summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ssl
Commit message (Collapse)AuthorAgeFilesLines
* Mac client-side SSL cert improvements.snej@chromium.org2010-02-241-0/+4
| | | | | | | | | | | Allow Netscape-style client certs. Remember which identity the user chooses for a domain, and put it at the top of the list next time. BUG=36316,36446 TEST=none Review URL: http://codereview.chromium.org/651090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39904 0039d316-1c4b-4281-b951-d872f2087c98
* Make the translation bar not show up again when you closed it in a page jcampan@chromium.org2010-02-231-5/+0
| | | | | | | | | | | | | | | | | | | | | | | and navigate in page. This is the case with web apps like GMail where many actions result in an in-page navigation. It would originally bring back the translation infobar, which is very anoying. This CL fixes the is_in_page state of LoadCommittedDetails, it was always false. This triggered a bug in the SSLManager that was wrongly not setting the SSL states when an in-page navigation is performed. Since we create a new navigation entry for in-page navigations, not setting these states would make a bad page being reported as OK after an in-page navigation. See original review: http://codereview.chromium.org/650146/show BUG=36304 TEST=Login to gmail, change the GMail language to a language different than the Chrome language. When a translate infobar shows up, close it. Click on the different links in GMail (inbox, drafts, select email...) the translate infobar should not show again. Review URL: http://codereview.chromium.org/650207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39700 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-194-4/+4
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* Client-side SSL cert support for Mac.snej@chromium.org2010-02-185-48/+139
| | | | | | | | | | This includes sending an existing identity cert, and asking the user which cert to use. Doesn't yet handle SSL renegotiation, or key-gen. BUG=16831 TEST=none Review URL: http://codereview.chromium.org/604067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39389 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2010-02-091-0/+1
| | | | | | | | | BUG=none TEST=If it compiles it is perfect. Review URL: http://codereview.chromium.org/585008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38463 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup histogram classes mixing SetFlags into FactoryGet argumentsjar@chromium.org2009-12-281-5/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Generic cleanup of histogram class, renaming *FactoryGet to FactoryGet, along with reformatting. The macros were cleaned up to use common sub-macros rather than repeating code as much. Removed ThreadSafeHistogram (and associated ASSET_HISTOGRAM macros) since this class was not getting used. I introduced UMA_HISTOGRAM_ENUMERATION to support the common use of LinearHistograms to count various enumerated values. I added a Flags argument to all the FactoryGet routines to help avoid needing to call SetFlags each time a new sample is Add()ed. This also simplifies the code. This will all help prepare for a "don't histogram at all" macro setting so that I can test the impact of the histogram macro calls on performance (since there are now so many active histograms). BUG=31206 r=raman.tenneti Review URL: http://codereview.chromium.org/515033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35295 0039d316-1c4b-4281-b951-d872f2087c98
* Implement ResourceQueue, an object that makes it easy to delay startingphajdan.jr@chromium.org2009-12-102-2/+4
| | | | | | | | | | | | | | | requests in ResourceDispatcherHost until specified conditions are met. Make UserScriptListener use ResourceQueue. This is the first step toward waiting for the privacy blacklists to load. TEST=Covered by unit_tests. BUG=21541 Review URL: http://codereview.chromium.org/460108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34271 0039d316-1c4b-4281-b951-d872f2087c98
* Marking test as flaky since it is failing in release >50% of the time now.thomasvl@chromium.org2009-12-101-3/+8
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/489003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34253 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Browser_tests workthomasvl@chromium.org2009-12-081-1/+1
| | | | | | | | | | | | | | | | - Drop the GYP variables that were only used in one place (the indirection seems more complicated then helpful) - don't bother with a conditional for breakpad_mac_stubs (1/2 of the file didn't since the excludes handle it) - Continue bring browser_tests stuff online: - extension_browsertest support for other tests - TaskManagerBrowserTest passes - SSLUITest passes - BlacklistManagerBrowserTest passes BUG=none TEST=tests show up on the waterfall/trybot and pass. Review URL: http://codereview.chromium.org/467046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34059 0039d316-1c4b-4281-b951-d872f2087c98
* Use factory to create histograms, and refcounts to track lifetimesjar@chromium.org2009-12-061-3/+5
| | | | | | | | | | | | | | | This is CL patch 377028 by Raman Tenneti, with minor changes to make the try-bots happier. It is cleanup that better ensures lifetimes of histograms (making it harder for users to abuse them). bug=16495 (repairs leak induced by the first landing) bug=18840 (should make leaks less possible) tbr=raman.tenneti Review URL: http://codereview.chromium.org/462027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33933 0039d316-1c4b-4281-b951-d872f2087c98
* Fix null-pointer crash.abarth@chromium.org2009-12-051-0/+3
| | | | | | | | BUG=29444 Review URL: http://codereview.chromium.org/469001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33914 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-301-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33301 and 33305 due to unit_tests breakage.maruel@chromium.org2009-11-301-1/+1
| | | | | | | | TBR=pawel Review URL: http://codereview.chromium.org/453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-301-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
* Flaky tests on linux/view/64bit builds.oshima@chromium.org2009-11-251-10/+8
| | | | | | | | | | | Also updated browser_tests to use #define instead of #if/else, like other tests. BUG=28808 TEST=None Review URL: http://codereview.chromium.org/442012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33137 0039d316-1c4b-4281-b951-d872f2087c98
* Moving two tests to FLAKY tests.oshima@chromium.org2009-11-251-3/+8
| | | | | | | | | | | | TestHTTPSErrorWithNoNavEntry: fails differently on 32 and 64 bits due to timing issue. (We thought it's deterinistic, but this is apparently not) FindDisappearOnNavigate: due to asynchronous-ness on x11. BUG=28629,28098 TEST=build and run browser_tests in 64bit. Review URL: http://codereview.chromium.org/438010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33068 0039d316-1c4b-4281-b951-d872f2087c98
* This is a temp hack to get SSLUITest.TestHTTPErrorWithNoNavEntry working on ↵oshima@chromium.org2009-11-181-0/+5
| | | | | | | | | | | | | linux/views. see http://crbug/28098 for more details about the root cause of the issue. BUG=28098 TEST=brower_tests passes with this hack, but we need real solution. Review URL: http://codereview.chromium.org/397037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32381 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-132-8/+8
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* Upstreaming WebKit.gypyaar@chromium.org2009-11-121-1/+1
| | | | | | | | | | | | This mega patch contains a few simple but tightly dependent changes: 1. Deletion of webkit/api/WebKit.gyp. The file now lives in webkit.org. 2. Rename of webkit/webkit.gyp to webkit/webkit_glue.gyp. Having two webkit.gyp was a source of developer confusion. 3. Gyp dependencies are updated across chromium to point at the upstream WebKit.gyp and the renamed webkit_glue.gyp. 4. Some 200+ files include paths fixed to point to third_party/WebKit/WebKit/chromium instead of webkit/api. The later will be deleted in a subsequent patch. Review URL: http://codereview.chromium.org/387020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31749 0039d316-1c4b-4281-b951-d872f2087c98
* A large number of style nits in preparation for turning on automated cpplint.py.erg@google.com2009-11-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/385023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31669 0039d316-1c4b-4281-b951-d872f2087c98
* Ninth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-074-3/+14
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/372013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31357 0039d316-1c4b-4281-b951-d872f2087c98
* Fifth patch in getting rid of caching MessageLoop pointers.jam@chromium.org2009-11-038-69/+54
| | | | | | | BUG=25354 Review URL: http://codereview.chromium.org/345037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30790 0039d316-1c4b-4281-b951-d872f2087c98
* Degrade the https color and lock icon for the page that has a worker that ↵dimich@google.com2009-10-191-40/+90
| | | | | | | | | | | loads subresource with bad cert. The idea is to make UI reflect loading of resources with bad certificates that were previously approved by the user. bug=20176 TEST=SSLUITest.TestUnsafeContentsInWorker unit_test. Review URL: http://codereview.chromium.org/268006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29461 0039d316-1c4b-4281-b951-d872f2087c98
* Always ASSERT that created servers are non-NULL (since creation can fail). ↵pkasting@chromium.org2009-10-131-1/+44
| | | | | | | | | | | Blindly dereferencing NULL pointers in a unittest causes the test harness to crash. BUG=none TEST=none TBR=jcampan Review URL: http://codereview.chromium.org/270088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28862 0039d316-1c4b-4281-b951-d872f2087c98
* Header dependency cleanup in chrome/phajdan.jr@chromium.org2009-10-122-0/+3
| | | | | | | | | | | | - reduce header dependencies - remove things that shouldn't be #included in a header, like string_util.h and theme_resources.h! TEST=none BUG=none Review URL: http://codereview.chromium.org/245011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28705 0039d316-1c4b-4281-b951-d872f2087c98
* Update the SSLClientAuthHandler to use the thread safe reference counter.mbelshe@google.com2009-10-091-1/+2
| | | | | | | | | | | It does get invoked both on the ui and io threads. BUG=none TEST=none Review URL: http://codereview.chromium.org/267028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28498 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old way of handling mixed content now that we have the new mixed contentabarth@chromium.org2009-09-2911-344/+18
| | | | | | | | | | | API in place. R=agl TEST=Covered by our mixed content browser tests Review URL: http://codereview.chromium.org/248013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27469 0039d316-1c4b-4281-b951-d872f2087c98
* Update our mixed content state with information from the new mixed contentabarth@chromium.org2009-09-265-1/+31
| | | | | | | | | | | APIs. This change is purely additive. I'll rip out the old mechanism in the next patch. R=agl Review URL: http://codereview.chromium.org/243012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27323 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds a test to insure we are not regressing on http://crbug.com/19941jcampan@chromium.org2009-09-151-0/+37
| | | | | | | | | | | We would crash when an SSL error would happen on a page with no navigation entry. TEST=Run the test. BUG=http://crbug.com/19941 Review URL: http://codereview.chromium.org/196115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26224 0039d316-1c4b-4281-b951-d872f2087c98
* The SSL policy when showing an error page sets the page type on the wrong ↵jcampan@chromium.org2009-09-121-2/+6
| | | | | | | | | | | | | navigation entry, which can potentially be NULL causing a crasher. Disabling the setting of page type for the error page, since it is not used. BUG=http://crbug.com/19941 TEST=See steps in the bug. Review URL: http://codereview.chromium.org/193063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26056 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringPiece into the base namespace. It is collidingtony@chromium.org2009-09-102-2/+2
| | | | | | | | | | with the StringPiece class in icu4.2, which is a problem when trying to use the system version of icu. Review URL: http://codereview.chromium.org/193072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25920 0039d316-1c4b-4281-b951-d872f2087c98
* Rename X-Force-TLS to Strict-Transport-Security.abarth@chromium.org2009-09-053-22/+2
| | | | | | | | | | | Also, remove StrictTransportSecurity code from SSLPolicy because that code doesn't work. R=agl Review URL: http://codereview.chromium.org/198035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25577 0039d316-1c4b-4281-b951-d872f2087c98
* Split ExtraRequestInfo out of ResourceDispatcherHost so it isn't cluttering upbrettw@chromium.org2009-09-022-21/+22
| | | | | | | | | | | that header file. I added documentation and split out the accessors according to Google-style. BUG=none TEST=none Review URL: http://codereview.chromium.org/179046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25133 0039d316-1c4b-4281-b951-d872f2087c98
* Replace the RenderProcessHost.PID function that returns the OS-generatedbrettw@chromium.org2009-08-316-16/+18
| | | | | | | | | | | | | | | | | | | | process ID with an internally-generated id() function. This allows us the guarantee that the IDs are unique over the entire run of the application. This also cleans up some code associated with managing the PID. The main potentially interesting change is now the PID is set uniquely for every creation of RenderProcessHost. It used to be set cleared if the process went away, and re-set if the process was re-created. The ID generation is in ChildProcesInfo so it is also unique between workers and plugins. I had to change some significant things in resource_dispatcher_host_unittest to take into account this new generation of IDs. BUG=17828 TEST=none Review URL: http://codereview.chromium.org/160203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24899 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-282-6/+2
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-282-2/+6
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* Add new certificate error codewtc@chromium.org2009-08-143-8/+28
| | | | | | | | | | | | | | | | | | ERR_CERT_WEAK_SIGNATURE_ALGORITHM and certificate status flag CERT_STATUS_WEAK_SIGNATURE_ALGORITHM. Note that I didn't add new load flag LOAD_IGNORE_CERT_WEAK_SIGNATURE_ALGORITHM. Allow users to accept MD2 certificates as certificates signed using a weak signature algorithm. MD4 certificates are still treated as invalid certificates. R=jar,jcampan BUG=http://crbug.com/18725 TEST=none Review URL: http://codereview.chromium.org/165504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23497 0039d316-1c4b-4281-b951-d872f2087c98
* Disable SSLUITest.TestGoodFrameNavigation as it seems to be flaky.hamaji@chromium.org2009-08-061-1/+1
| | | | | | | | | | BUG=18626 TEST=none TBR=jcampan Review URL: http://codereview.chromium.org/165047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22602 0039d316-1c4b-4281-b951-d872f2087c98
* This provides a simpler js template engine than JsTemplate. It has beenarv@google.com2009-07-142-3/+3
| | | | | | | | | | | | | | | | | | optimized for the way we do internationalization with JST before and is about 4 times faster (average 4.8ms vs 22.8ms) for the history page. The syntax for this is very similar to JsTemplates. It uses the attributes i18n-values and i18n-content which worls like jsvalues and jscontent except that it does not allow arbitrary expressions. BUG=None TEST=All UI pages should work as before Review URL: http://codereview.chromium.org/149420 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20590 0039d316-1c4b-4281-b951-d872f2087c98
* The SSL UI tests are only run on Windows today.jcampan@chromium.org2009-07-081-1021/+0
| | | | | | | | | | Since they have been ported to the browser tests framework, they are not required anymore. BUG=None TEST=None Review URL: http://codereview.chromium.org/155224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20174 0039d316-1c4b-4281-b951-d872f2087c98
* Add an ExtensionBrowserTest base class that allows in-process browser tests ↵aa@chromium.org2009-07-041-17/+22
| | | | | | | | of extensions using ExtensionsService directly, rather than TestExtensionLoaded. Use it to re-enable some old browser tests that had been disabled. Review URL: http://codereview.chromium.org/150213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19930 0039d316-1c4b-4281-b951-d872f2087c98
* Move GetTabContentsID out of tab util because it has nothing to do with tabs orbrettw@chromium.org2009-06-301-3/+4
| | | | | | | | | | | | TabContents. I put a more accurately named static function in ResourceDispatcherHost which is what really controls this request data. I also moved a couple of static functions from the header to the cc in resource_dispatcher. Review URL: http://codereview.chromium.org/150124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19675 0039d316-1c4b-4281-b951-d872f2087c98
* A first implementation of the SSL client auth UI.This uses the Windows API ↵jcampan@chromium.org2009-06-272-0/+160
| | | | | | | | that prompts the user for a cert.R=wtcBUG=http://crbug.com/318TEST=Visit a site that requires client auth. A dialog to select a certificate should be shown. Try selecting no cert. Try again this time select a cert. Review URL: http://codereview.chromium.org/147233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19456 0039d316-1c4b-4281-b951-d872f2087c98
* Simple clean-up of the ssl_manager.h includes.jcampan@chromium.org2009-06-261-20/+5
| | | | | | | | | R=wtc BUG=None TEST=None Review URL: http://codereview.chromium.org/147234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19442 0039d316-1c4b-4281-b951-d872f2087c98
* On Linux, the path to the exe is used to fork renderer processes.jcampan@chromium.org2009-06-251-15/+0
| | | | | | | | | | | This was causing the browser tests to create browser tests instead of a renderer processes. Also the SSL tests now pass on Linux and have been enabled. BUG=None TEST=Run the browser tests on Linux. Review URL: http://codereview.chromium.org/146057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19257 0039d316-1c4b-4281-b951-d872f2087c98
* Removing a now irrelevant browser test and disabling 2 failing ones (in ↵jcampan@chromium.org2009-06-231-56/+7
| | | | | | | | | | order to be able to run browser tests on the main build bots). BUG=None TEST=Run the SSL browser tests Review URL: http://codereview.chromium.org/146039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19038 0039d316-1c4b-4281-b951-d872f2087c98
* Move socket related files from net/base to net/socket.willchan@chromium.org2009-06-221-1/+1
| | | | | | Review URL: http://codereview.chromium.org/144009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18985 0039d316-1c4b-4281-b951-d872f2087c98
* Removed mixed content options. Turns out extremely few users changed the ↵abarth@chromium.org2009-06-162-70/+1
| | | | | | | | | | | | default. R=beng BUG=None TEST=Go to options dialog and notice that the mixed content option is gone. Review URL: http://codereview.chromium.org/126106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18479 0039d316-1c4b-4281-b951-d872f2087c98
* Porting the browser tests to Unix.jcampan@chromium.org2009-06-051-4/+18
| | | | | | | | | | | | | The browser tests are an alternative to UI tests. They provide a way to exercise the browser from within the test (without having the test and the browser running in different processes). In order to ensure atexit hanlders are run after each tests and static initializers start fresh for each test, each test is run in a new process (on Linux and Mac). On Windows, a DLL containing the test is loaded/unloaded for each tests. BUG=None TEST=Run the browser tests. Review URL: http://codereview.chromium.org/115896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17781 0039d316-1c4b-4281-b951-d872f2087c98
* Headers cleanup in chrome/browser/phajdan.jr@chromium.org2009-06-033-0/+3
| | | | | | | | | | | - reduce header dependencies - miscellanous cleanups (add missing includes for OS_ defines etc) Further changesets may follow. I was only looking at header files up to character_encoding.h. Review URL: http://codereview.chromium.org/118072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17470 0039d316-1c4b-4281-b951-d872f2087c98