summaryrefslogtreecommitdiffstats
path: root/chrome/browser/sync/engine/syncer_thread.cc
Commit message (Collapse)AuthorAgeFilesLines
* [Sync] Combine sync thread and sync core thread.akalin@chromium.org2011-06-141-896/+0
| | | | | | | | | | | | | | | | Rename SyncerThread to SyncerScheduler and its owned thread; it is now a (mostly) non-thread-safe class which schedules events on the message loop it was created on. Rename core_thread_ in SyncBackendHost to sync_thread_ (and associated variables). BUG=79174 TEST= Review URL: http://codereview.chromium.org/6995097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88976 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Clean up sync loggingakalin@chromium.org2011-06-081-87/+79
| | | | | | | | | | | | | | | | Add GetDebugName() method to Profile. Use it in ProfileSyncServiceHarness, SyncerThread, and LiveSyncExtensionHelper. Change VLOG(1)s in SyncerThread to VLOG(2)s. Turn on logging for the test server if VLOG is enabled for that file, and not just in general. BUG= TEST= Review URL: http://codereview.chromium.org/7024058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88355 0039d316-1c4b-4281-b951-d872f2087c98
* Removing some unncessary logging statements.lipalani@chromium.org2011-05-121-3/+3
| | | | | | | | | BUG=80706 TEST= Review URL: http://codereview.chromium.org/7016009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85160 0039d316-1c4b-4281-b951-d872f2087c98
* fix the flakiness caused by passing a linked ptointer across threads.lipalani@chromium.org2011-05-071-5/+8
| | | | | | | | | BUG=81256 TEST=sync_integration_tests.exe Review URL: http://codereview.chromium.org/6956014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84537 0039d316-1c4b-4281-b951-d872f2087c98
* Add extra logging to prove a theory for the race condition in bug 81256.lipalani@chromium.org2011-05-051-2/+6
| | | | | | | | | BUG=80706 TEST= Review URL: http://codereview.chromium.org/6932049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84313 0039d316-1c4b-4281-b951-d872f2087c98
* Update the source for config requests.lipalani@chromium.org2011-05-051-2/+17
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/6904147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84206 0039d316-1c4b-4281-b951-d872f2087c98
* Increasing the chance of the race condition bug to occur by disabling ↵lipalani@chromium.org2011-05-051-1/+1
| | | | | | | | | | | | | | | | | logging. VLOG(0) is used only in conditions that are guaranteed to trigger this bug. Other places are now VLOG(1). There are 2 VLOG(0) that will still print in normal scenario. They are: 1. SyncShare is about to be called. 2. DTM is informing sync configure is done. I think the above 2 cases are after the bug, meaning the bug happens before either of the above 2 conditions are hit. This will prove that or disprove it. BUG= TEST= Review URL: http://codereview.chromium.org/6933018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84194 0039d316-1c4b-4281-b951-d872f2087c98
* Add more debug logging to trace a race condition.lipalani@chromium.org2011-05-041-0/+2
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/6907023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84021 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 83792 - Add DCHECKS to ensure syncer thread methods are called from ↵lipalani@chromium.org2011-05-021-13/+3
| | | | | | | | | | | | | | the right thread. BUG= TEST= Review URL: http://codereview.chromium.org/6898035 TBR=lipalani@chromium.org Review URL: http://codereview.chromium.org/6907005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83798 0039d316-1c4b-4281-b951-d872f2087c98
* Add DCHECKS to ensure syncer thread methods are called from the right thread.lipalani@chromium.org2011-05-021-3/+13
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/6898035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83792 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all TODO(tim):deprcecated and clean up all the remnants of syncer ↵lipalani@chromium.org2011-04-291-1/+1
| | | | | | | | | | | thread2. BUG= TEST= Review URL: http://codereview.chromium.org/6883210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83485 0039d316-1c4b-4281-b951-d872f2087c98
* Purge disabled datatypes in syncer thread.lipalani@chromium.org2011-04-221-1/+8
| | | | | | | | | | | BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82578 Review URL: http://codereview.chromium.org/6873147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82604 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82578 - Purge disabled datatypes in syncer thread.BUG=TEST=Review ↵lipalani@chromium.org2011-04-221-8/+1
| | | | | | | | | URL: http://codereview.chromium.org/6873147 TBR=lipalani@chromium.org Review URL: http://codereview.chromium.org/6880129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82586 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak by moving the creation of the object close the call for ↵lipalani@chromium.org2011-04-211-6/+5
| | | | | | | | | | | making the lined pointer. BUG=79568 TEST= Review URL: http://codereview.chromium.org/6880021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82580 0039d316-1c4b-4281-b951-d872f2087c98
* Purge disabled datatypes in syncer thread.lipalani@chromium.org2011-04-211-1/+8
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/6873147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82578 0039d316-1c4b-4281-b951-d872f2087c98
* The passive worker was being added to the session once per datatype. Fix it ↵lipalani@chromium.org2011-04-211-7/+19
| | | | | | | | | | | so it gets added only once so we dont do extra processing. BUG=80049 TEST= Review URL: http://codereview.chromium.org/6880082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82411 0039d316-1c4b-4281-b951-d872f2087c98
* 1. Fix a bug in which scheduleconfig was called from wrong thread.lipalani@chromium.org2011-04-201-2/+1
| | | | | | | | | | | 2. Always put the syncer in config mode before doing model associations. BUG=79971 TEST= Review URL: http://codereview.chromium.org/6883073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82235 0039d316-1c4b-4281-b951-d872f2087c98
* sync: add a BackendMigrator class to perform migration flow.tim@chromium.org2011-04-201-1/+4
| | | | | | | | | | | The rest of the change (more innocent than it looks) is mostly callback plumbing to make the long trek from SyncerProtoUtil up to ProfileSyncService. BUG=79247 TEST=BackendMigratorTest Review URL: http://codereview.chromium.org/6858002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82215 0039d316-1c4b-4281-b951-d872f2087c98
* make new syncer thread the default. Fixed all the test cases that failed.lipalani@chromium.org2011-04-191-742/+707
| | | | | | | | | | | | | | | | | BUG=26339 TEST=unit_tests.exe, sync_integration_tests.exe, sync_unit_tests.exe. manual testcases: 1. Set up a brand new profile to sync and make sure it syncs. 2. enable/disable a datatype and make sure it syncs. 3. Make change to a datatype locally and make sure it gets propagated. 4. make change to a datatype remotely and make sure it syncs down. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82026 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82067 Review URL: http://codereview.chromium.org/6874018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82150 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82067 - make new syncer thread the default. Fixed all the test cases ↵lipalani@chromium.org2011-04-191-707/+742
| | | | | | | | | that failed.BUG=26339TEST=unit_tests.exe, sync_integration_tests.exe, sync_unit_tests.exe. manual testcases:1. Set up a brand new profile to sync and make sure it syncs.2. enable/disable a datatype and make sure it syncs.3. Make change to a datatype locally and make sure it gets propagated.4. make change to a datatype remotely and make sure it syncs down.Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82026Review URL: http://codereview.chromium.org/6874018 TBR=lipalani@chromium.org Review URL: http://codereview.chromium.org/6883037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82073 0039d316-1c4b-4281-b951-d872f2087c98
* make new syncer thread the default. Fixed all the test cases that failed.lipalani@chromium.org2011-04-191-742/+707
| | | | | | | | | | | | | | | BUG=26339 TEST=unit_tests.exe, sync_integration_tests.exe, sync_unit_tests.exe. manual testcases: 1. Set up a brand new profile to sync and make sure it syncs. 2. enable/disable a datatype and make sure it syncs. 3. Make change to a datatype locally and make sure it gets propagated. 4. make change to a datatype remotely and make sure it syncs down. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82026 Review URL: http://codereview.chromium.org/6874018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82067 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82026 - make new syncer thread the default. Fixed all the test cases ↵lipalani@chromium.org2011-04-191-707/+742
| | | | | | | | | that failed.BUG=26339TEST=unit_tests.exe, sync_integration_tests.exe, sync_unit_tests.exe. manual testcases:1. Set up a brand new profile to sync and make sure it syncs.2. enable/disable a datatype and make sure it syncs.3. Make change to a datatype locally and make sure it gets propagated.4. make change to a datatype remotely and make sure it syncs down.Review URL: http://codereview.chromium.org/6874018 TBR=lipalani@chromium.org Review URL: http://codereview.chromium.org/6877027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82040 0039d316-1c4b-4281-b951-d872f2087c98
* make new syncer thread the default. Fixed all the test cases that failed.lipalani@chromium.org2011-04-181-742/+707
| | | | | | | | | | | | | BUG=26339 TEST=unit_tests.exe, sync_integration_tests.exe, sync_unit_tests.exe. manual testcases: 1. Set up a brand new profile to sync and make sure it syncs. 2. enable/disable a datatype and make sure it syncs. 3. Make change to a datatype locally and make sure it gets propagated. 4. make change to a datatype remotely and make sure it syncs down. Review URL: http://codereview.chromium.org/6874018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82026 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Move TypePayloadMap into its own fileakalin@chromium.org2011-03-221-16/+16
| | | | | | | | | | | Also rename it to ModelTypePayloadMap. BUG=None TEST= Review URL: http://codereview.chromium.org/6718024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79046 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor sync notifier out of sync apiakalin@chromium.org2011-03-141-1/+0
| | | | | | | | | | | | | | | We now have a clearly defined interface for notifier. Old p2p notifications are still used by tests. Original patch by nileshagrawal@google.com. BUG=75831 TEST= Review URL: http://codereview.chromium.org/6683015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78007 0039d316-1c4b-4281-b951-d872f2087c98
* sync: add switch for using new syncer thread.tim@chromium.org2011-03-031-1/+0
| | | | | | | | | | | | Also adds SyncerThreadAdapter (temp code) to facilitate swapping between implementations without tearing syncapi apart. BUG=26339 TEST=unit_tests, sync_unit_tests Review URL: http://codereview.chromium.org/6576049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76756 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup everything but net/ for our first clang plugins.erg@google.com2011-02-021-0/+10
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6250088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73396 0039d316-1c4b-4281-b951-d872f2087c98
* Recommit attempt for rev 72685.zea@chromium.org2011-01-271-20/+56
| | | | | | | | | | | [SYNC] Refactor SyncSourceInfo and add support in chrome invalidation client and syncer thread for passing a datatype-specific payload originating in the invalidation server and directed at the sync frontend server. Also fixes bug with last_sync_time and PostTimeToTypeHistogram, which would get hit when the unit tests were being run. BUG=68572, 69558 TEST=unit Review URL: http://codereview.chromium.org/6313018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72891 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 72685 - [SYNC] Refactor SyncSourceInfo and add support in chrome ↵zea@chromium.org2011-01-261-56/+20
| | | | | | | | | | | | | invalidation client and syncer thread for passing a datatype-specific payload originating in the invalidation server and directed at the sync frontend server. Also fixes bug with last_sync_time and PostTimeToTypeHistogram, which would get hit when the unit tests were being run. BUG=68572,69558 TEST=unit Review URL: http://codereview.chromium.org/6182004 TBR=zea@chromium.org Review URL: http://codereview.chromium.org/6270006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72687 0039d316-1c4b-4281-b951-d872f2087c98
* [SYNC] Refactor SyncSourceInfo and add support in chrome invalidation client ↵zea@chromium.org2011-01-261-20/+56
| | | | | | | | | | and syncer thread for passing a datatype-specific payload originating in the invalidation server and directed at the sync frontend server. Also fixes bug with last_sync_time and PostTimeToTypeHistogram, which would get hit when the unit tests were being run. BUG=68572,69558 TEST=unit Review URL: http://codereview.chromium.org/6182004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72685 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-211-1/+1
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* The sync server supports a new "progress token" scheme that allows data ↵nick@chromium.org2011-01-131-2/+2
| | | | | | | | | | | | | | | | types to be requested with a different timestamp per datatype. The benefits of this approach are: - timestamps become opaque to the client, which makes - the client no longer has to rely on timestamps converging for all datatypes. - the server will send fewer redundant updates after enabling a new datatype. - the flexibility of the opaque field allows the server to implement other optimizations which will increase scalability & performance BUG=58217 TEST=manual test of sync (old profile+new profile), unit tests, integ tests Review URL: http://codereview.chromium.org/6104003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71357 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of chrome_switches.h.thestig@chromium.org2011-01-111-9/+8
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6086003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70978 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/lock and base/condition_variable to base/synchronization/brettw@chromium.org2011-01-011-11/+11
| | | | | | | | | | | I kept a base/lock.h in place with a using statement to avoid updating all callers in one CL. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6018013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70363 0039d316-1c4b-4281-b951-d872f2087c98
* Even more virtual method deinlining.erg@google.com2010-12-131-0/+20
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5741001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69041 0039d316-1c4b-4281-b951-d872f2087c98
* sync: Make SyncSession take most of its required state at construction time.tim@chromium.org2010-11-241-21/+46
| | | | | | | | | | | | This is more prep for the MessageLoop based SyncerThread. Somewhat subtle: previously, if HasMoreToSync returned true, we'd grab a fresh copy of routing_info and workers for the next session, but now we hold the data constant, which I think is more sane. BUG=26339, 64136 TEST=sync_unit_tests, sync_integration_tests Review URL: http://codereview.chromium.org/5307001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67334 0039d316-1c4b-4281-b951-d872f2087c98
* sync: union model type nudge source before dropping coalesced nudge.tim@chromium.org2010-11-181-15/+17
| | | | | | | | | | Also, clear nudge_types in UpdateNudgeSource along with the other pending_nudge state, so that we don't accidentally bleed data pertaining to a nudge that comes in while a sync is in progress into the histogram record for that sync. BUG=none TEST=SyncerThreadWithSyncerTest Review URL: http://codereview.chromium.org/5145006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66684 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 66513 - sync: remove event_sys from ServerConnectionManager and ↵tim@chromium.org2010-11-181-41/+42
| | | | | | | | | | | | | | SyncerThread BUG=26339 TEST=sync_unit_tests Review URL: http://codereview.chromium.org/5125001 TBR=tim@chromium.org Review URL: http://codereview.chromium.org/5228002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66675 0039d316-1c4b-4281-b951-d872f2087c98
* sync: remove event_sys from ServerConnectionManager and SyncerThreadtim@chromium.org2010-11-171-42/+41
| | | | | | | | | BUG=26339 TEST=sync_unit_tests Review URL: http://codereview.chromium.org/5125001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66513 0039d316-1c4b-4281-b951-d872f2087c98
* Sync: Fix RequestResume in SyncerThread, and re-enable the various unit testszea@chromium.org2010-11-171-1/+2
| | | | | | | | | | | that were breaking. BUG=62880,39070,62880 TEST=sync_unit_tests Review URL: http://codereview.chromium.org/5047002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66507 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb datatype information to syncer from nudges.zea@chromium.org2010-11-111-6/+44
| | | | | | | | | | | | Add plumbing to support tracking which datatypes are triggering nudges. This gets plumbed from the nudges to the actual sync session. Also added some histogramming for the frequency at which particular datatypes trigger syncs (as a result, also supports tracking how often datatypes are changing). New histograms are of the form "Sync.Freq<datatype>", with bucket units in milliseconds. BUG=None TEST=unit_tests Review URL: http://codereview.chromium.org/4659003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65818 0039d316-1c4b-4281-b951-d872f2087c98
* Change miscellaneous LOG(INFO)s to VLOG()s that I missed the first time ↵pkasting@chromium.org2010-10-271-2/+2
| | | | | | | | | | | | through, either because they were LOG_IF() (which I didn't search for) or they were added during the week I was changing things. Plus a few misc. cleanup bits. BUG=none TEST=none Review URL: http://codereview.chromium.org/4111002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63998 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG/LOG_IF(INFO) to VLOG/VLOG_IF(1) - chrome/browser/syncrsimha@chromium.org2010-10-251-2/+2
| | | | | | | | | | | Continuing the work done in http://codereview.chromium.org/4001002/show. BUG=none TEST=none Review URL: http://codereview.chromium.org/4096002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63798 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - chrome/browser/sync/engine/.pkasting@chromium.org2010-10-211-52/+44
| | | | | | | | | | Also fix some line wrapping, remove some extra {}s, and remove "else" after "return". BUG=none TEST=none Review URL: http://codereview.chromium.org/4001002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63432 0039d316-1c4b-4281-b951-d872f2087c98
* sync: use ObserverList instead of EventChannel (deprecated) for syncer events.tim@chromium.org2010-10-111-39/+11
| | | | | | | | | | | | | | | Remove the relay_channel and syncer_event_channel in favor of having listeners live on the SyncSessionContext and be notified directly. Remove some unnecessary event types and variables. BUG=26339 TEST=sync_unit_tests Review URL: http://codereview.chromium.org/3538011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62187 0039d316-1c4b-4281-b951-d872f2087c98
* Replaced sync thread nudge queue with a single pending nudge.akalin@chromium.org2010-09-141-10/+22
| | | | | | | | | | | This partially fixes a high QPS issue we're seeing with notifications. BUG=55279 TEST=Manually Review URL: http://codereview.chromium.org/3410002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59336 0039d316-1c4b-4281-b951-d872f2087c98
* 2nd attempt at http://codereview.chromium.org/3305003/showjohnnyg@chromium.org2010-09-091-26/+12
| | | | | | | | | | | | | | | | | | The difference between this patch and the other one is plumbing setup_in_test_mode through the Initialization process, rather than using a separate SetupInTestMode() method, which happens too late to safely stop the syncer thread. [see syncapi.cc|h for most of the changes.] --- This patch removes: authenticator.cc, auth_watcher.cc removes calls to user_settings.cc, removes an authenticate PB request to the server, and moves token storage into the Chrome TokenService. This patch introduces the SigninManager, which is an interim solution for user management prior to moving the system into chrome. Other changes include removing the dependency on the sync backend to be running while the sync wizard is intially displayed. This means that the backend can be brought up in response to credentials becoming available. The backend now is always provided credentials on startup. If an auth error occurs, it propogates it up via a notification. Some event handlers were removed and streamlined for more straightforward sync system startup. BUG=51001, 50293, 35158 TEST=Unit tests && Start up sync, log in, log out, run with expired credentials, run with new gaia credentials, run with gaia credentials updated while system is syncing. Try logging in with incorrect username. Trigger CAPTCHA. Try logging out and in repeatedly. Check about:sync works. Try going offline and back online again. Expire gaia credentials and try renewing it with the UI dialog. Review URL: http://codereview.chromium.org/3342025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58993 0039d316-1c4b-4281-b951-d872f2087c98
* Implements the backend for clearing data from the servertim@chromium.org2010-09-081-0/+3
| | | | | | | | | | | | BUG=54280 TEST=accessible only via unit test checked in this CL Original patch by raz@chromium.org Original review: http://codereview.chromium.org/3293007 Review URL: http://codereview.chromium.org/3310018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58859 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58778 - New authorization framework for sync. johnnyg@chromium.org2010-09-081-12/+26
| | | | | | | | | | | | | | | | | | | | | To quote chron's original patch (http://codereview.chromium.org/3148036/show) <blockquote> This patch removes: authenticator.cc, auth_watcher.cc removes calls to user_settings.cc, removes an authenticate PB request to the server, and moves token storage into the Chrome TokenService. This patch introduces the SigninManager, which is an interim solution for user management prior to moving the system into chrome. Other changes include removing the dependency on the sync backend to be running while the sync wizard is intially displayed. This means that the backend can be brought up in response to credentials becoming available. The backend now is always provided credentials on startup. If an auth error occurs, it propogates it up via a notification. Some event handlers were removed and streamlined for more straightforward sync system startup. </blockquote> BUG=51001, 50293, 35158 TEST=Unit tests && Start up sync, log in, log out, run with expired credentials, run with new gaia credentials, run with gaia credentials updated while system is syncing. Try logging in with incorrect username. Trigger CAPTCHA. Try logging out and in repeatedly. Check about:sync works. Try going offline and back online again. Expire gaia credentials and try renewing it with the UI dialog. Review URL: http://codereview.chromium.org/3305003 TBR=johnnyg@chromium.org Review URL: http://codereview.chromium.org/3310019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58782 0039d316-1c4b-4281-b951-d872f2087c98
* New authorization framework for sync. johnnyg@chromium.org2010-09-081-26/+12
| | | | | | | | | | | | | | | | | | To quote chron's original patch (http://codereview.chromium.org/3148036/show) <blockquote> This patch removes: authenticator.cc, auth_watcher.cc removes calls to user_settings.cc, removes an authenticate PB request to the server, and moves token storage into the Chrome TokenService. This patch introduces the SigninManager, which is an interim solution for user management prior to moving the system into chrome. Other changes include removing the dependency on the sync backend to be running while the sync wizard is intially displayed. This means that the backend can be brought up in response to credentials becoming available. The backend now is always provided credentials on startup. If an auth error occurs, it propogates it up via a notification. Some event handlers were removed and streamlined for more straightforward sync system startup. </blockquote> BUG=51001, 50293, 35158 TEST=Unit tests && Start up sync, log in, log out, run with expired credentials, run with new gaia credentials, run with gaia credentials updated while system is syncing. Try logging in with incorrect username. Trigger CAPTCHA. Try logging out and in repeatedly. Check about:sync works. Try going offline and back online again. Expire gaia credentials and try renewing it with the UI dialog. Review URL: http://codereview.chromium.org/3305003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58778 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 08:40:43 +0000