summaryrefslogtreecommitdiffstats
path: root/chrome/browser/sync/glue/change_processor.cc
Commit message (Collapse)AuthorAgeFilesLines
* AutofillDataTypeController should invoke start callback on abort. Also ↵skrul@chromium.org2010-04-151-1/+1
| | | | | | | | | | | gracefully handle stopping the data type startup while waiting for the PDM, WDS, and association. BUG=41361 TEST=unittest Review URL: http://codereview.chromium.org/1513034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44660 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44504 - AutofillDataTypeController should invoke start callback on abort.skrul@chromium.org2010-04-141-1/+1
| | | | | | | | | | | BUG=41361 Review URL: http://codereview.chromium.org/1513034 TBR=skrul@chromium.org Review URL: http://codereview.chromium.org/1564032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44506 0039d316-1c4b-4281-b951-d872f2087c98
* AutofillDataTypeController should invoke start callback on abort.skrul@chromium.org2010-04-141-1/+1
| | | | | | | | BUG=41361 Review URL: http://codereview.chromium.org/1513034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44504 0039d316-1c4b-4281-b951-d872f2087c98
* I refactored ChangeProcessor so that the common stuff can be reused by otheralbertb@google.com2009-12-141-523/+11
| | | | | | | | | | | | | | | | | | | | data types. For ModelAssociator, I just extracted an interface. There's probably more that can be reused, but I thought we would get to it once we know more about what kind of associations the other data types will require. In particular, I didn't use templates because none of the methods that ProfileSyncService calls on ModelAssociator require a data-type specific type. I didn't invest too much time refactoring the unit tests, so they're pretty hacky. I believe the right thing to do would be to test PSS, CP and MA seperately instead of having a giant PSS test that assumes we only care about bookmarks. BUG=29831,29832 TEST=Unit test Review URL: http://codereview.chromium.org/477007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34510 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-301-0/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33301 and 33305 due to unit_tests breakage.maruel@chromium.org2009-11-301-2/+0
| | | | | | | | TBR=pawel Review URL: http://codereview.chromium.org/453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-301-0/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash described in 27580 by telling bookmark model to removemunjal@chromium.org2009-11-131-1/+1
| | | | | | | | | | a node *after* disassocating from the maps. BUG=27580 Review URL: http://codereview.chromium.org/391056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31943 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 26141munjal@chromium.org2009-11-101-7/+6
| | | | | | | | | | | | - Change sync id to bookmark id map to sync id to bookmark node map - Make other appropriate changes. BUG=26141 TEST=Exist. Review URL: http://codereview.chromium.org/383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31597 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of string cleanup in Sync:munjal@chromium.org2009-11-061-10/+6
| | | | | | | | | | | | | | | | | | - Get rid of sync_char16 from syncapi - Use wstring for title in syncapi since that gets converted to wstring later on anyway. - Use GURL for urls in syncapi - Return const string references from syncapi instead of pointers to C-style strings. - Make appropriate changes to calling code. BUG=26342 TEST=Already exist. Review URL: http://codereview.chromium.org/362019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31298 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the browser_sync flag.zork@chromium.org2009-10-271-4/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/337034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30272 0039d316-1c4b-4281-b951-d872f2087c98
* Beef-up a DCHECK_NE case in browser_sync::ChangeProcessor to return early if ↵tim@chromium.org2009-10-191-4/+8
| | | | | | | | | | | | one of the permanent nodes are changed by a bookmark model event. I think we may hit a roadblock a bit deeper down right now and not actually poison the user's cloud state, but it seems best to catch this at first-chance. BUG=25067 Review URL: http://codereview.chromium.org/295007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29437 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CHROME_PERSONALIZATION to BROWSER_SYNC.nick@chromium.org2009-10-171-2/+2
| | | | | | | | | | Avoid #ifdef in general, favoring #if defined(). In one spot, use PlatformThread::Sleep instead of rolling our own. Review URL: http://codereview.chromium.org/267125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29360 0039d316-1c4b-4281-b951-d872f2087c98
* Makes canceling 'bookmark all tabs' delete the folder. Or rather,sky@chromium.org2009-10-161-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | makes it so that bookmark all tabs only creates the folder if the user presses ok. I wasn't happy adding another random arg to BookmarkEditor::Show, so I added in a structure an enum. This makes it clearer what Show should do. I also fixed the following: . On gtk we wouldn't always pick the right parent for nodes. . The context menu item is now enabled on views/gtk. And this now breaks the mac side. I'll straighten that out right after landing this. BUG=24367 TEST=Make sure 'bookmark all tabs' works, as well as the bookmark editor work. (get to the bookmark editor by creating a new bookmark, then clicking edit, or right clicking a bookmark on the bookmark bar and choosing edit). Review URL: http://codereview.chromium.org/271115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29343 0039d316-1c4b-4281-b951-d872f2087c98
* Move the JPEG and PNG codecs from base/gfx to app/gfx/codec. Move the classesbrettw@chromium.org2009-10-031-2/+2
| | | | | | | | | | | | | | | into the gfx namespace. Combine the PNGEncoder and PNGDecoder. There were separate when we had different executables for the browser and renderer, and linked the encoder only in one of them (which saved us some space used by libpng). This hasn't been the case for years, so combining them (again) makes sense. TEST=none BUG=none Review URL: http://codereview.chromium.org/243076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27930 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a FaviconService class tied to the profile.arv@google.com2009-08-281-3/+6
| | | | | | | | | | | | | | | | | | | Original issue: http://codereview.chromium.org/115212/show The favicons service is the entry point to getting favicons. Make the DOMUIFactory handle the favicons of DOMUI pages so since DOMUI pages are never added to the history. BUG=5840 TEST=Open a new window and open history and downloads (Ctrl+H and Ctrl+J) in this window. Then close the window and open the NTP. The recently closed windows/tabs should show the favicons for the hsitroy and downloads page. Review URL: http://codereview.chromium.org/178001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24806 0039d316-1c4b-4281-b951-d872f2087c98
* Move model operations from ProfileSyncService to ChangeProcessor.tim@chromium.org2009-08-181-0/+541
TEST=ProfileSyncServiceTest, sync integration tests Review URL: http://codereview.chromium.org/172040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23669 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-06 16:07:26 +0000