summaryrefslogtreecommitdiffstats
path: root/chrome/browser/sync/glue
Commit message (Collapse)AuthorAgeFilesLines
* Implement the gaia captcha state and unlock capability in the sync setup wizard.tim@chromium.org2009-11-122-6/+10
| | | | | | | | | | | BUG=19738 TEST=Get a Google Account into captcha state. Start syncing. You should be presented with a captcha image and textbox to answer the challenge. Doing so correctly shoud unlock your account and proceed with sync setup. Review URL: http://codereview.chromium.org/389017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31829 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of implementing captcha for sync dialog. tim@chromium.org2009-11-112-29/+13
| | | | | | | | | | | | Added GoogleServiceAuthError, which is the same as the incumbent AuthErrorState but can support captcha information too. I moved it because it just had nothing specific to sync about it. This CL is mostly a rename and basic plumbing CaptchaRequired error state from browser_sync::AuthWatcher through to UI thread. Ben, I added a .h to chrome/browser/ alongside other google_* stuff. I'm just looking for your blessing here, or suggestion of alternate location. BUG=19738 Review URL: http://codereview.chromium.org/384040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31729 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 26141munjal@chromium.org2009-11-103-47/+30
| | | | | | | | | | | | - Change sync id to bookmark id map to sync id to bookmark node map - Make other appropriate changes. BUG=26141 TEST=Exist. Review URL: http://codereview.chromium.org/383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31597 0039d316-1c4b-4281-b951-d872f2087c98
* Ninth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-074-2/+13
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/372013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31357 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of string cleanup in Sync:munjal@chromium.org2009-11-064-38/+24
| | | | | | | | | | | | | | | | | | - Get rid of sync_char16 from syncapi - Use wstring for title in syncapi since that gets converted to wstring later on anyway. - Use GURL for urls in syncapi - Return const string references from syncapi instead of pointers to C-style strings. - Make appropriate changes to calling code. BUG=26342 TEST=Already exist. Review URL: http://codereview.chromium.org/362019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31298 0039d316-1c4b-4281-b951-d872f2087c98
* Seventh patch in making destructors of refcounted objects private.jam@chromium.org2009-11-062-0/+4
| | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/371006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31192 0039d316-1c4b-4281-b951-d872f2087c98
* Fourth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-051-1/+2
| | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/360043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31167 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the strings for sync code:munjal@chromium.org2009-11-041-8/+4
| | | | | | | | | | | | | | | | - Use FilePath for real file paths. - Use std::string for PathString on Windows as well TODO in a separate CL: - Get rid of PathString typedef completely and directly use std::string everywhere. - Use wchar_t in syncapi.h/.cc and get rid of sync_char16. TEST=Existing tests are sufficient since this CL does a lot of code refactoring. BUG=26342 Review URL: http://codereview.chromium.org/340055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30970 0039d316-1c4b-4281-b951-d872f2087c98
* Gosh, fix a typo to really fix the tree.munjal@chromium.org2009-10-291-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30488 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the warning treated as error on linux 64 bit build ofmunjal@chromium.org2009-10-291-2/+2
| | | | | | | | | | | comparing signed and unsigned values. BUG=tree break TEST=none Review URL: http://codereview.chromium.org/339070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30487 0039d316-1c4b-4281-b951-d872f2087c98
* Try to revive the revision 30441 which was reverted in 30443.munjal@chromium.org2009-10-291-6/+67
| | | | | | | | | BUG=23978 TEST=Added unit test Review URL: http://codereview.chromium.org/343041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30484 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r30441. Fails compile on linux x64.aa@chromium.org2009-10-291-67/+6
| | | | | | TBR=munjal@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30443 0039d316-1c4b-4281-b951-d872f2087c98
* Make some improvements to sync model associator:munjal@chromium.org2009-10-291-6/+67
| | | | | | | | | | | | | | | | | | | - Fail the load assocications if there the total number of nodes in the bookmark model and the sync model don't match (issue: 25542) - Add a bookmark id index and use that during load assocications instead of calling BookmarkModel::GetNodeByID since the latter traverses the entier tree in DFS order until it finds the node with the given ID. - Add a unit test that would exercise the new model associator load associations behavior. BUG=25542 TEST=Unit test added. Review URL: http://codereview.chromium.org/337037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30441 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the browser_sync flag.zork@chromium.org2009-10-2712-45/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/337034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30272 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify threading in browser thread by making only ChromeThread deal with ↵jam@chromium.org2009-10-273-42/+30
| | | | | | | | different thread lifetimes.The rest of the code doesn't get MessageLoop pointers since they're not thread-safe and instead just call PostTask on ChromeThread. If the target thread is not alive, then the task is simply deleted.In a followup change, I'll remove any remaining MessageLoop* caching. With this change, there's little to be gained by caching since no locks are involved if the target MessageLoop is guaranteed to outlive the current thread (inferred automatically by the order of the chrome_threads_ array).BUG=25354 Review URL: http://codereview.chromium.org/306032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30163 0039d316-1c4b-4281-b951-d872f2087c98
* Move initialization of ChromeURLRequestContexts to the IO thread.eroman@chromium.org2009-10-235-53/+118
| | | | | | | | | | | | | | | | | | | | | | | Before, these URLRequestContexts were lazily created from the UI thread. Unfortunately that model made it easy for consumers on the UI thread to poke at stuff which was being used from the IO thread, and introduce races. So instead of providing a URLRequestContext*, the Profile now vends a URLRequestContextGetter*. The consequence of this is: * Consumers on the UI thread can no longer get access to a URLRequestContext. * Consumers on the IO thread need to call URLRequestContextGetter::GetURLRequestContext() to get at the context. This uses the same style lazy-creation of URLRequestContexts, albeit from the IO thread. OK, so now the smelly part: There were a couple of consumers of URLRequestContext on the UI thread that can't easily be moved to the IO thread -- these are the consumers of the cookie store. Before they could happily mess with the cookie store from the UI thread, and this was fine since CookieStore is threadsafe. However under the new model, they have no way to get at the URLRequestContext from the UI thread, hence can't get a pointer to the cookie store. To support that use-cases, I bastardized the API some by adding a URLRequestContextGetter::GetCookieStore() method that lets UI thread consumers get a pointer to the cookie store, since we know this particular cross-thread usage is safe. BUG=http://crbug.com/22294 Review URL: http://codereview.chromium.org/258008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29880 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/272036 for Thiago:sky@chromium.org2009-10-191-2/+2
| | | | | | | | | | | | | | Rename GetType and SetType using the Unix style to match with the other usages in BookmarkNode. GetType -> type SetType -> set_type BUG=None TEST=None Review URL: http://codereview.chromium.org/297005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29443 0039d316-1c4b-4281-b951-d872f2087c98
* Beef-up a DCHECK_NE case in browser_sync::ChangeProcessor to return early if ↵tim@chromium.org2009-10-191-4/+8
| | | | | | | | | | | | one of the permanent nodes are changed by a bookmark model event. I think we may hit a roadblock a bit deeper down right now and not actually poison the user's cloud state, but it seems best to catch this at first-chance. BUG=25067 Review URL: http://codereview.chromium.org/295007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29437 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ProfileSyncService unit test.nick@chromium.org2009-10-175-79/+64
| | | | | | | | | | | | | | | | | | | | | Create TestHttpBridge for use by ProfileSyncServiceUnittest, so it doesn't crash. DoInitialize has been changed to take a HttpPostProviderFactory before the core initialization. The HttpBridge is now created on the UI thread instead of the core thread. Create fake tagged nodes in the order that they are requested. Make the request order consistent and in visual order since this is the most natural way to request them. TEST=Ran the affected unit tests on Windows, tested basic sync functionality with two concurrent browsers. BUG=25021 Review URL: http://codereview.chromium.org/292008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29368 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CHROME_PERSONALIZATION to BROWSER_SYNC.nick@chromium.org2009-10-1712-27/+26
| | | | | | | | | | Avoid #ifdef in general, favoring #if defined(). In one spot, use PlatformThread::Sleep instead of rolling our own. Review URL: http://codereview.chromium.org/267125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29360 0039d316-1c4b-4281-b951-d872f2087c98
* Makes canceling 'bookmark all tabs' delete the folder. Or rather,sky@chromium.org2009-10-161-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | makes it so that bookmark all tabs only creates the folder if the user presses ok. I wasn't happy adding another random arg to BookmarkEditor::Show, so I added in a structure an enum. This makes it clearer what Show should do. I also fixed the following: . On gtk we wouldn't always pick the right parent for nodes. . The context menu item is now enabled on views/gtk. And this now breaks the mac side. I'll straighten that out right after landing this. BUG=24367 TEST=Make sure 'bookmark all tabs' works, as well as the bookmark editor work. (get to the bookmark editor by creating a new bookmark, then clicking edit, or right clicking a bookmark on the bookmark bar and choosing edit). Review URL: http://codereview.chromium.org/271115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29343 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a dcheck that had a signed/unsigned warning.nick@chromium.org2009-10-161-1/+0
| | | | | | | | | | Fix the mac build (sync is enabled by default on Mac!) R=munjal Review URL: http://codereview.chromium.org/291002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29308 0039d316-1c4b-4281-b951-d872f2087c98
* Use a multiset rather than a set to store bookmarks when running the model ↵nick@chromium.org2009-10-161-4/+6
| | | | | | | | | | | | | | | | | | associator merge. For cases where there's an exact duplicate URL and title, this allows each BookmarkNode a chance to be associated with a sync node. With a set, we'd forget about all but one of the duplicates, resulting in the creation of yet more duplicates. The result was exponential growth with each merge and sync. BUG=24995 TEST= Review URL: http://codereview.chromium.org/288001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29307 0039d316-1c4b-4281-b951-d872f2087c98
* Fix pieces of syncapi that aren't implemented on Linux.zork@chromium.org2009-10-152-2/+0
| | | | | | Review URL: http://codereview.chromium.org/242141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29134 0039d316-1c4b-4281-b951-d872f2087c98
* More style nits.erg@google.com2009-10-141-1/+1
| | | | | | | | (Working on cleaning chrome/ so hopefully we can lint it by default.) Review URL: http://codereview.chromium.org/274040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28971 0039d316-1c4b-4281-b951-d872f2087c98
* Patched in 265058 (which was uploaded under akalin@gmail.com). Originalakalin@chromium.org2009-10-135-7/+10
| | | | | | | | | | | | | | | | | | | | description: Numerous fixes to get parts of Chrome Sync to compile on OS X. Fixes include: - Added missing definitions for some static const class variables. - Added some missing dependencies. - Marked some Windows-only dependencies as such. - Added stub files for some platform-specific classes. BUG=none TEST=Put through trybots. Review URL: http://codereview.chromium.org/266065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28900 0039d316-1c4b-4281-b951-d872f2087c98
* Update sync unit tests to build on linuxzork@chromium.org2009-10-071-10/+12
| | | | | | Review URL: http://codereview.chromium.org/218014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28349 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup some rotten references to old command line switches.nick@chromium.org2009-10-061-2/+0
| | | | | | Review URL: http://codereview.chromium.org/243105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28131 0039d316-1c4b-4281-b951-d872f2087c98
* Initial CL for fixing some of the proxy auth issues.chron@chromium.org2009-10-065-26/+86
| | | | | | | | | | | | | | Auth_cache is contained in the http session. We need to share the http session with the parent profile request context in order to retain http authentication. Weirdly enough, Profile::GetDefaultRequestContext() is not the same as profile_->GetRequestContext(), It does NOT yet pop up a dialog if the user hasn't done so already. BUG=19581 TEST=Included. Review URL: http://codereview.chromium.org/241001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28086 0039d316-1c4b-4281-b951-d872f2087c98
* Move the JPEG and PNG codecs from base/gfx to app/gfx/codec. Move the classesbrettw@chromium.org2009-10-031-2/+2
| | | | | | | | | | | | | | | into the gfx namespace. Combine the PNGEncoder and PNGDecoder. There were separate when we had different executables for the browser and renderer, and linked the encoder only in one of them (which saved us some space used by libpng). This hasn't been the case for years, so combining them (again) makes sense. TEST=none BUG=none Review URL: http://codereview.chromium.org/243076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27930 0039d316-1c4b-4281-b951-d872f2087c98
* For bookmark sync, remove cookie support from http bridge and syncapi.chron@chromium.org2009-09-213-53/+5
| | | | | | | | | | Cookies are problematic for the sync client and no longer necessary. This code is no longer used. Review URL: http://codereview.chromium.org/208036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26752 0039d316-1c4b-4281-b951-d872f2087c98
* Handle some startup errors encountered by ModelAssociator (such as tim@chromium.org2009-09-161-14/+18
| | | | | | | | | | | | unable to find tagged nodes) more gracefully by triggering the unrecoverable error handler. This was in response to a suggestion from chron, as we seem to hit this case a fair bit, and crashing is a pain. More importantly it's possible users are hitting it as well and having an explicit error case / message hidden on the options dialog is better than silently failing with no inkling as to what happened. It also just seems preferable to be in the PSS error state when this happens. Review URL: http://codereview.chromium.org/201119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26407 0039d316-1c4b-4281-b951-d872f2087c98
* Build sync engine as part of the browser build.nick@chromium.org2009-09-153-8/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | As before, syncapi is built as a dynamic library, and only on windows. The difference is that it's built from source, rather than being pulled in as a binary. Changes to sync engine code: * Use OS_WIN instead of OS_WINDOWS (requires build_config.h). * Rename platform-specific files to match the chrome convention. This allows them to be excluded by rules that already exist in chrome.gyp. The convention is either a /win/ directory, or an _win.cc at the end of the file. Other valid platforms are _mac, _linux, and _posix Changes to DEPS: * On Windows, pull in pthreads-win32. Changes to chrome.gyp: * Add new library targets for sync, notifier, sync_proto, and syncapi. Review URL: http://codereview.chromium.org/193103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26295 0039d316-1c4b-4281-b951-d872f2087c98
* This CL changes the CookieStore obect to be a refcounted object to get a ↵ananta@chromium.org2009-09-051-1/+0
| | | | | | | | | | | | better handle on its lifetime as there are cases where this object is handed out to URLRequestContext instances which outlive the URLRequestContext object which created it. Partial fix for http://code.google.com/p/chromium/issues/detail?id=15289 Bug=15289 Review URL: http://codereview.chromium.org/197023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25558 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a FaviconService class tied to the profile.arv@google.com2009-08-281-3/+6
| | | | | | | | | | | | | | | | | | | Original issue: http://codereview.chromium.org/115212/show The favicons service is the entry point to getting favicons. Make the DOMUIFactory handle the favicons of DOMUI pages so since DOMUI pages are never added to the history. BUG=5840 TEST=Open a new window and open history and downloads (Ctrl+H and Ctrl+J) in this window. Then close the window and open the NTP. The recently closed windows/tabs should show the favicons for the hsitroy and downloads page. Review URL: http://codereview.chromium.org/178001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24806 0039d316-1c4b-4281-b951-d872f2087c98
* Make HttpBridge::AllowSendingCookies return true for now.tim@chromium.org2009-08-252-2/+13
| | | | | | | | | TEST=HttpBridgeTest, sync integration BUG=20182 Review URL: http://codereview.chromium.org/173325 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24206 0039d316-1c4b-4281-b951-d872f2087c98
* In HttpBridgeTest, make sure to read the full HTTP response content and nottim@chromium.org2009-08-242-13/+7
| | | | | | | | | | just up until the first null character. TEST=HttpBridgeTest Review URL: http://codereview.chromium.org/174291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24150 0039d316-1c4b-4281-b951-d872f2087c98
* Add support to glue and syncAPI for header setting. (second try)chron@chromium.org2009-08-223-18/+57
| | | | | | Review URL: http://codereview.chromium.org/174269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24062 0039d316-1c4b-4281-b951-d872f2087c98
* Pref-backed SSLConfigService for Linux.mattm@chromium.org2009-08-191-1/+3
| | | | | | | | | | Makes SSLConfigService into a ref-counted interface, and makes Profile own an SSLConfigServiceFactory which is used to create the SSLConfigService and pass it through the URLRequestContext on down to where it is actually used. R=eroman,wtc BUG=11507,19290 Review URL: http://codereview.chromium.org/165003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23757 0039d316-1c4b-4281-b951-d872f2087c98
* Move model operations from ProfileSyncService to ChangeProcessor.tim@chromium.org2009-08-186-49/+794
| | | | | | | | TEST=ProfileSyncServiceTest, sync integration tests Review URL: http://codereview.chromium.org/172040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23669 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two URLRequestContext leaks in HttpBridgeTest and reenable the test. It ↵tim@chromium.org2009-08-121-11/+16
| | | | | | | | | | | | was previously failing the purify step. BUG=19002 TEST=HttpBridgeTest Review URL: http://codereview.chromium.org/165363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23254 0039d316-1c4b-4281-b951-d872f2087c98
* Disable some unit tests.jorlow@chromium.org2009-08-111-0/+4
| | | | | | | | | TEST=none BUG=19002 Review URL: http://codereview.chromium.org/165294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23015 0039d316-1c4b-4281-b951-d872f2087c98
* Add the sync files to chrome.gyp. They still don't result in anything ↵tim@chromium.org2009-08-052-2/+2
| | | | | | | | | | | | building because the files are wrapped in #ifdef CHROME_PERSONALIZATION which is not defined anywhere at the moment. Add live_sync to chrome\test and corresponding target to chrome.gyp Review URL: http://codereview.chromium.org/159902 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22521 0039d316-1c4b-4281-b951-d872f2087c98
* Add files to browser/sync and tweak includes.tim@chromium.org2009-08-0510-0/+2291
| | | | | | | | | | | | | Create browser/sync/glue and /engine. Create sync watchlist and add a few folks. No GYP change here so no build changes should occur. chrome.gyp CL is coming shortly, as well as live_sync tests. Review URL: http://codereview.chromium.org/160598 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22454 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling back 22317bradnelson@google.com2009-08-0310-2289/+0
| | | | | | | | | | BUG=None TEST=None TBR=tim Review URL: http://codereview.chromium.org/160542 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22321 0039d316-1c4b-4281-b951-d872f2087c98
* Add the image resources first so the CL that references them can pass ontim@chromium.org2009-08-0310-0/+2289
the try servers. Review URL: http://codereview.chromium.org/159808 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22317 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 13:13:43 +0000