summaryrefslogtreecommitdiffstats
path: root/chrome/browser/sync/glue
Commit message (Collapse)AuthorAgeFilesLines
* [SYNC] Tests to catch datatype manager behavior when datatype controller is ↵zea@chromium.org2011-01-271-0/+45
| | | | | | | | | | | busy when stop() is called. BUG=61804 TEST=self Review URL: http://codereview.chromium.org/6357018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72803 0039d316-1c4b-4281-b951-d872f2087c98
* Handle sync values of wrong type more graceful.mnissler@chromium.org2011-01-271-1/+8
| | | | | | | | | | | Clear prefs that the server reports TYPE_NULL values for and log a warning if the type is off otherwise. BUG=none TEST=compiles and passes tests Review URL: http://codereview.chromium.org/6288016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72786 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up net unit testing code.erg@google.com2011-01-261-19/+2
| | | | | | | | | | | | | | | | | | | | (Reapply r72562 with willchan's nits + locally tested shlib fixes + removing duplicate code that was partially responsible for the failure.) - Move code included from blah_unittest.h (where blah_unittest.cc has actual unittests) into their own files, often completely out-of-lining the definitions. - Remove anonymous namespaces from headers. - Reorder method declarations. - Make other unit test link against net_test_support instead of reaching in and including .h files in their targets directly. BUG=68682 TEST=compiles First Review URL: http://codereview.chromium.org/6264013 Review URL: http://codereview.chromium.org/6248021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72682 0039d316-1c4b-4281-b951-d872f2087c98
* Do not use local override for language settings: always store it into ↵dilmah@chromium.org2011-01-261-2/+1
| | | | | | | | | | | synchronized preference. BUG=chromium-os:11147 TEST=Manual Review URL: http://codereview.chromium.org/6248017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72633 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Clean up net unit testing code." since it breaks the shlib builder.erg@google.com2011-01-251-1/+1
| | | | | | | | | | This reverts commit 006f377bbb65ece3490b7c76e58e0dc4cb330909 (r72562). BUG=68682 TEST=compiles TBR=thomasvl git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72564 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up net unit testing code.erg@google.com2011-01-251-1/+1
| | | | | | | | | | | | | | | | | - Move code included from blah_unittest.h (where blah_unittest.cc has actual unittests) into their own files, often completely out-of-lining the definitions. - Remove anonymous namespaces from headers. - Reorder method declarations. - Make other unit test link against net_test_support instead of reaching in and including .h files in their targets directly. BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6264013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72562 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce incognito preference settings.battre@chromium.org2011-01-251-44/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL introduces preference settings for incognito windows. The semantics are the following: - An extension can set regular preferences as before. These affect regular and incognito windows. - An extension can set regular preferences *and* incognito preferences. In this case, the incognito preferences affect only incognito windows. - If extension A sets reg+incognito, extension B sets reg but no incognito, extension B has higher precedence than A --> B's preferences hold for all regular and incognito windows. - Incognito preferences are never persisted to disk. In order to realize this, the ExtensionPrefs class allows setting regular and incognito extension controlled preferences. It allows creating an incognito version of the PrefService with an independent PrefValueStore. This (incognito) PrefValueStore and the original PrefValueStore share several of their PrefStores (i.e. DefaultPrefStore, CommandLinePrefStore, Configuration PrefStores) but differ in two pref stores: - We maintain two separate ExtensionPrefStores containing the effective preferences for regular and incognito windows. - We maintain two separate user pref stores. The regular JsonPrefStore is expanded by an OverlayPersistentPrefStore that maintains all write-operations in an in-memory overlay. Therefore, incognito changes are not visible in the file-backed JsonPrefStore. The two ExtensionPrefStores retrieve their effective values from a shared ExtensionPrefValueMap. The OffTheRecordProfileImpl provides a request_context_ that uses the new PrefService already. BUG=66027,69057 TEST=unit tests, will be fully testable once the Proxy Settings API allows incognito settings. Review URL: http://codereview.chromium.org/5915004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72489 0039d316-1c4b-4281-b951-d872f2087c98
* [SYNC] Speculative fix for autofill change processor destroying on the wrong ↵zea@chromium.org2011-01-251-1/+2
| | | | | | | | | | | thread. The data type manager should now tell any datatype controller that is not already stopping or not running to stop. Namely, this covers the MODEL_STARTING and ASSOCIATING cases, which weren't being covered before. Tests that can reproduce these race conditions still needed. BUG=61804 TEST=unit,sync_integration,self Review URL: http://codereview.chromium.org/6273011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72458 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Refactored ProfileSyncService and remove its backend() functionakalin@chromium.org2011-01-2417-110/+61
| | | | | | | | | | | | | | | | | Moved bodies of test functions into .cc files. Remove sync_service() accessors from various model associators. Renamed GetUserShareHandle to GetUserShare() and removed typedefs for its return types. Added plenty of TODOs for future improvements. BUG=None TEST=unit_tests Review URL: http://codereview.chromium.org/6375007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72419 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-2110-28/+28
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* Update references part 3: remaining files in chrome/...msw@chromium.org2011-01-191-3/+3
| | | | | | | | | | | | | | | | | Update chrome/browser/gtk references & copyright dates of touched files. Re-alphabetize include lists as necessary from this change. Manually merge r71828 svn pset svn:eol-style LF \ chrome/browser/automation/testing_automation_provider_gtk.cc \ chrome/browser/speech/speech_input_bubble_gtk.cc BUG=69289 TEST=none Review URL: http://codereview.chromium.org/6245006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71859 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Tidy up SyncBackendHost interface.akalin@chromium.org2011-01-196-54/+65
| | | | | | | | | | | | | | | Converted passphrase-related notifications to SyncFrontend methods. Removed some unneeded parameters from SyncBackendHost constructor. Moved some function definitions into .cc files. BUG=None TEST=unit_tests Review URL: http://codereview.chromium.org/6380004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71855 0039d316-1c4b-4281-b951-d872f2087c98
* Made return types of various Value::DeepCopy() implementations more specificakalin@chromium.org2011-01-181-3/+2
| | | | | | | | | | | | | | | | | | Since C++ supports covariant return types, a subclass of Value can return its own pointer type for Value::DeepCopy(). Also made signatures of Value::Create*Value() more specific. Removed now-unnecessary casts. Added test for covariant return types. BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6324004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71617 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded chrome/browser/prefs/pref_service.h usage.thestig@chromium.org2011-01-153-3/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6335001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71547 0039d316-1c4b-4281-b951-d872f2087c98
* Turn password sync on by default.johnnyg@chromium.org2011-01-151-2/+2
| | | | | | | | | BUG=61252 TEST=none Review URL: http://codereview.chromium.org/6249006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71534 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequestContext URLRequestContext;tfarina@chromium.org2011-01-153-8/+10
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/6338002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71522 0039d316-1c4b-4281-b951-d872f2087c98
* We forgot to call Associate in case of local changes for autofill.lipalani@chromium.org2011-01-141-0/+3
| | | | | | | | | | When a local profile is created we create the corresponding sync node and we need to associate the sync node with profile. We forgot to make the call and that is fixed in this cl. BUG=68912, 69173 TEST= sync_integration_tests Review URL: http://codereview.chromium.org/6323001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71409 0039d316-1c4b-4281-b951-d872f2087c98
* sync: annotate call to join SyncCoreThread to keep ThreadRestrictions happy.tim@chromium.org2011-01-131-4/+9
| | | | | | | | | | | | Bug 19757 discusses how we block the UI thread on the core thread when shutting down sync. Until that is fixed, we have to fess up to the Thread police. BUG=69570,19757 TEST=Start syncing in debug build. Stop sync. Don't crash. Review URL: http://codereview.chromium.org/6328001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71361 0039d316-1c4b-4281-b951-d872f2087c98
* sync: avoid creating a HistoryModelWorker unless it is needed.tim@chromium.org2011-01-131-3/+9
| | | | | | | | | | | | We typically add all known workers when Initializing the SyncBackendHost, but this one is causing crashes and isn't used by default. BUG=53916,69561 TEST=none Review URL: http://codereview.chromium.org/6111012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71337 0039d316-1c4b-4281-b951-d872f2087c98
* Also delete plugin data when the cookies checkbox in the clear browsing data ↵bauerb@chromium.org2011-01-131-1/+0
| | | | | | | | | | | dialog is checked. BUG=58235 TEST=none Review URL: http://codereview.chromium.org/6122008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71304 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequestStatus URLRequestStatus;tfarina@chromium.org2011-01-132-6/+8
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/6166010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71285 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of pref_names.hthestig@chromium.org2011-01-133-4/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6122006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71283 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the command line flag for enabling autofill profile datatype.lipalani@chromium.org2011-01-117-1517/+0
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/6140002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70970 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang compile failurezea@chromium.org2011-01-061-1/+1
| | | | | | | | | BUG=none TEST=self TBR=thakis@ Review URL: http://codereview.chromium.org/6111002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70670 0039d316-1c4b-4281-b951-d872f2087c98
* [SYNC] Sessions datatype refactor. Most things related to sessions ↵zea@chromium.org2011-01-066-439/+1570
| | | | | | | | | | | under-the-hood have changed. More tests on the way. BUG=30519,62753 TEST=unit_tests,sync_integration_tests Review URL: http://codereview.chromium.org/5705004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70645 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add namespace net to the remaining files under url_request directory.tfarina@chromium.org2011-01-061-8/+9
| | | | | | | | | | | | It just adds the 'namespace net' to these files and a typedef for them, because there are many entries to fix in one pass. They will be fixed later. BUG=64263 TEST=trybots Review URL: http://codereview.chromium.org/6056007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70592 0039d316-1c4b-4281-b951-d872f2087c98
* [SYNC] HttpBridge's UrlFetcher should not send cookieszea@chromium.org2011-01-062-4/+1
| | | | | | | | | BUG=60227 TEST=unit Review URL: http://codereview.chromium.org/6093007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70580 0039d316-1c4b-4281-b951-d872f2087c98
* fixing the case of duplicate profiles.lipalani@chromium.org2011-01-054-105/+84
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/6047006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70556 0039d316-1c4b-4281-b951-d872f2087c98
* Move lots of GMock stuff out of line.erg@google.com2011-01-058-30/+89
| | | | | | | | | | | | | | Nico did some treemapping of our build time on Mac, and (surprise!) gmock unittests dominated. Gmock works with several large, heavy templates, and previous patches that out of line the ctors/dtors have significantly sped up compilation (e.g.GLMock) and have reduced thrashing. Nico says I should plug this again: http://www.chromium.org/developers/coding-style/cpp-dos-and-donts BUG=none TEST=none Review URL: http://codereview.chromium.org/6056008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70516 0039d316-1c4b-4281-b951-d872f2087c98
* Move CancellationFlag and WaitableEvent to the synchronization subdirectory.brettw@chromium.org2011-01-028-8/+8
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/5977010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70369 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/lock and base/condition_variable to base/synchronization/brettw@chromium.org2011-01-012-7/+7
| | | | | | | | | | | I kept a base/lock.h in place with a using statement to avoid updating all callers in one CL. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6018013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70363 0039d316-1c4b-4281-b951-d872f2087c98
* Move non_thread_safe from base to base/threading and into the base namespace.brettw@chromium.org2011-01-011-3/+6
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6005010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70351 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/thread.h to base/threading, fix up callers to use the new location.brettw@chromium.org2011-01-014-4/+4
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6028009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70345 0039d316-1c4b-4281-b951-d872f2087c98
* Change extension unload notification to indicate updates.asargent@chromium.org2010-12-232-7/+13
| | | | | | | | | | | | | | | | | | | When an extension in being unloaded, some listeners want to know if it's because the extension is being updated to a newer version, or disabled. This changes the details sent to include a reason. Also this removes the EXTENSION_UNLOADED_DISABLED notification, since only a small number of places actually cared about the disctinction between EXTENSION_UNLOADED and EXTENSION_UNLOADED_DISABLED, and puts that information into the details as well. BUG=65510 TEST=Should be covered by existing unit & browser tests. Review URL: http://codereview.chromium.org/5968009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70104 0039d316-1c4b-4281-b951-d872f2087c98
* Coalesced various extension type enums into Extension::Type.akalin@chromium.org2010-12-218-211/+97
| | | | | | | | | | | | | | Renamed Extension::HistogramType to Extension::Type and used it everywhere. Moved extension sync security checks into sync land and simplified them. BUG=55823 TEST=Existing unit tests / sync integration tests Review URL: http://codereview.chromium.org/5946001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69855 0039d316-1c4b-4281-b951-d872f2087c98
* Respect synced locale settings.dilmah@chromium.org2010-12-201-1/+1
| | | | | | | | | BUG=chromium-os:9164 TEST=Manual Review URL: http://codereview.chromium.org/6000001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69709 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69592 - file_version_info was not finding Mac values correctly.dmaclach@chromium.org2010-12-181-0/+5
| | | | | | | | | | | | | | Changed file_version_info to find Mac values, and changed version_info to fail if values can't be found. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5815001 TBR=dmaclach@chromium.org Review URL: http://codereview.chromium.org/6017003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69601 0039d316-1c4b-4281-b951-d872f2087c98
* file_version_info was not finding Mac values correctly.dmaclach@chromium.org2010-12-181-5/+0
| | | | | | | | | | | Changed file_version_info to find Mac values, and changed version_info to fail if values can't be found. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5815001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69592 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of notification_service.h, part 2.thestig@chromium.org2010-12-171-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5928003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69576 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of notification_service.h.thestig@chromium.org2010-12-172-2/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5875005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69507 0039d316-1c4b-4281-b951-d872f2087c98
* Almost done deinlining virtual methods.erg@google.com2010-12-1618-93/+155
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5841002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69470 0039d316-1c4b-4281-b951-d872f2087c98
* Rest of the autofill work.lipalani@chromium.org2010-12-1621-142/+964
| | | | | | | | | | | Includes 1. change processor. 2. Migrating code. 3. new datatype registration/enabling/disabling from the UI. (It is keyed off of autofill datatype). Review URL: http://codereview.chromium.org/5159001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69382 0039d316-1c4b-4281-b951-d872f2087c98
* Move GUID utils to src/chrome/common.sergeyu@chromium.org2010-12-152-2/+2
| | | | | | | | | BUG=None TEST=compiles,unittests Review URL: http://codereview.chromium.org/5849001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69347 0039d316-1c4b-4281-b951-d872f2087c98
* Keep deinlining stuff.erg@google.com2010-12-154-22/+39
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5783004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69273 0039d316-1c4b-4281-b951-d872f2087c98
* Add a preference to clear Flash LSO data in the Clear Browsing Data dialog.bauerb@chromium.org2010-12-151-0/+1
| | | | | | | | | | | The preference defaults to false, so without UI it should do nothing. BUG=58235 TEST=none Review URL: http://codereview.chromium.org/5278001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69268 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ExtensionsService to ExtensionService.tfarina@chromium.org2010-12-1410-36/+36
| | | | | | | | | BUG=61409 TEST=trybots Review URL: http://codereview.chromium.org/5730004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69117 0039d316-1c4b-4281-b951-d872f2087c98
* Deinline even more destructors.erg@google.com2010-12-1416-95/+165
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5794003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69084 0039d316-1c4b-4281-b951-d872f2087c98
* Even more virtual method deinlining.erg@google.com2010-12-134-6/+12
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5741001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69041 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded browser_thread.h usage.thestig@chromium.org2010-12-133-3/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5676004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69037 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove needed #includes for profile.h.thestig@chromium.org2010-12-104-4/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5682007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68884 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-12 15:20:00 +0000