| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
95% of this is removing "const" from return types, but turning this
on found one bug! (A "for" loop that expected its iterator to go negative but
which was using an unsigned type.)
BUG=34160
Review URL: http://codereview.chromium.org/570012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/548203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33091
TEST=none
Review URL: http://codereview.chromium.org/552162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
crash in 30721.
Added method for creating ssl socket adapters to libjingle socket factories and made callers use it.
Added SSLSocketAdapterFactory class, which uses the right SSL socket adapter for Linux/OS X.
Fixed bug in asynchttprequest.cc where ignore_bad_cert_ was being left uninitialized.
BUG=30721
TEST=trybots, manual testing
Review URL: http://codereview.chromium.org/503087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots,manual testing
Review URL: http://codereview.chromium.org/485004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/462014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/418042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the really hard ones which will need actual review instead of rubber-stamping.)
Review URL: http://codereview.chromium.org/386026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=19784
TEST=On a system with two network adapters, ensure one has an active internet
connection, and the other does not. Disconnect the active one, and check that
in notifier::NetworkStatusDetectorTaskMT::OnNetworkAliveDone() the call to
network_alive->alive() returns false.
Review URL: http://codereview.chromium.org/377019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
time_posix.cc has the actual code and compiles on Linux
already. Including both files causes linker errors for
the shared build.
BUG=none
TEST=compiles on trybots
Review URL: http://codereview.chromium.org/341035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Avoid #ifdef in general, favoring #if defined().
In one spot, use PlatformThread::Sleep instead of rolling our own.
Review URL: http://codereview.chromium.org/267125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
description:
Numerous fixes to get parts of Chrome Sync to compile on OS X.
Fixes include:
- Added missing definitions for some static const class variables.
- Added some missing dependencies.
- Marked some Windows-only dependencies as such.
- Added stub files for some platform-specific classes.
BUG=none
TEST=Put through trybots.
Review URL: http://codereview.chromium.org/266065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add high res timer class for mac (we might eventually replace all timer classes with Chrome ones)
- Define POSIX for OS==mac where needed
- Add new liens at the end of some files since otherwise they produce errors on Mac
- Rearrange initializer list of constructors to match declaration order in header; these become warning as error.
- Some chrome.gyp magic
At this point the code compiles but doesn't link due to some missing code on Mac like SSL stuff. But
I thought this was a good check point.
Note that chrome.gyp magic might change in future.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/255053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
logging.h to suppress the definition of LOG() and friends unless
explicitly requested. Fix gyp paths to overrides files.
Review URL: http://codereview.chromium.org/225001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
from notifier/base. These were unused.
Review URL: http://codereview.chromium.org/219006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/211019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As before, syncapi is built as a dynamic library, and only
on windows. The difference is that it's built from source,
rather than being pulled in as a binary.
Changes to sync engine code:
* Use OS_WIN instead of OS_WINDOWS (requires build_config.h).
* Rename platform-specific files to match the chrome convention.
This allows them to be excluded by rules that already exist
in chrome.gyp. The convention is either a /win/ directory,
or an _win.cc at the end of the file. Other valid platforms
are _mac, _linux, and _posix
Changes to DEPS:
* On Windows, pull in pthreads-win32.
Changes to chrome.gyp:
* Add new library targets for sync, notifier, sync_proto, and
syncapi.
Review URL: http://codereview.chromium.org/193103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
under chrome/test/sync.
Review URL: http://codereview.chromium.org/203043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=single-stepped with breakpoints in all
functions of PlatformNetworkInfo; made changes on a
connected client while disconnecting the client
I was debugging. Achieved full coverage of the
affected code, except for error paths.
Review URL: http://codereview.chromium.org/194091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and adding a DEPS rule to allow "talk/".
This code is not yet compiled,
but it is still subject to checkdeps.
TEST=ran checkdeps.py
BUG=none
Review URL: http://codereview.chromium.org/201077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
The code is not built on any platform yet. That will arrive
as a subsequent checkin.
This is an implementation of the interface exposed earlier
through syncapi.h. It is the client side of a sync
protocol that lets users sync their browser data
(currently, just bookmarks) with their Google Account.
Table of contents:
browser/sync/
protocol - The protocol definition, and
other definitions necessary to connect to
the service.
syncable/ - defines a data model for syncable objects,
and provides a sqlite-based backing store
for this model.
engine/ - includes the core sync logic, including commiting
changes to the server, downloading changes from
the server, resolving conflicts, other parts of
the sync algorithm.
engine/net - parts of the sync engine focused on the
business of talking to the server. Some of
this is binds a generic "server connection"
interface to a concrete implementation
provided by Chromium.
notifier - the part of the syncer focused on the business
of sending and receiving xmpp notifications.
Notifications are used instead of polling to
achieve very low latency change propagation.
util - not necessarily sync specific utility code. Much
of this is scaffolding which should either be
replaced by, or merged with, the utility code
in base/.
BUG=none
TEST=this code includes its own suite of unit tests.
Review URL: http://codereview.chromium.org/194065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25850 0039d316-1c4b-4281-b951-d872f2087c98
|