| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
for external developers.
Added the signed in devices permission back and enable it in dev channel.
BUG=170375
R=mpcomplete@chromium.org, rlp@chromium.org, zea@chromium.org
Review URL: https://codereview.chromium.org/23576009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
open foreign windows and tabs. API proposal accessible at go/sessions-apidoc. SyncedDevices / DeviceInfo still needs to be added in once they are written and checked in by chrome.syncedDevices developer. Session name is currently holding the place of DeviceInfo in "info" component of Session object (sessions.json). An "on change" event listener for changes in device sync needs to be added as well.
BUG=123266
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219066
Review URL: https://chromiumcodereview.appspot.com/21022018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Failed ExtensionSEssionsTest.RestoreForeignSessionTab on XP Tests (dbg)(3).
> Sessions API - previously Session Restore API. Supports restoring currently open foreign windows and tabs. API proposal accessible at go/sessions-apidoc. SyncedDevices / DeviceInfo still needs to be added in once they are written and checked in by chrome.syncedDevices developer. Session name is currently holding the place of DeviceInfo in "info" component of Session object (sessions.json). An "on change" event listener for changes in device sync needs to be added as well.
>
> BUG=123266
>
> Review URL: https://chromiumcodereview.appspot.com/21022018
TBR=dwankri@chromium.org
Review URL: https://codereview.chromium.org/22793017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
open foreign windows and tabs. API proposal accessible at go/sessions-apidoc. SyncedDevices / DeviceInfo still needs to be added in once they are written and checked in by chrome.syncedDevices developer. Session name is currently holding the place of DeviceInfo in "info" component of Session object (sessions.json). An "on change" event listener for changes in device sync needs to be added as well.
BUG=123266
Review URL: https://chromiumcodereview.appspot.com/21022018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
channel(the permission and manifest entries are missing)
Nicolas - would you mind reviewing the device_info.cc and pss_mock changes. In DeviceInfo the changes are to make the tovalue method consistent with the API docs. However there still remains some work particularly for ios devices which are marked as todo and if you are OK with it we will do it as a seperate review.
Matt - Please review the rest.
BUG=170375
R=mpcomplete@chromium.org, zea@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218087
Review URL: https://codereview.chromium.org/22706006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Plumbing to expose DeviceInfo API (get) to dev channel.
>
> Nicolas - would you mind reviewing the device_info.cc and pss_mock changes. In DeviceInfo the changes are to make the tovalue method consistent with the API docs. However there still remains some work particularly for ios devices which are marked as todo and if you are OK with it we will do it as a seperate review.
>
> Matt - Please review the rest.
> BUG=170375
> R=mpcomplete@chromium.org, zea@chromium.org
>
> Review URL: https://codereview.chromium.org/22706006
TBR=lipalani@chromium.org
Review URL: https://codereview.chromium.org/22865018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nicolas - would you mind reviewing the device_info.cc and pss_mock changes. In DeviceInfo the changes are to make the tovalue method consistent with the API docs. However there still remains some work particularly for ios devices which are marked as todo and if you are OK with it we will do it as a seperate review.
Matt - Please review the rest.
BUG=170375
R=mpcomplete@chromium.org, zea@chromium.org
Review URL: https://codereview.chromium.org/22706006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
id ->sync partnership mapping is persisted to extension prefs(which takes care of persisting to disk)
BUG=170375
R=mpcomplete@chromium.org, zea@chromium.org
Review URL: https://codereview.chromium.org/21289004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
notifications.
BUG=258107
Review URL: https://chromiumcodereview.appspot.com/18497007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProfileSyncService requests access token from OAuth2TokenService and passes it
to ServerConnectionManager through UpdateCredentials. When server returns
AUTH_ERROR it gets propagated to ProfileSyncService through OnGetStatusChange
call. At this point ProfileSyncService needs to invalidate old token with
OAuth2TokenService and request a new one.
Access token is requested in PSS::StartUp since this is the place where all
preconditions are verified. There is a call to pre-request access token in
Initialize and Observe after Login token is loaded.
There are still two tests disabled, I'll fix them and update this CR.
BUG=226464
TBR=jhawkins@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15421011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16258008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original codereview at https://codereview.chromium.org/14789020/
This fixes the win_aura failure from the original patch.
BUG=none
TBR=dbeam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16105012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=227219
R=joi@chromium.org
Review URL: https://codereview.chromium.org/15517005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeOS doesn't need the sync login code - in fact, it's actively bad to have
this code in there because it keeps getting triggered through various bugs. As
an interim measure, this CL #if-outs the code on chromeos platforms. Once we
have removed the non-web-based signin code, we can look at the remaining code
and decide whether it is worth refactoring this into platform-specific classes.
BUG=236005
R=arv@chromium.org, rogerta@chromium.org
Review URL: https://codereview.chromium.org/14696017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instead of Profile. This will help move it out of chrome.
BUG=227219
Review URL: https://codereview.chromium.org/14141006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Keystore encryption is always on by default now, so no need to check
for the command line switch.
TBR=jhawkins@chromium.org
BUG=225524
Review URL: https://chromiumcodereview.appspot.com/13084010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=174134
Review URL: https://codereview.chromium.org/12221101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change signin logic to allow signin if SyncDisabled policy is set.
Also broke out logic in SyncUIUtil into separate class so it can be used even
if sync is not enabled.
BUG=166148
Review URL: https://codereview.chromium.org/12077030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also addresses an issue on Chrome OS where we'd unnecessarily spin up
the DataTypeManager if the user cancelled out of a sync setup (after a
dashboard clear), and adds some comments.
Lastly some tests were firing TOKEN_LOADING_FINISHED on a fake / mock
TokenService, but calling TokensLoadedFromDB was still returning
false -- fixed that (needed for this patch).
BUG=80194, 128692
Review URL: https://chromiumcodereview.appspot.com/11348220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The DataTypeDebugListener is an interface that allows glue components to pass
sync debug info to the sync debug event listener, which lives in the sync
internals on the sync thread. To do this we pass a WeakHandle at initialization
time all the way through to the PSS, which then uses it to create the
DataTypeManager.
Follow up patches will plumb DTC results to the DataTypeDebugListener.
BUG=158576
Review URL: https://chromiumcodereview.appspot.com/11365116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now track when a custom passphrase is set, and in conjunction with
the migration time now support querying the passphrase time (returns
migration time for FROZEN_IMPLICIT type, or custom passphrase time for
CUSTOM_PASSPHRASE type).
Plumb this information up through to the PSS for eventual use in the UI.
BUG=129665
Review URL: https://chromiumcodereview.appspot.com/11098007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=mechanicalowners@chromium.org
BUG=145584
Review URL: https://chromiumcodereview.appspot.com/10928017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
creating a new DataTypeManagerOserver interface
As of today, DataTypeManager sends out notifications for various
configure events via NotificationService notifications. This is bad,
because other services that depend on these events need to have
knowledge of DataTypeManager, which is internal to the sync
implementation.
This patch does the following:
1) Creates a new DatTypeManagerObserver interface through which
observers are made aware of configure events.
2) Has ProfileSyncService implement the interface.
3) Gets rid of unnecessary sync configure * notification types.
4) Has PSS send out notifications for SYNC_CONFIGURE_START and
SYNC_CONFIGURE_DONE.
5) Allows ForeignSessionHandler to listen to SYNC_CONFIGURE_DONE
notifications from the PSS, instead of from all sources, while
waiting to populate the "other devices" section of the NTP.
6) Updates various mock and test classes and fixes unit tests.
TBR=estade@chromium.org, thakis@chromium.org
BUG=142984,124717,111676,142550
Review URL: https://chromiumcodereview.appspot.com/10834351
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit changes the way we initialize the fields which get exported
to about:sync's about tab. The goal was to pre-declare all the data
which would be exported in a complete snapshot, and to track which of
these fields were actually set. Unset fields will have a default value
and be specially highlighted on about:sync. This commit includes the
changes necessary to perform this highlighting.
Also in this commit are a few backend changes that are used to determine
from sync_ui_util which fields are properly initialized and which fields
have been unset by anything other than a default constructor.
The signature for ProfileSyncService::QueryDetailedSyncStatus() has been
modified to return an additional parameter indicating whether or not the
returned status actually came from the backend.
The SyncSesionSnapshot takes a different approach. The object is
immutable and has two constructors. If it is constructed with the
zero-argument constructor it is clearly uninitialized, and will remain
so. This change adds a flag which is set or unset based on which
constructor is used.
Finally, the ConstructAboutInforation function and all its helpers have
been moved out of sync_ui_util.cc and into their own file.
BUG=134927
TEST=
Review URL: https://chromiumcodereview.appspot.com/10696107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10689154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously they were in 'syncer::syncable'.
Also remove aliases to those classes from 'syncable'.
BUG=128060
TEST=
TBR=pkasting@chromium.org,jhawkins@chromium.org,
Review URL: https://chromiumcodereview.appspot.com/10696087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also move enum_set* to base/.
This is the first step in moving ModelType et al. to the syncer
namespace (from syncer::syncable).
Move PurgeStalePayload() back to sync_session.cc.
Move ModelTypePayloadMapFromRoutingInfo() to model_safe_worker.* and rename it to ModelSafeRoutingInfoToPayloadMap().
BUG=128060
TEST=
Review URL: https://chromiumcodereview.appspot.com/10690071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Everyone was confused by 'csync'. 'syncer' seems more understandable.
(Note that we can't use the 'sync' namespace since sync() is a function
from unistd.h.)
BUG=10662035
TEST=
TBR=jhawkins@chromium.org,pkasting@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10698014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=128060
TEST=
Review URL: https://chromiumcodereview.appspot.com/10601002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update all references from chrome.
Leave possibly-extraneous csync:: qualifications in sync/ for now.
(This will be cleaned up once everything in sync/ is in csync::.)
BUG=128060
TEST=
TBR=jhawkins@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10600002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"On" is typically reserved for api callbacks, and 'disable datatype' is a conflated term.
BUG=132020
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10559050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The net effect of this patch is that a few lingering callsites of OnUnrecoverableError (resulting in full sync shutdown) from within data type specific code are changed over to OnSingleDatatypeUnrecoverableError.
Removes need to post task to ProfileSyncService from FrontendDataTypeController, which is the only legit use
for making ProfileSyncService SupportsWeakPtr (which will be removed in a later patch).
zea FYI
BUG=132017, 100829
TEST=unit
Review URL: https://chromiumcodereview.appspot.com/10553042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now differentiate between unrecoverable errors due to the syncer,
configuraiton retry (failed to talk to server), configuration failure (missing
datatypes), backend not initializing, and actionable errors.
BUG=132645
TEST=
Review URL: https://chromiumcodereview.appspot.com/10542165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/sync.
Note on sync.gyp changes and .cc file moves: most files in /public have .h and their .cc side by side, as they are simple implementations. In some cases like model_type.cc (and others in a follow up patch, like sync_manager.cc) have only their header exposed in /public while the impl stays behind, because it needs to include things from within sync/, and /public has a strict include DEPS policy. This is in accordance with other /public folders (like content/).
Cleans up DEPS files in sync + c/b/sync. Adds sync/{engine, sessions, syncable} to public/. There is more to come (moving things in internal_api/ into public).
Not touching /notifier as that is in flux at the moment.
BUG=131130
TEST=
Review URL: https://chromiumcodereview.appspot.com/10532019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Break up AreCredentialsAvailable() into two routines, IsSyncEnabledAndLoggedIn() and IsSyncTokenAvailable().
ProfileSyncService now will start up the sync backend even if there's no sync token available. GetCredentials() will make up fake/invalid tokens for the sync backend to use, which will eventually yield an auth error for the user.
BUG=121755
TEST=see bug
Review URL: https://chromiumcodereview.appspot.com/10335015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=92265
TEST=no functionality change - just code cleanup.
Review URL: http://codereview.chromium.org/10210013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously it was an immutable struct that was passed around by making
dynamic allocations and passing pointers. We now just have a class with
only getters and no setters, but support for default copy and assign.
This cleans up some code and makes some future work easier to pass snapshots
around.
BUG=none
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/10197004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed so all code queries the auth-in-progress status directly from SigninManager.
BUG=95269
TEST=existing unit tests suffice
Review URL: http://codereview.chromium.org/9959038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move logic in SyncSetupFlow and SyncSetupWizard into the UI (SyncSetupHandler)
and into ProfileSyncService itself.
Removed obsolete UI, logic, and strings that are no longer necessary.
BUG=92265,95269
TEST=Run all of the signin/config test cases.
Review URL: https://chromiumcodereview.appspot.com/9716023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous attempts to share code between ProfileKeyedServiceFactory and RefcountedProfileKeyedServiceFactory were ill advised. The core logic code must maintain refcounted data in a scoped_refptr<> for the entire lifecycle, across interface and implementation, preventing any real abstraction here.
This removes the common ProfileKeyedBase and splits the two worlds entirely in two. This has quite a bit of exact code with different types now.
Fallout from this is far reaching:
- Since there isn't one common heiarchy, now the testing methods either return ProfileKeyedServices or scoped_refptr<RefcountedProfileKeyedService>s. This is a lot of change.
- Many consumers handled the refcounted ptrs as raw pointers, which probably isn't a good idea.
- There is now a bunch of code duplication.
BUG=118196,77155
R=mirandac,tim
TBR=jhawkins,sky,scottbyer
Review URL: http://codereview.chromium.org/9703038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also move related test files.
Move WriteNode::UpdateEntryWithEncryption to nigori_util.h.
Clean up defines and dependencies. In particular, get rid of SYNC_ENGINE_VERSION_STRING and hard-code the string in the single place it's used.
Rename data_encryption.* to data_encryption_win.* and add a pragma for crypt32.lib.
Clean up exit-time constructor warnings in sync{able,er}_unittest.cc.
Remove some unused files.
BUG=117585
TEST=
TBR=jhawkins@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9699057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updated SigninTracker to wait for all signed-in services auth tokens to be loaded before
transitioning to the signed in state.
SigninManager no longer tracks the last auth error - this tracking has been moved to the UI layer where it belongs.
BUG=111859,114209
TEST=Test app notification signin flows.
Review URL: http://codereview.chromium.org/9465036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Recreated the tests that used to live in SyncSetupWizardTest, and wrote new tests for SigninTracker that test our state transitions.
Added a MockWebUI helper class to content/test.
BUG=112565
TEST=run new unit tests.
Review URL: http://codereview.chromium.org/9395068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 51e62c2c61ecde08d0e7cca563624184f634953f.
BUG=108017
TEST=none
TBR=tim@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9138051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
regression.
Reverting due to linux sync integration test crashes, and a memory leak.
BUG=108017
TEST=none
TBR=tim@chromium.org,jamesr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9141027
TBR=atwilson@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9226042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=108017
TEST=none
TBR=tim@chromium.org,jamesr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9141027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
regression.
Revert "Moved SigninManager out of browser/sync, and start changing the code so signin"
This reverts commit 897f42f222022acb470de4e8cd369862139583f2.
Revert "Make SigninManager a ProfileKeyedService."
This reverts commit b29413fd67465671335091b2b7e3bb7ed2f62e0f.
BUG=108017
TEST=watch perf bots, see if perf regression disappears
TBR=jamesr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9251031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
does not require going through ProfileSyncService.
BUG=108017
TEST=test signin scenarios
TBR=mnissler
Review URL: http://codereview.chromium.org/8996002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the old ModelTypeSet and ModelTypeBitSet are gone, we can rename
ModelEnumSet to ModelTypeSet. Conveniently, they're the same number
of characters, so this is just a straight rename. Command:
git grep -l ModelEnumSet | xargs sed -i '' -e 's/ModelEnumSet/ModelTypeSet/g'
BUG=79970
TEST=
Review URL: http://codereview.chromium.org/8919021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also change some functions to return ModelEnumSets directly instead of
taking a pointer value.
BUG=79970
TEST=
Review URL: http://codereview.chromium.org/8851006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113906 0039d316-1c4b-4281-b951-d872f2087c98
|