| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none.
TEST=examine logs from browser/ui/unit/interactive_ui tests, profile_sync_service should not be in top 20 spammers.
Review URL: http://codereview.chromium.org/3436017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In r57340, the datatype selection section of sync set-up UI got wider, but
not wide enough to avoid truncation in all the locales. When a word
is too long to fit, it's truncated with 'tooltip' showing the full-word.
This CL adds 'text-overflow: ellipsis' and other necessary CSS properties
to 'label' elements so that long words that do not fit are ellipsized instead of
truncated.
While I'm at it, I fixed two 'typos'. One is 'i8n' (note missing '1') and
the other is the misplaced label for the radio-button for
'Choose what to sync'. The raido-button and the corresponding label is
separated by 'div' tag (chooseDataTypesBody) leading to a strange line wrapping
in the sync setup UI.
BUG=52789, 53494
TEST=1. Open sync setup UI in French, Italian, Brazilliant Portugest (pt-BR) and see if the translation for 'autofill' is ellipsized rather than truncated.
2. Open sync setup UI and 'Choose what to sync:' is on the same line as the corresponding radio button.
Review URL: http://codereview.chromium.org/3142042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
wrapping)
BUG=53494
TEST=choose datatypes screen on windows
Review URL: http://codereview.chromium.org/3184027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for the labels so that the long text can be seen on hover even if it still doesn't fit.
BUG=52789
TEST=open sync setup ui in a language with long words
Review URL: http://codereview.chromium.org/3197019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Save the information that the setup of remoting has completed.
After setup has been completed we start and stop service process when
--enable-remoting presents when browser starts.
Also save the information in the service process that host is registered
and ready to be used. Again start chromoting host automatically once
the host registration is done.
BUG=50244, 50242, 50243, 50249
Review URL: http://codereview.chromium.org/3153029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46512
TEST=manual
Review URL: http://codereview.chromium.org/3186002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Partially from original patch by randy.posynick@gmail.com
BUG=26388,19721,37676
TEST=manually tested
Review URL: http://codereview.chromium.org/3090017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
iframes.
BUG=48138
Review URL: http://codereview.chromium.org/2819089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All resource files
_ Made text unselectable on all 3 screens
_ Change the default font size to 11pt and 1.8em line height spacing
gaia_login
_ Introduction paragraph is now using 11pt font and new spaced line height
_ Moved the cancel button into the GAIA login box.
_ Error message
> Made permanent space for the error msg between intro paragraph and GAIA login
> Error message now as the same orange background as on choosedatatypes
> Error shows on Captcha view if there's an error
setup_done
_ Got rid of the tables
_ Header is now the right size
_ Synced to user@gmail.com is now bold
BUG=49704
Original patch by dudley@chromium.org
Original review: http://codereview.chromium.org/3085003
Review URL: http://codereview.chromium.org/2856081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Original patch by dudley@chromium.org (http://codereview.chromium.org/2861069)
BUG=49704
Review URL: http://codereview.chromium.org/3019014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=49645
TEST=Set up sync, make sure throbbers that appear spin.
Review URL: http://codereview.chromium.org/3029012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46807
TEST=SyncerThreadWithSyncerTest, SyncSetupWizardTest, SyncerProtoUtilTest
Review URL: http://codereview.chromium.org/2976011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Correct throbber path in choose_datatypes.html (I overlooked this)
* Change CSS style settings for throbber to a form the inliner could understand, so the image got inlined properly
* Remove references to throbber path from sync_setup_wizard.cc (no longer needed)
* Fix improper use of url_constants.* (only paths that need to be in common/ should be there) and change sync hostname constant name to match other hostnames' naming scheme
BUG=40984
TEST=Signing into GAIA in sync setup dialog should show a throbber
Review URL: http://codereview.chromium.org/2840035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2986006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Flatten HTML where possible
* Move resources only referenced by files in browser/resources/ into there (and out of the theme dir)
* Remove duplicate/unreferenced resources
* Remove IDs for resources that are inlined due to flattening
* Remove IDR_CHAT_MANAGER_MANIFEST but leave the files on disk (they will be moving elsewhere some time soon)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2897015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If you try to set up or customize sync, then click "choose data types to sync" and uncheck all of them, then click OK, this will give you an error message ("you must select at least one data type to sync.") and will not start syncing. This is what we wanted to do with the old dialog box; the only reason we couldn't is that we didn't have time to get a translated string in.
Note that there's enough room on the error message for two lines' worth of text if necessary.
Screenshot in the corresponding bug (47995).
BUG=47995
TEST=try to start syncing, click "choose data types to sync", and uncheck all of them, and click OK. It should give you an error as described above.
Review URL: http://codereview.chromium.org/2827040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of leftover references to "merge and sync."
BUG=48125
TEST=Start up sync, change data types, stop sync, etc, nothing should break.
Review URL: http://codereview.chromium.org/2843019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This means, if you press enter, it'll work the same as if you clicked OK.
BUG=47752
TEST=Set up sync -> enter username/pw, press enter on choose datatypes screen, it should start syncing and eventually get to "success".
Review URL: http://codereview.chromium.org/2876017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Was reverted because of a valgrind error. This is try #2.
Old flow:
- type username/password. wait for Gaia auth and initial sync (with throbber)
- success! or error.
New flow:
- type username/password. wait for Gaia auth. (with throbber)
- error, or choose your datatypes. you can choose "keep everything synced", which will sync all present and future datatypes, or you can pick one by one.
- wait for initial sync (with throbber)
- success! or error, which brings you back to the gaia auth screen.
Smaller details:
- removed the Customize button from gaia_login.html; further removal of the old native Customize dialog to follow.
- added a logging statement to log if you cancel from the Choose Data Types screen.
- added a pref to the profile for whether you want to "keep everything synced" or choose one by one.
- added a couple more strings. Not final yet, I don't think.
BUG=45869
TEST=Exercise all the different paths through the login flow.
Review URL: http://codereview.chromium.org/2880001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=checkperms.py passes
Review URL: http://codereview.chromium.org/2850030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dantasse@chromium.org
TEST=Valgrind bot goes green
BUG=none
Review URL: http://codereview.chromium.org/2827025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
soon...)
Old flow:
- type username/password. wait for Gaia auth and initial sync (with throbber)
- success! or error.
New flow:
- type username/password. wait for Gaia auth. (with throbber)
- error, or choose your datatypes. you can choose "keep everything synced", which will sync all present and future datatypes, or you can pick one by one.
- wait for initial sync (with throbber)
- success! or error, which brings you back to the gaia auth screen.
Smaller details:
- removed the Customize button from gaia_login.html; further removal of the old native Customize dialog to follow.
- added a logging statement to log if you cancel from the Choose Data Types screen.
- added a pref to the profile for whether you want to "keep everything synced" or choose one by one.
- added a couple more strings. Not final yet, I don't think.
BUG=45869
TEST=Exercise all the different paths through the login flow.
Review URL: http://codereview.chromium.org/2851012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45869
TEST=Doesn't do anything yet
Review URL: http://codereview.chromium.org/2845019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for every time I hated a CR LF, I'd buy fancy overpriced cupcakes for everyone on Chrome.
BUG=45869
TEST=none
Review URL: http://codereview.chromium.org/2831025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Needs http://codereview.chromium.org/2002012 to build).
BUG=42695
TEST=manually visit about:sync
Review URL: http://codereview.chromium.org/1987009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
username/password, then press enter, it'll have the same effect as if you clicked "sign in."
BUG:43224
TEST: Wrench->set up sync. Enter a valid username and password. Press enter. It should sign you in and start syncing.
Review URL: http://codereview.chromium.org/2687001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=42769
TEST=click "set up sync" in chrome in any language, make sure the "customize sync" text fits inside the button.
For a screenshot of how it'll look: http://chromium.googlecode.com/issues/attachment?aid=-4915103749708609065&name=customize_sync_button.jpg&token=1393e02a3f3cd5e36e332205f24bf6d1&inline=1
Review URL: http://codereview.chromium.org/1712022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1723014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
page again.
BUG=40881
TEST=none
Review URL: http://codereview.chromium.org/1713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
version (see bug for screenshots).
BUG=41708
Changes include:
- Justify the introduction text
- Align customize/cancel buttons to the bottom of the window.
I uploaded a screen shot of the changed window to the bug.
I also created a test page that iframes the html of the login dialog so it makes it easier to work on the layer without having to compile and run chrome to see it.
Review URL: http://codereview.chromium.org/1654020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
data type (bookmarks, preferences, etc).
The Customize Sync dialog appears if you click a button on the gaia login or the Options->Personal Stuff tab. This button only appears if you've set the --enable-sync-preferences or --enable-sync-autofill command-line flag.
On the Gaia login, the Customize Sync button grays out when you click 'sign in'. If the "customize sync" dialog is open, it closes when you click "cancel" on the Gaia login, and it accepts when you log in to Gaia.
Removed "Merge and Sync" from the login sequence. Also deleted the 'merge_allowed' parameter from DataTypeController and its subclasses.
Fixed strings so they all refer to "Google Chrome/Chromium sync" instead of "Bookmark sync".
BUG=34209,27259
TEST=none
Review URL: http://codereview.chromium.org/1134002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1182001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add padding to throbber.
Fix merge and sync cutoff.
BUG=27770, 29767, 29788, 29782, 29647
TEST=manually checked all languages,
Review URL: http://codereview.chromium.org/460123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Remove stray style tag that caused validation problems.
TEST=manually tested
BUG=28803,28801
Review URL: http://codereview.chromium.org/442019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27543
TEST=Manually tested
Review URL: http://codereview.chromium.org/437033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sync_setup_wizard.cc
so that we can append the language code as a CGI parameter based on the locale.
BUG=26385
TEST=Make sure links on the sync login dialog open pages in the same language as the browser language.
Review URL: http://codereview.chromium.org/385103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=19738
TEST=Get a Google Account into captcha state. Start syncing. You should
be presented with a captcha image and textbox to answer the challenge.
Doing so correctly shoud unlock your account and proceed with sync setup.
Review URL: http://codereview.chromium.org/389017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=19980
TEST=See the steps in the bug description.
Patch by Randy Posynick<randy.posynick@gmail.com>
http://codereview.chromium.org/287008
Review URL: http://codereview.chromium.org/339075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=19918,21509
Review URL: http://codereview.chromium.org/267135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23136,24858,21596
TEST=SyncSetupWizardTest
Review URL: http://codereview.chromium.org/270081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
upcoming patch. TBR=nick
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24217
TEST=screenshotted before and after.
Review URL: http://codereview.chromium.org/261018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in generated_resources.grd.Move the google logo depending of the order of words in the translation of "Google Account"Add support for rtl locales
BUG=19896
TEST=Make sure the layout of gaia_login.html and merge_and_sync.html is correct in ltr and rtl
Patch by Bruno Calvignac, http://codereview.chromium.org/195082.
Review URL: http://codereview.chromium.org/244024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
unable to find tagged nodes) more gracefully by triggering the
unrecoverable error handler.
This was in response to a suggestion from chron, as we seem to hit this case a fair bit, and crashing is a pain. More importantly it's possible users are hitting it as well and having an explicit error case / message hidden on the options dialog is better than silently failing with no inkling as to what happened. It also just seems preferable to be in the PSS error state when this happens.
Review URL: http://codereview.chromium.org/201119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=19896
Review URL: http://codereview.chromium.org/194092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=21494,19896
TEST=SyncSetupWizardTest. Open sync wizard, ensure strings are present (error cases too).
Review URL: http://codereview.chromium.org/199083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Removes ProfilePersonalization (which is why the CL appears huge)
- Makes Profile do the work ProfilePersonalization did for creating PSS
- cloudy:stats > about:sync
- Removes the cloudy:// scheme and uses chrome:// for resources.
(Note SyncResourcesSource is a straight copy of CloudyResourceSource).
- Moves prefs and switches to pref_names and chrome_switches.
BUG=none
TEST=ProfileSyncServiceTest, LiveBookmarkSyncTests, SyncSetupWizardTest
Review URL: http://codereview.chromium.org/164544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22628 0039d316-1c4b-4281-b951-d872f2087c98
|