summaryrefslogtreecommitdiffstats
path: root/chrome/browser/sync/sync_ui_util.h
Commit message (Collapse)AuthorAgeFilesLines
* signin: pull basic SigninManager functionality into new SigninManagerBase class.tim@chromium.org2013-04-211-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | Removes chrome os ifdefs from SigninManager. SigninManagerBase provides all necessary functionality for that platform. I plan to change most callers of SigninManagerFactory::GetForProfile to use GetBaseForProfile in a follow up CL, and ultimately have the factory only create an SMB (versus a full SigninManager) on Chrome OS. TBR=sky@chromium.org for chrome/, chrome/browser, chrome/browser/ui, and chrome/test. TBR=zelidrag@chromium.org for chrome/browser/chromeos/login TBR=mpcomplete@chromium.org for chrome/browser/extensions/api/identity BUG=181451, 174927 Review URL: https://codereview.chromium.org/12502017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195410 0039d316-1c4b-4281-b951-d872f2087c98
* Move auth-error reporting code out of SyncGlobalError and into SigninGlobalErroratwilson@chromium.org2013-01-171-4/+0
| | | | | | | | | | | | | This is the first step towards enabling signin even when sync is disabled by policy. BUG=166148,113133 Relanding after rollout due to failures in ExtensionActionContextMenuTest.BrowserAction Review URL: https://codereview.chromium.org/11817045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177416 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 177136creis@chromium.org2013-01-161-0/+4
| | | | | | | | | | | | | | | | | > Move auth-error reporting code out of SyncGlobalError and into SigninGlobalError > > This is the first step towards enabling signin even when sync is disabled by > policy. > > BUG=166148,113133 > > > Review URL: https://chromiumcodereview.appspot.com/11817045 TBR=atwilson@chromium.org Review URL: https://codereview.chromium.org/11886079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177206 0039d316-1c4b-4281-b951-d872f2087c98
* Move auth-error reporting code out of SyncGlobalError and into SigninGlobalErroratwilson@chromium.org2013-01-161-4/+0
| | | | | | | | | | | | This is the first step towards enabling signin even when sync is disabled by policy. BUG=166148,113133 Review URL: https://chromiumcodereview.appspot.com/11817045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177136 0039d316-1c4b-4281-b951-d872f2087c98
* sync: Track validity of about:sync fieldsrlarocque@chromium.org2012-07-191-33/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit changes the way we initialize the fields which get exported to about:sync's about tab. The goal was to pre-declare all the data which would be exported in a complete snapshot, and to track which of these fields were actually set. Unset fields will have a default value and be specially highlighted on about:sync. This commit includes the changes necessary to perform this highlighting. Also in this commit are a few backend changes that are used to determine from sync_ui_util which fields are properly initialized and which fields have been unset by anything other than a default constructor. The signature for ProfileSyncService::QueryDetailedSyncStatus() has been modified to return an additional parameter indicating whether or not the returned status actually came from the backend. The SyncSesionSnapshot takes a different approach. The object is immutable and has two constructors. If it is constructed with the zero-argument constructor it is clearly uninitialized, and will remain so. This change adds a flag which is set or unset based on which constructor is used. Finally, the ConstructAboutInforation function and all its helpers have been moved out of sync_ui_util.cc and into their own file. BUG=134927 TEST= Review URL: https://chromiumcodereview.appspot.com/10696107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147531 0039d316-1c4b-4281-b951-d872f2087c98
* Remove #pragma once from chrome/browser/syncajwong@chromium.org2012-07-111-1/+0
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10689154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146068 0039d316-1c4b-4281-b951-d872f2087c98
* Removed ProfileSyncService::UIShouldDepictAuthInProgressatwilson@chromium.org2012-04-111-2/+6
| | | | | | | | | | | | Changed so all code queries the auth-in-progress status directly from SigninManager. BUG=95269 TEST=existing unit tests suffice Review URL: http://codereview.chromium.org/9959038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131709 0039d316-1c4b-4281-b951-d872f2087c98
* Remove PSS::ShowLoginDialog() and obsolete IDC_SYNC_BOOKMARKS.atwilson@chromium.org2012-02-251-8/+1
| | | | | | | | | | | | | | | | | | Changed calls to ShowLoginDialog() to go through LoginUIService() instead. Also noticed that IDC_SYNC_BOOKMARKS has been superceded by IDC_SHOW_SYNC_SETUP so changed the remaining uses over so we only have to maintain a single UI flow. Modified MainMenu.xib to generate IDC_SHOW_SYNC_SETUP instead of IDC_SYNC_BOOKMARKS when the user clicks on the menu item. TBR=jhawkins (for new_tab_page_sync_handler.cc which I believe is obsolete/unused) BUG=111859 TEST=bring up login via wrench/app menu. Review URL: http://codereview.chromium.org/9456031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123610 0039d316-1c4b-4281-b951-d872f2087c98
* Re-application of CL originally reviewed here: ↵jimblackler@google.com2011-11-301-1/+7
| | | | | | | | | | | | | | | | http://codereview.chromium.org/8383036 That CL was wound back after test failures not caught by commitbot. Those test failures fixed here. Adding parameter to GetStatusLabels to indicate if links are acceptable, as some platforms cannot handle links in all the places these messages are shown." This reverts commit 8a7d864f6069576f60bc9a63b9916d86a6157f96. BUG=N/A TEST=N/A Review URL: http://codereview.chromium.org/8634008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112194 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 110905 - Adding parameter to GetStatusLabels to indicate if links are ↵torne@chromium.org2011-11-211-7/+1
| | | | | | | | | | | | | | | | | acceptable, as some platforms cannot handle links in all the places these messages are shown. Also adding unit tests for other functionality of GetStatusLabels. BUG=none, discussed beforehand with akalin TEST=HtmlNotIncludedInStatusIfNotRequested Review URL: http://codereview.chromium.org/8383036 TBR=jimblackler@google.com Review URL: http://codereview.chromium.org/8613001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110909 0039d316-1c4b-4281-b951-d872f2087c98
* Adding parameter to GetStatusLabels to indicate if links are acceptable, as ↵jimblackler@google.com2011-11-211-1/+7
| | | | | | | | | | | | | | some platforms cannot handle links in all the places these messages are shown. Also adding unit tests for other functionality of GetStatusLabels. BUG=none, discussed beforehand with akalin TEST=HtmlNotIncludedInStatusIfNotRequested Review URL: http://codereview.chromium.org/8383036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110905 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the revert. This change was not the cause of the failures, so relanding.zea@chromium.org2011-11-171-0/+7
| | | | | | | | | | | | | | | | | | | | | Revert 110490 - Revert "[Sync] Add version info to about:sync" This reverts r110456. These tests have been failing on the Mac10.6 Sync builder since this was landed: ManyClientBookmarksSyncTest.Sanity ManyClientPasswordsSyncTest.Sanity ManyClientPreferencesSyncTest.Sanity BUG= TEST= Review URL: http://codereview.chromium.org/8590030 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/8585037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110532 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "[Sync] Add version info to about:sync"avi@chromium.org2011-11-171-7/+0
| | | | | | | | | | | | | | | | This reverts r110456. These tests have been failing on the Mac10.6 Sync builder since this was landed: ManyClientBookmarksSyncTest.Sanity ManyClientPasswordsSyncTest.Sanity ManyClientPreferencesSyncTest.Sanity BUG= TEST= Review URL: http://codereview.chromium.org/8590030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110490 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Add version info to about:synczea@chromium.org2011-11-171-0/+7
| | | | | | | | | | | | Version is in format <Browser Name> <Version> (<OS>) <Channel/Modifier info> BUG=97158 TEST=verify version info is in about:sync Review URL: http://codereview.chromium.org/8587017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110456 0039d316-1c4b-4281-b951-d872f2087c98
* Remove sync error button from bookmark barsail@chromium.org2011-10-271-3/+0
| | | | | | | | | | | | We now show sync errors in the wrench menu so we no longer need to show in the bookmark bar. BUG=101314 TEST= Review URL: http://codereview.chromium.org/8391034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107512 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress bubble view for CONNECTION_FAILED errorsail@chromium.org2011-10-171-4/+6
| | | | | | | | | | | | | | | | | | | | If there was a connection failed error then we woud display an error bubble view and wrench menu item. We're not supposed to display error messages for CONNECTION_FAILED errors so all the labels in the bubble view and wrench menu error item were blank. The problem was that we would decide when to show the error UI based on the auth error state. To fix this I simplified the code so that we show the error UI based directly on the presence of the error labels. This makes the code significantly simpler. I also added unit tests to make sure that we're returning labels when we should not not returning them when we shouldn't. BUG=100451 TEST= Review URL: http://codereview.chromium.org/8308005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105944 0039d316-1c4b-4281-b951-d872f2087c98
* Show bubble and wrench menu item for sync errorsail@chromium.org2011-09-211-0/+7
| | | | | | | | | | | | With this change we now show a bubble and menu item for actionable sync errors. BUG=92803 TEST= Review URL: http://codereview.chromium.org/7906013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102061 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync UI] Show only one sync status on personal options page.binji@chromium.org2011-09-151-0/+2
| | | | | | | | | | | | | Prior to this fix, the sync status would briefly display "Synced to ...@gmail.com. Last synced: Just now". BUG=84907 TEST=Go to chrome://settings/personal. Sign into sync. Click the "Enable Autofill..." checkbox. The sync status line should not change -- should still be "Last synced to ... Manage data on Google Dashboard". Review URL: http://codereview.chromium.org/7830019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101257 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Add passphrase/encryption info to chrome://sync.zea@chromium.org2011-08-041-0/+3
| | | | | | | | | | BUG=91134 TEST=Set up sync, inspect chrome://sync Review URL: http://codereview.chromium.org/7550023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95536 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/values.h into the base namespace. This includes a cros DEPS rolldmazzoni@chromium.org2011-07-121-2/+5
| | | | | | | | | | with a minor change to that code since libcros also uses base/values.h. BUG=88666 TEST=none Review URL: http://codereview.chromium.org/7259019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92208 0039d316-1c4b-4281-b951-d872f2087c98
* Sync: Inline sync login dialog into Tabbed Options.jhawkins@chromium.org2011-04-221-2/+0
| | | | | | | | | BUG=72363 TEST=none Review URL: http://codereview.chromium.org/6879125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82720 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI: Get rid of references to DOMUI in comments. The last part.tfarina@chromium.org2011-02-121-1/+1
| | | | | | | | | BUG=59945 TEST=trybots Review URL: http://codereview.chromium.org/6509004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74705 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DOMUI pref mode handling of Mac menu itemsstuartmorgan@chromium.org2011-01-251-4/+7
| | | | | | | | | | | In DOMUI pref mode, Mac menu items should open prefs via a browser window. Also fixes OpenSyncMyBookmarksDialog on all platforms. BUG=67670 TEST=Choosing a pref-opening menu item from the Chrome menu on Mac should open DOMUI prefs. Review URL: http://codereview.chromium.org/6293018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72500 0039d316-1c4b-4281-b951-d872f2087c98
* Create a new code path to generate sync strings for the new tab page ↵johnnyg@chromium.org2011-01-211-0/+5
| | | | | | | | | | | | | different from those used on the settings' page. This will allow us to show on the settings page the current sync status as well as a message regarding passwords. BUG=69622 TEST=see bug Review URL: http://codereview.chromium.org/6350008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72171 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Port about:sync to DOMUIakalin@chromium.org2011-01-141-0/+1
| | | | | | | | | | | | | | | | | Write chrome://sync-internals DOMUI page which is like about:sync but automatically updates on sync events. Make about:sync{,-internals} aliases for chrome://sync-internals. More diagnostic capabilities will be added to chrome://sync-internals in future CLs. BUG=69500 TEST=Manual Review URL: http://codereview.chromium.org/6299002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71435 0039d316-1c4b-4281-b951-d872f2087c98
* Add passphrase migration UI according to the flow chart for users who ↵johnnyg@chromium.org2011-01-081-1/+4
| | | | | | | | | | | require a passphrase the first time. BUG=63014,58935 TEST=test Review URL: http://codereview.chromium.org/5563004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70825 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] fix about:sync crash with unrecoverable errorakalin@chromium.org2010-10-151-1/+16
| | | | | | | | | | | | | | | If the client had encountered an unrecoverable error typing about:sync would crash because the client code would try to dereference the backendhost for the purpose of printing the model group information(by this time backendhost would have been released). The fix is to bail out of printing the model information if the client had encountered an unrecoverable error. however we would still print the client had encountered an urecoverable error and the line number etc. In the process moved a bunch of code related to collecting about information for sync, from browser_about_handler.cc to sync_ui_util.cc. The refactoing helps us in unit testing by passing in a mock service object. BUG=55503 TEST=Wrote a new unit test for it. ConstructAboutInformationWithUnrecoverableErrorTest. Also tested by pretending one of the datatypes generated an unrecoverable error in the debugger. Original patch by lipalani@google.com Original review: http://codereview.chromium.org/3715002 Review URL: http://codereview.chromium.org/3810011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62789 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* sync: Add two functions to sync_ui_util header and update the callers ↵akalin@chromium.org2010-01-061-0/+9
| | | | | | | | | | | | | accordingly. * ShouldShowSyncErrorButton: added. * GetSyncMenuLabel: added. (original code review: http://codereview.chromium.org/501142 , patch by thiago.farina@gmail.com ) Review URL: http://codereview.chromium.org/519069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35656 0039d316-1c4b-4281-b951-d872f2087c98
* Add a UI helper method to just get the sync status without needing labels.akalin@chromium.org2009-12-141-0/+2
| | | | | | | | | | | Patch by thiago.farina@gmail.com ( original code review: http://codereview.chromium.org/469017 ). BUG=none TEST=trybots Review URL: http://codereview.chromium.org/486044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34487 0039d316-1c4b-4281-b951-d872f2087c98
* Changed SyncStatusUIHelper namespace class into a real namespace ↵akalin@chromium.org2009-11-251-0/+36
(sync_ui_util), per style guide. Changed static functions into anonymous-namespace functions. Renamed files/namespaces from sync_status_ui_helper to sync_ui_util. Moved sync_ui_util_mac.mm functions into sync_ui_util namespace. Updated all callers. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/414065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33044 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 01:36:55 +0000