summaryrefslogtreecommitdiffstats
path: root/chrome/browser/sync
Commit message (Collapse)AuthorAgeFilesLines
* Update routing info and nudge syncer in ConfigureDataTypes().skrul@chromium.org2010-04-0210-85/+125
| | | | | | | | | | | | | | Here is an incomplete change that will reconfigure the routing info when the DTM calls ConfigureDataTypes. Some open questions: - How will the SBH actually nudge the syncer? I can add a SyncManager::Nudge method if that makes sense. - Looking at the nudge code, it looks like it is possible for nudges to get dropped on the floor. This could be really bad since sync can't start until the syncer thread runs and downloads updates for new data types. Is there a better way to make sure the syncer thread runs at this point? Also, I changed the callback method used for the SBH to notify the DTM that downloads are ready by switching the raw CancelableTask instance with a RunnableMethod. The previous version has the DTM touching the CancelableTask pointer after it was handed over to the SBH which was bad. This should be better. Review URL: http://codereview.chromium.org/1484001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43487 0039d316-1c4b-4281-b951-d872f2087c98
* Fix syncing deleted autofills and properly associate when an autofill is added.zork@chromium.org2010-04-023-23/+37
| | | | | | | | | BUG=39957 TEST=Manually test. Review URL: http://codereview.chromium.org/1546009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43445 0039d316-1c4b-4281-b951-d872f2087c98
* Move enable/disable storage to prefs.nick@chromium.org2010-04-028-35/+181
| | | | | | | | | | | | | | | | | | | | | | | The ProfileSyncService will manage the enabled/disabled types. Remove CustomizeSyncWindowView's DataTypeManager dependency; it should really just be operating on the preferences via the ProfileSyncService. Clarify the difference between types being enabled (meaning the user wants to sync them) versus being advertisable (meaning we support the datatype, and advertise that the user has the option of syncing it). BUG=34209,38340 TEST=After syncing, open the options dialog and recustomize your options. Verify that the enabled types from the wizard match the initial state of the options window. After changing the options and hitting "accept", observe that a breakpoint in DTM::Configure gets triggered, with exactly the new configuration set. Verify that the preferences are preserved on restart, as well as across Stop Syncing / Start Syncing. Review URL: http://codereview.chromium.org/1556009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43440 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a problem introduced by 41865 which causes sync notificationsakalin@chromium.org2010-04-011-0/+16
| | | | | | | | | | | to break for non-gmail.com accounts. BUG=40054 TEST=manual testing Review URL: http://codereview.chromium.org/1558013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43409 0039d316-1c4b-4281-b951-d872f2087c98
* Make last_download_timestamp and initial_sync_ended per-datatype.nick@chromium.org2010-04-0125-233/+822
| | | | | | | | | | | | | | | | | Persist them on a per-datatype basis. Add a migration from the old database scheme. In DownloadUpdates, pick the datatype(s) with the lowest last_download_timestamp; and fetch those. Keep running DownloadUpdatesCommand until we've gotten a "no-timestamp" result when requesting all datatypes. BUG=33065,37359,37331,37369,37373 TEST=included unit tests. Also, ran with Bookmark sync enabled, then added autofill the next time I started up, and observed that the incremental GetUpdates happened for autofill only, and that eventually the timestamps for bookmarks and autofill coalesced. Review URL: http://codereview.chromium.org/1521005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43397 0039d316-1c4b-4281-b951-d872f2087c98
* Add linux UI for enabling sync types.zork@chromium.org2010-04-013-2/+12
| | | | | | | | | BUG=none TEST=Go to the sync options on Linux, and click customize Review URL: http://codereview.chromium.org/1606003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43372 0039d316-1c4b-4281-b951-d872f2087c98
* Move the Nigori classes from base to sync.albertb@chromium.org2010-04-013-0/+405
| | | | | | | | | BUG=none TEST=NigoriTest Review URL: http://codereview.chromium.org/1549012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43366 0039d316-1c4b-4281-b951-d872f2087c98
* Annotate benign race in SyncherThread::IsSyncingCurrentlySilenced()timurrrr@chromium.org2010-04-011-1/+7
| | | | | | | | | | | | | | | | | | | | | | | Example of TSan report is: WARNING: Possible data race during write of size 8 at 0xEBC2AF0: {{{ T24 (SyncEngine_SyncerThread) (locks held: {L780}): #0 base::TimeTicks::operator=(base::TimeTicks) base/time.h:442 #1 browser_sync::SyncerThread::SyncMain(browser_sync::Syncer*) chrome/browser/sync/engine/syncer_thread.cc:418 #2 browser_sync::SyncerThread::ThreadMainLoop() chrome/browser/sync/engine/syncer_thread.cc:288 #3 browser_sync::SyncerThread::ThreadMain() chrome/browser/sync/engine/syncer_thread.cc:408 #4 void DispatchToMethod<browser_sync::SyncerThread, void (browser_sync::SyncerThread::*)()>(browser_sync::SyncerThread*, void (browser_sync::SyncerThread::*)(), Tuple0 const&) base/tuple.h:412 ... Concurrent read(s) happened at (OR AFTER) these points: T0 (locks held: {}): #0 base::TimeTicks::operator-(base::TimeTicks) const base/time.h:447 #1 browser_sync::SyncerThread::IsSyncingCurrentlySilenced() chrome/browser/sync/engine/syncer_thread.cc:202 #2 browser_sync::SyncerThreadWithSyncerTest::WaitForThrottle() chrome/browser/sync/engine/syncer_thread_unittest.cc:81 #3 browser_sync::SyncerThreadWithSyncerTest_Throttling_Test::TestBody() chrome/browser/sync/engine/syncer_thread_unittest.cc:666 #4 testing::Test::Run() testing/gtest/src/gtest.cc:2095 }}} Review URL: http://codereview.chromium.org/1575007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43327 0039d316-1c4b-4281-b951-d872f2087c98
* Add themes to new sync UI.dantasse@chromium.org2010-04-011-0/+1
| | | | | | | | | BUG=34209,32414 TEST=none Review URL: http://codereview.chromium.org/1582006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43312 0039d316-1c4b-4281-b951-d872f2087c98
* Send out a notification when the bookmark bar changes.zork@chromium.org2010-03-311-2/+10
| | | | | | | | | BUG=38559 TEST=Turn on preference sync. Run two chromes. Press ctrl+b on one. Ensure that the bookmark bar changes on the other. Review URL: http://codereview.chromium.org/1589007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43273 0039d316-1c4b-4281-b951-d872f2087c98
* fix the builddantasse@chromium.org2010-03-311-1/+1
| | | | | | | | TBR=ncarter Review URL: http://codereview.chromium.org/1551010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43258 0039d316-1c4b-4281-b951-d872f2087c98
* The "Customize Sync" dialog will let users select to sync or not sync each ↵dantasse@chromium.org2010-03-3131-453/+239
| | | | | | | | | | | | | | | | | | data type (bookmarks, preferences, etc). The Customize Sync dialog appears if you click a button on the gaia login or the Options->Personal Stuff tab. This button only appears if you've set the --enable-sync-preferences or --enable-sync-autofill command-line flag. On the Gaia login, the Customize Sync button grays out when you click 'sign in'. If the "customize sync" dialog is open, it closes when you click "cancel" on the Gaia login, and it accepts when you log in to Gaia. Removed "Merge and Sync" from the login sequence. Also deleted the 'merge_allowed' parameter from DataTypeController and its subclasses. Fixed strings so they all refer to "Google Chrome/Chromium sync" instead of "Bookmark sync". BUG=34209,27259 TEST=none Review URL: http://codereview.chromium.org/1134002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43256 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert 42551 "Add a "download" step into the DataTypeManager""skrul@chromium.org2010-03-316-27/+267
| | | | | | | | This is just reverting a previous revert, no code changes. This change was originally reverted due to valgrid issues that have been fixed elsewhere. Review URL: http://codereview.chromium.org/1528010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43222 0039d316-1c4b-4281-b951-d872f2087c98
* Fix and resubmit 42959zork@chromium.org2010-03-301-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1508005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43129 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a bug where themes wouldn't sync properly if it had been installedakalin@chromium.org2010-03-301-13/+20
| | | | | | | | | | | | | before. Did some refactoring and fixed comments. BUG=none TEST=manually Review URL: http://codereview.chromium.org/1543004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43128 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sync leaks and some more good stuff.skrul@chromium.org2010-03-3016-10/+67
| | | | | | | | | | | | | | This is a continuation of zork's change http://codereview.chromium.org/1354001 that adds some preventitive DCHECKs througout the sync code to make sure stuff happens on the UI thread. This also includes a leak fix in the ProfileSyncServiceTypedUrlTest. The final change is changing the TestingProfile to return a ProfileSyncServiceMock rather than a real ProfileSyncService. This should help prevent random test failes due to other tests that need to use the PSS. BUG=38490,38487 Review URL: http://codereview.chromium.org/1383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43102 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43009 - This change isn't as bad as it looks, basically it's ↵tim@chromium.org2010-03-307-310/+205
| | | | | | | | | | | templating the AutofillModelAssociator code so we can use it for both formfill (what I'm calling autofillV1 in this patch), and "profiles". Since the diffs didn't line up so well from having to move some implementation to the .h (template), I'm breaking up the review here with just the formfill code rearranged and no autofill++ impl. Review URL: http://codereview.chromium.org/1521002 TBR=tim@chromium.org Review URL: http://codereview.chromium.org/1559005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43055 0039d316-1c4b-4281-b951-d872f2087c98
* New autofill_specifics for autofill++ support.tim@chromium.org2010-03-301-0/+72
| | | | | | Review URL: http://codereview.chromium.org/1581001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43042 0039d316-1c4b-4281-b951-d872f2087c98
* This change isn't as bad as it looks, basically it's templating the ↵tim@chromium.org2010-03-297-205/+310
| | | | | | | | AutofillModelAssociator code so we can use it for both formfill (what I'm calling autofillV1 in this patch), and "profiles". Since the diffs didn't line up so well from having to move some implementation to the .h (template), I'm breaking up the review here with just the formfill code re-arranged and no autofill++ impl. Review URL: http://codereview.chromium.org/1521002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43009 0039d316-1c4b-4281-b951-d872f2087c98
* Use the invalid file handle value instead of 0 when creating pipes.zork@chromium.org2010-03-291-12/+16
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1409002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42996 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented initial version of themes syncing (behind a flag).akalin@chromium.org2010-03-2923-1/+1394
| | | | | | | | | BUG=32414 TEST=manual,unittests,trybot Review URL: http://codereview.chromium.org/1399001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42984 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting to fix the vista sync_unit_tests failures.ananta@chromium.org2010-03-291-1/+1
| | | | | | | | | | | | | | Revert 42959 - Make sure we poll immediately on the first syncer loop. BUG=36460 TEST=Try to enable sync on an Ubuntu VM that has been running less than 8 hours, and make sure it succeeds Review URL: http://codereview.chromium.org/1421003 TBR=zork@chromium.org Review URL: http://codereview.chromium.org/1568003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42968 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we poll immediately on the first syncer loop.zork@chromium.org2010-03-291-1/+1
| | | | | | | | | BUG=36460 TEST=Try to enable sync on an Ubuntu VM that has been running less than 8 hours, and make sure it succeeds Review URL: http://codereview.chromium.org/1421003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42959 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for negative routing info problem. We were replacing tokens afternick@chromium.org2010-03-264-10/+116
| | | | | | | | | | | failure multiple times. BUG=39214 TEST=included new fancy unit test Review URL: http://codereview.chromium.org/1294002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42738 0039d316-1c4b-4281-b951-d872f2087c98
* Scope the WriteTransactions during model association so that we don't lock ↵zork@chromium.org2010-03-263-136/+153
| | | | | | | | | | | the UI thread BUG=34206 TEST=none Review URL: http://codereview.chromium.org/1361002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42708 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up read FDs in async network alive. This prevents chrome from eating ↵zork@chromium.org2010-03-251-1/+17
| | | | | | | | | | | all FDs. BUG=35229 TEST=Let Chrome idle with a flakey net connection, and check that the number of open FDs is not increasing. Review URL: http://codereview.chromium.org/1336004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42678 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r42473. Add a delegate to CookieMonster and broadcast notifications ↵jochen@chromium.org2010-03-251-1/+1
| | | | | | | | | | | | | | about changes to cookies. This change will allow implementing the experimental cookie extension API, specifically the cookies.onChaned event BUG=none TEST=net_unittests TBR=jochen@ Review URL: http://codereview.chromium.org/1287001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42586 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42551 "Add a "download" step into the DataTypeManager"maruel@chromium.org2010-03-256-267/+27
| | | | | | | | | TEST=valgrind test: unit should turn green BUG=none Review URL: http://codereview.chromium.org/1313004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42571 0039d316-1c4b-4281-b951-d872f2087c98
* Add a "download" step into the DataTypeManagerskrul@chromium.org2010-03-246-27/+267
| | | | | | | | | | The download step invokies SBH::ConfigureDataTypes() and waits for the task callback. Currently SBH::ConfigureDataTypes() is stubbed out, it will be implemented in the next change. I also added some additional unit tests to the DTMImpl to make sure Stop() works while pasue and resume are pending, and to make sure the SYNC_CONFIGURE_DONE notification is always sent. Review URL: http://codereview.chromium.org/1311001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42551 0039d316-1c4b-4281-b951-d872f2087c98
* Remove vendor specific CSS prefixes.arv@chromium.org2010-03-242-122/+121
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/1182001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42488 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42473 - Add a delegate to CookieMonster and broadcast notifications ↵dhollowa@chromium.org2010-03-241-1/+1
| | | | | | | | | | | | | | | | about changes to cookies. This change will allow implementing the experimental cookie extension API, specifically the cookies.onChanged event BUG=38398 TEST=net_unittests Review URL: http://codereview.chromium.org/1023004 TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/1256003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42478 0039d316-1c4b-4281-b951-d872f2087c98
* Add a delegate to CookieMonster and broadcast notifications about changes to ↵jochen@chromium.org2010-03-241-1/+1
| | | | | | | | | | | | | cookies. This change will allow implementing the experimental cookie extension API, specifically the cookies.onChanged event BUG=38398 TEST=net_unittests Review URL: http://codereview.chromium.org/1023004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42473 0039d316-1c4b-4281-b951-d872f2087c98
* Make it clear what last_sync_timestamp actually tracks. Updatenick@chromium.org2010-03-2421-130/+210
| | | | | | | | | | | | | | | | last_sync_timestamp from the new_timestamp only, never from per-entry timestamps. Use what the server sends us to know whether or not there are more updates to fetch. Eliminate some unnecessarily complicated logic having to do with the # of updates returned -- that's always a red herring; with server-side filtering, it is indeed possible for 0 updates to be returned along with a new timestamp. BUG=37373 TEST=manual testing of 2 browser sync; unit tests. Review URL: http://codereview.chromium.org/1161006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42413 0039d316-1c4b-4281-b951-d872f2087c98
* This is basically a rewrite of the DataTypeManager to support dynamic data ↵skrul@chromium.org2010-03-238-283/+645
| | | | | | | | | | type configuration. DTM::Start() has been replaced with DTM::Configure(). Note that the callback is also gone, replaced with notification service style notifications to tell listeners that configuration has started or finished. I also added some stuff to prepare for adding the "initial download" step for new datatype into the configure process. Review URL: http://codereview.chromium.org/1128012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42384 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage by adding friend decl.tim@chromium.org2010-03-231-1/+1
| | | | | | | TBR=nick Review URL: http://codereview.chromium.org/1192001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42371 0039d316-1c4b-4281-b951-d872f2087c98
* Disable SyncerThreadWithSyncerTest.Pause. It's timing out, so I can't use ↵tim@chromium.org2010-03-231-1/+2
| | | | | | | | | | | FLAKY :( TBR=skrul BUG=39070 Review URL: http://codereview.chromium.org/1189001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42369 0039d316-1c4b-4281-b951-d872f2087c98
* Removed win32socketserver and its use in mediator_thread_impl.cc.akalin@chromium.org2010-03-231-25/+0
| | | | | | | | | BUG=38595 TEST=trybots, manual Review URL: http://codereview.chromium.org/1110007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42313 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/gfx/canvas and app/gfx/font to gfx/.ben@chromium.org2010-03-231-1/+1
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1132006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42312 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor Directory/Directory::Kernel to eliminate some duplicate variable ↵nick@chromium.org2010-03-222-51/+49
| | | | | | | | | | | | | declarations. Add a PersistedKernelInfo member to the directory kernel, rather than having parallel members. BUG=37331 TEST=unit tests. Review URL: http://codereview.chromium.org/1078004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42265 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate a race between the syncerthread delivering PAUSEDnick@chromium.org2010-03-221-11/+11
| | | | | | | | notifications and the syncmanager subscribing to them. Review URL: http://codereview.chromium.org/1096006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42257 0039d316-1c4b-4281-b951-d872f2087c98
* Pass the raw history backend pointer to the gmock action rather than the refptr.skrul@chromium.org2010-03-221-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1072009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42230 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the integration test harness by using the max_local_timestamptim@chromium.org2010-03-194-8/+44
| | | | | | | | | | | from the sync engine rather than waiting for "a couple syncs" to happen before declaring sync "done". BUG=37351 Review URL: http://codereview.chromium.org/1042008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42134 0039d316-1c4b-4281-b951-d872f2087c98
* Combine similar code from sync unit tests and add additional unit tests for ↵zork@chromium.org2010-03-194-204/+233
| | | | | | | | | | | typed url syncing. BUG=none TEST=run unit tests Review URL: http://codereview.chromium.org/1124002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42048 0039d316-1c4b-4281-b951-d872f2087c98
* Move image codec stuff to toplevel gfx.ben@chromium.org2010-03-181-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41911 0039d316-1c4b-4281-b951-d872f2087c98
* Update sync to support syncing of typed urlszork@chromium.org2010-03-1826-5/+2000
| | | | | | Review URL: http://codereview.chromium.org/896001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41901 0039d316-1c4b-4281-b951-d872f2087c98
* Pause the sync thread while starting data types.skrul@chromium.org2010-03-1719-51/+339
| | | | | | | | | | | | | A few things to note: - I ended the plubming (it's-a me, mario!) at the SyncBackendHost (the PSS does not know about pausing). The SyncBackendHost now has RequestPause/RequestResume methods. The notifications that are sent when pause and resume is complete are dispatched to the notification service by the SyncBackendHost. - Calls to SHB::Request(Pause|Resume) go directly to the similar named methods on the SyncerThread. This is unlike other methods on the SHB which are usually dispatched to the "core" thread before calling deeper into the onion. I did this to avoid having to deal with callbacks to carry the result value of pause/resume (since the methods can fail and return false). If this is a problem I can change the way it works. - There is a little trickery regarding the integration unit tests since we typically use a specially initialized SBH for these tests, and the syncer thread does not really run for these tests. Since the thread is not running, pause and resume won't work properly. To get around this, the DataTypeManagerImpl in these tests is constructed with a mock SBH that will respond properly to pause and resume requests. BUG=37154,37553 Review URL: http://codereview.chromium.org/1063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41883 0039d316-1c4b-4281-b951-d872f2087c98
* Removed auth_task.* and talk_auth_task.* (dead code)akalin@chromium.org2010-03-1721-1435/+21
| | | | | | | | | | | | | | | Removed GaiaAuth class. Gtalk login will now fail immediately instead of trying (in vain) to gaia-auth. Removed now-unneeded parameters. BUG=38034 TEST=manual with and without --invalidate-sync-xmpp-login Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41790 Review URL: http://codereview.chromium.org/885008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41865 0039d316-1c4b-4281-b951-d872f2087c98
* Change observer expectationsskrul@chromium.org2010-03-172-24/+44
| | | | | | | | This should prevent some test flakyness we saw on vista. Review URL: http://codereview.chromium.org/977003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41857 0039d316-1c4b-4281-b951-d872f2087c98
* Add a lock to read |state_| in UIModelWorker::DoWorkAndWait. We don'ttim@chromium.org2010-03-172-8/+8
| | | | | | | | | | | | | | | strictly need to acquire the lock here because this can only get called while !syncapi_has_shutdown_ and STOPPED could only get set after that bool is false (and that bool is protected by locks), the purpose of this DCHECK/return is for catching developer error in extraordinary cases, so in a way, adding ANNOTATE_UNPROTECTED_READ would seem hypocritical. BUG=32892 TEST=UIModelWorkerTest Review URL: http://codereview.chromium.org/965002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41840 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41790 - Removed auth_task.* and talk_auth_task.* (dead code) because ↵hbono@google.com2010-03-1721-18/+1436
| | | | | | | | | | | | | | | | | | Windows XP doesn't have inet_pton and it crashes XP bots. Removed GaiaAuth class. Gtalk login will now fail immediately instead of trying (in vain) to gaiaauth. Removed nowunneeded parameters. BUG=38034 TEST=manual with and without invalidatesyncxmpplogin Review URL: http://codereview.chromium.org/885008 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/983005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41808 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 11:24:20 +0000