| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
sync_setup_wizard.cc
so that we can append the language code as a CGI parameter based on the locale.
BUG=26385
TEST=Make sure links on the sync login dialog open pages in the same language as the browser language.
Review URL: http://codereview.chromium.org/385103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a node *after* disassocating from the maps.
BUG=27580
Review URL: http://codereview.chromium.org/391056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the really hard ones which will need actual review instead of rubber-stamping.)
Review URL: http://codereview.chromium.org/386026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in chron's CL to avoid merge.
Review URL: http://codereview.chromium.org/393011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=27630
TEST=n/a
TBR=nick
Review URL: http://codereview.chromium.org/393012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/276071 by randy.posynick@gmail.com
Don't overwrite email with lowercase value from GetUserInfo().
BUG=20848
TEST=See bug for description
TBR=brg@chromium.org
Review URL: http://codereview.chromium.org/392016
TBR=idana@chromium.org
Review URL: http://codereview.chromium.org/384106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
randy.posynick@gmail.com
Don't overwrite email with lowercase value from GetUserInfo().
BUG=20848
TEST=See bug for description
TBR=brg@chromium.org
Review URL: http://codereview.chromium.org/392016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=19738
TEST=Get a Google Account into captcha state. Start syncing. You should
be presented with a captcha image and textbox to answer the challenge.
Doing so correctly shoud unlock your account and proceed with sync setup.
Review URL: http://codereview.chromium.org/389017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
otherwise idle.
BUG=19784, 26988
TEST=1. Enable sync and log in.
2. Go to about:sync
3. Check that notifications are enabled.
4. Disable all network adapters, and wait 15 seconds.
5. Refresh about:sync, and ensure that notifications are disabled.
Review URL: http://codereview.chromium.org/391027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added ProfileSyncService::IsSyncEnabled().
BUG=23073
TEST=manually (OS X),trybot
Review URL: http://codereview.chromium.org/389019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added GoogleServiceAuthError, which is the same as the incumbent AuthErrorState but can support captcha information too. I moved it because it just had nothing specific to sync about it. This CL is mostly a rename and basic plumbing CaptchaRequired error state from browser_sync::AuthWatcher through to UI thread.
Ben, I added a .h to chrome/browser/ alongside other google_* stuff. I'm just looking for your blessing here, or suggestion of alternate location.
BUG=19738
Review URL: http://codereview.chromium.org/384040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/385023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=19784
TEST=On a system with two network adapters, ensure one has an active internet
connection, and the other does not. Disconnect the active one, and check that
in notifier::NetworkStatusDetectorTaskMT::OnNetworkAliveDone() the call to
network_alive->alive() returns false.
Review URL: http://codereview.chromium.org/377019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Change sync id to bookmark id map to sync id to bookmark node map
- Make other appropriate changes.
BUG=26141
TEST=Exist.
Review URL: http://codereview.chromium.org/383002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
help minimize diffs from) a larger CL.
(Cloned from http://codereview.chromium.org/371071, which was part of an http:// checkout,
and this one is an svn:// checkout, so that I can commit).
BUG=25266
Review URL: http://codereview.chromium.org/371092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/355046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26749
Review URL: http://codereview.chromium.org/372013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Get rid of sync_char16 from syncapi
- Use wstring for title in syncapi since that gets converted to wstring
later on anyway.
- Use GURL for urls in syncapi
- Return const string references from syncapi instead of pointers to
C-style strings.
- Make appropriate changes to calling code.
BUG=26342
TEST=Already exist.
Review URL: http://codereview.chromium.org/362019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out that the v10 -> v11 database migration code had a bug
where the destination file (SyncData.sqlite3) wasn't copied into the
correct directory. I fixed that problem too.
BUG=21834
Review URL: http://codereview.chromium.org/366011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=None
Original patch by Thiago Farina <thiago.farina@gmail.com> at
http://codereview.chromium.org/296004
Review URL: http://codereview.chromium.org/373013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
process commands. This fixes the problem where the auto-reconnect posts a
login command just after the client connects, just before a listen for updates
command is posted.
BUG=24245
TEST=Send a CMD_LISTEN_FOR_UPDATES immediately after the CMD_LOGIN in
MediatorThreadImpl::Login() Chromium will no longer crash.
Review URL: http://codereview.chromium.org/372011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bustage seems to be a WebKit change upstream. It is not reverted in
WebKit and merger. So bring the innocent change back in.
TBR=jam
TEST=green tree
Review URL: http://codereview.chromium.org/375009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
XP tests are failing, the guess is r31175 and r31176.
TBR=beng
TEST=XP tests go green
Review URL: http://codereview.chromium.org/376008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
event_sys_unittests.cc
BUG=21833
Review URL: http://codereview.chromium.org/360040
TBR=idana@chromium.org
Review URL: http://codereview.chromium.org/361035
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/377001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=26749
Review URL: http://codereview.chromium.org/371006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26749
Review URL: http://codereview.chromium.org/361025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=26749
Review URL: http://codereview.chromium.org/360043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/369006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=akalin
Review URL: http://codereview.chromium.org/360047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
event_sys_unittests.cc
BUG=21833
Review URL: http://codereview.chromium.org/360040
TBR=idana@chromium.org
Review URL: http://codereview.chromium.org/361035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=21833
Review URL: http://codereview.chromium.org/360040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=7228-7241
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/360037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use FilePath for real file paths.
- Use std::string for PathString on Windows as well
TODO in a separate CL:
- Get rid of PathString typedef completely and directly use std::string everywhere.
- Use wchar_t in syncapi.h/.cc and get rid of sync_char16.
TEST=Existing tests are sufficient since this CL does a lot of code refactoring.
BUG=26342
Review URL: http://codereview.chromium.org/340055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TESTED=tested sync setup wizard on OS X
Review URL: http://codereview.chromium.org/348070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This helps clarify UpdateApplicator and removes SyncerSession from SyncerUtil.
Part of work to separate sync session "context" like the ConflictResolver, ServerConnectionManager,
ModelSafeWorker, etc from progress state.
BUG=25266
TEST=sync unit tests
Review URL: http://codereview.chromium.org/351026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26493
Review URL: http://codereview.chromium.org/353011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TODO: Use LoadLog in FLIP code.
Review URL: http://codereview.chromium.org/344026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ChromeThread instead.
BUG=25354
Review URL: http://codereview.chromium.org/342068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is just cleanup.
Take 2 with a fix in sync code.
TBR=evanm
Review URL: http://codereview.chromium.org/350007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux and OSX.
BUG=none
TEST=Enable bookmark sync, close and re-launch chrome, make sure there are no sync error message at the bottom of the NTP.
Original patch by albertb@chromium.org
Committed by davemoore@chromium.org
Review URL: http://codereview.chromium.org/341012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=19980
TEST=See the steps in the bug description.
Patch by Randy Posynick<randy.posynick@gmail.com>
http://codereview.chromium.org/287008
Review URL: http://codereview.chromium.org/339075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
time_posix.cc has the actual code and compiles on Linux
already. Including both files causes linker errors for
the shared build.
BUG=none
TEST=compiles on trybots
Review URL: http://codereview.chromium.org/341035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
comparing signed and unsigned values.
BUG=tree break
TEST=none
Review URL: http://codereview.chromium.org/339070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23978
TEST=Added unit test
Review URL: http://codereview.chromium.org/343041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=munjal@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fail the load assocications if there the total number of
nodes in the bookmark model and the sync model don't match
(issue: 25542)
- Add a bookmark id index and use that during load assocications
instead of calling BookmarkModel::GetNodeByID since the latter
traverses the entier tree in DFS order until it finds the node
with the given ID.
- Add a unit test that would exercise the new model associator
load associations behavior.
BUG=25542
TEST=Unit test added.
Review URL: http://codereview.chromium.org/337037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=1. Enable bookmark sync on Linux.
2. Options -> Sync my bookmarks
3. Log in.
4: Go to "about:sync" and check that "Notifications Enabled" is true.
Review URL: http://codereview.chromium.org/339056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Original: http://codereview.chromium.org/325001/show
TEST=ExtensionsActivityMonitorTest
Review URL: http://codereview.chromium.org/333041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
These are mostly minor syntax / missing header fixes.
Review URL: http://codereview.chromium.org/338037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30277 0039d316-1c4b-4281-b951-d872f2087c98
|