summaryrefslogtreecommitdiffstats
path: root/chrome/browser/sync
Commit message (Collapse)AuthorAgeFilesLines
* Moved the various Google Accounts URLs out of gaia_login.html and into ↵idana@chromium.org2009-11-142-4/+39
| | | | | | | | | | | | | sync_setup_wizard.cc so that we can append the language code as a CGI parameter based on the locale. BUG=26385 TEST=Make sure links on the sync login dialog open pages in the same language as the browser language. Review URL: http://codereview.chromium.org/385103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31968 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash described in 27580 by telling bookmark model to removemunjal@chromium.org2009-11-131-1/+1
| | | | | | | | | | a node *after* disassocating from the maps. BUG=27580 Review URL: http://codereview.chromium.org/391056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31943 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-1313-27/+28
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of removing PathSTring. I scrubbed files that are notmunjal@chromium.org2009-11-1319-45/+54
| | | | | | | | in chron's CL to avoid merge. Review URL: http://codereview.chromium.org/393011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31930 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ProfileSyncServiceTest_ServerChangeProcessing due to purify error.scherkus@chromium.org2009-11-131-1/+2
| | | | | | | | | | | BUG=27630 TEST=n/a TBR=nick Review URL: http://codereview.chromium.org/393012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31917 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31865 - This change is patched from ↵idana@chromium.org2009-11-131-6/+12
| | | | | | | | | | | | | | | | | http://codereview.chromium.org/276071 by randy.posynick@gmail.com Don't overwrite email with lowercase value from GetUserInfo(). BUG=20848 TEST=See bug for description TBR=brg@chromium.org Review URL: http://codereview.chromium.org/392016 TBR=idana@chromium.org Review URL: http://codereview.chromium.org/384106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31872 0039d316-1c4b-4281-b951-d872f2087c98
* This change is patched from http://codereview.chromium.org/276071 by ↵idana@chromium.org2009-11-131-12/+6
| | | | | | | | | | | | | | randy.posynick@gmail.com Don't overwrite email with lowercase value from GetUserInfo(). BUG=20848 TEST=See bug for description TBR=brg@chromium.org Review URL: http://codereview.chromium.org/392016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31865 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the gaia captcha state and unlock capability in the sync setup wizard.tim@chromium.org2009-11-1213-77/+249
| | | | | | | | | | | BUG=19738 TEST=Get a Google Account into captcha state. Start syncing. You should be presented with a captcha image and textbox to answer the challenge. Doing so correctly shoud unlock your account and proceed with sync setup. Review URL: http://codereview.chromium.org/389017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31829 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mediator_thread_impl.cc to run timer tasks when the task runner iszork@google.com2009-11-121-9/+10
| | | | | | | | | | | | | | | otherwise idle. BUG=19784, 26988 TEST=1. Enable sync and log in. 2. Go to about:sync 3. Check that notifications are enabled. 4. Disable all network adapters, and wait 15 seconds. 5. Refresh about:sync, and ensure that notifications are disabled. Review URL: http://codereview.chromium.org/391027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31820 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on sync for OS X (behind an --enable-sync switch).akalin@chromium.org2009-11-122-0/+13
| | | | | | | | | | | Added ProfileSyncService::IsSyncEnabled(). BUG=23073 TEST=manually (OS X),trybot Review URL: http://codereview.chromium.org/389019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31789 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of implementing captcha for sync dialog. tim@chromium.org2009-11-1110-120/+83
| | | | | | | | | | | | Added GoogleServiceAuthError, which is the same as the incumbent AuthErrorState but can support captcha information too. I moved it because it just had nothing specific to sync about it. This CL is mostly a rename and basic plumbing CaptchaRequired error state from browser_sync::AuthWatcher through to UI thread. Ben, I added a .h to chrome/browser/ alongside other google_* stuff. I'm just looking for your blessing here, or suggestion of alternate location. BUG=19738 Review URL: http://codereview.chromium.org/384040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31729 0039d316-1c4b-4281-b951-d872f2087c98
* A large number of style nits in preparation for turning on automated cpplint.py.erg@google.com2009-11-115-10/+11
| | | | | | Review URL: http://codereview.chromium.org/385023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31669 0039d316-1c4b-4281-b951-d872f2087c98
* Check for an active network connection when network adapter status changes.zork@google.com2009-11-111-1/+17
| | | | | | | | | | | | BUG=19784 TEST=On a system with two network adapters, ensure one has an active internet connection, and the other does not. Disconnect the active one, and check that in notifier::NetworkStatusDetectorTaskMT::OnNetworkAliveDone() the call to network_alive->alive() returns false. Review URL: http://codereview.chromium.org/377019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31623 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 26141munjal@chromium.org2009-11-103-47/+30
| | | | | | | | | | | | - Change sync id to bookmark id map to sync id to bookmark node map - Make other appropriate changes. BUG=26141 TEST=Exist. Review URL: http://codereview.chromium.org/383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31597 0039d316-1c4b-4281-b951-d872f2087c98
* Removes blocked items. Also, some minor cleanup in preparation for (and to ↵tim@chromium.org2009-11-1018-317/+8
| | | | | | | | | | | | | | help minimize diffs from) a larger CL. (Cloned from http://codereview.chromium.org/371071, which was part of an http:// checkout, and this one is an svn:// checkout, so that I can commit). BUG=25266 Review URL: http://codereview.chromium.org/371092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31528 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few spelling mistakes.nick@chromium.org2009-11-093-7/+7
| | | | | | Review URL: http://codereview.chromium.org/355046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31498 0039d316-1c4b-4281-b951-d872f2087c98
* Ninth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-075-2/+16
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/372013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31357 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of string cleanup in Sync:munjal@chromium.org2009-11-067-172/+118
| | | | | | | | | | | | | | | | | | - Get rid of sync_char16 from syncapi - Use wstring for title in syncapi since that gets converted to wstring later on anyway. - Use GURL for urls in syncapi - Return const string references from syncapi instead of pointers to C-style strings. - Make appropriate changes to calling code. BUG=26342 TEST=Already exist. Review URL: http://codereview.chromium.org/362019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31298 0039d316-1c4b-4281-b951-d872f2087c98
* Got rid of DieFileDie in user_settings_unittest.cc.idana@chromium.org2009-11-062-32/+49
| | | | | | | | | | | | It turns out that the v10 -> v11 database migration code had a bug where the destination file (SyncData.sqlite3) wasn't copied into the correct directory. I fixed that problem too. BUG=21834 Review URL: http://codereview.chromium.org/366011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31272 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetSwitchValueASCII.tony@chromium.org2009-11-061-2/+3
| | | | | | | | | | | | BUG=24672 TEST=None Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/296004 Review URL: http://codereview.chromium.org/373013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31269 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the mediator thread to check for a valid xmpp client before trying tozork@google.com2009-11-061-3/+18
| | | | | | | | | | | | | | process commands. This fixes the problem where the auto-reconnect posts a login command just after the client connects, just before a listen for updates command is posted. BUG=24245 TEST=Send a CMD_LISTEN_FOR_UPDATES immediately after the CMD_LOGIN in MediatorThreadImpl::Login() Chromium will no longer crash. Review URL: http://codereview.chromium.org/372011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31242 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert r31175 r31176 r31187"hclam@chromium.org2009-11-061-1/+3
| | | | | | | | | | | | The bustage seems to be a WebKit change upstream. It is not reverted in WebKit and merger. So bring the innocent change back in. TBR=jam TEST=green tree Review URL: http://codereview.chromium.org/375009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31214 0039d316-1c4b-4281-b951-d872f2087c98
* Rever r31175 r31176 r31187hclam@chromium.org2009-11-061-3/+1
| | | | | | | | | | | XP tests are failing, the guess is r31175 and r31176. TBR=beng TEST=XP tests go green Review URL: http://codereview.chromium.org/376008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31201 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31122 - Revert 31109 Avoid calling PlatformThread::Sleep(1) from ↵idana@chromium.org2009-11-061-1/+1
| | | | | | | | | | | | | | | | event_sys_unittests.cc BUG=21833 Review URL: http://codereview.chromium.org/360040 TBR=idana@chromium.org Review URL: http://codereview.chromium.org/361035 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/377001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31194 0039d316-1c4b-4281-b951-d872f2087c98
* Seventh patch in making destructors of refcounted objects private.jam@chromium.org2009-11-062-0/+4
| | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/371006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31192 0039d316-1c4b-4281-b951-d872f2087c98
* Fifth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-061-1/+3
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/361025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31175 0039d316-1c4b-4281-b951-d872f2087c98
* Fourth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-051-1/+2
| | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/360043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31167 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the high res timer, which is unused.nick@chromium.org2009-11-058-410/+0
| | | | | | Review URL: http://codereview.chromium.org/369006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31149 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the extensions activity monitor test for POSIX (c:\? Really?)nick@chromium.org2009-11-051-12/+17
| | | | | | | | R=akalin Review URL: http://codereview.chromium.org/360047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31138 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31109 - Avoid calling PlatformThread::Sleep(1) from ↵ben@chromium.org2009-11-051-1/+1
| | | | | | | | | | | | | event_sys_unittests.cc BUG=21833 Review URL: http://codereview.chromium.org/360040 TBR=idana@chromium.org Review URL: http://codereview.chromium.org/361035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31122 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid calling PlatformThread::Sleep(1) from event_sys_unittests.ccidana@chromium.org2009-11-051-1/+1
| | | | | | | | BUG=21833 Review URL: http://codereview.chromium.org/360040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31109 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix unnecessary Singleton object instantiation.mattm@chromium.org2009-11-051-1/+1
| | | | | | | | | | CID=7228-7241 BUG=none TEST=none Review URL: http://codereview.chromium.org/360037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31056 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the strings for sync code:munjal@chromium.org2009-11-0446-1410/+390
| | | | | | | | | | | | | | | | - Use FilePath for real file paths. - Use std::string for PathString on Windows as well TODO in a separate CL: - Get rid of PathString typedef completely and directly use std::string everywhere. - Use wchar_t in syncapi.h/.cc and get rid of sync_char16. TEST=Existing tests are sufficient since this CL does a lot of code refactoring. BUG=26342 Review URL: http://codereview.chromium.org/340055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30970 0039d316-1c4b-4281-b951-d872f2087c98
* Added scale hack to work around Windows font metric issue.akalin@chromium.org2009-11-041-3/+14
| | | | | | | | | BUG=none TESTED=tested sync setup wizard on OS X Review URL: http://codereview.chromium.org/348070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30946 0039d316-1c4b-4281-b951-d872f2087c98
* Remove context-based dependencies on SyncerSession from ApplyUpdatesCommand.tim@chromium.org2009-11-038-46/+48
| | | | | | | | | | | | | | This helps clarify UpdateApplicator and removes SyncerSession from SyncerUtil. Part of work to separate sync session "context" like the ConflictResolver, ServerConnectionManager, ModelSafeWorker, etc from progress state. BUG=25266 TEST=sync unit tests Review URL: http://codereview.chromium.org/351026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30868 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mem leak in sync tests by ensuring that the destruction tasks get to run.jam@chromium.org2009-11-031-0/+4
| | | | | | | | BUG=26493 Review URL: http://codereview.chromium.org/353011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30789 0039d316-1c4b-4281-b951-d872f2087c98
* Add LoadLog to ClientSocket::Connect().willchan@chromium.org2009-11-022-3/+9
| | | | | | | | TODO: Use LoadLog in FLIP code. Review URL: http://codereview.chromium.org/344026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30765 0039d316-1c4b-4281-b951-d872f2087c98
* Third patch in getting rid of caching MessageLoop pointers and always using ↵jam@chromium.org2009-11-023-11/+25
| | | | | | | | | | ChromeThread instead. BUG=25354 Review URL: http://codereview.chromium.org/342068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30687 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome_url_data_manager (previously a global) into a Singleton. Thistony@chromium.org2009-10-301-1/+2
| | | | | | | | | | | | is just cleanup. Take 2 with a fix in sync code. TBR=evanm Review URL: http://codereview.chromium.org/350007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30622 0039d316-1c4b-4281-b951-d872f2087c98
* Use the password_manager encryptor to encrypt the sync credentials under ↵davemoore@chromium.org2009-10-301-9/+43
| | | | | | | | | | | | | | Linux and OSX. BUG=none TEST=Enable bookmark sync, close and re-launch chrome, make sure there are no sync error message at the bottom of the NTP. Original patch by albertb@chromium.org Committed by davemoore@chromium.org Review URL: http://codereview.chromium.org/341012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30611 0039d316-1c4b-4281-b951-d872f2087c98
* Disable form entry while sending credentials. tim@chromium.org2009-10-301-1/+6
| | | | | | | | | | | | BUG=19980 TEST=See the steps in the bug description. Patch by Randy Posynick<randy.posynick@gmail.com> http://codereview.chromium.org/287008 Review URL: http://codereview.chromium.org/339075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30542 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Remove unnecessary time_linux.cc from sync code.craig.schlenter@chromium.org2009-10-291-7/+0
| | | | | | | | | | | | | time_posix.cc has the actual code and compiles on Linux already. Including both files causes linker errors for the shared build. BUG=none TEST=compiles on trybots Review URL: http://codereview.chromium.org/341035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30492 0039d316-1c4b-4281-b951-d872f2087c98
* Gosh, fix a typo to really fix the tree.munjal@chromium.org2009-10-291-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30488 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the warning treated as error on linux 64 bit build ofmunjal@chromium.org2009-10-291-2/+2
| | | | | | | | | | | comparing signed and unsigned values. BUG=tree break TEST=none Review URL: http://codereview.chromium.org/339070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30487 0039d316-1c4b-4281-b951-d872f2087c98
* Try to revive the revision 30441 which was reverted in 30443.munjal@chromium.org2009-10-292-6/+87
| | | | | | | | | BUG=23978 TEST=Added unit test Review URL: http://codereview.chromium.org/343041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30484 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r30441. Fails compile on linux x64.aa@chromium.org2009-10-292-87/+6
| | | | | | TBR=munjal@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30443 0039d316-1c4b-4281-b951-d872f2087c98
* Make some improvements to sync model associator:munjal@chromium.org2009-10-292-6/+87
| | | | | | | | | | | | | | | | | | | - Fail the load assocications if there the total number of nodes in the bookmark model and the sync model don't match (issue: 25542) - Add a bookmark id index and use that during load assocications instead of calling BookmarkModel::GetNodeByID since the latter traverses the entier tree in DFS order until it finds the node with the given ID. - Add a unit test that would exercise the new model associator load associations behavior. BUG=25542 TEST=Unit test added. Review URL: http://codereview.chromium.org/337037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30441 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the notifier SSL layer to make notifications work for Linux Bookmark sync.zork@chromium.org2009-10-292-53/+43
| | | | | | | | | | | | | BUG=none TEST=1. Enable bookmark sync on Linux. 2. Options -> Sync my bookmarks 3. Log in. 4: Go to "about:sync" and check that "Notifications Enabled" is true. Review URL: http://codereview.chromium.org/339056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30421 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at browser_sync::ExtensionsActivityMonitor.tim@chromium.org2009-10-2811-7/+506
| | | | | | | | | | Original: http://codereview.chromium.org/325001/show TEST=ExtensionsActivityMonitorTest Review URL: http://codereview.chromium.org/333041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30313 0039d316-1c4b-4281-b951-d872f2087c98
* linux: fix gcc 4.3 issues (for arm)piman@chromium.org2009-10-276-10/+14
| | | | | | | | These are mostly minor syntax / missing header fixes. Review URL: http://codereview.chromium.org/338037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30277 0039d316-1c4b-4281-b951-d872f2087c98