| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetClientDataForCurrentRequest: The particular use case I need this
for is that I'm using the same CancelableRequestConsumer for multiple
sources so that I don't know whic CancelableRequestProvider to pass in
to GetClientData. None-the-less it seems a lot easier to use this when
always get the provider and handle.
GetFirstHandleForClientData: For this one I know I want to cancel a
request for a given client data but don't know the associated handle.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3311012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adding/Moving dtors of objects that have CancelableRequestConsumers shaves
three megs off browser.a.
- Adding/Moving dtors of objects that have ScopedRunnableMethodFactories only
shaved 100k off browser.a/renderer.a.
- Adding/Moving dtors of objects that used some form of base::*Timer<> was
negligible; there were only a few classes that had a Timer but had a
ctor/dtor in the header after the previous cleanups.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3278006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/3291002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed --sync-use-chrome-async-socket switch, added
--sync-disable-chrome-async-socket switch.
BUG=45612
TEST=manually
Review URL: http://codereview.chromium.org/3304001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XmppClientSocketFactory serves up regular TCP sockets or fake SSL TCP
sockets. This way, ChromeAsyncSocket has feature parity with
XmppSocketAdapter.
BUG=45612
TEST=existing unittests
Review URL: http://codereview.chromium.org/3299001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids requiring prompting the user for a passphrase on each
start.
TEST=CryptographerTest, CryptographerPackUnpackTest
Review URL: http://codereview.chromium.org/3216001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves all sorts of code from h files to cc files and reduces header
dependencies.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3212008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50548
TEST=compiles
Review URL: http://codereview.chromium.org/3280008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to GetTitle().
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3279005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
default values instead.
BUG=chromium-os:5933
TEST=manually
Review URL: http://codereview.chromium.org/3181035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This converts lots of (wstring) GetTitle()s to (string16) GetTitleAsString16().
Soon, I'll be able to delete the former, and rename the latter (s/AsString16//).
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3226004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I changed the type of this function, but the trybots didn't catch
it because it's in an offical-only ifdef.
Review URL: http://codereview.chromium.org/3236006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was trying to replace wstring usage in base::FileVersionInfo, but
that class is rather Windows-specific with strange fields like
"private_build()" where the value and encoding aren't clear. 95%
of the users of FileVersionInfo actually just care about the current
Chrome version, so we can provide a much simpler interface for them.
We still use FileVersionInfo for retrieving information from e.g.
plugin DLLs, but in those cases the usage is clearer.
Review URL: http://codereview.chromium.org/3135028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
wrapping)
BUG=53494
TEST=choose datatypes screen on windows
Review URL: http://codereview.chromium.org/3184027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3207002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename includes, resort header include order in places where the rename
changed the order.
BUG=50548
TEST=compiles
Review URL: http://codereview.chromium.org/3203008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rename (and resort) every #include.
BUG=50548
TEST=compiles
Review URL: http://codereview.chromium.org/3173043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46512
TEST=manual
Review URL: http://codereview.chromium.org/3144012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for the labels so that the long text can be seen on hover even if it still doesn't fit.
BUG=52789
TEST=open sync setup ui in a language with long words
Review URL: http://codereview.chromium.org/3197019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Made CacheInvalidationPacketHandler use a ScopedCallbackFactory.
BUG=53201
TEST=manually with sync_listen_notifications
Review URL: http://codereview.chromium.org/3191024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Save the information that the setup of remoting has completed.
After setup has been completed we start and stop service process when
--enable-remoting presents when browser starts.
Also save the information in the service process that host is registered
and ready to be used. Again start chromoting host automatically once
the host registration is done.
BUG=50244, 50242, 50243, 50249
Review URL: http://codereview.chromium.org/3153029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3140022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the wstring version of BookmarkModel::SetTitle().
BUG=23581
TEST=builds and passes enough tests
Review URL: http://codereview.chromium.org/3142030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A new field to describe the sources of history urls(visits) is added. This field is recorded in visit_database.
So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries.
In the future, history extension API may allow queries to combinate with this criterion.
BUG=none
TEST=Unit tests are already included. Please test the web browser with history from previous
versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the
sources added to the visit_source table in hitory database are correct.
Original review: http://codereview.chromium.org/2906004/show
Patch by weili@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52703
TEST=Start chrome, set up sync, dont crash. ProfileSyncFactoryImplTest.
Review URL: http://codereview.chromium.org/3165046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
src/chrome.
BUG=23581
TEST=builds
Review URL: http://codereview.chromium.org/3181028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove wstring BookmarkModel::AddURL().
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3152034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is added. This field is recorded in visit_database.
So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries.
In the future, history extension API may allow queries to combinate with this criterion.
BUG=none
TEST=Unit tests are already included. Please test the web browser with history from previous
versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the
sources added to the visit_source table in hitory database are correct.
Original review=http://codereview.chromium.org/2906004/show
Patch by weili@google.com
TBR=brettw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
field is recorded in visit_database.
So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries.
In the future, history extension API may allow queries to combinate with this criterion.
BUG=none
TEST=Unit tests are already included. Please test the web browser with history from previous
versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the
sources added to the visit_source table in hitory database are correct.
Original review=http://codereview.chromium.org/2906004/show
Patch by weili@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The parameter describes a list of Values that act as parameters to the callback. It is always a ListValue. It should be typed as such.
BUG=none
TEST=compile; manual testing
Review URL: http://codereview.chromium.org/3146019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove CAPTCHA code from existing user controller and plumb into google
authenticator2.
TEST=Install ChromeOS build. Hit Captcha. Enter captcha.
BUG=50408
Review URL: http://codereview.chromium.org/3134009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix a bunch of #includes. Folks, scoped_refptr<> is defined in
base/ref_counted.h, not in base/scoped_ptr.h.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3132024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Doc updates will follow in another CL.
BUG=48117
TEST=ExtensionsServiceTest.(UpdatePendingExternalCrx,UpdatePendingCrxThemeMismatch,ExternalPrefProvider), ExtensionManagmentTest.ExternalUrlUpdate, manual testing.
Review URL: http://codereview.chromium.org/3005057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of wstring BookmarkModel::AddGroup() (and convert lots of uses; also
convert many uses of the wstring AddURL() as drive-by's).
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3115017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This (re-)inspects files under src/chrome for unneeded #includes of <map>, <string>, <vector>, etc.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3152033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3093013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52552
TEST=ProfileSyncServiceSessionTest. Trying to get heapchecker running locally.
Review URL: http://codereview.chromium.org/3167022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from our patches, READMEs, etc.
Also, add a shim header so we can use it for building
with system sqlite.
TEST=compile
BUG=22208
Review URL: http://codereview.chromium.org/3108030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add fixes for browser tests broken by r56529
Revert "Revert 56529 - [Chrome OS] Block the installation of extensions with NPAPI plugins"
BUG=chromium-os:5454
TEST=browser tests, unit tests
This reverts commit 8e3ffd2dab317dd7fb2d501353153d3e4dcc1c90.
Review URL: http://codereview.chromium.org/3164026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
plugins
BUG=chromium-os:5454
TEST=try to install http://www.3djam.com/roozz/roozz-plugin.crx, see that it is rejected. Try to install https://chrome.google.com/extensions/detail/gofhjkjmkpinhpoiabjplobcaignabnl, see that it works. And...unit tests
Review URL: http://codereview.chromium.org/3163013
TBR=cmasone@google.com
Review URL: http://codereview.chromium.org/3174015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes all IPC Log methods from wstring to string. All static logging debug
data changed from wchar[] to char[].
Various string conversion/numeric headers no longer need to be included in
ipc_message_utils.h and have been removed (and added in all implementation
files that require them).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3159013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:5454
TEST=try to install http://www.3djam.com/roozz/roozz-plugin.crx, see that it is rejected. Try to install https://chrome.google.com/extensions/detail/gofhjkjmkpinhpoiabjplobcaignabnl, see that it works. And...unit tests
Review URL: http://codereview.chromium.org/3163013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added classes to enable session sync functionality.
TEST=ProfileSyncServiceSessionTest
BUG=30519
Original patch by : jerrica@chromium.org
Original review http://codereview.chromium.org/3168009
Review URL: http://codereview.chromium.org/3133022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=ProfileSyncServiceSessionTest
BUG=30519
Original patch by jerrica@chromium.org
Original review: http://codereview.chromium.org/3168009
Review URL: http://codereview.chromium.org/3184004
TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/3127017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=ProfileSyncServiceSessionTest
BUG=30519
Original patch by jerrica@chromium.org
Original review: http://codereview.chromium.org/3168009
Review URL: http://codereview.chromium.org/3184004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- reduce the number of different classes
- clean up the internal code
- modify the interface to expose less internal details
(this will allow more flexibility with port numbers)
TEST=many
BUG=49680
Review URL: http://codereview.chromium.org/3080029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The constructor of syncable::ScopedDirLookup takes the username of the
account being synced. There are times when the username is blank,
resulting in a DCHECK being fired for the value of good() within the method
SyncManager::SyncInternal::InitialSyncEndedForAllEnabledTypes().
This patch makes sure that a ScopedDirLookup with a blank username is
never created by adding a check in the method
SyncManager::SyncInternal::HandleDirectoryManagerEvent().
BUG=51820
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3184009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3109025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=builds
TBR=viettrungluu@chromium.org,brettw@chromium.org
Review URL: http://codereview.chromium.org/3156019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a temporary workaround so that server-issued notifications work
for new sync data types.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/3114012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56290 0039d316-1c4b-4281-b951-d872f2087c98
|