summaryrefslogtreecommitdiffstats
path: root/chrome/browser/sync
Commit message (Collapse)AuthorAgeFilesLines
* Various model associator fixes from preferences bringup.nick@chromium.org2010-02-122-23/+39
| | | | | | | | | | | | | | | | | | Use JSONReader to extract simple values (the previous interface would only parse dict or list values). ReadNode should be Init()'ed only once. Add better handling of deletion; we haven't seen it happen yet, but I found an issue by inspection and added a TODO suggesting how we might make it work correctly. BUG=32409 TEST=manual testing using a hacked up server running locally Review URL: http://codereview.chromium.org/600102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38942 0039d316-1c4b-4281-b951-d872f2087c98
* Two fixes from preference sync bringup: (a) Nudge the syncer on morenick@chromium.org2010-02-112-7/+13
| | | | | | | | | | | than just bookmarks, and (b) set the client_unique_tag during commits. BUG=none TEST=hack-enabled prefs, saw commit go through. Review URL: http://codereview.chromium.org/606004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38847 0039d316-1c4b-4281-b951-d872f2087c98
* Changed default notification method to 'transitional'.akalin@chromium.org2010-02-111-3/+3
| | | | | | | | | BUG=33261 TEST=manual Review URL: http://codereview.chromium.org/597035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38820 0039d316-1c4b-4281-b951-d872f2087c98
* Create preferences DTC and wire it into the profile sync factory.skrul@chromium.org2010-02-1116-49/+407
| | | | | | | | Also includes a small valgrind error fix. Review URL: http://codereview.chromium.org/598046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38815 0039d316-1c4b-4281-b951-d872f2087c98
* For sync, add OrderedCommitSet::Projection, a helper for iterating overtim@chromium.org2010-02-115-39/+238
| | | | | | | | | | | commit IDs one ModelSafeGroup at a time. BUG=31911 TEST=SyncerTest.OrderedCommitSetProjections Review URL: http://codereview.chromium.org/603025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38803 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented new notification methods.akalin@chromium.org2010-02-1130-96/+885
| | | | | | | | | | | | | | | | | Added a NotificationMethod enum, which defines NOTIFICATION_LEGACY, NOTIFICATION_TRANSITIONAL, NOTIFICATION_NEW (see bug for details). Made SendUpdateTask and SubscribeTask take a NotificationMethod and use it. Added command-line switch to override default notification method (currently NOTIFICATION_LEGACY). Added a bunch of unittests. BUG=33261 TEST=trybots, manual testing with notification client pythons scripts and browsers with different notification methods Review URL: http://codereview.chromium.org/573046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38740 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the revert... This has the cumulative effect of relanding 38694.eroman@chromium.org2010-02-111-1/+1
| | | | | | | | | | | | | | | | The chrome frame failure appears to be unrelated. Add some tests to CookieMonster for overwriting persistent cookies, and checking that the PersistentCookieStore interface is exercised correctly. Review URL: http://codereview.chromium.org/600040 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/596048 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/604012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38728 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up client side of per-datatype GetUpdates.nick@chromium.org2010-02-1121-80/+417
| | | | | | | | | | | Which datatypes are fetched is dictated by the ModelSafeRoutingInfo. We change the semantic of the ModelSafeRoutingInfo so that datatypes which should not be synced are not in the map. We will do GetUpdates for GROUP_PASSIVE datatypes. BUG=29905 TEST=included unit tests Review URL: http://codereview.chromium.org/594024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38726 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38694 - For some reason this seems to be hanging chrome frame tests, ↵eroman@chromium.org2010-02-101-1/+1
| | | | | | | | | | | | | even though this should be a strictly no-op change... Add some tests to CookieMonster for overwriting persistent cookies, and checking that the PersistentCookieStore interface is exercised correctly. Review URL: http://codereview.chromium.org/600040 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/596048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38707 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor PostClientToServer message, include new unit tests for it. In prep ↵chron@google.com2010-02-103-73/+243
| | | | | | | | | | | for adding auth filter changes. TEST=unit tests included BUG=35321 Review URL: http://codereview.chromium.org/597025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38703 0039d316-1c4b-4281-b951-d872f2087c98
* Add some tests to CookieMonster for overwriting persistent cookies, and ↵eroman@chromium.org2010-02-101-1/+1
| | | | | | | | checking that the PersistentCookieStore interface is exercised correctly. Review URL: http://codereview.chromium.org/600040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38694 0039d316-1c4b-4281-b951-d872f2087c98
* Change the name fields back to their previous name to unbreak the buildzork@chromium.org2010-02-102-2/+2
| | | | | | | BUG=none TEST=build chrome git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38656 0039d316-1c4b-4281-b951-d872f2087c98
* First stab at a DataTypeController.skrul@chromium.org2010-02-1020-202/+1107
| | | | | | | | This is my first stab at a DataTypeController, plus a BookmarkDataTypeController implementation. It is not fully wired into the PSS yet :) Review URL: http://codereview.chromium.org/545074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38655 0039d316-1c4b-4281-b951-d872f2087c98
* Update the .proto files to change the fields to optional.zork@chromium.org2010-02-102-4/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/598035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38654 0039d316-1c4b-4281-b951-d872f2087c98
* Fill in the preference sync TODOs using the preference specifics proto andalbertb@google.com2010-02-105-53/+109
| | | | | | | | | | | client tags. BUG=32409 TEST=none Review URL: http://codereview.chromium.org/593029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38650 0039d316-1c4b-4281-b951-d872f2087c98
* Added UNIQUE_CLIENT_TAG to sync engine. Added some syncapi unit tests. Added ↵chron@google.com2010-02-0916-87/+1136
| | | | | | | | | | | | | | new index to syncable. Added new DB col to syncable. Renamed singleton tag to UNIQUE_CLIENT_TAG. Added syncapi layer support for unique client tags. Hooked up wire protocol to use this index. Downintegrate of sync.proto from trunk. TEST=unit tests included BUG=32636 Review URL: http://codereview.chromium.org/558015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38518 0039d316-1c4b-4281-b951-d872f2087c98
* Make SyncerThread stop polling if an AUTH_INVALID response is parsed.tim@chromium.org2010-02-098-78/+168
| | | | | | | | | | BUG=34396 TEST=SyncerTHreadWithSyncerTest.AuthInvalid Review URL: http://codereview.chromium.org/596007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38513 0039d316-1c4b-4281-b951-d872f2087c98
* Implement BookmarkModel::SetUrlarv@chromium.org2010-02-091-13/+4
| | | | | | | | | | BUG=10603 TEST=*_test.exe --gtest_filter=*Bookmark* Also manually tested changing the URL through the bookmarks extension API, bookmark manager, bookmark bar and saw it update in all places and correctly sync to another chrome instance. Review URL: http://codereview.chromium.org/582022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38509 0039d316-1c4b-4281-b951-d872f2087c98
* Moved all sync-related command-line logic to profile_sync_service.akalin@chromium.org2010-02-098-15/+29
| | | | | | | | | | | | | Moved --invalidate-sync-login switch logic to profile_sync_service. Removed unneeded command_line.h includes. BUG=none TEST=trybots, manual Review URL: http://codereview.chromium.org/582017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38508 0039d316-1c4b-4281-b951-d872f2087c98
* Mark dirty in PutParentIdPropertyOnly.nick@chromium.org2010-02-091-0/+1
| | | | | | | | | BUG=33081 TEST=none Review URL: http://codereview.chromium.org/594010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38490 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where positions inside of a newly-committed folder would benick@chromium.org2010-02-096-63/+298
| | | | | | | | | | | | | | | | | | | reversed if the children of the folder weren't committed in the same batch as the folder. Refactor ApplyUpdatesCommandTest, pulling out functionality that would be useful for any SyncerCommand test, into syncer_command_test.h. Add a test case for ProcessCommitResponseCommand using the new SyncerCommandTest framework. Add a test for the bug. BUG=33081 TEST=sync_unit_tests. Also, manual testing, using the reduced repro instructions described in comment #26 of the bug. Review URL: http://codereview.chromium.org/572021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38472 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2010-02-095-2/+5
| | | | | | | | | BUG=none TEST=If it compiles it is perfect. Review URL: http://codereview.chromium.org/585008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38463 0039d316-1c4b-4281-b951-d872f2087c98
* linux: build with -Wextraevan@chromium.org2010-02-052-4/+4
| | | | | | | | | | | | 95% of this is removing "const" from return types, but turning this on found one bug! (A "for" loop that expected its iterator to go negative but which was using an unsigned type.) BUG=34160 Review URL: http://codereview.chromium.org/570012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed notifications-related bug on network reconnections.akalin@chromium.org2010-02-044-7/+16
| | | | | | | | | | | | | | Tied talk_mediator logged_in state to mediator_thread instead of auth_watcher. Added some extra logging. BUG=34117 TEST=see bug Review URL: http://codereview.chromium.org/566028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38087 0039d316-1c4b-4281-b951-d872f2087c98
* Switch the order of two checks to avoid dereferencing a null RequestContextdantasse@chromium.org2010-02-041-2/+2
| | | | | | | | | | TBR=tim@chromium.org BUG=32085,32084 TEST=none Review URL: http://codereview.chromium.org/561064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38054 0039d316-1c4b-4281-b951-d872f2087c98
* Check the LSID before starting up a ProfileSyncService. This will stop ↵dantasse@chromium.org2010-02-031-0/+4
| | | | | | | | | | | memory leaks in tests. It will also stop us from starting Sync in Chromium OS UI tests. BUG=32085,32084 TEST=none Review URL: http://codereview.chromium.org/560033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38042 0039d316-1c4b-4281-b951-d872f2087c98
* Add autofill proto buffer for sync.zork@google.com2010-02-031-0/+24
| | | | | | | | | BUG=34203 TEST=none Review URL: http://codereview.chromium.org/562027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38033 0039d316-1c4b-4281-b951-d872f2087c98
* Sync api changes to support preferences.albertb@google.com2010-02-026-3/+43
| | | | | | | | | BUG=34174 TEST=none Review URL: http://codereview.chromium.org/561010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37865 0039d316-1c4b-4281-b951-d872f2087c98
* Wire popup blocking UI to the new machinery and port over the user's old ↵pkasting@chromium.org2010-02-021-2/+1
| | | | | | | | | | | | | | | | whitelist. Notably, this removes the UI entirely for Mac and Linux. We need to rebuild it. This also guts the old system's testing, since most of it disappeared or changed radically. We should test the new stuff. I will file a followup bug for that. There are various tiny edge cases, like if you click the address bar icon really quickly, sometimes you'll get popups without any title yet, which makes them leave gaps in the bubble that appears. We can fix that sort of thing. The critical bit I tried to ensure was that we never try to open a dead popup or use a dead TabContents, no matter what. BUG=33314 TEST=Go visit some sites with popups and play with things Review URL: http://codereview.chromium.org/562013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37819 0039d316-1c4b-4281-b951-d872f2087c98
* Proto extenions to sync preferences.albertb@google.com2010-02-011-0/+23
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/561003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37761 0039d316-1c4b-4281-b951-d872f2087c98
* BSD port: chrome/app and chrome/browser ifdef cleaningpvalchev@google.com2010-02-011-0/+1
| | | | | | Review URL: http://codereview.chromium.org/548203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37714 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of the DatabaseModelWorker, take 2.albertb@google.com2010-02-019-24/+182
| | | | | | | | | BUG=none TEST=unit tests Review URL: http://codereview.chromium.org/557043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37702 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for thread sanitizer failures in ProfileSyncServiceTest.tim@chromium.org2010-02-011-1/+1
| | | | | | | | | | | We should not raise an "auth needed" event if we're not supposed to attempt auth in the first place. TBR=albertb Review URL: http://codereview.chromium.org/549222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37700 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r37535.darin@chromium.org2010-01-291-3/+0
| | | | | | | | | | | | | There was no LGTM, and there was still open discussion in the code review. See http://codereview.chromium.org/554119. This was not ready to land. TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/553154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37556 0039d316-1c4b-4281-b951-d872f2087c98
* Implement extended cookie controls.jochen@chromium.org2010-01-291-0/+3
| | | | | | | | | BUG=32782 TEST=none Review URL: http://codereview.chromium.org/554119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37535 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bug 21102 where shutdown while starting Sync leaves things weird.nick@chromium.org2010-01-295-23/+108
| | | | | | | | | | | | | Specifically, it leaves the Sync Data folder around, which causes problems later where it thinks we're already logged into sync. Patch contributed by Dan Tasse (dantasse@google.com) TEST=create new Sync Data files with nonsense data, enable sync for a user, make sure those files were replaced with real Sync Data files. BUG=21102 Review URL: http://codereview.chromium.org/557010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37482 0039d316-1c4b-4281-b951-d872f2087c98
* Don't acquire a database lock in ↵nick@chromium.org2010-01-281-1/+10
| | | | | | | | | | | | | syncable::DirectoryBackingStore::SaveChanges if there is nothing to save. Patch contributed by vt (p155off@gmail.com). BUG=33367 TEST=SyncData.sqlite3-journal isn't written to every 10 seconds with sync enabled; sync_unit_tests continue to pass Review URL: http://codereview.chromium.org/558019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37448 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 37367 - Implementation of the database safe worker model.viettrungluu@chromium.org2010-01-289-174/+12
| | | | | | | | | | | | BUG=none TEST=unit test Review URL: http://codereview.chromium.org/546138 TBR=albertb@google.com, victorw@chromium.org, rolandsteiner@chromium.org Review URL: http://codereview.chromium.org/557032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37380 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 37372 - Fix leak in DatabaseWorkerModelTest.viettrungluu@chromium.org2010-01-281-2/+2
| | | | | | | | | | | | | BUG=none TEST=none TBR=tim Review URL: http://codereview.chromium.org/557029 TBR=albertb@google.com, victorw@chromium.org, rolandsteiner@chromium.org Review URL: http://codereview.chromium.org/548175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37379 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in DatabaseWorkerModelTest.albertb@google.com2010-01-281-2/+2
| | | | | | | | | | BUG=none TEST=none TBR=tim Review URL: http://codereview.chromium.org/557029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37372 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of the database safe worker model.albertb@google.com2010-01-289-12/+174
| | | | | | | | | BUG=none TEST=unit test Review URL: http://codereview.chromium.org/546138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37367 0039d316-1c4b-4281-b951-d872f2087c98
* Add an implementation for async_network_alive to Linuxzork@chromium.org2010-01-273-16/+125
| | | | | | | | | BUG=33091 TEST=none Review URL: http://codereview.chromium.org/552162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37342 0039d316-1c4b-4281-b951-d872f2087c98
* Enable valgrind for sync tests (and fix valgrind errors)skrul@chromium.org2010-01-273-1/+9
| | | | | | | | BUG=32871 Review URL: http://codereview.chromium.org/548156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37262 0039d316-1c4b-4281-b951-d872f2087c98
* In the sync database, use protobuf-based storage. Drop the oldnick@chromium.org2010-01-2723-325/+1404
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | bookmark-only columns. Add getters and setters for BookmarkSpecifics to syncapi as well as syncable entries. Make the datatype be a required property when creating a syncapi node. Add a datatype for the 'google chrome' top level folder. Add database migrations from version 67 to the new schema. Add infrastructure to support migrations generically. Add unit tests for the migrations. Pull a new version of the protobuf library to pick up a fix for a bug that this change exposed (I upstreamed the fix). Fix some example code in the sql helpers so that it would actually compile. BUG=29899,30041 TEST=New unit tests for migrations: unit tests are based on actual database dumps. Additionally, I manually tested 2-client sync using combos of old-protocol servers, new-protocol servers, and initial database versions v67, v68, and v0 (new client). I manually verified that add/edit/delete works in these combination cases. Afterwards I verified (by inspecting the sync databases) that the ModelTypes are consistent across the various migration/protocol paths. Review URL: http://codereview.chromium.org/554066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37253 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bug involving destruction order in GaiaAuth.akalin@chromium.org2010-01-272-8/+25
| | | | | | | | | | | See bug for more details. BUG=33120 TEST=Put sleep(15) before post of on_work_done_task, made sure OnAuthDone doesn't get called on shutdown. Review URL: http://codereview.chromium.org/548147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37219 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed race condition with AddressWatchTask and ServerConnectionManager.akalin@chromium.org2010-01-263-22/+11
| | | | | | | | | BUG=33162 TEST=manually with sleep() Review URL: http://codereview.chromium.org/552157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37154 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a bunch of 0 byte files. (due to git-svn misbehavior?)thestig@chromium.org2010-01-266-0/+0
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37152 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for UserIdleTime to Linux.zork@chromium.org2010-01-264-74/+177
| | | | | | | | | BUG=32421 TEST=none Review URL: http://codereview.chromium.org/553051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37136 0039d316-1c4b-4281-b951-d872f2087c98
* Remove SYNC_EXPORT macro and all it's uses.munjal@chromium.org2010-01-221-13/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/555044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36904 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leaks due to not deleting closures.tim@chromium.org2010-01-222-3/+5
| | | | | | | | TBR=nick@chromium.org Review URL: http://codereview.chromium.org/552102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36852 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-19 10:07:16 +0000