summaryrefslogtreecommitdiffstats
path: root/chrome/browser/sync
Commit message (Collapse)AuthorAgeFilesLines
* [SYNC] Tests to catch datatype manager behavior when datatype controller is ↵zea@chromium.org2011-01-271-0/+45
| | | | | | | | | | | busy when stop() is called. BUG=61804 TEST=self Review URL: http://codereview.chromium.org/6357018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72803 0039d316-1c4b-4281-b951-d872f2087c98
* Handle sync values of wrong type more graceful.mnissler@chromium.org2011-01-271-1/+8
| | | | | | | | | | | Clear prefs that the server reports TYPE_NULL values for and log a warning if the type is off otherwise. BUG=none TEST=compiles and passes tests Review URL: http://codereview.chromium.org/6288016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72786 0039d316-1c4b-4281-b951-d872f2087c98
* sync: remove a test expectation that is actually dumb.tim@chromium.org2011-01-261-2/+0
| | | | | | | | | | | | | | | I added it. Yay me. (It is dumb because it puts a sub 20 millisecond upper bound on certain operations involving posting tasks across threads.) TBR=akalin BUG=26339 TEST=SyncerThread2Test Review URL: http://codereview.chromium.org/6296023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72716 0039d316-1c4b-4281-b951-d872f2087c98
* sync: fix a couple less-than comparisons to be less-than-eq in tests.tim@chromium.org2011-01-261-2/+3
| | | | | | | | | | | TBR=akalin BUG=26339 TEST=SyncerThread2Test Review URL: http://codereview.chromium.org/6267015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72691 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 72685 - [SYNC] Refactor SyncSourceInfo and add support in chrome ↵zea@chromium.org2011-01-2616-386/+59
| | | | | | | | | | | | | invalidation client and syncer thread for passing a datatype-specific payload originating in the invalidation server and directed at the sync frontend server. Also fixes bug with last_sync_time and PostTimeToTypeHistogram, which would get hit when the unit tests were being run. BUG=68572,69558 TEST=unit Review URL: http://codereview.chromium.org/6182004 TBR=zea@chromium.org Review URL: http://codereview.chromium.org/6270006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72687 0039d316-1c4b-4281-b951-d872f2087c98
* [SYNC] Refactor SyncSourceInfo and add support in chrome invalidation client ↵zea@chromium.org2011-01-2616-59/+386
| | | | | | | | | | and syncer thread for passing a datatype-specific payload originating in the invalidation server and directed at the sync frontend server. Also fixes bug with last_sync_time and PostTimeToTypeHistogram, which would get hit when the unit tests were being run. BUG=68572,69558 TEST=unit Review URL: http://codereview.chromium.org/6182004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72685 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up net unit testing code.erg@google.com2011-01-261-19/+2
| | | | | | | | | | | | | | | | | | | | (Reapply r72562 with willchan's nits + locally tested shlib fixes + removing duplicate code that was partially responsible for the failure.) - Move code included from blah_unittest.h (where blah_unittest.cc has actual unittests) into their own files, often completely out-of-lining the definitions. - Remove anonymous namespaces from headers. - Reorder method declarations. - Make other unit test link against net_test_support instead of reaching in and including .h files in their targets directly. BUG=68682 TEST=compiles First Review URL: http://codereview.chromium.org/6264013 Review URL: http://codereview.chromium.org/6248021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72682 0039d316-1c4b-4281-b951-d872f2087c98
* attempt to fix perms on some filestim@chromium.org2011-01-262-0/+0
| | | | | | | TBR=akalin@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72680 0039d316-1c4b-4281-b951-d872f2087c98
* sync: beginnings of MessageLoop based SyncerThreadtim@chromium.org2011-01-2620-20/+1630
| | | | | | | | | | | | | This is just a checkpoint. It's not wired up to anything yet, and not fully implemented (note several NOTIMPLEMENTED() checks). For design and overview, see https://docs.google.com/document/d/1bFqqtpA7TZuwtyEqlSxgkCCRrHvYRnnH6HlHou2LwVo/edit BUG=26339 TEST=sync_unit_tests Review URL: http://codereview.chromium.org/5939006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72663 0039d316-1c4b-4281-b951-d872f2087c98
* From the enter-passphrase screen in sync setup, canceling should only ↵johnnyg@chromium.org2011-01-266-7/+99
| | | | | | | | | | | disable encrypted sync, not all sync. Show a confirmation dialog for the same and ignore future passphrase warnings that are decryption-related, as long as encrypted datatypes are not being used. BUG=60182 TEST=see bug Review URL: http://codereview.chromium.org/6364009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72659 0039d316-1c4b-4281-b951-d872f2087c98
* Use labels for the new radio buttons in the sync dialogs.johnnyg@chromium.org2011-01-262-10/+13
| | | | | | | | | BUG=70265 TEST=setup sync, encryption tab radio buttons should support clicking on labels Review URL: http://codereview.chromium.org/6271023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72655 0039d316-1c4b-4281-b951-d872f2087c98
* Do not use local override for language settings: always store it into ↵dilmah@chromium.org2011-01-261-2/+1
| | | | | | | | | | | synchronized preference. BUG=chromium-os:11147 TEST=Manual Review URL: http://codereview.chromium.org/6248017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72633 0039d316-1c4b-4281-b951-d872f2087c98
* Pass empty cros_user string to GetProfileSyncService() in sync integration testsrsimha@chromium.org2011-01-261-1/+1
| | | | | | | | | | | | | | | | | The sync integration tests are broken on chrome OS because a cros_string is not being passed to GetProfileSyncService() in ProfileSyncServiceHarness::SetupSync(), causing no ProfileSyncService object to be returned. This patch passes an empty cros_user string to GetProfileSyncService(), thereby fixing the sync integration tests on chrome OS. BUG=70854, chromium-os:11319, chromium-os:9262 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6248019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72574 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Clean up net unit testing code." since it breaks the shlib builder.erg@google.com2011-01-251-1/+1
| | | | | | | | | | This reverts commit 006f377bbb65ece3490b7c76e58e0dc4cb330909 (r72562). BUG=68682 TEST=compiles TBR=thomasvl git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72564 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up net unit testing code.erg@google.com2011-01-251-1/+1
| | | | | | | | | | | | | | | | | - Move code included from blah_unittest.h (where blah_unittest.cc has actual unittests) into their own files, often completely out-of-lining the definitions. - Remove anonymous namespaces from headers. - Reorder method declarations. - Make other unit test link against net_test_support instead of reaching in and including .h files in their targets directly. BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6264013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72562 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Remove now-obsolete FastDump classakalin@chromium.org2011-01-2510-132/+29
| | | | | | | | | | | Fix uses of bare 'string' to be 'std::string'. BUG=55816 TEST=None Review URL: http://codereview.chromium.org/6304021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72559 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DOMUI pref mode handling of Mac menu itemsstuartmorgan@chromium.org2011-01-252-8/+29
| | | | | | | | | | | In DOMUI pref mode, Mac menu items should open prefs via a browser window. Also fixes OpenSyncMyBookmarksDialog on all platforms. BUG=67670 TEST=Choosing a pref-opening menu item from the Chrome menu on Mac should open DOMUI prefs. Review URL: http://codereview.chromium.org/6293018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72500 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce incognito preference settings.battre@chromium.org2011-01-251-44/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL introduces preference settings for incognito windows. The semantics are the following: - An extension can set regular preferences as before. These affect regular and incognito windows. - An extension can set regular preferences *and* incognito preferences. In this case, the incognito preferences affect only incognito windows. - If extension A sets reg+incognito, extension B sets reg but no incognito, extension B has higher precedence than A --> B's preferences hold for all regular and incognito windows. - Incognito preferences are never persisted to disk. In order to realize this, the ExtensionPrefs class allows setting regular and incognito extension controlled preferences. It allows creating an incognito version of the PrefService with an independent PrefValueStore. This (incognito) PrefValueStore and the original PrefValueStore share several of their PrefStores (i.e. DefaultPrefStore, CommandLinePrefStore, Configuration PrefStores) but differ in two pref stores: - We maintain two separate ExtensionPrefStores containing the effective preferences for regular and incognito windows. - We maintain two separate user pref stores. The regular JsonPrefStore is expanded by an OverlayPersistentPrefStore that maintains all write-operations in an in-memory overlay. Therefore, incognito changes are not visible in the file-backed JsonPrefStore. The two ExtensionPrefStores retrieve their effective values from a shared ExtensionPrefValueMap. The OffTheRecordProfileImpl provides a request_context_ that uses the new PrefService already. BUG=66027,69057 TEST=unit tests, will be fully testable once the Proxy Settings API allows incognito settings. Review URL: http://codereview.chromium.org/5915004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72489 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Roll cache-invalidation to @70akalin@chromium.org2011-01-255-11/+20
| | | | | | | | | | | | | Pass user agent to InvalidationClientImpl as client_info. Pick up fix for bug that was causing increased server traffic. BUG=70674 TEST=none Review URL: http://codereview.chromium.org/6310015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72468 0039d316-1c4b-4281-b951-d872f2087c98
* [SYNC] Speculative fix for autofill change processor destroying on the wrong ↵zea@chromium.org2011-01-251-1/+2
| | | | | | | | | | | thread. The data type manager should now tell any datatype controller that is not already stopping or not running to stop. Namely, this covers the MODEL_STARTING and ASSOCIATING cases, which weren't being covered before. Tests that can reproduce these race conditions still needed. BUG=61804 TEST=unit,sync_integration,self Review URL: http://codereview.chromium.org/6273011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72458 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Refactored ProfileSyncService and remove its backend() functionakalin@chromium.org2011-01-2432-536/+685
| | | | | | | | | | | | | | | | | Moved bodies of test functions into .cc files. Remove sync_service() accessors from various model associators. Renamed GetUserShareHandle to GetUserShare() and removed typedefs for its return types. Added plenty of TODOs for future improvements. BUG=None TEST=unit_tests Review URL: http://codereview.chromium.org/6375007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72419 0039d316-1c4b-4281-b951-d872f2087c98
* Bring the first passphrase screen UI up to date with equivalent changes made ↵johnnyg@chromium.org2011-01-242-16/+17
| | | | | | | | | | | to the encryption tab: learn more link, behavior of passphrase/confirm passphrase boxes. BUG=none TEST=none Review URL: http://codereview.chromium.org/6353013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72342 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a scoped_allowio for ProfileSyncService until we can evaluate.finnur@chromium.org2011-01-241-2/+5
| | | | | | | | | | TBR=chron BUG=70380 TEST=None Review URL: http://codereview.chromium.org/6315010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72326 0039d316-1c4b-4281-b951-d872f2087c98
* Stop using browser signin for passphrase migration, just use the normal ↵johnnyg@chromium.org2011-01-213-42/+21
| | | | | | | | | | | signin flow which is accessible from all parts of the sync UI. Create the correct state transition from login -> initial passphrase selection. BUG=70429 TEST=upgrade a sync-everything profile to latest chrome Review URL: http://codereview.chromium.org/6357011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72236 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to ui/baseben@chromium.org2011-01-215-5/+5
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
* Create a new code path to generate sync strings for the new tab page ↵johnnyg@chromium.org2011-01-212-8/+59
| | | | | | | | | | | | | different from those used on the settings' page. This will allow us to show on the settings page the current sync status as well as a message regarding passwords. BUG=69622 TEST=see bug Review URL: http://codereview.chromium.org/6350008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72171 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-2128-93/+93
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* Add Throbber control for DOMUI. Use it everywhere in options and in Sync ↵sergeyu@chromium.org2011-01-212-38/+10
| | | | | | | | | | | setup UI. BUG=69755 TEST=Throbber works properly when settings page is scaled. Review URL: http://codereview.chromium.org/6378006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72104 0039d316-1c4b-4281-b951-d872f2087c98
* Force patches that touch sync code to use the sync trybotsrsimha@chromium.org2011-01-211-0/+13
| | | | | | | | | | | | | | | | | | | | | As of today, we have dedicated chromium trybots that can run the sync integration tests, but it requires developers to explicitly send try jobs to these bots via the --bot switch. Now that the sync trybots are stable, it is time to make this process automatic by adding a PRESUBMIT.py file to chrome/browser/sync, that adds the sync trybots in addition to win, mac and linux to the list of preferred trybots. This patch adds such a PRESUBMIT.py file, that includes win_sync, mac_sync and linux_sync to the list of preferred trybots. BUG=70311 TEST=modify something under chrome/browser/sync and do a "git try" or "gcl try" Review URL: http://codereview.chromium.org/6275010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72067 0039d316-1c4b-4281-b951-d872f2087c98
* Move ResourceBundle, DataPack to ui/baseben@chromium.org2011-01-202-2/+2
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6263008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of random other files to src/ui/baseben@chromium.org2011-01-201-5/+6
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6257006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71970 0039d316-1c4b-4281-b951-d872f2087c98
* Make tweaks to password UI following today's UI review: added a learn more ↵johnnyg@chromium.org2011-01-202-4/+19
| | | | | | | | | | | link on the encryption tab and reduced the amount of text slightly. Made the dialog slightly taller so that everything fits more comfortably without the risk of overlapping elements. BUG=69624 TEST=none Review URL: http://codereview.chromium.org/6291008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71908 0039d316-1c4b-4281-b951-d872f2087c98
* Update references part 3: remaining files in chrome/...msw@chromium.org2011-01-191-3/+3
| | | | | | | | | | | | | | | | | Update chrome/browser/gtk references & copyright dates of touched files. Re-alphabetize include lists as necessary from this change. Manually merge r71828 svn pset svn:eol-style LF \ chrome/browser/automation/testing_automation_provider_gtk.cc \ chrome/browser/speech/speech_input_bubble_gtk.cc BUG=69289 TEST=none Review URL: http://codereview.chromium.org/6245006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71859 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Tidy up SyncBackendHost interface.akalin@chromium.org2011-01-1912-195/+199
| | | | | | | | | | | | | | | Converted passphrase-related notifications to SyncFrontend methods. Removed some unneeded parameters from SyncBackendHost constructor. Moved some function definitions into .cc files. BUG=None TEST=unit_tests Review URL: http://codereview.chromium.org/6380004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71855 0039d316-1c4b-4281-b951-d872f2087c98
* Change all the places where the multi-purpose sync error link is surfaced to ↵johnnyg@chromium.org2011-01-192-0/+24
| | | | | | | | | | | call a common routine that either shows a login prompt or shows the passphrase prompt depending on the reason for the error. BUG=68962 TEST=none Review URL: http://codereview.chromium.org/6293010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71844 0039d316-1c4b-4281-b951-d872f2087c98
* Made return types of various Value::DeepCopy() implementations more specificakalin@chromium.org2011-01-181-3/+2
| | | | | | | | | | | | | | | | | | Since C++ supports covariant return types, a subclass of Value can return its own pointer type for Value::DeepCopy(). Also made signatures of Value::Create*Value() more specific. Removed now-unnecessary casts. Added test for covariant return types. BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6324004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71617 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded chrome/browser/prefs/pref_service.h usage.thestig@chromium.org2011-01-154-4/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6335001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71547 0039d316-1c4b-4281-b951-d872f2087c98
* Turn password sync on by default.johnnyg@chromium.org2011-01-1512-231/+254
| | | | | | | | | BUG=61252 TEST=none Review URL: http://codereview.chromium.org/6249006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71534 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequestContext URLRequestContext;tfarina@chromium.org2011-01-153-8/+10
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/6338002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71522 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Convert notifications for UNKNOWN to notifications for everythingakalin@chromium.org2011-01-143-15/+13
| | | | | | | | | | | | | | | Handle this in ChromeInvalidationClient so that we don't have to handle it everywhere else. We were handling it incorrectly anyway, but it wasn't a problem since we always get all updates for all data types. BUG=None TEST=Manual Review URL: http://codereview.chromium.org/6358001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71507 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Port about:sync to DOMUIakalin@chromium.org2011-01-143-216/+3
| | | | | | | | | | | | | | | | | Write chrome://sync-internals DOMUI page which is like about:sync but automatically updates on sync events. Make about:sync{,-internals} aliases for chrome://sync-internals. More diagnostic capabilities will be added to chrome://sync-internals in future CLs. BUG=69500 TEST=Manual Review URL: http://codereview.chromium.org/6299002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71435 0039d316-1c4b-4281-b951-d872f2087c98
* Clang: enable -Wbool-conversions and -Wunused-variables on Linux.hans@chromium.org2011-01-141-1/+1
| | | | | | | | | | | | | | | -Wbool-conversion warns about EXPECT_EQ(false, blah), so replace that with EXPECT_FALSE(blah). Do the same with EXPECT_EQ(true, blah) for good measure (even though that doesn't generate warnings). Also remove the one instance of an unused variable. BUG=69421 TEST=buildbots all compile and all tests pass Review URL: http://codereview.chromium.org/6300001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71431 0039d316-1c4b-4281-b951-d872f2087c98
* We forgot to call Associate in case of local changes for autofill.lipalani@chromium.org2011-01-141-0/+3
| | | | | | | | | | When a local profile is created we create the corresponding sync node and we need to associate the sync node with profile. We forgot to make the call and that is fixed in this cl. BUG=68912, 69173 TEST= sync_integration_tests Review URL: http://codereview.chromium.org/6323001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71409 0039d316-1c4b-4281-b951-d872f2087c98
* Fix passphrase unit test.johnnyg@chromium.org2011-01-141-1/+2
| | | | | | | | | | BUG=62103 TEST=none TBR=tim Review URL: http://codereview.chromium.org/6341001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71396 0039d316-1c4b-4281-b951-d872f2087c98
* Further tweaks to the passphrase UI to deal with passphrase entry.johnnyg@chromium.org2011-01-138-42/+101
| | | | | | | | | BUG=62103 TEST=none Review URL: http://codereview.chromium.org/6309002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71381 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded chrome/browser/ui/browser.h usage.thestig@chromium.org2011-01-131-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6260001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71368 0039d316-1c4b-4281-b951-d872f2087c98
* sync: annotate call to join SyncCoreThread to keep ThreadRestrictions happy.tim@chromium.org2011-01-131-4/+9
| | | | | | | | | | | | Bug 19757 discusses how we block the UI thread on the core thread when shutting down sync. Until that is fixed, we have to fess up to the Thread police. BUG=69570,19757 TEST=Start syncing in debug build. Stop sync. Don't crash. Review URL: http://codereview.chromium.org/6328001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71361 0039d316-1c4b-4281-b951-d872f2087c98
* The sync server supports a new "progress token" scheme that allows data ↵nick@chromium.org2011-01-1334-554/+692
| | | | | | | | | | | | | | | | types to be requested with a different timestamp per datatype. The benefits of this approach are: - timestamps become opaque to the client, which makes - the client no longer has to rely on timestamps converging for all datatypes. - the server will send fewer redundant updates after enabling a new datatype. - the flexibility of the opaque field allows the server to implement other optimizations which will increase scalability & performance BUG=58217 TEST=manual test of sync (old profile+new profile), unit tests, integ tests Review URL: http://codereview.chromium.org/6104003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71357 0039d316-1c4b-4281-b951-d872f2087c98
* sync: avoid creating a HistoryModelWorker unless it is needed.tim@chromium.org2011-01-133-10/+12
| | | | | | | | | | | | We typically add all known workers when Initializing the SyncBackendHost, but this one is causing crashes and isn't used by default. BUG=53916,69561 TEST=none Review URL: http://codereview.chromium.org/6111012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71337 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix a bunch of NULL vs. 0 issues spotted by gcc 4.5.craig.schlenter@chromium.org2011-01-131-1/+1
| | | | | | | | | | | | There are more gcc 4.5 issues to be solved so GYP_DEFINES=='werror=' is still required to build with 4.5 even with these changes. BUG=66652 TEST=compiles with gcc 4.5 and trybots Review URL: http://codereview.chromium.org/6186008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71325 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-12 20:41:40 +0000