summaryrefslogtreecommitdiffstats
path: root/chrome/browser/tab_contents
Commit message (Collapse)AuthorAgeFilesLines
* Fix class/struct forward-declare mixups.evan@chromium.org2010-04-161-1/+1
| | | | | | | | GCC doesn't mind, but clang does. Review URL: http://codereview.chromium.org/1631025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44842 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes the translate context menu disabled when thejcivelli@chromium.org2010-04-161-4/+10
| | | | | | | | | | | | | | | page language is the same as the UI language. BUG=39506 TEST=With Chrome configure to be in English, Visit www.google.com. Right click on the page, the context menu "Translate to English" should be disabled. Do the same on www.google.fr, the menu should be enabled. Review URL: http://codereview.chromium.org/1619014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44756 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK in web_drop_target_win.cc.dcheng@chromium.org2010-04-163-35/+51
| | | | | | | | | | | Relax the DCHECK for asserting that only one drag op is set. WebKit occasionally only sets DragOperationMove to indicate a drag move, even though the usual convention is to set both DragOperationMove and DragOperationGeneric. BUG=41670 TEST=none Review URL: http://codereview.chromium.org/1513044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44742 0039d316-1c4b-4281-b951-d872f2087c98
* Move third_pary/mozilla/include up one directory.evan@chromium.org2010-04-151-1/+1
| | | | | | | | | | This allows the license checker to find the README. BUG=39240 Review URL: http://codereview.chromium.org/1596025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44655 0039d316-1c4b-4281-b951-d872f2087c98
* The geolocation icon must be displayed even if the current origin change its ↵bulach@chromium.org2010-04-142-4/+21
| | | | | | | | | | | | document or query params. We should only remove the icon when visiting a new origin or the underlying setting has changed. BUG=40742 Review URL: http://codereview.chromium.org/1640004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44463 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the --enable-user-stylesheet flag.tony@chromium.org2010-04-141-4/+5
| | | | | | | | | | Startup perf was not impacted in an earlier test run, so this should be safe. BUG=38182 Review URL: http://codereview.chromium.org/1530031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44457 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44443 - Try removing the enableuserstylesheet flag.tony@chromium.org2010-04-141-2/+6
| | | | | | | | | | | | | | This is a test run to see how it impacts startup perf (if any). BUG=38182 TBR=chase Review URL: http://codereview.chromium.org/1595027 TBR=tony@chromium.org Review URL: http://codereview.chromium.org/1560034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44444 0039d316-1c4b-4281-b951-d872f2087c98
* Try removing the --enable-user-stylesheet flag.tony@chromium.org2010-04-141-6/+2
| | | | | | | | | | | This is a test run to see how it impacts startup perf (if any). BUG=38182 TBR=chase Review URL: http://codereview.chromium.org/1595027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44443 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Make automation calls for Downloads, Extensions, and History pagesphajdan.jr@chromium.org2010-04-121-0/+5
| | | | | | | | | | | | | reliable. This way we'll be able to write good pyauto tests for them. TEST=ui_tests BUG=none Review URL: http://codereview.chromium.org/1562021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44264 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Fill the default profile when the AutoFill accelerator combo is ↵jhawkins@chromium.org2010-04-092-3/+10
| | | | | | | | | | | pressed (ctrl-shift-a). BUG=39491 TEST=none Review URL: http://codereview.chromium.org/1521020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44149 0039d316-1c4b-4281-b951-d872f2087c98
* Adds an updated safety check for DOM UI renderers. creis@chromium.org2010-04-091-0/+7
| | | | | | | | | | | | | We should not be passing web URLs to DOM UI renderers. This CL adds a check to ensure that we only navigate to DOM-UI-permitted URLs in such renderers. BUG=40575, 40893 TEST=none Review URL: http://codereview.chromium.org/1631009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44112 0039d316-1c4b-4281-b951-d872f2087c98
* Do not prepopulate the findbar with incognito search terms.rohitrao@chromium.org2010-04-092-17/+8
| | | | | | | | BUG=32021 TEST=On win/linux, open an incognito window and search for some term. Then open a new normal tab and press Ctrl-F. Findbar should not be prepopoulated with your incognito search term. Review URL: http://codereview.chromium.org/1561018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44104 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43962 - Adds a safety check for DOM UI renderers.creis@chromium.org2010-04-091-7/+0
| | | | | | | | | | | | | | | | | (Currently crashing on reliability bot.) We should not be passing web URLs to DOM UI renderers. This CL adds a check to ensure that we only navigate to DOM UI URLs in such renderers. BUG=40575 TEST=none Review URL: http://codereview.chromium.org/1549027 TBR=brettw Review URL: http://codereview.chromium.org/1626012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44100 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor common, platform-independent code for the repost form warning ↵bauerb@chromium.org2010-04-091-5/+6
| | | | | | | | | | | | | | | dialog on all platforms into a delegate. The platform-dependent ConstrainedWindow{Gtk,Mac,Win} classes each have their own platform-dependent |ConstrainedWindowDelegate| to inherit from, so instead of a common superclass they now have a RepostFormWarningDelegate. Also, change the RELOADING notification to REPOST_WARNING_SHOWN to avoid trying to close the dialog while it's already in the process of being closed. BUG=none TEST=RepostFormWarningTest.* Review URL: http://codereview.chromium.org/1520023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44074 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a safety check for DOM UI renderers.creis@chromium.org2010-04-081-0/+7
| | | | | | | | | | | | We should not be passing web URLs to DOM UI renderers. This CL adds a check to ensure that we only navigate to DOM UI URLs in such renderers. BUG=40575 TEST=none Review URL: http://codereview.chromium.org/1549027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43962 0039d316-1c4b-4281-b951-d872f2087c98
* Implement patterns for content setting exceptions.jochen@chromium.org2010-04-081-8/+5
| | | | | | | | | BUG=37394 TEST=unit_tests + manual Review URL: http://codereview.chromium.org/1567010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43936 0039d316-1c4b-4281-b951-d872f2087c98
* Return an approximately correct drop effect from WebDragTarget::OnDrop.dcheng@chromium.org2010-04-083-16/+27
| | | | | | | | | | | This isn't actually guaranteed to be correct, since it's the cached value from previous dragenter / dragover results, but hopefully it's somewhat correct part of the time. To prevent potential data loss, all moves are mapped to copies. A future improvement might to fire a ViewHostMsg_UpdateDragCursor after the renderer processes the drop event. BUG=39399 TEST=Manual testing using the attached test case on the bug. Review URL: http://codereview.chromium.org/1572027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43925 0039d316-1c4b-4281-b951-d872f2087c98
* Set the site instance in all cases when we start a new load. If you navigate ↵brettw@chromium.org2010-04-072-6/+26
| | | | | | | | | | away from the new tab page (or another DOMUI page) before the DOMUI page commits, the subsequent page will inherit the SiteInstance of the original page. BUG=12718,40575 TEST=included unit test Review URL: http://codereview.chromium.org/1519025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43879 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the new WebPopupType to the RenderWidget creation.jcivelli@google.com2010-04-077-16/+23
| | | | | | | | | BUG=None TEST=Tests that all popups (select popup, autofill, browser actions, bookmark bubble...) work as expected and get the focus correctly. Review URL: http://codereview.chromium.org/1523013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43845 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the translate back-end to use the Google Translate element.jcivelli@google.com2010-04-063-36/+8
| | | | | | | | | | | | | | | | When the user indicates that a page should be translated, the browser first fetches the Google Translate Element JS code. It then sends it to the renderer, which injects the script in the page, waits for the Translate element to be initialized and then calls the translate method on it. The TranslationService class previously used to translate text chunks is now unused and has been removed. Some of its static methods that are still used have been moved to the TranslateManager class. This CL also implements the "revert" translation behavior. BUG=35474,37778,35553,39375 TEST=Test the translation feature extensively. Review URL: http://codereview.chromium.org/1599016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43768 0039d316-1c4b-4281-b951-d872f2087c98
* Win32 plumbing for dragend event.dcheng@chromium.org2010-04-065-19/+61
| | | | | | | | | | | This plumbs the actual dropEffect that occurred back into WebKit so that dragend is dispatched with the correct dropEffect. Note that this only helps with drags that start in Chrome and end outside of Chrome. Since WebDropTarget always lies and claims that no drop occurred, drags that start in Chrome and end in Chrome will still be incorrect. BUG=39399 TEST=Manual testing using the attached test case on the bug. Review URL: http://codereview.chromium.org/1136007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43726 0039d316-1c4b-4281-b951-d872f2087c98
* GTK plumbing for dragend.dcheng@chromium.org2010-04-051-24/+5
| | | | | | | | | | | This plumbs the actual dropEffect that occurred back into WebKit so that dragend is dispatched with the correct dropEffect. BUG=39399 TEST=Manual testing using the attached test case on the bug. Review URL: http://codereview.chromium.org/1589015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43679 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make image dragging 162.4% more awesome.thakis@chromium.org2010-04-051-4/+13
| | | | | | | | | | | | | | | | | | | Also needs a webkit patch to do anything ( https://bugs.webkit.org/show_bug.cgi?id=37069 ), but can be landed independently. BUG=11457,18992 TEST=(all require the webkit patch, so this won't work yet) http://html5demos.com/drag and http://ljouanneau.com/lab/html5/demodragdrop.html Dragging should show image http://www.google.com/ Dragging google image should show image http://www.travelvivi.com/wp-content/uploads/2009/09/Eiffel_Tower.jpg Dragging image should work, drag image should be smaller than image itself Random website Mark some text, drag it. Should show drag cursor and no image Review URL: http://codereview.chromium.org/1539018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43631 0039d316-1c4b-4281-b951-d872f2087c98
* Fix prepopulate value for Find and add browser tests for it.finnur@chromium.org2010-04-051-1/+2
| | | | | | | | | | | | | | | Notable changes: FindBarController now sets the prepopulate text during Show for the Find dialog, to fix regression 40121. It also checks not just the current find string (find_text()) but the previous one also (previous_find_text()) in MaybeSetPrepopulateText() because the current find string is blanked out when closing the Find window. And TabContents now makes sure previous_find_text() is never overwritten with an empty find_text value (to prevent the last search from being cleared if you open Find, close it without searching and open it again). This changelist also adds automated tests for the codepaths above, which results in adding a GetFindText method to the FindBarTesting interface, to allow the tests to check what string is being shown to the user when the Find box opens. BUG=40121 TEST=FindInPageControllerTest.Prepopulate* (three tests) Review URL: http://codereview.chromium.org/1560012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43620 0039d316-1c4b-4281-b951-d872f2087c98
* Add calling frame's source_url to extension and dom ui requests.rafaelw@chromium.org2010-04-022-1/+4
| | | | | | | | Additionally, in the extension and tabs api, compute & report UMA histogram data for relative URL use in API calls so we can decide if it's possible to change the behavior of relative url resolution to use the calling frame's url rather than the extension's base url. Review URL: http://codereview.chromium.org/1605005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43523 0039d316-1c4b-4281-b951-d872f2087c98
* Show an infobar when the user is using an unsupported flag.viettrungluu@chromium.org2010-04-013-6/+21
| | | | | | | | | | | | Patch stolen from Evan and a translatable string added: <http://codereview.chromium.org/490019>. BUG=40113 TEST=Run Chromium with --no-sandbox; should get an infobar warning that you're going to die young. Review URL: http://codereview.chromium.org/1599010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43361 0039d316-1c4b-4281-b951-d872f2087c98
* Makes tab contents look for extension whose extent contains thesky@chromium.org2010-04-012-15/+143
| | | | | | | | | | | current url and fetches the smallish icon if the extension is found. BUG=none TEST=none Review URL: http://codereview.chromium.org/1576006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43345 0039d316-1c4b-4281-b951-d872f2087c98
* Make the browser survive massive data: URIs, via various techniques:cevans@chromium.org2010-04-011-3/+9
| | | | | | | | | | | | | | | | | | | | | | | 1) Drop the URL limit from 10MB to 2MB. The browser survives without this, but that final tweaks makes the whole data: URI attack fairly smooth (on my admittedly powerful machine). 2) Elide the title string at kMaxTitleChars. We already have a hard title limit but there was a path whereby the title is implied by the URL (e.g. file: and data: etc). 3) For massive URLs, limit the length shown in URL bar. We need to support them, because someone might redirect to a data: URI with e.g. an image in it. However, attempting to show them would kill the browser. We can't elide them because eliding URLs is a security risk (and would lead to correctness issues with an edit/press enter cycle). So we show at least the origin (minus path) or just the scheme for data: URIs BUG=33952 TEST=NONE Review URL: http://codereview.chromium.org/1569011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43319 0039d316-1c4b-4281-b951-d872f2087c98
* Added item to Show/Hide video controls in the context menu for <video>.scherkus@chromium.org2010-03-311-0/+24
| | | | | | | | | | | | | Patch by sergeyu@chromium.org http://codereview.chromium.org/1081011/show BUG=19848 TEST=Right-click on video, toggle "Show Controls". For audio the item must be disabled. Review URL: http://codereview.chromium.org/1589003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43172 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent warning on Mac about uninitialized variable by initializing thebrettw@chromium.org2010-03-301-0/+1
| | | | | | | | | | variable in the failure case. BUG=none TEST=none Review URL: http://codereview.chromium.org/1534007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43124 0039d316-1c4b-4281-b951-d872f2087c98
* Extend the file browser/chooser to support more modes of operation, and plumbbrettw@chromium.org2010-03-302-14/+27
| | | | | | | | | | | | | it through to the pepper API. This pepper API just supports adding the filename to the "upload files" whitelist and returning it to the plugin, but it does not actually give any ability for a sandboxed plugin to read the file (this will come in a separate changelist). TEST=none BUG=none Review URL: http://codereview.chromium.org/1094004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43123 0039d316-1c4b-4281-b951-d872f2087c98
* Make repost form warning tab-modal on Windows.bauerb@chromium.org2010-03-301-0/+5
| | | | | | | | | | | Also, add a type ConstrainedDialogDelegate that is used for constrained windows that show a dialog. In a future CL, Mac and Gtk will be changed to use that type. BUG=26271 TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html, hit Submit, then refresh. The warning sheet should be tab-modal, not window-modal. Opening a login form (which is also tab-modal) while the warning is shown should not crash, neither should hitting the reload button again, or bringing up the warning while a login form is shown. Review URL: http://codereview.chromium.org/1138009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43112 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sync leaks and some more good stuff.skrul@chromium.org2010-03-302-13/+0
| | | | | | | | | | | | | | This is a continuation of zork's change http://codereview.chromium.org/1354001 that adds some preventitive DCHECKs througout the sync code to make sure stuff happens on the UI thread. This also includes a leak fix in the ProfileSyncServiceTypedUrlTest. The final change is changing the TestingProfile to return a ProfileSyncServiceMock rather than a real ProfileSyncService. This should help prevent random test failes due to other tests that need to use the PSS. BUG=38490,38487 Review URL: http://codereview.chromium.org/1383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43102 0039d316-1c4b-4281-b951-d872f2087c98
* Making the translate context menu reset the blacklisting.jcivelli@chromium.org2010-03-301-5/+10
| | | | | | | | | | | | | BUG=None TEST=Select a site in a language different than the Chrome language, select never translate this site/language. Visit that site again, use the context menu to translate. The site and language should not be blacklisted for translation anymore. Review URL: http://codereview.chromium.org/1551001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43058 0039d316-1c4b-4281-b951-d872f2087c98
* Show the location bar icon (almost) all the time, and have its contents ↵pkasting@chromium.org2010-03-301-10/+10
| | | | | | | | | | | | | | | | | | match what the user is doing. There are a couple major moving parts here: * Change AutocompletePopupModel::URLsForCurrentText() to InfoForCurrentText() and have it return an AutocompleteMatch, which callers can use to parse out whatever they want. I needed to get at the match type for the current text and found the proliferation of arguments here ridiculous. This had major ripple effects throughout the codebase, including changing the name and location of SearchVersusNavigateClassifier as it no longer had an "is_search" parameter directly, so the name became misleading and too narrow. I also ended up adding a null constructor for AutocompleteMatch because it was too cumbersome otherwise. * Change the name of the "SecurityImageView" (or similar) to reflect its broader purpose, and plumb it to the edit to get an icon instead of to the toolbar model. * Add an AutocompleteMatch::Type to icon mapping function, and use it not only in the new code but also to simplify showing the popup contents. BUG=27570,39725 TEST=An icon should appear next to the address at all times. It should be a globe on non-secure pages, a magnifying glass on the NTP, and a match for whatever the user is typing as he types. Review URL: http://codereview.chromium.org/1457002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43025 0039d316-1c4b-4281-b951-d872f2087c98
* Focus the location bar on any navigation to the NTP. Specifically, this ↵pkasting@chromium.org2010-03-306-10/+39
| | | | | | | | | | | | focuses it on back/forward navigations. This becomes important for some upcoming omnibox M5 changes, and was what Glen and Scott and I agreed was the right behavior. BUG=none TEST=ctrl-t + navigate + click in page + hit back button = location bar focused Review URL: http://codereview.chromium.org/1423003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43020 0039d316-1c4b-4281-b951-d872f2087c98
* This CL ensures the interstitial when hidden does not calljcivelli@google.com2010-03-291-1/+4
| | | | | | | | | | | | | Show on the RenderWidgetHostView. on Windows this would cause the tab HWND to be parented to the desktop (as Show was called when Hide had not been called). BUG=36290 TEST=See bug for steps. Review URL: http://codereview.chromium.org/1388002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42991 0039d316-1c4b-4281-b951-d872f2087c98
* reland cl that implement error state for translate infobarkuan@chromium.org2010-03-292-7/+10
| | | | | | | | | | | | - original review URL: http://codereview.chromium.org/1321003 - this reland fixes uniitest build break in translate_manager_unittest.cc BUG=38548 TEST=none yet (details in original review url) Review URL: http://codereview.chromium.org/1542003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42976 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "implement error state for translate infobar"phajdan.jr@chromium.org2010-03-292-10/+7
| | | | | | | | | | | Due to broken build (compile). TBR=kuan BUG=38548 Review URL: http://codereview.chromium.org/1567001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42955 0039d316-1c4b-4281-b951-d872f2087c98
* implement error state for translate infobarkuan@chromium.org2010-03-292-7/+10
| | | | | | | | | | | | | | | | | | | | | | | - this cl implements the UI on Windows and the partial backend of IPC messaging to include error type - implement error state - add translate error types - use a structure as details for IPC messaging between render view and browser so as to include error type (was using std::pair) - translate delegate handles error state and provides mapping to error messages - infobar handles visual error states - modify background painting to handle normal and error backgrounds, and animation of cross-fading between the 2 backgrounds - infobar now stores state (and translation_pending flag) that it's currently displaying to user, instead of just relying on TransateInfoBarDelegate's - if infobar receives PAGE_TRANSLAED notification before delegate does (possible because order is not fixed), delegate's state won't be updated to be used by infobar. - after all the observers have received the notification, both infobar and delegate will end up with matching states, so there's no worries of out-of-sync. - update unittests accordingly - update mac and linux code accordingly to make build pass - jay will implement the remaining backend to pass actual translate error types to the IPC message (tracked by bug 37778) BUG=38548 TEST=none yet, until bug 37778 is also fixed. Review URL: http://codereview.chromium.org/1321003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42953 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the translate menu behavior.jcivelli@chromium.org2010-03-291-9/+21
| | | | | | | | | | | | | | | | | | | | | The correct behavior is to always have the menu showing, it is disabled when the page is translated or a Chrome page (new tab page, history...). Selecting the translate menu triggers a translation of the page to the Chrome UI language. BUG=35480 TEST=Open the page context menu on the new tab page. There should be a translate menu and it should be disabled. Navigate to a page in a foreign language. Opne the context menu. The translate menu should be enabled. Select it. The page should be translated. Open the context menu again on the translated page. The translate menu should be disabled. Review URL: http://codereview.chromium.org/1402003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42932 0039d316-1c4b-4281-b951-d872f2087c98
* Committing for Eric Dingle.mad@chromium.org2010-03-262-0/+17
| | | | | | | | | | http://codereview.chromium.org/890005 BUG=0 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42800 0039d316-1c4b-4281-b951-d872f2087c98
* Clarify a comment about the geolocation content settings mapjoth@chromium.org2010-03-261-2/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1361004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42755 0039d316-1c4b-4281-b951-d872f2087c98
* Add Geolocation to the content types. This adds several special case guards ↵joth@chromium.org2010-03-251-0/+6
| | | | | | | | | | | | | so we can still build & run whilst the full implementation is being worked on (in parallel) (Some code taken from http://codereview.chromium.org/650180) BUG=11246 TEST=Built & ran on all three platforms. Used geolocation & open content setting dialog. Review URL: http://codereview.chromium.org/1241006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42633 0039d316-1c4b-4281-b951-d872f2087c98
* Adds GeolocationContentSettings on TabContents. joth@chromium.org2010-03-252-0/+31
| | | | | | | | | | | | | | | | This data structure and the notification flow will be used to populate the location bar icon and its bubble. - this was originally part of http://codereview.chromium.org/650180 - Fully reviewed as http://codereview.chromium.org/1143002 I'm just landing on Marcus's behalf TBR=bulach BUG=11246 TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/1320005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42594 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a context menu to bring up or bring back the translate infobarjcivelli@chromium.org2010-03-251-0/+21
| | | | | | | | | | | | | | | | when it is not showing. BUG=35480 TEST=Open a page so that the translate infobar is shown. Close the infobar. Use the page translate context menu, make sure it works. Do the same thing but make sure you translate the page first. Make sure the menu is not enabled on Chrome specific pages (new tab, history, downloads...) as well as on interstitials. Review URL: http://codereview.chromium.org/1151003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42582 0039d316-1c4b-4281-b951-d872f2087c98
* Make repost form warning tab-modal on Gtk.bauerb@chromium.org2010-03-241-2/+4
| | | | | | | | | | | | | This is the Gtk version of http://codereview.chromium.org/969003. Trying this again after it broke the Chrome OS build the first time (which was http://src.chromium.org/viewvc/chrome?view=rev&revision=42474). BUG=26271 TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html, hit Submit, then refresh. The warning sheet should be tab-modal, not window-modal. Opening a login form (which is also tab-modal) while the warning is shown should not crash, neither should bringing up the warning while a login form is shown. Review URL: http://codereview.chromium.org/1279003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42497 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42474 - Make repost form warning tabmodal on Gtk.dhollowa@chromium.org2010-03-241-4/+2
| | | | | | | | | | | | | | This is the Gtk version of http://codereview.chromium.org/969003. BUG=26271 TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perlcgi/programs/form1POST.html, hit Submit, then refresh. The warning sheet should be tabmodal, not windowmodal. Opening a login form (which is also tabmodal) while the warning is shown should not crash, neither should bringing up the warning while a login form is shown. Review URL: http://codereview.chromium.org/660434 TBR=bauerb@chromium.org Review URL: http://codereview.chromium.org/1247004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42479 0039d316-1c4b-4281-b951-d872f2087c98
* Make repost form warning tab-modal on Gtk.bauerb@chromium.org2010-03-241-2/+4
| | | | | | | | | | | This is the Gtk version of http://codereview.chromium.org/969003. BUG=26271 TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html, hit Submit, then refresh. The warning sheet should be tab-modal, not window-modal. Opening a login form (which is also tab-modal) while the warning is shown should not crash, neither should bringing up the warning while a login form is shown. Review URL: http://codereview.chromium.org/660434 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42474 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42366 - Allow TabContentsDelegate classes to specify whether InfoBars ↵joi@chromium.org2010-03-232-17/+0
| | | | | | | | | | | | | | | | are enabled. Allow ChromeFrame to pass infobar enabled parameter to ExternalTabContainer. BUG=2444936 Patch contributed by ericdingle@google.com Original review at http://codereview.chromium.org/890005 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/1205001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42378 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 05:48:54 +0000