summaryrefslogtreecommitdiffstats
path: root/chrome/browser/tab_contents
Commit message (Collapse)AuthorAgeFilesLines
* Instant - move AutocompleteLosingFocus implementation to InstantController.estade@chromium.org2010-11-012-2/+2
| | | | | | | | | | | This way Linux and Windows can share. BUG=58937 TEST=manual Review URL: http://codereview.chromium.org/4157004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64657 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor automation messages." due to mysterious problems on mac.erg@google.com2010-11-017-13/+57
| | | | | | | | | | | | | This reverts commit c1c1fed998ee4d839bfe256150e5e59220ebc0ef (r64637). TBR=nirnimesh@ BUG=51409 TEST=none Review URL: http://codereview.chromium.org/4194007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64644 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor automation messages.erg@google.com2010-11-017-57/+13
| | | | | | | | | | | | | | | | | automation_messages used to live in chrome/test/automation, when it's needed by browser and chrome_frame. When I started lifting code out of headers and into implementation files, I was getting link errors and temporarily solved the problem by compiling the cc files manually into libbrowser.a. Now this is part of chrome/common/ which is included by all targets needed. While doing this, discover that automation IPC redefines the ContextMenuParams struct. Rename it to MiniContextMenuParams. BUG=51409 TEST=none Review URL: http://codereview.chromium.org/4200007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64637 0039d316-1c4b-4281-b951-d872f2087c98
* Part 3 of immutable Extension refactor.mpcomplete@chromium.org2010-10-294-13/+14
| | | | | | | | | | | | | Make ExtensionsService hold const Extension pointers only. This ensures that extensions can't be modified after they're created, and lets us share them between threads. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4138006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64517 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tabbing into web area not focusing first element.avi@chromium.org2010-10-291-0/+25
| | | | | | | | | BUG=49738 TEST=as in bug Review URL: http://codereview.chromium.org/3153039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64465 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] Added unit tests for omnibox highlightingscr@chromium.org2010-10-271-0/+1
| | | | | | | | | | BUG=55418 TEST=unit_tests --gtest_filter=AutocompletePopupViewGtkTest.\* should run tests on GTK but not Windows or Mac. Review URL: http://codereview.chromium.org/4082002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64169 0039d316-1c4b-4281-b951-d872f2087c98
* First try at a DOMUI based textfield in chrome. This is a copy of the issue ↵rjkroege@google.com2010-10-271-0/+6
| | | | | | | | | | | | I first created (http://codereview.chromium.org/3582018). I deleted that issue accidentally :( So I will copy all the comments from that issue to here (I still have that browser window open fortunately) BUG=none TEST=none Review URL: http://codereview.chromium.org/3977001 Patch from Varun Jain <varunjain@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64158 0039d316-1c4b-4281-b951-d872f2087c98
* Fix file URL detection in WebDragDestGtk.dcheng@chromium.org2010-10-271-2/+5
| | | | | | | | | BUG=60804 TEST=Drag links into input boxes. Review URL: http://codereview.chromium.org/4151007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64132 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing top sites refactor:sky@chromium.org2010-10-271-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactors TopSites so that it's hopefully easier to maintain and doesn't suffer the plethora of threading issues that exist with the current version. Here's the breakdown of what was refactored: . TopSitesCache: Contains the most visited urls and thumbnails. . TopSitesBackend: All mutations to topsites data end up calling into the backend on the UI thread. TopSitesBackend processes the method on the DB thread calling through to the TopSitesDatabase. . TopSites: uses two TopSitesCache. One that contains the raw history data, the other contains the processed data (pinned/blacklisted). The processed cache can be accessed on any thread. TopSites waits until history loads to know if it should migrate or use it's own db. I could probably make these execute in parallel, but for now this is how it works. This patch also makes it so the dom ui accesses the thumbnails on the IO thread. BUG=56382 TEST=Make sure all your thumbnails are correctly updated and you don't see problems. Review URL: http://codereview.chromium.org/4051004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64072 0039d316-1c4b-4281-b951-d872f2087c98
* [gtk] spoof proof infobars, take 2estade@chromium.org2010-10-264-20/+0
| | | | | | | | | | | | | | | | | | This looks like a big review, but a lot of it is just shuffling code around: - rip out dropshadow code - move arrow state and drawing to a model class, to allow sharing between BrowserWindow and Infobar - get rid of InfoBar's border_bin_ and slightly simplify baseclasses by no longer requiring them to call show() on the toplevel widget Added stuff: - transition between arrow colors (previous_color_ vs. target_color_ business) - arrows protruding on neighboring infobars BUG=48996 TEST=manual, with animations slowed down 100x Review URL: http://codereview.chromium.org/3919004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63956 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring select popup on Mac.jcivelli@google.com2010-10-268-5/+198
| | | | | | | | | | | | | | The select popup on Mac was based on a hack: we would create an invisible RenderWidget and redirect mouse and keyboard events to it and we would display a native Cocoa menu. With this CL we do not use a RenderWidget anymore, we send the user selection to the RenderView which in turns communicates to WebKit that selection. BUG=None TEST=On Mac, ensures the select popup works as expected. Also test that for an extension with a browser action containing a select popup, the select popup does work. Also ensures autocomplete/autofill still works (especially popups). Original review: http://codereview.chromium.org/3795006/show Review URL: http://codereview.chromium.org/4078003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63906 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure save-as right click menu obeys content restrictions.jam@chromium.org2010-10-251-0/+6
| | | | | | | BUG=60347 Review URL: http://codereview.chromium.org/4089001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63804 0039d316-1c4b-4281-b951-d872f2087c98
* dom-ui settings: Add setting for detault zoom level.csilv@chromium.org2010-10-252-5/+21
| | | | | | | | BUG=11321 TEST=Exercise the default zoom level setting in the 'Under the hood' panel. Review URL: http://codereview.chromium.org/3807001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63702 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63687 - Refactors TopSites so that it's hopefully easier to maintain andsky@chromium.org2010-10-241-5/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | doesn't suffer the plethora of threading issues that exist with the current version. Here's the breakdown of what was refactored: . TopSitesCache: Contains the most visited urls and thumbnails. . TopSitesBackend: All mutations to topsites data end up calling into the backend on the UI thread. TopSitesBackend processes the method on the DB thread calling through to the TopSitesDatabase. . TopSites: uses two TopSitesCache. One that contains the raw history data, the other contains the processed data (pinned/blacklisted). The processed cache can be accessed on any thread. TopSites waits until history loads to know if it should migrate or use it's own db. I could probably make these execute in parallel, but for now this is how it works. This patch also makes it so the dom ui accesses the thumbnails on the IO thread. BUG=56382 TEST=Make sure all your thumbnails are correctly updated and you don't see problems. Review URL: http://codereview.chromium.org/3440018 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/4048005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63695 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors TopSites so that it's hopefully easier to maintain andsky@chromium.org2010-10-241-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | doesn't suffer the plethora of threading issues that exist with the current version. Here's the breakdown of what was refactored: . TopSitesCache: Contains the most visited urls and thumbnails. . TopSitesBackend: All mutations to topsites data end up calling into the backend on the UI thread. TopSitesBackend processes the method on the DB thread calling through to the TopSitesDatabase. . TopSites: uses two TopSitesCache. One that contains the raw history data, the other contains the processed data (pinned/blacklisted). The processed cache can be accessed on any thread. TopSites waits until history loads to know if it should migrate or use it's own db. I could probably make these execute in parallel, but for now this is how it works. This patch also makes it so the dom ui accesses the thumbnails on the IO thread. BUG=56382 TEST=Make sure all your thumbnails are correctly updated and you don't see problems. Review URL: http://codereview.chromium.org/3440018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63687 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63535 - Disable GPU features AcceleratingCompositing and WebGL by ↵enne@chromium.org2010-10-221-2/+2
| | | | | | | | | | | | | | | | | | default. (This change got checked into trunk only to get merged into M8.) Flags have been switched to reversed logic, and about_flags.cc modified to expose these to users in GUI. BUG=56053, 59092 TEST=Use about:flags to toggle features, confirm state with e.g. http://webglsamples.googlecode.com/hg/aquarium/aquarium.html http://webkit.org/blog-files/3d-transforms/poster-circle.html Vince's change for about:flags. Review URL: http://codereview.chromium.org/3978002 TBR=vangelis@chromium.org Review URL: http://codereview.chromium.org/3974004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63547 0039d316-1c4b-4281-b951-d872f2087c98
* Disable GPU features AcceleratingCompositing and WebGL by default.enne@chromium.org2010-10-221-2/+2
| | | | | | | | | | | Flags have been switched to reversed logic, and about_flags.cc modified to expose these to users in GUI. BUG=56053, 59092 TEST=Use about:flags to toggle features, confirm state with e.g. http://webglsamples.googlecode.com/hg/aquarium/aquarium.html http://webkit.org/blog-files/3d-transforms/poster-circle.html Vince's change for about:flags. Review URL: http://codereview.chromium.org/3978002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63535 0039d316-1c4b-4281-b951-d872f2087c98
* Add policy to disable Developer-Tools.markusheintz@chromium.org2010-10-221-2/+13
| | | | | | | | | BUG=49600 TEST=none Review URL: http://codereview.chromium.org/3965003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63520 0039d316-1c4b-4281-b951-d872f2087c98
* Move inspector to "chrome-devtools" schemepodivilov@chromium.org2010-10-222-10/+4
| | | | | | | | Pages with "chrome" scheme have very narrow permissions (e.g. no access to localStorage). We want inspector page to have the same permissions as usual page. Review URL: http://codereview.chromium.org/3838005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63495 0039d316-1c4b-4281-b951-d872f2087c98
* Remove src/app's dependency on the WebKit api.tony@chromium.org2010-10-211-3/+3
| | | | | | | | | | src/app shouldn't depend on webkit in anyway. DEPS allows this because it allows paths pulled in by deps = {} (stuff pulled in by gclient). Add a new rule to explicitly disallow this. Review URL: http://codereview.chromium.org/3998004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63434 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63232 - On Windows, create a new TransportDIB::Handle struct which ↵kkania@chromium.org2010-10-201-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | includes the file mapping HANDLE and the source process ID. Duplicating the handle for the remote process is done in TransportDIB::Map, instead of in various #ifdefs scattered across the code. Also on windows, remove the struct for the TransportDIB::Id which contained both the sequence number and the HANDLE and replace it with just the sequence number. Fix ThumbnailGenerator by mapping the TransportDIB on Windows and adding a method to duplicate the file mapping handle before sending across the channel. Also, add a ScopedHandle and fix some handle leaks. BUG=none TEST=none Review URL: http://codereview.chromium.org/3834003 TBR=kkania@chromium.org Review URL: http://codereview.chromium.org/3943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63246 0039d316-1c4b-4281-b951-d872f2087c98
* Disable detection of Extension URL Scheme from blocking GPU rendering.vangelis@chromium.org2010-10-201-2/+1
| | | | | | | | | | | | This is a on-line fix that removes the test that detects if the Extension URL scheme is being used, and disables GPU acceleration. Patch provided by James MacLean <wjmaclean@chromium.org> BUG=56716 TEST=none Review URL: http://codereview.chromium.org/3901004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63241 0039d316-1c4b-4281-b951-d872f2087c98
* On Windows, create a new TransportDIB::Handle struct which includes the filekkania@chromium.org2010-10-201-2/+4
| | | | | | | | | | | | | | | | | | | | mapping HANDLE and the source process ID. Duplicating the handle for the remote process is done in TransportDIB::Map, instead of in various #ifdefs scattered across the code. Also on windows, remove the struct for the TransportDIB::Id which contained both the sequence number and the HANDLE and replace it with just the sequence number. Fix ThumbnailGenerator by mapping the TransportDIB on Windows and adding a method to duplicate the file mapping handle before sending across the channel. Also, add a ScopedHandle and fix some handle leaks. BUG=none TEST=none Review URL: http://codereview.chromium.org/3834003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63232 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63067 - This adds some plumbing for propagating the status and error ↵gspencer@chromium.org2010-10-193-19/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | code of a renderer process that went away so that we can tell at the UI level what happened to the tab: did it crash, or was it killed by the OOM killer (or some other reason). This is in preparation for implementing a new UI for when a process is killed by the OOM on ChromeOS which handles it differently from a crash. Most of the changes are modifications of the argument list to include a status and error code for the exited process, but in addition the following was done: - Changed the name of DidProcessCrash to GetTerminationStatus. - Added some new enum values to TerminationStatus enum (and named it) in process_util.h, so it can be used as the status returned by WhatHappenedToProcess. - Improved process_util_unittest to actually test for crashing and terminated processes on all platforms. - Added a new notification for renderers that were killed. - Added error code information to crash notification. - Added status and error code information to renderer IPC message for RenderViewGone. - Added a UMA histogram count for number of renderer kills. [This change was previously reviewed and LGTM'd: http://codereview.chromium.org/3386014/show but due to issues with "git cl push" was never committed to the tree.] BUG=none TEST=ran new unit test. Test passes on try servers. Review URL: http://codereview.chromium.org/3869001 TBR=gspencer@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63074 0039d316-1c4b-4281-b951-d872f2087c98
* This adds some plumbing for propagating the status and error code of agspencer@chromium.org2010-10-193-8/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | renderer process that went away so that we can tell at the UI level what happened to the tab: did it crash, or was it killed by the OOM killer (or some other reason). This is in preparation for implementing a new UI for when a process is killed by the OOM on ChromeOS which handles it differently from a crash. Most of the changes are modifications of the argument list to include a status and error code for the exited process, but in addition the following was done: - Changed the name of DidProcessCrash to GetTerminationStatus. - Added some new enum values to TerminationStatus enum (and named it) in process_util.h, so it can be used as the status returned by WhatHappenedToProcess. - Improved process_util_unittest to actually test for crashing and terminated processes on all platforms. - Added a new notification for renderers that were killed. - Added error code information to crash notification. - Added status and error code information to renderer IPC message for RenderViewGone. - Added a UMA histogram count for number of renderer kills. [This change was previously reviewed and LGTM'd: http://codereview.chromium.org/3386014/show but due to issues with "git cl push" was never committed to the tree.] BUG=none TEST=ran new unit test. Test passes on try servers. Review URL: http://codereview.chromium.org/3869001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63067 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize data members in constructor.kmadhusu@chromium.org2010-10-181-1/+1
| | | | | | | | | | CID=1634, 11587, 5007, 13234, 13398, 9295, 8294, 8285 BUG=none TEST=none Review URL: http://codereview.chromium.org/3817007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62945 0039d316-1c4b-4281-b951-d872f2087c98
* Move BaseDropTarget and BaseDragSource from base to app/win. Remove the ↵brettw@chromium.org2010-10-174-33/+23
| | | | | | | | | | "Base" class name prefix and put in the app::win namespace. TEST=none BUG=none Review URL: http://codereview.chromium.org/3822007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62900 0039d316-1c4b-4281-b951-d872f2087c98
* [mac] Fix so that Service menu items show up properly in contextual menus.csilv@chromium.org2010-10-151-1/+1
| | | | | | | | BUG=53117 TEST=Select text and verify that service menu items show up in contextual menu. Review URL: http://codereview.chromium.org/3776006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62773 0039d316-1c4b-4281-b951-d872f2087c98
* Makes session restore work correctly with instant.sky@chromium.org2010-10-154-20/+33
| | | | | | | | | BUG=58956 TEST=see bug Review URL: http://codereview.chromium.org/3783005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62738 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] fix crash when dragging within process over render view.estade@chromium.org2010-10-151-3/+3
| | | | | | | | | | | The data is returned synchronously in gtk_drag_get_data(). We have to set the number of requests beforehand. BUG=59304 TEST=drag bookmark from bookmark bar onto render view; no sad tab Review URL: http://codereview.chromium.org/3830002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62688 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a strange trailing paren. While here, make the indenting nicer too.pkasting@chromium.org2010-10-141-3/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3812004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62652 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes instant so that it correctly deals with child contents. I'vesky@chromium.org2010-10-142-24/+56
| | | | | | | | | | | | | | | changed around BlockedPopupContainer so that it can handle any types and made TabContents offer a mode to block all child content. BUG=58927 TEST=enable instant, go to a site that would normally show a popup on entering (or explicitly enable all popups). While typing in the omnibox the popup shouldn't appear, but as soon as you commit the instant result it should appear. Review URL: http://codereview.chromium.org/3694005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62553 0039d316-1c4b-4281-b951-d872f2087c98
* Remove traces for the WhitelistExtension test. The flakiness seems to be gone.finnur@chromium.org2010-10-141-8/+0
| | | | | | | | | | TBR=aa BUG=59060 TEST=None Review URL: http://codereview.chromium.org/3808005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62536 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a drag-and-drop bug in the bookmark manager on Chrome OS.satorux@chromium.org2010-10-141-3/+27
| | | | | | | | | | | | | | Before the fix, drag-and-drop in the bookmark manager on Chrome OS resulted in a copy rather than move. The drag-and-drop logic is shared with GTK and Views, but there was a subtle difference between the two toolkits, that caused the bug. BUG=chromium-os:7533 TEST=confirmed that dnd in the bookmark manager worked on Linux and Chrome OS Review URL: http://codereview.chromium.org/3743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62524 0039d316-1c4b-4281-b951-d872f2087c98
* Move Stats, histograms, and field trial into a metrics subdirectory of base andbrettw@chromium.org2010-10-143-3/+3
| | | | | | | | | put them in the base namespace. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
* Use CommandUpdater for disabling commands that were disabled by plugins.jam@chromium.org2010-10-135-18/+26
| | | | | | Review URL: http://codereview.chromium.org/3742002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62475 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Update how menu icons are assigned.estade@chromium.org2010-10-131-2/+2
| | | | | | | | | | | | | | | | | | Slightly change the architecture of how icons are assigned to menu items. Also, add stock icons for some additional menu items. And always show icons on overflow menus. BUG=59101 TEST=The major change here is architectural change, so there is little visible change in functionality. But if you right click on a link, it should now show an icon for the 'Open in new tab' menu. patch by sadrul@chromium.org original review: http://codereview.chromium.org/3714003/show Review URL: http://codereview.chromium.org/3816002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62461 0039d316-1c4b-4281-b951-d872f2087c98
* dom-ui settings: Add setting for setting the minimum font size.csilv@chromium.org2010-10-131-0/+2
| | | | | | | | BUG=7417 TEST=Exercise the minimum font size setting in dom-ui settings window. Review URL: http://codereview.chromium.org/3584019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62450 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Fix more ctor/dtors found by clang plugin.erg@google.com2010-10-134-13/+27
| | | | | | | | | | | (1.2 megs off of Debug Linux .a files) BUG=none TEST=compiles everywhere Review URL: http://codereview.chromium.org/3743001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62420 0039d316-1c4b-4281-b951-d872f2087c98
* Add a private pepper API for the pdf plugin to disable copy/print etc. This ↵jam@chromium.org2010-10-123-0/+23
| | | | | | | | | is needed because pdf documents might disallow copying/printing and it's confusing to have an enabled menu item which does nothing. BUG=47364 Review URL: http://codereview.chromium.org/3692007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62345 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeThread to BrowserThread Part22:tfarina@chromium.org2010-10-124-4/+4
| | | | | | | | | | | | | | | | - Include browser_thread instead of chrome_thread in more 97 files. Now the remaining files that are including chrome_thread.h are: chrome_thread.cc and browser_thread.h. They will be fixed next. BUG=56926 TEST=trybots Review URL: http://codereview.chromium.org/3717004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62312 0039d316-1c4b-4281-b951-d872f2087c98
* Inspector settings not updated in profile when inspecting extensions.podivilov@chromium.org2010-10-127-9/+51
| | | | | | | | | BUG=56815 TEST= Review URL: http://codereview.chromium.org/3582021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62285 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust the traces for WhitelistedExtension.finnur@chromium.org2010-10-121-0/+8
| | | | | | | | | | | | Looks like the tabUpdated event is not being received by the extension. TBR=aa BUG=57694 TEST=Tracking down flakiness in a test. Review URL: http://codereview.chromium.org/3702007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62278 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Initial Instant implementation.rohitrao@chromium.org2010-10-121-0/+1
| | | | | | | | | | | | | | | | This is a very rough cut. Many things are still unfinished and will be fixed in future CLs: - Clicking on instant results clears the results. - Suggestions do not work yet. - The omnibox popup overlaps with instant results. - HTTP auth dialogs cause crashes. BUG=56385 TEST=No visible impact when --enable-match-preview is not set on the command line. TEST=Instant results should appear when typing in the omnibox. TEST=Instant results should disappear when clicking outside the browser window or clicking on devtools or the sidebar. Review URL: http://codereview.chromium.org/3624001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62221 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor TemplateURLFetcher to make it more testable and add more tests for it.levin@chromium.org2010-10-111-28/+7
| | | | | | | | | | | I also moved some basic logic from tab_contents to TemplateURLFetcher to make it easier to unit test it. BUG=38475 TEST=unit_tests.exe --gtest_filter=TemplateURLFetcherTest* Review URL: http://codereview.chromium.org/3710001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62207 0039d316-1c4b-4281-b951-d872f2087c98
* Wire up InstallSearchProvider to allow setting the default search provider.levin@chromium.org2010-10-112-5/+31
| | | | | | | | | | | Depends on http://codereview.chromium.org/3673002/show. BUG=38475 TEST=Next patch changes the callback mechanism TemplateURLFetcher to make it much more testable and adds tests. (I kept it out of this one to make this more focused.) Review URL: http://codereview.chromium.org/3652003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62204 0039d316-1c4b-4281-b951-d872f2087c98
* Add the Windows dialog for setting default search provider from js.levin@chromium.org2010-10-112-2/+19
| | | | | | | | | | | Document with the dialog: http://sites.google.com/a/chromium.org/dev/developers/design-documents/chromium-search-provider-js-support BUG=38475 TEST=Used a custom html page which calls window.external.AddSearchProvider(url, true). Review URL: http://codereview.chromium.org/3673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62199 0039d316-1c4b-4281-b951-d872f2087c98
* Change plugin content settings to three states: Allow, click-to-play, and block.bauerb@chromium.org2010-10-111-2/+2
| | | | | | | | | | | | | The click-to-play default setting says "Let me choose which plug-ins to run". XIB changes: Change the middle radio button label in plug-in default settings from IDS_PLUGINS_LOAD_SANDBOXED_RADIO to IDS_PLUGINS_ASK_RADIO. BUG=35316,56514,56270 TEST=ContentSettingsBubbleModelTest.*, mainly Review URL: http://codereview.chromium.org/3608007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62146 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeThread to BrowserThread Part13:tfarina@chromium.org2010-10-104-16/+16
| | | | | | | | | | | | | - Rename entries under appcache, automation, chromeos, cocoa, file_system, metrics, policy, prefs, remoting, search_engines and tab_contents. BUG=56926 TEST=trybots Review URL: http://codereview.chromium.org/3660002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62120 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug that caused web pages not to accept drag and drop on Chrome OS.satorux@chromium.org2010-10-091-1/+3
| | | | | | | | | | | | | | In ShouldAcceptDragAndDrop(), delegate() can be NULL if the delegate is not set yet, hence the function could return false when it should not, before the fix. TEST=opened the bookmark manager, and confirmed that drag and drop worked. BUG=chromium-os:4874 BUG=chromium-os:6444 Review URL: http://codereview.chromium.org/3598020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62067 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 17:57:43 +0000