| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Moves a bunch of methods from glue to the WebKit API.
R=dglazkov
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/246079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
clipboard_util to clipboard_util_win since it's Windows-only. This patch makes
test_shell depend on app as well. There should be no logic change.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/260003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
view. This is needed
for system keyboard messages which are generated when the Alt key is pressed in addition to other
keys to function correctly in ChromeFrame.
The TabContentsView implementation for windows does the right thing by specifically checking for keydown
events before processing them as accelerators. The TabContentsView implementation for Linux also treated
keyup messages as accelerators, which is now fixed.
This fixes parts of http://code.google.com/p/chromium/issues/detail?id=22996
Bug=22996
Review URL: http://codereview.chromium.org/255028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't time all loads of the new tab page, just new foreground
tabs using ctrl+t or the plus button. This includes the time it takes
to create the tab contents and logs the time until JS has started
executing, domcontentloaded, and onload.
Note: onload doesn't mean the page is done loading. We have "NewTabUI load" for that.
BUG=23120
Review URL: http://codereview.chromium.org/242107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
some redirects.
R=brettw
BUG=21353
TEST=none
Review URL: http://codereview.chromium.org/246073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/5638
TEST=existing tab strip model tests, Fast shutdown ui tests, new tab strip model fast shutdown test
Review URL: http://codereview.chromium.org/235050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This avoids tabs maliciously preventing closing using ctrl+f4/ctrl+w/alt+f4, and also hung/slow renderers from making tab cycling sluggish.
BUG=5496
TEST=added ui test
Review URL: http://codereview.chromium.org/224023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[crbug.com/13488].
This turns out to be because it was never implemented.
Tested manually on Windows; I'll test on Linux before submitting.
BUG=13488
TEST=Tested manually on Windows and added a unit test for the new Clipboard function.
Review URL: http://codereview.chromium.org/210042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ENABLE_3D_CANVAS in development builds. Currently this argument also
requires disabling the sandbox.
BUG=http://crbug.com/21852
TEST=none (runs preexisting WebGL layout tests; more coming)
Review URL: http://codereview.chromium.org/246042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The initialization of the ProfileSyncService was being called twice in one test.
Test=RenderViewHostManagerTest in unittests
Bug=none
Review URL: http://codereview.chromium.org/248036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use Helvetica, Times, Courier, Apple Chancery, and Papyrus for sans-serif,
serif, monospace, cursive, and fantasy, respectively. These are the fonts
used by Safari and Firefox on the Mac, and the fonts that we run layout tests
with on the Mac.
BUG=19135 21458
TEST=http://www.w3.org/Style/Examples/007/fonts
Check the fonts for sans-serif, serif, monospace, cursive, fantasy
Note that the font used for "Helvetica, sans-serif" is actually Verdana
Review URL: http://codereview.chromium.org/244039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=1315
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/243029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
default.
BUG=none
Test=Sync my bookmarks should be enabled by default.
Review URL: http://codereview.chromium.org/248024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22528
Review URL: http://codereview.chromium.org/249023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
process makes a win32 call that ends up waiting on the plugin. Since the plugin thread is blocked, the Windows message doesn't get dispatched and the browser ui thread deadlocks. The message from the renderer would make the plugin run a nested message loop but it doesn't get run on the browser ui thread since it's blocked. The fix is to set the event that runs nested message loop in the renderer process.
BUG=23147
TEST=ui tests already cover nested message loops and plugins. This particular scenario is hard to write a test case for because it's a race condition involving the browser.
Review URL: http://codereview.chromium.org/243018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
renaming it ExtensionAction.
No code change.
BUG=None
TEST=Page actions and browser actions should work as before (no change)
Review URL: http://codereview.chromium.org/242035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
wstring to avoid conversions "To and From wstring".
BUG=None
TEST=run unit_tests.exe
Review URL: http://codereview.chromium.org/217008
Patch from tfarina.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
APIs. This change is purely additive. I'll rip out the old mechanism in the
next patch.
R=agl
Review URL: http://codereview.chromium.org/243012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Browser Actions are like Page Actions, except they appear next to the Omnibox and are always visible. For details see http://code.google.com/p/chromium/wiki/BrowserActions.
Added a simple browser action sample that adds a Print button to the chrome toolbar (which brings up the Print dialog for the current page).
Removed |type| from PageActions, which is currently ignored and was already removed from the docs.
Each extension can only have 1 browser_action. Each browser action can specify more than one icon, but only the first is used. And no API has been added yet (besides the event definition).
BUG=22099
TEST=Install the sample browser action, navigate to google.com, press the print button. A print dialog should come up.
Review URL: http://codereview.chromium.org/243001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
use these notifications in a future patch.
No behavior change.
R=agl
Review URL: http://codereview.chromium.org/241004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
sites from popping up a lot of dialogs (or in the case of whitelisted protocols, launching a lot of programs).
BUG=3628
TEST=test.html from crbug.com/21049
Review URL: http://codereview.chromium.org/240002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bar. This happened because when we changed from needing a
bookmarkbar/extension-shelf to not needing one we processed the layout
change asynchronously, but could paint immediately and painting always
checks the current state. I initially made painting/layout stay in
sync with regards to whether they thought the bookmark bar should be
shown, which also fixes this, but because we process the change async
there was still some noticable jank. Instead I've changed processing
of the transition from needing bars to not (or vice-versa) to be
synchronous.
BUG=22165
TEST=see bug
Review URL: http://codereview.chromium.org/219034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
size of another TabContents by having an optional TabContents*
passed into the TabContents ctor.
This fixes a race condition where it's possible for a web
page to load before getting the sizing information from the
browser. The new flow passes the size information to the
renderer process before passing the URL to load.
BUG=20159
Review URL: http://codereview.chromium.org/201130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Creates a TabContents in CreateNewWindow rather than a
RenderViewHost. We want to support the ability to open popups from
this menu, so going with TabContents directly seemed the best
option.
. Showing the menu now does a keyboard grab. This is needed so that
keyboard events go to the menu and focus doesn't remain whever it
was when the menu was shown.
BUG=22954
TEST=see bug
Review URL: http://codereview.chromium.org/219037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When sending an HTTP POST request with sufficiently large payload data (such as
uploading a file or several), the status bar should display the progress in the
form of a percentage. The ResourceDispatcherHost periodically sends upload
progress messages to the UI thread as well as to the renderer. If an upload is
occurring, other potential LoadStateChanged messages to the same RenderViewHost
are ignored; this prevents the upload progress display from being interrupted
periodically by "Waiting for <site>" messages.
Original code review:
http://codereview.chromium.org/211050
Original patch by Simon Radford
r=darin
BUG=4715
TEST=Try uploading one or more files (e.g. at a file hosting site) and confirm
that the percentage is shown in the status bar.
Review URL: http://codereview.chromium.org/244001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18268
TEST=run the included test under valgrind without the navigation_controller.cc change, then with. The memcheck condititional jump error shouldn't fire with the fix.
Review URL: http://codereview.chromium.org/220002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and image_operations.* can be moved because they are not used by WebKit code.
This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights.
This is a re-do of r26975, this time with WebKit update and some fixes to compile on Mac and Linux.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/222011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and image_operations.* can be moved because they are not used by WebKit code.
This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/207059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in the constructor.
CID=5442
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/222008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the comment I added to the code.
http://crbug.com/21849
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/210043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Not getting rid of WaitForTitleMatching because I have to add few more calls to the automation framework (http://crbug.com/19395) to wait properly after navigating back and forward.
TEST=Covered by ui_tests and browser_tests.
http://crbug.com/18365, http://crbug.com/19361
Review URL: http://codereview.chromium.org/174179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/12556
TEST=Open two tabs. Focus the omnibox in one, switch tabs and then back again. Omnibox should still have focus. Repeat with the findbar instead of the omnibox.
Review URL: http://codereview.chromium.org/206015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
some time-outs with notifications.
BUG=22065
TEST=Run the interactive tests, especially BrowserFocusTest*FocusTraversal*
These tests should run in few seconds.
Review URL: http://codereview.chromium.org/210013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
particular size.
BUG=21942
TEST=On Linux chrome, load a #anchor page in the background. After
the page loads, view the tab. It should be scrolled to the right
place.
Review URL: http://codereview.chromium.org/214002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/173556
TBR=mpcomplete@chromium.org
Patch from Jerry Tang <tangjie@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/212002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
that they don't show up as mnemonics.
Also escape underscores in gtk menus so they don't show up as mnemonics (we use ampersands to match windows).
BUG=14587
Review URL: http://codereview.chromium.org/203078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Just a small cleanup.
Review URL: http://codereview.chromium.org/206037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/193092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We would crash when an SSL error would happen on a page with no navigation entry.
TEST=Run the test.
BUG=http://crbug.com/19941
Review URL: http://codereview.chromium.org/196115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/194109 for details.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/196122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Leftover cruft.
Review URL: http://codereview.chromium.org/194109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
auto detect
In order to fix the bug I added new interfaces to allow resetting the override encoding (including a new render message).
The new logic is as follows:
-) If the user turns auto-detect OFF, nothing happens (as requested in the bug description)
-) If the user turns auto-detect ON, then the page is reloaded with an empty override encoding
I.e., turning auto-detect on resets a previous override setting.
The reverse is not true, however: specifiying a new override setting will not turn auto-detect off.
BUG=2932
TEST=do the following steps, using the test file (encoding-gb18030.htm) attached to comment 14 of the original bug http://crbug.com/2932 :
1.) load the file while auto-detect is turned off
-> garbage is displayed
2.) turn auto-detect on
-> proper Chinese text should appear
-> in the encoding menu, Chinese encoding should be highlighted
3.) turn auto-detect off
-> proper Chinese text should remain
-> in the encoding menu, Chinese encoding should remain highlighted
4.) choose any other encoding
-> garbage is again displayed (in the new encoding)
5.) turn auto-detect on
-> proper Chinese text should again appear
-> in the encoding menu, Chinese should again be highlighted
Original Review: http://codereview.chromium.org/173265
Patch by Roland Steiner (rolandsteiner@google.com)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This is long overdue.
Review URL: http://codereview.chromium.org/193100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pinkerton
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Note that chrome still does not support _reading_ from the find pasteboard, so hitting cmd-e followed by cmd-g in chrome still doesn't work. Also, cmd-f doesn't write to the find pasteboard yet either.
BUG=14562
TEST=Select some text on a web page, hit cmd-e, go to the same web page in safari, hit cmd-g. Safari should search for the text you selected in chrome.
Review URL: http://codereview.chromium.org/197035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Also had to implement change notification for TextField on views / gtk
Review URL: http://codereview.chromium.org/200035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
now access it from the main menu and context menu and use it to perform
spelling tasks. For more detail, see
http://code.google.com/p/chromium/wiki/SpellingPanelPlanningDoc
Patch from pwicks86@gmail.com (Paul Wicks).
BUG=None
TEST=The spelling panel should work in os x.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=5027
TEST=none
Review URL: http://codereview.chromium.org/194051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25761 0039d316-1c4b-4281-b951-d872f2087c98
|