summaryrefslogtreecommitdiffstats
path: root/chrome/browser/tab_contents
Commit message (Collapse)AuthorAgeFilesLines
* Cleaning up lines longer than 80 chars under src/chrome/browser. mark@chromium.org2009-08-171-1/+2
| | | | | | | | | | | | | | | | | | | Command: awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' *.cc *.h # recursive find . -type f \( -name '*.cc' -o -name '*.h' \) -exec awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' {} \; Patch by Pierre-Antoine LaFayette <pierre.lafayette@gmail.com> BUG=None TEST=None Code review URL: http://codereview.chromium.org/164566 Review URL: http://codereview.chromium.org/171066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23583 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of getBackgroundPage(), getToolstrips(), andaa@chromium.org2009-08-144-1/+19
| | | | | | | | | | | | | | | getTabContentses(). This lands http://codereview.chromium.org/159067. Raf, the only thing you need to look at is the changes to extensions_process_bindings.js and extension_api.json. BUG=13577 TEST=Browser tests added Review URL: http://codereview.chromium.org/164458 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23422 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r23358 with a fix for linux unit_tests:tony@chromium.org2009-08-131-2/+5
| | | | | | | | | | | | | | | | | | Better location for setting the size of tab contents. This should catch all code paths. I noticed that middle clicking a bookmark wasn't working, so I found a single place to do this. This code is always run when a tab is added and it sizes the contents when it's loading in the background. BUG=619 TBR=japhet Review URL: http://codereview.chromium.org/164526 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23384 0039d316-1c4b-4281-b951-d872f2087c98
* When you clicked Get Themes in Mac prefs, the browser window containing the ↵beng@google.com2009-08-131-0/+1
| | | | | | | | | | | | | | | | | themes gallery wasn't coming to the front. There was an implicit assumption on Windows that TabContentsViewWin::Focus caused the window containing the TabContents to be foregrounded. This is because on Windows a HWND is focused with a call to SetFocus, which activates the containing top level window. On Mac, TabContentsViewMac::Focus needs to explicitly activate the containing window. Also, changes the Mac preferences code to call the same function as on Windows, for simplicity. Note: the "foreground" parameter to AddTabWithURL means the tab is opened in the foreground, not that the window is activated. http://crbug.com/18157 TEST=none Review URL: http://codereview.chromium.org/165492 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23378 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r23357 since it doesn't seem to be the cause of unit testtony@chromium.org2009-08-138-42/+42
| | | | | | | | | | | | | | | | | failure: Renames the NavigationEntry::display_url() to virtual_url(). BUG=6970 (http://crbug.com/6970) TEST=None Patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/164383 Review URL: http://codereview.chromium.org/165501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23374 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Renames the NavigationEntry::display_url() to virtual_url()."tony@chromium.org2009-08-138-42/+42
| | | | | | | | | This reverts commit r23357. Review URL: http://codereview.chromium.org/164517 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23367 0039d316-1c4b-4281-b951-d872f2087c98
* Renames the NavigationEntry::display_url() to virtual_url().tony@chromium.org2009-08-138-42/+42
| | | | | | | | | | | | | BUG=6970 (http://crbug.com/6970) TEST=None Patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/164383 Review URL: http://codereview.chromium.org/165485 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23357 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at fixing anchor links opening in background tabs on linux.tony@chromium.org2009-08-131-2/+10
| | | | | | | | | | | | | | | | Also fix a code path that seems to be missing on Windows (maybe this regressed?). This time make sure RWHV is not NULL. BUG=619 TEST=http://code.google.com/p/chromium/issues/detail?id=619#c6 Review URL: http://codereview.chromium.org/165468 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23332 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix anchor links opening in background tabs on linux. Also fix"tony@chromium.org2009-08-131-8/+2
| | | | | | | | | | | | | Some tab opening crashes, I need to null check some pointers. TBR=estade This reverts commit r23317. Review URL: http://codereview.chromium.org/164486 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23320 0039d316-1c4b-4281-b951-d872f2087c98
* Fix anchor links opening in background tabs on linux. Also fixtony@chromium.org2009-08-131-2/+8
| | | | | | | | | | | | | a code path that seems to be missing on Windows (maybe this regressed?). BUG=619 TEST=http://code.google.com/p/chromium/issues/detail?id=619#c6 Review URL: http://codereview.chromium.org/164452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23317 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors OSExchangeData for easier portability.sky@chromium.org2009-08-121-1/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23230 0039d316-1c4b-4281-b951-d872f2087c98
* First step to create application shortcuts on Linux.phajdan.jr@chromium.org2009-08-121-0/+6
| | | | | | | | | | | Create a working desktop shortcut. For now it displays no UI, but the backend works. TEST=none http://crbug.com/17251 Review URL: http://codereview.chromium.org/164280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23226 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Playback Rate from the context menu.scherkus@chromium.org2009-08-121-91/+0
| | | | | | | | | | This feature is better implemented as an extension rather than being put into the absolute-core UI. Review URL: http://codereview.chromium.org/164301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23208 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors drag support from TabContentsViewGtk intosky@chromium.org2009-08-122-249/+16
| | | | | | | | | | | TabContentsDragHandler so that it can be used by both Gtk and Views. BUG=none TEST=none Review URL: http://codereview.chromium.org/165302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23168 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a command line switch to enable the appcache, and plumb the switch ↵michaeln@google.com2009-08-121-0/+2
| | | | | | | | | | | throughto preferences and webcore settings. BUG=none TEST=none Review URL: http://codereview.chromium.org/164306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23135 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for constrained windows on os x, based on Avi's ↵thakis@chromium.org2009-08-113-8/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GTMWindowSheetController. Add carpet bombing dialog as first per-tab sheet. Depends http://codereview.appspot.com/105064 . The main issue with this patch is that GTMWindowSheetController doesn't provide an api to move sheets between windows, so this CL disables tab dragging for tabs with sheets, and fullscreen mode for windows with sheets. We can fix this later. Other stuff that should be done at some point, but not now: * Open/Save panels should be per-tab * Need an ui test that goes to page, then page with sheet, then hit back, forward, reload. * Bookmark sheets should not be sheets but in a separate window BUG=14666 TEST=Go to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html , a per-window sheet should appear. Things to test with this dialog: * Hitting cmd-q while a sheet is open in any tab should not quit but instead focus the sheet. * Hitting cmd-w while a sheet is open in any tab should not close the window but instead focus the sheet. * Dragging a tab with a sheet should move the window (and keep the tab visible), not detach the tab. * Going fullscreen should be disabled for windows with open tabs. * When a per-tab sheet is open in a non-active tab, it shouldn't steal the focus, i.e. going to the page above, then hitting cmd-t, and then hitting cmd-l should work. * Closing a non-frontmost tab with a per-tab sheet shouldn't crash. * Going to the url above and quickly opening a new tab, so that the sheet opens while its tab is not front-most should work (sheet should display only when you switch back to the tab with the sheet). * Go to google.com, then to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html , hit "backward" with open sheet, hit forward, focus location bar, hit enter. This shouldn't crash. * Hitting escape should dismiss the sheet * Hitting enter should confirm the sheet. Review URL: http://codereview.chromium.org/159780 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23091 0039d316-1c4b-4281-b951-d872f2087c98
* Move some Mac l10n helpers out into app/l10n so they are closer to the ↵thomasvl@chromium.org2009-08-071-3/+2
| | | | | | | | | | | | | generic ones. Complete the apis points so the ones folks might need are all there already. Switch the code using the old calls over to the new helpers. TEST=no l10n stuff broke BUG=none Review URL: http://codereview.chromium.org/165132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22753 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few bugs with the theme infobar:aa@chromium.org2009-08-072-0/+26
| | | | | | | | | | | | | | * Don't animate the infobar closing and opening when switching between themes. * Don't show multiple infobars when intalling themes in rapid succession. BUG=18213 Review URL: http://codereview.chromium.org/165029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22711 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Pass font settings through to interstitial renderers.derat@chromium.org2009-08-063-46/+15
| | | | | | | | | BUG=18483 TESTED=restarted and visited a page with a broken SSL cert a few times while changing font settings via gnome-appearance-properties Review URL: http://codereview.chromium.org/164094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22679 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fancy html5 draggy stuff.estade@chromium.org2009-08-052-60/+157
| | | | | | | | | | | | | | | | | | | | | Also, don't crash in release mode when the tab contents is deleted during a drag. 1) Source side: when the tab contents is going down, abort the current drag (if any). Initiate drags on a GtkInvisible (matching firefox, among other programs I assume). This lets us give up ownership of the drag widget and let the drag unwind. 2) Destination side: make a seemingly harmless GTK assert point to a crbug bug. This warrants further investigation. BUG=16249 TEST=drag around ntp thumbnails BUG=18557 In release mode, you should be able to do all the following without crashing or getting any asserts besides the two mentioned in 18557 TEST=drag something from gedit over a tab that closes TEST=drag something from the render view over a tab that closes TEST=drag something from the render view off of the browser from within a tab that closes TEST=repeat all the above with a tab that is being swapped out according to the repro steps in bug 16073 Review URL: http://codereview.chromium.org/159889 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22542 0039d316-1c4b-4281-b951-d872f2087c98
* Implement TabContentsViewMac::SizeContents(), so that the TabContentsViewjaphet@chromium.org2009-08-051-2/+5
| | | | | | | | | | | | gets sized properly on creation. BUG=619 BUG=15960 TEST=none Review URL: http://codereview.chromium.org/162016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22531 0039d316-1c4b-4281-b951-d872f2087c98
* Activate scrollbars (etc.) upon selecting a tab.avi@chromium.org2009-08-041-1/+5
| | | | | | | | | | | | | | | | | | | (Conceivably, the SetActive() could be pushed into the RWHV's DidBecomeSelected(). Conceivably, one could imagine selection without activation, so I chose to put it closer to the UI side of the code in the TabContents. Hmmm. Maybe we should also put in the RWHV::SetActive() method on all platforms.) Patch by viettrungluu. BUG=http://crbug.com/18262 TEST=Make your browser window really small, create new tabs, switch between them. Review URL: http://codereview.chromium.org/160505 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22422 0039d316-1c4b-4281-b951-d872f2087c98
* Port more tests from save_page_uitest.cc to save_page_browsertest.cc.phajdan.jr@chromium.org2009-08-042-4/+5
| | | | | | | | | | | Also add more detailed checks for saved page contents. TEST=Covered by browser_tests. http://crbug.com/3791 Review URL: http://codereview.chromium.org/159858 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22413 0039d316-1c4b-4281-b951-d872f2087c98
* Add some more content to the content scripts docs.aa@chromium.org2009-08-041-1/+6
| | | | | | TBR=rafaelw@chormium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22397 0039d316-1c4b-4281-b951-d872f2087c98
* Move alternate 404 error page loading out of WebFrame and into RenderView.darin@chromium.org2009-08-041-2/+2
| | | | | | | | | | | | | | | | This involved adding a new method on WebViewDelegate to allow the embedder to intercept data being loaded for a document. I also had to plumb a few more FrameLoaderClient notifications through WebViewDelegate. See DidReceiveResponse and DidFinishLoading. R=tony BUG=15648 TEST=covered by errorpage_uitest.cc Review URL: http://codereview.chromium.org/160578 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22389 0039d316-1c4b-4281-b951-d872f2087c98
* Fix or/|| mistake in ifdefstuartmorgan@google.com2009-07-311-1/+1
| | | | | | | | | | TBR=mark BUG=none TEST=none Review URL: http://codereview.chromium.org/160487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22216 0039d316-1c4b-4281-b951-d872f2087c98
* Switch on plugins by default for the Macstuartmorgan@google.com2009-07-311-1/+1
| | | | | | | | | BUG=10809 TEST=Visit a sit with Flash content. Playback should work, interacting with the plugin is still buggy. Review URL: http://codereview.chromium.org/159729 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22209 0039d316-1c4b-4281-b951-d872f2087c98
* Enable dragging of images to desktop (Finder), Preview, etc. (on Mac).thakis@chromium.org2009-07-312-141/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This hooks up drag-and-drop of file promises, lazy writing to the drag pasteboard, drag-sourcing of TIFF images (via Cocoa) and file contents. Patch Set 5 improvements: Adds asynchronous writing of promised files. Patch Set 4 improvements: Big refactoring -- drag source stuff is now handled by the WebDragSource (Cocoa) object, with messages proxied through the TabContentsViewCocoa object. The WebDragSource object carries a weak reference to the TCVC, owns the WebDropData, and keeps track of the drag pasteboard types/promises. Patch Set 3 improvements over Patch Set 2: It shouldn't crash anymore. Made drop_data_ reference counted, in anticipation of asynchronous file writing. TODO #1: Testing. Still need a unit test, maybe. Should make sure that dragging by file contents actually works. TODO #2 (in some other patch): Refactor some of the WebDropData extraction code out, e.g., file name extraction should be made common with other platforms. TODO #3 (in some other patch): We really should make WebDropData cheaper to copy around and retain. I'm not convinced it's a good idea to push out the entire thing over IPC, especially since the data pushed could be very big and may not even be used. BUG=15640 TEST=drag images to various applications Patch by viettrungluu@gmail.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22187 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 20927 - Experiment with opening links opened via context menu in the ↵laforge@chromium.org2009-07-311-1/+1
| | | | | | | | | | | | | | | foreground. BUG=none TEST=tabs opened via "Open link in new tab..." should open in foreground, not background. Review URL: http://codereview.chromium.org/155671 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/160439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22141 0039d316-1c4b-4281-b951-d872f2087c98
* The focus would be messed-up when reloading a crashed tab, also causing ↵jcampan@chromium.org2009-07-291-0/+6
| | | | | | | | | | | | accelerators to be broken. This CL also makes sure to keep the focus on the location bar when reloading the NTP. BUG=http://crbug.com/14954 TEST=See bug. Review URL: http://codereview.chromium.org/160206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21961 0039d316-1c4b-4281-b951-d872f2087c98
* Only allow one theme installation infobar to be shown at a time.glen@chromium.org2009-07-281-0/+7
| | | | | | | | | BUG=None TEST=Install two themes without closing the infobar - make sure only one infobar is visible. Review URL: http://codereview.chromium.org/160296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21910 0039d316-1c4b-4281-b951-d872f2087c98
* Add a NULL check for the pending render view host when we get a close message.brettw@chromium.org2009-07-281-1/+2
| | | | | | | | | I don't think we're guaranteed to have a pending one. BUG=17916 Review URL: http://codereview.chromium.org/160286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21887 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: DnD extravaganzaestade@chromium.org2009-07-281-17/+6
| | | | | | | | | | | | | - Correctly update drag status for drags over renderer. This makes things look quite a bit better. - Rework the dnd utils so that we specify the drag targets in the order we prefer them (for destinations) - Refactor code in bookmark bar so folder and toolbar drags share more code - Allow bookmark bar to accept URI lists and plain text drags (for plain text we require the text to be a valid url) BUG=17431 Review URL: http://codereview.chromium.org/159419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21767 0039d316-1c4b-4281-b951-d872f2087c98
* Re-landing r21673 without re-enabling the BrowserTest, which apparently isbrettw@chromium.org2009-07-274-27/+21
| | | | | | | | | | | | | | | | | | | | | | | | | still failing. Make downloads not prevent tabs from closing. If a download creates a cross-site transition (for example, if you click a link in Gmail that results in a download in a new tab), that tab will be stuck and you can't close it or the browser. This is the opposite problem with a similar cause as bug 16246. In both cases we were using some secondary signal to tell us if we're closing for a cross site transition or closing the tab, and that signal was wrong. In this case, we were running the onunload handler, but because there was a pending RenderViewHost, the RenderManager would think that the close was a cross-site one, and not forward the close message to actually close the tab. This patch adds a flag to the on unload handlers that indicates whether it's for a tab closure or a cross-site transition, so we can do the right thing unambiguously when the message returns. In this case I keep this information in the RenderView in case we send multiple close requests, we'll close the tab if any of them were for the entire tab, even if that particular one was dropped because we don't want to have more than one in flight at once. BUG=17560 TEST=none. Review URL: http://codereview.chromium.org/160122 Review URL: http://codereview.chromium.org/159426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21685 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of r21673 - which caused browser_test failure in ChromeURLAfterDownload.robertshield@chromium.org2009-07-274-21/+27
| | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/160187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21683 0039d316-1c4b-4281-b951-d872f2087c98
* Make downloads not prevent tabs from closing.brettw@chromium.org2009-07-274-27/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | If a download creates a cross-site transition (for example, if you click a link in Gmail that results in a download in a new tab), that tab will be stuck and you can't close it or the browser. This is the opposite problem with a similar cause as bug 16246. In both cases we were using some secondary signal to tell us if we're closing for a cross site transition or closing the tab, and that signal was wrong. In this case, we were running the onunload handler, but because there was a pending RenderViewHost, the RenderManager would think that the close was a cross-site one, and not forward the close message to actually close the tab. This patch adds a flag to the on unload handlers that indicates whether it's for a tab closure or a cross-site transition, so we can do the right thing unambiguously when the message returns. In this case I keep this information in the RenderView in case we send multiple close requests, we'll close the tab if any of them were for the entire tab, even if that particular one was dropped because we don't want to have more than one in flight at once. BUG=17560 TEST=none. Review URL: http://codereview.chromium.org/160122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21673 0039d316-1c4b-4281-b951-d872f2087c98
* Add in UMA logging for context menu playback controls.ajwong@chromium.org2009-07-251-0/+11
| | | | | | | | | BUG=15686 TEST=none Review URL: http://codereview.chromium.org/159371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21598 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where an ongoing find operation would re-appear eventc@google.com2009-07-241-0/+4
| | | | | | | | | | | | | | | | | | though we already changed the find text. On Linux, we would continue doing a find operation. On Windows, the find operation would stop, but the find box would not be cleared. TEST=Go to a long page (like the html 5 spec). Do a find for a very common string (e.g., any single letter). Press backspace to clear the find box while results are still populating. The find box should be cleared and the find stopped. Review URL: http://codereview.chromium.org/159321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21555 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race condition where rapid back/forward clicks could close a tabbrettw@chromium.org2009-07-241-4/+11
| | | | | | | | | | | | | | | | | | | | | | | This can be triggered when you're on the new tab page, going to *two* other sites, then rapidly hitting back and forward randomly. If a cross-site transition was canceled before the original page responds with an "OK to close me" message, it will mistakenly categorize the close as not just for the RenderView (correspondong to one side of the cross-site transition) but for the entire tab. This change adds an explicit parameter on the messages indicating whether it's for interstials or for the tab so we don't have to rely on the request still being active. This also adds the "requesting process + route" in addition to the "new process + request" so we can be more clear about sending the messages to the correct place. The previous patch conbimed these in a confusing way. BUG=16246 TEST=none Review URL: http://codereview.chromium.org/159255 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21531 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the browser to send actions back to the render for media element ↵ajwong@chromium.org2009-07-232-30/+113
| | | | | | | | | | | | | context menus. Also renamed ContextNodeType per fishd's suggestion. BUG=15686 TEST=none Review URL: http://codereview.chromium.org/155954 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21466 0039d316-1c4b-4281-b951-d872f2087c98
* Close pop up notification when navigating to other site.erg@google.com2009-07-231-0/+6
| | | | | | | | | | | | | When BlockedPopupContainer stopped being a ConstrainedWindow, the notification stopped being cleared in TabContents::MaybeCloseChildWindows. http://crbug.com/8622 http://crbug.com/14150 TEST=See 8622 for repro steps. Review URL: http://codereview.chromium.org/159287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21445 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds an infobar instructing users they can do search directly from ↵jcampan@chromium.org2009-07-233-0/+27
| | | | | | | | the location bar when they navigate to their default search engine.The infobar is dismissed and not shown again if the user does a search from the omnibox or dismiss the infobar.This is part of a UX experiment and is behind a switch.BUG=NoneTEST=Start Chrome with a fresh profile. Navigate to www.google.com. An info bar should be shown. Click the 'show me' button, the location bar should display a message explaining search can be made from it. Review URL: http://codereview.chromium.org/159242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21438 0039d316-1c4b-4281-b951-d872f2087c98
* Squash the "Confirm Form Repost" dialog triggered via an external context ↵robertshield@chromium.org2009-07-231-2/+2
| | | | | | | | | | menu reload - the dialog is modal, but there may not be anything for it to be modal to. This is a shorter term fix - a longer term fix will be to change the way the dialog is displayed and allow it to be routed through automation. Review URL: http://codereview.chromium.org/160010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21400 0039d316-1c4b-4281-b951-d872f2087c98
* Flip on crashed plugin name lookup on the Mac.stuartmorgan@google.com2009-07-231-1/+1
| | | | | | | | | BUG=none TEST=Running with --enable-plugins on, go to a page with a plugin and kill the plugin process. The info bar should list the name of the plugin rather than its path. Review URL: http://codereview.chromium.org/155952 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21347 0039d316-1c4b-4281-b951-d872f2087c98
* Split the IPC code into ipc/agl@chromium.org2009-07-222-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This splits the ipc code from the common project. The 'common' project pulls in all of webkit, the v8 bindings, skia, googleurl, and a number of other projects which makes it very difficult to deal with especially for external projects wanting just to use some of Chromium's infrastructure. This puts the ipc code into its top-level ipc/ directory with a dependency only on base. The common project depends on the new ipc/ipc.gyp:ipc target so that all projects currently pulling common in to get the IPC code still have it available. This mostly follows agl's pre-gyp attempt to do this which was r13062. Known issues: - Currently a number of projects depend on chrome/chrome.gyp:common in order to use the IPC infrastructure. Rather than fixing all of these dependencies I have made common depend on ipc/ipc.gyp:ipc and added "ipc" to the include_rules section of DEPS so that checkdeps.py doesn't complain. Over time projects that need IPC should depend on the IPC project themselves and dependencies on common removed, although I don't think many projects that need IPC will be able to get away without common currently. - ipc/ipc_message_macros.h still has #include "chrome/common/..." inside of a ipc/ should not refer to files in chrome/... now. I'm not sure how to resolve this since it's really an IDE bug - the named pipe name (windows+linux) and the logging event name (all) + env variable (posix) refer explicitly to 'Chrome' which somewhat hurts the illusion of ipc/ being an independent library. I think this should be examined in a subsequent, much smaller patch. - I've eliminated the IPC.SendMsgCount counter since it was implemented in a way to create a dependency from ipc/ to chrome/common/chrome_counters. This is the same approach that r13062 took. http://codereview.chromium.org/155905 (Patch from James Robinson) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21342 0039d316-1c4b-4281-b951-d872f2087c98
* Starting mac l10n:thomasvl@chromium.org2009-07-221-5/+2
| | | | | | | | | | | | | | | | | | | Added a script to process a xib file and generate a localizer out of the resource constants it finds in the xib. Update the MainMenu.xib to use a generated localizer. Kill off the menu_localizer in favor of a generated one. ui_localizer is a helper so each "localizer" is as small as possible. Build some menus out of base strings and the product name like windows. Added the dir generated for the localizers so we can load the header to directly create them (menubar one). Enable the other 3 languages we were building to help test. Made the context menu code use the new code for handling window's accelerators and ellipsis. Added unittest for ui_localizer. Opened http://crbug.com/17380 to track the problem with the menu titles so I can move on to other parts of the UI for now. TEST=The main menu will have some items localized now (and more will be localizable in the TC). BUG=16764 Review URL: http://codereview.chromium.org/155774 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21272 0039d316-1c4b-4281-b951-d872f2087c98
* When a web contents drag has a URL but no title, make up a title for it.estade@chromium.org2009-07-221-14/+30
| | | | | | | | | BUG=17393 TEST=drag nntp thumbnail to bookmark bar Review URL: http://codereview.chromium.org/155900 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21255 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another d&d crash that happens when the tab contentstc@google.com2009-07-212-5/+44
| | | | | | | | | | | | | | | | is swapped out while a drag is happening. Since the tab contents is swapped out, our RVH that the drag started on is no longer valid. Simply null out the pointer and no longer try to send feedback to the drag source. This allows the user to continue the drag even though the source RVH is gone. BUG=16073 Review URL: http://codereview.chromium.org/159040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21187 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: pass users' font settings through to renderer.agl@chromium.org2009-07-216-9/+64
| | | | | | | | | | | | The renderer doesn't give the settings to Skia yet -- that'll go in after agl's work on hinting and subpixel rendering in Skia. http://codereview.chromium.org/155787 (Patch by Dan Erat) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21182 0039d316-1c4b-4281-b951-d872f2087c98
* Enable DOM_STORAGE in our build. Put LocalStorage and SessionStorage behind ↵jorlow@chromium.org2009-07-211-0/+4
| | | | | | | | their own flags. Add the beginnings of StorageNamespaceProxy since it implements WebCore::StorageNamespace::____StorageNamespace and we'd get link errors otherwise.--enable-local-storage and --enable-session-storage are the new flags. If you enable them and try to use DOM Storage, Chromium will crash.Originally Committed in http://src.chromium.org/viewvc/chrome?view=rev&revision=21059 but then backed out due to include path issues.BUG=4360TEST=none Review URL: http://codereview.chromium.org/159059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21157 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 04:56:57 +0000