| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
TEST=|'localStorage' in window| should only be true iff --enable-local-storage is specified
Review URL: http://codereview.chromium.org/335034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TCV's size allocate message. This avoids a spurious size-allocate
being sent to the renderers when creating a new tab. The extra
size-allocate is called by the build-in GtkFixed's size allocate
method.
Another way to think of this is that we only size our RWH directly
and decouple it's sizing from the GTK+ widget's sizing.
BUG=26495
Review URL: http://codereview.chromium.org/363012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r30843.
This broke the findbar/download shelf animation optimization. I
originally was doing this as part of fixing issue 26495, but I
found a different way.
TBR=estade
Review URL: http://codereview.chromium.org/366009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
has focus.
BUG=26112
TEST=per bug.
Review URL: http://codereview.chromium.org/355016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the cache. We need to do this else we don't honor page expiration and
end up showing stale data for some sites.
BUG=21195
TEST=make sure session restore works.
Review URL: http://codereview.chromium.org/341043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
comment in the code mentions that a vbox would cause a split screen,
but looking at the code, it seems like that's not possible because
we hide the old TCVG before adding new ones. These days the vbox
contains all TCVGs and only shows one at a time (I think in the past
we tried to remove them, but we don't have that problem now).
This simplifies the code by not having to use our own size-allocate
handler.
Review URL: http://codereview.chromium.org/354018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=25354
Review URL: http://codereview.chromium.org/345037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
were eliding the text before passing it to the classifier, resulting in wrong destination URLs for elided strings.
This also eliminates a couple string conversions and shortens the EscapeAmpersand() algorithm.
BUG=1978
TEST=Highlight a long string in a page. Right-click it. Verify the string is elided in the context menu. Click the search entry. Verify the string you searched for is not elided.
Review URL: http://codereview.chromium.org/343081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ChromeThread instead.
BUG=25354
Review URL: http://codereview.chromium.org/342068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So when you select:
"http://www.google.com"
The context menu that will appear will be:
"Go to http://www.google.com"
Instead of:
"Search Google for http://www.google.com"
BUG=1978
TEST=open chromium, select a text that is a url, see if appears the menu "Go to..."; click on it,
see if it goes to the desired page.
Review URL: http://codereview.chromium.org/326026
Patch from tfarina.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/341062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So when you select:
"http://www.google.com"
The context menu that will appear will be:
"Go to http://www.google.com"
Instead of:
"Search Google for http://www.google.com"
BUG=1978
TEST=open chromium, select a text that is a url, see if appears the menu "Go to..."; click on it,
see if it goes to the desired page.
Review URL: http://codereview.chromium.org/326026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
code.
BUG=25318
TEST=none
Review URL: http://codereview.chromium.org/339093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/342072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
an options to navigate rather than searching. Original patch by Thiago Farina (see http://codereview.chromium.org/326026 ), r=me.
BUG=1978
TEST=Highlight "google.com" and right-click.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
it may not be what we think it is.
BUG=23157
TEST=context menus in the web content area, esp rapid right-click and dragging.
Review URL: http://codereview.chromium.org/344024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a similar fix to what eroman did previously.
We NULL render_widget_host_ when it's deleted, so we do not call it if it's been destroyed.
Added a bunch of check for render_widget_host_ before using it, as eroman changes triggered some crashers with some windows messages somehow happening after render_widget_host_ was NULLed.
Also added a NOTREACHED when the RenderWidgetHostViewWin OnFinalMessage is called and the destruction has not been initiated by the render view host, but it's gone, in an attempt to understand how this crasher can happen.
More info is available in the bug comments.
BUG=24248
TEST=Make sure opening/closing tab works as expected.
Test that selects (for example the language on under
http://www.google.com/advanced_search?hl=en can be open,
closed, selected.
Review URL: http://codereview.chromium.org/338054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
behind a switch, --enable-new-autofill. So far, we only pop up an infobar asking the user if he'd like to save the form information. I've added a rudimentary icon for the infobar, pulled from the mocks, so we'll probably want a blessed version of this icon at some point.
BUG=18201
TEST=none
Review URL: http://codereview.chromium.org/339030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24472
Review URL: http://codereview.chromium.org/337035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension_action.*.
Final bit of refactor will be to rename ExtensionAction2 to
ExtensionAction will be the next CL.
BUG=24472,25844
Review URL: http://codereview.chromium.org/332021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18120
TEST=Open google.com, type Ctrl+F, type in garbage. Erase one letter at a time and there should be no beeping while you erase. Try it again, but this time use shift-delete to cut a few letters off the end. It should not ding. Now Copy the whole find string, press Esc, open Find again and on Paste it should not ding.
Review URL: http://codereview.chromium.org/338005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab-specific state.
Future changelists will move Page Actions over to
ExtensionAction2, then replace ExtensionAction and
ExtensionActionState with ExtensionAction2.
Also, fix a bug in setIcon({path:...}) where it
would work only the first time.
BUG=24669,24472
Review URL: http://codereview.chromium.org/306044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
need to resolve with Glen/Nicholas how to handle the windows side.
BUG=25308
TEST=none
Review URL: http://codereview.chromium.org/314010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: nsylvain
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25330
TEST=Open sysprefs, keyboard, keyboard shortcuts, add a keyboard shortcut that makes cmd-right do "Select Next Tab". Hit cmd-right in chromium. Should switch tabs instead of doing history navigation (note "instead". If it does both tab switching _and_ history navigation, that's wrong). If a text box is focussed, cmd-right should however instead move the cursor and not switch tabs. Switching windows with cmd-` should still work. Switching tabs with cmd-1/2/3 and cmd-{/} should still work. Using backspace/shift-backspace for history should still work.
Review URL: http://codereview.chromium.org/325004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fixes conflicts between accelerator keys and HTML DOM accesskeys by suppressing Char events if corresponding RawKeyDown event was handled by the browser after returning from the renderer unhandled.
This CL not only fixes this conflict issue, but also makes the behavior of handling accelerator keys similar than IE, which also suppresses a key press event if the key down event was handled as an accelerator key.
BUG=21624 accesskey attributes conflict with browser shortcuts (like tab-switching)
TEST=Open http://djmitche.github.com/buildbot/docs/0.7.11/ in one of opened multiple tabs, switch to another tab by pressing an alt-# key binding, then switch back to the original page to see if it's just as you left it before switching tabs.
Review URL: http://codereview.chromium.org/235039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't record browser history for navigations for tabs in app frame.
BUG=18228
TEST=Open chrome in app frame (via "-app", application shortcut or convert a page to app), navigations in app frame should not appear in history.
Review URL: http://codereview.chromium.org/306052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22060
TEST=See bug.
Review URL: http://codereview.chromium.org/306019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
session/local storage.
BUG=none
TEST=|'localStorage' in window| should only be true iff enablelocalstorage
is specified
Review URL: http://codereview.chromium.org/293032
TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/315009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=|'localStorage' in window| should only be true iff --enable-local-storage
is specified
Review URL: http://codereview.chromium.org/293032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
purpose of the class.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/292050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
functions that are now public. Fix a few style errors. Make some functions shorter. Remove "using" directives since most of the file ignored them anyways. Remove unneeded #includes.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/292041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
RenderViewHostDelegate::FormFieldHistory to better reflect the purpose of the interface.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/294030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
data structure.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/306014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=yaar
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/305002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/308002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and remove experimentalWebSocketsEnabled from WebPreferences/Settings.
Patch for http://bugs.webkit.org/show_bug.cgi?id=29896 will remove Settings::experimentalWebSocketsEnabled(), so we need to remove it from WebPreferences too. This is because such configuration in Settings confuses other WebKit developers and such control is only required for chromium.
Instead add WebKit::enableWebSockets() in this change to
control WebSockets feature.
Review URL: http://codereview.chromium.org/292012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Focus background of google.com, hit "a". Shouldn't DCHECK.
Review URL: http://codereview.chromium.org/297017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in sysprefs.
Instead of just dispatching to the menu after a key comes back from the renderer, do a complete re-dispatch to NSApp (so that the event gets to the menu and cmd-` handlers) but then ignore it when it comes back to the web (because we already sent this event to the renderer once).
BUG=24817
TEST=Open sysprefs, change keyboard shortcut for "Move focus to next window in active application" to e.g. cmd-\. Open two chrome windows, focus the web, hit cmd-\. It should switch windows. All other keyboard shortcuts should still work (test that ctrl-tab works when web has focus, test backspace when text field is focussed in web, when background is focussed in web, when IME is active, test hitting cmd-1/2 when omnibox or web have focus, hit cmd-left when omnibox, textbox in web, background in web has focus, test that cmd-f in docs still opens doc's find interface)
Review URL: http://codereview.chromium.org/303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for words instead of wstring. I also changed some places where it converted the
word to a string to do that conversion at the last possible second before
giving it to Hunspell (since this conversion isn't needed for Mac).
TEST=Covered by unit tests
BUG=none
Review URL: http://codereview.chromium.org/274077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Linux does this in GtkIMContextWrapper::ProcessFilteredKeyPressEvent() by setting hardware_keycode to 0. It's a pain to change an NSEvent, so I just added a bool "skip" to NativeWebKeybordEvent and set it to "true" for rawkeydowns while ime is active.
BUG=25000
TEST=Open webpage. Focus text field. Type something, hit backspace. Text should be deleted. Focus background, hit backspace. Browser should go back one page. Focus text field, start IME (either by going to syspref->international->input menu and enabling e.g. "Kotoeri" and then selecting this in the top right corner and typing a single "a", or by just activating dead key ime on an us layout by hitting opt-u, opt-i, or opt-e), hit backspace. Browser should not go back but end IME mode.
Review URL: http://codereview.chromium.org/295003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Still no actual drawing code for badges, though.
BUG=24635
TEST=Load the sample test_page_action extension and click the page action to cycle through various states.
Review URL: http://codereview.chromium.org/269079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24471
TEST=none
Review URL: http://codereview.chromium.org/273046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Major changes:
- Moved sync_setup_{flow,wizard} to sync directory.
- Made browser_with_test_window_test compile on non-Windows platform.
- Moved localized contents font util functions to app/.
BUG=23073
TEST=trybot
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29255
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29258
Review URL: http://codereview.chromium.org/279004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: nick@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Major changes:
- Moved sync_setup_{flow,wizard} to sync directory.
- Made browser_with_test_window_test compile on non-Windows platform.
- Moved localized contents font util functions to app/.
BUG=23073
TEST=trybot
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29255
Review URL: http://codereview.chromium.org/279004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: nick@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Major changes:
- Moved sync_setup_{flow,wizard} to sync directory.
- Made browser_with_test_window_test compile on non-Windows platform.
- Moved localized contents font util functions to app/.
BUG=23073
TEST=trybot
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253
Review URL: http://codereview.chromium.org/279004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: nick@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Major changes:
- Moved sync_setup_{flow,wizard} to sync directory.
- Made browser_with_test_window_test compile on non-Windows platform.
- Moved localized contents font util functions to app/.
BUG=23073
TEST=trybot
Review URL: http://codereview.chromium.org/279004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29253 0039d316-1c4b-4281-b951-d872f2087c98
|