summaryrefslogtreecommitdiffstats
path: root/chrome/browser/tab_contents
Commit message (Collapse)AuthorAgeFilesLines
* When copying urls in the render view context menu, copy them to PRIMARY as ↵estade@chromium.org2009-05-294-12/+27
| | | | | | | | | | well as CLIPBOARD. BUG=12716 Review URL: http://codereview.chromium.org/115949 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17254 0039d316-1c4b-4281-b951-d872f2087c98
* Make automation proxy objects to ref_counted. That allows to process async ↵stoyan@chromium.org2009-05-281-2/+2
| | | | | | | | | | | notifications directly in channel background thread. Add support for listener-less ChannelProxy. BUG=none TEST=none Review URL: http://codereview.chromium.org/113722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17093 0039d316-1c4b-4281-b951-d872f2087c98
* Generalize the code that checks for user actions in the render view to work ↵estade@chromium.org2009-05-283-9/+4
| | | | | | | | | | | | on all platforms. Also, on linux, assume the user denies every download which we would have prompted him with. BUG=12709 TEST=windows is still carpet-bombing resilient and linux can download from the same page more than once. Review URL: http://codereview.chromium.org/113925 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17089 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the problem of the status bubble obscuring the download shelf.mirandac@chromium.org2009-05-272-0/+6
| | | | | | | | | | | | | BUG= http://crbug.com/6590 TEST=Cause the download shelf to appear by initiating a download. Hover over a link in the extreme lower left corner of the browser window. The status bubble should avoid your mouse by moving to the right, instead of moving down and obscuring the download shelf. Review URL: http://codereview.chromium.org/113671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17025 0039d316-1c4b-4281-b951-d872f2087c98
* Some ui tests would crash when the browser was closed.jcampan@chromium.org2009-05-271-6/+10
| | | | | | | | | | | | | The problem was related to an infobar (the default browser one) showing. When the tab is closed, InfoBarClosed is called on the infobar delegates, triggering a delete of the delegate. Then a notification that the tab is destroyed is sent, causing the tab contents to layout its infobars accessing the deleted delegates. BUG=12668 TEST=All UI tests should pass (especially the LoginPromptTest ones). Make IE your default browser, start Chrome. The default browser infobar should show. Close the tab. Review URL: http://codereview.chromium.org/113906 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17021 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add 'Enable Developer Tools' option into the Advanced tab. Hide ↵pfeldman@chromium.org2009-05-271-1/+2
| | | | | | | | developer tools by default. Review URL: http://codereview.chromium.org/117003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16984 0039d316-1c4b-4281-b951-d872f2087c98
* For "Copy link address" context menu, copy the URL with Unicode host namejungshik@google.com2009-05-271-27/+27
| | | | | | | | | | | | | | instead of Punycode host name. http://crbug.com/4008 TEST="Copy link address" copies Unicode host name for both of <a href="punycode URL"> and <a href="Unicode URL"> if Accept-Language preference is matched. Patch by tkent Original review: http://codereview.chromium.org/115752 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16973 0039d316-1c4b-4281-b951-d872f2087c98
* SetInitialFocus() when there's no view to restore to.shess@chromium.org2009-05-261-0/+6
| | | | | | | | | | | | http://crbug.com/12555 TEST=Browse to a page. Bring up a new tab (Command-t), should be able to start typing in autocomplete. http://crbug.com/12556 TEST=With a partial URL entered, switch tabs, and switch back. Should be able to type to replace autocomplete. This does not fix the entire bug. Review URL: http://codereview.chromium.org/115734 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16906 0039d316-1c4b-4281-b951-d872f2087c98
* Removes some dead code in TabContentsViewGtk and makes it compile forsky@chromium.org2009-05-263-39/+6
| | | | | | | | | | views. BUG=none TEST=none Review URL: http://codereview.chromium.org/113849 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16892 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 12468 where F3 (FindNext) in a brand new tab was not using ↵finnur@chromium.org2009-05-222-26/+42
| | | | | | | | | | | prepopulated search (what you have searched for in other tabs). TEST=Covered by in-process-browser test now. To test manually: open a tab, search for something in FindInPage, Press Ctrl+T and then F3. It should search for the same thing in the newly opened tab. BUG=12468 Review URL: http://codereview.chromium.org/115714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16786 0039d316-1c4b-4281-b951-d872f2087c98
* Use a NotificationRegistrar to listen for notifications.BUG=2381pkasting@chromium.org2009-05-222-8/+5
| | | | | | Review URL: http://codereview.chromium.org/113743 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16767 0039d316-1c4b-4281-b951-d872f2087c98
* Shows Unicode IDN instead of Punycode in the followings:brettw@google.com2009-05-221-5/+4
| | | | | | | | | | | | | | | | | | | - Bookmark Manager - Edit Bookmark dialog opened by Bookmark Manager - Edit Bookmark dialog opened by the star on the left of the address bar Introduces new function, net::FormatUrl(), which has the following parameters in addition to gfx::GetCleanStringFromUrl(). - bool omit_username_password - bool unescape and moves gfx::GetClienStringFromUrl() to net:: namespace, and removed the last two parameters. BUG=3991 Checked in for tkent Original review = http://codereview.chromium.org/115346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16761 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of dialog creation routines to browser_dialogs.h to break thebrettw@chromium.org2009-05-221-1/+2
| | | | | | | | | | | | | | dependency on the implementations of those views. This also moves that file into the browser:: namespace to avoid having all the functions in the global namespace. Rename the "parent" parameter to ShowHTMLDialog to a NativeWindow type to avoid nasty casting. I assume this argument was written before we had NativeWindow. Review URL: http://codereview.chromium.org/113728 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16743 0039d316-1c4b-4281-b951-d872f2087c98
* Move more misplaced tests.abarth@chromium.org2009-05-222-0/+1602
| | | | | | | | | TBR=creis TEST=No behavior change. Review URL: http://codereview.chromium.org/113755 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16727 0039d316-1c4b-4281-b951-d872f2087c98
* Move site_instance_unittest.cc next to site_instance.ccabarth@chromium.org2009-05-221-0/+400
| | | | | | | | | | TBR=creis TEST=No behavior change. Review URL: http://codereview.chromium.org/115691 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16721 0039d316-1c4b-4281-b951-d872f2087c98
* Find box regression: Doesn't move if obscuring. The problem is that we get ↵finnur@chromium.org2009-05-211-1/+5
| | | | | | | | | | | multiple messages from the renderer about the status of the find operation and some contain the selection rect (others don't). Therefore, we have to use the last known good selection rect if none is passed in. BUG=12463 TEST=Covered by in-process browser test now. Review URL: http://codereview.chromium.org/115667 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16683 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage in toolkit views build caused by lack of #ifdef OS_WINben@chromium.org2009-05-211-0/+5
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/113739 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16680 0039d316-1c4b-4281-b951-d872f2087c98
* Make views/ depend only on images from app/resources.ben@chromium.org2009-05-212-0/+2
| | | | | | | | | | Trying this again. All compile issues should be addressed, ui and unit tests now pass. http://crbug.com/11387 Review URL: http://codereview.chromium.org/113690 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16677 0039d316-1c4b-4281-b951-d872f2087c98
* Enable "View page info" context menu only for pages which developer commandsestade@chromium.org2009-05-211-3/+3
| | | | | | | | | | | | | | | | | | are meaningful for. "View page info" can be treated as if it were a developer command in deciding whether to enable it. For example, viewing page info of chrome://newtab doesn't make much sense. Tested manually. ------------- patch by yuzo@google.com review url: <http://codereview.chromium.org/115563> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16627 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 16567.ben@chromium.org2009-05-212-2/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16575 0039d316-1c4b-4281-b951-d872f2087c98
* views/ should use resources from app/resources. Move dependent images to ↵ben@chromium.org2009-05-212-0/+2
| | | | | | | | | this location. http://crbug.com/11387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16567 0039d316-1c4b-4281-b951-d872f2087c98
* Fix inspection of extensions.aa@chromium.org2009-05-194-10/+0
| | | | | | | | | | | | As a bonus, debugging of extensions now works. Go OOP inspector team! Inspection code was calling RVHD::GetProfile(), which was not implemented by ExtensionHost. Looking into this, it seems better to just remove the method from the interface since Profile is already accessible by way of RVH. The only caller to RVHD::GetProfile() besides the inspector was HWNDHtmlView which is itself dead code, so I removed it too. Review URL: http://codereview.chromium.org/115501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16392 0039d316-1c4b-4281-b951-d872f2087c98
* More NOTIMPLEMENTED() swatting.estade@chromium.org2009-05-181-2/+4
| | | | | | | | http://crbug.com/12052 Review URL: http://codereview.chromium.org/113544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16322 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix interstitials to work across tab changes.willchan@chromium.org2009-05-181-3/+8
| | | | | | | | | BUG=http://www.crbug.com/8486 TEST=Bring up two tabs. In one tab, navigate to https://ianfette.org. Switch to the next tab. Switch back to the first tab. It should still display the interstitial page. Try this both with the focus on the interstitial page before you switch to the second tab and with the focus on the omnibox before switching tabs, to make sure focus is set properly. Review URL: http://codereview.chromium.org/115446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16282 0039d316-1c4b-4281-b951-d872f2087c98
* Forward simplified mouse events to the RenderViewHostDelegate::View so that ↵erikkay@google.com2009-05-182-0/+16
| | | | | | | | it can implementsimple hover / tracking behavior.BUG=crbug.com/12067TEST=none (suggestions welcome) Review URL: http://codereview.chromium.org/113481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16279 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome-part of disabling web fonts by default while still alowing SVG fontsjshin@chromium.org2009-05-161-0/+2
| | | | | | | | | | | | | | | | | (The webkit part is http://codereview.chromium.org/67209/show and http://bugs.webkit.org/show_bug.cgi?id=25239 ) 1. Adds '--enable-remote-fonts' command line switch 2. Adds a field ('enable_remote_fonts) to WebPreference 3. Pass the value of enable_remote_fonts to the corresponding field in WebCore::Settings (m_downloadableBinaryFontsEnabled) BUG=9633 TEST: 1. Run Chrome with and without '--enable-remote-font' command line flag and go to http://www.alistapart.com/d/cssatten/heid.html. Without the flag, the page should be rendered with 'dull-looking ordinary' fonts. With the flag, the page should be rendered with 'decorative' remote fonts. 2. Even without the above flag, Chrome should should get 100/100, with no boxes in the upper right corner (still has the Linktest Failed error). Review URL: http://codereview.chromium.org/67210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16247 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Add download shelf first show animation.estade@chromium.org2009-05-152-10/+13
| | | | | | | | http://crbug.com/8631 Review URL: http://codereview.chromium.org/113428 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16196 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Take download shelf and infobar close animations into account during ↵estade@chromium.org2009-05-155-10/+70
| | | | | | | | | | render view sizing. http://crbug.com/11080 Review URL: http://codereview.chromium.org/113322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16193 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Make findbar restore focus to last focused widget on close.estade@chromium.org2009-05-152-30/+7
| | | | | | | | Factor out some common code to FocusStoreGtk so it can be shared by anyone who cares about remembering which widget last had focus. Currently used in FindBarGtk and TabContentsViewGtk. Review URL: http://codereview.chromium.org/115391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16189 0039d316-1c4b-4281-b951-d872f2087c98
* Displaying consecutive alerts from plugins should not hang the browser. The ↵ananta@chromium.org2009-05-154-0/+14
| | | | | | | | | | | | | | | | | | plugins display alerts via the NPN_Evaluate API. The browser signals an event handle to ensure that the plugin starts peeking for messages while waiting for the NPN_Evaluate call to return. When the dialog is dismissed by the user, windows does send some messages to the plugin window underneath, like activation messages, etc. These don't get dispatched as the event is reset when the dialog is dismissed, i.e. much before the window is actually destroyed. The fix is to reset the event handle after the window is actually destroyed. To achieve this I added an OnClose virtual function to the DialogDelegate interface, which is overridden by the JavascriptMessageBoxDialog class which eventually ensures that the event is reset. This fixes http://code.google.com/p/chromium/issues/detail?id=10799 I updated the AlertInWindowMessage npapi test to display two alerts instead of one. Bug=10799 Review URL: http://codereview.chromium.org/113464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16172 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeCanvas->gfx::Canvasben@chromium.org2009-05-151-2/+2
| | | | | | | | | | | Rename files too. TBR=brettw http://crbug.com/11387 Review URL: http://codereview.chromium.org/113443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16148 0039d316-1c4b-4281-b951-d872f2087c98
* Finish refactoring to make SSLPolicy and friends unit testable. Next stop: ↵abarth@chromium.org2009-05-151-1/+1
| | | | | | | | | | | tests! TBR=jcampan BUG=http://crbug.com/8782 Review URL: http://codereview.chromium.org/115389 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16145 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors menus so that I can create a MenuGtk implementation, and moves it intosky@chromium.org2009-05-142-13/+15
| | | | | | | | | | | | the namespace views. BUG=none TEST=make sure I haven't broken any menus. This impacts all menus in Chrome, except bookmark ones. Review URL: http://codereview.chromium.org/113410 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16100 0039d316-1c4b-4281-b951-d872f2087c98
* Remove even more ATL dependencies.maruel@chromium.org2009-05-141-1/+1
| | | | | | Review URL: http://codereview.chromium.org/115309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16088 0039d316-1c4b-4281-b951-d872f2087c98
* Save/restore the focused subview.avi@google.com2009-05-132-4/+20
| | | | | | | | http://crbug.com/9420 Review URL: http://codereview.chromium.org/100358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16013 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a comment referencing tab contents type switching.brettw@chromium.org2009-05-131-3/+1
| | | | | | Review URL: http://codereview.chromium.org/99047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16009 0039d316-1c4b-4281-b951-d872f2087c98
* Propagate intrinsic width notification over IPC in all cases (not just ↵pinkerton@chromium.org2009-05-136-1/+43
| | | | | | | | extensions) to the TabContentsView. Enable the zoom button on Mac to utilize it. Ensure we only send the IPC notification when the value changes, as WebCore tends to over-report that it has changed. Fix const-ness in delegate API where it's not necessary. Review URL: http://codereview.chromium.org/115138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15988 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 15965. I wasn't supposed to check that in since it still doesn't ↵maruel@chromium.org2009-05-131-1/+1
| | | | | | | | | compile on linux and mac! TBR=sky Review URL: http://codereview.chromium.org/113351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15967 0039d316-1c4b-4281-b951-d872f2087c98
* Remove even more ATL dependencies.maruel@chromium.org2009-05-131-1/+1
| | | | | | Review URL: http://codereview.chromium.org/115309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15965 0039d316-1c4b-4281-b951-d872f2087c98
* This is the successor to http://codereview.chromium.org/67150maruel@chromium.org2009-05-132-13/+21
| | | | | | | | | | | | | | | | | | | | | Make forward/backward navigation work even when redirection is involved. Currently, Chrome tries to go back to the page immediately before the current one. This doesn't work if the current page was visited by redirection; redirection just occurs again. With this change, Chrome first tries to find the redirection source of the current page and then to go back to the page before the source. BUG=9663,10531 Tested: unit_tests, ui_tests, manually. Patch contributed by Yuzo Fujishima <yuzo@google.com> Review: http://codereview.chromium.org/100245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15950 0039d316-1c4b-4281-b951-d872f2087c98
* This CL updates chrome to the latest version of skia, retrieved via DEPS, andsenorblanco@chromium.org2009-05-132-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | placed in third_party. All relevant skia changes (for all 3 platforms) have been upstreamed. Most of this CL is mind-numbingly repetitive. Things of interest are: skia.gyp (now points at third_party versions), DEPS, and SkUserConfig.h. stdint.h: Skia now requires C99 integer types, which MSVC doesn't support natively. I have put typedefs in config/win/stdint.h. Note that the new version of skia appears to render rects whose coordinates are "backwards" (ie., x2 < x1 or y2 < y1), which were formerly culled. There were a couple obvious instances of this in the code which I fixed, but there may be more. There were ~35 layout test failures due to minor pixel differences which I rebaselined on Windows and Linux, and 8 genuine failures related to masks and stroked text, which I have put in text_expectations.txt and assigned to myself. (There was another change which broke ~1700 tests on each platform, but I put that change behind an #ifdef for now). R=brettw Review URL: http://codereview.chromium.org/65012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15949 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix a couple focus issues:estade@chromium.org2009-05-121-5/+7
| | | | | | | | | | - Don't change focus in FindBarGtk::RestoreSavedFocus() unless the find bar has focus. - Hide widgets in SlideAnimatorGtk when they aren't showing so they can't get focus. - Add a check for null focus widget in TabContentsViewGtk::SaveFocus(). Review URL: http://codereview.chromium.org/115254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15910 0039d316-1c4b-4281-b951-d872f2087c98
* Remove two context menu entries that were never implemented!tc@google.com2009-05-121-17/+6
| | | | | | | | | | | Leave some stub code so someone can implement in the future. BUG=11827 Review URL: http://codereview.chromium.org/113289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15904 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Only show the original RWHV or the interstitial page at any ↵willchan@chromium.org2009-05-121-0/+6
| | | | | | | | | | time."" Fixed the SSL ui_tests which only failed on the buildbot by removing an unnecessary DCHECK. Review URL: http://codereview.chromium.org/113238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15875 0039d316-1c4b-4281-b951-d872f2087c98
* Be slightly more precise in how we propagate mixed content state.abarth@chromium.org2009-05-121-1/+1
| | | | | | | | | | | Mixed content can't really propagate from one process to another, so we don't need to break the lock icon for every tab in the same origin when we see insecure content. We need only break the lock icon for all the tabs in the same process. R=jcampan TEST=SSLUITest.TestMixedContentsTwoTabs Review URL: http://codereview.chromium.org/115230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15858 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Only show the original RWHV or the interstitial page at any time."willchan@chromium.org2009-05-111-6/+0
| | | | | | | | It broke ui_tests. Review URL: http://codereview.chromium.org/112017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15801 0039d316-1c4b-4281-b951-d872f2087c98
* Only show the original RWHV or the interstitial page at any time.willchan@chromium.org2009-05-111-0/+6
| | | | | | | | | | In Windows this doesn't matter, since the interstitial page just renders on top of the original RWHV. In Linux, the two RWHV widgets are in the same content view vbox, so we need to hide one of them so they both don't render on the screen. BUG=http://www.crbug.com/8486 Review URL: http://codereview.chromium.org/112014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15792 0039d316-1c4b-4281-b951-d872f2087c98
* Stop leaking RenderWidgetHostViewGtk.willchan@chromium.org2009-05-081-1/+0
| | | | | | | | | | | | | | | Don't bother calling gfx::RemoveAllChildren() in TabContentsViewGtk when creating a new RWHV, since any previously existing RWHV widget should already have been deleted. This also fixes interstitial pages crashing. Although instead we have two RWHV widgets in the same TabContentsView vbox :) I'll fix that in a later changelist. Also update the valgrind suppressions file. BUG=http://www.crbug.com/10747 BUG=http://www.crbug.com/8486 Review URL: http://codereview.chromium.org/115145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15695 0039d316-1c4b-4281-b951-d872f2087c98
* Move win_util.h from common to app.ben@chromium.org2009-05-081-1/+3
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15694 0039d316-1c4b-4281-b951-d872f2087c98
* Move color_utils, text_elider, drag_utils, accessibility_types, ↵ben@chromium.org2009-05-081-1/+1
| | | | | | | | | standard_layout to new locations in app/ and views/ http://crbug.com/11387 Review URL: http://codereview.chromium.org/113143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15687 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-17 06:32:02 +0000