summaryrefslogtreecommitdiffstats
path: root/chrome/browser/tabs/tab_strip_model.h
Commit message (Collapse)AuthorAgeFilesLines
* Moving notification types which are chrome specific to a new header file ↵ananta@chromium.org2011-07-101-1/+1
| | | | | | | | | | | | | chrome_notification_types.h. This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END which defines the end of the enum used by content to define notification types. The notificaton_type.h file in content\common has been renamed to content_notification_types.h BUG=76698 Review URL: http://codereview.chromium.org/7327007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
* Multi-tab: Adding new Notification when tab selection changes (again).dpapad@chromium.org2011-06-231-9/+16
| | | | | | | | | | | | | | | This is mostly a copy of http://codereview.chromium.org/7033048/ which was reverted. Only changes from 7033048 are 1) Fixing linux_touch trivial compile_error. 2) Adding <iterator> header in chrome/browser/ui/views/tabs/tab_strip.cc because Win Builder 2010 failed because of that. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7215003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90155 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 89752 - Multi-tab: Adding new Notification when tab selection changes.dpapad@chromium.org2011-06-201-16/+9
| | | | | | | | | | | | | | | | | | In this CL 1) TabStripModelObserver::ActiveTabChanged is only called when the active tab actually changes (where as before it was called to also signal tab selection changes). 2) TabStripModelObserver::TabSelectionChanged is called when the tab selection changes. 3) BaseTabStrip::SelectTabAt() is replaced by BaseTabStrip::SetSelection(). BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7033048 TBR=dpapad@chromium.org Review URL: http://codereview.chromium.org/7200044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89753 0039d316-1c4b-4281-b951-d872f2087c98
* Multi-tab: Adding new Notification when tab selection changes.dpapad@chromium.org2011-06-201-9/+16
| | | | | | | | | | | | | | | In this CL 1) TabStripModelObserver::ActiveTabChanged is only called when the active tab actually changes (where as before it was called to also signal tab selection changes). 2) TabStripModelObserver::TabSelectionChanged is called when the tab selection changes. 3) BaseTabStrip::SelectTabAt() is replaced by BaseTabStrip::SetSelection(). BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7033048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89752 0039d316-1c4b-4281-b951-d872f2087c98
* Multi-tab: Renaming TabStripModel::GetSelectedTabContents to ↵dpapad@chromium.org2011-06-091-3/+2
| | | | | | | | | | | | GetActiveTabContents BUG=There was a TODO comment for that. TEST=NONE Review URL: http://codereview.chromium.org/7134026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88471 0039d316-1c4b-4281-b951-d872f2087c98
* Multi-tab: Renaming NotifySelectionChanged to NotifyActiveTabChangeddpapad@chromium.org2011-05-311-3/+3
| | | | | | | | | | | | | | | | Reasons for renaming 1) The old name no longer reflects the cause of the notification. 2) A new NotifySelectionChanged method will be written (in http://codereview.chromium.org/6933037/) to notify observers which tabs were affected (either selected or deselcted) by a selection change. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6965019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87344 0039d316-1c4b-4281-b951-d872f2087c98
* The initial prototype code for the compact navigation (cnav) prototype, ↵stevet@chromium.org2011-05-111-0/+5
| | | | | | | | | | | | currently only active in windows. This is well hidden behind a flag and a context menu option. Loosely based off oshima's original prototype patch: http://codereview.chromium.org/165272 BUG=None TEST=Activate the cnav prototype in about:flags. Right click a tab and select "Hide Toolbar" to go into cnav mode. Ensure that the compact location bar provides the same basic functionality as the toolbar (except browser actions). Review URL: http://codereview.chromium.org/6913026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84971 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 84831 - The initial prototype code for the compact navigation (cnav) ↵bradnelson@google.com2011-05-101-5/+0
| | | | | | | | | | | | | | | prototype, currently only active in windows. This is well hidden behind a flag and a context menu option. Loosely based off oshima's original prototype patch: http://codereview.chromium.org/165272 BUG=None TEST=Activate the cnav prototype in about:flags. Right click a tab and select "Hide Toolbar" to go into cnav mode. Ensure that the compact location bar provides the same basic functionality as the toolbar (except browser actions). Review URL: http://codereview.chromium.org/6913026 TBR=stevet@chromium.org Review URL: http://codereview.chromium.org/7005004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84836 0039d316-1c4b-4281-b951-d872f2087c98
* The initial prototype code for the compact navigation (cnav) prototype, ↵stevet@chromium.org2011-05-101-0/+5
| | | | | | | | | | | | currently only active in windows. This is well hidden behind a flag and a context menu option. Loosely based off oshima's original prototype patch: http://codereview.chromium.org/165272 BUG=None TEST=Activate the cnav prototype in about:flags. Right click a tab and select "Hide Toolbar" to go into cnav mode. Ensure that the compact location bar provides the same basic functionality as the toolbar (except browser actions). Review URL: http://codereview.chromium.org/6913026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84831 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: fix bug where "aw snap" page replaces first tab if it was a NTP ↵kuan@chromium.org2011-04-261-1/+2
| | | | | | | | | | when closing window with > 1 tab. BUG=chromium-os:12088 TEST=verify bug per bug report. Review URL: http://codereview.chromium.org/6882058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83031 0039d316-1c4b-4281-b951-d872f2087c98
* More TabStripModel renaming:sky@chromium.org2011-04-181-10/+9
| | | | | | | | | | | | | | | | AddTabTypes::ADD_SELECTED -> ADD_ACTIVE SelectTabContentsAt -> ActivateTabAt BUG=none TEST=none R=ben@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/6840007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81947 0039d316-1c4b-4281-b951-d872f2087c98
* Renames TabStripModel and Browser's selected_index tosky@chromium.org2011-04-121-4/+2
| | | | | | | | | | | | | active_index. I plan on renaming more, but wanted to start with this one. BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6823064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81268 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of extensions dependency from content\browser.jam@chromium.org2011-04-041-2/+2
| | | | | | | BUG=76789 Review URL: http://codereview.chromium.org/6693054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80315 0039d316-1c4b-4281-b951-d872f2087c98
* Adds flag for selecting different sets of tabs in the tab strip.sky@chromium.org2011-03-231-3/+9
| | | | | | | | | | BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6725027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79216 0039d316-1c4b-4281-b951-d872f2087c98
* Makes control-shift clicks on the tabstrip work. In particularsky@chromium.org2011-03-211-0/+4
| | | | | | | | | | | | | control-shift makes sure the tabs from the anchor to the index the user clicked on are selected, but doesn't remove anything. BUG=30572 TEST=none, just make sure tab selection isn't broken. R=ben@chromium.org Review URL: http://codereview.chromium.org/6709011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78882 0039d316-1c4b-4281-b951-d872f2087c98
* Updates TabStripModel context menu commands to deal with multiplesky@chromium.org2011-03-171-5/+21
| | | | | | | | | | | | | selected tabs. A right click on an selected tab makes the action apply to all tabs. A right click on an unselected tab only applies to that tab. BUG=30572 TEST=covered by unit tests. Review URL: http://codereview.chromium.org/6673095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78604 0039d316-1c4b-4281-b951-d872f2087c98
* Move the remaining files in chrome\common to content\common.jam@chromium.org2011-03-171-1/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6672070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78516 0039d316-1c4b-4281-b951-d872f2087c98
* Further tweaks to TabStripModel::MoveSelectedTabsTo.sky@chromium.org2011-03-101-0/+12
| | | | | | | | | BUG=30572 TEST=none, just make sure tab selection isn't broke. Review URL: http://codereview.chromium.org/6646050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77669 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the notification stub files.tfarina@chromium.org2011-03-101-2/+2
| | | | | | | | | | | This is the last part of this series. BUG=None TEST=None Review URL: http://codereview.chromium.org/6658015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77581 0039d316-1c4b-4281-b951-d872f2087c98
* Creates TabStripSelectionModel and moves some functionality tosky@chromium.org2011-03-091-12/+40
| | | | | | | | | | | | it. Also adds MoveSelectedTabsTo which will be used when dragging around in the tab strip. BUG=30572 TEST=none, just make sure tab selection isn't broke. Review URL: http://codereview.chromium.org/6647011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77506 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of notification files.tfarina@chromium.org2011-03-091-3/+3
| | | | | | | | | | | Third part of the remaining files. BUG=None TEST=None Review URL: http://codereview.chromium.org/6650020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77458 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing crash in tab code. It appears that we end up in asky@chromium.org2011-01-191-0/+3
| | | | | | | | | | | | | | | situation where the opener ends up the same as the tab being closed. The only way I could see this happening is a new tab getting the same address as a tab that was deleted. This seems unlikely, but I've added the code to make sure we clean up properly when a tab is deleted. I'm also adding a couple more checks. BUG=34135 TEST=none Review URL: http://codereview.chromium.org/6346008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71800 0039d316-1c4b-4281-b951-d872f2087c98
* Makes instant run before unload listeners.sky@chromium.org2010-12-081-3/+5
| | | | | | | | | BUG=64694 TEST=none Review URL: http://codereview.chromium.org/5610005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68646 0039d316-1c4b-4281-b951-d872f2087c98
* views: Show accelerators in tabstrip context menu.sadrul@chromium.org2010-11-241-0/+4
| | | | | | | | | | | | | | As it happens, the command-id is a TabStripModel::ContextMenuCommand. So it needs to be converted into a browser command first, before the accelerator is looked up. BUG=None TEST=Right click on a tab. The context menu should have proper accelerators displayed (e.g. Ctrl+T for the 'New Tab' option). Review URL: http://codereview.chromium.org/5331005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67289 0039d316-1c4b-4281-b951-d872f2087c98
* Make pink's TabContentsWrapper change compile on Windows.ben@chromium.org2010-11-181-22/+34
| | | | | | | | | | Code by pinkerton@, with modifications by evanm and myself to get it to build on windows/linux/chromeos. BUG=none TEST=none Review URL: http://codereview.chromium.org/4694008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66626 0039d316-1c4b-4281-b951-d872f2087c98
* Address sky's post-commit comments for my phantom tab removal change.andybons@chromium.org2010-10-061-4/+0
| | | | | | | | | | | | | | o Consolidate ReplaceTabContentsAtImpl into ReplaceTabContentsAt since there is only one caller to the former. o Removal of a TODO. The original change is http://crrev.com/61303 BUG=none TEST=none Review URL: http://codereview.chromium.org/3543012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61670 0039d316-1c4b-4281-b951-d872f2087c98
* Rip out phantom tabs and corresponding unit tests.andybons@chromium.org2010-10-021-53/+6
| | | | | | | | | | | Also get rid of the type enum passed to TabReplacedAt since it can only be one option after phantom tabs are removed. BUG=none TEST=compile? good. pass tests? good. Review URL: http://codereview.chromium.org/3539010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61303 0039d316-1c4b-4281-b951-d872f2087c98
* Moves TabStripModelObserver/Delegate into their own headers.sky@chromium.org2010-09-161-253/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3425009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59733 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Header cleanup in chrome/common part 2. The majority of the changed filesjhawkins@chromium.org2010-08-201-0/+1
| | | | | | | | | | | just added notification_observer.h. BUG=none TEST=none Review URL: http://codereview.chromium.org/3120021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56824 0039d316-1c4b-4281-b951-d872f2087c98
* Clone of issue 2941001. See initial review below.twiz@google.com2010-08-121-0/+3
| | | | | | | | | | | | | | http://codereview.chromium.org/2941001 Initial submit broke the chromeos build. This patch includes the original change, and fixes to compile ChromeOs properly. BUG=None TEST=None Review URL: http://codereview.chromium.org/2819086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55951 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for showing the match preview on views. It's behind thesky@chromium.org2010-08-111-1/+36
| | | | | | | | | | | | flag --enable-match-preview. There is still a lot of details to get it working good enough, but this is a good point to check some stuff in. BUG=none TEST=none Review URL: http://codereview.chromium.org/3105004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55665 0039d316-1c4b-4281-b951-d872f2087c98
* Minor header cleanup of chrome/browser/[st]*/*.h minus c/b/sync/*.h.viettrungluu@chromium.org2010-08-061-1/+0
| | | | | | | | | | | | - Remove unnecessary forward decls. - Remove unnecessary inclusions of <set>, <map>, <vector>, <list>. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3023043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55222 0039d316-1c4b-4281-b951-d872f2087c98
* When dropping a tab torn from a maximized window, inherit the restored size ↵pkasting@chromium.org2010-08-021-7/+2
| | | | | | | | | | and maximized state, instead of creating a restored window at the maximized size. BUG=22154 TEST=Drag a tab from a maximized window and drop it; it should create a maximized window. Review URL: http://codereview.chromium.org/3032039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54607 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54560 - nick@chromium.org2010-08-021-3/+0
| | | | | | | | | | | | | | | | Change removing method, GetBrowser from TabContentsDelegate, as this was breaking an abstraction layer. This routine was originally added in CL 434046, which required the Browser* to construct extension popup views from within Chrome-Frame instances. I changed all accesses to Browser instances from usage of the above method, to either iterating the BrowserList using the situation-specific profile as a search key, or modifying the appropriate delegate interfaces to provide the functionality that was previously used directly via the Browser. BUG=None TEST=None Review URL: http://codereview.chromium.org/2941001 TBR=twiz@google.com Review URL: http://codereview.chromium.org/3012042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54565 0039d316-1c4b-4281-b951-d872f2087c98
* Change removing method, GetBrowser from TabContentsDelegate, as this was ↵twiz@google.com2010-08-021-0/+3
| | | | | | | | | | | | | breaking an abstraction layer. This routine was originally added in CL 434046, which required the Browser* to construct extension popup views from within Chrome-Frame instances. I changed all accesses to Browser instances from usage of the above method, to either iterating the BrowserList using the situation-specific profile as a search key, or modifying the appropriate delegate interfaces to provide the functionality that was previously used directly via the Browser. BUG=None TEST=None Review URL: http://codereview.chromium.org/2941001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54560 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors.ziadh@chromium.org2010-07-241-0/+6
| | | | | | | | | | Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. r=jar Review URL: http://codereview.chromium.org/2856051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53570 0039d316-1c4b-4281-b951-d872f2087c98
* Makes app tabs always pinned and unpinable.sky@chromium.org2010-07-231-1/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3020024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53492 0039d316-1c4b-4281-b951-d872f2087c98
* Attemp 2 at:sky@chromium.org2010-07-211-7/+0
| | | | | | | | | | | | | | | | Makes the toolbar visible for apps again. Here's the set of patches I reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for 45566) If you see anything missing, please let me know. Also, there are some grd strings no longer necessary. I'll nuke those separately. BUG=49013 TEST=none TBR=finnur Review URL: http://codereview.chromium.org/3056003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53204 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 53062 - Makes the toolbar visible for apps again. Here's the set of ↵pinkerton@chromium.org2010-07-201-0/+7
| | | | | | | | | | | | | | | | | | patches I reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for 45566. If you see anything missing, please let me know. Also, there are some grd strings no longer necessary. I'll nuke those separately. BUG=49013 TEST=none Review URL: http://codereview.chromium.org/2888020 TBR=sky@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53073 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the toolbar visible for apps again. Here's the set of patches Isky@chromium.org2010-07-201-7/+0
| | | | | | | | | | | | | | reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for 45566. If you see anything missing, please let me know. Also, there are some grd strings no longer necessary. I'll nuke those separately. BUG=49013 TEST=none Review URL: http://codereview.chromium.org/2888020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53062 0039d316-1c4b-4281-b951-d872f2087c98
* Move implementation from header to source.erg@chromium.org2010-07-151-16/+14
| | | | | | | | | | | | | | | | | | | | This is an effort to speed up compile and link time, and also minimizing the size of the intermediary .o files on disk. For example, just moving the constructor/destructor from the classes in chrome/browser/pref_member.{cc,h} netted a 368k drop in total .o file size. In aggregate, this shrinks libbrowser.a by 10 megabytes, and a few odd megabytes on most other chrome .a files. A lot of this was done before I started harvesting what the most included symbols were across all of chrome's code. Most of them are in webkit, but there's plenty in base/ that are used everywhere to keep me busy for several patches to come. BUG=none TEST=none Review URL: http://codereview.chromium.org/3012001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52528 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: except when signing off, disallow closing of last NTP of last ↵kuan@chromium.org2010-07-141-0/+13
| | | | | | | | | | | non-incognito normal browser, in which case, the window also cannot be closed. if the last normal browser is closeable and user closes it or the last tab in it, if it's a incognito browser, a new non-incognito browser will be opened, else the browser stays opened with all tabs closed and a NTP opened. before-unload-handlers are also taken care of. BUG=chromium-os:2711,chromium-os:3479,chromium-os:2568 TEST=verify per bug report. Review URL: http://codereview.chromium.org/2069002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52328 0039d316-1c4b-4281-b951-d872f2087c98
* Remove "Close tabs opened by this tab".pkasting@chromium.org2010-07-121-1/+0
| | | | | | | | BUG=none TEST=Right click a tab, "Close opened by" should not be in the context menu. Review URL: http://codereview.chromium.org/2903004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52143 0039d316-1c4b-4281-b951-d872f2087c98
* Makes all tabs openned from the omnibox inherit the opener of thesky@chromium.org2010-07-011-4/+6
| | | | | | | | | | | current tab. BUG=29933 TEST=see comment #9 in bug for test case. Review URL: http://codereview.chromium.org/2821026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51445 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Cleanups to the new wrench menu.erg@chromium.org2010-06-301-0/+4
| | | | | | | | | | | | | | | - Make the rendering for multiple buttons pretty by unifying sequnces of buttons. - Add the zoom label control and make the wrench menu model listen for notifications about zoom percentage changing. - Fixes crash that would have gone away once this was taken out from behind a flag BUG=45757 TEST=none Review URL: http://codereview.chromium.org/2799043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51266 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at Moving Browser::AddTypes to TabStripModel. The firstsky@chromium.org2010-06-281-22/+38
| | | | | | | | | | | | | | | | | | | | | | | | | attempt caused some flakiness on the new tab warm startup test. The only difference between this and the last is that I'm leaving some suspcious code in TabStripModel::InsertTabContents and Browser::AddTabWithURL. I'll try to isolate why those changes caused flakiness after I land the rest. Here's the description: Moves Browser::AddTypes to TabStripModel. This patch is primarily cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/2866024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50981 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50752 - Moves Browser::AddTypes to TabStripModel. This patch is primarilysky@chromium.org2010-06-241-38/+22
| | | | | | | | | | | | | | | | | | | | | | | | cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Nuked duplicate code in Browser::addTabWithURL that invoked wasHidden on the TabContents. This code is already in TabStripModel. . Moved code for setting visibility of tabcontents from TabStripModel::AddTabContents to InsertTabContentsAt. Since everything ends up in InsertTabContentsAt it should be there. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none Review URL: http://codereview.chromium.org/2863021 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/2849025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50776 0039d316-1c4b-4281-b951-d872f2087c98
* Moves Browser::AddTypes to TabStripModel. This patch is primarilysky@chromium.org2010-06-241-22/+38
| | | | | | | | | | | | | | | | | | | | | cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Nuked duplicate code in Browser::addTabWithURL that invoked wasHidden on the TabContents. This code is already in TabStripModel. . Moved code for setting visibility of tabcontents from TabStripModel::AddTabContents to InsertTabContentsAt. Since everything ends up in InsertTabContentsAt it should be there. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none Review URL: http://codereview.chromium.org/2863021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50752 0039d316-1c4b-4281-b951-d872f2087c98
* Add a context menu item to toggle app tab toolbars.aa@chromium.org2010-06-061-0/+7
| | | | | | Review URL: http://codereview.chromium.org/2690001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49016 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 06:42:20 +0000