summaryrefslogtreecommitdiffstats
path: root/chrome/browser/tabs/tab_strip_model_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Move more files from chrome/test to chrome/test/base, part #4phajdan.jr@chromium.org2011-08-011-1/+1
| | | | | | | BUG=90905 Review URL: http://codereview.chromium.org/7544021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94963 0039d316-1c4b-4281-b951-d872f2087c98
* some cleanup for base/stl_utildilmah@chromium.org2011-07-191-1/+1
| | | | | | | | | | | | | removed unused/irrelevant functions removed irrelevant comments Moved stl_util-inl.h => stl_util.h BUG=None TEST=None Review URL: http://codereview.chromium.org/7342047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
* Moving notification types which are chrome specific to a new header file ↵ananta@chromium.org2011-07-101-2/+2
| | | | | | | | | | | | | chrome_notification_types.h. This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END which defines the end of the enum used by content to define notification types. The notificaton_type.h file in content\common has been renamed to content_notification_types.h BUG=76698 Review URL: http://codereview.chromium.org/7327007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Split SystemMonitor initialization so it's not blocked by the Sandbox.jeremy@chromium.org2011-07-041-2/+7
| | | | | | | | | | | | | In OS X 10.7 Lion, the IO port we listen on to monitor system power events is blocked by the Sandbox. Move the allocation of the IO port so it happens early on during Chrome startup. BUG=83783 TEST=When putting a system to sleep with Chrome running, the browser shouldn't crash. Also, need to monitor crash logs to see that this crash goes away. Review URL: http://codereview.chromium.org/7235023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91462 0039d316-1c4b-4281-b951-d872f2087c98
* Multiprofile: Remove AllSources() usage on CONTENT_SETTINGS_CHANGED.erg@chromium.org2011-06-281-0/+7
| | | | | | | | | | BUG=87457 TEST=none Review URL: http://codereview.chromium.org/7277013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90852 0039d316-1c4b-4281-b951-d872f2087c98
* Multi-tab: Adding new Notification when tab selection changes (again).dpapad@chromium.org2011-06-231-12/+122
| | | | | | | | | | | | | | | This is mostly a copy of http://codereview.chromium.org/7033048/ which was reverted. Only changes from 7033048 are 1) Fixing linux_touch trivial compile_error. 2) Adding <iterator> header in chrome/browser/ui/views/tabs/tab_strip.cc because Win Builder 2010 failed because of that. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7215003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90155 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 89752 - Multi-tab: Adding new Notification when tab selection changes.dpapad@chromium.org2011-06-201-122/+12
| | | | | | | | | | | | | | | | | | In this CL 1) TabStripModelObserver::ActiveTabChanged is only called when the active tab actually changes (where as before it was called to also signal tab selection changes). 2) TabStripModelObserver::TabSelectionChanged is called when the tab selection changes. 3) BaseTabStrip::SelectTabAt() is replaced by BaseTabStrip::SetSelection(). BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7033048 TBR=dpapad@chromium.org Review URL: http://codereview.chromium.org/7200044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89753 0039d316-1c4b-4281-b951-d872f2087c98
* Multi-tab: Adding new Notification when tab selection changes.dpapad@chromium.org2011-06-201-12/+122
| | | | | | | | | | | | | | | In this CL 1) TabStripModelObserver::ActiveTabChanged is only called when the active tab actually changes (where as before it was called to also signal tab selection changes). 2) TabStripModelObserver::TabSelectionChanged is called when the tab selection changes. 3) BaseTabStrip::SelectTabAt() is replaced by BaseTabStrip::SetSelection(). BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7033048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89752 0039d316-1c4b-4281-b951-d872f2087c98
* Multi-tab: Renaming TabStripModel::GetSelectedTabContents to ↵dpapad@chromium.org2011-06-091-22/+22
| | | | | | | | | | | | GetActiveTabContents BUG=There was a TODO comment for that. TEST=NONE Review URL: http://codereview.chromium.org/7134026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88471 0039d316-1c4b-4281-b951-d872f2087c98
* Multi-tab selection: Renaming TabStripModelObserver::TabSelectedAt to ↵dpapad@chromium.org2011-05-241-5/+5
| | | | | | | | | | | | | ActiveTabChanged This is done in preparation for multi-tab selection in Linux (http://codereview.chromium.org/6933037/). There was a TODO for that in tab_strip_model_observer.h:75 BUG=NONE TEST=Tab behavior should be unaffected on all platforms Review URL: http://codereview.chromium.org/7043020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86502 0039d316-1c4b-4281-b951-d872f2087c98
* Move SystemMonitor to base/.willchan@chromium.org2011-05-181-3/+3
| | | | | | | | | | | | | | | I plan to use SystemMonitor in net/. Fix up the Mac implementation not to use Cocoa APIs since @interface is not allowed in base. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85732 Review URL: http://codereview.chromium.org/7015017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85737 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 85732 (broke build) - Move SystemMonitor to base/.willchan@chromium.org2011-05-181-3/+3
| | | | | | | | | | | | | | | | I plan to use SystemMonitor in net/. Fix up the Mac implementation not to use Cocoa APIs since @interface is not allowed in base. BUG=none TEST=none Review URL: http://codereview.chromium.org/7015017 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/7042003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85734 0039d316-1c4b-4281-b951-d872f2087c98
* Move SystemMonitor to base/.willchan@chromium.org2011-05-181-3/+3
| | | | | | | | | | | | | I plan to use SystemMonitor in net/. Fix up the Mac implementation not to use Cocoa APIs since @interface is not allowed in base. BUG=none TEST=none Review URL: http://codereview.chromium.org/7015017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85732 0039d316-1c4b-4281-b951-d872f2087c98
* The initial prototype code for the compact navigation (cnav) prototype, ↵stevet@chromium.org2011-05-111-0/+2
| | | | | | | | | | | | currently only active in windows. This is well hidden behind a flag and a context menu option. Loosely based off oshima's original prototype patch: http://codereview.chromium.org/165272 BUG=None TEST=Activate the cnav prototype in about:flags. Right click a tab and select "Hide Toolbar" to go into cnav mode. Ensure that the compact location bar provides the same basic functionality as the toolbar (except browser actions). Review URL: http://codereview.chromium.org/6913026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84971 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 84831 - The initial prototype code for the compact navigation (cnav) ↵bradnelson@google.com2011-05-101-2/+0
| | | | | | | | | | | | | | | prototype, currently only active in windows. This is well hidden behind a flag and a context menu option. Loosely based off oshima's original prototype patch: http://codereview.chromium.org/165272 BUG=None TEST=Activate the cnav prototype in about:flags. Right click a tab and select "Hide Toolbar" to go into cnav mode. Ensure that the compact location bar provides the same basic functionality as the toolbar (except browser actions). Review URL: http://codereview.chromium.org/6913026 TBR=stevet@chromium.org Review URL: http://codereview.chromium.org/7005004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84836 0039d316-1c4b-4281-b951-d872f2087c98
* The initial prototype code for the compact navigation (cnav) prototype, ↵stevet@chromium.org2011-05-101-0/+2
| | | | | | | | | | | | currently only active in windows. This is well hidden behind a flag and a context menu option. Loosely based off oshima's original prototype patch: http://codereview.chromium.org/165272 BUG=None TEST=Activate the cnav prototype in about:flags. Right click a tab and select "Hide Toolbar" to go into cnav mode. Ensure that the compact location bar provides the same basic functionality as the toolbar (except browser actions). Review URL: http://codereview.chromium.org/6913026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84831 0039d316-1c4b-4281-b951-d872f2087c98
* Move WebUI ntp files into new ntp directory.estade@chromium.org2011-04-281-1/+1
| | | | | | | | | | | And add myself to an ntp watchlist. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/6905067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83379 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 83062 - Move WebUI ntp files into new ntp directory.And add myself to ↵estade@chromium.org2011-04-261-1/+1
| | | | | | | | | an ntp watchlist.BUG=noneTEST=trybotsReview URL: http://codereview.chromium.org/6883154 TBR=estade@chromium.org Review URL: http://codereview.chromium.org/6903039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83063 0039d316-1c4b-4281-b951-d872f2087c98
* Move WebUI ntp files into new ntp directory.estade@chromium.org2011-04-261-1/+1
| | | | | | | | | | | And add myself to an ntp watchlist. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/6883154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83062 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: fix bug where "aw snap" page replaces first tab if it was a NTP ↵kuan@chromium.org2011-04-261-1/+5
| | | | | | | | | | when closing window with > 1 tab. BUG=chromium-os:12088 TEST=verify bug per bug report. Review URL: http://codereview.chromium.org/6882058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83031 0039d316-1c4b-4281-b951-d872f2087c98
* More TabStripModel renaming:sky@chromium.org2011-04-181-44/+44
| | | | | | | | | | | | | | | | AddTabTypes::ADD_SELECTED -> ADD_ACTIVE SelectTabContentsAt -> ActivateTabAt BUG=none TEST=none R=ben@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/6840007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81947 0039d316-1c4b-4281-b951-d872f2087c98
* Renames TabStripModel and Browser's selected_index tosky@chromium.org2011-04-121-41/+41
| | | | | | | | | | | | | active_index. I plan on renaming more, but wanted to start with this one. BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6823064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81268 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of extensions dependency from content\browser.jam@chromium.org2011-04-041-2/+3
| | | | | | | BUG=76789 Review URL: http://codereview.chromium.org/6693054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80315 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in tabstrip that resulted in not repainting when wesky@chromium.org2011-03-251-0/+28
| | | | | | | | | | | | | | should. This was the result of the tabstrip not notifying observers when the selection changed. For example, if tabs 1 and 2 were selected and 1 active, and 2 was removed observers weren't notified. BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6736011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79403 0039d316-1c4b-4281-b951-d872f2087c98
* Updates TabStripModel context menu commands to deal with multiplesky@chromium.org2011-03-171-13/+200
| | | | | | | | | | | | | selected tabs. A right click on an selected tab makes the action apply to all tabs. A right click on an unselected tab only applies to that tab. BUG=30572 TEST=covered by unit tests. Review URL: http://codereview.chromium.org/6673095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78604 0039d316-1c4b-4281-b951-d872f2087c98
* Move property bag to content.avi@chromium.org2011-03-101-1/+1
| | | | | | | | | BUG=none TEST=zero change Review URL: http://codereview.chromium.org/6660027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77686 0039d316-1c4b-4281-b951-d872f2087c98
* Further tweaks to TabStripModel::MoveSelectedTabsTo.sky@chromium.org2011-03-101-2/+4
| | | | | | | | | BUG=30572 TEST=none, just make sure tab selection isn't broke. Review URL: http://codereview.chromium.org/6646050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77669 0039d316-1c4b-4281-b951-d872f2087c98
* Creates TabStripSelectionModel and moves some functionality tosky@chromium.org2011-03-091-0/+86
| | | | | | | | | | | | it. Also adds MoveSelectedTabsTo which will be used when dragging around in the tab strip. BUG=30572 TEST=none, just make sure tab selection isn't broke. Review URL: http://codereview.chromium.org/6647011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77506 0039d316-1c4b-4281-b951-d872f2087c98
* Move notification service code to content. We'll need to figure out how to ↵jam@chromium.org2011-03-071-4/+4
| | | | | | | | | split the type enum so that chrome specific parts aren't in content later. TBR=avi Review URL: http://codereview.chromium.org/6627043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77102 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI: Move more files from chrome/browser/webui to chrome/browser/ui/webui.tfarina@chromium.org2011-02-271-1/+1
| | | | | | | | | | | | I'm moving the files I have found with: $ ls chrome/browser/webui | grep _ui BUG=59946 TEST=trybots Review URL: http://codereview.chromium.org/6599024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76183 0039d316-1c4b-4281-b951-d872f2087c98
* Move files out of chrome\browser\renderer_host\test alongside their source. ↵jam@chromium.org2011-02-241-4/+4
| | | | | | | | Most of them went to content\browser\renderer_host. Review URL: http://codereview.chromium.org/6575009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75824 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI: Move chrome/browser/dom_ui/ to chrome/browser/webui/.tfarina@chromium.org2011-02-221-2/+2
| | | | | | | | | | | | | To reduce the size of this change I've left stub header files in chrome/browser/dom_ui/. I'll updated the references and delete the stub files later. BUG=59945, 59946 TEST=trybots Review URL: http://codereview.chromium.org/6538075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75660 0039d316-1c4b-4281-b951-d872f2087c98
* Move SystemMonitor to src/ui/base/system_monitor. Move HiResTimerManager to ↵ben@chromium.org2011-01-191-3/+3
| | | | | | | | | | | | | src/chrome/common. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6361002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71797 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71487 - Move SystemMonitor to src/ui/base/system_monitor.ben@chromium.org2011-01-141-3/+3
| | | | | | | | | | | | | | Move HiResTimerManager to src/chrome/common. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6361002 TBR=ben@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71489 0039d316-1c4b-4281-b951-d872f2087c98
* Move SystemMonitor to src/ui/base/system_monitor.ben@chromium.org2011-01-141-3/+3
| | | | | | | | | | | | Move HiResTimerManager to src/chrome/common. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6361002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71487 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of pref_names.hthestig@chromium.org2011-01-131-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6122006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71283 0039d316-1c4b-4281-b951-d872f2087c98
* Changes instant so that the newly created tab has a new id. Doingsky@chromium.org2011-01-111-2/+4
| | | | | | | | | | | | otherwise causes subtle problems with extensions and breaks the invariant that the tab id is unique. BUG=68508 TEST=none Review URL: http://codereview.chromium.org/6155003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71063 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of notification_service.h, part 2.thestig@chromium.org2010-12-171-3/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5928003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69576 0039d316-1c4b-4281-b951-d872f2087c98
* Makes instant run before unload listeners.sky@chromium.org2010-12-081-2/+2
| | | | | | | | | BUG=64694 TEST=none Review URL: http://codereview.chromium.org/5610005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68646 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-021-2/+2
| | | | | | | | | | | | | | | file_path_watcher into subdir profile* into profiles/ subdir login* into ui/login visitedlink* into subdir BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5606002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-021-1/+1
| | | | | | | | | | | | | | | | | | | | tab_menu_model->ui/tabs tab_contents_wrapper->ui/tab_contents view_ids.h->ui status_bubble.h->ui options*->ui/options show_options_url*->ui/options location_bar*->ui/omnibox input_window*->ui browser_uitests->ui/tests BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5582002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68047 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix: Remove one last browser.h that slipped in.jhawkins@chromium.org2010-11-181-1/+1
| | | | | | | | | | TBR=thestig BUG=none TEST=none Review URL: http://codereview.chromium.org/5201003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66671 0039d316-1c4b-4281-b951-d872f2087c98
* Make pink's TabContentsWrapper change compile on Windows.ben@chromium.org2010-11-181-158/+171
| | | | | | | | | | Code by pinkerton@, with modifications by evanm and myself to get it to build on windows/linux/chromeos. BUG=none TEST=none Review URL: http://codereview.chromium.org/4694008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66626 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in TabStripModel. If during close all a tab wassky@chromium.org2010-11-111-0/+47
| | | | | | | | | | | | | removed out from under the TabStripModel it would still attempt to remove the tab. At least this is my best guess as to what is causing the crash. BUG=34135 TEST=none Review URL: http://codereview.chromium.org/4687009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65872 0039d316-1c4b-4281-b951-d872f2087c98
* Add pinned property to tabs.update and create.jstritar@chromium.org2010-11-081-3/+9
| | | | | | | | | | | Fire tabs.onUpdated event if a tab's pinned state changes. BUG=24781 TEST=ExtensionApiTest Review URL: http://codereview.chromium.org/3816005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65379 0039d316-1c4b-4281-b951-d872f2087c98
* Unrevert r64676 "Part 4/4 of immutable Extension refactor: Kill ↵mpcomplete@chromium.org2010-11-021-1/+1
| | | | | | | | | | | | | | | | | Extension::StaticData and put" Original CL: Part 4/4 of immutable Extension refactor: Kill Extension::StaticData and put its guts into Extension. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4200005 Review URL: http://codereview.chromium.org/4277002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64767 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r64676 "Part 4/4 of immutable Extension refactor: Kill ↵mpcomplete@chromium.org2010-11-021-1/+1
| | | | | | | | | | | | | | | | | | | Extension::StaticData and put" Original CL: Part 4/4 of immutable Extension refactor: Kill Extension::StaticData and put its guts into Extension. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4200005 TBR=nirnimesh Review URL: http://codereview.chromium.org/4274001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64692 0039d316-1c4b-4281-b951-d872f2087c98
* Part 4/4 of immutable Extension refactor: Kill Extension::StaticData and putmpcomplete@chromium.org2010-11-011-1/+1
| | | | | | | | | | | its guts into Extension. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4200005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64676 0039d316-1c4b-4281-b951-d872f2087c98
* Unrevert again r63919: "Part 2 of immutable Extension refactor."mpcomplete@chromium.org2010-10-271-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | (Last landing broke chromeos and chromium linux builder.) I made Extension a refcounted object, and privitized the existing con/destructor and InitFromValue. The only way to get an Extension is to call a factory method. In the next CL, I plan to make the factory method return a const Extension, to guarantee that no one can modify the Extension object after creation. Note: There was a tricky part of this CL because of the difference in semantics between scoped_ptr and scoped_refptr. I had to be careful not to use ptr.release(), since that would result in leaks (an un-Released AddRef). BUG=56558 TEST=no functional change Original Review URL: http://codereview.chromium.org/3982001 TBR=aa Review URL: http://codereview.chromium.org/4119010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64139 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-28 05:24:44 +0000