summaryrefslogtreecommitdiffstats
path: root/chrome/browser/tabs
Commit message (Collapse)AuthorAgeFilesLines
* Extension tweaks for phantom tabs. I did the following modifications:sky@chromium.org2010-01-231-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | . Modified chrome.tabs.executeScript so that it sends error message if failure in sending message (which happens with phantom tabs). . When a tab is made phantom we send TabInsertedAt event. . Made connecting to a phantom tab send disconnect. . Disallow changing the url of pinned tabs. . Disallow closing phantom tabs. . Detect language fails for phantom tabs. And I removed the flag for phantom tabs. BUG=25309 TEST=on windows or chromeos create a window with a couple of tabs, pin the first, then close it. Selection should change to another tab and the favicon of the closed tab should remain, but not the tab border. control-tab should not select the phantom tab, but if you click on the phantom tab it should become live again and the border should reappear. Review URL: http://codereview.chromium.org/552110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36964 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for phantom tabs. A pinned tab becomes a phantom tab whensky@chromium.org2010-01-224-53/+195
| | | | | | | | | | | | | | | | | it is closed, and effectively unloads the renderer and replaces it with a new TabContents that loads when selected. A phantom tab is currently rendered without a border. Phantom tabs do not prevent a window from closing. Long term only pinned app tabs will have the ability to be made phantom, but this allows us to test the feature until app support is all wired in. BUG=32845 TEST=none yet Review URL: http://codereview.chromium.org/553008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36815 0039d316-1c4b-4281-b951-d872f2087c98
* Tab-modal dialog improvements:zelidrag@google.com2010-01-152-1/+30
| | | | | | | | | | | | | | | | - treat constrained dialogs as tab-modal - only one shows at the time - added visual indication (tab pulsing) to the tab strip when a tab is blocked by a tab-modal dialog - blocked all UI activity from rendrer host and forced refocusing on constrained (tab-modal) dialogs This CL reverts http://codereview.chromium.org/384113 and instead incorporates the changes from http://codereview.chromium.org/392018. BUG=456,27585,27620 TEST=Go to http://www/~thakis/cgi-bin/test.html, hit esc. Review URL: http://codereview.chromium.org/541056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36415 0039d316-1c4b-4281-b951-d872f2087c98
* Removes debugging code that proved unnecessary.sky@chromium.org2010-01-152-45/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/552005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36355 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash with application mode windows and extensions tab API.asargent@chromium.org2010-01-121-2/+3
| | | | | | | | | | | | | From an application mode window, if you call chrome.tabs.create and specify a index for the new tab (and had no other windows open), chrome will crash. BUG=29810 TEST=Crash should no longer happen when following steps in the bug report. Review URL: http://codereview.chromium.org/542018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36019 0039d316-1c4b-4281-b951-d872f2087c98
* Forbid reloading the Inspector window.apavlov@chromium.org2009-12-251-1/+7
| | | | | | | | | | | This CL disables reloading from the system menu, tab popup menu, and page context menu. BUG=27254,6902 TEST=none Review URL: http://codereview.chromium.org/391036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35275 0039d316-1c4b-4281-b951-d872f2087c98
* Make View Source and Search Web For inherit group properly. Original patch ↵pkasting@chromium.org2009-12-212-8/+16
| | | | | | | | | by John Spiegel (see http://codereview.chromium.org/466086 ), r=me. BUG=1922 TEST="View Page Source" in context menu should open to the immediate right of the current tab. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35101 0039d316-1c4b-4281-b951-d872f2087c98
* Make SystemMonitor not a Singleton and move it out of basephajdan.jr@chromium.org2009-11-261-0/+5
| | | | | | | | | | | | | SystemMonitor makes an assumption that through its lifetime a MessageLoop exists and stays the same. It is difficult and error-prone to satisfy that when it is a Singleton. It has caused problems in the past. Additionally, extract HighResoltionTimerManager out of time_win.cc, eliminating yet another Singleton. TEST=none BUG=none Review URL: http://codereview.chromium.org/431008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33214 0039d316-1c4b-4281-b951-d872f2087c98
* Use plain strings instead of wstrings for UMA actionsevan@chromium.org2009-11-171-10/+10
| | | | | | | | | | | | git grep 'RecordAction(L' | xargs sed -i -e s/RecordAction(L/RecordAction(/ This cuts more than 10k off my binary. Which is nothing compared to the size of the binary, but that's a whole lot of zero bytes! This is less code this way anyway. Review URL: http://codereview.chromium.org/399026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32194 0039d316-1c4b-4281-b951-d872f2087c98
* Fix jumping/resize/relayout of NTP/webpages when switching between NTP and ↵simonrad@chromium.org2009-11-111-4/+6
| | | | | | | | | | | | | | | | | | another tab. (This really fixes 3 issues) 1. When the bookmarks bar is not docked, it toggles on and off when switching between the NTP and another tab. Since it is part of the UI, this causes the TabContents to be resized. This causes ugly re-layout of some webpages and also causes the NTP to jump when you switch to it, if themed. The solution is to toggle the floating bookmarks bar at a time when no TabContents is attached - that is, after detaching the first one but before attaching the second one. 2. Changing the info-bar can also cause a resize, so we also want to do this when no TabContents is attached. 3. Finally, when the NTP is displayed and another, floating tab is dragged and inserted to the left of the NTP, the selected tab index will not be set correctly. As a result, the NTP will be resized incorrectly before the tabs are even switched. R=beng BUG=23925 TEST=1. Apply Ratchet and Clank theme. Open NTP and Google Calendar in tabs. Switch back and forth between them. The NTP background should not jump or flicker, and Calendar should not re-layout. 2. Try switching between the NTP (or Calendar) and a tab that has an info-bar. 3. Open NTP and another tab. Drag the other tab until it detaches from the windows and floats. Re-attach and detach the tab repeatedly, so that the window switches between displaying the two tabs, and make sure you insert the other tab to the *left* of the NTP. The NTP should never jump. Review URL: http://codereview.chromium.org/376018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31687 0039d316-1c4b-4281-b951-d872f2087c98
* Adds more debugging code in hopes of figuring out why on dragging thesky@chromium.org2009-11-092-1/+57
| | | | | | | | | | | | tab strip model is empty, but not the tab strip. The latest crash data indicates the tab strip is not closing all. BUG=24132 TEST=none Review URL: http://codereview.chromium.org/375017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31450 0039d316-1c4b-4281-b951-d872f2087c98
* Makes inactive pinned tabs on linux throb when the title changes. Isky@chromium.org2009-10-233-16/+23
| | | | | | | | | | | need to resolve with Glen/Nicholas how to handle the windows side. BUG=25308 TEST=none Review URL: http://codereview.chromium.org/314010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29903 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an erroneous set of tab change notifications sent whenever closing a tab ↵pkasting@chromium.org2009-10-161-3/+3
| | | | | | | | | | before the current one. GetSelectedTabContents() was using the old |selected_index_|, which was no longer the selected tab, leading to bogus notifications, which in turn caused other problems. BUG=16753 TEST=Open Chrome. Hit ctrl-t twice. Type a few letters. Middle click the tab to the left of the current tab (the first "New Tab" you opened). Your typing should not disappear. Review URL: http://codereview.chromium.org/276052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29233 0039d316-1c4b-4281-b951-d872f2087c98
* Add histogram for how tab closing time. Did some cleanup along the way. ↵jam@chromium.org2009-10-141-9/+8
| | | | | | | | Moved the is_showing_before_unload_dialog_ stuff from RenderViewHost to TabContents since we need that bit there as well. Review URL: http://codereview.chromium.org/274057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29063 0039d316-1c4b-4281-b951-d872f2087c98
* More style nits.erg@google.com2009-10-141-2/+2
| | | | | | | | (Working on cleaning chrome/ so hopefully we can lint it by default.) Review URL: http://codereview.chromium.org/274040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28971 0039d316-1c4b-4281-b951-d872f2087c98
* Header dependency cleanup in chrome/phajdan.jr@chromium.org2009-10-121-0/+1
| | | | | | | | | | | | - reduce header dependencies - remove things that shouldn't be #included in a header, like string_util.h and theme_resources.h! TEST=none BUG=none Review URL: http://codereview.chromium.org/245011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28705 0039d316-1c4b-4281-b951-d872f2087c98
* * Add ctrl-shift-d to bookmark all tabs.pkasting@chromium.org2009-10-083-4/+6
| | | | | | | | | | | * Enable or disable bookmark commands based on whether we're actually going to be able to bookmark anything. * Rename IDC_STAR to IDC_BOOKMARK_PAGE, which is more obvious. BUG=2935 TEST=Hit ctrl-shift-d, make sure it bookmarks all tabs Review URL: http://codereview.chromium.org/266029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28480 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to create a bookmark folder populated with a bookmarksky@chromium.org2009-10-083-0/+19
| | | | | | | | | | | | | | | for each open tab. I've currently wired this up on windows, will wire up rest of platforms in a separate cl. BUG=2935 TEST=on Windows open multiple tabs, right click on a tab and choose 'Bookmark all tabs'. You should then get the bookmark editor with no url field. Accepting the dialog should result in creating a new folder with a bookmark for each of the open tabs. Review URL: http://codereview.chromium.org/270021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28446 0039d316-1c4b-4281-b951-d872f2087c98
* Any time we are shutting down a tab, try to use fast shutdown.estade@chromium.org2009-10-023-48/+160
| | | | | | | | | BUG=http://crbug.com/5638 TEST=existing tab strip model tests, Fast shutdown ui tests, new tab strip model fast shutdown test Review URL: http://codereview.chromium.org/235050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27865 0039d316-1c4b-4281-b951-d872f2087c98
* Fix deadlock when plugin puts an alert and right afterwards the browser ↵jam@chromium.org2009-09-281-2/+2
| | | | | | | | | | process makes a win32 call that ends up waiting on the plugin. Since the plugin thread is blocked, the Windows message doesn't get dispatched and the browser ui thread deadlocks. The message from the renderer would make the plugin run a nested message loop but it doesn't get run on the browser ui thread since it's blocked. The fix is to set the event that runs nested message loop in the renderer process. BUG=23147 TEST=ui tests already cover nested message loops and plugins. This particular scenario is hard to write a test case for because it's a race condition involving the browser. Review URL: http://codereview.chromium.org/243018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27421 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the initial size of TabContentViews to be based on thetony@chromium.org2009-09-251-2/+2
| | | | | | | | | | | | | | | | size of another TabContents by having an optional TabContents* passed into the TabContents ctor. This fixes a race condition where it's possible for a web page to load before getting the sizing information from the browser. The new flow passes the size information to the renderer process before passing the URL to load. BUG=20159 Review URL: http://codereview.chromium.org/201130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27199 0039d316-1c4b-4281-b951-d872f2087c98
* Add keyboard shortcuts to reorder tabs left or right on Linux.tony@chromium.org2009-09-142-0/+14
| | | | | | | | | | | | | | | It's standard in GTK+ for tabbed interfaces to be reorderable using ctrl+shift+pgup and ctrl+shift+pgdn (e.g., in Terminal). The plumbing is included on all platforms, but the shortcut is only hooked up on Linux. BUG=21594 Review URL: http://codereview.chromium.org/194088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26125 0039d316-1c4b-4281-b951-d872f2087c98
* Fix my change to flashing tabcpu@chromium.org2009-09-101-2/+1
| | | | | | | | | | | | | - I commited the last experiment, not what I meant to commit, sorry. TBR=darin BUG=21481 TEST=see bug Review URL: http://codereview.chromium.org/193076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25911 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for the flashing of the front tab.cpu@chromium.org2009-09-091-1/+7
| | | | | | | | | | | | | | | - The background tabs think they are visible causing paints to be executed. These steal the backing store from the visible tab Please read the bug for more info. BUG=20831 TEST= see bug for steps Review URL: http://codereview.chromium.org/199010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25739 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-281-16/+10
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-281-10/+16
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up lines longer than 80 chars under src/chrome/browser. mark@chromium.org2009-08-171-4/+6
| | | | | | | | | | | | | | | | | | | Command: awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' *.cc *.h # recursive find . -type f \( -name '*.cc' -o -name '*.h' \) -exec awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' {} \; Patch by Pierre-Antoine LaFayette <pierre.lafayette@gmail.com> BUG=None TEST=None Code review URL: http://codereview.chromium.org/164566 Review URL: http://codereview.chromium.org/171066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23583 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r23358 with a fix for linux unit_tests:tony@chromium.org2009-08-131-0/+14
| | | | | | | | | | | | | | | | | | Better location for setting the size of tab contents. This should catch all code paths. I noticed that middle clicking a bookmark wasn't working, so I found a single place to do this. This code is always run when a tab is added and it sizes the contents when it's loading in the background. BUG=619 TBR=japhet Review URL: http://codereview.chromium.org/164526 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23384 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Better location for setting the size of tab contents. This should"tony@chromium.org2009-08-131-14/+0
| | | | | | | | | | | This reverts commit r23358. TBR=japhet Review URL: http://codereview.chromium.org/165489 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23365 0039d316-1c4b-4281-b951-d872f2087c98
* Better location for setting the size of tab contents. This shouldtony@chromium.org2009-08-131-0/+14
| | | | | | | | | | | | | | | catch all code paths. I noticed that middle clicking a bookmark wasn't working, so I found a single place to do this. This code is always run when a tab is added and it sizes the contents when it's loading in the background. BUG=619 Review URL: http://codereview.chromium.org/165473 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23358 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up restoring pinned tabs for session and tab restoresky@chromium.org2009-07-142-14/+0
| | | | | | | | | | | services. And turns on pinned tabs by default on linux. BUG=16634 TEST=Currently this linux only. Try tab pinning and make sure it works. Review URL: http://codereview.chromium.org/149621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20650 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes the 3 arg TabMoved variant in favor of the 4 arg variant.sky@chromium.org2009-07-131-9/+1
| | | | | | | | | BUG=16634 TEST=none Review URL: http://codereview.chromium.org/155441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20581 0039d316-1c4b-4281-b951-d872f2087c98
* Adds tab pinning to TabStripModel. This is just the model side ofsky@chromium.org2009-07-084-42/+429
| | | | | | | | | | | | | | | | | | | things (and tests), no UI yet. The model enforces that all pinned tabs occur at the beginning of the model. For example, if there are no pinned tabs and you pin the 10th tab, it is moved to the front of the tab strip. Similarly inserting a tab before the last pinned tab implicitly pins it. Moving a pinned tab beyond the set of pinned tabs implicitly unpins it. I'll file a bug on this when the site allows me to. BUG=none TEST=none Review URL: http://codereview.chromium.org/155228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20181 0039d316-1c4b-4281-b951-d872f2087c98
* Basics of a new TabStrip.It's very, very rough, but I wanted to check it in ↵ben@chromium.org2009-07-072-0/+14
| | | | | | | | so I don't have to keep typing svn pset as I pass patches back and forth between machines.Behind a command line flag --enable-tabtastic2.I'm trying to split the TabContents specific stuff off of the TabStrip so it's more generic (and more easily mocked for unit testing of various layout conditions). Hence TabStrip vs. BrowserTabStrip. TabStrip may move into views/ once this process is complete.Animator is a utility that can be associated with a View that (at this point) animates that View's bounds from wherever it is now to somewhere else. The TabStrip uses this to do animations for individual Tabs that are independent of each other - a limitation of the old TabStrip is that only one animation is ever active at a time so its animations are a little jumpy compared to other products.Also, detached tab dragging shows the live contents, with all animations/video/etc.Like I said, this is really rough, but I didn't want it to grow any bigger. I will write up a design doc later.http://crbug.com/9032TEST=TBD... will finally be doing some for TabStrip layout! Review URL: http://codereview.chromium.org/42490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20053 0039d316-1c4b-4281-b951-d872f2087c98
* Do some refactoring of renderer_host.brettw@chromium.org2009-07-061-1/+1
| | | | | | | | | | | | | | | | | | | This removes the last dependency on tab_contents from the renderer_host code and into the RenderViewHostDelegate. Some of the tests depended on tab_contents, so I moved to a new directory with the tab_contents include allowed via DEPS. Now DEPS can enforce that no additional tab_contents includes are added to renderer_host. RenderViewHost delegate is now pure virtual. After spending a while *again* figuring out why my code didn't work, only to find it was because the default implementation of a function was getting called instead of the real one, I decided to make this pure virtual. It is implemented by TabContents, which implements basically everything, and two other places that implement less. Only two lists of duplicate functions seems not too bad, although long-term it would be nice if this delegate was somehow more succinct. Review URL: http://codereview.chromium.org/155071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19982 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure tabs open on the left like normal.brettw@chromium.org2009-07-011-4/+0
| | | | | | Review URL: http://codereview.chromium.org/151117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19733 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the default tab opening behavior. Fix some linux build issues by ↵brettw@chromium.org2009-06-151-0/+5
| | | | | | | | adding missing includes. Review URL: http://codereview.chromium.org/125145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18444 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the titlebar code into its own class because it's getting bigtc@google.com2009-06-121-1/+0
| | | | | | | | | | | | | | | and cluttering up browser_window_gtk. Fix a small painting bug when a menu is drawn over the titlebar background. Also move the tab strip context menu into the titlebar background container by adding an event box. Now the context menu appears e.g., below the min/max/close buttons or above the tab strip. Review URL: http://codereview.chromium.org/125078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18328 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build.tc@google.com2009-06-021-1/+0
| | | | | | | | | TBR=erg Review URL: http://codereview.chromium.org/114068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17426 0039d316-1c4b-4281-b951-d872f2087c98
* Port 2 more unittests to linux/mac. Just some small compiler warnings.tc@google.com2009-06-021-5/+3
| | | | | | | | | This ports find_backend_unittest.cc and tab_strip_model_unittest.cc. Review URL: http://codereview.chromium.org/119055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17424 0039d316-1c4b-4281-b951-d872f2087c98
* Add a context menu to the tab strip. It appears when you click in thetc@google.com2009-06-021-0/+1
| | | | | | | | | tab strip background. Review URL: http://codereview.chromium.org/119020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17415 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the Omnibox when changing tabs while its contents have been deleted.pkasting@chromium.org2009-05-292-1/+11
| | | | | | | | | To do this, I needed to add a new TabStripModelObserver call that fired before the tab had been changed, since when the Omnibox asks for the current permanent_text_ it gets it from the selected tab's navigation controller. BUG=6850 Review URL: http://codereview.chromium.org/113983 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17241 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15399.maruel@chromium.org2009-05-064-1/+18
| | | | | | | broke purify Review URL: http://codereview.chromium.org/115026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15409 0039d316-1c4b-4281-b951-d872f2087c98
* Change Browser::GetIndexOfController to GetIndexOfTabContents. Now that webrettw@chromium.org2009-05-064-18/+1
| | | | | | | | don't have tab contents switching, identifying tabs by their controller is weird, so we should gradually move to only using TabContents*. Review URL: http://codereview.chromium.org/115018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15399 0039d316-1c4b-4281-b951-d872f2087c98
* honor index in createTab()rafaelw@chromium.org2009-05-063-48/+65
| | | | | | | | | BUG=11200 R=brettw,beng Review URL: http://codereview.chromium.org/99300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15392 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_vector.h and stl_util-inl.h to base/ben@chromium.org2009-05-052-2/+2
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/107001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15272 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression that the sad tab favicon is not displayed when a tab crashes.brettw@chromium.org2009-05-041-1/+3
| | | | | | | | | | | | | | This regressed in my favicon/title updating change because the crashed state is not updated on the codepath, since it comes from the tab. The other approach would have been to make this call through the "update everything" codepath for tbe state changing, but that's executed on a timer, and it's nice to show the tab crash right away since the check is very inexpensive. BUG=http://crbug.com/10756 Review URL: http://codereview.chromium.org/99341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15201 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all occurrances of WebContents with TabContents.brettw@chromium.org2009-05-042-4/+4
| | | | | | Review URL: http://codereview.chromium.org/99177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this, it was missing the Mac unit-test change, that was breaking ↵jcampan@chromium.org2009-04-303-8/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | the build. TBR=ben Closing the last tab with a download in-progress would cause the tab to be closed and become unusable if the user decides not to proceed with the browser shutdown. This is because we check for in-progress downloads when the browser is closed, and the tab is closed before that, leaving the tab-strip in a bad state. This CL ensures we also bring-up the confirmation dialog when the last tab is closed. BUG=10680 TEST=Start downloading a big file. While the file is downloading, close all tabs. When closing the last tab, the in-progress download dialog should be shown. Select the 'Wait for downloads', the download tab should be shown and the previous tab should still be displayed and functional. Close all tabs again, this time select the 'Close and cancel downloads' option, the browser should be closed. Review URL: http://codereview.chromium.org/100210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14952 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 14948.jcampan@chromium.org2009-04-303-29/+8
| | | | | | | | | Broke the Mac build. TBR=ben Review URL: http://codereview.chromium.org/99224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14949 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 05:27:28 +0000