summaryrefslogtreecommitdiffstats
path: root/chrome/browser/tabs
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup: Update a bunch of files to the new location of browser_list.h. Part ↵tfarina@chromium.org2011-04-062-3/+3
| | | | | | | | | | | | | 2/3. BUG=None TEST=None R=avi@chromium.org Review URL: http://codereview.chromium.org/6805012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80647 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of extensions dependency from content\browser.jam@chromium.org2011-04-044-8/+13
| | | | | | | BUG=76789 Review URL: http://codereview.chromium.org/6693054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80315 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-283-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in tabstrip that resulted in not repainting when wesky@chromium.org2011-03-252-2/+40
| | | | | | | | | | | | | | should. This was the result of the tabstrip not notifying observers when the selection changed. For example, if tabs 1 and 2 were selected and 1 active, and 2 was removed observers weren't notified. BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6736011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79403 0039d316-1c4b-4281-b951-d872f2087c98
* Adds flag for selecting different sets of tabs in the tab strip.sky@chromium.org2011-03-232-3/+62
| | | | | | | | | | BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6725027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79216 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of renderer->browser messages to content.jam@chromium.org2011-03-231-1/+1
| | | | | | | TBR=tsepez Review URL: http://codereview.chromium.org/6721021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79152 0039d316-1c4b-4281-b951-d872f2087c98
* Makes pinned tab service save pinned tabs if you close a normalsky@chromium.org2011-03-236-28/+162
| | | | | | | | | | | | browser and there are only non-normal browsers open. BUG=40293 TEST=see bug, also covered by unit test R=ben@chromium.org,jcivelli@chromium.org Review URL: http://codereview.chromium.org/6722008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79131 0039d316-1c4b-4281-b951-d872f2087c98
* More OWNERS files.sky@chromium.org2011-03-221-0/+2
| | | | | | | | | | R=ben@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/6713068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79027 0039d316-1c4b-4281-b951-d872f2087c98
* Makes control-shift clicks on the tabstrip work. In particularsky@chromium.org2011-03-215-3/+40
| | | | | | | | | | | | | control-shift makes sure the tabs from the anchor to the index the user clicked on are selected, but doesn't remove anything. BUG=30572 TEST=none, just make sure tab selection isn't broken. R=ben@chromium.org Review URL: http://codereview.chromium.org/6709011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78882 0039d316-1c4b-4281-b951-d872f2087c98
* Updates TabStripModel context menu commands to deal with multiplesky@chromium.org2011-03-175-62/+360
| | | | | | | | | | | | | selected tabs. A right click on an selected tab makes the action apply to all tabs. A right click on an unselected tab only applies to that tab. BUG=30572 TEST=covered by unit tests. Review URL: http://codereview.chromium.org/6673095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78604 0039d316-1c4b-4281-b951-d872f2087c98
* Move the remaining files in chrome\common to content\common.jam@chromium.org2011-03-175-5/+5
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6672070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78516 0039d316-1c4b-4281-b951-d872f2087c98
* Move property bag to content.avi@chromium.org2011-03-101-1/+1
| | | | | | | | | BUG=none TEST=zero change Review URL: http://codereview.chromium.org/6660027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77686 0039d316-1c4b-4281-b951-d872f2087c98
* Further tweaks to TabStripModel::MoveSelectedTabsTo.sky@chromium.org2011-03-103-19/+38
| | | | | | | | | BUG=30572 TEST=none, just make sure tab selection isn't broke. Review URL: http://codereview.chromium.org/6646050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77669 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the notification stub files.tfarina@chromium.org2011-03-101-2/+2
| | | | | | | | | | | This is the last part of this series. BUG=None TEST=None Review URL: http://codereview.chromium.org/6658015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77581 0039d316-1c4b-4281-b951-d872f2087c98
* Creates TabStripSelectionModel and moves some functionality tosky@chromium.org2011-03-096-58/+670
| | | | | | | | | | | | it. Also adds MoveSelectedTabsTo which will be used when dragging around in the tab strip. BUG=30572 TEST=none, just make sure tab selection isn't broke. Review URL: http://codereview.chromium.org/6647011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77506 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of notification files.tfarina@chromium.org2011-03-096-18/+18
| | | | | | | | | | | Third part of the remaining files. BUG=None TEST=None Review URL: http://codereview.chromium.org/6650020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77458 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a lab that prefers switching to an existing tab rather thansky@chromium.org2011-03-072-0/+353
| | | | | | | | | | | | | | openning a url (when the url is typed into the omnibox). For example, if the 10th tab is for 'google.com' the first tab is selected and you type in 'google.com', this will switch to the 10th tab and not load anything. BUG=46623 TEST=none Review URL: http://codereview.chromium.org/3173036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77146 0039d316-1c4b-4281-b951-d872f2087c98
* Move notification service code to content. We'll need to figure out how to ↵jam@chromium.org2011-03-071-4/+4
| | | | | | | | | split the type enum so that chrome specific parts aren't in content later. TBR=avi Review URL: http://codereview.chromium.org/6627043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77102 0039d316-1c4b-4281-b951-d872f2087c98
* Changes semantics of TabSelectedAt. For multi-selection the TabStripsky@chromium.org2011-03-022-3/+18
| | | | | | | | | | | | | | | | | | is going to still have the notion of the selected tab, but I need some way to notify observers when other aspects of the selection change. For example, if you shift click to extend the selection the 'selected tab' won't change. I'm changing TabSelectedAt so that if the selected TabContents hasn't changed the old/new are the same. This change only adds the necessary code to ignore the new semantics. Code that actually invokes TabSelectedAt will come later. BUG=30572 TEST=none Review URL: http://codereview.chromium.org/6591097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76619 0039d316-1c4b-4281-b951-d872f2087c98
* Update the includes to the old tab_contents.hjam@chromium.org2011-03-021-2/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6596103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76552 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a bunch of includes to old locations of headers.jam@chromium.org2011-03-021-5/+5
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6602061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76470 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the int parameter from TabStripModel::TabDeselectedAt. Itsky@chromium.org2011-02-275-9/+7
| | | | | | | | | | | wasn't always right and no one used it anyway. BUG=none TEST=none Review URL: http://codereview.chromium.org/6598025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76195 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI: Move more files from chrome/browser/webui to chrome/browser/ui/webui.tfarina@chromium.org2011-02-271-1/+1
| | | | | | | | | | | | I'm moving the files I have found with: $ ls chrome/browser/webui | grep _ui BUG=59946 TEST=trybots Review URL: http://codereview.chromium.org/6599024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76183 0039d316-1c4b-4281-b951-d872f2087c98
* Move files out of chrome\browser\renderer_host\test alongside their source. ↵jam@chromium.org2011-02-241-4/+4
| | | | | | | | Most of them went to content\browser\renderer_host. Review URL: http://codereview.chromium.org/6575009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75824 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI: Move chrome/browser/dom_ui/ to chrome/browser/webui/.tfarina@chromium.org2011-02-221-2/+2
| | | | | | | | | | | | | To reduce the size of this change I've left stub header files in chrome/browser/dom_ui/. I'll updated the references and delete the stub files later. BUG=59945, 59946 TEST=trybots Review URL: http://codereview.chromium.org/6538075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75660 0039d316-1c4b-4281-b951-d872f2087c98
* Removes debugging code as cause of crash was found.sky@chromium.org2011-01-243-27/+8
| | | | | | | | | | | | I'm TBRing as this is just a removing of unneeded CHECKs. BUG=34135 TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6291011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72396 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing crash in tab code. It appears that we end up in asky@chromium.org2011-01-192-2/+21
| | | | | | | | | | | | | | | situation where the opener ends up the same as the tab being closed. The only way I could see this happening is a new tab getting the same address as a tab that was deleted. This seems unlikely, but I've added the code to make sure we clean up properly when a tab is deleted. I'm also adding a couple more checks. BUG=34135 TEST=none Review URL: http://codereview.chromium.org/6346008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71800 0039d316-1c4b-4281-b951-d872f2087c98
* Move SystemMonitor to src/ui/base/system_monitor. Move HiResTimerManager to ↵ben@chromium.org2011-01-191-3/+3
| | | | | | | | | | | | | src/chrome/common. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6361002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71797 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71487 - Move SystemMonitor to src/ui/base/system_monitor.ben@chromium.org2011-01-141-3/+3
| | | | | | | | | | | | | | Move HiResTimerManager to src/chrome/common. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6361002 TBR=ben@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71489 0039d316-1c4b-4281-b951-d872f2087c98
* Move SystemMonitor to src/ui/base/system_monitor.ben@chromium.org2011-01-141-3/+3
| | | | | | | | | | | | Move HiResTimerManager to src/chrome/common. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6361002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71487 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded chrome/browser/ui/browser.h usage.thestig@chromium.org2011-01-131-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6260001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71368 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of pref_names.hthestig@chromium.org2011-01-131-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6122006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71283 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some debugging code in hopes of figuring out why we'resky@chromium.org2011-01-123-7/+24
| | | | | | | | | | | | crashing. I can only see this crash happening if the opener ends up equal to contents, but that doesn't seem possible in code. BUG=34135 TEST=none Review URL: http://codereview.chromium.org/6124009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71116 0039d316-1c4b-4281-b951-d872f2087c98
* Changes instant so that the newly created tab has a new id. Doingsky@chromium.org2011-01-116-10/+16
| | | | | | | | | | | | otherwise causes subtle problems with extensions and breaks the invariant that the tab id is unique. BUG=68508 TEST=none Review URL: http://codereview.chromium.org/6155003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71063 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of chrome_switches.h.thestig@chromium.org2011-01-111-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6086003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70978 0039d316-1c4b-4281-b951-d872f2087c98
* Change extension unload notification to indicate updates.asargent@chromium.org2010-12-231-1/+2
| | | | | | | | | | | | | | | | | | | When an extension in being unloaded, some listeners want to know if it's because the extension is being updated to a newer version, or disabled. This changes the details sent to include a reason. Also this removes the EXTENSION_UNLOADED_DISABLED notification, since only a small number of places actually cared about the disctinction between EXTENSION_UNLOADED and EXTENSION_UNLOADED_DISABLED, and puts that information into the details as well. BUG=65510 TEST=Should be covered by existing unit & browser tests. Review URL: http://codereview.chromium.org/5968009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70104 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of notification_service.h, part 2.thestig@chromium.org2010-12-171-3/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5928003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69576 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ExtensionsService to ExtensionService.tfarina@chromium.org2010-12-141-1/+1
| | | | | | | | | BUG=61409 TEST=trybots Review URL: http://codereview.chromium.org/5730004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69117 0039d316-1c4b-4281-b951-d872f2087c98
* Makes instant run before unload listeners.sky@chromium.org2010-12-083-10/+14
| | | | | | | | | BUG=64694 TEST=none Review URL: http://codereview.chromium.org/5610005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68646 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-024-5/+5
| | | | | | | | | | | | | | | file_path_watcher into subdir profile* into profiles/ subdir login* into ui/login visitedlink* into subdir BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5606002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-024-4/+4
| | | | | | | | | | | | | | | | | | | | tab_menu_model->ui/tabs tab_contents_wrapper->ui/tab_contents view_ids.h->ui status_bubble.h->ui options*->ui/options show_options_url*->ui/options location_bar*->ui/omnibox input_window*->ui browser_uitests->ui/tests BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5582002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68047 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused BaseTabStrip methodsrjkroege@google.com2010-11-253-22/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before creating a new kind of TabStrip, I'm first cleaning up the BaseTabStrip class to remove two unused methods: SetDraggedTabBounds, and AsTabStrip. AsTabStrip was particularly unwanted because the base class was referencing the derived class. Furthermore, as an additional cleanup effort, I observe that there is no original caller to TabStripModelDelegate::ContinueDraggingDetachedTab(...) Therefore: TabStripModelDelegate::ContinueDraggingDetachedTab(...) REMOVED DefaultTabHandler::ContinueDraggingDetachedTab(...) REMOVED ...which leaves no callers of Browser::ContinueDraggingDetachedTab(...) Therefore: Browser::ContinueDraggingDetachedTab(...) REMOVED ...which leaves no callers of BrowserWindow::ContinueDraggingDetachedTab(bounds) Therefore: BrowserWindow::ContinueDraggingDetachedTab(bounds) REMOVED BrowserView::ContinueDraggingDetachedTab(bounds) REMOVED ...which leaves no callers of BrowserFrame::ContinueDraggingDetachedTab() Therefore: BrowserFrame::ContinueDraggingDetachedTab() REMOVED BrowserFrameGtk::ContinueDraggingDetachedTab() REMOVED BrowserFrameWin::ContinueDraggingDetachedTab() REMOVED BUG=None TEST=None Review URL: http://codereview.chromium.org/5253001 Patch from Chad Faragher <wyck@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67418 0039d316-1c4b-4281-b951-d872f2087c98
* This is another try to commit OOM priority management.gspencer@chromium.org2010-11-241-1/+3
| | | | | | | | | | | | | This changes nothing, except that I now initialize memory_used in oom_priority_manager.cc to placate the incorrect gcc warning about it being used when uninitialized. The original review is here: http://codereview.chromium.org/4498001/ BUG=none TEST=Passed chromeos try-bot, built both debug and release locally. Review URL: http://codereview.chromium.org/5328003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67342 0039d316-1c4b-4281-b951-d872f2087c98
* views: Show accelerators in tabstrip context menu.sadrul@chromium.org2010-11-242-0/+38
| | | | | | | | | | | | | | As it happens, the command-id is a TabStripModel::ContextMenuCommand. So it needs to be converted into a browser command first, before the accelerator is looked up. BUG=None TEST=Right click on a tab. The context menu should have proper accelerators displayed (e.g. Ctrl+T for the 'New Tab' option). Review URL: http://codereview.chromium.org/5331005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67289 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67175 - This change implements OOM priority management for ChromeOSviettrungluu@chromium.org2010-11-231-1/+0
| | | | | | | | | | | | | | | | (Build failure, probably debug/release warning difference.) This adds periodic OOM score adjustment, based on the last access time of the tab, whether or not it is pinned, and (of course) how much memory it is using. BUG=http://crosbug.com/8990 TEST=Ran some ui_tests, ran on device. Review URL: http://codereview.chromium.org/4498001 TBR=gspencer@chromium.org Review URL: http://codereview.chromium.org/5284003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67183 0039d316-1c4b-4281-b951-d872f2087c98
* This change implements OOM priority management for ChromeOSgspencer@chromium.org2010-11-231-0/+1
| | | | | | | | | | | This adds periodic OOM score adjustment, based on the last access time of the tab, whether or not it is pinned, and (of course) how much memory it is using. BUG=http://crosbug.com/8990 TEST=Ran some ui_tests, ran on device. Review URL: http://codereview.chromium.org/4498001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67175 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] hide floating bookmark bar during instant preview.estade@chromium.org2010-11-221-1/+1
| | | | | | | | | BUG=63562 TEST=manual Review URL: http://codereview.chromium.org/5147005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66993 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix: Remove one last browser.h that slipped in.jhawkins@chromium.org2010-11-181-1/+1
| | | | | | | | | | TBR=thestig BUG=none TEST=none Review URL: http://codereview.chromium.org/5201003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66671 0039d316-1c4b-4281-b951-d872f2087c98
* Make pink's TabContentsWrapper change compile on Windows.ben@chromium.org2010-11-1811-306/+368
| | | | | | | | | | Code by pinkerton@, with modifications by evanm and myself to get it to build on windows/linux/chromeos. BUG=none TEST=none Review URL: http://codereview.chromium.org/4694008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66626 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Include browser.h -> ui/browser.h [Part 2].jhawkins@chromium.org2010-11-163-3/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5046002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66229 0039d316-1c4b-4281-b951-d872f2087c98