summaryrefslogtreecommitdiffstats
path: root/chrome/browser/tabs
Commit message (Collapse)AuthorAgeFilesLines
* Move RenderViewHost management out of WebContents into a newbrettw@google.com2008-08-121-2/+3
| | | | | | | | | | | | | | RenderViewHostManager object. The goal for this patch is to change no logic or APIs, just move the code. So there are some not very clean callback functions and no new unit tests for this file (although is is still covered by the same WebContents unit tests). This should make the actual cleanup in a later pass much easier to follow. I changed the ordering of only a few operations (like WebContents shutdown), and checked that this shouldn't matter. I had to change the "source" for several notifications since they are no longer sent from the WebContents. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@716 0039d316-1c4b-4281-b951-d872f2087c98
* Fiddle with destruction order of the dragged tab controller to ensure that ↵beng@google.com2008-08-121-0/+3
| | | | | | | | | there's still a TabStrip available for it. B=1145714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@708 0039d316-1c4b-4281-b951-d872f2087c98
* Move Tab Drag Tests inside Project interactive_ui_testssidchat@google.com2008-08-111-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@675 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the TabStrip is laid out after a drag-detach operation is ↵beng@google.com2008-08-092-4/+4
| | | | | | | | | | completed. This is important because if there was a pending animation it was canceled, potentially leaving the TabStrip in a bad visual state. Also remove some debugging code that wasn't useful. B=1317895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@633 0039d316-1c4b-4281-b951-d872f2087c98
* Even more tweaks.beng@google.com2008-08-092-16/+2
| | | | | | | | | | - make window icon and title work on app windows - make window title updating sync with the task bar - make Aero Glass frame respect app mode settings - move title formatting routine from TabRenderer into Browser (a more central location) - appearance adjustments for app windows with info bars git-svn-id: svn://svn.chromium.org/chrome/trunk/src@612 0039d316-1c4b-4281-b951-d872f2087c98
* Comment out the tests for now.sidchat@google.com2008-08-091-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@609 0039d316-1c4b-4281-b951-d872f2087c98
* M chrome/test/ui/ui_tests.vcprojsidchat@google.com2008-08-081-0/+262
| | | | | | | | AM chrome/browser/tabs/tab_dragging_test.cc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@606 0039d316-1c4b-4281-b951-d872f2087c98
* Make tabs affected by context menu actions pulse. The effect is somewhat ↵beng@google.com2008-08-078-74/+241
| | | | | | | | | | subtle since I'm re-using the selection animation. Added support to the Menu Delegate for notifications of when selection moves within the menu. B=1313339 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@523 0039d316-1c4b-4281-b951-d872f2087c98
* B=1302955 R=sky attempt to bandaid situation where tab_data_ and child list ↵beng@google.com2008-08-061-0/+11
| | | | | | can get out of sync git-svn-id: svn://svn.chromium.org/chrome/trunk/src@443 0039d316-1c4b-4281-b951-d872f2087c98
* Grab bag of random cleanups, implementation of some more methods, etc. I'm ↵beng@google.com2008-08-051-0/+3
| | | | | | | | going to become more methodical about this soon, I promise. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@377 0039d316-1c4b-4281-b951-d872f2087c98
* Add the TabStrip to the BrowserView2. (hooked up for OpaqueFrame only at ↵beng@google.com2008-08-052-0/+25
| | | | | | | | this point). Make non-client hittest logic mostly work. Window is somewhat interactive again. Yay! B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@359 0039d316-1c4b-4281-b951-d872f2087c98
* When a new tab is opened (either the new tab page via Ctrl+T or pressing the ↵beng@google.com2008-08-044-6/+121
| | | | | | | | | | new tab button) or an address is opened from the address bar in a new tab (by pressing Alt+Enter), the opener is remembered briefly, allowing quick lookup in a new tab without disrupting the z-order experience. Full explanation in bug: B=1266404 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@330 0039d316-1c4b-4281-b951-d872f2087c98
* A bunch of cleanups to beforeunload/unload handling.ojan@google.com2008-08-021-1/+1
| | | | | | | | 1. Remove all the is_closing_browser plumbing. WebContents/TabContents/RenderViewHost/etc really shouldn't (and don't!) need to know anything about whether we're closing the browser or not. 2. Refactor the handling of beforeunload/unload state in browser.cc. I think this makes it considerably easier to reason about the correctness of it. 3. Added a couple TODOs for future cleanups that would have made this change a bit too large. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273 0039d316-1c4b-4281-b951-d872f2087c98
* Make closetabsopenedby walk the whole tabstrip instead of just all the tabs ↵ojan@google.com2008-08-011-1/+1
| | | | | | to the right of the tab whose context menu was used. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253 0039d316-1c4b-4281-b951-d872f2087c98
* Forward declare Task in ssl_manager.h. Cleanup some uses of ↵deanm@google.com2008-08-011-1/+0
| | | | | | | | notification_service.h. TBR=maruel git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238 0039d316-1c4b-4281-b951-d872f2087c98
* Have CommandCloseTabsOpenedBy iterate through the tabs in reverse order to ↵ojan@google.com2008-08-011-6/+5
| | | | | | | | avoid race conditions with tab closing now that it's async. BUG=1303289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216 0039d316-1c4b-4281-b951-d872f2087c98
* Make HWNDViewContainer set up its contents view separately from its Init method.beng@google.com2008-07-303-3/+4
| | | | | | | | | This is needed as a first step in further adjustments I'm going to be making to Window, ClientView, etc. B=1280060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeFrame->BrowserWindowbeng@google.com2008-07-301-2/+3
| | | | | | | | | Move static utility functions to FrameUtil class. B=1294302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102 0039d316-1c4b-4281-b951-d872f2087c98
* Fix one more glitch when drag-attaching a tab to the tabstrip. Other tabs in ↵beng@google.com2008-07-301-0/+8
| | | | | | | | the strip were instantly sized to their start size for the insert tab animation (which is their current size) but this calculation didn't take into account the fact that a newly inserted tab has a minimum size so their initial size isn't just the width / n other tabs, it's (width / n other tabs) - (min width / n other tabs) B=1285677 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash. Now sometimes TabContentses can be NULL it seems.beng@google.com2008-07-301-2/+3
| | | | | | B=1297990 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84 0039d316-1c4b-4281-b951-d872f2087c98
* I screwed this one up, and had my index munging wrong.beng@google.com2008-07-301-13/+8
| | | | | | | | This is actually a much simpler approach. Get the TabContents that the context menu was brought up for and reverse walk the list closing all Tabs that don't match. Duh. B=1298878 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83 0039d316-1c4b-4281-b951-d872f2087c98
* Fix not closing the browser with hung, crashed and interstitial tabs. Adds a ↵ojan@google.com2008-07-291-1/+7
| | | | | | | | 1 second hang monitor for the beforeunload/unload events to fire. BUG=1296059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81 0039d316-1c4b-4281-b951-d872f2087c98
* Add a return value to InternalCloseTabContentsAt, indicating whether or not ↵beng@google.com2008-07-292-9/+21
| | | | | | | | | | the TabContents was closed immediately or if we're waiting for an unload handler to fire. Adjust indices in Close other tabs handler to take into account the fact that some tabs may not close immediately B=1295790 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63 0039d316-1c4b-4281-b951-d872f2087c98
* Ugh. It turns out we were never properly removing the dragged tab from the ↵beng@google.com2008-07-295-11/+65
| | | | | | | | | | | | source tabstrip when a drag was completed. This was causing various problems, which were highlighted when you reverted a drag (e.g. press esc or alt+tab while dragging). See my comments inline in the diff for explanations. This manifests as Venkat's latest repro in: B=1262392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few incorrect #endif's in include guards.deanm@google.com2008-07-284-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some glitches dragging tabs.beng@google.com2008-07-282-9/+48
| | | | | | | | | | | | | | | - Fix what looks like an off-by-one in tab attaching (line 504 in diff) - Ensure ideal bounds are appropriately generated for dragging so that insertion index calculations work properly (line 452, 492) - Provide a threshold so that when dragging left and right a tab must be displaced by at least threshold before tabs are reordered again to prevent jittering. Default threshold is 16px for standard sized tabs, scaled down in the ratio of the unselected current tab size to the standard size depending on the number of tabs open. B=1285677 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome to the repository.initial.commit2008-07-2617-0/+7185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-28 15:53:56 +0000