summaryrefslogtreecommitdiffstats
path: root/chrome/browser/task_manager
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup:pkasting@chromium.org2011-02-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | * Change int to size_t in a few APIs. * Rename infobar_delegate_count() to infobar_count() in preparation for TabContents owning InfoBars rather than InfoBarDelegates. * Move some code from PluginInstallerInfoBarDelegate to PluginObserver since it's more related to who's instantiating the infobar(delegate)s. * Unify InfoBarDelegate behavior by making no delegates auto-add themselves to tabs (callers now all do this explicitly). * Eliminate unused member TabContentsSSLHelper::SSLAddCertData::handler_. * De-inline a couple classes. * Make more functions private. * Add some consts. * Change DCHECK() to DCHECK_EQ() where possible. * Rename the delegates in plugin_observer.cc to have "Delegate" in the names. * Remove unnecessary qualifiers. * Simplify. * Misc. style issues, naming issues, etc. BUG=none TEST=none Review URL: http://codereview.chromium.org/6250172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74086 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Task Manager to correctly display network usage of plug-in processes.ajwong@chromium.org2011-02-054-42/+25
| | | | | | | | | | | | BUG=chromium-os:2954 TEST=Run Chrome and open Task Manager, then play a video in YouTube and check whether the Network usage is correctly reported against the plug-in. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73884 Review URL: http://codereview.chromium.org/6328010 Patch from James Weatherall <wez@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73915 0039d316-1c4b-4281-b951-d872f2087c98
* Change includes of gfx/* to ui/gfx/*sail@chromium.org2011-02-051-1/+1
| | | | | | | | | BUG=71063 TEST=compiled Review URL: http://codereview.chromium.org/6312156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
* This reverts commit r73836.ajwong@chromium.org2011-02-054-25/+42
| | | | | | TBR=wez git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73886 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Task Manager to correctly display network usage of plug-in processes.ajwong@chromium.org2011-02-054-42/+25
| | | | | | | | | | BUG=chromium-os:2954 TEST=Run Chrome and open Task Manager, then play a video in YouTube and check whether the Network usage is correctly reported against the plug-in. Review URL: http://codereview.chromium.org/6328010 Patch from James Weatherall <wez@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73884 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from the task manager.avi@chromium.org2011-02-035-89/+89
| | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6410065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73672 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to ui/baseben@chromium.org2011-01-214-4/+4
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: de-inline a bunch of classes, rename and move "PluginInstaller" to ↵pkasting@chromium.org2011-01-211-6/+5
| | | | | | | | | | "PluginInstallerInfoBarDelegate" for clarity, lots of other misc. stuff BUG=none TEST=none Review URL: http://codereview.chromium.org/6249010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72166 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-211-1/+0
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* Attribute orphaned or anonymous network usage to the Browser resources.thakis@chromium.org2011-01-211-13/+17
| | | | | | | | | | | | BUG=47955,69883 TEST=When a tab is closed with a download in-progress and Task Manager displayed, the network activity is reflected in the Browser resource's Network total. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72095 Review URL: http://codereview.chromium.org/6383002 Patch from James Weatherall <wez@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72105 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 72095 - Attribute orphaned or anonymous network usage to the Browser ↵thakis@chromium.org2011-01-211-16/+13
| | | | | | | | | | | | | | | resources. BUG=47955,69883 TEST=When a tab is closed with a download in-progress and Task Manager displayed, the network activity is reflected in the Browser resource's Network total. Review URL: http://codereview.chromium.org/6383002 Patch from James Weatherall <wez@chromium.org>. TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/6341006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72096 0039d316-1c4b-4281-b951-d872f2087c98
* Attribute orphaned or anonymous network usage to the Browser resources.thakis@chromium.org2011-01-211-13/+16
| | | | | | | | | | BUG=47955,69883 TEST=When a tab is closed with a download in-progress and Task Manager displayed, the network activity is reflected in the Browser resource's Network total. Review URL: http://codereview.chromium.org/6383002 Patch from James Weatherall <wez@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72095 0039d316-1c4b-4281-b951-d872f2087c98
* Move ResourceBundle, DataPack to ui/baseben@chromium.org2011-01-202-2/+2
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6263008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK caused by Task Manager assuming all requests have a render view.thakis@chromium.org2011-01-191-1/+7
| | | | | | | | | | BUG=69883 TEST=Display Task Manager while one or more tabs are open, and start typing into the Omnibox of one of them. Review URL: http://codereview.chromium.org/6240006 Patch from Wez Weatherall <wez@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71807 0039d316-1c4b-4281-b951-d872f2087c98
* Blow away BackgroundContents when RenderView goes away.atwilson@chromium.org2011-01-181-0/+63
| | | | | | | | | | | | | Reopening, because this CL broke NoticeNotificationChanges on XP for some reason, so I'm going to undo my (now superfluous) changes to flush the queue in WaitForResourceChange(). BUG=65189 TEST=TaskManagerBrowserTest.KillBGContents Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71458 Review URL: http://codereview.chromium.org/6226002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71688 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPS past WebKit move. Update gyp files and include paths to ↵abarth@chromium.org2011-01-172-2/+2
| | | | | | reflect the move. Consolidate how we DEPS in WebKit source files. Cross fingers. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71585 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71458 - Blow away BackgroundContents when RenderView goes away.atwilson@chromium.org2011-01-151-87/+5
| | | | | | | | | | | | | | Rolling this out because it breaks NoticeNotificationChanges on XP for some reason. BUG=65189 TEST=TaskManagerBrowserTest.KillBGContents Review URL: http://codereview.chromium.org/6226002 TBR=atwilson@chromium.org Review URL: http://codereview.chromium.org/6310008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71536 0039d316-1c4b-4281-b951-d872f2087c98
* Blow away BackgroundContents when RenderView goes away.atwilson@chromium.org2011-01-141-5/+87
| | | | | | | | | BUG=65189 TEST=TaskManagerBrowserTest.KillBGContents Review URL: http://codereview.chromium.org/6226002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71458 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequestStatus URLRequestStatus;tfarina@chromium.org2011-01-131-2/+2
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/6166010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71285 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix unchecked return values.kmadhusu@chromium.org2011-01-121-2/+5
| | | | | | | | | | CID=13943, 13746, 13749, 13597, 13249, 13145, 12875, 12874, 12871, 12438, 12436, 12431 BUG=none TEST=none Review URL: http://codereview.chromium.org/6076006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71179 0039d316-1c4b-4281-b951-d872f2087c98
* Re-disable TaskManagerBrowserTest.ReloadExtension for now. asargent@chromium.org2011-01-071-3/+2
| | | | | | | | | | | | | | I got the data I needed from re-enabling it, and have a way to repro and am working on a fix. BUG=42315 TEST=none TBR=twiz Review URL: http://codereview.chromium.org/6106008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70784 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70722 - Disable crashy TaskManagerBrowserTest.ReloadExtensionphajdan.jr@chromium.org2011-01-071-2/+1
| | | | | | | | | | | | | | | The test is being debugged, see http://crbug.com/42315. TBR=sky BUG=66957 TEST=browser_tests Review URL: http://codereview.chromium.org/6097009 TBR=sky Review URL: http://codereview.chromium.org/6155002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70726 0039d316-1c4b-4281-b951-d872f2087c98
* Disable crashy TaskManagerBrowserTest.ReloadExtensionphajdan.jr@chromium.org2011-01-071-1/+2
| | | | | | | | | | TBR=sky BUG=66957 TEST=browser_tests Review URL: http://codereview.chromium.org/6097009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70722 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add namespace net to the remaining files under url_request directory.tfarina@chromium.org2011-01-061-2/+2
| | | | | | | | | | | | It just adds the 'namespace net' to these files and a typedef for them, because there are many entries to fix in one pass. They will be fixed later. BUG=64263 TEST=trybots Review URL: http://codereview.chromium.org/6056007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70592 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable a crashy test with some added logging.asargent@chromium.org2011-01-041-2/+12
| | | | | | | | | BUG=42315 TEST=none Review URL: http://codereview.chromium.org/6075010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70464 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/thread.h to base/threading, fix up callers to use the new location.brettw@chromium.org2011-01-012-2/+2
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6028009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70345 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70281 - Revert 70271 - Remove wstring from l10n_util. Part 3.avi@chromium.org2010-12-292-18/+20
| | | | | | | | | | | | | | | BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6044006 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6051012 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/5989012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70283 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70271 - Remove wstring from l10n_util. Part 3.avi@chromium.org2010-12-292-20/+18
| | | | | | | | | | | | BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6044006 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6051012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70281 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from l10n_util. Part 3.avi@chromium.org2010-12-292-18/+20
| | | | | | | | | BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6044006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70271 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add namespace net to more files. Part 2.tfarina@chromium.org2010-12-202-3/+3
| | | | | | | | | BUG=64263 TEST=compiled locally and trybots Review URL: http://codereview.chromium.org/5980003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69689 0039d316-1c4b-4281-b951-d872f2087c98
* Almost done deinlining virtual methods.erg@google.com2010-12-162-14/+71
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5841002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69470 0039d316-1c4b-4281-b951-d872f2087c98
* Disable crashy TaskManagerBrowserTest.KillExtensionAndReloadphajdan.jr@chromium.org2010-12-151-1/+3
| | | | | | | | | | TBR=sky BUG=66957 TEST=browser_tests Review URL: http://codereview.chromium.org/5883001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69236 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ExtensionsService to ExtensionService.tfarina@chromium.org2010-12-142-10/+10
| | | | | | | | | BUG=61409 TEST=trybots Review URL: http://codereview.chromium.org/5730004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69117 0039d316-1c4b-4281-b951-d872f2087c98
* This adds some plumbing for propagating the status and error code of a ↵gspencer@chromium.org2010-12-141-1/+2
| | | | | | | | | | | | | | | | | | | | | renderer process that went away so that we can tell at the UI level what happened to the tab: did it crash, or was it killed by the OOM killer (or some other reason). This is in preparation for implementing a new UI for when a process is killed by the OOM on ChromeOS which handles it differently from a crash. Most of the changes are modifications of the argument list to include a status and error code for the exited process, but in addition the following was done: - Changed the name of DidProcessCrash to GetTerminationStatus. - Added TerminationStatus enum in process_util.h, so it can be used as the status returned by GetTerminationStatus. - Improved process_util_unittest to actually test for crashing and terminated processes on all platforms. - Added a new notification for renderers that were killed. - Added error code information to crash notification. - Added status and error code information to renderer IPC message for RenderViewGone. - Added a UMA histogram count for number of renderer kills. BUG=http://crosbug.com/8505 TEST=ran new unit test. Test passes on try servers. Review URL: http://codereview.chromium.org/5172009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69082 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ResourceMessageFilter to RenderMessageFilter, since that's what it ↵jam@chromium.org2010-12-141-1/+1
| | | | | | | | actually is. I will add a ResourceMessageFilter just for resource IPCs in a future change. Review URL: http://codereview.chromium.org/5701004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69076 0039d316-1c4b-4281-b951-d872f2087c98
* Rename all methods accessing Singleton<T> as GetInstance().satish@chromium.org2010-12-131-1/+1
| | | | | | | | | | | | | | | This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton. This primarily covers files in chrome os and other directories, missed in the previous CL. In a couple of files i changed Singleton<T> usage to LazyInstance<T>, because changing the method name to GetInstance() in there would require a whole lot of updates throughout the chrome os codebase. BUG=65298 TEST=all existing tests should pass. Review URL: http://codereview.chromium.org/5734002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69007 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequestJob URLRequestJob;tfarina@chromium.org2010-12-111-6/+6
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/5607004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68935 0039d316-1c4b-4281-b951-d872f2087c98
* Add the "virtual" keyword on method overrides that are missing it.erg@google.com2010-12-083-48/+54
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5648004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68606 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash and flakiness in TaskManagerBrowserTest.NoticeExtensionChanges.creis@google.com2010-12-071-14/+10
| | | | | | | | | BUG=31663 TEST=TaskManagerBrowserTest.* Review URL: http://codereview.chromium.org/5646004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68494 0039d316-1c4b-4281-b951-d872f2087c98
* Show extension tabs in task manager and correctly label apps.creis@google.com2010-12-053-15/+125
| | | | | | | | | | | BUG=31526 BUG=60840 TEST=TaskManagerBrowserTest.NoticeExtensionTabs TEST=TaskManagerBrowserTest.NoticeAppTabs Review URL: http://codereview.chromium.org/5526002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68324 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-023-3/+3
| | | | | | | | | | | | | | | file_path_watcher into subdir profile* into profiles/ subdir login* into ui/login visitedlink* into subdir BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5606002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add namespace net to URLRequest and URLRequestJob classes.tfarina@chromium.org2010-11-281-5/+7
| | | | | | | | | BUG=64263 TEST=compiled locally and trybots Review URL: http://codereview.chromium.org/5298008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67497 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup AdjustStringForLocaleDirection() to modify input parameter in place.jeremy@chromium.org2010-11-242-4/+3
| | | | | | | | | | | As described in the bug, the current behavior is confusing and bug-prone. BUG=47194 TEST=Check that there are no visible regressions in RTL and LTR language UIs on Linux & Windows. Review URL: http://codereview.chromium.org/5154009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67237 0039d316-1c4b-4281-b951-d872f2087c98
* Reenables some tests that were disabled because of property leaks thatsky@chromium.org2010-11-221-16/+0
| | | | | | | | | | | should now be fixed. BUG=44991, 61528 TEST=none Review URL: http://codereview.chromium.org/5131006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66998 0039d316-1c4b-4281-b951-d872f2087c98
* When an extension is uninstalled, close all desktop notifications from that ↵johnnyg@chromium.org2010-11-191-2/+3
| | | | | | | | | | | | | | | | | | | extension. This change also refactors the balloon collection code to remove duplication between chrome and chromeos. Removes some gross removal code which was using fake notifications just to get the right ID. BUG=58266 TEST=open notifications from extension, uninstall extensions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65879 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66571 Review URL: http://codereview.chromium.org/4635007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66829 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 66571 - When an extension is uninstalled, close all desktop ↵johnnyg@chromium.org2010-11-181-3/+2
| | | | | | | | | | | | | | | | | | | | notifications from that extension. This change also refactors the balloon collection code to remove duplication between chrome and chromeos. Removes some gross removal code which was using fake notifications just to get the right ID. BUG=58266 TEST=open notifications from extension, uninstall extensions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65879 Review URL: http://codereview.chromium.org/4635007 TBR=johnnyg@chromium.org Review URL: http://codereview.chromium.org/5162003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66572 0039d316-1c4b-4281-b951-d872f2087c98
* When an extension is uninstalled, close all desktop notifications from that ↵johnnyg@chromium.org2010-11-181-2/+3
| | | | | | | | | | | | | | | | | extension. This change also refactors the balloon collection code to remove duplication between chrome and chromeos. Removes some gross removal code which was using fake notifications just to get the right ID. BUG=58266 TEST=open notifications from extension, uninstall extensions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65879 Review URL: http://codereview.chromium.org/4635007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66571 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Include browser.h -> ui/browser.h [Part 4].jhawkins@chromium.org2010-11-171-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5104002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66401 0039d316-1c4b-4281-b951-d872f2087c98
* Implement new task manager mocks on windows.atwilson@chromium.org2010-11-154-28/+78
| | | | | | | | | | | | | Added API to differentiate between background resources and normal foreground tabs, and added support for grouping processes containing background resources in a separate section of task manager. BUG=63140 TEST=bring up task manager on windows Review URL: http://codereview.chromium.org/4987001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66132 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 65879 - When an extension is uninstalled, close all desktop ↵johnnyg@chromium.org2010-11-121-3/+2
| | | | | | | | | | | | | | | | | | notifications from that extension. This change also refactors the balloon collection code to remove duplication between chrome and chromeos. Removes some gross removal code which was using fake notifications just to get the right ID. BUG=58266 TEST=open notifications from extension, uninstall extensions Review URL: http://codereview.chromium.org/4635007 TBR=johnnyg@chromium.org Review URL: http://codereview.chromium.org/4855002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65896 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 09:22:13 +0000