| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
| |
TEST=Open the task manager. Close it. Open again and close. Browser should not crash.
http://crbug.com/13361
Review URL: http://codereview.chromium.org/119299
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18038 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The reason why it didn't bring up the stats in foreground is because it is an application window. Application (same goes for popup) windows cannot have tabs, it is just a single page. When the link is clicked, we need to get the last active browser so we could open that about:memory page. When you open a page in an application window, it will create a new window or find a window (normal) that is present, then open the url in that tab. So now we don't have the browser pointed to that tab, its still pointed to the application window.
By finding the last active tab again, we can ensure we have the correct tab.
BUG=11822 (http://crbug.com/11822)
TEST=tested if the stats appeared in foreground and it did.
Review URL: http://codereview.chromium.org/119293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17925 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
its destructor, causing a failure in the browser tests.
BUG=None
TEST=Run the browser tests
Review URL: http://codereview.chromium.org/118315
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17762 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
Make Task Manager Table view a scoped_ptr so it and its columns are deleted regardless of whether or not the HWND has been constructed.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17677 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
| |
This reverts commit r17573, on beng's request.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17581 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
actually creating the window it lives in. Make sure the table is only allocated and initialized when it's inserted into a view hierarchy to avoid leaking the columns.
BUG=none
TEST=purify unit test bot
Review URL: http://codereview.chromium.org/118199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17573 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
the task manager view is added.
http://crbug.com/12927
TEST=open the task manager, should work
Review URL: http://codereview.chromium.org/119105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17532 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
- reduce header dependencies
- miscellanous cleanups (add missing includes for OS_ defines etc)
Further changesets may follow. I was only looking at header files up to character_encoding.h.
Review URL: http://codereview.chromium.org/118072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17470 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
need either the view or model observers and that's it.
I moved the model constructors to a .cc file so we don't have to include
l10n_util.h for everybody. A surprising number of files were getting l10n_util
from the table code, so I had to add it in a bunch of places.
There should be no code change except I made the table column cosntructors take
wstring references instead of copies.
Review URL: http://codereview.chromium.org/115969
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17295 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
http://crbug.com/12320
Review URL: http://codereview.chromium.org/113636
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16978 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TaskManager is a singleton, so it's destroyed by AtExitManager. At the time
of destruction it cannot register AtExit callbacks (AtExitManager requires
that). It turns out that some Windows view code wants to register an AtExit
callback during destruction.
For more info about view code, see http://src.chromium.org/viewvc/chrome?view=rev&revision=9161
The fix is to destroy the view early, using EnsureShutdown static method
of TaskManager. It was also necessary to delete child views a bit earlier
to avoid another crashed.
Added a regression browser_test and verified that it's broken without this fix.
http://crbug.com/11180
Review URL: http://codereview.chromium.org/114031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16474 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
manager. It's the only one who uses this setting and the UI for exposing it is very specific to the task manager. Window retains a setter to set always on top state, but persistence and the system menu is Task Manager's responsbility. This allows us to sever the second-to-last chrome dependency from views.
http://crbug.com/11674
Review URL: http://codereview.chromium.org/115378
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16107 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
the namespace views.
BUG=none
TEST=make sure I haven't broken any menus. This impacts all menus in
Chrome, except bookmark ones.
Review URL: http://codereview.chromium.org/113410
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
- task_manager.cc compiles on POSIX
- task_manager_unittest.cc passes on Linux
- stub TaskManagerViewImpl for Linux (so that the unit test can pass)
TEST=Task manager should not be obviously broken on Windows.
http://crbug.com/11461
Review URL: http://codereview.chromium.org/115295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16053 0039d316-1c4b-4281-b951-d872f2087c98
|
