summaryrefslogtreecommitdiffstats
path: root/chrome/browser/themes/theme_syncable_service_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup extension_service.hrdevlin.cronin@chromium.org2014-05-291-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | If the Broken Window Theory holds true, then ExtensionService will never be cleaned up (and will, in fact, degrade faster than we can fix it) if it looks like it's messy. So, let's clean house! - Group overriden methods together, say what they override. - Move all comments to the original method declaration (i.e., if it's overriden from ExtensionServiceInterface, comment there). - Move accessors together. - Move for_test methods together. - Move methods which are not used publicly into private:. - Move simple getters/setters from the .cc to the .h. - Remove FRIEND_TESTs that should not be there. - Remove unneeded forward class declarations. - Remove unneeded includes.* *This one led to a BUNCH of fixes in other files, which relied on the transitive includes of extension_service.h. Sorry for the noise. BUG=351891 TBR=jochen@chromium.org (for every header file change - they're only fixing transitive includes) Review URL: https://codereview.chromium.org/296073003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273424 0039d316-1c4b-4281-b951-d872f2087c98
* [cros login] Split login related classes into subfolders.nkostylev@chromium.org2014-05-161-1/+1
| | | | | | | | | | | | | | | | | | | auth: local auth i.e. cryptohome related lock: screen lock signin: browser signin related such as OAuth2* users: user management users/avatar: user avatars (profile pictures) users/wallpaper: user wallpapers ui: login/lock dialogs/host/view etc. BUG=370175 TEST=existing tests, presubmit hooks TBR=benwells Review URL: https://codereview.chromium.org/286933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270898 0039d316-1c4b-4281-b951-d872f2087c98
* Improve some namingestade@chromium.org2014-05-131-11/+11
| | | | | | | | | | "Native" theme is sometimes synonymous with "system" theme, and sometimes not. Change some uses of "native" to "system" to avoid confusion with the class called NativeTheme. BUG=none Review URL: https://codereview.chromium.org/244893004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269985 0039d316-1c4b-4281-b951-d872f2087c98
* Replace deprecated 3-arg SyncData::CreateLocalData with 5-arg version.maniscalco@chromium.org2014-04-101-5/+11
| | | | | | | | | | | | | | | | | | | | Update unit tests that call SyncData::CreateLocalData to call the new version. Add AttachmentServiceProxyForTest to reduce boilerplate in tests. Add a MessageLoop to ManagedUserSyncServiceTest, DomDistillerStoreTest, and SyncChangeTest because AttachmentServiceProxyForTest needs one. Format modified lines with clang-format. TBR=pam,droger,asargent,pkasting,pkotwicz,cjhopman BUG=353296 Review URL: https://codereview.chromium.org/213003004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263128 0039d316-1c4b-4281-b951-d872f2087c98
* Move clients of BrowserContextKeyedService to use KeyedService (#4)blundell@chromium.org2014-03-141-2/+1
| | | | | | | | | | | | | This change covers: - //components - Roughly half of the remaining clients in //chrome BUG=351704 TBR=jochen Review URL: https://codereview.chromium.org/198193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257067 0039d316-1c4b-4281-b951-d872f2087c98
* Move extension_messages.h to extensions/common.derat@chromium.org2014-03-131-1/+1
| | | | | | | | | | | | | | | Move most of chrome/common/extensions/extension_messages.h into a new extensions/common/extension_messages.h file. WebApplicationInfo-related IPC definitions are now in chrome/common/extensions/chrome_extension_messages.h. BUG=335159 TBR=sky@chromium.org,cdn@chromium.org Review URL: https://codereview.chromium.org/194333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256831 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ExtensionService::extension_prefs()rockot@chromium.org2014-02-191-2/+2
| | | | | | | | | | | | | | Callers use ExtensionPrefs::Get instead of depending on ExtensionService for access. Where appropriate, other nearby, unnecessary references to ExtensionService have also been removed. BUG=341181 TBR=benwells@chromium.org,benjhayden@chromium.org,akalin@chromium.org,pkotwicz@chromium.org,stevenjb@chromium.org,sky@chromium.org,dbeam@chromium.org,finnur@chromium.org Review URL: https://codereview.chromium.org/156843004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251958 0039d316-1c4b-4281-b951-d872f2087c98
* Remove duplicated code from sync related unit tests.maniscalco@chromium.org2014-02-191-129/+159
| | | | | | | | | | | | | Consolidate the various implementations of SyncChangeProcessorDelegate and fake into sync/api. Replace many of the fake SyncChangeProcessor implementations with a slightly more advanced FakeSyncChangeProcessor. TBR=brettw@chromium.org BUG= Review URL: https://codereview.chromium.org/151963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251926 0039d316-1c4b-4281-b951-d872f2087c98
* Removes MessageLoop::TYPE_XXX where possiblesky@chromium.org2014-01-151-2/+1
| | | | | | | | | | | | This is part of attempting to get rid of MessageLoop::Type enum. BUG=none TEST=none R=darin@chromium.org Review URL: https://codereview.chromium.org/136683004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244996 0039d316-1c4b-4281-b951-d872f2087c98
* Update some uses of Value in chrome/browser to use the base:: namespace.avi@chromium.org2013-12-231-2/+2
| | | | | | | | | | BUG=88666 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/113013003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242399 0039d316-1c4b-4281-b951-d872f2087c98
* Move Extension and PermissionsData to extensions/common.yoz@chromium.org2013-11-151-1/+1
| | | | | | | | | | BUG=298586 R=cdn@chromium.org, miket@chromium.org, sky@chromium.org TBR=cdn@chromium.org Review URL: https://codereview.chromium.org/15239002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235462 0039d316-1c4b-4281-b951-d872f2087c98
* Enable permission warnings from ManifestHandlers.rpaquay@chromium.org2013-11-151-1/+3
| | | | | | | | BUG=293755,247857 Review URL: https://codereview.chromium.org/51433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235332 0039d316-1c4b-4281-b951-d872f2087c98
* Move PermissionSet to top-level extensions.yoz@chromium.org2013-10-291-1/+1
| | | | | | | | | BUG=310171 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/42723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231470 0039d316-1c4b-4281-b951-d872f2087c98
* Move APIPermission, APIPermissionSet, PermissionsInfo to top-level extensions.yoz@chromium.org2013-10-081-1/+1
| | | | | | | | | BUG=298586 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/26024004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227409 0039d316-1c4b-4281-b951-d872f2087c98
* sync: Add GetAllSyncData to sync/apitim@chromium.org2013-09-051-0/+5
| | | | | | | | | | | | | | | | | | | | This allows datatype SyncableServices to request a fresh copy of the data that was previously only passed over in batch form during MergeDataAndStartSyncing. Since it can be slow, it should be used sparingly. Though currently unused, Sessions will soon need this behavior to deal with cases where (e.g) the local session is deleted by a foreign client, thereby corrupting TabNodePool tracking and requiring a full re-association. TBR=zea@chromium.org ^Many function signature touchups under browser/ BUG=98892 Review URL: https://codereview.chromium.org/23129007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221540 0039d316-1c4b-4281-b951-d872f2087c98
* Rename extension_manifest_keys namespace to extensions::manifest_keys.yoz@chromium.org2013-08-151-5/+5
| | | | | | | | | | | | | Move it to extensions/common/manifest_constants.cc. Minorly improve packaged app + manifest version 1 error message. BUG=162530 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/22794012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217709 0039d316-1c4b-4281-b951-d872f2087c98
* sync: Add remote modification time to SyncData.tim@chromium.org2013-07-151-4/+6
| | | | | | | | | | | | | | | | | This is required for building session sync on top of Sync API. TBR=zea@chromium.org ^ themes OWNERS ^ history OWNERS ^ managed_mode OWNERS BUG=98892, 80194 Review URL: https://codereview.chromium.org/18873006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211722 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Add support for sync Persistence Errorszea@chromium.org2013-07-021-2/+3
| | | | | | | | | | | | | | Persistence errors are those detected by the native model's transaction version being newer than sync's. They currently have no effect beyond a normal association error, but will eventually result in delayed association after a sync update. BUG=239828 TBR=atwilson@chromium.org, sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/15701022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209810 0039d316-1c4b-4281-b951-d872f2087c98
* Change ApiResourceManager to use ProfileKeyedApi.patrickriordan177@gmail.com2013-06-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This also finishes SocketUnitTest.Create and fixes the includes for files that were dependent on the includes from api_resource_manager.h BUG=179951 TBR=estade@chromium.org chrome/browser/media_galleries/media_file_system_registry_unittest.cc chrome/browser/renderer_host/pepper/pepper_crx_file_system_message_filter.cc For transitive include and using fix. TBR=yoshiki@chromium.org chrome/browser/task_manager/extension_process_resource_provider.cc For transitive include fix. TBR=pkotwicz@chromium.org chrome/browser/task_manager/extension_process_resource_provider.cc For transitive using fix. TBR=ben@chromium.org chrome/browser/ui/* For transitive include and using fix. TBR=achuith@chromium.org chrome/browser/chromeos/* For transitive include and using fix. Review URL: https://chromiumcodereview.appspot.com/15917015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206783 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"rsleevi@chromium.org2013-06-031-9/+12
| | | | | | | | | | | Linux fixes, Part 4 of N BUG=110610 TBR=darin Review URL: https://chromiumcodereview.appspot.com/16290004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203648 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Use base::MessageLoop. (Part 3)xhwang@chromium.org2013-05-281-2/+2
| | | | | | | | | | | | This CL updates chrome/browser/* other than chrome/browser/ui which is in another CL. BUG=236029 TBR=brettw Review URL: https://chromiumcodereview.appspot.com/14113053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202664 0039d316-1c4b-4281-b951-d872f2087c98
* Remove references to Profile from browser_context_keyed_service.phajdan.jr@chromium.org2013-05-221-1/+2
| | | | | | | | | BUG=227219 R=joi@chromium.org Review URL: https://codereview.chromium.org/15517005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201634 0039d316-1c4b-4281-b951-d872f2087c98
* [components] Switch {RefCounted}ProfileKeyedService to use BrowserContextphajdan.jr@chromium.org2013-04-261-1/+1
| | | | | | | | | | instead of Profile. This will help move it out of chrome. BUG=227219 Review URL: https://codereview.chromium.org/14141006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196777 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly construct/destruct UserManager and dependencies in testsbartfab@chromium.org2013-04-241-0/+12
| | | | | | | | | | | | | | | | | | | | | | | The ScopedTestUserManager initializes and subsequently tears down the UserManager singleton only if it has not been initialized already. This allows ScopedTestUserManagers to be nested but also means that it is never clear which ScopedTestUserManager actually did end up initializing the singleton. The same goes for ScopedTestCrosSettings. This CL makes the initialization and teardown explicit. The helper classes now explicitly manage the initialization and teardown of their respective singletons and cannot be nested anymore. BUG=None For tests that need to instantiate a UserManager: TBR=sky,rkc,aa,thestig,asvitkine,davemoore,kinuko,pkotwicz,davemoore,akalin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195811 Review URL: https://chromiumcodereview.appspot.com/14192040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195951 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 195811 "Explicitly construct/destruct UserManager and dep..."kalman@chromium.org2013-04-231-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | > Explicitly construct/destruct UserManager and dependencies in tests > > The ScopedTestUserManager initializes and subsequently tears down the > UserManager singleton only if it has not been initialized already. This > allows ScopedTestUserManagers to be nested but also means that it is > never clear which ScopedTestUserManager actually did end up initializing > the singleton. The same goes for ScopedTestCrosSettings. > > This CL makes the initialization and teardown explicit. The helper classes > now explicitly manage the initialization and teardown of their respective > singletons and cannot be nested anymore. > > BUG=None > > For tests that need to instantiate a UserManager: > TBR=sky,rkc,aa,thestig,asvitkine,davemoore,kinuko,pkotwicz,davemoore,akalin > > Review URL: https://codereview.chromium.org/14192040 TBR=bartfab@google.com Review URL: https://codereview.chromium.org/14436007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195821 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly construct/destruct UserManager and dependencies in testsbartfab@google.com2013-04-231-0/+8
| | | | | | | | | | | | | | | | | | | | | The ScopedTestUserManager initializes and subsequently tears down the UserManager singleton only if it has not been initialized already. This allows ScopedTestUserManagers to be nested but also means that it is never clear which ScopedTestUserManager actually did end up initializing the singleton. The same goes for ScopedTestCrosSettings. This CL makes the initialization and teardown explicit. The helper classes now explicitly manage the initialization and teardown of their respective singletons and cannot be nested anymore. BUG=None For tests that need to instantiate a UserManager: TBR=sky,rkc,aa,thestig,asvitkine,davemoore,kinuko,pkotwicz,davemoore,akalin Review URL: https://codereview.chromium.org/14192040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195811 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-091-1/+1
| | | | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020 Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Rewrite std::string("") to std::string(), Linux edition."dcheng@chromium.org2013-04-091-1/+1
| | | | | | | | | | | | | | This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6. Revert "Fix build after r193020." This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a. Revert "Really fix build after r193020." This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-091-1/+1
| | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
* No longer sync themes that are installed by policy.atwilson@chromium.org2013-03-151-2/+35
| | | | | | | | | | | | ThemeSyncableService now checks IsSyncable() on custom themes before trying to sync them. BUG=175755 Review URL: https://chromiumcodereview.appspot.com/12328148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188399 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_path.h to base/files.brettw@chromium.org2013-02-241-3/+3
| | | | | | TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
* Merge branch 'master' into file_path_browserbrettw@chromium.org2013-02-101-8/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | version control markers Merge branch 'master' into file_path_browser remove version control Fix typo Merge branch 'master' into file_path_browser Conflicts: chrome/browser/intents/native_services_browsertest.cc chrome/browser/ui/intents/native_file_picker_service.cc Merge branch 'master' into file_path_browser Conflicts: chrome/browser/chromeos/drive/drive_file_system.cc chrome/browser/chromeos/drive/drive_file_system.h chrome/browser/chromeos/drive/drive_file_system_interface.h chrome/browser/chromeos/drive/drive_file_system_unittest.cc chrome/browser/chromeos/drive/file_system/drive_operations.cc chrome/browser/chromeos/login/wallpaper_manager.cc chrome/browser/chromeos/login/wallpaper_manager.h chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc chrome/browser/google_apis/gdata_wapi_operations.cc chrome/browser/google_apis/gdata_wapi_operations.h chrome/browser/google_apis/gdata_wapi_operations_unittest.cc chrome/browser/profiles/off_the_record_profile_impl.cc chrome/browser/profiles/off_the_record_profile_impl.h chrome/browser/profiles/profile_impl.cc chrome/browser/profiles/profile_impl.h chrome/browser/profiles/profile_impl_io_data.cc chrome/browser/profiles/profile_impl_io_data.h chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc chrome/browser/ui/webui/options/manage_profile_handler.cc Long lines long lines some long lines. long lines long lines Beginning of lines. Rename FilePath -> base::FilePath in chrome/browser git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181638 0039d316-1c4b-4281-b951-d872f2087c98
* Linux/ChromeOS Chromium style checker cleanup, chrome/browser edition.rsleevi@chromium.org2013-02-071-1/+1
| | | | | | | | | | | Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 Review URL: https://codereview.chromium.org/12212048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181164 0039d316-1c4b-4281-b951-d872f2087c98
* Move Extension Location and Type enums to Manifest, and move InstallWarning ↵yoz@chromium.org2013-01-311-1/+1
| | | | | | | | | | | | | | | to its own file. Reverses the dependency between Extension and Manifest. Part 1 of moving Manifest to top-level extensions. BUG=162530 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/12093036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179828 0039d316-1c4b-4281-b951-d872f2087c98
* Move the parsing of 'update_url' & 'options_page' URLs out of Extension.MHX348@motorola.com2013-01-151-3/+4
| | | | | | | | | | | | | This CL follows https://codereview.chromium.org/11624036/ Patch from Joe Thomas <mhx348@motorola.com>. BUG=159265 Review URL: https://chromiumcodereview.appspot.com/11726002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176824 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Have MergeDataAndStartSyncing return a SyncMergeResultzea@chromium.org2012-11-171-11/+22
| | | | | | | | | | | | This will allow us to track merge statistics for datatypes. For now none of the datatypes fill the SyncMergeResult with anything other than an error. BUG=158576 TBR=stevet@chromium.org Review URL: https://chromiumcodereview.appspot.com/11365241 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168446 0039d316-1c4b-4281-b951-d872f2087c98
* chrome/browser: Update calls from RunAllPending() to RunUntilIdle().tfarina@chromium.org2012-11-171-2/+2
| | | | | | | | | | | | RunAllPending() is deprecated and we should switch to RunUntilIdle(). BUG=131220 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/11413050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168416 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in ThemeSyncableServiceTest.haitaol@chromium.org2012-10-021-4/+12
| | | | | | | | | | | | | | During profile shutdown, destruction of cache objects in SettingsFrontend is deferred to file thread. So add a file thread on existing message loop to catch those deletions. In test tear down, run all pending tasks of message loop to release the memory of those cache objects. BUG=145705 Review URL: https://chromiumcodereview.appspot.com/10993092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159760 0039d316-1c4b-4281-b951-d872f2087c98
* Convert theme syncing to use syncable service API.haitaol@chromium.org2012-09-281-0/+552
This change removes the theme-specific classes (processor, controller, associator, etc) under browser/sync and convert theme syncing to use the new syncable service API implemented by ThemeSyncableService under browser/themes. BUG=152341 Review URL: https://chromiumcodereview.appspot.com/10911316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159304 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 07:00:51 +0000