summaryrefslogtreecommitdiffstats
path: root/chrome/browser/translate
Commit message (Collapse)AuthorAgeFilesLines
...
* Convert URLFetcher::Delegates to use an interface in content/public/common. ↵jam@chromium.org2011-10-243-27/+24
| | | | | | | | Also remove the old URLFetcher delegate callback while I'm touching all of them.BUG=98716,83592 Review URL: http://codereview.chromium.org/8373021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106949 0039d316-1c4b-4281-b951-d872f2087c98
* Make NotificationService an interface in the content namespace, and switch ↵jam@chromium.org2011-10-192-7/+7
| | | | | | | | | callers to use it. Move the implementation to content/browser. Stop creating it in all child processes since it's only used in the browser. BUG=98716 Review URL: http://codereview.chromium.org/8342048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106403 0039d316-1c4b-4281-b951-d872f2087c98
* Move NotificationObserver, NotificationSource, and NotificationDetails to ↵jam@chromium.org2011-10-194-43/+49
| | | | | | | | | | | content/public/browser. This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header. BUG=98716 TBR=joi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
* Move navigation_types.h from content/common to content/public/browser, and ↵jam@chromium.org2011-10-182-3/+3
| | | | | | | | | | | put it in the content namespace. There was no reason for it to be in common since it's only used by browser. I also updated the enum names to match the rest of the enums in the Content API. BUG=98716 TBR=joi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106029 Review URL: http://codereview.chromium.org/8339006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106070 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 106029nkostylev@chromium.org2011-10-182-3/+3
| | | | | | | | | | | | | | | Broke http://build.chromium.org/p/chromium.perf/console Move navigation_types.h from content/common to content/public/browser, and put it in the content namespace. There was no reason for it to be in common since it's only used by browser. I also updated the enum names to match the rest of the enums in the Content API. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8339006 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/8333018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106054 0039d316-1c4b-4281-b951-d872f2087c98
* Move navigation_types.h from content/common to content/public/browser, and ↵jam@chromium.org2011-10-182-3/+3
| | | | | | | | | | put it in the content namespace. There was no reason for it to be in common since it's only used by browser. I also updated the enum names to match the rest of the enums in the Content API. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8339006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106029 0039d316-1c4b-4281-b951-d872f2087c98
* Move content_notification_types.h from content\common to ↵jam@chromium.org2011-10-181-1/+1
| | | | | | | | | content\public\browser. I dropped the "content" from the name to match other files whose chrome version adds a "chrome_" prefix. I also moved it to the browser directory since notifications are only used in the browser process. I will move the other notification files in future changes. BUG=98716 Review URL: http://codereview.chromium.org/8331001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106028 0039d316-1c4b-4281-b951-d872f2087c98
* Move PageTransition into content namespace. While I'm touching all these ↵jam@chromium.org2011-10-133-6/+7
| | | | | | | | | files, I've also updated it to use the enum naming convention in the Content API. BUG=98716 Review URL: http://codereview.chromium.org/8253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105254 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing deprecated NewRunnableMethod() calls converting them over to ↵mad@chromium.org2011-10-122-6/+9
| | | | | | | | | | | base::Bind(). BUG=None TEST=All your test are belong to us! :-) Review URL: http://codereview.chromium.org/8144006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105009 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the error reporting option for secured URL.mad@chromium.org2011-10-032-0/+14
| | | | | | | | | | | When there is a translate error, we should not let users report them because the report includes the sercured URL which would get compromised. BUG=98441 TEST=Make sure the option is always disabled for secured (httpS) urls, and always enabled otherwise... Review URL: http://codereview.chromium.org/8086025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103768 0039d316-1c4b-4281-b951-d872f2087c98
* Move infobar handling to a tab helper.avi@chromium.org2011-09-305-51/+87
| | | | | | | | | | | | | | Part 2: - Removed TabContentsWrapper from core infobar classes - Made InfoBarTabHelper the owner of the infobar delegates - Removed all owner references from the delegate subclasses BUG=94741 TEST=no visible change Review URL: http://codereview.chromium.org/7862003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103463 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 103459 - Disable the error reporting option for secured URL.backer@chromium.org2011-09-302-8/+0
| | | | | | | | | | | | | When there is a translate error, we should not let users report them because the report includes the sercured URL which would get compromised. BUG=98441 TEST=Make sure the option is always disabled for secured (httpS) urls, and always enabled otherwise... Review URL: http://codereview.chromium.org/8080007 TBR=mad@chromium.org Review URL: http://codereview.chromium.org/8086024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103460 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the error reporting option for secured URL.mad@chromium.org2011-09-302-0/+8
| | | | | | | | | | When there is a translate error, we should not let users report them because the report includes the sercured URL which would get compromised. BUG=98441 TEST=Make sure the option is always disabled for secured (httpS) urls, and always enabled otherwise... Review URL: http://codereview.chromium.org/8080007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103459 0039d316-1c4b-4281-b951-d872f2087c98
* Add ChromeRenderViewHostTestHarness to get rid of the dependency from RVHTH ↵jochen@chromium.org2011-09-141-8/+7
| | | | | | | | | | | to profile BUG=90443 TEST=everything still works Review URL: http://codereview.chromium.org/7892007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101037 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLFetcher from content/common to content/common/net.willchan@chromium.org2011-09-131-1/+1
| | | | | | | | | | | | | Add a OWNERS for content/common/net BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100828 Review URL: http://codereview.chromium.org/7875006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100857 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux Views build breakage.willchan@chromium.org2011-09-131-1/+1
| | | | | | | | | | | | | | | | Revert 100828 - Move URLFetcher from content/common to content/common/net. Add a OWNERS for content/common/net BUG=none TEST=none Review URL: http://codereview.chromium.org/7875006 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/7884003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100829 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLFetcher from content/common to content/common/net.willchan@chromium.org2011-09-131-1/+1
| | | | | | | | | | | Add a OWNERS for content/common/net BUG=none TEST=none Review URL: http://codereview.chromium.org/7875006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100828 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant LoadURLWithHeaders method.rogerta@chromium.org2011-09-101-1/+2
| | | | | | | | | BUG=None TEST=No user visible or functional change. Review URL: http://codereview.chromium.org/7847023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100573 0039d316-1c4b-4281-b951-d872f2087c98
* Move infobar handling to a tab helper, part 1.avi@chromium.org2011-09-012-16/+24
| | | | | | | | | | | | | | | | | | Revert revert of r99187. This reverts r99198. BUG=94741 TEST=no visible change Review URL: http://codereview.chromium.org/7810002 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/7827017 Review URL: http://codereview.chromium.org/7826014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99222 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 99187 (speculative revert for ↵thakis@chromium.org2011-09-012-24/+16
| | | | | | | | | | | | | | | | ProfileSyncServiceSessionTest.FailModelAssociation on 10.5) - Move infobar handling to a tab helper, part 1. BUG=94741 TEST=no visible change Review URL: http://codereview.chromium.org/7810002 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/7827017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99198 0039d316-1c4b-4281-b951-d872f2087c98
* Move infobar handling to a tab helper, part 1.avi@chromium.org2011-09-012-16/+24
| | | | | | | | | BUG=94741 TEST=no visible change Review URL: http://codereview.chromium.org/7810002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99187 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash caused by unknown saved language.mad@chromium.org2011-08-292-2/+9
| | | | | | | | | | | | | The language index in the dump referred by the crbug is left to -1, meaning that the language passed to TranslateInfoBarDelegate's constructor... The call stack showed that the call came from an auto translate preference, so my only guess would be that a preference was saved for a language that is not available anymore, so I added code to protect against that. BUG=93291 TEST=TranslateManagerTest.UnsupportedSavedLanguage Review URL: http://codereview.chromium.org/7764003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98661 0039d316-1c4b-4281-b951-d872f2087c98
* Switch ChromeTestSuite to the same convention as ContentTestSuite:phajdan.jr@chromium.org2011-08-271-7/+5
| | | | | | | | | | | | | | | | | the test suite implicitly provides global resources for each test, but they're re-initialized between each test. The performance overhead is negligible. We need that to continue moving tests from unit_tests to content_unittests. Because of shared test fixtures the test suites need to be compatible. BUG=90443 Review URL: http://codereview.chromium.org/7744039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98526 0039d316-1c4b-4281-b951-d872f2087c98
* Prefix all IPC messages used by src\chrome with Chrome. For e.g ↵ananta@chromium.org2011-08-193-35/+38
| | | | | | | | | | | | | | | ChromeViewMsg_, ChromeViewHostMsg, etc. This makes it easier to identify which messages are specific to content and chrome. This is a preparation CL for bug http://code.google.com/p/chromium/issues/detail?id=87335 which requires IPC's to not span across content and chrome. When IPC's cross these boundaries they need to be handled as API calls. BUG=87335 Review URL: http://codereview.chromium.org/7631063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97536 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed crash on TranslateManager with multiple profiles.joaodasilva@chromium.org2011-08-182-8/+19
| | | | | | | | | | BUG=93363 TEST=See bug description. Review URL: http://codereview.chromium.org/7669051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97336 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: base/scoped_ptr.h -> base/memory/scoped_ptr.h. (part 4)thestig@chromium.org2011-08-181-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7670016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97286 0039d316-1c4b-4281-b951-d872f2087c98
* base: Fix the TODO in ListValue::Remove().tfarina@chromium.org2011-08-131-1/+1
| | | | | | | | | | | | | Change the return type of Remove() to bool, and add a size_t output parameter. BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7618021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96702 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize chrome/test, part #9phajdan.jr@chromium.org2011-08-111-1/+1
| | | | | | | | | TBR=jcivelli BUG=90905 Review URL: http://codereview.chromium.org/7616019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96453 0039d316-1c4b-4281-b951-d872f2087c98
* Make the TranslateManager listen for the destruction of the right profile.joaodasilva@chromium.org2011-08-111-1/+2
| | | | | | | | | | BUG=92307 TEST=Steps described in the bug should not crash a debug build of chromium. Review URL: http://codereview.chromium.org/7608024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96378 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in the translate info bar.mad@chromium.org2011-08-104-24/+29
| | | | | | | | | | A language from the accepted list was converted before being validated, but the unconverted version was returned. BUG=90106 Review URL: http://codereview.chromium.org/7589002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96125 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build after http://codereview.chromium.org/7537031/phajdan.jr@chromium.org2011-08-011-1/+0
| | | | | | | | | | | | We were using too many ScopedTestingBrowserProcesses at once. TBR=sky BUG=61062 Review URL: http://codereview.chromium.org/7453061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95002 0039d316-1c4b-4281-b951-d872f2087c98
* Move more files from chrome/test to chrome/test/base, part #4phajdan.jr@chromium.org2011-08-011-1/+1
| | | | | | | BUG=90905 Review URL: http://codereview.chromium.org/7544021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94963 0039d316-1c4b-4281-b951-d872f2087c98
* Removal of Profile from content part 5.avi@chromium.org2011-08-011-16/+23
| | | | | | | | | BUG=76788 TEST=no change visible Review URL: http://codereview.chromium.org/7523054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94907 0039d316-1c4b-4281-b951-d872f2087c98
* Removal of Profile from content part 4.avi@chromium.org2011-08-013-12/+17
| | | | | | | | | BUG=76788 TEST=no change visible Review URL: http://codereview.chromium.org/7531004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94901 0039d316-1c4b-4281-b951-d872f2087c98
* Add a scoper object for URLFetcher::Factoryphajdan.jr@chromium.org2011-07-291-5/+1
| | | | | | | | | | This should make it much safer to use (i.e. memory-safe). BUG=90585 Review URL: http://codereview.chromium.org/7524033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94694 0039d316-1c4b-4281-b951-d872f2087c98
* Keep a pointer to the owning TabContents on InfoBarDelegates, clearing it ↵pkasting@chromium.org2011-07-281-8/+4
| | | | | | | | | | | | | | when they're no longer owned, so that if they wish to close themselves they can do so safely. This is a temporary fix for bug 89915 to replace http://codereview.chromium.org/7466019/ , which is IMO the slightly better fix, and is how I'll be fixing this bug in the future when the ownership model of infobars changes. This also cleans up the names of a few other RemoveInfoBar() functions so there aren't so many different functions named the same thing. BUG=89915 TEST=none Review URL: http://codereview.chromium.org/7471047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94515 0039d316-1c4b-4281-b951-d872f2087c98
* Put TestRenderViewContextMenus in an anonymous namespace.koz@chromium.org2011-07-211-0/+4
| | | | | | | | | TEST=affected unit tests Review URL: http://codereview.chromium.org/7281003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93349 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate Profile::GetDefaultRequestContext().willchan@chromium.org2011-07-201-3/+3
| | | | | | | | | | | | Make it private and establish a friend whitelist for existing users. BUG=64339 TEST=none Review URL: http://codereview.chromium.org/7438002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93200 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/values.h into the base namespace. This includes a cros DEPS rolldmazzoni@chromium.org2011-07-121-4/+7
| | | | | | | | | | with a minor change to that code since libcros also uses base/values.h. BUG=88666 TEST=none Review URL: http://codereview.chromium.org/7259019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92208 0039d316-1c4b-4281-b951-d872f2087c98
* GetTargetLanguage() returns the UI language if it's supported by thedfilimon@google.com2011-07-123-9/+51
| | | | | | | | | | | | | | | | | | translation service or the first supported language in the accepted languages list. If there is no such language, returns "". BUG=37328 TEST=1. browser_tests: TranslateManagerTest.TranslateAcceptLanguage and TranslateManagerTest.UnsupportedUILanguag 2. a. Start Chrome in the UI language that's unsupported by the translation service (like Amharic). On Windows, "chrome --lang=am". On Linux, 'LANGUAGE=am chrome' with Amharic locale installed. b. add a language supported by the translation service to the Accept-Languages list (e.g Italian and Spanish). c. When navigating to a page in a third language (e.g. French), it should offer to translate to the first supported language in the Accept-Language list (Italian in the scenario). Contributed by dfilimon@google.com Review URL: http://codereview.chromium.org/7327008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92162 0039d316-1c4b-4281-b951-d872f2087c98
* Moving notification types which are chrome specific to a new header file ↵ananta@chromium.org2011-07-104-25/+29
| | | | | | | | | | | | | chrome_notification_types.h. This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END which defines the end of the enum used by content to define notification types. The notificaton_type.h file in content\common has been renamed to content_notification_types.h BUG=76698 Review URL: http://codereview.chromium.org/7327007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
* Usage fixes per Coverity. Add checks for tab contents wrapper, profile check,gbillock@chromium.org2011-07-081-2/+14
| | | | | | | | | | | | | | return values. Update download manager callsite to take const ref. Update request handle objects to reflect const-ness. Coverity CID=17238,16334,8852,12877 BUG= TEST= Review URL: http://codereview.chromium.org/7218016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91903 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r89864. Hopefully this won't trigger the apparent perf regression ↵abarth@chromium.org2011-07-081-1/+1
| | | | | | now that we've tweaked things. If it does, I'll continue to investigate. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91811 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 89864 - Don't rely on user gestures for deciding when to dismiss ↵cmp@chromium.org2011-07-071-1/+1
| | | | | | | | | | | | | | | | | | | | infobars. Previously, we looked at the user gesture state when deciding whether to dismiss infobars. Now that WebKit's user gesture state doesn't lie, we can tell that this behavior is incorrect. Page-specific infobars, like translate, should close whenever the main frame navigates to a new page, regardless of whether that navigation was conducted from a user gesture. BUG=86417 Review URL: http://codereview.chromium.org/7205026 TBR=abarth@chromium.org Review URL: http://codereview.chromium.org/7324001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91744 0039d316-1c4b-4281-b951-d872f2087c98
* Add typedefs for InfoBar-related notifications in infobar.h, so that code ↵pkasting@chromium.org2011-07-011-2/+2
| | | | | | | | | | | | elsewhere doesn't have to constantly redefine them, and so we can change them later and know that we've caught all places. These will eventually move inside the InfoBar class. BUG=none TEST=none Review URL: http://codereview.chromium.org/7292016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91322 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a few valgrind tests by not assuming the UrlFetcher arrives with the ↵cbentzel@chromium.org2011-06-252-43/+47
| | | | | | | | | | same URL. BUG=87237 Review URL: http://codereview.chromium.org/7246010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90463 0039d316-1c4b-4281-b951-d872f2087c98
* Get the list of supported languages from the translate server.mad@chromium.org2011-06-213-67/+280
| | | | | | | | | BUG=35475 TEST=Make sure that we can translate to and from all languages supported by the translate server. Review URL: http://codereview.chromium.org/7171002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89892 0039d316-1c4b-4281-b951-d872f2087c98
* Don't rely on user gestures for deciding when to dismiss infobars.abarth@chromium.org2011-06-211-1/+1
| | | | | | | | | | | | | | Previously, we looked at the user gesture state when deciding whether to dismiss infobars. Now that WebKit's user gesture state doesn't lie, we can tell that this behavior is incorrect. Page-specific infobars, like translate, should close whenever the main frame navigates to a new page, regardless of whether that navigation was conducted from a user gesture. BUG=86417 Review URL: http://codereview.chromium.org/7205026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89864 0039d316-1c4b-4281-b951-d872f2087c98
* Change BrowserList::GetLastActive to respect the profile.mirandac@chromium.org2011-06-171-1/+2
| | | | | | | | | BUG=86361 TEST=translate manager tests still work. Review URL: http://codereview.chromium.org/7205005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89531 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 88553 - Revert 88510 - Escaping file names correctly. Also fixed a ↵thestig@chromium.org2011-06-141-1/+1
| | | | | | | | | | | | | | | | | | | | crush in chromeos debug build while saving a web page. This change broke the official CrOS builder. I'll forward the error separately. BUG=chromium-os:13130 TEST=Save a file with special characters like '#', '&', '"'. Review URL: http://codereview.chromium.org/7057053 TBR=serya@chromium.org Review URL: http://codereview.chromium.org/7046077 TBR=ericu@google.com Review URL: http://codereview.chromium.org/7145014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88934 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 18:40:28 +0000