summaryrefslogtreecommitdiffstats
path: root/chrome/browser/translate
Commit message (Collapse)AuthorAgeFilesLines
* Merge 120113 - When translating a page, get the code and translation via HTTPS.palmer@chromium.org2012-02-071-2/+3
| | | | | | | | | | | | | | | | For some reason, the error reporting page doesn't work over HTTPS yet. That's a separate bug, and when it is fixed we'll fix the last http: URL in this file. BUG=112236 TEST=browser_tests: TranslateManagerTest.*; translation still works, and reporting a translation error still works Review URL: http://codereview.chromium.org/9320015 TBR=palmer@chromium.org Review URL: https://chromiumcodereview.appspot.com/9364001 git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120863 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of help center URLs.derat@chromium.org2012-01-291-17/+4
| | | | | | | | | | | | | | | This updates the first wave of links from https://www.google.com/support/chrome paths to https://support.google.com/chrome. We also don't need locale parameters on these links. BUG=111556 TEST=manual TBR=dhollowa Review URL: http://codereview.chromium.org/9234077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119635 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old (pre-webkit) compositorpiman@chromium.org2012-01-271-11/+2
| | | | | | | | | BUG=103948 TEST=builds, tests pass Review URL: http://codereview.chromium.org/9288053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119402 0039d316-1c4b-4281-b951-d872f2087c98
* Convert use of int ms to TimeDelta in files owned by brettw.tedvessenes@gmail.com2012-01-272-5/+8
| | | | | | | | | | BUG=108171 TEST= Review URL: http://codereview.chromium.org/9233018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119321 0039d316-1c4b-4281-b951-d872f2087c98
* There are some application locale which can't be used as a target language ↵mad@chromium.org2012-01-241-2/+9
| | | | | | | | | | | | | for translation... And this is the cause of some crashes... BUG=47807 TEST=Make sure that none of the application languages for which we don't support translating to don't enable the translate context menu option. Review URL: http://codereview.chromium.org/9212035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118880 0039d316-1c4b-4281-b951-d872f2087c98
* Adding Language code synonyms to support new and old versions of changed codes.mad@chromium.org2012-01-173-8/+108
| | | | | | | | | BUG=94883 TEST=Make sure translate works for alternate language codes like 'iw' VS 'he' and 'no' VS 'nb' Review URL: http://codereview.chromium.org/9221007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117963 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 117824 - Convert use of int ms to TimeDelta in files owned by brettw.hbono@chromium.org2012-01-162-9/+7
| | | | | | | | | | | | | | | | | | | | This change broke Linux and Mac bots. I would recommend to ask committers to run your next change on trybots. (*1) http://chromegw.corp.google.com/i/chromium/builders/Mac/builds/10788/steps/compile/logs/stdio (*2) http://chromegw.corp.google.com/i/chromium/builders/Linux/builds/19313/steps/compile/logs/stdio (*3) http://chromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/21385/steps/compile/logs/stdio R=brettw@chromium.org BUG=108171 TEST= Review URL: http://codereview.chromium.org/9185026 TBR=tedvessenes@gmail.com Review URL: http://codereview.chromium.org/9215005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117825 0039d316-1c4b-4281-b951-d872f2087c98
* Convert use of int ms to TimeDelta in files owned by brettw.tedvessenes@gmail.com2012-01-162-7/+9
| | | | | | | | | | | R=brettw@chromium.org BUG=108171 TEST= Review URL: http://codereview.chromium.org/9185026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117824 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a bunch of tab_contents.h includes from chrome. These are all ↵jam@chromium.org2012-01-043-6/+6
| | | | | | | | | trivial changes to use WebContents instead of TabContents. BUG=98716 Review URL: http://codereview.chromium.org/9030032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116392 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of content::NavigationController in cc file and use "using" instead.jam@chromium.org2012-01-042-3/+5
| | | | | | | | BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8983012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116328 0039d316-1c4b-4281-b951-d872f2087c98
* Convert WebContents to return a content::NavigationController instead of the ↵jam@chromium.org2012-01-042-3/+3
| | | | | | | | | | implementation. Update all the headers in chrome to use the interface only. In a subsequent cl, I'll rename the implementation to NavigationControllerImpl and also get rid of content::NavigationController everywhere. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8983010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116244 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the remaining Browser::GetSelectedTabContents() calls to ↵jam@chromium.org2012-01-031-5/+6
| | | | | | | | | | GetSelectedWebContents, and update all dependent code. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9074012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116226 0039d316-1c4b-4281-b951-d872f2087c98
* Convert all the notifications which use NavigationController to ↵jam@chromium.org2012-01-032-3/+3
| | | | | | | | | | content::NavigationController. After this is done, we can then make WebContents return a content::NavigationEntry instead of the impl. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9016047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116150 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome users of NavigationController::tab_contents() to use ↵jam@chromium.org2012-01-021-6/+8
| | | | | | | | | | GetWebContents() instead. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8986009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116086 0039d316-1c4b-4281-b951-d872f2087c98
* Create a Content API interface around NavigationController, and move all the ↵jam@chromium.org2011-12-291-0/+1
| | | | | | | | | | methods used by chrome code to it. BUG=98716 TBR=brettw Review URL: http://codereview.chromium.org/8989071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115946 0039d316-1c4b-4281-b951-d872f2087c98
* Rename NavigationController to NavigationControllerImpl and put it into the ↵jam@chromium.org2011-12-283-10/+12
| | | | | | | | | | content namespace. Also make all users of content::NavigationController interface use the "using" keyword so they don't have to put content:: everywhere (similar to other Content API and WebKit API classes). BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8956059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115916 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a few methods in NavigationController to return a ↵jam@chromium.org2011-12-284-12/+14
| | | | | | | | | | content::NavigationEntry, in preparation for creating an interface around NavigationController. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9008034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115872 0039d316-1c4b-4281-b951-d872f2087c98
* Move the PageNavigator interface and GlobalRequestID struct to ↵jam@chromium.org2011-12-281-3/+6
| | | | | | | | | | content\public and put them in the content namespace. Make PageNavigator use WebContents instead of TabContents. While I'm touching all the callers, I've removed the deprecated PageNavigator function and converted users to the new one. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8991012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115858 0039d316-1c4b-4281-b951-d872f2087c98
* Move FaviconStatus and SSLStatus out of NavigationEntry into their own files ↵jam@chromium.org2011-12-273-0/+3
| | | | | | | | | in content/public and in the content namespace. I've also made them structs instead of classes. This was because I didn't want to wrap them with Content API for what were really a collection of member variables. The one exception was SSLStatus::content_status which had helper functions around it to set and get the bitfield. Each of the two setter helpers were only called in one non-test code, and read in a few places, so I just converted them to do it directly. BUG=98716 Review URL: http://codereview.chromium.org/9048002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115847 0039d316-1c4b-4281-b951-d872f2087c98
* Remove PrefService::ScheduleSavePersistentPrefs and change ↵bauerb@chromium.org2011-12-271-21/+8
| | | | | | | | | | | | | SavePersistentPrefs calls to CommitPendingWrites. TBR=ncarter@chromium.org BUG=99306 TEST=none Review URL: http://codereview.chromium.org/8198007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115829 0039d316-1c4b-4281-b951-d872f2087c98
* Move most of the remaining users of WebContentsObserver::tab_contents() to ↵jam@chromium.org2011-12-263-13/+16
| | | | | | | | | | use web_contents(). BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9030010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115800 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a bunch of WebContentsObservers to use web_contents() instead of ↵jam@chromium.org2011-12-254-43/+52
| | | | | | | | | | tab_contents(), as well as all the dependent code. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8982008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115777 0039d316-1c4b-4281-b951-d872f2087c98
* Create a Content API around NavigationEntry that's in ↵jam@chromium.org2011-12-254-11/+11
| | | | | | | | | | content/public/browser. NavigationEntry will be renamed to NavigationEntryImpl in a later change. It now derives from content::NavigationEntry. Most of this change is changing unix_hacker functions to CamelCase and updating callers. BUG=98716 TBR=brettw Review URL: http://codereview.chromium.org/9007043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115766 0039d316-1c4b-4281-b951-d872f2087c98
* Move TabContentsObserver to content/public, rename it to ↵jam@chromium.org2011-12-222-4/+4
| | | | | | | | | | WebContentsObserver, and put it into the content namespace. BUG=98716 TBR=tburkard Review URL: http://codereview.chromium.org/9026011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115599 0039d316-1c4b-4281-b951-d872f2087c98
* Move navigation_details.h to content/public/browser.jam@chromium.org2011-12-223-3/+3
| | | | | | | BUG=98716 Review URL: http://codereview.chromium.org/8949066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115498 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::browser_context() to GetBrowserContext and put it into ↵jam@chromium.org2011-12-214-20/+29
| | | | | | | | | the WebContents interface. BUG=98716 Review URL: http://codereview.chromium.org/9021022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115435 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 115346. The change didn't break anything, the test was faulty. Will ↵jam@chromium.org2011-12-215-14/+14
| | | | | | | | | | | | | | | | | | | | disable in a followup. - Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_tests on win,linux,mac. Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 TBR=jam Review URL: http://codereview.chromium.org/9018016 TBR=thakis@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115428 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_teststhakis@chromium.org2011-12-215-14/+14
| | | | | | | | | | | | | | | | on win,linux,mac. Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 TBR=jam Review URL: http://codereview.chromium.org/9018016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115346 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::controller() to GetController and put it into the ↵jam@chromium.org2011-12-215-14/+14
| | | | | | | | | | WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115276 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::render_view_host() to GetRenderViewHost and put it into ↵jam@chromium.org2011-12-201-9/+8
| | | | | | | | | the WebContents interface. BUG=98716 Review URL: http://codereview.chromium.org/9007026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115200 0039d316-1c4b-4281-b951-d872f2087c98
* Fix TabRestoreServiceTest and TranslateManagerTest when using ↵piman@chromium.org2011-12-061-0/+15
| | | | | | | | | | | use_webkit_compositor=1 BUG=106157 TEST=browser_tests Review URL: http://codereview.chromium.org/8790012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113288 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of view_messages.h dependency in extension_messages_browsertest.cc ↵jam@chromium.org2011-12-051-1/+0
| | | | | | | | | by adding a method to MockRenderThread instead. BUG=98716 Review URL: http://codereview.chromium.org/8801001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112987 0039d316-1c4b-4281-b951-d872f2087c98
* Change NavigationController::LoadURL to take a Referrer class instead of a ↵jochen@chromium.org2011-12-051-1/+2
| | | | | | | | | | | GURL as referrer BUG=105028 TEST=no functional change Review URL: http://codereview.chromium.org/8785004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112968 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to IWYU for files that previously were getting a bunch ofjoi@chromium.org2011-12-011-0/+1
| | | | | | | | | | | header files via io_thread.h or browser_thread.h TBR=owners (previously approved on codereview 8477004) BUG=98716 Review URL: http://codereview.chromium.org/8746023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112455 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a bunch of view_messages.h includes from chrome by making the ↵jam@chromium.org2011-11-212-2/+2
| | | | | | | | | TabContentsObserver interface not use a struct from it. Instead, the interface uses a new struct, content::FrameNavigateParams, that's in the public directory. The IPC message's struct derives from it. BUG=98716 Review URL: http://codereview.chromium.org/8603015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110963 0039d316-1c4b-4281-b951-d872f2087c98
* Add OVERRIDE to chrome/browser/.avi@chromium.org2011-11-213-14/+16
| | | | | | | | | BUG=104314 TEST=no change Review URL: http://codereview.chromium.org/8614003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110940 0039d316-1c4b-4281-b951-d872f2087c98
* Define the public interface for content browser RenderProcessHost. This ↵ananta@chromium.org2011-11-181-2/+3
| | | | | | | | | | | | | | | interface is implemented by the RenderProcessHostImpl class which lives in content\browser\renderer_host\render_process_host_impl.cc/.h. The RenderProcessHostImpl class is a consolidation of the RenderProcessHost and BrowserRenderProcessHost classes. The RenderProcessHost public interface was created from the now deleted RenderProcessHost class defined in content\browser\renderer_host\render_process_host.h. Additional methods have been added to the interface to ensure that it works correctly with the MockRenderProcessHost class used by unit tests. I had to implement a number of overrides in the MockRenderProcessHost class to ensure that tests work correctly. This was because of assumptions in the tests that the MockRPH class was a real RPH which it was till now. Added a TODO for the methods which could potentially be removed from this interface. Will revisit that in a subsequent CL. BUG=98716 TEST=No change in functionality. Hopefully it all compiles and works. Review URL: http://codereview.chromium.org/8515027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110615 0039d316-1c4b-4281-b951-d872f2087c98
* Allow linker initialization of lazy instancejoth@chromium.org2011-11-151-1/+1
| | | | | | | | | | | | | | Using the initializer list construct = {0} allows the object to be linker initialized. Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design. Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile) BUG=94925 TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward. TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org Review URL: http://codereview.chromium.org/8491043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded forward declarations from various chrome/browser ↵thestig@chromium.org2011-11-151-3/+3
| | | | | | | | | | | subdirectories. BUG=none TEST=none Review URL: http://codereview.chromium.org/8539006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109987 0039d316-1c4b-4281-b951-d872f2087c98
* Switch BackgroundContents to use TabContents instead of RenderViewHost.jam@chromium.org2011-11-112-2/+2
| | | | | | | BUG=99698, 98934 Review URL: http://codereview.chromium.org/8469015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109661 0039d316-1c4b-4281-b951-d872f2087c98
* net: Move the last two Escape() functions into the net namespace.tfarina@chromium.org2011-11-091-3/+3
| | | | | | | | | | | BUG=64263 TEST=None R=willchan@chromium.org Review URL: http://codereview.chromium.org/8507011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109298 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in PageActionImageView when extensions are reloaded due to ↵finnur@chromium.org2011-11-081-0/+1
| | | | | | | | | | incognito settings changing. BUG=99736 TEST=Precise reproduction steps can be found in the bug description (first comment). Review URL: http://codereview.chromium.org/8333021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109011 0039d316-1c4b-4281-b951-d872f2087c98
* Remove needless include of the content/browser/render_process_host.h header ↵ananta@chromium.org2011-11-041-1/+0
| | | | | | | | | | | file. Part 1 of upcoming changes to move RPH/BRPH to a public interface. BUG=98716 Review URL: http://codereview.chromium.org/8451012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108608 0039d316-1c4b-4281-b951-d872f2087c98
* Move BrowserThread to content namespace.joi@chromium.org2011-11-021-0/+1
| | | | | | | | | TBR=owners BUG=98716 Review URL: http://codereview.chromium.org/8437002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108270 0039d316-1c4b-4281-b951-d872f2087c98
* Split BrowserThread into public API and private implementation, step 1.joi@chromium.org2011-10-281-4/+4
| | | | | | | | | | | | | | | | | | | | | Only content/ now has the ability to create BrowserThread objects, with the exception that tests can create the content::TestBrowserThread subclass, and (temporarily) code in chrome/ can create the DeprecatedBrowserThread subclass. A follow-up change will make content/ take care of its own thread creation, remove DeprecatedBrowserThread, and move all state and non-trivial constructors from BrowserThread down to BrowserThreadImpl. Also moved BrowserProcessSubThread into content/ namespace. As part of follow-up cleanup, chrome/ will stop using this class. BUG=98716 TEST=existing Review URL: http://codereview.chromium.org/8392042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107718 0039d316-1c4b-4281-b951-d872f2087c98
* Use system_request_context in TranslateManager instead of ↵joaodasilva@chromium.org2011-10-281-2/+2
| | | | | | | | | | | | Profile::GetDefaultRequestContext. BUG=89396 TEST=The translate features work as usual Review URL: http://codereview.chromium.org/8365033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107706 0039d316-1c4b-4281-b951-d872f2087c98
* Handle additional feedback from http://codereview.chromium.org/8395038/.jam@chromium.org2011-10-281-2/+2
| | | | | | | | | | | -rename URLFetcherFactory to URLFetcherImplFactory -rename GetUrl to GetURL and GetOriginalUrl to GetOriginalURL -get rid of request_type in TestURLFetcher's constructor BUG=98716 Review URL: http://codereview.chromium.org/8416020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107665 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome callers of UrlFetcher to use the interface. I'll switch tests ↵jam@chromium.org2011-10-261-5/+5
| | | | | | | | | to use composition instead of inheritence in a future change. BUG=98716 Review URL: http://codereview.chromium.org/8395023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107268 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary dependencies on Autofill.isherman@chromium.org2011-10-251-7/+0
| | | | | | | | | | | | The Autofill cache is now smart enough to update itself after the page is translated. BUG=none TEST=Autofill should still work after Translating web sites Review URL: http://codereview.chromium.org/8382028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107216 0039d316-1c4b-4281-b951-d872f2087c98
* Create a content::UrlFetcher interface that lives in content/public/common ↵jam@chromium.org2011-10-253-15/+16
| | | | | | | | | and convert users to it. I have added a static create function, but will switch instantiations to use it in another change since this has grown a lot. Basically this change converts function names away from unix_hacker style, which they shouldn't have been using anyways since some are virtual, and made all of the other functions virtual. BUG=98716 Review URL: http://codereview.chromium.org/8375039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107151 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 10:18:59 +0000