| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Push UnhandledWheelEvent and GetBrowserAccessibilityManager down to RenderWidgetHostViewPort.
Get rid of OnMessageReceivedForTesting, in favor of RenderViewHostTester::TestOnMessageReceived (which already existed but needed to be converted to a static method so it could be used with regular RenderViewHost instances).
Rename WebContentsTester::pending_rvh() to GetPendingRvh() since it's a virtual method.
Remove top-level alias for content::RenderViewHostTestHarness and switch clients to use the fully-qualified name.
Clean up a couple of other minor TODO items, some had already been done and the comment just needed to be removed; in one case the TODO was just wrong (in dump_accessibility_tree_browsertest.cc) since it's OK for content to depend on content implementations.
Remove test_tab_contents.h from DEPS (seems to have been a merge failure in my last change that left this in).
BUG=98716
Review URL: http://codereview.chromium.org/9838009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
exposing the internals of content/.
A separate WebContentsTester interface is used. For reasons this approach was chosen, see comments on the interface.
As part of this work, removed a bunch of references to TabContents from Chrome, some of which were true usages (leaked to Chrome via the test_tab_contents.h header), others of which were just forward declarations and never used. Also removed a chunk of code from autofill_manager.cc that isn't called from anywhere that referenced TabContents.
TBR=ben@chromium.org
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9706012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and Media Player
This patch applies the same URL check as https://chromiumcodereview.appspot.com/7745021.
BUG=chromium-os:27374
TEST=
Review URL: http://codereview.chromium.org/9592004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
namespace.
BUG=98716
R=jam@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9699082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=base_unittests
TBR=abodenha@chromium.org,ajwong@chromium.org,chocobo@chromium.org,mnissler@chromium.org,akalin@chromium.org,brettw@chromium.org,arv@chromium.org
Review URL: http://codereview.chromium.org/9590002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
without knowing about content's internals.
From the embedders' point of view, this is done by splitting the
"tester" interface away from the RenderViewHost interface, rather than
extending the parallel interface/implementation hierarchy; see
comments on TestRenderViewHost for the rationale.
TBR=ben@chromium.org
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9645003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
service, ExtensionSystem."
I believe this change is causing failures in
[SocketApiTest.Socket{TCP,UDP}Extension.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9648026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionSystem.
Move InitExtensions into ExtensionSystem.
Remove a few accessors (ExtensionDevToolsManager, ExtensionMessageService). The others have too many callers to fix in one go.
New: PrerenderManagerFactory DependsOn ExtensionSystemFactory.
BUG=104095
TEST=Open and close an incognito window; should not crash.
TBR=aa@chromium.org,akalin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9609024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9600036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also finishes breaking the Chrome dependency on RenderWidgetHostImpl and RenderViewHostImpl.
TBR=jam@chromium.org
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9599011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderViewHostImpl for content.
TBR=darin@chromium.org
BUG=98716
Review URL: http://codereview.chromium.org/9473001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionSystem.
This may be causing this crash:
Note: Google Test filter = PrerenderBrowserTest.PrerenderUnload
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from PrerenderBrowserTest, where TypeParam =
[ RUN ] PrerenderBrowserTest.PrerenderUnload
[2464:2324:0302/211059:6709843:FATAL:profile_dependency_manager.cc(134)] Check failed: false. Attempted to access a Profile that was ShutDown(). This is most likely a heap smasher in progress. After ProfileKeyedService::Shutdown() completes, your service MUST NOT refer to depended Profile services again.
Move InitExtensions into ExtensionSystem.
Remove a few accessors (ExtensionDevToolsManager, ExtensionMessageService). The others have too many callers to fix in one go.
BUG=104095
TEST=Open and close an incognito window; should not crash.
Review URL: http://codereview.chromium.org/9369013
TBR=yoz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9583036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move InitExtensions into ExtensionSystem.
Remove a few accessors (ExtensionDevToolsManager, ExtensionMessageService). The others have too many callers to fix in one go.
BUG=104095
TEST=Open and close an incognito window; should not crash.
Review URL: http://codereview.chromium.org/9369013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reasons are:
-this struct wasn't used at all in webkit layer, so no need to have it there
-we can avoid exposing content layer's serialization of SSLInfo to embedders
-avoid mentioning routing_ids in the webkit layer
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9382037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some reason, the error reporting page doesn't work over HTTPS yet.
That's a separate bug, and when it is fixed we'll fix the last http: URL in
this file.
BUG=112236
TEST=browser_tests: TranslateManagerTest.*; translation still works, and reporting a translation error still works
Review URL: http://codereview.chromium.org/9320015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates the first wave of links from
https://www.google.com/support/chrome paths to
https://support.google.com/chrome. We also don't need
locale parameters on these links.
BUG=111556
TEST=manual
TBR=dhollowa
Review URL: http://codereview.chromium.org/9234077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=103948
TEST=builds, tests pass
Review URL: http://codereview.chromium.org/9288053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9233018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for translation...
And this is the cause of some crashes...
BUG=47807
TEST=Make sure that none of the application languages for which we don't support translating to don't enable the translate context menu option.
Review URL: http://codereview.chromium.org/9212035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=94883
TEST=Make sure translate works for alternate language codes like 'iw' VS 'he' and 'no' VS 'nb'
Review URL: http://codereview.chromium.org/9221007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change broke Linux and Mac bots. I would recommend to ask committers to run your next change on trybots.
(*1) http://chromegw.corp.google.com/i/chromium/builders/Mac/builds/10788/steps/compile/logs/stdio
(*2) http://chromegw.corp.google.com/i/chromium/builders/Linux/builds/19313/steps/compile/logs/stdio
(*3) http://chromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/21385/steps/compile/logs/stdio
R=brettw@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9185026
TBR=tedvessenes@gmail.com
Review URL: http://codereview.chromium.org/9215005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=brettw@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9185026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
trivial changes to use WebContents instead of TabContents.
BUG=98716
Review URL: http://codereview.chromium.org/9030032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8983012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
implementation. Update all the headers in chrome to use the interface only. In a subsequent cl, I'll rename the implementation to NavigationControllerImpl and also get rid of content::NavigationController everywhere.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8983010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
GetSelectedWebContents, and update all dependent code.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/9074012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
content::NavigationController. After this is done, we can then make WebContents return a content::NavigationEntry instead of the impl.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/9016047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
GetWebContents() instead.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8986009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
methods used by chrome code to it.
BUG=98716
TBR=brettw
Review URL: http://codereview.chromium.org/8989071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
content namespace. Also make all users of content::NavigationController interface use the "using" keyword so they don't have to put content:: everywhere (similar to other Content API and WebKit API classes).
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8956059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
content::NavigationEntry, in preparation for creating an interface around NavigationController.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/9008034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
content\public and put them in the content namespace. Make PageNavigator use WebContents instead of TabContents. While I'm touching all the callers, I've removed the deprecated PageNavigator function and converted users to the new one.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8991012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
in content/public and in the content namespace. I've also made them structs instead of classes. This was because I didn't want to wrap them with Content API for what were really a collection of member variables. The one exception was SSLStatus::content_status which had helper functions around it to set and get the bitfield. Each of the two setter helpers were only called in one non-test code, and read in a few places, so I just converted them to do it directly.
BUG=98716
Review URL: http://codereview.chromium.org/9048002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SavePersistentPrefs calls to CommitPendingWrites.
TBR=ncarter@chromium.org
BUG=99306
TEST=none
Review URL: http://codereview.chromium.org/8198007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
use web_contents().
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/9030010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
tab_contents(), as well as all the dependent code.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8982008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
content/public/browser. NavigationEntry will be renamed to NavigationEntryImpl in a later change. It now derives from content::NavigationEntry. Most of this change is changing unix_hacker functions to CamelCase and updating callers.
BUG=98716
TBR=brettw
Review URL: http://codereview.chromium.org/9007043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
WebContentsObserver, and put it into the content namespace.
BUG=98716
TBR=tburkard
Review URL: http://codereview.chromium.org/9026011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=98716
Review URL: http://codereview.chromium.org/8949066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the WebContents interface.
BUG=98716
Review URL: http://codereview.chromium.org/9021022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disable in a followup. - Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_tests
on win,linux,mac.
Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace.
BUG=98716
TBR=dpranke
Review URL: http://codereview.chromium.org/8956050
TBR=jam
Review URL: http://codereview.chromium.org/9018016
TBR=thakis@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on win,linux,mac.
Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace.
BUG=98716
TBR=dpranke
Review URL: http://codereview.chromium.org/8956050
TBR=jam
Review URL: http://codereview.chromium.org/9018016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
WebContents namespace.
BUG=98716
TBR=dpranke
Review URL: http://codereview.chromium.org/8956050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the WebContents interface.
BUG=98716
Review URL: http://codereview.chromium.org/9007026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
use_webkit_compositor=1
BUG=106157
TEST=browser_tests
Review URL: http://codereview.chromium.org/8790012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
by adding a method to MockRenderThread instead.
BUG=98716
Review URL: http://codereview.chromium.org/8801001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GURL as referrer
BUG=105028
TEST=no functional change
Review URL: http://codereview.chromium.org/8785004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
header files via io_thread.h or browser_thread.h
TBR=owners (previously approved on codereview 8477004)
BUG=98716
Review URL: http://codereview.chromium.org/8746023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TabContentsObserver interface not use a struct from it. Instead, the interface uses a new struct, content::FrameNavigateParams, that's in the public directory. The IPC message's struct derives from it.
BUG=98716
Review URL: http://codereview.chromium.org/8603015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8614003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110940 0039d316-1c4b-4281-b951-d872f2087c98
|