| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Added logic to tab_menu_model.cc to pick "Reopen closed tab" or "Reopen closed window". It had been hardcoded to "tab".
BUG=161083
BUG=manual
Review URL: https://chromiumcodereview.appspot.com/12280010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=133088
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/12294004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previouly we removed it from Win8 but it is really just something
that is experimental and now that Aura is deployed we don't want
the casual user to play with it. Accelerator entry is gone as well.
The menu entry is kept in debug mode
BUG=175036
TEST=menu entry is gone in canary, see bug
Review URL: https://codereview.chromium.org/12251009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
On OSX 10.7 and later, apps should launch to lion fullscreen mode (where the omnibox is visible), not presentation mode (purely fullscreen). This had regressed in r179554. Behavior on OSX 10.6 remains to use presentation mode.
BUG=173605
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12207052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a mostly-automated change, using
./tools/git/move_source_file.py to move files and fix up include
guards and #includes from other files. Manual edits were limited to
fixing up .gypi files and adding BASE_PREFS_EXPORT where needed.
TBR=ben@chromium.org
BUG=155525
Review URL: https://codereview.chromium.org/12211105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
version control markers
Merge branch 'master' into file_path_browser
remove version control
Fix typo
Merge branch 'master' into file_path_browser
Conflicts:
chrome/browser/intents/native_services_browsertest.cc
chrome/browser/ui/intents/native_file_picker_service.cc
Merge branch 'master' into file_path_browser
Conflicts:
chrome/browser/chromeos/drive/drive_file_system.cc
chrome/browser/chromeos/drive/drive_file_system.h
chrome/browser/chromeos/drive/drive_file_system_interface.h
chrome/browser/chromeos/drive/drive_file_system_unittest.cc
chrome/browser/chromeos/drive/file_system/drive_operations.cc
chrome/browser/chromeos/login/wallpaper_manager.cc
chrome/browser/chromeos/login/wallpaper_manager.h
chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc
chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc
chrome/browser/google_apis/gdata_wapi_operations.cc
chrome/browser/google_apis/gdata_wapi_operations.h
chrome/browser/google_apis/gdata_wapi_operations_unittest.cc
chrome/browser/profiles/off_the_record_profile_impl.cc
chrome/browser/profiles/off_the_record_profile_impl.h
chrome/browser/profiles/profile_impl.cc
chrome/browser/profiles/profile_impl.h
chrome/browser/profiles/profile_impl_io_data.cc
chrome/browser/profiles/profile_impl_io_data.h
chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc
chrome/browser/ui/webui/options/manage_profile_handler.cc
Long lines
long lines
some long lines.
long lines
long lines
Beginning of lines.
Rename FilePath -> base::FilePath in chrome/browser
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. The relaunch chrome into windows 8 metro/desktop mode don't make sense for Chrome
AURA/ASH. We need to remove them.
2. The Open Ash/Close Ash environment options should only be added when Chrome AURA/ASH
is launched on Windows 7 or below.
The accelerator for the IDC_TOGGLE_ASH_DESKTOP is only added for windows 7 or below for
chrome AURA.
BUG=174169
Review URL: https://chromiumcodereview.appspot.com/12189020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change signin logic to allow signin if SyncDisabled policy is set.
Also broke out logic in SyncUIUtil into separate class so it can be used even
if sync is not enabled.
BUG=166148
Review URL: https://codereview.chromium.org/12077030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This sets up a finch server style server controlled field trial to experiment with having the profile switcher always visible.
We want to see the effect this has on sign in.
BUG=172872
TEST=start chrome with --force-fieldtrials=ShowProfileSwitcher/AlwaysShow/ either with a clean user data dir or only one profile. The avatar menu should be visible and there should only be one profile in the profile switcher. You should also be able to edit that profile.
Review URL: https://chromiumcodereview.appspot.com/12040085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The initial change in r179554 [1] presumed that IDC_FULLSCREEN would only be issued on Mac 10.7 and later. TestInstallThemeInFullScreen calls fullscreen without a platform & os version check.
This solution is to tolerate IDC_FULLSCREEN and convert it to a IDC_PRESENTATION_MODE on Mac 10.6 and earlier. Both are conceptually the same "fullscreen with no browser chrome".
[1] http://src.chromium.org/viewvc/chrome?view=rev&revision=179554
BUG=169138
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12096063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Revert 179554 - suspected to break browser_tests on Mac 10.6
>
> > Refactor FullscreenController removing TogglePresentationMode & adding ToggleFullscreenWithChrome.
> >
> > Part of a series of refactoring changes that will enable simpler code in FullscreenController as well as correcting behavior there. This change attempts to make the minimal modifications required in order to have FullscreenController::ToggleFullscreenMode consistently mean fullscreen with no browser chrome on all platforms.
> >
> > Depends on https://codereview.chromium.org/12018007/
> >
> > BUG=169138
> >
> > Review URL: https://chromiumcodereview.appspot.com/11896104
>
> TBR=scheib@chromium.org
> Review URL: https://codereview.chromium.org/12089068
TBR=kinuko@chromium.org
Review URL: https://codereview.chromium.org/12096059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Refactor FullscreenController removing TogglePresentationMode & adding ToggleFullscreenWithChrome.
>
> Part of a series of refactoring changes that will enable simpler code in FullscreenController as well as correcting behavior there. This change attempts to make the minimal modifications required in order to have FullscreenController::ToggleFullscreenMode consistently mean fullscreen with no browser chrome on all platforms.
>
> Depends on https://codereview.chromium.org/12018007/
>
> BUG=169138
>
> Review URL: https://chromiumcodereview.appspot.com/11896104
TBR=scheib@chromium.org
Review URL: https://codereview.chromium.org/12089068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ToggleFullscreenWithChrome.
Part of a series of refactoring changes that will enable simpler code in FullscreenController as well as correcting behavior there. This change attempts to make the minimal modifications required in order to have FullscreenController::ToggleFullscreenMode consistently mean fullscreen with no browser chrome on all platforms.
Depends on https://codereview.chromium.org/12018007/
BUG=169138
Review URL: https://chromiumcodereview.appspot.com/11896104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=167548
TEST=no functional change
Review URL: https://chromiumcodereview.appspot.com/12051054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=170053
TEST=as in bug
Review URL: https://chromiumcodereview.appspot.com/11906008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=108367
TEST=Shortcut doesn't launch menu when there's a single profile.
Adding/deleting profiles propertly changes the state.
Review URL: https://chromiumcodereview.appspot.com/11574010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
chrome/browser/printing/print_preview_tab_controller.h.
Review URL: https://chromiumcodereview.appspot.com/11543035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://codereview.chromium.org/11570024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=103846
Review URL: https://chromiumcodereview.appspot.com/11363227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11308259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=ben@chromium.org
BUG=155525
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170483
Review URL: https://chromiumcodereview.appspot.com/11280115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=ben@chromium.org
BUG=155525
Review URL: https://chromiumcodereview.appspot.com/11280115
Reason for revert: A review comment after commit showed that the
change is probably wrong (or at least changes behavior in a way that
was not intended). Reverting for now, until there is time to figure
out the correct change.
TBR=joi@chromium.org
Review URL: https://codereview.chromium.org/11308295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ben@chromium.org
BUG=155525
Review URL: https://chromiumcodereview.appspot.com/11280115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL allows apps windows to enter fullscreen on all platforms.
This fixes a regression introduced by r167006.
BUG=161246
Review URL: https://chromiumcodereview.appspot.com/11308085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL disables the "find in place" command if a constrained window is shown.
BUG=156969
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168440
Review URL: https://chromiumcodereview.appspot.com/11293259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no functional change
Review URL: https://chromiumcodereview.appspot.com/11411035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Reverting this CL because it included an unintentional change to chrome_browser_main.cc. I'll reland this afterwards with that change removed.)
This CL disables the "find in place" command if a constrained window is shown.
BUG=156969
Review URL: https://chromiumcodereview.appspot.com/11293259
TBR=sail@chromium.org
Review URL: https://codereview.chromium.org/11419076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL disables the "find in place" command if a constrained window is shown.
BUG=156969
Review URL: https://chromiumcodereview.appspot.com/11293259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://chromiumcodereview.appspot.com/11359201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this is a first-draft implementation of the "Recent tabs" submenu on cros/win,
initial cl was created by dhollowa@ who populated menu w/ non-executable
multiple recently-closed local tabs.
- for local device, show "Reopen closed tab"
* it's enabled if last closed tab can be restored , else it's disabled
- for other devices, show tabs in all windows of all sessions
* sessions and tabs of each session are ranked by recency
* each session has a section header and separator
* selecting a tab menu item restores tab
* if tab has been loaded in history, its favicon is shown
* max 3 sessions, most-recent session first
* max 4 tabs per session, most recent tabs independent of what window they
were from, reverse chronological and no window delineation
- if there's no device, show disabled "No tabs from other devices"
- added unittest, which populates SessionModelAssociator with fake foreign sessions via protocol buffer
BUG=159015
TEST=verify per bug rpt
Review URL: https://chromiumcodereview.appspot.com/11298004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://chromiumcodereview.appspot.com/11293205
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://chromiumcodereview.appspot.com/11293204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL prevents windows from entering or exiting fullscreen if a constrained window is attached.
BUG=146451
Review URL: https://chromiumcodereview.appspot.com/10947019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Trying to keep it simple so I can merge to 24 or 23.
BUG=159041
TEST=none
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/11275142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch is for counting star icon click followed by the bookmark prompt.
This patch is a part of "Bookmark Prompt Experiment" found in http://codereview.chromium.org/11028114/
BUG=144586
TEST=no user visible change
Review URL: https://chromiumcodereview.appspot.com/11358006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of using content::NotificationObserver, introduce specific
type-safe observer classes and update users to use them. In a very
large number of cases this was the users' only reason for being a
content::NotificationObserver and they would have a lot of
boiler-plate code such as a DCHECK on the notification type and
unpacking of the generic NotificationDetails types, so this change
removes a bunch of boilerplate and introduces more type safety.
This is part of enabling more of the Prefs code to live in
base/prefs/.
TBR=ben@chromium.org,brettw@chromium.org
BUG=155525
Review URL: https://chromiumcodereview.appspot.com/11345008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(IDC_RELOAD_IGNORING_CACHE), Shift+F4 (IDC_FULLSCREEN), and IDC_SEARCH since we have no reason to do so.
Along with that, rename browser_unittest.cc to browser_command_controller_unittest.cc and add some test cases.
BUG=152265
TEST=new tests added
Review URL: https://chromiumcodereview.appspot.com/11270024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fixes a crash in chromeos when trying to switch the desktop from the wrench menu.
BUG=157384
Review URL: https://codereview.chromium.org/11235071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove command control from location bars and service changes.
Add GetUpdatedCommandEnabledState static service helper function.
Call GetUpdatedCommandEnabledState from ActionBoxMenuModel.
Add and expand on unit tests (remove GMock use from unit test).
BUG=102709,122183,125307
TEST=No Chrome To Mobile behavior changes.
Review URL: https://chromiumcodereview.appspot.com/11190063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
intent menu items and a webstore link. Removes the command this deprecates from browser_commands.
BUG=137953
Review URL: https://chromiumcodereview.appspot.com/11073009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I think context menu should hide bookmark menu in guest mode.
BUG=155470
TEST=compile,manual test
Review URL: https://chromiumcodereview.appspot.com/11112009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of tabs during an exit on chromeos.
. When we forcefully shutdown we wouldn't tell TabRestoreService the
browsers was closing, which resulted in not recording the close.
. BrowserCommandController was triggering creation of
TabRestoreService during shutdown.
BUG=150799
TEST=see bug
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11049016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Run chrome.exe --enable-ash for the menu item to appear.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10967043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=127627
TEST=manual test
Review URL: https://chromiumcodereview.appspot.com/10990026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://chromiumcodereview.appspot.com/10945010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only default browsers can launch in metro mode so in the
case of not being the default we trigger the setting the default UI
If we are the default mode we just launch in metro
BUG=148570
TEST=see bug
Review URL: https://codereview.chromium.org/10914306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow user to request tablet site via a toggle on the wrench menu. Under about-flag & cmd line switch:
--enable-request-tablet-site
BUG=127841
TEST=Run with flag;
URLs to try: whatsmyuseragent.com, whatsmyua.com, slashdot.org, www.espn.com, www,facebook.com, www.google.com
toggle "Request tablet site" under wrench menu
Review URL: https://chromiumcodereview.appspot.com/10827146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Now relaunches wholesale chrome on desktop.
BUG=141032
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10928064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change puts a menu option to restart chrome in desktop or
to restart chrome in metro mode and then wires up to the restart
helper.
BUG=141032
TEST=see bug
Review URL: https://chromiumcodereview.appspot.com/10885047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
receives an F12 keypress
BUG=139581
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/10823233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154694 0039d316-1c4b-4281-b951-d872f2087c98
|