summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ui/browser_command_controller.h
Commit message (Collapse)AuthorAgeFilesLines
* Support full-screen and single-profile avatar bubbles.msw@chromium.org2014-05-131-15/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enable IDC_SHOW_AVATAR_MENU for normal browser windows. (full-screen and single-profile windows are now allowed) (non-tabbed and incognito windows are still disallowed) Nix BrowserCommandController's use of ProfileManager. (no commands rely on the profile count anymore) Cleanup some BrowserCommandController code. Inline AvatarMenuButton::ShowAvatarBubble in BrowserView. (ShowAvatarBubbleFromAvatarButton needs to set an anchor) (single-profile windows have no avatar icon; use hotdogs) Anchor to the Chrome menu button in Mac single-profile too. Take an ArrowPaintType in AvatarMenuBubbleView::ShowBubble. (lets fullscreen hide the arrow, there's no visible anchor) (this corresponds with fullscreen bookmark bubble behavior) Remove a stale Windows Valgrind DrMemory test exclusion entry. (test name was changed, but the exclusion wasn't; isn't needed) BUG=255452,167014 TEST=The avatar menu shows for Ctrl+Shift+M even in fullscreen and even for single-profile Chrome windows. Test with and without the experimental --new-profile-management, and in LTR and RTL Chrome UI modes. R=pkasting@chromium.org, asvitkine@chromium.org Review URL: https://codereview.chromium.org/264303006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270126 0039d316-1c4b-4281-b951-d872f2087c98
* Use base namespace for string16 in chrome/browser.brettw@chromium.org2013-12-061-1/+1
| | | | | | | | | | This converts 200 more files. TBR=sky Review URL: https://codereview.chromium.org/108353004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239278 0039d316-1c4b-4281-b951-d872f2087c98
* Add policy for fullscreen mode; disallow fullscreen in public sessionsbartfab@chromium.org2013-08-251-13/+1
| | | | | | | | | | | | This CL adds a user policy that determines whether fullscreen mode is allowed and uses it to disallow fullscreen mode in public sessions. BUG=275405 TEST=New browser tests Review URL: https://chromiumcodereview.appspot.com/22986010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219482 0039d316-1c4b-4281-b951-d872f2087c98
* ProfileInfoCacheObserver: All methods now have a default empty implementation.mgiuca@chromium.org2013-06-111-5/+0
| | | | | | | | | | | Previously they were pure virtual. Removed all empty overrides of ProfileInfoCacheObserver methods, as they are no longer necessary. BUG=247570 Review URL: https://chromiumcodereview.appspot.com/16035013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205488 0039d316-1c4b-4281-b951-d872f2087c98
* base/prefs: Remove the public/ directory and move the files to //base/prefs.tfarina@chromium.org2013-03-211-2/+2
| | | | | | | | | | BUG=155525 R=joi@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/12789006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189513 0039d316-1c4b-4281-b951-d872f2087c98
* Add a signin allowed policy which is used to determine if a user is allowed ↵akuegel@chromium.org2013-02-281-1/+8
| | | | | | | | | | | to sign in to Chrome. This will be used for example for one preference for managed user settings (Playpen project). BUG=171370 TEST=unit_tests, browser_tests, manual Review URL: https://chromiumcodereview.appspot.com/12088040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185359 0039d316-1c4b-4281-b951-d872f2087c98
* content: convert interstitial notifications to observer usagephajdan.jr@chromium.org2013-02-281-9/+6
| | | | | | | | BUG=170921 Review URL: https://codereview.chromium.org/12383009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185300 0039d316-1c4b-4281-b951-d872f2087c98
* Reland ash: Use immersive mode for fullscreenjamescook@chromium.org2013-02-271-1/+1
| | | | | | | | | | | | | | | | | | * Remove immersive mode button from maximized window frame * Tie immersive mode to browser-fullscreen only, keep tab-fullscreen with existing UI * Size button exits immersive mode * Add ImageButton::GetImage for testing * Most browser commands are enabled in immersive fullscreen BUG=177549 TEST=added to browser_tests views_unittests ash_unittests Original review: https://codereview.chromium.org/12316086/ Review URL: https://chromiumcodereview.appspot.com/12328119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184908 0039d316-1c4b-4281-b951-d872f2087c98
* Allow signin to continue even if sync is disabled by policy.atwilson@chromium.org2013-02-031-4/+0
| | | | | | | | | | | | | Change signin logic to allow signin if SyncDisabled policy is set. Also broke out logic in SyncUIUtil into separate class so it can be used even if sync is not enabled. BUG=166148 Review URL: https://codereview.chromium.org/12077030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180301 0039d316-1c4b-4281-b951-d872f2087c98
* Add FilePath to base namespace.brettw@chromium.org2013-02-021-5/+6
| | | | | | | This updates headers that forward-declare it and a few random places to use the namespace explicitly. There us a using declaration in file_path.h that makes the rest compile, which we can do in future passes. Review URL: https://codereview.chromium.org/12163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180245 0039d316-1c4b-4281-b951-d872f2087c98
* Make Mac menu code obey incognito availability.avi@chromium.org2013-01-221-3/+12
| | | | | | | | | | BUG=170053 TEST=as in bug Review URL: https://chromiumcodereview.appspot.com/11906008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178093 0039d316-1c4b-4281-b951-d872f2087c98
* Move window_open_disposition.h from webkit/ into ui/base.tfarina@chromium.org2013-01-221-1/+1
| | | | | | | | | | | | This reduces one more dependency on webkit from chrome. BUG=146251 R=jam@chromium.org,ben@chromium.org TBR=darin@chromium.org,tsepez@chromium.org Review URL: https://codereview.chromium.org/12036003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178082 0039d316-1c4b-4281-b951-d872f2087c98
* Disable profile avatar menu shortcut when there's only one profile.asvitkine@chromium.org2012-12-181-6/+20
| | | | | | | | | | BUG=108367 TEST=Shortcut doesn't launch menu when there's a single profile. Adding/deleting profiles propertly changes the state. Review URL: https://chromiumcodereview.appspot.com/11574010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173756 0039d316-1c4b-4281-b951-d872f2087c98
* Remove straggling TabContents references.avi@chromium.org2012-12-141-1/+0
| | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://codereview.chromium.org/11577020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173207 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Extract CommandUpdaterDelegate into its own header file.tfarina@chromium.org2012-12-061-2/+3
| | | | | | | | | R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11308259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171592 0039d316-1c4b-4281-b951-d872f2087c98
* Remove PrefObserver usages, batch 12.joi@chromium.org2012-12-031-6/+4
| | | | | | | | | | | | TBR=ben@chromium.org BUG=155525 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170483 Review URL: https://chromiumcodereview.appspot.com/11280115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170759 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 170483 - Remove PrefObserver usages, batch 12.joi@chromium.org2012-11-301-4/+6
| | | | | | | | | | | | | | | | | | TBR=ben@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11280115 Reason for revert: A review comment after commit showed that the change is probably wrong (or at least changes behavior in a way that was not intended). Reverting for now, until there is time to figure out the correct change. TBR=joi@chromium.org Review URL: https://codereview.chromium.org/11308295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170519 0039d316-1c4b-4281-b951-d872f2087c98
* Remove PrefObserver usages, batch 12.joi@chromium.org2012-11-301-6/+4
| | | | | | | | | | TBR=ben@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11280115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170483 0039d316-1c4b-4281-b951-d872f2087c98
* Disable find if constrained window is shownsail@chromium.org2012-11-201-0/+5
| | | | | | | | | | | | | This CL disables the "find in place" command if a constrained window is shown. BUG=156969 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168440 Review URL: https://chromiumcodereview.appspot.com/11293259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168688 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 168440 - Disable find if constrained window is shownsail@chromium.org2012-11-191-5/+0
| | | | | | | | | | | | | | | | | (Reverting this CL because it included an unintentional change to chrome_browser_main.cc. I'll reland this afterwards with that change removed.) This CL disables the "find in place" command if a constrained window is shown. BUG=156969 Review URL: https://chromiumcodereview.appspot.com/11293259 TBR=sail@chromium.org Review URL: https://codereview.chromium.org/11419076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168633 0039d316-1c4b-4281-b951-d872f2087c98
* Disable find if constrained window is shownsail@chromium.org2012-11-171-0/+5
| | | | | | | | | | | This CL disables the "find in place" command if a constrained window is shown. BUG=156969 Review URL: https://chromiumcodereview.appspot.com/11293259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168440 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContents from TabStripModelObserver::TabReplacedAt.avi@chromium.org2012-11-151-2/+2
| | | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/11359201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167955 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContents from TabStripModelObserver::TabDetachedAt.avi@chromium.org2012-11-111-2/+3
| | | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/11293205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167122 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContents from TabStripModelObserver::TabInsertedAt.avi@chromium.org2012-11-101-2/+2
| | | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/11293204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167104 0039d316-1c4b-4281-b951-d872f2087c98
* Remove content::NotificationObserver dependency from most Prefs code.joi@chromium.org2012-11-011-0/+6
| | | | | | | | | | | | | | | | | | | | | Instead of using content::NotificationObserver, introduce specific type-safe observer classes and update users to use them. In a very large number of cases this was the users' only reason for being a content::NotificationObserver and they would have a lot of boiler-plate code such as a DCHECK on the notification type and unpacking of the generic NotificationDetails types, so this change removes a bunch of boilerplate and introduces more type safety. This is part of enabling more of the Prefs code to live in base/prefs/. TBR=ben@chromium.org,brettw@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11345008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165414 0039d316-1c4b-4281-b951-d872f2087c98
* Update ChromeToMobile command logic and tests.msw@chromium.org2012-10-231-1/+0
| | | | | | | | | | | | | | Remove command control from location bars and service changes. Add GetUpdatedCommandEnabledState static service helper function. Call GetUpdatedCommandEnabledState from ActionBoxMenuModel. Add and expand on unit tests (remove GMock use from unit test). BUG=102709,122183,125307 TEST=No Chrome To Mobile behavior changes. Review URL: https://chromiumcodereview.appspot.com/11190063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163497 0039d316-1c4b-4281-b951-d872f2087c98
* Move the bits of Prefs where production code has only trivially easyjoi@chromium.org2012-10-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | to break dependencies back to Chrome. This leaves the following in chrome/ for now, which will move later: - PrefService, to move once sync dependencies and dependencies on Chrome-specific pref stores are externalized. - PrefNotifierImpl and PrefObserverMock, to move once NotificationSource dependency is broken. - PrefValueStore, to move once PrefModelAssociatior dependency is externalized. - ScopedUserPrefUpdate, to move once PrefService moves. TBR=ben@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163354 0039d316-1c4b-4281-b951-d872f2087c98
* Extract abstract base to API directory for ProfileSyncService.joi@chromium.org2012-09-191-1/+1
| | | | | | | | | | | | | | | Move ProfileSyncServiceObserver to API directory. Use these to break Autofill's concrete dependency on ProfileSyncService. Remove last usages of Profile in Autofill code (modulo usage in one file that I expect will be moved to chrome/browser/configuration). TBR=ben@chromium.org,mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10910071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157563 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 153205 - Temporarily revert 152729 - Revert "Fixing crash Crash ↵yusukes@chromium.org2012-08-241-3/+0
| | | | | | | | | | | | | | | | | | | | | | | Report - Stack Signature: content::RenderWidgetHostImpl::ForwardKeybo" ben asked to revert this in the main trunk. The real fix will be in once Issue 142422 gets fixed. This reverts commit 54bac78404d9b2d3ddb475526da8211414ae36b2. R=skuhne@chromium.org BUG=134465 Review URL: https://chromiumcodereview.appspot.com/10866009 TBR=skuhne@chromium.org Review URL: https://chromiumcodereview.appspot.com/10876066 TBR=yusukes@chromium.org Review URL: https://chromiumcodereview.appspot.com/10879066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153211 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily revert 152729 - Revert "Fixing crash Crash Report - Stack ↵yusukes@chromium.org2012-08-241-0/+3
| | | | | | | | | | | | | | | | | | | | Signature: content::RenderWidgetHostImpl::ForwardKeybo" ben asked to revert this in the main trunk. The real fix will be in once Issue 142422 gets fixed. This reverts commit 54bac78404d9b2d3ddb475526da8211414ae36b2. R=skuhne@chromium.org BUG=134465 Review URL: https://chromiumcodereview.appspot.com/10866009 TBR=skuhne@chromium.org Review URL: https://chromiumcodereview.appspot.com/10876066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153205 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fixing crash Crash Report - Stack Signature: ↵skuhne@chromium.org2012-08-221-3/+0
| | | | | | | | | | | | | | | | | content::RenderWidgetHostImpl::ForwardKeybo" ben asked to revert this in the main trunk. The real fix will be in once Issue 142422 gets fixed. This reverts commit 54bac78404d9b2d3ddb475526da8211414ae36b2. R=skuhne@chromium.org BUG=134465 Review URL: https://chromiumcodereview.appspot.com/10866009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152729 0039d316-1c4b-4281-b951-d872f2087c98
* Move PrefMember and PrefChangeRegistrar to api directory.joi@chromium.org2012-08-211-2/+2
| | | | | | | | | | | | | | | | This is the first step in breaking Autofill's concrete dependency on prefs. These two classes are essentially utilities with very small dependencies back to PrefService (which I will break in the next change, by introducing a virtual PrefServiceBase) so they are suitable for api. TBRing other owners for mechanical changes. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10857031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152544 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing crash Crash Report - Stack Signature: ↵skuhne@chromium.org2012-08-101-0/+3
| | | | | | | | | | | | content::RenderWidgetHostImpl::ForwardKeybo BUG=134465 TEST=by hand Review URL: https://chromiumcodereview.appspot.com/10836186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151121 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Moves command handling from Browser to a new object, BrowserCommandController.ben@chromium.org2012-06-271-0/+188
Notes: . BrowserCommandController now owns the CommandUpdater. . CommandHandler's ExecuteCommand API was massaged a little so that ExecuteCommand/IsCommandEnabled/SupportsCommand methods are always called on it, rather than the wrapping controller. . The creation of BCC was performed as a svn cp so that history for the various Exec methods could be easily carried forward. . Various "CanFoo" methods were extracted from the UpdateFooState() methods and moved to CanFoo(const Browser* browser) in browser_commands. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10677009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144597 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-28 02:25:52 +0000