summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ui/browser_commands.cc
Commit message (Collapse)AuthorAgeFilesLines
* add test to verify bookmark bar state and it's always reflected by its ↵kuan@chromium.org2013-10-141-1/+1
| | | | | | | | | | | | | | | visual state - the mentioned bug exposed the out-of-sync error between the bookmark bar state in Browser and the visual state in BrowserWindow. - this test verifies the bookmark bar state in Browser and that the 2 states are always in sync. - in the process, remove BrowserWindow::ToggleBookmarkBar() and have chrome::ToggleBookmarkBar() call chrome::ToggleBookmarkBarWhenVisible() directly. BUG=299131 TEST=unit_tests --gtest_filter=BrowserBookmarkBarTest.StateOnActiveTabChanged passes. Review URL: https://codereview.chromium.org/25660004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228539 0039d316-1c4b-4281-b951-d872f2087c98
* When running in immersive mode, the system print dialog opens zturner@chromium.org2013-10-091-1/+9
| | | | | | | | | | | | | | | modally on the desktop, causing the browser to appear hung with no indication to the user that it is waiting on input from a modal dialog on the desktop. This patch hides the "Print with system dialog..." link in Print Preview iff metro. BUG=291345 Review URL: https://codereview.chromium.org/25033006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227680 0039d316-1c4b-4281-b951-d872f2087c98
* Convert GetInputString() to GetDestinationURL().pkasting@chromium.org2013-10-031-1/+1
| | | | | | | | | | | | There's no reason to convert GURL -> string16 -> GURL. BUG=none TEST=none R=sky@chromium.org Review URL: https://codereview.chromium.org/25645003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226849 0039d316-1c4b-4281-b951-d872f2087c98
* [Cleanup] rename WebContentsModalDialogManager::IsShowingDialog() to ↵wittman@chromium.org2013-09-101-1/+1
| | | | | | | | | | | | | | IsDialogActive() The function tests whether web contents modal dialogs are active, rather than if they are actually showing. This updates the name accordingly and resolves the TODO. BUG=157161 Review URL: https://chromiumcodereview.appspot.com/23815006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222289 0039d316-1c4b-4281-b951-d872f2087c98
* This is a follow-up to https://chromiumcodereview.appspot.com/16305010/. To ↵vasilii@chromium.org2013-08-261-10/+7
| | | | | | | | | | | | | eradicate the discrepancy between find bar text and actual search term we'll always search for current find bar text on Mac. This is correct because find bar updates itself whenever the find pboard changes. The test strengthened to reproduce the bug. BUG=272291 TBR=estade@chromium.org Review URL: https://chromiumcodereview.appspot.com/22796022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219530 0039d316-1c4b-4281-b951-d872f2087c98
* Printing: Add a basic printing mode without print preview and cloud print.thestig@chromium.org2013-08-121-6/+29
| | | | | | | | | BUG=147070 TBR=cimamoglu@google.com Review URL: https://codereview.chromium.org/22577010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217025 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary #if defined(ENABLE_MANAGED_USERS) and header includes.bauerb@chromium.org2013-08-051-2/+0
| | | | | | | | | TBR=kalman@chromium.org,erg@chromium.org,tim@chromium.org,pkotwicz@chromium.org,sky@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/21523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215605 0039d316-1c4b-4281-b951-d872f2087c98
* Create CoreAppLauncherHandler to handle recordAppLaunchbyURL messagesimon.hong81@gmail.com2013-07-261-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | recordAppLaunchByURL is also used in the ntp such as recently closed, most visited page and web store button click. But its handler is not registered when NewTabUI::ShouldShowApps() is false. When I build(debug) chrome with chromeos=1, click most visited page causes segfault with below messages. [5003:5003:0721/121918:FATAL:web_ui_impl.cc(221)] Check failed: false. Unhandled chrome.send("recordAppLaunchByURL"); [0x7fbe96938c00] base::debug::StackTrace::StackTrace() [0x7fbe9697aa67] logging::LogMessage::~LogMessage() [0x7fbe8ca29d38] content::WebUIImpl::ProcessWebUIMessage() [0x7fbe8ca28d9e] content::WebUIImpl::OnWebUISend() To handle this message in ntp and app view page, CoreAppLauncherHandler is created. Also, add MetricsHandler in the app view page because it uses metricsHandler::logEventTime. R=dbeam@chromium.org BUG=NONE TEST=Compiles Review URL: https://chromiumcodereview.appspot.com/19913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213840 0039d316-1c4b-4281-b951-d872f2087c98
* Hide knowledge of webkit::ppapi::PluginDelegate from chrome. This is part of ↵jam@chromium.org2013-07-231-6/+9
| | | | | | | | | | | | | | | | moving ppapi implementation from webkit/plugins/ppapi to content/renderer. Chrome used four methods on that interface for PDFs. -DidStartLoading/DidStopLoading: I just exposed these methods from RenderViewImpl on the RenderView interface -SetContentRestriction: I moved this functionality completely into chrome. This allows us to get rid of all the content restrictions related methods in the content API, and to move content_restriction.h out to chrome. -SaveURLAs: exposed the internal SaveURL method on WebContents BUG=263054 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/19800005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213027 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the integrated desktop Chrome To Mobile Service and UI.msw@chromium.org2013-07-181-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove ChromeToMobile service, factory, unittests, and UI. Remove IDS_CHROME_TO_MOBILE* strings. Remove IDC_CHROME_TO_MOBILE_PAGE and adjust IDC values. Remove IDR_MOBILE and chrome/app/theme/*/mobile[_lit].png Remove browser frame and location bar callers, consts. Remove prefs::kChromeToMobileDeviceList from user profiles. Add code in c/b/prefs/browser_prefs.cc to clear this value. The UMA histograms will be removed in a related CL: https://chromereviews.googleplex.com/9087014/ WontFix'ed issues related to this code, listed for future reference: -Issue 120941: Chrome To Mobile: An error occured while sending the page. -Issue 154709: Last selected mobile device not stored and automatically reselected -Issue 154710: Ordering of mobile devices not consistent -Issue 156843: Only acknowledge invalidation after device search is finished in ChromeToMobileService -Issue 122183: Make ChromeToMobile API more testable, drop gmock. BUG=260121 TEST=Dead user pref is cleared, no compile failures/crashes. R=rfevang@chromium.org,battre@chromium.org,sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/19256007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212219 0039d316-1c4b-4281-b951-d872f2087c98
* Update some includes of chrome_notification_types.hjam@chromium.org2013-07-121-1/+1
| | | | | | Review URL: https://codereview.chromium.org/19071004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211272 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. cleanup:pkasting@chromium.org2013-07-111-4/+2
| | | | | | | | | | | | | | | | | | | * Don't need HISTOGRAM_ on ever value of a private enum about histograms * Shorten code * Explicitly declare a destructor if we declare a constructor * Infobar -> InfoBar * Don't handle DCHECK failure * Avoid non-const refs * Prefer // to /* */ * Braces on multi-line conditional bodies BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/19029002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211253 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused parameter "show_history" from the ShowWebsiteSettings methods.markusheintz@chromium.org2013-07-051-3/+2
| | | | | | | | | BUG=none TBR=sky@chromium.org,avi@chromium.org,nkostylev@chromium.org Review URL: https://chromiumcodereview.appspot.com/18518002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210292 0039d316-1c4b-4281-b951-d872f2087c98
* Expose "Chrome" as accessible product name.dmazzoni@chromium.org2013-06-291-3/+6
| | | | | | | | | | | | Moves source of the various components of the user agent product name and version to ChromeVersionInfo, and exposes them in ChromeContentClient. BUG=255053 Review URL: https://chromiumcodereview.appspot.com/18055008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209317 0039d316-1c4b-4281-b951-d872f2087c98
* Change various google_util functions from taking a std::string to a GURL.pkasting@chromium.org2013-06-271-2/+2
| | | | | | | | | | BUG=249197 TEST=none TBR=jered,sky Review URL: https://codereview.chromium.org/18110003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209004 0039d316-1c4b-4281-b951-d872f2087c98
* Remove "View Background Pages".avi@chromium.org2013-06-221-2/+2
| | | | | | | | | BUG=148581 TEST=No more "feature". Review URL: https://chromiumcodereview.appspot.com/17501006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208061 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed cmd + G (find next) on Mac in Incognito, 2 new tests:vasilii@chromium.org2013-06-121-6/+8
| | | | | | | | | | | | FindInPageControllerTest.IncognitoFindNextSecret FindInPageControllerTest.IncognitoFindNextShared BUG=245638 Review URL: https://chromiumcodereview.appspot.com/16305010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205830 0039d316-1c4b-4281-b951-d872f2087c98
* InstantExtended: make modes work with the native popup.samarth@chromium.org2013-06-101-3/+3
| | | | | | | | | | | | | For any navigations to a instant-extended search URL, process the query using the active tab, if it's an instant-extended search page. BUG=247725 TEST=interactive ui tests R=jered@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/16507009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205225 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in chrome/browser/ui/, part 1.avi@chromium.org2013-06-081-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16525009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205063 0039d316-1c4b-4281-b951-d872f2087c98
* Handle key sequence for toggling voice search. This is a no-op until ↵jeremycho@chromium.org2013-06-071-0/+2
| | | | | | | | | | | | ontogglevoicesearch is added server-side. This will be used in lieu of the current server-side implementation of this keyboard shortcut to handle cases where Chrome is capturing keystrokes (see internal bug b/9123020). In the future, we may also use this API to initiate voice search from an icon in the omnibox. BUG=230417 Review URL: https://chromiumcodereview.appspot.com/15721006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204677 0039d316-1c4b-4281-b951-d872f2087c98
* Replace PruneAllButActive with PruneAllButVisible.creis@chromium.org2013-05-311-1/+2
| | | | | | | | | | | | | Before we would forget the entry for the visible page, so we now require there to be a last committed entry, no transient entry, and optionally a new pending entry (not an existing pending entry). BUG=234809 TEST=Prerendering should not swap in without a last committed entry. Review URL: https://chromiumcodereview.appspot.com/15041004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203492 0039d316-1c4b-4281-b951-d872f2087c98
* content: Move kViewSourceScheme constant into content namespace.tfarina@chromium.org2013-05-301-2/+2
| | | | | | | | | BUG=None R=thestig@chromium.org,grt@chromium.org,joi@chromium.org,eroman@chromium.org Review URL: https://chromiumcodereview.appspot.com/15950011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203241 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce content::PageState (again).darin@chromium.org2013-05-281-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a concrete class wrapping a string that contains the data of a serialized WebKit::WebHistoryItem class. Previously, we've just passed around these as strings, giving them names like "state", "content_state" or "history_state". It has been hard to identify all of the places in the code where these strings get passed around. A concrete class should make usage more apparent. Plus, instead of manipulating the strings using methods from webkit/glue/glue_serialize.h, we can just declare methods on the PageState class. This makes the code much cleaner. This first pass just implements PageState in terms of glue_serialize. It also adds content/public/renderer/history_item_serialization.h as the home for PageState to WebKit::WebHistoryItem conversion, which should ideally only be usable from the renderer process. (This bit is a step toward resolving bug 237243.) page_state.h declares operator==() to support DCHECK_EQ, which seems consistent with the idea of PageState being a replacement for std::string. I didn't want to litter tests with calls to PageState::ToEncodedData(). That would get cumbersome. Originally reviewed at: https://codereview.chromium.org/14985014 The only difference is that page_state.cc is now split into two pieces: page_state.cc and page_state_webkit.cc. The second holds the definition of all methods that depend on webkit/glue. That way code like Chrome Frame and the iOS port of Chromium can use PageState without pulling in a dependency on webkit/glue at link time. BUG=240426 R=brettw@chromium.org, grt@chromium.org, joth@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/16162003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202678 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 202188 "Introduce content::PageState."grt@chromium.org2013-05-261-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change bloated npchrome_frame.dll (see http://build.chromium.org/f/chromium/perf/xp-release/sizes/report.html?=undefined&history=3&rev=202214&graph=npchrome_frame.dll) because content_common.lib's common_param_traits.obj depends on content_common.lib's page_state.obj which, in turn, depends on webkit. This means that consumers of IPC messages in content_common suddenly require all of webkit. > Introduce content::PageState. > > This is a concrete class wrapping a string that contains the > data of a serialized WebKit::WebHistoryItem class. Previously, > we've just passed around these as strings, giving them names > like "state", "content_state" or "history_state". It has been > hard to identify all of the places in the code where these > strings get passed around. A concrete class should make usage > more apparent. Plus, instead of manipulating the strings using > methods from webkit/glue/glue_serialize.h, we can just declare > methods on the PageState class. This makes the code much cleaner. > > This first pass just implements PageState in terms of glue_serialize. > It also adds content/public/renderer/history_item_serialization.h > as the home for PageState to WebKit::WebHistoryItem conversion, > which should ideally only be usable from the renderer process. > (This bit is a step toward resolving bug 237243.) > > page_state.h declares operator==() to support DCHECK_EQ, which > seems consistent with the idea of PageState being a replacement > for std::string. I didn't want to litter tests with calls to > PageState::ToEncodedData(). That would get cumbersome. > > BUG=240426 > R=brettw@chromium.org, tsepez@chromium.org > > Review URL: https://codereview.chromium.org/14985014 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/16068002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202321 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce content::PageState.darin@chromium.org2013-05-241-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a concrete class wrapping a string that contains the data of a serialized WebKit::WebHistoryItem class. Previously, we've just passed around these as strings, giving them names like "state", "content_state" or "history_state". It has been hard to identify all of the places in the code where these strings get passed around. A concrete class should make usage more apparent. Plus, instead of manipulating the strings using methods from webkit/glue/glue_serialize.h, we can just declare methods on the PageState class. This makes the code much cleaner. This first pass just implements PageState in terms of glue_serialize. It also adds content/public/renderer/history_item_serialization.h as the home for PageState to WebKit::WebHistoryItem conversion, which should ideally only be usable from the renderer process. (This bit is a step toward resolving bug 237243.) page_state.h declares operator==() to support DCHECK_EQ, which seems consistent with the idea of PageState being a replacement for std::string. I didn't want to litter tests with calls to PageState::ToEncodedData(). That would get cumbersome. BUG=240426 R=brettw@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/14985014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202188 0039d316-1c4b-4281-b951-d872f2087c98
* Move webkit/user_agent/ into webkit/commonjamesr@chromium.org2013-05-231-1/+1
| | | | | | | | | | | | | webkit/user_agent/ defines a tidy little library that depends on almost nothing and can be used in any process. This moves it into webkit/common/user_agent/. It's still linked as a separate component in the shared_library build. BUG=237267 R=darin Review URL: https://chromiumcodereview.appspot.com/15702003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201700 0039d316-1c4b-4281-b951-d872f2087c98
* InstantExtended: Reload when re-accepting search terms.jered@chromium.org2013-05-171-2/+7
| | | | | | | | | | | | | | | Previously when focusing in the omnibox and pressing enter while it showed search results, we would re-classify the match based on the query terms. Instead, we should refresh the search page. Not doing so is a potential security problem and is inconsistent UI behavior, because something that says "Search" should really do a search. TEST=Manually and browsertest BUG=173483,226841 Review URL: https://chromiumcodereview.appspot.com/14752021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200904 0039d316-1c4b-4281-b951-d872f2087c98
* content: Extract url utility functions into url_utils.{h,cc}tfarina@chromium.org2013-05-171-2/+2
| | | | | | | | | | BUG=104549 R=joi@chromium.org,asanka@chromium.org TBR=thestig@chromium.org Review URL: https://chromiumcodereview.appspot.com/15021020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200885 0039d316-1c4b-4281-b951-d872f2087c98
* components: Create web_modal component.sadrul@chromium.org2013-05-161-1/+2
| | | | | | | | | | | | | | | | | | | | Notable changes: * Move WebContentsModalDialog related classes into components/web_modal/ * Use namespace web_modal * Move the logic for sending the Chrome IPC message out of WebContentsModalDialogManager, and into ChromeModalDialogManager. Have Browser and ShellWindow subclass ChromeModalDialogManager, instead of directly from WebContentsModalDialogManager, to be able to send the IPC. * Introduce WebContentsModalDialogManagerDelegate::IsWebContentsVisibile. This is necessary to remove the dependency on platform_util. BUG=241278 R=ben@chromium.org, wittman@chromium.org Review URL: https://codereview.chromium.org/14969012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200448 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Make BookmarkModel::IsLoaded() not virtual.tfarina@chromium.org2013-05-081-2/+2
| | | | | | | | | | | | | | | | | | BookmarkModel is not intended to be mocked out nor inherited from. Making IsLoaded() a virtual function allow clients to inherit from BookmarkModel and override its behavior, but that is not what we want and thus we make it non-virtual. Since r184651, nobody inherits from BookmarkModel nor override IsLoaded(). Also while at it, rename it to just loaded() and inline it in the header file, since it's a only a trivial getter. BUG=None R=sky@chromium.org Review URL: https://codereview.chromium.org/15012013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199021 0039d316-1c4b-4281-b951-d872f2087c98
* Add key to focus infobarsdmazzoni@chromium.org2013-04-191-0/+5
| | | | | | | | | | | | | On Windows & Chrome OS, pressing Alt+Shift+A will bring focus to the first control in the first infobar, if any are shown. No reason for 'A' - 'I' is already taken on Chrome OS, but all other hotkeys to directly focus a given pane are Alt+Shift+Letter shortcuts. BUG=226334 Review URL: https://chromiumcodereview.appspot.com/14225016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195030 0039d316-1c4b-4281-b951-d872f2087c98
* Properly track the creation of a new window for managed users.pam@chromium.org2013-04-111-7/+0
| | | | | | | | | | | | | Move the measurement of how many new Browsers (i.e., windows) a managed user creates into the Browser constructor, so it catches them all. See https://codereview.chromium.org/8890054/ for relevant discussion about previous metrics. BUG=228848 Review URL: https://chromiumcodereview.appspot.com/13997003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193658 0039d316-1c4b-4281-b951-d872f2087c98
* Hide ContentClient getters from embedders so that they they don't reuse ↵jam@chromium.org2013-04-051-2/+2
| | | | | | | | | content's embedder API. The main reasons are that it makes content's embedder interfaces harder to change if they're reused by the embedder, and that its makes it confusing for embedder code when there are multiple ways to do the same thing. BUG=227047 Review URL: https://codereview.chromium.org/13409003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192649 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate Browser::TYPE_PANELstevenjb@chromium.org2013-04-041-2/+1
| | | | | | | | BUG=225595 Review URL: https://chromiumcodereview.appspot.com/13139004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192264 0039d316-1c4b-4281-b951-d872f2087c98
* Added histogram for v2 app launch sourcecalamity@chromium.org2013-03-241-2/+5
| | | | | | | | | | | This patch takes the Extensions.AppLaunch UMA stat and logs v2 app launches to Apps.AppLaunch. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189589 Review URL: https://chromiumcodereview.appspot.com/12708005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190134 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in chrome.tabs.duplicate if the tab to be duplicated belongs to an ↵meacer@chromium.org2013-03-231-15/+15
| | | | | | | | app window. Review URL: https://chromiumcodereview.appspot.com/12746007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190109 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 189589 "Added histogram for v2 app launch source"hans@chromium.org2013-03-211-5/+2
| | | | | | | | | | | | | | | | | It seems 189589 broke the build. Its CQ tryjobs were started before r189567, which had conflicting changes, had landed. > Added histogram for v2 app launch source > > This patch takes the Extensions.AppLaunch UMA stat and logs v2 app launches to Apps.AppLaunch. > BUG= > > Review URL: https://chromiumcodereview.appspot.com/12708005 TBR=calamity@chromium.org Review URL: https://codereview.chromium.org/12790015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189593 0039d316-1c4b-4281-b951-d872f2087c98
* Added histogram for v2 app launch sourcecalamity@chromium.org2013-03-211-2/+5
| | | | | | | | | This patch takes the Extensions.AppLaunch UMA stat and logs v2 app launches to Apps.AppLaunch. BUG= Review URL: https://chromiumcodereview.appspot.com/12708005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189589 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing problem with a tabless browser windows showing up after a task ↵skuhne@chromium.org2013-03-211-4/+2
| | | | | | | | | | | | | | | | manager was used I traced it down to the creation of the task manager which grabs an existing (or new) browser. It requires the browser only for two things: determining the system it is running in and for giving the created web dialog a context (a window which is used (by Aura only) to position the window within the hierarchy. As I can see it there are no other dependencies to the browser and it can be disposed of after the task manager was created (and there are no tabs in the tabbed browser). BUG=176670 TEST=visual Review URL: https://chromiumcodereview.appspot.com/12712018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189579 0039d316-1c4b-4281-b951-d872f2087c98
* Change the way the omnibox handles CTRL-Enter navigations.beaudoin@chromium.org2013-03-181-2/+9
| | | | | | | | | | | | | | | Previously, holding CTRL in the omnibox caused the providers to change their top result, promoting a URL_WHAT_YOU_TYPED result with a ".com" suffix. With this patch, the providers now disregard the CTRL state and, instead, when a CTRL-Enter is encountered the OmniboxEditModel tries to replace the top AutocompleteMatch by a URL_WHAT_YOU_TYPED result with the ".com" suffix. As a result, CTRL-Enter is now supported in instant-extended. BUG=172223,170124 TBR=isherman@chromium.org,avi@chromium.org Review URL: https://chromiumcodereview.appspot.com/12485004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188738 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ScopedHostDesktopType.gab@chromium.org2013-03-021-4/+0
| | | | | | | | | | | | | | | | It was introduced (in crrev.com/163664) back when desktop context was hard to obtain. It doesn't seem to be required anymore as all users now have desktop context provided to them. e.g.: 1) AddBlankTabAt only needs it if it creates a WebContents via CreateTargetWebContents which now takes context from |browser->window()|. 2) ToggleAshDesktop(); I'm not even sure this is used by anyone anymore (appears to only be triggerable from the Wrench menu on Win7- (I tried to force it on Win8 and it doesn't do anything)). BUG=133312, 129187 TEST=Trigger AddBlankTabAt() from both desktops in parallel, open new windows from the resulting tabs, and verify that everything pops on the expected desktop. Review URL: https://chromiumcodereview.appspot.com/12381015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185724 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WebContents methods that duplicate WebContentsView methods.jam@chromium.org2013-02-261-1/+1
| | | | | | Review URL: https://codereview.chromium.org/12334073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184598 0039d316-1c4b-4281-b951-d872f2087c98
* Make Browser::CreateParams::CreateFor(App|DevTools) take HostDesktopType.gab@chromium.org2013-02-231-2/+4
| | | | | | | | | | | Plumbing HostDesktopType through all consumers (hardcoding HOST_DESKTOP_TYPE_NATIVE for some tests). BUG=129187 Review URL: https://chromiumcodereview.appspot.com/12334051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184304 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb HostDesktopType through BrowserListTabContentsProvider.gab@chromium.org2013-02-221-6/+0
| | | | | | | | | | | | | Although LaunchDevToolsHandlerIfNeeded (in chrome_browser_main.cc) is the only user via the remote dev tools debugger, the API is rather generic and it made more sense to plumb the HostDesktopType through even if we end up hardcoding it in the only caller. Also removes chrome::NewEmptyWindowDeprecated(). BUG=129187 Review URL: https://chromiumcodereview.appspot.com/12328029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184094 0039d316-1c4b-4281-b951-d872f2087c98
* Make all consumers of chrome::NewEmptyWindow and chrome::OpenEmptyWindow ↵gab@chromium.org2013-02-201-7/+7
| | | | | | | | | | | | | | | | browser commands use the version specifying a HostDesktopType. Removes chrome::OpenEmptyWindow() completely. 1 trickier consumer remains for chrome::NewEmptyWindow(), but the non-multi-desktop aware ovveride of this call was renamed to chrome::NewEmptyWindowDeprecated() and will be removed in a follow-up CL. - Re-used desktop context where it was present. - Hardcoded context to HOST_DESKTOP_TYPE_ASH for everything under chrome/browser/ui/ash/. - Hardcoded context to HOST_DESKTOP_TYPE_NATIVE in tests. BUG=129187 Review URL: https://chromiumcodereview.appspot.com/12282048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183424 0039d316-1c4b-4281-b951-d872f2087c98
* "Reopen closed window" text not consistent across tab/window context menusschmitz@chromium.org2013-02-201-2/+7
| | | | | | | | | | | Added logic to tab_menu_model.cc to pick "Reopen closed tab" or "Reopen closed window". It had been hardcoded to "tab". BUG=161083 BUG=manual Review URL: https://chromiumcodereview.appspot.com/12280010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183402 0039d316-1c4b-4281-b951-d872f2087c98
* browser: Move the rest of application_lifetime.h into chrome namespace.tfarina@chromium.org2013-02-181-1/+1
| | | | | | | | | BUG=133088 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/12294004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183049 0039d316-1c4b-4281-b951-d872f2087c98
* Add an outdated upgrade bubble view.mad@chromium.org2013-02-151-2/+12
| | | | | | | | | | | Show a new bubble when the current install is more than on major revision away from what's available. BUG=151996 Review URL: https://chromiumcodereview.appspot.com/11440020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182626 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable print and reload for instant extended NTP which now supports it ↵mad@chromium.org2013-02-141-12/+2
| | | | | | | | | | properly. BUG=165557, 162318 Review URL: https://chromiumcodereview.appspot.com/12250028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182415 0039d316-1c4b-4281-b951-d872f2087c98
* Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/.joi@chromium.org2013-02-111-1/+1
| | | | | | | | | | | | | | This is a mostly-automated change, using ./tools/git/move_source_file.py to move files and fix up include guards and #includes from other files. Manual edits were limited to fixing up .gypi files and adding BASE_PREFS_EXPORT where needed. TBR=ben@chromium.org BUG=155525 Review URL: https://codereview.chromium.org/12211105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181707 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-20 05:32:52 +0000