summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ui/browser_init.cc
Commit message (Collapse)AuthorAgeFilesLines
...
* Cleanup: Update a bunch of files to the new location of browser_window.h. ↵tfarina@chromium.org2011-04-091-1/+1
| | | | | | | | | | | | | | | | | Part 1/1. (Note: This was a TODO for beng). Also remove browser_window.h stub file as all the includes to it were already updated. BUG=None TEST=None R=avi@chromium.org Review URL: http://codereview.chromium.org/6820015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81038 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Update a bunch of files to the new location of browser_list.h. Part ↵tfarina@chromium.org2011-04-061-1/+1
| | | | | | | | | | | | | 2/3. BUG=None TEST=None R=avi@chromium.org Review URL: http://codereview.chromium.org/6805012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80647 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Make brightness and volume work on login screen.derat@chromium.org2011-03-311-11/+0
| | | | | | | | | | | | | | | This makes us initialize the listener for brightness changes and volume key presses earlier (we used to do it in BrowserInit; now we do it in BrowserMain) and makes SettingLevelBubble attempt to use the login background window as its parent if it can't find a browser window. BUG=chromium-os:13226 TEST=manual testing: used volume and brightness keys both before and after login and checked that the bubbles appeared onscreen Review URL: http://codereview.chromium.org/6748011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80055 0039d316-1c4b-4281-b951-d872f2087c98
* Add SMS notificationdpolukhin@chromium.org2011-03-311-0/+6
| | | | | | | | | BUG=chromium-os:12006 TEST=Manual, send SMS while logged in and see desktop notification Review URL: http://codereview.chromium.org/6776015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79987 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Incorporates review comments from last review. I somehow missedsky@chromium.org2011-03-241-4/+5
| | | | | | | | | | | | | them. Sorry. BUG=67227 TEST=see bug TBR=brettw@chromium.org R=brettw@chromium.org Review URL: http://codereview.chromium.org/6676114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79294 0039d316-1c4b-4281-b951-d872f2087c98
* Makes browser init not duplicate any tabs that are in both the set ofsky@chromium.org2011-03-231-2/+23
| | | | | | | | | | | | startup urls and last of pinned tabs. BUG=67227 TEST=see bug R=brettw@chromium.org Review URL: http://codereview.chromium.org/6705010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79198 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a lot more unused strings, mostly from settings.estade@chromium.org2011-03-181-1/+1
| | | | | | | | | | | There are plenty more strings flagged by the script, but it's not clear to me they should be removed (e.g., they may exist to make a translation cut-off even if they aren't used in the UI yet) BUG=none TEST=trybots Review URL: http://codereview.chromium.org/6677094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78762 0039d316-1c4b-4281-b951-d872f2087c98
* Rewritten MountLibrary to work with non-blocking mount API calls in libcros.zelidrag@chromium.org2011-03-171-8/+10
| | | | | | | | BUG=chromium-os:13190 TEST=none Review URL: http://codereview.chromium.org/6674043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78612 0039d316-1c4b-4281-b951-d872f2087c98
* Move the remaining files in chrome\common to content\common.jam@chromium.org2011-03-171-1/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6672070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78516 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome crashed infobar should be alert yellow.tfarina@chromium.org2011-03-121-19/+15
| | | | | | | | | | | | | | - No need to override the GetInfoBarType, because it's WARNING_TYPE by default which give us the yellow color. - While I'm here add OVERRIDE to some methods. BUG=75082 TEST=see bug. R=atwilson@chromium.org Review URL: http://codereview.chromium.org/6682017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77919 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show startup infobars in non-startup Browsers.agl@chromium.org2011-03-111-1/+2
| | | | | | | | | | | | | | r75602 introduced a regression by adding startup infobars when restoring a session: startup infobars would be shown in each new Browser (i.e. when a user creates a new window in an existing session via ProcessSingleton). BUG=75654 TEST=Start Chrome, navigate somewhere and crash it. Start Chrome again. Note the startup infobar. Start Chrome again so that a window is created in the existing session. There should not be any startup infobars. Review URL: http://codereview.chromium.org/6665003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77820 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: remove a ToWStringHack in command line URL codeevan@chromium.org2011-03-081-32/+34
| | | | | | | | | | | | We can't search for something unless we can convert it to Unicode. Also, rather than duplicating code for the "treat as URL" case, fall through to shared code. BUG=69467 Review URL: http://codereview.chromium.org/6624074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77363 0039d316-1c4b-4281-b951-d872f2087c98
* Removing references to off the record in comments and log messages.akalin@chromium.org2011-03-081-2/+2
| | | | | | | | | | | Original patch by vipul.bhasin@gmail.com. BUG=3333 TEST=None Review URL: http://codereview.chromium.org/6625076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77331 0039d316-1c4b-4281-b951-d872f2087c98
* Add startup infobar for Monoscope.agl@chromium.org2011-03-071-0/+47
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6488029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77154 0039d316-1c4b-4281-b951-d872f2087c98
* Split infobar_delegate.[cc,h] into separate pieces for the different classes ↵tfarina@chromium.org2011-03-031-1/+2
| | | | | | | | | | | defined within, so that each piece is shorter and clearer. BUG=None TEST=None Review URL: http://codereview.chromium.org/6598057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76677 0039d316-1c4b-4281-b951-d872f2087c98
* Added "--login-user=" option for the Guest session.altimofeev@chromium.org2011-03-021-6/+1
| | | | | | | | | | | | Fixes regression which happened after http://codereview.chromium.org/6272016. BUG=chromium-os:12236, chromium-os:12568, chromium-os:12319 TEST=try to set theme in the guest session. Review URL: http://codereview.chromium.org/6602010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76519 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the temporary headers left behind in chrome\browser. I've left ↵jam@chromium.org2011-03-011-6/+6
| | | | | | | | | browser_thread.h for another change, since 450 files include it. TBR=avi Review URL: http://codereview.chromium.org/6596060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76326 0039d316-1c4b-4281-b951-d872f2087c98
* Open the home page on launch even when there are pinned tabs.sadrul@chromium.org2011-02-281-0/+5
| | | | | | | | | | | BUG=55153 TEST=RetorePinnedTab Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76245 Review URL: http://codereview.chromium.org/6602002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76309 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 76245 - Open the home page on launch even when there are pinned tabs.rdsmith@chromium.org2011-02-281-5/+0
| | | | | | | | | | | | BUG=55153 TEST=manually, see bug Review URL: http://codereview.chromium.org/6602002 TBR=sadrul@chromium.org Review URL: http://codereview.chromium.org/6602014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76255 0039d316-1c4b-4281-b951-d872f2087c98
* Open the home page on launch even when there are pinned tabs.sadrul@chromium.org2011-02-281-0/+5
| | | | | | | | | BUG=55153 TEST=manually, see bug Review URL: http://codereview.chromium.org/6602002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76245 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI: Move more files from chrome/browser/webui to chrome/browser/ui/webui.tfarina@chromium.org2011-02-271-1/+1
| | | | | | | | | | | | I'm moving the files I have found with: $ ls chrome/browser/webui | grep _ui BUG=59946 TEST=trybots Review URL: http://codereview.chromium.org/6599024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76183 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor app launching code for clarity. Add unit tests.skerner@chromium.org2011-02-231-26/+72
| | | | | | | | | | | BUG=None TEST=BrowserInitTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75625 Review URL: http://codereview.chromium.org/6543006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75743 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crashes when the ExtensionService isn't present (e.g. incognito, chrome ↵piman@google.com2011-02-221-0/+4
| | | | | | | | | | | | | os before login). This is a workaround until http://code.google.com/p/chromium/issues/detail?id=73768 is fixed. BUG=73658 TEST=with chromeos=1 build, go to any site and check no crash. Review URL: http://codereview.chromium.org/6544023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75651 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 75625 - Refactor app launching code for clarity. Add unit tests.hansl@chromium.org2011-02-221-72/+26
| | | | | | | | | | | | | | Was failing on check_perms. Check http://build.chromium.org/p/chromium/builders/Linux/builds/3520 for more info. BUG=None TEST=BrowserInitTest.* Review URL: http://codereview.chromium.org/6543006 TBR=skerner@google.com Review URL: http://codereview.chromium.org/6469100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75643 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor app launching code for clarity. Add unit tests.skerner@google.com2011-02-221-26/+72
| | | | | | | | | BUG=None TEST=BrowserInitTest.* Review URL: http://codereview.chromium.org/6543006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75625 0039d316-1c4b-4281-b951-d872f2087c98
* Show startup infobars when restoring session.agl@chromium.org2011-02-221-8/+16
| | | | | | | | | | | | | | At the moment, startup infobars (such as the bar which warns about --no-sandbox) doesn't show at startup if the user has their preferences set to restore the previous session. This is because the RestoreSessionSynchronously code path never hits the logic to show them. BUG=none TEST=Set preferences to restore previous session at startup. Close and restart Chrome with --no-sandbox. Verify that the warning infobar appears. Review URL: http://codereview.chromium.org/6532062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75602 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI: Move more files from chrome/browser/dom_ui to chrome/browser/webui. ↵tfarina@chromium.org2011-02-181-1/+1
| | | | | | | | | | | Part 4. BUG=59945, 59946 TEST=trybots Review URL: http://codereview.chromium.org/6532045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75380 0039d316-1c4b-4281-b951-d872f2087c98
* Add a histogram to track application launches by type. Unfortunately, this ↵jstritar@chromium.org2011-02-161-0/+37
| | | | | | | | | | | undercounts apps that are launched via a URL that redirects to the app's web extent. BUG=62410 TEST=None. Review URL: http://codereview.chromium.org/6312189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75122 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug that caused Chrome OS system preferences not to work in the guest ↵satorux@chromium.org2011-02-161-0/+7
| | | | | | | | | | | | | | | | mode. Before this change, we were initializing Chrome OS system preferences in ProfileImpl's constructor, but this didn't work in the guest mode, since we'll switch the profile implementation (GuestSessionProfile) afterward in the guest mode. BUG=chromium-os:11912 TEST=confirm that "Enable tap-to-click" works both in the guest and the normal mode. Review URL: http://codereview.chromium.org/6484033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75067 0039d316-1c4b-4281-b951-d872f2087c98
* Hide network notification only when user initiates a new connection.chocobo@chromium.org2011-02-151-0/+2
| | | | | | | | BUG=chromium-os:9642 TEST=1) Try connecting to a network with bad password. See failure notification. Manually initiate a new connection and make sure notification gets hidden automatically. 2) If a new connection is initiated by the system automatically when it roams, make sure that the notification does not get hidden. Review URL: http://codereview.chromium.org/6499007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74994 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for incorrect tab count when starting testing automation.dtu@chromium.org2011-02-121-58/+67
| | | | | | | | | | | | | | Previously it just used args().size() to determine the number of initial tabs loaded, but this could be incorrect if some of the args are invalid URLs. Now it will call GetURLsFromCommandLine() to get the correct number of valid URLs. GetURLsFromCommandLine() is moved from BrowserInit::LaunchWithProfile to a static function in BrowserInit because it is now used in another place. BUG=72254 TEST=none STATUS=Fixed Review URL: http://codereview.chromium.org/6246157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74718 0039d316-1c4b-4281-b951-d872f2087c98
* Fix presentation of infobar for non-warning messages. Their colour isrogerta@chromium.org2011-02-091-0/+5
| | | | | | | | | | | | | | | currently yellow, but should be blue like other non-warning messages. The bug mentions 3 infobars: save passwords, did you mean..., and always restore. However, save passwords is already the correct colour, so I only needed to fix the two others. BUG=9037 TEST=Force the display of the corresponding infobar and look at the colour. Review URL: http://codereview.chromium.org/6312188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74295 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup:pkasting@chromium.org2011-02-081-4/+2
| | | | | | | | | | | | | | | | | | | | | | * Change int to size_t in a few APIs. * Rename infobar_delegate_count() to infobar_count() in preparation for TabContents owning InfoBars rather than InfoBarDelegates. * Move some code from PluginInstallerInfoBarDelegate to PluginObserver since it's more related to who's instantiating the infobar(delegate)s. * Unify InfoBarDelegate behavior by making no delegates auto-add themselves to tabs (callers now all do this explicitly). * Eliminate unused member TabContentsSSLHelper::SSLAddCertData::handler_. * De-inline a couple classes. * Make more functions private. * Add some consts. * Change DCHECK() to DCHECK_EQ() where possible. * Rename the delegates in plugin_observer.cc to have "Delegate" in the names. * Remove unnecessary qualifiers. * Simplify. * Misc. style issues, naming issues, etc. BUG=none TEST=none Review URL: http://codereview.chromium.org/6250172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74086 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: allow binding remote debugging to provided interface.pfeldman@chromium.org2011-02-041-0/+1
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/6334105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73796 0039d316-1c4b-4281-b951-d872f2087c98
* - Add ChromeOS login and lock screen automation hooks.dtu@chromium.org2011-02-011-0/+6
| | | | | | | | | | | | | | - Add AutomationProxy::SendJSONRequest that does not require a handle to a Browser/BrowserProxy. - Fix issue where AutomationProvider thinks it's never finished loading the login screen. - Not included: UI tests for login, since they should be PyAuto tests. - Not included: fix for Chrome quitting as a result of channel disconnect. BUG=chromium-os:11538 TEST=none Review URL: http://codereview.chromium.org/6320022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73327 0039d316-1c4b-4281-b951-d872f2087c98
* Introduced a new policy DefaultBrowserSettingEnabled.pastarmovj@chromium.org2011-02-011-0/+14
| | | | | | | | | | | | | | When set it either enforces Chrome's registration as default browser, or prevents the user from seeing the reminder about Chrome not being default as well as disabled the UI for setting it as default browser. When not set the old behavior is observed. BUG=65290 TEST=Manual. Set the policy and the UI should be disabled. If set to true the browser should become default browser immediately. Review URL: http://codereview.chromium.org/6348021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73280 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: enable remote debugging with front-end served from the cloud.pfeldman@chromium.org2011-01-311-6/+11
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/6356015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73146 0039d316-1c4b-4281-b951-d872f2087c98
* Implement pref policy for disabling incognito mode.finnur@chromium.org2011-01-271-2/+5
| | | | | | | | | | | 2nd attempt with shutdown crash fix (only difference is in browser.cc). BUG=66413 TEST=None Review URL: http://codereview.chromium.org/6279012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72791 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup:pkasting@chromium.org2011-01-261-8/+3
| | | | | | | | | | | | | * Remove AlertInfoBarDelegate. There are basically no users of this (the only one is in autofill which is really trying to make something like a confirm info bar). * Change the default button set for a ConfirmInfoBarDelegate from 0 buttons to 2 to match how practically every caller uses it. Note that this doesn't remove views' AlertInfoBar yet. AlertInfoBar is now only used as a base for ConfirmInfoBar, but actually moving that functionality into ConfirmInfoBar is to come in a subsequent patch. BUG=none TEST=none Review URL: http://codereview.chromium.org/6262018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72726 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 72624 (due to crashes) - Implement pref policy for disabling ↵finnur@chromium.org2011-01-261-5/+2
| | | | | | | | | | | | | | incognito mode. BUG=66413 TEST=None Review URL: http://codereview.chromium.org/6313008 TBR=finnur@chromium.org Review URL: http://codereview.chromium.org/6399001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72630 0039d316-1c4b-4281-b951-d872f2087c98
* Implement pref policy for disabling incognito mode.finnur@chromium.org2011-01-261-2/+5
| | | | | | | | | BUG=66413 TEST=None Review URL: http://codereview.chromium.org/6313008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72624 0039d316-1c4b-4281-b951-d872f2087c98
* Add --enable-nacl to the list of infobar-generating flags.abarth@chromium.org2011-01-251-1/+4
| | | | | | | | | For M10, we don't want folks to turn on NaCl persistently because its API surface hasn't been vetted as thoroughly as we would like. Review URL: http://codereview.chromium.org/6299017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72560 0039d316-1c4b-4281-b951-d872f2087c98
* Modify chrome to accept a pdf file on the command line and upload it to ↵scottbyer@chromium.org2011-01-241-0/+6
| | | | | | | | | | | | | Cloud Print via the Cloud Print dialog Contributed by abodenha@google.com BUG=none TEST=Run Chrome on Windows with --cloud-print-file=<Path to PDF> and --cloud-print-job-title Review URL: http://codereview.chromium.org/6038008 Patch from Albert Bodenhamer <abodenha@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72392 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to ui/baseben@chromium.org2011-01-211-1/+1
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: de-inline a bunch of classes, rename and move "PluginInstaller" to ↵pkasting@chromium.org2011-01-211-126/+213
| | | | | | | | | | "PluginInstallerInfoBarDelegate" for clarity, lots of other misc. stuff BUG=none TEST=none Review URL: http://codereview.chromium.org/6249010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72166 0039d316-1c4b-4281-b951-d872f2087c98
* Move ResourceBundle, DataPack to ui/baseben@chromium.org2011-01-201-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6263008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
* Update references part 2: files in chrome/browser/ui/msw@chromium.org2011-01-191-1/+1
| | | | | | | | | | | | | | | | Update chrome/browser/gtk references & copyright dates of touched files. Re-alphabetize include lists as necessary from this change. Update header guard & add EOF newline in chrome/browser/ui/view_ids.h Split C/C++ system headers into blocks in: chrome/browser/ui/gtk/gtk_expanded_container.cc chrome/browser/ui/gtk/gtk_chrome_shrinkable_hbox.cc Sync manually with r71749 BUG=69289 TEST=none Review URL: http://codereview.chromium.org/6296012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71816 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from TemplateURL and friends.avi@chromium.org2011-01-191-3/+3
| | | | | | | | | | | Re-landing r71485 (which was reverted in r71500). BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6278007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71814 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71485 - Remove wstring from TemplateURL and friends.avi@chromium.org2011-01-141-3/+3
| | | | | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6322001 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6291003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71500 0039d316-1c4b-4281-b951-d872f2087c98