| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1/1.
(Note: This was a TODO for beng).
Also remove browser_window.h stub file as all the includes to it were already updated.
BUG=None
TEST=None
R=avi@chromium.org
Review URL: http://codereview.chromium.org/6820015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2/3.
BUG=None
TEST=None
R=avi@chromium.org
Review URL: http://codereview.chromium.org/6805012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes us initialize the listener for brightness changes
and volume key presses earlier (we used to do it in
BrowserInit; now we do it in BrowserMain) and makes
SettingLevelBubble attempt to use the login background window
as its parent if it can't find a browser window.
BUG=chromium-os:13226
TEST=manual testing: used volume and brightness keys both before and after login and checked that the bubbles appeared onscreen
Review URL: http://codereview.chromium.org/6748011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:12006
TEST=Manual, send SMS while logged in and see desktop notification
Review URL: http://codereview.chromium.org/6776015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
them. Sorry.
BUG=67227
TEST=see bug
TBR=brettw@chromium.org
R=brettw@chromium.org
Review URL: http://codereview.chromium.org/6676114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
startup urls and last of pinned tabs.
BUG=67227
TEST=see bug
R=brettw@chromium.org
Review URL: http://codereview.chromium.org/6705010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There are plenty more strings flagged by the script, but it's not clear to me they should be removed (e.g., they may exist to make a translation cut-off even if they aren't used in the UI yet)
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/6677094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:13190
TEST=none
Review URL: http://codereview.chromium.org/6674043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=avi
Review URL: http://codereview.chromium.org/6672070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- No need to override the GetInfoBarType, because it's WARNING_TYPE by default which give us the yellow color.
- While I'm here add OVERRIDE to some methods.
BUG=75082
TEST=see bug.
R=atwilson@chromium.org
Review URL: http://codereview.chromium.org/6682017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r75602 introduced a regression by adding startup infobars when restoring
a session: startup infobars would be shown in each new Browser (i.e.
when a user creates a new window in an existing session via
ProcessSingleton).
BUG=75654
TEST=Start Chrome, navigate somewhere and crash it. Start Chrome again. Note the startup infobar. Start Chrome again so that a window is created in the existing session. There should not be any startup infobars.
Review URL: http://codereview.chromium.org/6665003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We can't search for something unless we can convert it to Unicode.
Also, rather than duplicating code for the "treat as URL" case,
fall through to shared code.
BUG=69467
Review URL: http://codereview.chromium.org/6624074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Original patch by vipul.bhasin@gmail.com.
BUG=3333
TEST=None
Review URL: http://codereview.chromium.org/6625076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6488029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
defined within, so that each piece is shorter and clearer.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6598057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes regression which happened after
http://codereview.chromium.org/6272016.
BUG=chromium-os:12236, chromium-os:12568, chromium-os:12319
TEST=try to set theme in the guest session.
Review URL: http://codereview.chromium.org/6602010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
browser_thread.h for another change, since 450 files include it.
TBR=avi
Review URL: http://codereview.chromium.org/6596060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=55153
TEST=RetorePinnedTab
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76245
Review URL: http://codereview.chromium.org/6602002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=55153
TEST=manually, see bug
Review URL: http://codereview.chromium.org/6602002
TBR=sadrul@chromium.org
Review URL: http://codereview.chromium.org/6602014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=55153
TEST=manually, see bug
Review URL: http://codereview.chromium.org/6602002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm moving the files I have found with:
$ ls chrome/browser/webui | grep _ui
BUG=59946
TEST=trybots
Review URL: http://codereview.chromium.org/6599024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=BrowserInitTest.*
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75625
Review URL: http://codereview.chromium.org/6543006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
os before login).
This is a workaround until http://code.google.com/p/chromium/issues/detail?id=73768 is fixed.
BUG=73658
TEST=with chromeos=1 build, go to any site and check no crash.
Review URL: http://codereview.chromium.org/6544023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Was failing on check_perms. Check http://build.chromium.org/p/chromium/builders/Linux/builds/3520 for more info.
BUG=None
TEST=BrowserInitTest.*
Review URL: http://codereview.chromium.org/6543006
TBR=skerner@google.com
Review URL: http://codereview.chromium.org/6469100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=BrowserInitTest.*
Review URL: http://codereview.chromium.org/6543006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At the moment, startup infobars (such as the bar which warns about
--no-sandbox) doesn't show at startup if the user has their preferences
set to restore the previous session. This is because the
RestoreSessionSynchronously code path never hits the logic to show them.
BUG=none
TEST=Set preferences to restore previous session at startup. Close and restart Chrome with --no-sandbox. Verify that the warning infobar appears.
Review URL: http://codereview.chromium.org/6532062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part 4.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6532045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
undercounts apps that are launched via a URL that redirects to the app's web extent.
BUG=62410
TEST=None.
Review URL: http://codereview.chromium.org/6312189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mode.
Before this change, we were initializing Chrome OS system preferences
in ProfileImpl's constructor, but this didn't work in the guest mode,
since we'll switch the profile implementation (GuestSessionProfile)
afterward in the guest mode.
BUG=chromium-os:11912
TEST=confirm that "Enable tap-to-click" works both in the guest and the normal mode.
Review URL: http://codereview.chromium.org/6484033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:9642
TEST=1) Try connecting to a network with bad password. See failure notification. Manually initiate a new connection and make sure notification gets hidden automatically. 2) If a new connection is initiated by the system automatically when it roams, make sure that the notification does not get hidden.
Review URL: http://codereview.chromium.org/6499007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously it just used args().size() to determine the number of initial tabs loaded, but this could be incorrect if some of the args are invalid URLs. Now it will call GetURLsFromCommandLine() to get the correct number of valid URLs.
GetURLsFromCommandLine() is moved from BrowserInit::LaunchWithProfile to a static function in BrowserInit because it is now used in another place.
BUG=72254
TEST=none
STATUS=Fixed
Review URL: http://codereview.chromium.org/6246157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
currently yellow, but should be blue like other non-warning messages.
The bug mentions 3 infobars: save passwords, did you mean..., and always
restore. However, save passwords is already the correct colour, so I only
needed to fix the two others.
BUG=9037
TEST=Force the display of the corresponding infobar and look at the colour.
Review URL: http://codereview.chromium.org/6312188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Change int to size_t in a few APIs.
* Rename infobar_delegate_count() to infobar_count() in preparation for TabContents owning InfoBars rather than InfoBarDelegates.
* Move some code from PluginInstallerInfoBarDelegate to PluginObserver since it's more related to who's instantiating the infobar(delegate)s.
* Unify InfoBarDelegate behavior by making no delegates auto-add themselves to tabs (callers now all do this explicitly).
* Eliminate unused member TabContentsSSLHelper::SSLAddCertData::handler_.
* De-inline a couple classes.
* Make more functions private.
* Add some consts.
* Change DCHECK() to DCHECK_EQ() where possible.
* Rename the delegates in plugin_observer.cc to have "Delegate" in the names.
* Remove unnecessary qualifiers.
* Simplify.
* Misc. style issues, naming issues, etc.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6250172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6334105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add AutomationProxy::SendJSONRequest that does not require a handle to a Browser/BrowserProxy.
- Fix issue where AutomationProvider thinks it's never finished loading the login screen.
- Not included: UI tests for login, since they should be PyAuto tests.
- Not included: fix for Chrome quitting as a result of channel disconnect.
BUG=chromium-os:11538
TEST=none
Review URL: http://codereview.chromium.org/6320022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When set it either enforces Chrome's registration as default browser,
or prevents the user from seeing the reminder about Chrome not being default
as well as disabled the UI for setting it as default browser. When not set
the old behavior is observed.
BUG=65290
TEST=Manual. Set the policy and the UI should be disabled. If set to true the browser should become default browser immediately.
Review URL: http://codereview.chromium.org/6348021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6356015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
2nd attempt with shutdown crash fix (only difference is in browser.cc).
BUG=66413
TEST=None
Review URL: http://codereview.chromium.org/6279012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove AlertInfoBarDelegate. There are basically no users of this (the only one is in autofill which is really trying to make something like a confirm info bar).
* Change the default button set for a ConfirmInfoBarDelegate from 0 buttons to 2 to match how practically every caller uses it.
Note that this doesn't remove views' AlertInfoBar yet. AlertInfoBar is now only used as a base for ConfirmInfoBar, but actually moving that functionality into ConfirmInfoBar is to come in a subsequent patch.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6262018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
incognito mode.
BUG=66413
TEST=None
Review URL: http://codereview.chromium.org/6313008
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/6399001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=66413
TEST=None
Review URL: http://codereview.chromium.org/6313008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For M10, we don't want folks to turn on NaCl persistently because its API
surface hasn't been vetted as thoroughly as we would like.
Review URL: http://codereview.chromium.org/6299017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cloud Print via the Cloud Print dialog
Contributed by abodenha@google.com
BUG=none
TEST=Run Chrome on Windows with --cloud-print-file=<Path to PDF> and --cloud-print-job-title
Review URL: http://codereview.chromium.org/6038008
Patch from Albert Bodenhamer <abodenha@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
"PluginInstallerInfoBarDelegate" for clarity, lots of other misc. stuff
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6249010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6263008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update chrome/browser/gtk references & copyright dates of touched files.
Re-alphabetize include lists as necessary from this change.
Update header guard & add EOF newline in chrome/browser/ui/view_ids.h
Split C/C++ system headers into blocks in:
chrome/browser/ui/gtk/gtk_expanded_container.cc
chrome/browser/ui/gtk/gtk_chrome_shrinkable_hbox.cc
Sync manually with r71749
BUG=69289
TEST=none
Review URL: http://codereview.chromium.org/6296012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Re-landing r71485 (which was reverted in r71500).
BUG=23581
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6278007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6322001
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/6291003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71500 0039d316-1c4b-4281-b951-d872f2087c98
|