| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
policy.
Enum may take 3 values:
* ENABLED (default) - both normal and incognito modes are allowed.
* DISABLED - incognito mode cannot be used.
* FORCED - browsing is only possible in incognito mode.
Mapped IncognitoEnabled::false to IncognitoModeAvailability::DISABLED when IncognitoModeAvailability policy/pref is not set.
Removed IncognitoEnabled pref (no longer used).
BUG=69580
TEST=
Review URL: http://codereview.chromium.org/7520023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CloudPrintProxyService is now owned by CloudPrintProxyServiceFactory,
using Profile as a key. This uses the ProfileKeyedService infrastructure
originally created for ThemeServiceFactory.
BUG=77155
TEST=existing tests
Review URL: http://codereview.chromium.org/6792047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=76788
TEST=no change visible
Review URL: http://codereview.chromium.org/7531004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
devtools files.
BUG=84078
TEST=
Review URL: http://codereview.chromium.org/7453021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7477008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clear local cache on exit
BUG=69580
TEST=configuration_policy_pref_store_unittest.cc
Review URL: http://codereview.chromium.org/7399021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=80790
TEST=touch compiles
Review URL: http://codereview.chromium.org/6975045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
content/common/result_codes.h contains only the codes defined in content. chrome/common/chrome_result_codes.h contains the codes defined in chrome and also includes (for convenience) the content header.
R=jam@chromium.org
BUG=76699
TEST=everything compiles
Review URL: http://codereview.chromium.org/7397004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builds compile.
TBR=jam@chromium.org
BUG=none
TEST=
Review URL: http://codereview.chromium.org/7400002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a new file into chrome/common and does a lot of renaming.
The current version is just a sketch of the headers, and nothing will
compile.
R=jam@chromium.org
BUG=76699
TEST=everything still compiles and runs
Review URL: http://codereview.chromium.org/7377010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved the CanSetAsDefaultBrowser / ProtocolClient functions next to the
routines which do the setting of Chrome to be the default browser and
client.
BUG=88196
TEST=Manual testing performed
Review URL: http://codereview.chromium.org/7334003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73195
TEST=none
Review URL: http://codereview.chromium.org/7352006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- remove duplicate code between most_visited_handler.cc and top_sites.cc
- remove dead code in most_visited_handler.cc
- remove duplicate favicon resources
- update favicon resources by adding 32x32s resource for NTP stock most visited pages
- uniformly refer to PRODUCT_NAME rather than sometimes using "google chrome" in chromium builds on the NTP
- consolidate some resources (IDR_CHROME_STORE_PAGE_FAVICON and IDR_WESBTORE_ICON_16 for example)
- remove unused thumbnail for webstore (which is slightly distinct from the themes gallery because there's no &category=theme in the URL)
as a precursor, I had to add an icon to chrome/app/theme/google_chrome (internal repository)
as a cleanup after, I will have to remove an icon from the same
BUG=none
TEST=trybots; manual
Review URL: http://codereview.chromium.org/7342001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
now that we've tweaked things. If it does, I'll continue to investigate.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
infobars.
Previously, we looked at the user gesture state when deciding whether to
dismiss infobars. Now that WebKit's user gesture state doesn't lie, we can
tell that this behavior is incorrect. Page-specific infobars, like translate,
should close whenever the main frame navigates to a new page, regardless of
whether that navigation was conducted from a user gesture.
BUG=86417
Review URL: http://codereview.chromium.org/7205026
TBR=abarth@chromium.org
Review URL: http://codereview.chromium.org/7324001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
active tab if it's the new tab page. This is necessary to properly
persist startup tabs, or other tabs the user may have created before
hitting the restore button. I also tweaked the public API to take a
bitmask instead of a bunch of bools.
BUG=27005
TEST=see bug
R=brettw@chromium.org
Review URL: http://codereview.chromium.org/7307023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, we looked at the user gesture state when deciding whether to
dismiss infobars. Now that WebKit's user gesture state doesn't lie, we can
tell that this behavior is incorrect. Page-specific infobars, like translate,
should close whenever the main frame navigates to a new page, regardless of
whether that navigation was conducted from a user gesture.
BUG=86417
Review URL: http://codereview.chromium.org/7205026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
installerdata/master_preferences. I suppose that an empty GURL used to trigger the NTP, but that is no longer the case. It appears that the right way to do this is to use chrome://newtab, for which we have a nice constant.
BUG=86493
TEST=specify http://new_tab_page as a first_run_tab as per http://crbug/9706 and see that it works.
Review URL: http://codereview.chromium.org/7205003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove infobar warning for accelerated 2d canvas flag
This is a partial revert of r88616, so a partial un-revert of r86510
BUG=82348
TEST=none
TBR=vangelis@chromium.org
Review URL: http://codereview.chromium.org/7104112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NOTE: Temporarily disabling accelerated 2d canvas by default
Turns on the gpu accelerated canvas by default
BUG=82017
TEST=none
Review URL: http://codereview.chromium.org/7064032
TBR=junov@chromium.org
Review URL: http://codereview.chromium.org/6995124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to go through the newly made ProfileKeyedServiceFactory subclass.
In addition, makes further modifications to the unit testing stuff because the TemplateURL tests change the active TemplateURLService on a profile during the test.
BUG=77155
TEST=unit tests
R=mirandac
Review URL: http://codereview.chromium.org/7056056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
their own file in the |content| namespace. Remove un-necessary includes of
navigation_controller.h.
BUG=none
TEST=everything compiles
Review URL: http://codereview.chromium.org/7008018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
At startup we check the protocol handlers from the profile for urls passed in on the cmd line,
BUG=73710
TEST=Manual
Review URL: http://codereview.chromium.org/7071011
Patch from Ben Wells <benwells@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
not change.
BUG=chromium-os:14880
TEST=Click "play" button on an audion file in the file browser. Check that the mediaplayer panel has popped up. Click on another file. Check that the mediaplayer playlist panel has popped up and contains 2 items.
Review URL: http://codereview.chromium.org/7067020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gets rid of more use of net/ globals, replacing with URLRequestJobFactory uses. Helps make net/ more thread-compatible.
BUG=81979
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86802
Review URL: http://codereview.chromium.org/7019030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GViewRequestInterceptor.
Gets rid of more use of net/ globals, replacing with URLRequestJobFactory uses. Helps make net/ more thread-compatible.
BUG=81979
TEST=none
Review URL: http://codereview.chromium.org/7019030
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/7075005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Gets rid of more use of net/ globals, replacing with URLRequestJobFactory uses. Helps make net/ more thread-compatible.
BUG=81979
TEST=none
Review URL: http://codereview.chromium.org/7019030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Turns on the gpu accelerated canvas by default
BUG=82017
TEST=none
Review URL: http://codereview.chromium.org/7064032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We will stop providing Chrome releases for Ubuntu Hardy-era distros.
We should at least inform those users about this.
(Retry of r85956, with views fix.)
BUG=79401
TEST=tried manually changing code to require a newer GTK, saw infobar
Review URL: http://codereview.chromium.org/7012024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r85956, failed on views.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We will stop providing Chrome releases for Ubuntu Hardy-era distros.
We should at least inform those users about this.
BUG=79401
TEST=tried manually changing code to require a newer GTK, saw infobar
Review URL: http://codereview.chromium.org/7012024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It now displays a link instead of a button for the "Learn more" action.
I intend to reuse this for the "Your OS is obsolete" infobar.
BUG=79401
Review URL: http://codereview.chromium.org/7047012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In Google news, you can change the UI language through a popup menu [which does so by submitting a form programmatically]. The translation infobar wasn't being refreshed in this situation because the page navigation being performed is programmatic.
Infobar hiding on navigation, goes through TabContents::ExpireInfoBars() which has an early return if the navigation just performed wasn't initiated by the user. After this, the code loops through the list of infobars and calls ShouldExpire() on each one to determine if it can be closed.
This CL removes the early return and moves the code to determine dismissal to the ShouldExpire() method of the infobar delegates, thus allowing the translate infobar to indicate that it can be dismissed on page navigation.
BUG=70261
TEST=See bug.
Review URL: http://codereview.chromium.org/6883299
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=76792
Review URL: http://codereview.chromium.org/7010017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
URLRequest::Interceptor and URLRequest::ProtocolFactory are globally registered. This causes a variety of problems. This provides a method for replacing them.
It used to be the case that we used net::URLRequest::IsHandledProtocol()/net::URLRequest::IsHandledURL() to see if the request would be handled by Chrome, or deferred to an external protocol handler. This required that URLRequest be aware of all protocol handlers.
We instead provide ProfileIOData::IsHandledProtocol(), which checks to see if there are any Chrome registered protocol handlers, and if not, checks the default ones in net::URLRequest.
Note this doesn't work for custom handlers (registerProtocolHandler) because they are dynamic and profile-specific. We would have to add a member function to ProfileIOData and not use a global. This is problematic since we check ProfileIOData::IsHandledProtocol in the RenderViewContextMenu, which runs on the UI thread, whereas ProfileIOData lives on the IO thread. RenderViewContextMenu is using also using it synchronously, which makes it a pain to support.
So, we don't support custom handlers in ProfileIOData::IsHandledProtocol(). This means that "save as" won't work for custom handlers. Seems ok for now.
This also fixes the multiprofile/incognito bugs where if a profile registers a custom handler, and then a different profile / an incognito profile registers the same custom handler and then unregisters it, which globally unregisters it, so the original profile is now broken. By removing the use of the globals, we fix this.
Also fixes a bunch of style guide violations in the ProtocolHandler/ProtocolHandlerRegistry code.
This changelist replaces two existing URLRequest::ProtocolFactory uses: chrome-extension/user-script and custom handlers.
Also improve the tests in ResourceDispatcherHost so we don't have to do as many NULL checks. Change the MockResourceContext to create a TestURLRequestContext.
BUG=81979
TEST=none
Review URL: http://codereview.chromium.org/6960006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Significant refactoring with some notable behavior changes:
1. Switches are appended preceding existing arguments (after other swtiches).
2. (Windows) command_line_string() is generated and properly quoted/escaped.
3. Appended switches will retain their (optional) included prefixes (--,-,/).
Notable internal changes (shouldn't affect behavior):
1. (Windows) Generate the cl string, instead of storing&updating the original.
2. Explicitly retain switch prefixes (--,-,/) (was automatic in init*/ctor).
Update (obvious) code expecting switches to be appended antecedent to args.
Add Nico's test from: codereview.chromium.org/6728016/.
An intermediary CL landed between patch set 3 and 4, see:
http://codereview.chromium.org/6596020
BUG=73195,67764
TEST=Commandline usage.
Review URL: http://codereview.chromium.org/6526040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=82348
Review URL: http://codereview.chromium.org/7015015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
launched from the Omnibox.
BUG=81379
TEST=Install Scratchpad extension (from Google). Launch it from the Omnibox and it should launch as a panel app. Test Paste and Go also like you normally would (it is affected).
Review URL: http://codereview.chromium.org/6913022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Existing tests
R=ben@chromium.org,stevenjb@chromium.org,phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/6697032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
non-virtual one. This is a step along the way to killing it entirely. This also adds a lot of OVERRIDE markers and does some other cleanup in a few places.
The original (stupid) design for the delegate class left subclasses great flexibility in how they mapped infobars to delegates. In practice, no one ever wanted multiple infobars driven off a single delegate, so the mapping was always one-to-one. As a result, it was always correct for InfoBarClosed() to "delete this", but because the base class did not do so, every subclass needed to. Most did; the others leaked memory and failed to run their destructors.
This change forces the base class to delete itself. This fixes the delegate leaks in the couple subclasses that failed to do this. It also eliminates a lot of copy-and-pasted "delete this" implementations.
Ultimately, we'll be moving to a model where the InfoBar "view" class owns the delegate and deletes it directly, which will eliminate InfoBarClosed() completely.
BUG=62154
TEST=none
Review URL: http://codereview.chromium.org/6926001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=77590
TEST=start chrome with '--enable-nacl', or turn it on in about:flags and restart. Confirm that _no_ infobar appears saying 'You are using an unsupported command-line flag: --enable-nacl. Stability and security will suffer.'.
Review URL: http://codereview.chromium.org/6913029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6902156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BaseSessionService is now a ProfileKeyedService. Its subclasses,
SessionService and TabRestoreService, are now accessed through
factories.
BUG=77155
TEST=existing tests
Review URL: http://codereview.chromium.org/6901031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:14305
TEST=
Review URL: http://codereview.chromium.org/6882069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=carnitas
TEST=visual
Review URL: http://codereview.chromium.org/6883095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes some light refactoring to give all platforms a
platform_util::CanSetAsDefaultBrowser() function. The .xib change links the
set-as-default button with the new IBOutlet.
BUG=79814
TEST=Canary.app should never offer to set as the default browser in the
first run dialog or in an infobar.
Review URL: http://codereview.chromium.org/6881058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AddTabTypes::ADD_SELECTED -> ADD_ACTIVE
SelectTabContentsAt -> ActivateTabAt
BUG=none
TEST=none
R=ben@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6840007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
An old feature let users launch any URL with the --app command line switch. This change separates out non app --app launches into a separate histogram.
BUG=78357
TEST=None.
Review URL: http://codereview.chromium.org/6851003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserMain. This allows the print dialog to work even if chrome is already running.
BUG=
TEST=Run Chrome.exe normally then run a second copy with
--cloud-print-file="<some valid file>" Also, run chrome.exe with --cloud-print-file with no other chrome.exe running.
In both cases, the print dialog should display.
Review URL: http://codereview.chromium.org/6833012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome.fileBrowserPrivate.onChanged.addListener(function(mountDirUrl) {
...
});
BUG=chromium-os:13025
TEST=none
Review URL: http://codereview.chromium.org/6749024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81208 0039d316-1c4b-4281-b951-d872f2087c98
|