| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Other LAYOUT_EXPERIMENT_* are only counted on first start. Unfortunately LAYOUT_EXPERIMENT_NONE is being counted on every start.
With this change we only count LAYOUT_EXPERIMENT_NONE on first start.
BUG=115056
TEST=
Review URL: https://chromiumcodereview.appspot.com/9395081
TBR=sail@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9478005
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@123758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we record which version of the sync promo a user was shown from the SyncPromoUI constructor.
This lead to a problem where we didn't count the "don't show sync promo" trial. To fix this we explicitly record the "don't show" trial in BrowserInit.
BUG=113135
TEST=
Review URL: http://codereview.chromium.org/9358017
TBR=sail@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9371023
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@121280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with no
selected tab, which triggers the crash. This fix is to be merged over
to the branch. Subsequentely I'll add some more debugging code to
isolate what's triggering the crash.
BUG=110909
TEST=none
R=pkasting@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9339004
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9351006
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows on startup.
BUG=112590
TEST=ProfileManager.LastOpenedProfilesDoesNotContainIncognito
Review URL: https://chromiumcodereview.appspot.com/9320068
TBR=marja@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9307124
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a new version of the sync promo that is displayed inside a blocking dialog window.
If a new browser window is spawned from inside the sync promo then we close the dialog box and foucs on the new window. Any remaining first run tabs are added as inactive tabs to the new browser window.
Screenshots: http://imgur.com/iBspQ
BUG=107219
TEST=
Review URL: https://chromiumcodereview.appspot.com/9225053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=99653
TEST=Use the auto-login features (regular and reverse) and then visit the
about:histograms page. Should see stats called AutoLogin.Regular and
AutoLogin.Reverse. There should be buckets for shown, accpted, rejected,
and ignored, which are 0 to 3 respectively.
Review URL: http://codereview.chromium.org/9234037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- When started with --profile-directory, launch only one profile.
- Don't launch additional profiles which wouldn't open any pages. (When restarting
after an update, all profiles will reopen last pages.) The last active profile
is always launched.
BUG=99088,111118
TEST=See bugs.
Review URL: http://codereview.chromium.org/9117024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*) Removed temporary 'protector.enabled' pref.
*) Renamed --disable-protector back to --no-protector ("bad flag" on platforms other than ChromeOS).
BUG=None
TEST=Manual with and without --no-protector
Review URL: http://codereview.chromium.org/9270041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
https://chromiumcodereview.appspot.com/9240027/
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, launch the profiles in the order they became active. (Windows are
still not launched in the original order, since that information is lost.)
BUG=109816
TEST=See bug & BrowserInitTest.UpdateWithTwoProfiles
Review URL: http://codereview.chromium.org/9232007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also rename TestTabContentsView to TestWebContentsView.
Add content namespace to both.
TBR=owners (trivial updates)
BUG=98716
Review URL: http://codereview.chromium.org/9241011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IDS_SYSTEM_OBSOLETE_MESSAGE
IDS_FLAGS_RELAUNCH_NOTICE
IDS_AUTO_LAUNCH_INFOBAR_TEXT
IDS_CREATE_SHORTCUTS_ERROR_LABEL
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/9107064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Have the service process periodically launch the browser (if not connected to
the browser already) with a command line switch that instructs the browser to
check the policy, shut the service down if it's set, then quit. If the service
is already connected to the browser, the launch is not done since the browser
is already watching for policy changes and would immediately inform the
service.
BUG=98049
TEST=Launch the browser, sign into the cloud print connector, quit the browser,
set the policy, wait a long time (8 hours) or relaunch the service process -
the service process should end up disabled and shut itself down.
Review URL: http://codereview.chromium.org/8905023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=110043
TEST=Manual: Protector bubble only triggered when 'protector.enabled' == true in Local State.
Review URL: http://codereview.chromium.org/9134008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9190024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Upon startup, all profiles which had browsers open at the last exit are restored.
This will restore the last open pages if the profile settings so dictate.
BUG=99088
TEST=see bug & ProfileManagerTest.LastActiveProfiles(AtShutdown)?, BrowserInitTest.StartupURLsForTwoProfiles
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117033
Review URL: http://codereview.chromium.org/9087009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pages."
This reverts commit 2e2929bd78578081b5665fcea6d085793df2c233.
TBR=marja@chromium.org
BUG=99088
TEST=none
Review URL: http://codereview.chromium.org/9181004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Upon startup, all profiles which had browsers open at the last exit are restored.
This will restore the last open pages if the profile settings so dictate.
BUG=99088
TEST=see bug & ProfileManagerTest.LastActiveProfiles(AtShutdown)?, BrowserInitTest.StartupURLsForTwoProfiles
Review URL: http://codereview.chromium.org/9087009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves more files from chrome/browser/chromeos/ into
subdirectories.
BUG=chromium-os:22896
TEST=did chrome os builds both with and without aura
TBR=sky
Review URL: http://codereview.chromium.org/9125006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
wrong profile. Using the default profile is the wrong thing when in
guest mode on chrome os.
TEST=see bug
BUG=106209
R=davemoore@chromium.org,battre@chromium.org
Review URL: http://codereview.chromium.org/9014020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=98919
TEST=existing
Review URL: http://codereview.chromium.org/9111032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a HasSwitch check before trying to access the contents of the switch when displaying the cloud print dialog from the command line.
BUG=108687
TEST=
Review URL: http://codereview.chromium.org/9008053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/9085006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
content::NavigationController in a separate change.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/9091002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
GetSelectedWebContents, and update all dependent code.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/9074012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Browser::GetSelectedWebContents. I've converted the easy ones, I'll do the ones with more dependencies in a separate change to keep things trivial to review.
I considered taking out GetSelectedTabContents altogether and having people just use GetSelectedTabContentsWrapper()->web_contents() per the existing comment in browser.h, but there are a lot of callers and it seemed too long to type.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/9015022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
refactors:
IsChromeFirstRun()
CreateSentinel()
RemoveSentinel()
GetFirstRunSentinelFilePath()
It also fixed an issue that chromeos first run won't create sentinel file, and the following runs always think it is a first run.
BUG=108137
TEST=None
Review URL: http://codereview.chromium.org/8989043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
content\public and put them in the content namespace. Make PageNavigator use WebContents instead of TabContents. While I'm touching all the callers, I've removed the deprecated PageNavigator function and converted users to the new one.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8991012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SavePersistentPrefs calls to CommitPendingWrites.
TBR=ncarter@chromium.org
BUG=99306
TEST=none
Review URL: http://codereview.chromium.org/8198007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
tab_contents(), as well as all the dependent code.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8982008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=98716
Review URL: http://codereview.chromium.org/8949066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=98716
TBR=tburkard
Review URL: http://codereview.chromium.org/8999005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=rogerta
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8995003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) shows up on First Run of Chrome (for the right experiment brand code).
2) takes precedent over the 'Chrome is not your default browser' infobar.
3) is not shown if other infobars are present.
Also some minor cleanup:
- Renamed IsInAutoLaunchGroup to IsInAutoLaunchFieldTrial (better fit).
- Moved brand specific code to auto_launch_trial namespace (easier to find) and created meaningful function names for'em.
BUG=106801
TEST=This requires a special branded build (see instructions for http://codereview.chromium.org/8729009).
Review URL: http://codereview.chromium.org/8969024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Register with the component updater service if it's discovered that WebGL is blacklisted. Then register the swiftshader library with the GPU data manager.
BUG=26001
TEST=Start up chrome on a blacklisted windows machine, wait a while, and open a webgl page
Review URL: http://codereview.chromium.org/8897008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
is for Windows only.
BUG=95971
TEST=This requires a special branded build to test (and master_preferences set to have auto_launch_chrome: true or specify mini_installer param --auto-launch-chrome), but after installing it you should see an item under the Wrench \ Options \ Basics that lets you configure Chrome to not auto-launch. If you instead, log out and log in again, Chrome should start with an infobar saying that it was auto-launched. The infobar should stay for a max of 5 launches and then not appear again. Pressing "Cut it out!" on the infobar should turn off this feature. If you just want to test the infobar, launch chrome with --auto-launch-at-startup. Also, uninstall and make sure Chrome is not auto-launched (a Windows error about Chrome not being found should not be shown).
Review URL: http://codereview.chromium.org/8729009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding tests + minor code cleanup.
BUG=NONE
TEST=BrowserListTest.AttemptRestart, BrowserInitTest.ReadingWasRestartAfter(Restart|NormalStart)
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114441
Review URL: http://codereview.chromium.org/8929027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, this CL moves chrome/browser/ui/webui/sync_promo_* to
chrome/browser/ui/webui/sync_promo/sync_promo_*.
BUG=107223
R=stevet@chromium.org,rogerta@chromium.org,sail@chromium.org
TEST=The sync promo responds to brand code and records results of the field
trial correctly.
Review URL: http://codereview.chromium.org/8933003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hidden behind a commandline flag '--enable-pnacl'.
Still some of TODOs: finalize the metadata associated with the CRX, figure out what to do when a NaCl plugin needs Pnacl, but it's not there yet.
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2365
TEST= none yet, only manually test:
(1) put a pnacl omaha config in the omaha sandbox, pointing at a crx.
(2) run out/Debug/chrome --user-data-dir=/tmp/temp_profile/ --enable-pnacl --component-updater-debug=fast-update --apps-gallery-update-url=http://omaha.sandbox.google.com/service/update2/crx
check /tmp/temp_profile/PNaCl/0.1.0.X is installed after a few seconds.
restart chrome, check that PathService registers /tmp/temp_profile/PNaCl/0.1.0.X soonish.
Review URL: http://codereview.chromium.org/8348026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding tests + minor code cleanup.
BUG=NONE
TEST=BrowserListTest.AttemptRestart, BrowserInitTest.ReadingWasRestartAfter(Restart|NormalStart)
Review URL: http://codereview.chromium.org/8929027
TBR=marja@chromium.org
Review URL: http://codereview.chromium.org/8916006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding tests + minor code cleanup.
BUG=NONE
TEST=BrowserListTest.AttemptRestart, BrowserInitTest.ReadingWasRestartAfter(Restart|NormalStart)
Review URL: http://codereview.chromium.org/8929027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reset the kWasRestarted pref upon successful restart. Set it only when restarting. Write
the persistent preferences after setting it.
The preference was introduced in http://codereview.chromium.org/8745015.
BUG=106948
TEST=see bug
Review URL: http://codereview.chromium.org/8937001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=105872
TEST=no functional change
Review URL: http://codereview.chromium.org/8892011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using the "-profile-directory" switch didn't work if the browser was already running.
The problem was that we were ignoring the switch and just using the last used profile.
BUG=100461
TEST=Ran Chrome with the first profile open. Launched a 2nd instance with "-profile-directory" and verified that the correct profile window opened.
Review URL: http://codereview.chromium.org/8854001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also removes several accessors on BrowserProcess that are no longer used.
I wanted to remove all retrieval of MessageLoop objects via BrowserThread, but this proved harder than it looked, because several net:: classes use MessageLoop and have fairly deep assumptions that it is a real MessageLoop, e.g. they use MessageLoopForIO with its IO observers and so forth. Therefore, we now have UnsafeGetMessageLoopForThread but UnsafeGetBrowserThread is gone.
TBR=abodenha@chromium.org
BUG=98716
Review URL: http://codereview.chromium.org/8769013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in a preference.
This way ChromiumOS can run the same session restore code as Chrome.
BUG=1870
TEST=NONE
Review URL: http://codereview.chromium.org/8745015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8776046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* theme_service.cc.
* browser_browsertest.cc.
* browser_init.cc.
* certificate_dialogs.cc.
* login_prompt.cc.
BUG=none
TEST=none
R=groby@chromium.org
Review URL: http://codereview.chromium.org/8725022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DevTools remote debugging protocol supersedes the legacy protocol and old implementation should be removed.
BUG=104625
TEST=Existing tests
Review URL: http://codereview.chromium.org/8635005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
Review URL: http://codereview.chromium.org/8665009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111365 0039d316-1c4b-4281-b951-d872f2087c98
|