| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Valid states are normal, minimized and maximized. Actual behavior depends on OS and window type.
BUG=10828
TEST=ExtensionApiTest.UpdateWindowShowState
Review URL: http://codereview.chromium.org/8586045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8533030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As of July, the mini-gallery simply redirects to the web store (b/4990237).
BUG=101405
TEST=no user-visible changes
Review URL: http://codereview.chromium.org/8404007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Shortcut on Views and GTK is Control-Shift-M. Shortcut on Mac is Command-Shift-M.
BUG=75782
TEST=
Review URL: http://codereview.chromium.org/8356028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:21738, chromium-os:20525
TEST=none
Review URL: http://codereview.chromium.org/8271025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, add a UpdateFullscreenExitBubbleContent() method.
At both call site and implementor side, just funnel the previous bool
through the enum for now.
This decouples the implementation of the new UI from the backend
support.
Based on a patch by Yuzhu Shen <yzshen@chromium.org>
BUG=95136
TEST=everything works as before
TBR=ben (OWNERS review for this part is at http://codereview.chromium.org/8274022/ )
Review URL: http://codereview.chromium.org/8313012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
preview when we shouldn't. Here's the sequence that would trigger it:
1. focus the omnibox (which triggers loading the InstantLoader).
2. Type in a string that'll autocomplete to a url.
3. Arrow over a search suggestion to a non-search entry.
4. Press enter.
When you arrow over a non-search we'll hide (what was
DestroyPreviewContentsAndLeaveActive) the preview. But if between
steps 3 and 4 we get a response back from the page with suggestions
we'll set displayable_ to true and think everything is up to
date. This leads to IsCurrent returning true when it isn't.
To fix this I've nuked is_active(), which was a bit confusing anyway
and added is_out_date_ (still confusing, but at least it's private).
BUG=100368
TEST=covered by test, see bug for test scenario.
R=sreeram@chromium.org,ben@chromium.org
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8298005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a site enters fullscreen a bubble should appear, both to give the user the option to exit fullscreen and to inform them that the site has entered fullscreen. This patch implements that behaviour on Windows and Mac.
XIB changes: (FullScreenExitBubble.xib)
* Added explanatory text field.
* Added "allow" and "deny" buttons.
* Changed from View into Window.
BUG=73923
TEST=
Review URL: http://codereview.chromium.org/7740044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
their background color. Unfortunately since they can't automatically determine what that backgruond color is it has to be manually set. (I suppose I could try to add some crazy hierarchy-walking code looking for views::Background objects, but that seems like a bad move.) There is also a disable switch, which I use in a few places where I couldn't figure out what the background color actually is, or where updating it is really annoying.
In theory, we might want to apply this to other controls like text buttons, but since those are usually rendered with explicit background images there's probably not a ton of win there.
This also makes some other cleanup changes like converting a few wstrings to string16s, de-inlining some class member functions, etc. Some of these were mandated by the presubmitter :/
BUG=92
TEST=Things still look OK
Review URL: http://codereview.chromium.org/8221027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There doesn't seem to be a strong need for the fade, so remove it, eliminating
some complexity and potential bugs. I've verified that it fixes bug 99755. I'm
not able to reproduce bug 99789 yet, but presumably, it will be fixed as well
(since there won't be any fades any more).
BUG=99755,99789
TEST=See bugs and description above.
Review URL: http://codereview.chromium.org/8232028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=31763,99332
TEST=side tabs no longer work
Review URL: http://codereview.chromium.org/8166008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the user clicks on the NTP login status we now show the avatar menu.
BUG=93179
TEST=Tested on Views. Mac build pending.
Review URL: http://codereview.chromium.org/8110003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I don't see any reason for this method to exist.
It was part of the following call stack:
TaskManagerDialogImpl::OpenHtmlDialog from
ui/webui/task_manager_dialog.cc calls
Browser::BrowserShowHtmlDialog() from ui/browser.cc,
which calls
BrowserView::ShowHTMLDialog() from ui/views/frame/browser_view.cc,
which calls
browser::ShowHtmlDialog() from ui/views/html_dialog_view.cc,
which calls
browser::CreateViewsWindow() from ui/views/window.cc,
which calls
chromeos::BubbleWindow::Create()
(with a hardcoded parameter that I want to change.) :-(
No functional changes intended.
BUG=chromium-os:20998
TEST=built and ran it
Review URL: http://codereview.chromium.org/8083024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=89162
TEST=none
Review URL: http://codereview.chromium.org/8041014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=95146
TEST=
Review URL: http://codereview.chromium.org/7892022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=new browser test
Review URL: http://codereview.chromium.org/7537030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To split the ConstrainedWindow feature off of TabContents entirely (moving it
to a helper object on TabContentsWrapper), I'll need to first make each
constrained window TabContentsWrapper aware first. I started just hacking
BUG=95257
TEST=compiles
Review URL: http://codereview.chromium.org/7831051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Extends session service to support more generalized "show" state encompassing maximized, minimized, and normal window states. This includes forward-migration logic from old stored session data. Mac changes to save and restore minimized windows as well as fixes for window position. Linux/GTK changes to save and restore minimized windows. Windows/Views changes to follow.
BUG=43274
TEST=Manual. SessionServiceTest.*
Review URL: http://codereview.chromium.org/7621061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If the other Task Manager opens, closes it and opens new Task Manager on the current window.
BUG=chromium-os:8272
TEST=manual on chromium-os
Review URL: http://codereview.chromium.org/7604032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Panels.
BUG=None
TEST=PanelBrowserTest.FindBar
Review URL: http://codereview.chromium.org/7538010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes:
- Add new "Enter Presentation Mode" menu item with Cmd-Shift-F.
- Change key equivalent for "Enter Full Screen" to Cmd-Opt-F.
On Lion:
This CL separates the concepts of "fullscreen mode" and "presentation mode."
Fullscreen mode uses Lion's fullscreen mode and places the window in its own
space. Presentation mode is an extra option to additionally hide the UI when in
fullscreen mode. On Lion, clicking on the fullscreen button takes you into
fullscreen mode, in which there is a button to toggle presentation mode on or
off. While in normal windowed mode, there are two menu options to either "Enter
Full Screen" or "Enter Presentation Mode" directly.
On Snow Leopard:
This CL does not change much on Snow Leopard. To maintain consistency with the
new Lion terminology, the "Enter Full Screen" menu item has been renamed to
"Enter Presentation Mode."
BUG=74065
TEST=Fullscreen works in Lion. Fullscreen continues to work as before in Snow Leopard.
Review URL: http://codereview.chromium.org/7566016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pushes that state to the BrowserWindow when it changes (except during
tab switches, when it's assumed the browserwindow polls). The problem
with the current code is that as the BookmarkBar queries for state
during painting and layout, it was possible for that state without the
bookmarkbar being layed out. This resulted in the bookmark bar
painting attached even when it was given the detached state.
I'm also plumbing through one case of when the bookmark bar state
changes that wasn't being handled.
BUG=87137
TEST=see bug, but make sure you don't notice any problems with
bookmark bar visibility changes (such as toggling visibility, or
turning off and navigating back/to the new tab page).
R=pkasting@chromium.org,brettw@chromium.org,estade@chromium.org
TBR=pinkerton@chromium.org, dimich@google.com
Review URL: http://codereview.chromium.org/7237001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7108047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to go through the newly made ProfileKeyedServiceFactory subclass.
In addition, makes further modifications to the unit testing stuff because the TemplateURL tests change the active TemplateURLService on a profile during the test.
BUG=77155
TEST=unit tests
R=mirandac
Review URL: http://codereview.chromium.org/7056056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
currently only active in windows. This is well hidden behind a flag and a context menu option.
Loosely based off oshima's original prototype patch: http://codereview.chromium.org/165272
BUG=None
TEST=Activate the cnav prototype in about:flags. Right click a tab and select "Hide Toolbar" to go into cnav mode. Ensure that the compact location bar provides the same basic functionality as the toolbar (except browser actions).
Review URL: http://codereview.chromium.org/6913026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prototype, currently only active in windows. This is well hidden behind a flag and a context menu option.
Loosely based off oshima's original prototype patch: http://codereview.chromium.org/165272
BUG=None
TEST=Activate the cnav prototype in about:flags. Right click a tab and select "Hide Toolbar" to go into cnav mode. Ensure that the compact location bar provides the same basic functionality as the toolbar (except browser actions).
Review URL: http://codereview.chromium.org/6913026
TBR=stevet@chromium.org
Review URL: http://codereview.chromium.org/7005004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
currently only active in windows. This is well hidden behind a flag and a context menu option.
Loosely based off oshima's original prototype patch: http://codereview.chromium.org/165272
BUG=None
TEST=Activate the cnav prototype in about:flags. Right click a tab and select "Hide Toolbar" to go into cnav mode. Ensure that the compact location bar provides the same basic functionality as the toolbar (except browser actions).
Review URL: http://codereview.chromium.org/6913026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This cleans up some code and fixes a related chromium-os issue:
* Adds a user_gesture parameter to browser::NavigateParams
* Adds AdjustNavigateParams to BrowserWindow and calls that from browser::NavigateParams to make browser window / view class specific changes
* Eliminates Browser::CreateForPopup in favor of browser::Navigate, unifying code paths for spawning popups (thus fixing chromium-os:10978)
BUG=chromium:78853,chromium-os:10978
TEST=Test opening popup windows with a range of sizes and parameters on all OSs (panels on ChromeOS)
Review URL: http://codereview.chromium.org/6881073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
using it. Rename BrowserWindow::SelectedTabToolbarSizeChanged() to ToolbarSizeChanged() as there are no per-tab toolbars since we made the DownloadShelf per-window a while ago.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6870002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6860002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and into a standalone function. This way we can show the error dialog
if no browser is around (as can happen during startup).
BUG=74639
TEST=none
R=ben@chromium.org,avi@chromium.org,estade@chromium.org
Review URL: http://codereview.chromium.org/6838031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
dependent implementation will be added later.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6799001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class provides a platform independent implementation of
BrowserWindow interface. This is the BrowserWindow instance that'll be
created for panels. This contains a platform specific implementation of
BrowserWindow that'll be used for actually creating the UI.
TEST=none
BUG=73936
modified: chrome/browser/ui/browser_window.h
new file: chrome/browser/ui/panels/panel.cc
new file: chrome/browser/ui/panels/panel.h
modified: chrome/chrome_browser.gypi
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6770021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add BrowserWindow::ShowInactive.
BUG=None
TEST=Added api test. Also tested manually on CR-48.
Review URL: http://codereview.chromium.org/6688036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=estade@chromium.org,avi@chromium.org
BUG=77091
TEST=none
Review URL: http://codereview.chromium.org/6729010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71097
TEST=none; no visible change
Review URL: http://codereview.chromium.org/6672059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Removes useless dependencies on themeing from content/
- Renames BrowserThemeProvider to ThemeService, along with name variants such
as GtkThemeService. BrowserThemeProvider has grown by a lot to be more than
an implementation of the ui::ThemeProvider interface. This change touches
everything.
- Rename theme_service.{h,cc} (which defined ThemeServiceFactory) to
theme_service_factory.{h,cc}.
BUG=77155
TEST=compiles.
Review URL: http://codereview.chromium.org/6727005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
There are probably a few more bits and pieces that can be removed, but I think this is the majority of it.
BUG=51934
Review URL: http://codereview.chromium.org/6576020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=75320
TEST=none
Review URL: http://codereview.chromium.org/6670011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6612062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=75320
TEST=none
Review URL: http://codereview.chromium.org/6646029
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/6657016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=75320
TEST=none
Review URL: http://codereview.chromium.org/6646029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=avi
Review URL: http://codereview.chromium.org/6598086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compile
Review URL: http://codereview.chromium.org/6581015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
exposing getters for TC, routing_id, and sending messages.
Review URL: http://codereview.chromium.org/6537004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71097
TEST=Hammer on search engines on all platforms. Namely, autocreation of search engines, and pages that have OpenSearch tags. Nothing should crash, break, or have any user-visible change.
Review URL: http://codereview.chromium.org/6515014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
focus parameter is passed and how setting window bounds in window.update doesn't work when a window is full screen.
BUG=65371
TEST=ExtensionApiTest.UpdateWindowDoesNotUnmaximize
Review URL: http://codereview.chromium.org/6392036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added "highlight_background_resources" param to BrowserWindow::ShowTaskManager()
and added support in Cocoa for drawing highlights.
BUG=71490
TEST=Click View Background Pages, see background pages are highlighted in yellow.
Review URL: http://codereview.chromium.org/6312178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71063
TEST=compiled
Review URL: http://codereview.chromium.org/6312156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See Issue 70141 for the full move details; see my inline review comments.
Changes significantly different from or beyond those prescribed by the bug:
*Consolidated a lot of GrabWindowSnapshot code.
*Moved EnsureRectIsVisibleInRect to views::internal namespace for test access.
*Moved app/win/win_util_unittest.cc to views/window/window_win_unittest.h
*Named ui/base/message_box_win.h instead of ui/base/message_box.h
*Made WindowWin::GetWindowTitleFont static; needed in static contexts.
*Denoted WindowWin::FrameTypeChanged as a Window override, moved code.
*Moved TestGrabWindowSnapshot into new file: chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm
BUG=70141
TEST=none
Review URL: http://codereview.chromium.org/6386009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73589 0039d316-1c4b-4281-b951-d872f2087c98
|