summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ui/browser_window.h
Commit message (Collapse)AuthorAgeFilesLines
* Add extension API to change window show state using chrome.windows.update().jennb@chromium.org2011-11-221-0/+5
| | | | | | | | | | | | Valid states are normal, minimized and maximized. Actual behavior depends on OS and window type. BUG=10828 TEST=ExtensionApiTest.UpdateWindowShowState Review URL: http://codereview.chromium.org/8586045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111071 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove forward declarations in various chrome/browser directories.thestig@chromium.org2011-11-161-3/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8533030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110225 0039d316-1c4b-4281-b951-d872f2087c98
* Delete code for and references to mini-gallery and theme install bubbles.yoz@chromium.org2011-10-271-3/+0
| | | | | | | | | | | As of July, the mini-gallery simply redirects to the web store (b/4990237). BUG=101405 TEST=no user-visible changes Review URL: http://codereview.chromium.org/8404007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107527 0039d316-1c4b-4281-b951-d872f2087c98
* Add shortcut to show avatar menusail@chromium.org2011-10-251-0/+3
| | | | | | | | | | | | Shortcut on Views and GTK is Control-Shift-M. Shortcut on Mac is Command-Shift-M. BUG=75782 TEST= Review URL: http://codereview.chromium.org/8356028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107226 0039d316-1c4b-4281-b951-d872f2087c98
* Moved mobile activation into its own modal dialog.zelidrag@chromium.org2011-10-241-0/+3
| | | | | | | | BUG=chromium-os:21738, chromium-os:20525 TEST=none Review URL: http://codereview.chromium.org/8271025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106964 0039d316-1c4b-4281-b951-d872f2087c98
* Change EnterFullscreen() to take an enum instead of a bool as second parameter.thakis@chromium.org2011-10-171-4/+10
| | | | | | | | | | | | | | | | | | | | Also, add a UpdateFullscreenExitBubbleContent() method. At both call site and implementor side, just funnel the previous bool through the enum for now. This decouples the implementation of the new UI from the backend support. Based on a patch by Yuzhu Shen <yzshen@chromium.org> BUG=95136 TEST=everything works as before TBR=ben (OWNERS review for this part is at http://codereview.chromium.org/8274022/ ) Review URL: http://codereview.chromium.org/8313012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105770 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in instant where we would end up incorrectly using thesky@chromium.org2011-10-151-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | preview when we shouldn't. Here's the sequence that would trigger it: 1. focus the omnibox (which triggers loading the InstantLoader). 2. Type in a string that'll autocomplete to a url. 3. Arrow over a search suggestion to a non-search entry. 4. Press enter. When you arrow over a non-search we'll hide (what was DestroyPreviewContentsAndLeaveActive) the preview. But if between steps 3 and 4 we get a response back from the page with suggestions we'll set displayable_ to true and think everything is up to date. This leads to IsCurrent returning true when it isn't. To fix this I've nuked is_active(), which was a bit confusing anyway and added is_out_date_ (still confusing, but at least it's private). BUG=100368 TEST=covered by test, see bug for test scenario. R=sreeram@chromium.org,ben@chromium.org TBR=ben@chromium.org Review URL: http://codereview.chromium.org/8298005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105664 0039d316-1c4b-4281-b951-d872f2087c98
* Implement fullscreen info bubble on Win and Mac.jeremya@chromium.org2011-10-151-2/+5
| | | | | | | | | | | | | | | | When a site enters fullscreen a bubble should appear, both to give the user the option to exit fullscreen and to inform them that the site has entered fullscreen. This patch implements that behaviour on Windows and Mac. XIB changes: (FullScreenExitBubble.xib) * Added explanatory text field. * Added "allow" and "deny" buttons. * Changed from View into Window. BUG=73923 TEST= Review URL: http://codereview.chromium.org/7740044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105649 0039d316-1c4b-4281-b951-d872f2087c98
* Make views::Label and views::Link auto-color themselves to be readable over ↵pkasting@chromium.org2011-10-121-4/+3
| | | | | | | | | | | | | | their background color. Unfortunately since they can't automatically determine what that backgruond color is it has to be manually set. (I suppose I could try to add some crazy hierarchy-walking code looking for views::Background objects, but that seems like a bad move.) There is also a disable switch, which I use in a few places where I couldn't figure out what the background color actually is, or where updating it is really annoying. In theory, we might want to apply this to other controls like text buttons, but since those are usually rendered with explicit background images there's probably not a ton of win there. This also makes some other cleanup changes like converting a few wstrings to string16s, de-inlining some class member functions, etc. Some of these were mandated by the presubmitter :/ BUG=92 TEST=Things still look OK Review URL: http://codereview.chromium.org/8221027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105189 0039d316-1c4b-4281-b951-d872f2087c98
* Remove fading in/out for Instant previews.sreeram@chromium.org2011-10-121-3/+0
| | | | | | | | | | | | | | | There doesn't seem to be a strong need for the fade, so remove it, eliminating some complexity and potential bugs. I've verified that it fixes bug 99755. I'm not able to reproduce bug 99789 yet, but presumably, it will be fixed as well (since there won't be any fades any more). BUG=99755,99789 TEST=See bugs and description above. Review URL: http://codereview.chromium.org/8232028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105178 0039d316-1c4b-4281-b951-d872f2087c98
* views: remove vertical tabsthakis@chromium.org2011-10-061-3/+0
| | | | | | | | | | BUG=31763,99332 TEST=side tabs no longer work Review URL: http://codereview.chromium.org/8166008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104319 0039d316-1c4b-4281-b951-d872f2087c98
* Show avatar menu from NTP4sail@chromium.org2011-10-061-0/+6
| | | | | | | | | | | | If the user clicks on the NTP login status we now show the avatar menu. BUG=93179 TEST=Tested on Views. Mac build pending. Review URL: http://codereview.chromium.org/8110003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104300 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BrowserWindow::ShowHTMLDialog().derat@chromium.org2011-10-011-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I don't see any reason for this method to exist. It was part of the following call stack: TaskManagerDialogImpl::OpenHtmlDialog from ui/webui/task_manager_dialog.cc calls Browser::BrowserShowHtmlDialog() from ui/browser.cc, which calls BrowserView::ShowHTMLDialog() from ui/views/frame/browser_view.cc, which calls browser::ShowHtmlDialog() from ui/views/html_dialog_view.cc, which calls browser::CreateViewsWindow() from ui/views/window.cc, which calls chromeos::BubbleWindow::Create() (with a hardcoded parameter that I want to change.) :-( No functional changes intended. BUG=chromium-os:20998 TEST=built and ran it Review URL: http://codereview.chromium.org/8083024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103608 0039d316-1c4b-4281-b951-d872f2087c98
* Remove compact navigation code.thakis@chromium.org2011-09-261-3/+0
| | | | | | | | | BUG=89162 TEST=none Review URL: http://codereview.chromium.org/8041014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102742 0039d316-1c4b-4281-b951-d872f2087c98
* Show global error bubble view when creating new browser windowsail@chromium.org2011-09-191-0/+1
| | | | | | | | | BUG=95146 TEST= Review URL: http://codereview.chromium.org/7892022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101843 0039d316-1c4b-4281-b951-d872f2087c98
* Make panel adjust bounds per preferred size change notification on Windows.jianli@chromium.org2011-09-071-0/+8
| | | | | | | | BUG=none TEST=new browser test Review URL: http://codereview.chromium.org/7537030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99880 0039d316-1c4b-4281-b951-d872f2087c98
* content: Move collected cookies constrained window to TabContentsWrapper.erg@chromium.org2011-09-071-1/+1
| | | | | | | | | | | | | | To split the ConstrainedWindow feature off of TabContents entirely (moving it to a helper object on TabContentsWrapper), I'll need to first make each constrained window TabContentsWrapper aware first. I started just hacking BUG=95257 TEST=compiles Review URL: http://codereview.chromium.org/7831051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99872 0039d316-1c4b-4281-b951-d872f2087c98
* Restoring a session should restore window minimization statedhollowa@chromium.org2011-08-221-0/+3
| | | | | | | | | | | Extends session service to support more generalized "show" state encompassing maximized, minimized, and normal window states. This includes forward-migration logic from old stored session data. Mac changes to save and restore minimized windows as well as fixes for window position. Linux/GTK changes to save and restore minimized windows. Windows/Views changes to follow. BUG=43274 TEST=Manual. SessionServiceTest.* Review URL: http://codereview.chromium.org/7621061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97646 0039d316-1c4b-4281-b951-d872f2087c98
* Showing Task manager on the foreground window.yoshiki@chromium.org2011-08-161-2/+2
| | | | | | | | | | | If the other Task Manager opens, closes it and opens new Task Manager on the current window. BUG=chromium-os:8272 TEST=manual on chromium-os Review URL: http://codereview.chromium.org/7604032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96881 0039d316-1c4b-4281-b951-d872f2087c98
* Make BrowserWindow::CreateFindBar non-static so that it can be overridden by ↵jennb@chromium.org2011-08-081-3/+3
| | | | | | | | | | | Panels. BUG=None TEST=PanelBrowserTest.FindBar Review URL: http://codereview.chromium.org/7538010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95897 0039d316-1c4b-4281-b951-d872f2087c98
* Fullscreen support for Lion.rohitrao@chromium.org2011-08-041-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | XIB changes: - Add new "Enter Presentation Mode" menu item with Cmd-Shift-F. - Change key equivalent for "Enter Full Screen" to Cmd-Opt-F. On Lion: This CL separates the concepts of "fullscreen mode" and "presentation mode." Fullscreen mode uses Lion's fullscreen mode and places the window in its own space. Presentation mode is an extra option to additionally hide the UI when in fullscreen mode. On Lion, clicking on the fullscreen button takes you into fullscreen mode, in which there is a button to toggle presentation mode on or off. While in normal windowed mode, there are two menu options to either "Enter Full Screen" or "Enter Presentation Mode" directly. On Snow Leopard: This CL does not change much on Snow Leopard. To maintain consistency with the new Lion terminology, the "Enter Full Screen" menu item has been renamed to "Enter Presentation Mode." BUG=74065 TEST=Fullscreen works in Lion. Fullscreen continues to work as before in Snow Leopard. Review URL: http://codereview.chromium.org/7566016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95518 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidates managing of bookmark bar state to browser. Browser nowsky@chromium.org2011-06-241-7/+5
| | | | | | | | | | | | | | | | | | | | | | | pushes that state to the BrowserWindow when it changes (except during tab switches, when it's assumed the browserwindow polls). The problem with the current code is that as the BookmarkBar queries for state during painting and layout, it was possible for that state without the bookmarkbar being layed out. This resulted in the bookmark bar painting attached even when it was given the detached state. I'm also plumbing through one case of when the bookmark bar state changes that wasn't being handled. BUG=87137 TEST=see bug, but make sure you don't notice any problems with bookmark bar visibility changes (such as toggling visibility, or turning off and navigating back/to the new tab page). R=pkasting@chromium.org,brettw@chromium.org,estade@chromium.org TBR=pinkerton@chromium.org, dimich@google.com Review URL: http://codereview.chromium.org/7237001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90405 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate Window completely.ben@chromium.org2011-06-131-4/+0
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7108047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88905 0039d316-1c4b-4281-b951-d872f2087c98
* Changes TemplateURLModel into TemplateURLService. Changes all access points ↵erg@google.com2011-06-071-2/+2
| | | | | | | | | | | | | | to go through the newly made ProfileKeyedServiceFactory subclass. In addition, makes further modifications to the unit testing stuff because the TemplateURL tests change the active TemplateURLService on a profile during the test. BUG=77155 TEST=unit tests R=mirandac Review URL: http://codereview.chromium.org/7056056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88153 0039d316-1c4b-4281-b951-d872f2087c98
* The initial prototype code for the compact navigation (cnav) prototype, ↵stevet@chromium.org2011-05-111-0/+3
| | | | | | | | | | | | currently only active in windows. This is well hidden behind a flag and a context menu option. Loosely based off oshima's original prototype patch: http://codereview.chromium.org/165272 BUG=None TEST=Activate the cnav prototype in about:flags. Right click a tab and select "Hide Toolbar" to go into cnav mode. Ensure that the compact location bar provides the same basic functionality as the toolbar (except browser actions). Review URL: http://codereview.chromium.org/6913026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84971 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 84831 - The initial prototype code for the compact navigation (cnav) ↵bradnelson@google.com2011-05-101-3/+0
| | | | | | | | | | | | | | | prototype, currently only active in windows. This is well hidden behind a flag and a context menu option. Loosely based off oshima's original prototype patch: http://codereview.chromium.org/165272 BUG=None TEST=Activate the cnav prototype in about:flags. Right click a tab and select "Hide Toolbar" to go into cnav mode. Ensure that the compact location bar provides the same basic functionality as the toolbar (except browser actions). Review URL: http://codereview.chromium.org/6913026 TBR=stevet@chromium.org Review URL: http://codereview.chromium.org/7005004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84836 0039d316-1c4b-4281-b951-d872f2087c98
* The initial prototype code for the compact navigation (cnav) prototype, ↵stevet@chromium.org2011-05-101-0/+3
| | | | | | | | | | | | currently only active in windows. This is well hidden behind a flag and a context menu option. Loosely based off oshima's original prototype patch: http://codereview.chromium.org/165272 BUG=None TEST=Activate the cnav prototype in about:flags. Right click a tab and select "Hide Toolbar" to go into cnav mode. Ensure that the compact location bar provides the same basic functionality as the toolbar (except browser actions). Review URL: http://codereview.chromium.org/6913026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84831 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup popup related browser navigation code.stevenjb@google.com2011-04-281-0/+5
| | | | | | | | | | | | | | This cleans up some code and fixes a related chromium-os issue: * Adds a user_gesture parameter to browser::NavigateParams * Adds AdjustNavigateParams to BrowserWindow and calls that from browser::NavigateParams to make browser window / view class specific changes * Eliminates Browser::CreateForPopup in favor of browser::Navigate, unifying code paths for spawning popups (thus fixing chromium-os:10978) BUG=chromium:78853,chromium-os:10978 TEST=Test opening popup windows with a range of sizes and parameters on all OSs (panels on ChromeOS) Review URL: http://codereview.chromium.org/6881073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83399 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the TabContentsDelegate::ToolbarSizeChanged() method as no one was ↵pkasting@chromium.org2011-04-151-1/+1
| | | | | | | | | | using it. Rename BrowserWindow::SelectedTabToolbarSizeChanged() to ToolbarSizeChanged() as there are no per-tab toolbars since we made the DownloadShelf per-window a while ago. BUG=none TEST=none Review URL: http://codereview.chromium.org/6870002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81834 0039d316-1c4b-4281-b951-d872f2087c98
* Flesh out a bit more of Panel class.jennb@chromium.org2011-04-151-7/+0
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6860002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81757 0039d316-1c4b-4281-b951-d872f2087c98
* Moves responsibility for showing profile error dialog out of Browsersky@chromium.org2011-04-141-5/+0
| | | | | | | | | | | | | and into a standalone function. This way we can show the error dialog if no browser is around (as can happen during startup). BUG=74639 TEST=none R=ben@chromium.org,avi@chromium.org,estade@chromium.org Review URL: http://codereview.chromium.org/6838031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81637 0039d316-1c4b-4281-b951-d872f2087c98
* Implement PanelManager and hook up with Panel creation. The platform ↵jianli@chromium.org2011-04-081-0/+8
| | | | | | | | | | dependent implementation will be added later. BUG=none TEST=none Review URL: http://codereview.chromium.org/6799001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80981 0039d316-1c4b-4281-b951-d872f2087c98
* Add a stub implementation for Panel class.prasadt@chromium.org2011-04-041-2/+2
| | | | | | | | | | | | | | | | | | | | | This class provides a platform independent implementation of BrowserWindow interface. This is the BrowserWindow instance that'll be created for panels. This contains a platform specific implementation of BrowserWindow that'll be used for actually creating the UI. TEST=none BUG=73936 modified: chrome/browser/ui/browser_window.h new file: chrome/browser/ui/panels/panel.cc new file: chrome/browser/ui/panels/panel.h modified: chrome/chrome_browser.gypi R=ben@chromium.org Review URL: http://codereview.chromium.org/6770021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80332 0039d316-1c4b-4281-b951-d872f2087c98
* Add focused property to chrome.windows.create extension API.jennb@chromium.org2011-03-281-0/+4
| | | | | | | | | | | Add BrowserWindow::ShowInactive. BUG=None TEST=Added api test. Also tested manually on CR-48. Review URL: http://codereview.chromium.org/6688036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79620 0039d316-1c4b-4281-b951-d872f2087c98
* Moves instant related methods off TabContents and to where they are used.sky@chromium.org2011-03-251-1/+1
| | | | | | | | | | R=estade@chromium.org,avi@chromium.org BUG=77091 TEST=none Review URL: http://codereview.chromium.org/6729010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79447 0039d316-1c4b-4281-b951-d872f2087c98
* Split off web_app's ui into ui files, plumb TCW rather than TC.avi@chromium.org2011-03-241-1/+2
| | | | | | | | | BUG=71097 TEST=none; no visible change Review URL: http://codereview.chromium.org/6672059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79220 0039d316-1c4b-4281-b951-d872f2087c98
* Theme system cleanuperg@google.com2011-03-231-1/+1
| | | | | | | | | | | | | | | | | - Removes useless dependencies on themeing from content/ - Renames BrowserThemeProvider to ThemeService, along with name variants such as GtkThemeService. BrowserThemeProvider has grown by a lot to be more than an implementation of the ui::ThemeProvider interface. This change touches everything. - Rename theme_service.{h,cc} (which defined ThemeServiceFactory) to theme_service_factory.{h,cc}. BUG=77155 TEST=compiles. Review URL: http://codereview.chromium.org/6727005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79145 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Gears from Chrome.aa@chromium.org2011-03-111-3/+2
| | | | | | | | | | There are probably a few more bits and pieces that can be removed, but I think this is the majority of it. BUG=51934 Review URL: http://codereview.chromium.org/6576020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77888 0039d316-1c4b-4281-b951-d872f2087c98
* Options: Remove the GTK and Views native options code.jhawkins@chromium.org2011-03-111-4/+0
| | | | | | | | | BUG=75320 TEST=none Review URL: http://codereview.chromium.org/6670011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77878 0039d316-1c4b-4281-b951-d872f2087c98
* Options: Remove several deprecated Options-related methods from BrowserWindow.jhawkins@chromium.org2011-03-101-12/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6612062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77594 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77547 - Options: Remove the GTK options.jhawkins@chromium.org2011-03-091-2/+0
| | | | | | | | | | | | BUG=75320 TEST=none Review URL: http://codereview.chromium.org/6646029 TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/6657016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77552 0039d316-1c4b-4281-b951-d872f2087c98
* Options: Remove the GTK options.jhawkins@chromium.org2011-03-091-0/+2
| | | | | | | | | BUG=75320 TEST=none Review URL: http://codereview.chromium.org/6646029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77547 0039d316-1c4b-4281-b951-d872f2087c98
* Update more includes that were pointing to the old locations.jam@chromium.org2011-03-021-1/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6598086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76512 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency on Views::Window from platforms that don't support it.estade@chromium.org2011-02-241-1/+1
| | | | | | | | | BUG=none TEST=compile Review URL: http://codereview.chromium.org/6581015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75953 0039d316-1c4b-4281-b951-d872f2087c98
* Make TabContentsObserver handle registration automatically, as well as ↵jam@chromium.org2011-02-171-1/+1
| | | | | | | | exposing getters for TC, routing_id, and sending messages. Review URL: http://codereview.chromium.org/6537004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75226 0039d316-1c4b-4281-b951-d872f2087c98
* Move search engine stuff from TabContents to TabContentsWrapper.avi@chromium.org2011-02-151-1/+2
| | | | | | | | | BUG=71097 TEST=Hammer on search engines on all platforms. Namely, autocreation of search engines, and pages that have OpenSearch tags. Nothing should crash, break, or have any user-visible change. Review URL: http://codereview.chromium.org/6515014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75004 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue where Chrome.Window.Update unmaximizes a window when only the ↵levin@chromium.org2011-02-091-0/+5
| | | | | | | | | | | focus parameter is passed and how setting window bounds in window.update doesn't work when a window is full screen. BUG=65371 TEST=ExtensionApiTest.UpdateWindowDoesNotUnmaximize Review URL: http://codereview.chromium.org/6392036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74250 0039d316-1c4b-4281-b951-d872f2087c98
* Highlight background pages in task manager if user clicks View Background Pages.atwilson@chromium.org2011-02-071-0/+3
| | | | | | | | | | | | Added "highlight_background_resources" param to BrowserWindow::ShowTaskManager() and added support in Cocoa for drawing highlights. BUG=71490 TEST=Click View Background Pages, see background pages are highlighted in yellow. Review URL: http://codereview.chromium.org/6312178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73993 0039d316-1c4b-4281-b951-d872f2087c98
* Change includes of gfx/* to ui/gfx/*sail@chromium.org2011-02-051-1/+1
| | | | | | | | | BUG=71063 TEST=compiled Review URL: http://codereview.chromium.org/6312156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
* Cross-platform CL to remove app/win/win_util.h&cc and related work.msw@chromium.org2011-02-031-6/+0
| | | | | | | | | | | | | | | | | | | | See Issue 70141 for the full move details; see my inline review comments. Changes significantly different from or beyond those prescribed by the bug: *Consolidated a lot of GrabWindowSnapshot code. *Moved EnsureRectIsVisibleInRect to views::internal namespace for test access. *Moved app/win/win_util_unittest.cc to views/window/window_win_unittest.h *Named ui/base/message_box_win.h instead of ui/base/message_box.h *Made WindowWin::GetWindowTitleFont static; needed in static contexts. *Denoted WindowWin::FrameTypeChanged as a Window override, moved code. *Moved TestGrabWindowSnapshot into new file: chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm BUG=70141 TEST=none Review URL: http://codereview.chromium.org/6386009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73589 0039d316-1c4b-4281-b951-d872f2087c98