summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ui/cocoa
Commit message (Collapse)AuthorAgeFilesLines
* Merge trunk r88533 to the 12.0.742 branchmark@chromium.org2011-06-133-41/+47
| | | | | | | | | | | | | | | | | Fix OS full-screen button on FutureCat. The full-screen button should trigger Chrome's full-screen mode. This should work properly even on subsequent clicks, when a window was already full-screened and then not-full-screened. BUG=85196 TEST=On FutureCat, use the full-screen button to go full-screen, then exit full-screen, then re-enter full-screen with the OS button again. Both times, Chrome's full-screen mode should be activated in the same way. Review URL: http://codereview.chromium.org/7003036 TBR=mark@chromium.org Review URL: http://codereview.chromium.org/7046113 git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@88848 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 86371 - Remove prefix elidingsail@chromium.org2011-05-243-60/+0
| | | | | | | | | | | | | | | For M12 we experimented with eliding common prefixes in tab titles. After lots of feedback we've decided to remove this feature. BUG=83668 TEST=Testing Review URL: http://codereview.chromium.org/7067007 TBR=sail@chromium.org Review URL: http://codereview.chromium.org/6992013 git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@86375 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 84655 - [Mac] Mark BrowserWindowController's window as non-restorable.rsesek@chromium.org2011-05-101-3/+11
| | | | | | | | | | | | BUG=79113 TEST=On FutureCat, browse around for a few minutes, opening multiple tabs and switching applications. Try to quit Chromium. It quits. Review URL: http://codereview.chromium.org/6971002 TBR=rsesek@chromium.org Review URL: http://codereview.chromium.org/7001002 git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@84830 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 84309 (rsesek is uncomfortable about merging this) - Merge 83125 - ↵thakis@chromium.org2011-05-0512-95/+116
| | | | | | | | | | | | | | | | | | Add and use gfx::ScopedNSGraphicsContextState (ui/gfx/scoped_ns_graphics_context_state_mac.h). BUG=none TEST=covered by tests Review URL: http://codereview.chromium.org/6904026 TBR=rsesek@chromium.org Review URL: http://codereview.chromium.org/6927058 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/6930048 git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@84311 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 83125 - Add and use gfx::ScopedNSGraphicsContextState ↵thakis@chromium.org2011-05-0512-116/+95
| | | | | | | | | | | | | | | (ui/gfx/scoped_ns_graphics_context_state_mac.h). BUG=none TEST=covered by tests Review URL: http://codereview.chromium.org/6904026 TBR=rsesek@chromium.org Review URL: http://codereview.chromium.org/6927058 git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@84309 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 84238 - Fix clang error below:mirandac@chromium.org2011-05-051-1/+1
| | | | | | | | | | | | | | | | | | | /b/build/slave/Mac_Clang__dbg_/build/src/chrome/browser/ui/cocoa/first_run_dialog.mm:152:13:error: '&&' within '||' [-Werror,-Wlogical-op-parentheses] model && !model->is_default_search_managed()) { ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /b/build/slave/Mac_Clang__dbg_/build/src/chrome/browser/ui/cocoa/first_run_dialog.mm:152:13: note: place parentheses around the '&&' expression to silence this warning model && !model->is_default_search_managed()) { ^ ( ) 1 error generated. TBR: sheriff maf when he wakes up. :-) Review URL: http://codereview.chromium.org/6935023 TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/6927047 git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@84259 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 84235 - Turn off the search engine selector for the Russian locale.mirandac@chromium.org2011-05-051-1/+2
| | | | | | | | | | | BUG=81578 TEST=no search engine selector in organic builds in Russian locale. Review URL: http://codereview.chromium.org/6927022 TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/6927046 git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@84258 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 84073 - Fix window widgets.avi@chromium.org2011-05-042-14/+9
| | | | | | | | | | | | | | Always force re-layout of window on load. BUG=81446 TEST=as in bug Review URL: http://codereview.chromium.org/6909039 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6933013 git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@84123 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 84005 - Mac. Ensure no more than one visibly selected item in each ↵maf@chromium.org2011-05-044-41/+81
| | | | | | | | | | | | | | | | | | bookmark folder menu. Make the BookmarkBarFolderButtonCell not hover select itself (by overriding setMouseInside to do nothing). Instead have the controller manage the selection, which enables selection to be moved from the keyboard or mouse without two selections appearing. Remove the [BookmarkBarFolderController toggleButtonBorderingWhileMouseInside] hack which was only necessary because of a bug in [GradientButtonCell updateTrackingAreas] that unexpectedly changed the isMouseInside_ state. Add new logic to [BookmarkBarFolderController performOneScroll] to make it detect an existing mouse-initiated selection. If one is present before scroll it will select whatever item ends up under the mouse after the scroll. Otherwise no selection change will happen, which is right. BUG=75014,77676,80043,81072,46595 Review URL: http://codereview.chromium.org/6889025 TBR=maf@chromium.org Review URL: http://codereview.chromium.org/6927001 git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@84010 0039d316-1c4b-4281-b951-d872f2087c98
* Merge trunk r83028 to the 12.0.742 branchmark@chromium.org2011-04-286-311/+135
| | | | | | | | | | | | | | | | Fix (X) (-) (+). Switch to a much saner and less hacky way of moving the window control buttons. BTW, this is how the App Store does it. BUG=74112 TEST=no visible difference; window buttons always work properly and are positioned correctly Review URL: http://codereview.chromium.org/6893023 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6883213 git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@83278 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 83056 - Protect against image conversion failure in ↵rsesek@chromium.org2011-04-261-2/+8
| | | | | | | | | | | | | | mac::FaviconForTabContents(). BUG=80579 TEST=Monitor crash server. Review URL: http://codereview.chromium.org/6906001 TBR=rsesek@chromium.org Review URL: http://codereview.chromium.org/6904030 git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@83065 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 83025 - [Mac] Prevent a browser and renderer crash when dragging ↵rsesek@chromium.org2011-04-261-6/+22
| | | | | | | | | | | | | | | images with invalid MIME types. BUG=78782 TEST=Drag image from repro case in bug to Desktop. Don't crash. Review URL: http://codereview.chromium.org/6900052 TBR=rsesek@chromium.org Review URL: http://codereview.chromium.org/6883163 git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@83052 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 82419 - Mac Bookmark bar menus: ensure that the innermost visible ↵maf@chromium.org2011-04-211-0/+3
| | | | | | | | | | | | submenu always has "key" status. Fixes bug where they keystrokes started going to the browser window if you opened and closed a submenu from the keyboard. R=mrossetti@chromium.org BUG=80003 Review URL: http://codereview.chromium.org/6881089 TBR=maf@chromium.org Review URL: http://codereview.chromium.org/6899010 git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@82576 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 82418 - Make bookmark menu windows not beep whenever they get a keystroke.maf@chromium.org2011-04-211-0/+4
| | | | | | | | | | R=mrossetti@chromium.org BUG=80065 Review URL: http://codereview.chromium.org/6879089 TBR=maf@chromium.org Review URL: http://codereview.chromium.org/6899008 git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@82574 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 82352 - Revert high res icon changesThe new high res icon change may ↵sail@chromium.org2011-04-2120-418/+100
| | | | | | | | | have caused a perf regression. To verify I'm reverting the following chnages: commit 3a360c6b3d2fc174cb7597d6365cfc5418d1442b r82326 Disable loading high res icons on Mac commit 3c39226937a39d0042b8a794f13505c7a25ca58b r82247 Fix reload button unit test commit f87ab117fc159566868e71e4df5672852bebd718 r82245 Unregister toolbar view from window notifications commit 0b287ba4a4ad5c19d901f973eb9af594dcf3dba1 r82239 Fix failing Mac unit tests commit 8b681c46a139d12151323952c58122f6805d7597 r82236 Mac: Remove custom drawn buttons commit 6ae8a2fe40485731b86267e362936db16b4c0706 r82209 Fix clang build break commit e8a19d1e0c76f204c834318566e4206320583449 r82185 Add support for multi resolution iconsBUG=NoneTEST=ComplingReview URL: http://codereview.chromium.org/6878077 TBR=sail@chromium.org Review URL: http://codereview.chromium.org/6881114 git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@82542 0039d316-1c4b-4281-b951-d872f2087c98
* Fix reload button unit testsail@chromium.org2011-04-202-4/+4
| | | | | | | | BUG=None TEST=Ran locally, verified that the tests passed. Review URL: http://codereview.chromium.org/6882073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82247 0039d316-1c4b-4281-b951-d872f2087c98
* Unregister toolbar view from window notificationssail@chromium.org2011-04-201-0/+5
| | | | | | | | | | | | The toolbar view was being deleted before it was removed from the window. This meant that it hadn't been removed from the window notifications and any notificaitons that were sent would cause a crash. Fix was to unregsiter for notifications in the destructor. BUG=None TEST=Ran locally and verified that the unit test passed. Review URL: http://codereview.chromium.org/6877075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82245 0039d316-1c4b-4281-b951-d872f2087c98
* Fix failing Mac unit testssail@chromium.org2011-04-202-1/+5
| | | | | | | | | | My previous change (r82236) to toolbar buttons was missing a few files. This caused the unit tests to fail. BUG=None TEST=None Review URL: http://codereview.chromium.org/6879073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82239 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Remove custom drawn buttons sail@chromium.org2011-04-2010-95/+396
| | | | | | | | | | | | | | This change switches to using the new high res icons instead of custom drawn buttons. Changed buttons in BrowserWindow.xib and Toolbar.xib to use ImageButtonCell instead of GradientButtonCell. Screenshot: http://www.dropmocks.com/mUDXS BUG=75812 TEST=Ran and verified that things looked ok. Made sure unit tests passed. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82236 0039d316-1c4b-4281-b951-d872f2087c98
* Make it easy to tell if BookmarkButtons are being used as menu items or as ↵maf@chromium.org2011-04-204-3/+13
| | | | | | | | | | | toolbar buttons. Use this to fix bug where items in submenus do not flash to confirm selection. R=mrossetti@chromium.org BUG=79958 Review URL: http://codereview.chromium.org/6882061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82207 0039d316-1c4b-4281-b951-d872f2087c98
* Add enum histogram for dangerous download save or discard.mattm@chromium.org2011-04-191-1/+1
| | | | | | | | | BUG=79490 TEST=save or discard a dangerous download, check about:histograms Review URL: http://codereview.chromium.org/6849004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82186 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for multi resolution iconssail@chromium.org2011-04-198-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | To support HiDPI we need a way to load two copies of icons, a low resolution version and a high resolution version. To support this, this change does the following: - split theme_resource.grd into three files: - theme_resources.grd: icons that only have one resolution - theme_resources_standard.grd: low resolution icons - theme_resources_large.grd: high resolution icons - theme_resource.grd and theme_resources_standard.grd and compiled into chrome.pak/chrome.rc for all platforms. - theme_resources_large.grd is compiled into theme_resources_large.pak for platforms that want high resolution icons (currently only Mac) - gfx::Image now support icons with multiple resolution Currently not all ThemeService APIs return multi-resolution images. Once this is checked in I'll work on converting them as I go. Note, this change will have to be coordinated with the change to reorganize theme resources. I'll work with saintlou on that. BUG=75812 TEST=Added a TIFF to theme_resources.grd. Verified that the toolbar icon had a mutliresolution image. Verified that unit tests passed. Review URL: http://codereview.chromium.org/6849030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82185 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Implement type-select and arrow key support for bookmark bar menus.maf@chromium.org2011-04-195-7/+243
| | | | | | | BUG=69310,69311 Review URL: http://codereview.chromium.org/6877026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82180 0039d316-1c4b-4281-b951-d872f2087c98
* Mac Canary: Don't offer to set as the default browser.mark@chromium.org2011-04-192-1/+8
| | | | | | | | | | | | | This includes some light refactoring to give all platforms a platform_util::CanSetAsDefaultBrowser() function. The .xib change links the set-as-default button with the new IBOutlet. BUG=79814 TEST=Canary.app should never offer to set as the default browser in the first run dialog or in an infobar. Review URL: http://codereview.chromium.org/6881058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82179 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix exception thrown by profile menu buttonsail@chromium.org2011-04-191-0/+4
| | | | | | | | | | | | Clicking on the hidden profile menu button would cause a Objective-C exception to be thrown. The problem was that I was implementing my own hit testing and I didn't check to see if the view was hidden. BUG=79890 TEST=Clicked in the top right of the browser window. Verified that without my change this caused an exception to be thrown. With my change no exception was thrown. Review URL: http://codereview.chromium.org/6882048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82167 0039d316-1c4b-4281-b951-d872f2087c98
* New cancel test (includes change in DownloadItem::Complete meaning andrdsmith@chromium.org2011-04-191-1/+0
| | | | | | | | | | | | | | | | | notification interface). * Changed DownloadItem::COMPLETE state to mean "really all done" with download (used to mean "all data received"). This isn't a very large change, since we recently put in another change to dangerous downloads where we didn't recognize all data received until we had been accepted by the user, which means that there aren't any blocking points between all data received and COMPLETE. * Removed DownloadItem::Observer::OnDownloadFileCompleted() notification. It's now redundant with the COMPLETE state, and the COMPLETE state works better for synchronization (because you can test the download item for it as opposed to having to be an observer when the notification is sent). * Added a basic test for cancel functionality in the downloads system. Also shifted MarkAsComplete to be used only by SavePackage, and make sure that the final transition occurs for drag-n-drop downloads (which don't need to go through name finalization). BUG=78183 TEST=All known download tests, manual drag-and-drop and dangerous accept/discard pre/post data received. Review URL: http://codereview.chromium.org/6720061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82113 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix Find Bar drawing regressionsail@chromium.org2011-04-193-14/+30
| | | | | | | | | | | | | | | The new tab drawing and omnibox drawing code caused the find bar to have two drawing problems: - the curve from the toolbar to the find bar was offset vertically by 1 pixel - the search field was 2 pixels taller than the find next/previous buttons This change fixes that. Screenshots: http://www.dropmocks.com/mUHAr BUG=None TEST=Ran and verified that it looks good at 72 and 144 DPI. Review URL: http://codereview.chromium.org/6873067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82074 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Breakpad key to help track web-drag crash.shess@chromium.org2011-04-191-1/+14
| | | | | | | | | | | BUG=78782 TEST=Monitor crashes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81855 Review URL: http://codereview.chromium.org/6861004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82065 0039d316-1c4b-4281-b951-d872f2087c98
* first-run: Move ShowFirstRunDialog() function to first_run_dialog.htfarina@chromium.org2011-04-181-1/+96
| | | | | | | | | | | | | So first_run doesn't need to depend on chrome/browser/ui/. BUG=79586 TEST=None R=jhawkins@chromium.org Review URL: http://codereview.chromium.org/6871032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82014 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't draw the inner highlight on infobars on the left side.rsesek@chromium.org2011-04-181-2/+1
| | | | | | | | | | BUG=39102 TEST=visual Review URL: http://codereview.chromium.org/6880008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81969 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Try to fix zombie -mouseMoved: message.shess@chromium.org2011-04-182-0/+2
| | | | | | | | | | | | | | ScopedTrackingArea added code to automagically break forwarding for tracking areas to prevent use-after-free messages. In BookmarkBarFolderController, the pointer was cleared before this code could kick in. Call it manually. BUG=78756 TEST=crash server. Review URL: http://codereview.chromium.org/6875014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81961 0039d316-1c4b-4281-b951-d872f2087c98
* More TabStripModel renaming:sky@chromium.org2011-04-183-8/+8
| | | | | | | | | | | | | | | | AddTabTypes::ADD_SELECTED -> ADD_ACTIVE SelectTabContentsAt -> ActivateTabAt BUG=none TEST=none R=ben@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/6840007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81947 0039d316-1c4b-4281-b951-d872f2087c98
* Clear now-stale buttonThatMouseIsIn_ member var when moving that button in ↵maf@chromium.org2011-04-171-0/+2
| | | | | | | | | | | array. Prevents an auto-scroll crash when the stale value is used later. R=mrossetti@chromium.org BUG=70329 Review URL: http://codereview.chromium.org/6865042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81918 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Move some extension-sync-related logic to ExtensionServiceakalin@chromium.org2011-04-171-1/+1
| | | | | | | | | | | | | | | | Add ExtensionSyncData class to hold the data that goes between the extension service and extension sync. Add ProcessSyncData() method to ExtensionService (with unit tests!). Remove now-unneeded extension sync functions. BUG=77995 TEST= Review URL: http://codereview.chromium.org/6852029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81899 0039d316-1c4b-4281-b951-d872f2087c98
* Commit Instant if needed before handling a web page context menu.maf@chromium.org2011-04-162-0/+8
| | | | | | | | Avoids the situation where contextual menu commands like "Open Link in New Tab" get ignored, because it's being handled with the Instant dummy loader still in place. BUG=73259 Review URL: http://codereview.chromium.org/6874030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81886 0039d316-1c4b-4281-b951-d872f2087c98
* Improve drawing of omnibox in HiDPI modesail@chromium.org2011-04-161-16/+25
| | | | | | | | | | | | | | | | | | In HiDPI mode the omnibox looks a little blurry. The current drawing code assumes that a line width of 1.0 will draw a 1 pixel wide line. This change looks up the line_width at run time. Screenshot of old omnibox: https://docs.google.com/leaf?id=0B0Odde3V7EhWYzEyYmM2ZjItMzczNC00MjMxLWE5NGItZWY4N2I2MDdiMzg5&hl=en Screenshot of new omnibox: https://docs.google.com/leaf?id=0B0Odde3V7EhWMDVhY2U5N2UtMWVhYi00YThjLThlYjctNzE2ODIxZjg3OTc0&hl=en BUG=None TEST=Verified that the ominbox looks the same at 72DPI. Ran at 144 DPI and verified that the ominbox no longer looks blurry. Review URL: http://codereview.chromium.org/6834012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81884 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "[Mac] Breakpad key to help track web-drag crash."shess@chromium.org2011-04-161-14/+1
| | | | | | | | | | | | | | | Unfortunately, clang complained. Original CL http://codereview.chromium.org/6861004/ http://src.chromium.org/viewvc/chrome?view=rev&revision=81855 BUG=78782 TBR=rsesek@chromium.org TEST=waterfall Review URL: http://codereview.chromium.org/6870024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81858 0039d316-1c4b-4281-b951-d872f2087c98
* Move json_value_serializer to content\common since it's used by code in ↵jam@chromium.org2011-04-161-1/+1
| | | | | | | | | content now. TBR=avi Review URL: http://codereview.chromium.org/6875018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81857 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Breakpad key to help track web-drag crash.shess@chromium.org2011-04-161-1/+14
| | | | | | | | | BUG=78782 TEST=Monitor crashes. Review URL: http://codereview.chromium.org/6861004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81855 0039d316-1c4b-4281-b951-d872f2087c98
* Improve drawing of tab strip in HiDPI modesail@chromium.org2011-04-165-24/+67
| | | | | | | | | | | | | | | | | | | | | This is a similar change to the omnibox change. The current tab strip drawing code assumes that a line width of 1.0 will draw a 1 pixel wide line. This change looks up the line width at runtime. Screenshot of the old tab strip at 144 DPI: https://docs.google.com/leaf?id=0B0Odde3V7EhWYzEyYmM2ZjItMzczNC00MjMxLWE5NGItZWY4N2I2MDdiMzg5&hl=en Screenshot of the new tab strip at 144 DPI: https://docs.google.com/leaf?id=0B0Odde3V7EhWMzEwN2RhYzktYmUyNi00OTY4LWJiNDgtNjA1YjM5MDQwYjc1&hl=en Screenshot of the new tab script drawing code running at 72 DPI: https://docs.google.com/leaf?id=0B0Odde3V7EhWY2RkNWNjNGYtZGNjYi00MmEwLTgzNTUtNTA2YmRmOWJhYWQz&hl=en BUG=None TEST=Verified that the tabstrip looks at the same at 72DPI. Ran at 144 DPI and verified that the tabstrip no longer looks blurry. Review URL: http://codereview.chromium.org/6839012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81852 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the TabContentsDelegate::ToolbarSizeChanged() method as no one was ↵pkasting@chromium.org2011-04-154-9/+2
| | | | | | | | | | using it. Rename BrowserWindow::SelectedTabToolbarSizeChanged() to ToolbarSizeChanged() as there are no per-tab toolbars since we made the DownloadShelf per-window a while ago. BUG=none TEST=none Review URL: http://codereview.chromium.org/6870002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81834 0039d316-1c4b-4281-b951-d872f2087c98
* Policy to manage file selection dialogs.pastarmovj@chromium.org2011-04-151-16/+14
| | | | | | | | | | | | | | | | Adds a policy to allow/disallow file selection dialogs from wherever they can be launched (Save Link As, Import Bookmarks, etc.). In case file selection dialogs are disallowed by policy a InfoBar informs the user whenever he triggers a file selection dialog. BUG=73174 TEST=Manually set the policy and check if the corresponding file selection are not shown and the InfoBar appears. Review URL: http://codereview.chromium.org/6814011 Patch from Sandro Feuz <sfeuz@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81804 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Move TabContent::PrintNow() out of src/content.thestig@chromium.org2011-04-151-1/+1
| | | | | | | BUG=76795 Review URL: http://codereview.chromium.org/6872003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81799 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Update infobars to the new style and remove the current anti-spoof bulge.rsesek@chromium.org2011-04-156-81/+35
| | | | | | | | | | | | | | | | | | | | | The anti-spoof bulge was removed on the M11 branch only. I haven't yet finished the new anti-spoof tip, so this is a subset of the changes from that in-progress CL to be a stopgap for M12. XIB Changes: * Make the height of the infobar 36px * Make the icon be 26px square * Turn off image scaling in the icon * Adjust the spacing around the icon to be 6px * Set fixed-bottom relationship springs for all objects * Move all objects' baseline up 2px BUG=39102,77693 TEST=visual Review URL: http://codereview.chromium.org/6865024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81798 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark folder menus : dynamically replace generic placeholder icons ↵maf@chromium.org2011-04-153-0/+21
| | | | | | | | | | with the real favicons as they load. Fixes bug where all the bookmark icons are generic the first time each bookmark folder menu is opened after each launch. R=mrossetti@chromium.org BUG=39068 Review URL: http://codereview.chromium.org/6858006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81778 0039d316-1c4b-4281-b951-d872f2087c98
* Put back "Enable component extensions for DefaultProfile used in login ↵dpolukhin@chromium.org2011-04-151-1/+2
| | | | | | | | | | | | | screen dialogs" Initial commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=79526 BUG=chromium-os:12741 TEST=Run debug Chrome on device Review URL: http://codereview.chromium.org/6737028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81770 0039d316-1c4b-4281-b951-d872f2087c98
* fix up TEST_VIEW macrodmaclach@chromium.org2011-04-151-2/+2
| | | | | | | | | BUG=53621 TEST=Build Mac Review URL: http://codereview.chromium.org/6831015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81765 0039d316-1c4b-4281-b951-d872f2087c98
* Moves responsibility for showing profile error dialog out of Browsersky@chromium.org2011-04-142-10/+0
| | | | | | | | | | | | | and into a standalone function. This way we can show the error dialog if no browser is around (as can happen during startup). BUG=74639 TEST=none R=ben@chromium.org,avi@chromium.org,estade@chromium.org Review URL: http://codereview.chromium.org/6838031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81637 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make the page info bubble animation look ever-so-slightly better.rsesek@chromium.org2011-04-141-4/+4
| | | | | | | | | | BUG=64823 TEST=visual Review URL: http://codereview.chromium.org/6851019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81616 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix constrained sheetsthakis@chromium.org2011-04-141-5/+5
| | | | | | | | | | | | | | | | | The problem was that beginSheet: was called before setActiveView:, so when setActiveView: was called, activeView_ was already the view belonging to the new tab, hence the old sheet wouldn't get hidden. Patch http://codereview.appspot.com/4418041 adds more asserts to GTM that make the implicit assumption about when beginSheet: can be called explicit through asserts. BUG=78889 TEST= * Open 4 tabs that open sheets * Close chrome, reopen chrome (with "remember tabs") * Switch tabs * Only one sheet should be visible at a time Review URL: http://codereview.chromium.org/6852013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81603 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-13 21:39:27 +0000