summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ui/find_bar
Commit message (Collapse)AuthorAgeFilesLines
* Removed sending of the following IPC messages from chrome and added API's on ↵ananta@chromium.org2011-09-231-11/+2
| | | | | | | | | | | | | | | | | | | | | | | | | the RenderViewHost object to facilitate this. 1. ViewMsg_CustomContextMenuAction 2. ViewMsg_ContextMenuClosed 3. ViewMsg_CopyImageAt 4. ViewMsg_MediaPlayerActionAt 5. ViewMsg_DisassociateFromPopupCount 6. ViewMsg_MoveOrResizeStarted 7. ViewMsg_StopFinding The ViewMsg_FindReplyACK message is now sent by the TabContents::OnFindReply handler. Continuing changes to get rid of the pattern of IPC messages being sent and processed across content and chrome. BUG=87335. TEST=no change in functionality. Review URL: http://codereview.chromium.org/8002005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102404 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call OnNativeWidgetVisibilityChange in NativeWidgetGtkoshima@chromium.org2011-09-221-0/+7
| | | | | | | | | BUG=chromium-os:20545 TEST=added a test case in FindInPageControllerTest.AcceleratorRestoring. See bug for repro step. Review URL: http://codereview.chromium.org/7978015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102233 0039d316-1c4b-4281-b951-d872f2087c98
* Removed the sending of the following content IPC messages out of chrome and ↵ananta@chromium.org2011-09-191-3/+2
| | | | | | | | | | | | | | | | | | | | | replaced them with corresponding API's on the RenderWidgetHost object. 1. ViewMsg_Zoom. 2. ViewMsg_ReloadFrame. 3. ViewMsg_Find. 4. ViewMsg_CSSInsertRequest. 5. ViewMsg_DisableScrollbarsForSmallWindows. 6. ViewMsg_EnablePreferredSizeChangedMode. Continuing fixes to ensure that IPC messages don't span across content and chrome. BUG=87335. TEST=no change in functionality. Review URL: http://codereview.chromium.org/7923023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101855 0039d316-1c4b-4281-b951-d872f2087c98
* Add ChromeRenderViewHostTestHarness to get rid of the dependency from RVHTH ↵jochen@chromium.org2011-09-141-1/+1
| | | | | | | | | | | to profile BUG=90443 TEST=everything still works Review URL: http://codereview.chromium.org/7892007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101037 0039d316-1c4b-4281-b951-d872f2087c98
* Handle the ViewHostMsg_FindReply message which is sent by content(renderer) ↵ananta@chromium.org2011-09-022-22/+10
| | | | | | | | | | | via the TabContentsDelegate. The other change is to remove an unused Browser member from the ExternalTabContainer class. BUG=87335 Review URL: http://codereview.chromium.org/7828025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99275 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 96617gbillock@chromium.org2011-08-171-7/+15
| | | | | | | | | | | | | | | | | Revert 96593 (Original review URL http://codereview.chromium.org/7489019) Fix up various browser tests not to use WaitForNavigation. Now with corrected pdf browsertest R=phajdan.jr@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/7645001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97181 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 96593 - Fix up various browser tests not to use WaitForNavigation.gbillock@chromium.org2011-08-121-15/+7
| | | | | | | | | | | | | | | | Convenience methods for WindowedNotificationObserver. R=phajdan.jr@chromium.org BUG=various TEST=none Review URL: http://codereview.chromium.org/7489019 TBR=gbillock@chromium.org Review URL: http://codereview.chromium.org/7633032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96617 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up various browser tests not to use WaitForNavigation.gbillock@chromium.org2011-08-121-7/+15
| | | | | | | | | | | | | Convenience methods for WindowedNotificationObserver. R=phajdan.jr@chromium.org BUG=various TEST=none Review URL: http://codereview.chromium.org/7489019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96593 0039d316-1c4b-4281-b951-d872f2087c98
* Nix GetFocusManagerForNativeView|Window.msw@chromium.org2011-08-021-3/+4
| | | | | | | | | | | | Use Widget|View::GetFocusManager instead. Use Widget::Get[TopLevel]WidgetForNativeView|Window as necessary. BUG=88718 TEST=none Review URL: http://codereview.chromium.org/7532015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95111 0039d316-1c4b-4281-b951-d872f2087c98
* Move more files from chrome/test to chrome/test/base, part #4phajdan.jr@chromium.org2011-08-011-1/+1
| | | | | | | BUG=90905 Review URL: http://codereview.chromium.org/7544021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94963 0039d316-1c4b-4281-b951-d872f2087c98
* Removal of Profile from content part 5.avi@chromium.org2011-08-011-1/+2
| | | | | | | | | BUG=76788 TEST=no change visible Review URL: http://codereview.chromium.org/7523054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94907 0039d316-1c4b-4281-b951-d872f2087c98
* Removal of Profile from content part 4.avi@chromium.org2011-08-011-2/+6
| | | | | | | | | BUG=76788 TEST=no change visible Review URL: http://codereview.chromium.org/7531004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94901 0039d316-1c4b-4281-b951-d872f2087c98
* Move in_process_browser_test and ui_test_utils to chrome/test/basephajdan.jr@chromium.org2011-07-291-2/+2
| | | | | | | BUG=90905 Review URL: http://codereview.chromium.org/7532034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94720 0039d316-1c4b-4281-b951-d872f2087c98
* Replacing wrong occurrences of OS_WINDOWS with OS_WIN.leandrogracia@chromium.org2011-07-221-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93643 0039d316-1c4b-4281-b951-d872f2087c98
* Marking FindNextInNewTabUsesPrepopulate flaky on Windows due to occasional ↵grt@chromium.org2011-07-201-2/+10
| | | | | | | | | | | timeout. BUG=88316,43070 TEST=browser_tests TBR=robertshield@chromium.org Review URL: http://codereview.chromium.org/7452022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93189 0039d316-1c4b-4281-b951-d872f2087c98
* Moving notification types which are chrome specific to a new header file ↵ananta@chromium.org2011-07-103-7/+9
| | | | | | | | | | | | | chrome_notification_types.h. This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END which defines the end of the enum used by content to define notification types. The notificaton_type.h file in content\common has been renamed to content_notification_types.h BUG=76698 Review URL: http://codereview.chromium.org/7327007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
* Multiprofile: Remove AllSources() usage on CONTENT_SETTINGS_CHANGED.erg@chromium.org2011-06-281-2/+11
| | | | | | | | | | BUG=87457 TEST=none Review URL: http://codereview.chromium.org/7277013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90852 0039d316-1c4b-4281-b951-d872f2087c98
* Factor load notification detail structs out of NavigationController and into pinkerton@chromium.org2011-05-311-2/+3
| | | | | | | | | | | their own file in the |content| namespace. Remove un-necessary includes of navigation_controller.h. BUG=none TEST=everything compiles Review URL: http://codereview.chromium.org/7008018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87319 0039d316-1c4b-4281-b951-d872f2087c98
* Test to verify that FindBar fits within narrow browser window.jennb@chromium.org2011-05-262-2/+37
| | | | | | | | | BUG=None TEST=FindInPageControllerTest.FitWindow Review URL: http://codereview.chromium.org/7063003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86865 0039d316-1c4b-4281-b951-d872f2087c98
* Remove functions in RenderViewHost and RenderWidgetHost that just send an ↵jam@chromium.org2011-05-191-6/+29
| | | | | | | | IPC message and are called by one or two places. Have the callers send the message instead. Also remove functions which dispatch an IPC only to call TabContents. Dispatch in TabContents instead. Review URL: http://codereview.chromium.org/7037041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85990 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land:ben@chromium.org2011-05-131-10/+4
| | | | | | | | | | | | Split the hierarchy. Now with AutocompletePopup implementing SupportsWeakPtr as before. This fixes the Windows XP crashes in browser_tests. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7015051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85298 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 85269 - Split the hierarchy. ben@chromium.org2011-05-131-4/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Widget ---- Now recognizes a supplied NativeWidget via InitParams. If this is specified then a default one is not created. Is now created directly rather than using a factory. NativeWidget creation is not performed until Init() is called. This means some functions that rely on a NativeWidget must not be called until _AFTER_ Init() (explains some of the function call reordering in this CL, e.g. moving SetOpacity() until after Init()). ResetLastMouseMovedFlag() moved to this API so that BaseTabStrip can call it in a cross-platform way. Made last remaining unimplemented methods on Widget pass-thru to NativeWidget implementations. * WidgetWin/WidgetGtk ---- The NativeWidget implementations now both require a NativeWidgetDelegate implementation upon construction. This is passed through the constructor by the static factory method NativeWidget::CreateNativeWidget and by subclasses such as WindowWin, BubbleWidgetWin, etc. Some classes that are constructed directly (e.g. LockWindow, in ChromeOS) never have a Widget created for them, so they create the Widget themselves in their base class initializer. Code in these classes (and their WindowWin/WindowGtk, BrowserFrameWin, BrowserFrameGtk subclasses) must now call GetWidget() etc to call Widget API methods since they are no longer subclasses. static_casting to this (and derived) types must now be done on the Widget's native_widget(). GetWindow() is renamed to GetContainingWindow() to avoid naming conflicts. * Window ---- Window is now a subclass of Widget. Now recognizes a supplied NativeWindow via InitParams. If this is specified then a default one is not created. Window::CloseWindow becomes an override of Widget::Close. CloseAllSecondaryWindows() becomes CloseAllSecondaryWidgets() and moves to widget.h IsAppWindow() is removed and replaced by set_is_secondary_widget on Widget. * MenuHost ---- Subclasses Widget now. * TabContentsViewViews ---- It looks like the Gtk-views code here was still using the old implementation of the Native version of this class - i.e. a class that subclassed TabContentsView AND WidgetGtk. A no-no. I had to write NativeTabContentsViewGtk, which is almost identical to NativeTabContentsViewWin with the Gtk bits of TabContentsViewGtk thrown in. * BrowserFrame ---- Platform-specific functionality is now restricted to BrowserFrameWin/BrowserFrameGtk behind a NativeBrowserFrame interface. Construction is exposed via a static factory method on NativeBrowserFrame. BrowserFrame becomes a concrete class that now subclasses Window. As a result, it no longer needs a GetWindow() accessor method, so people with a BrowserFrame* can just call Window methods directly on it. It is constructed directly, replacing the BrowserFrame::Create() method. NativeBrowserFrameDelegate is no longer needed. BrowserFrameChromeos is simpler as a couple of #ifdefs in BrowserFrame, so I got rid of that too. * AutocompletePopupWin/Gtk ---- No longer required. AutocompletePopupContentsView now just uses a Widget directly. * There is some lingering ugliness: - If you set a native_window field on Window::InitParams you must also manually set widget_init_params.native_widget. I will make InitParams do more of this automatically later. - It'd be nice for the ContentsView to be specified via InitParams. I'll get to this later. - NativeBrowserFrame could probably disappear as an interface. It only exists to provide a couple of methods that may be implemented in other ways. - delete_on_destroy should now be an ownership directionality enum. I will do this later. - Secondary-widgetness should somehow be inferred from transience. Later. - set_focus_on_creation for both the NativeWidgets should probably move to Widget if it is really needed. - WidgetWin/Gtk::SetInitialFocus seems like it could move to Widget. - I need to clean up function order in some cases. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7012006 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/7011038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85283 0039d316-1c4b-4281-b951-d872f2087c98
* Split the hierarchy. ben@chromium.org2011-05-131-10/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Widget ---- Now recognizes a supplied NativeWidget via InitParams. If this is specified then a default one is not created. Is now created directly rather than using a factory. NativeWidget creation is not performed until Init() is called. This means some functions that rely on a NativeWidget must not be called until _AFTER_ Init() (explains some of the function call reordering in this CL, e.g. moving SetOpacity() until after Init()). ResetLastMouseMovedFlag() moved to this API so that BaseTabStrip can call it in a cross-platform way. Made last remaining unimplemented methods on Widget pass-thru to NativeWidget implementations. * WidgetWin/WidgetGtk ---- The NativeWidget implementations now both require a NativeWidgetDelegate implementation upon construction. This is passed through the constructor by the static factory method NativeWidget::CreateNativeWidget and by subclasses such as WindowWin, BubbleWidgetWin, etc. Some classes that are constructed directly (e.g. LockWindow, in ChromeOS) never have a Widget created for them, so they create the Widget themselves in their base class initializer. Code in these classes (and their WindowWin/WindowGtk, BrowserFrameWin, BrowserFrameGtk subclasses) must now call GetWidget() etc to call Widget API methods since they are no longer subclasses. static_casting to this (and derived) types must now be done on the Widget's native_widget(). GetWindow() is renamed to GetContainingWindow() to avoid naming conflicts. * Window ---- Window is now a subclass of Widget. Now recognizes a supplied NativeWindow via InitParams. If this is specified then a default one is not created. Window::CloseWindow becomes an override of Widget::Close. CloseAllSecondaryWindows() becomes CloseAllSecondaryWidgets() and moves to widget.h IsAppWindow() is removed and replaced by set_is_secondary_widget on Widget. * MenuHost ---- Subclasses Widget now. * TabContentsViewViews ---- It looks like the Gtk-views code here was still using the old implementation of the Native version of this class - i.e. a class that subclassed TabContentsView AND WidgetGtk. A no-no. I had to write NativeTabContentsViewGtk, which is almost identical to NativeTabContentsViewWin with the Gtk bits of TabContentsViewGtk thrown in. * BrowserFrame ---- Platform-specific functionality is now restricted to BrowserFrameWin/BrowserFrameGtk behind a NativeBrowserFrame interface. Construction is exposed via a static factory method on NativeBrowserFrame. BrowserFrame becomes a concrete class that now subclasses Window. As a result, it no longer needs a GetWindow() accessor method, so people with a BrowserFrame* can just call Window methods directly on it. It is constructed directly, replacing the BrowserFrame::Create() method. NativeBrowserFrameDelegate is no longer needed. BrowserFrameChromeos is simpler as a couple of #ifdefs in BrowserFrame, so I got rid of that too. * AutocompletePopupWin/Gtk ---- No longer required. AutocompletePopupContentsView now just uses a Widget directly. * There is some lingering ugliness: - If you set a native_window field on Window::InitParams you must also manually set widget_init_params.native_widget. I will make InitParams do more of this automatically later. - It'd be nice for the ContentsView to be specified via InitParams. I'll get to this later. - NativeBrowserFrame could probably disappear as an interface. It only exists to provide a couple of methods that may be implemented in other ways. - delete_on_destroy should now be an ownership directionality enum. I will do this later. - Secondary-widgetness should somehow be inferred from transience. Later. - set_focus_on_creation for both the NativeWidgets should probably move to Widget if it is really needed. - WidgetWin/Gtk::SetInitialFocus seems like it could move to Widget. - I need to clean up function order in some cases. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7012006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85269 0039d316-1c4b-4281-b951-d872f2087c98
* More TabStripModel renaming:sky@chromium.org2011-04-181-4/+4
| | | | | | | | | | | | | | | | AddTabTypes::ADD_SELECTED -> ADD_ACTIVE SelectTabContentsAt -> ActivateTabAt BUG=none TEST=none R=ben@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/6840007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81947 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable FindInPageControllerTest::AcceleratorRestoringoshima@google.com2011-04-131-10/+1
| | | | | | | | | | | This was failing at last check (long time ago), but I'm no longer able to reproduce this (on local machine). BUG=26870 TEST=none Review URL: http://codereview.chromium.org/6833004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81506 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch more renderer messages from chrome to content.jam@chromium.org2011-03-221-1/+1
| | | | | | | TBR=tsepez Review URL: http://codereview.chromium.org/6726004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79031 0039d316-1c4b-4281-b951-d872f2087c98
* FindBar moves when selection is underneath it.thakis@chromium.org2011-03-101-9/+1
| | | | | | | | | | | | | | | | | | | | | Implemented in FindBarCocoaController instead of FindBarBridge.MoveWindowIfNecessary, since the move is triggered there and the rects required are also there. Enabled the FindInPageControllerTest.FindMovesWhenObscuring test on mac. Also tested with scaled resolutions, should handle that correctly. Manual test: open $CHROMIUM_SRC/chrome/test/data/find_in_page/find_test.txt, and start find in page for some text under the find bar (e.g. "New"). BUG=22036,11084 TEST=FindInPageControllerTest.FindMovesWhenObscuring in browser_tests. Review URL: http://codereview.chromium.org/6574014 Patch from Joao da Silva <joaodasilva@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77649 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of notification files.tfarina@chromium.org2011-03-093-7/+7
| | | | | | | | | | | Fourth part of the remaining files. The last one will be deleting the stub files. BUG=None TEST=None Review URL: http://codereview.chromium.org/6657003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77511 0039d316-1c4b-4281-b951-d872f2087c98
* Removing references to off the record in comments and log messages.akalin@chromium.org2011-03-081-1/+1
| | | | | | | | | | | Original patch by vipul.bhasin@gmail.com. BUG=3333 TEST=None Review URL: http://codereview.chromium.org/6625076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77331 0039d316-1c4b-4281-b951-d872f2087c98
* Update more includes that were pointing to the old locations.jam@chromium.org2011-03-023-3/+3
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6598086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76512 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of temporary render_view_host.h.jam@chromium.org2011-03-022-5/+5
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6598084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76477 0039d316-1c4b-4281-b951-d872f2087c98
* Make TabContentsObserver handle registration automatically, as well as ↵jam@chromium.org2011-02-172-20/+14
| | | | | | | | exposing getters for TC, routing_id, and sending messages. Review URL: http://codereview.chromium.org/6537004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75226 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the TabContentWrapper pieces to be "TabHelper"s. (Except for the ↵avi@chromium.org2011-02-165-70/+70
| | | | | | | | | | | PasswordManager... for now.) Also, just pre-create them up-front. It saves us effort, as they're all going to be eventually created anyway, so being lazy saves us nothing and creates headaches since the rules about what can be lazy differ from feature to feature. BUG=71097 TEST=zero visible change Review URL: http://codereview.chromium.org/6480117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75170 0039d316-1c4b-4281-b951-d872f2087c98
* Change includes of gfx/* to ui/gfx/*sail@chromium.org2011-02-053-3/+3
| | | | | | | | | BUG=71063 TEST=compiled Review URL: http://codereview.chromium.org/6312156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
* Add a regression test for issue 70505.finnur@chromium.org2011-02-031-0/+20
| | | | | | | | | | | | (2nd try, with fix for TabContents cleanup reorg fix) TBR=ojan BUG=70505 TEST=Automated test added, see bug for details. Review URL: http://codereview.chromium.org/6250127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73618 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 73604 - Add a regression test for issue 70505.finnur@chromium.org2011-02-031-20/+0
| | | | | | | | | | | | BUG=70505 TEST=Automated test added, see bug for details. Review URL: http://codereview.chromium.org/6297019 TBR=finnur@chromium.org Review URL: http://codereview.chromium.org/6410057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73606 0039d316-1c4b-4281-b951-d872f2087c98
* Add a regression test for issue 70505.finnur@chromium.org2011-02-031-0/+20
| | | | | | | | | BUG=70505 TEST=Automated test added, see bug for details. Review URL: http://codereview.chromium.org/6297019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73604 0039d316-1c4b-4281-b951-d872f2087c98
* Move find-in-page from TabContents to TabContentsWrapper.avi@chromium.org2011-02-016-86/+363
| | | | | | | | | | | Relanding r73294. BUG=71097 TEST=Hammer on find-in-page on all platforms. Nothing should crash, break, or have any user-visible change. Review URL: http://codereview.chromium.org/6246028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73360 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 73294 - Move find-in-page from TabContents to TabContentsWrapper.davemoore@chromium.org2011-02-016-363/+86
| | | | | | | | | | | | BUG=71097 TEST=Hammer on find-in-page on all platforms. Nothing should crash, break, or have any user-visible change. Review URL: http://codereview.chromium.org/6378014 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6286019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73307 0039d316-1c4b-4281-b951-d872f2087c98
* Move find-in-page from TabContents to TabContentsWrapper.avi@chromium.org2011-02-016-86/+363
| | | | | | | | | BUG=71097 TEST=Hammer on find-in-page on all platforms. Nothing should crash, break, or have any user-visible change. Review URL: http://codereview.chromium.org/6378014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73294 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71157 (caused 70644) - This is an alternate CL to the fix in ↵thakis@chromium.org2011-01-311-1/+0
| | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/5553002. The earlier fix changes the behaviour of the find bar text field such that whenever the textfield is focused, all of the text inside it is selected. This was done to fix a regression where the text was not getting selected when switching tabs (read description on that issue for more info). However, this new behaviour could be undesirable as we may not need to select the whole text everytime find bar gains focus. Hence, in this fix, we undo the changes from the earlier fix and add the selectall behaviour at the right place (when the tab is switched). BUG=56326,70644 TEST=Test added in the earlier CL still passes. Review URL: http://codereview.chromium.org/6188005 TBR=varunjain@chromium.org Review URL: http://codereview.chromium.org/6347040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73161 0039d316-1c4b-4281-b951-d872f2087c98
* Update references part 2: files in chrome/browser/ui/msw@chromium.org2011-01-191-1/+1
| | | | | | | | | | | | | | | | Update chrome/browser/gtk references & copyright dates of touched files. Re-alphabetize include lists as necessary from this change. Update header guard & add EOF newline in chrome/browser/ui/view_ids.h Split C/C++ system headers into blocks in: chrome/browser/ui/gtk/gtk_expanded_container.cc chrome/browser/ui/gtk/gtk_chrome_shrinkable_hbox.cc Sync manually with r71749 BUG=69289 TEST=none Review URL: http://codereview.chromium.org/6296012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71816 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust the Find test for unselectable test so that it has the right ↵finnur@chromium.org2011-01-191-10/+3
| | | | | | | | | | | expectation now that my change has been merged down. BUG=68494 TEST=Fixing a test. Review URL: http://codereview.chromium.org/6289007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71779 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some include paths that were missed in r71525.rsesek@chromium.org2011-01-151-1/+1
| | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6256005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71531 0039d316-1c4b-4281-b951-d872f2087c98
* This is the Chromium side of my WebKit change that fixes some Find issues ↵finnur@chromium.org2011-01-141-5/+9
| | | | | | | | | | | | | with text marked as user-select-none. Basically, it should now find matches within such text and therefore we get 1 of 1 instead of 0 of 0 in this test. BUG=68494 TEST=This CL modifies a test to catch this. Review URL: http://codereview.chromium.org/6315005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71451 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/key* to ui/base/keycodes/*ben@chromium.org2011-01-131-2/+2
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6246001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71330 0039d316-1c4b-4281-b951-d872f2087c98
* This is an alternate CL to the fix in http://codereview.chromium.org/5553002.varunjain@chromium.org2011-01-121-0/+1
| | | | | | | | | | | | | | | | | | The earlier fix changes the behaviour of the find bar text field such that whenever the textfield is focused, all of the text inside it is selected. This was done to fix a regression where the text was not getting selected when switching tabs (read description on that issue for more info). However, this new behaviour could be undesirable as we may not need to select the whole text everytime find bar gains focus. Hence, in this fix, we undo the changes from the earlier fix and add the selectall behaviour at the right place (when the tab is switched). BUG=none TEST=Test added in the earlier CL still passes. Review URL: http://codereview.chromium.org/6188005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71157 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the stubbed out headers in chrome/browser/views.msw@chromium.org2011-01-101-2/+2
| | | | | | | | | | | | | | | | | Update references to use headers in chrome/browser/ui/views. Update copyright dates in affected files. /chrome/browser/ui/views/constrained_html_delegate_win.cc Add space before 'private' label (presubmit warning) /chrome/browser/ui/views/toolbar_view.cc Add space before 'cleanup' label (presubmit warning) BUG=69082 TEST=Compiling... Review URL: http://codereview.chromium.org/6204002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70965 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of notification_service.h, part 2.thestig@chromium.org2010-12-171-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5928003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69576 0039d316-1c4b-4281-b951-d872f2087c98