summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ui/views/tabs
Commit message (Collapse)AuthorAgeFilesLines
* Try swapping tab drag tests SendKeyPress* order.msw@chromium.org2013-04-101-9/+9
| | | | | | | | | | | | | | | | Swap SendKeyPressToWindowSync / SendKeyPressSync order. (tests if SendKeyPressToWindowSync alone is sufficient) (otherwise two [esc] key presses are required, not sure why) See the bug for more investigation notes/context. BUG=227444 TEST=None; XP Tests (1) test output yields more info. TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/13994002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193339 0039d316-1c4b-4281-b951-d872f2087c98
* Debug TabDragControllerTest.DragAllToSeparateWindowAndCancel on XP Tests (1).msw@chromium.org2013-04-091-9/+47
| | | | | | | | | | | | | | | | Effectively disable the test for WinXP + Views Textfields. Add print-debugging code to examine the test expectations. Also try SendKeyPressToWindowSync after SendKeyPressSync. TODO(followup): Examine test output, investigate failures. BUG=227444 TEST=TabDragControllerTest.DragAllToSeparateWindowAndCancel "passes" on Win XP with Views Textfields enabled. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/13881002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193161 0039d316-1c4b-4281-b951-d872f2087c98
* views: fix poor layout of tab close buttonsestade@chromium.org2013-04-043-3/+24
| | | | | | | | | BUG=226253 Review URL: https://chromiumcodereview.appspot.com/13489005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192410 0039d316-1c4b-4281-b951-d872f2087c98
* ShowSystemMenu on Win Alt+Space with Views Textfields, etc.msw@chromium.org2013-03-291-2/+2
| | | | | | | | | | | | | | | | | | | | | Continuing on ananta's https://codereview.chromium.org/12669003 Match ui/base/ime/ and ui/views/ime/ input_method_win.cc handling. ( fixes handling of [Alt]+[Space] with --enable-views-testfield ) ( fixes KeyboardAccessTest.TestSystemMenuWithKeyboard w/ --enable-views-textfield ) Make both explicitly call ShowSystemMenu to avoid DefWindowProc artifacts. Explicitly call ui::ShowSystemMenu elsewhere to normalize placement. Add ui::ShowSystemMenuAtPoint, drop coordinate args from ui::ShowSystemMenu. ( normalizes the system menu default anchor point, inset at 10x10 ) ( see pics of the new/old placement at http://crbug.com/165966#c12 ) BUG=165966,181303 TEST=[Alt]+[Space] always shows the Windows system menu at a reasonable location (test non-Aura Win, non-Aura Win with --enable-views-textfield, and Win Aura). R=sky@chromium.org,ananta@chromium.org Review URL: https://chromiumcodereview.appspot.com/13003007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191378 0039d316-1c4b-4281-b951-d872f2087c98
* Makes MenuRunner take a MenuModel directly rather than having to usesky@chromium.org2013-03-291-5/+1
| | | | | | | | | | | | | MenuModelAdapter. BUG=none TEST=none R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/13201003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191274 0039d316-1c4b-4281-b951-d872f2087c98
* Tab audio indicator tweakssail@chromium.org2013-03-281-5/+7
| | | | | | | | | | | | | | | | | Some small tweaks to the tab audio indicator: - change the icon to be half the size (4 bars instead of 8 bars) - draw 2 columns instead of 3 - draw the icon at the bottom right - clip the favicon so that it doesn't obscure the equalizers screenshot: http://i.imgur.com/csAXHDx.png BUG=3541 Review URL: https://chromiumcodereview.appspot.com/13055002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191068 0039d316-1c4b-4281-b951-d872f2087c98
* Inconsistent use of [x] close panel icon. Code changes.varkha@chromium.org2013-03-271-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The close button in download pane should be the tab close button asset : tab_close_*.png (this was originally reported as part of BUG=173251). By the same logic the same smaller bitmap with red hover background should be used for all infobars such as translate bar, save password bar, etc. It should also be used for find-in-page bar on all platforms (Mac was missed with the previous implementation). The close button in the chrome UI and Web UI bubbles was left the same as before (this needs to be regression-tested). Code was rearranged to make explicit the disrepancy between the IDR_CLOSE_BAR and IDR_CLOSE_BUBBLE. IDR_TAB_CLOSE was renamed IDR_CLOSE_1. IDR_CLOSE_BAR was renamed IDR_CLOSE_2. png files were also renamed (this is handled by two separate committs to work around restriction on binary committs by newbies). See https://codereview.chromium.org/12703022/ for added resources. BUG=217094 TEST=Open any page that downloads an attachment such as gmail email with an attachment or a page with images. Download an image or an attachment. Verify that the close button in download bar at the bottom of the screen has a red circular background when mouse hovers over it - same as the close tab button. TEST=Open find-in-page (Ctrl+F) box on Mac, Linux and Windows and check that the close button is same as tab close (has a red circular background when mouse hovers over it). TEST=Open any infobar (translate / save password) on both ChromeOS and linux and check that the close button is same as tab close (has a red circular background when mouse hovers over it). Opening a non-English news page is usually the easiest way. TEST=Trigger chrome to show a toolbar bubble such as extension installed bubble that shows when an extension is installed from chrome web store (see bitmaps in comments attached to BUG=217094). Confirm that the close buttons in those bubbles are NOT changed from before the change (they should NOT have the red circular background when mouse hovers over). Review URL: https://chromiumcodereview.appspot.com/12703039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190844 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 190431 "Inconsistent use of [x] close panel icon"flackr@chromium.org2013-03-251-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Inconsistent use of [x] close panel icon > The close button in download pane should be the tab close button asset : tab_close_*.png > (this was originally reported as part of BUG=173251). > > By the same logic the same smaller bitmap with red hover background should be used for all infobars > such as translate bar, save password bar, etc. It should also be used for find-in-page bar on all > platforms (Mac was missed with the previous implementation). > > The close button in the chrome UI and Web UI bubbles was left the same as before (this needs to be regression-tested). > > Code was rearranged to make explicit the disrepancy between the IDR_CLOSE_BAR and IDR_CLOSE_BUBBLE. > IDR_TAB_CLOSE was renamed IDR_CLOSE_1. > IDR_CLOSE_BAR was renamed IDR_CLOSE_2. > png files were also renamed. > > BUG=217094 > TEST=Open any page that downloads an attachment such as gmail email with an attachment or a page with images. Download an image or an attachment. Verify that the close button in download bar at the bottom of the screen has a red circular background when mouse hovers over it - same as the close tab button. > > TEST=Open find-in-page (Ctrl+F) box on Mac, Linux and Windows and check that the close button is same as tab close (has a red circular background when mouse hovers over it). > > TEST=Open any infobar (translate / save password) on both ChromeOS and linux and check that the close button is same as tab close (has a red circular background when mouse hovers over it). Opening a non-English news page is usually the easiest way. > > TEST=Trigger chrome to show a toolbar bubble such as extension installed bubble that shows when an extension is installed from chrome web store (see bitmaps in comments attached to BUG=217094). Confirm that the close buttons in those bubbles are NOT changed from before the change (they should NOT have the red circular background when mouse hovers over). > > Review URL: https://codereview.chromium.org/12634025 TBR=flackr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190432 0039d316-1c4b-4281-b951-d872f2087c98
* Inconsistent use of [x] close panel iconflackr@chromium.org2013-03-251-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The close button in download pane should be the tab close button asset : tab_close_*.png (this was originally reported as part of BUG=173251). By the same logic the same smaller bitmap with red hover background should be used for all infobars such as translate bar, save password bar, etc. It should also be used for find-in-page bar on all platforms (Mac was missed with the previous implementation). The close button in the chrome UI and Web UI bubbles was left the same as before (this needs to be regression-tested). Code was rearranged to make explicit the disrepancy between the IDR_CLOSE_BAR and IDR_CLOSE_BUBBLE. IDR_TAB_CLOSE was renamed IDR_CLOSE_1. IDR_CLOSE_BAR was renamed IDR_CLOSE_2. png files were also renamed. BUG=217094 TEST=Open any page that downloads an attachment such as gmail email with an attachment or a page with images. Download an image or an attachment. Verify that the close button in download bar at the bottom of the screen has a red circular background when mouse hovers over it - same as the close tab button. TEST=Open find-in-page (Ctrl+F) box on Mac, Linux and Windows and check that the close button is same as tab close (has a red circular background when mouse hovers over it). TEST=Open any infobar (translate / save password) on both ChromeOS and linux and check that the close button is same as tab close (has a red circular background when mouse hovers over it). Opening a non-English news page is usually the easiest way. TEST=Trigger chrome to show a toolbar bubble such as extension installed bubble that shows when an extension is installed from chrome web store (see bitmaps in comments attached to BUG=217094). Confirm that the close buttons in those bubbles are NOT changed from before the change (they should NOT have the red circular background when mouse hovers over). Review URL: https://codereview.chromium.org/12634025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190431 0039d316-1c4b-4281-b951-d872f2087c98
* Make long tap to trigger context menu on tabmiletus@chromium.org2013-03-231-10/+27
| | | | | | | | | | | Showing context menu after long tap (long press & finger release) on tab. BUG=170693 Review URL: https://chromiumcodereview.appspot.com/12660016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190111 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so we don't allow detaching dragged tabs into a separatesky@chromium.org2013-03-223-2/+20
| | | | | | | | | | | | | window when in ash, the window is maximized and all the tabs are selected. BUG=164338 TEST=see bug R=jamescook@chromium.org Review URL: https://codereview.chromium.org/12938011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189849 0039d316-1c4b-4281-b951-d872f2087c98
* base/prefs: Remove the public/ directory and move the files to //base/prefs.tfarina@chromium.org2013-03-211-1/+1
| | | | | | | | | | BUG=155525 R=joi@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/12789006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189513 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the tabstrip so that when in touch mode and the tabs are notsky@chromium.org2013-03-201-1/+1
| | | | | | | | | | | | | | stacked a short press and drag reorders rather than changing the set of visible tabs. BUG=161634 TEST=see comment 2 in bug. R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/12886030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189180 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r187423: "Disable audio indicator tab icon for Chrome OS."backer@chromium.org2013-03-141-5/+0
| | | | | | | | | | | | r188038 and https://gerrit.chromium.org/gerrit/45340 mitigates some of the scheduling problems that we were having in the GPU process. It is now safe to re-enable this feature. BUG=181317 Review URL: https://chromiumcodereview.appspot.com/12868003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188213 0039d316-1c4b-4281-b951-d872f2087c98
* Audio indicator: Views UIsail@chromium.org2013-03-143-49/+34
| | | | | | | | | | | | | | This CL hooks up the new TabAudioIndicator class to the Views UI. Test build: https://docs.google.com/file/d/0B0Odde3V7EhWQklseGhYcmZ5R3M/edit?usp=sharing BUG=3541 TEST=Played audio and verified that an audio indicator was displayed in the tab. Review URL: https://codereview.chromium.org/12757002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188191 0039d316-1c4b-4281-b951-d872f2087c98
* Rotate Cursor when the display is rotatedoshima@chromium.org2013-03-141-1/+1
| | | | | | | | | | | | | | - moved Rotation enum from ash to gfx::Display so that views/ui can use it. - rotate image and hot point. BUG=119268 TEST=covered by unit tests, and also test on device. Review URL: https://chromiumcodereview.appspot.com/12666006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188174 0039d316-1c4b-4281-b951-d872f2087c98
* Remove favicon dominant color computation from tab stripjamescook@chromium.org2013-03-144-82/+1
| | | | | | | | | | | | | | We used to use the color for immersive mode, but we don't need it any more. BUG=166929 TEST=unit_tests TabTest.* TabStripTest.* R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/12710007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187994 0039d316-1c4b-4281-b951-d872f2087c98
* Delete items of the launcher jump list upon pressing Shift clickskuhne@chromium.org2013-03-131-1/+1
| | | | | | | | | | BUG=181541 TEST=unittest Review URL: https://chromiumcodereview.appspot.com/12518012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187769 0039d316-1c4b-4281-b951-d872f2087c98
* Disable audio indicator tab icon for Chrome OS.hshi@chromium.org2013-03-121-0/+5
| | | | | | | | | | | | | | | | | | There appears to be an underlying gfx scheduling problem with Chrome OS that causes hardware-accelerated video decoding to be affected by animating tab icons. The fix is tracked under issue 181317. For the time being disable the audio indicator tab icon for Chrome OS. BUG=180332 TEST=manually verified on link Review URL: https://chromiumcodereview.appspot.com/12741002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187423 0039d316-1c4b-4281-b951-d872f2087c98
* Adding mask around tab recording icon for Views.grunell@chromium.org2013-03-082-45/+121
| | | | | | | | | BUG=175737 Review URL: https://chromiumcodereview.appspot.com/12459012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187019 0039d316-1c4b-4281-b951-d872f2087c98
* Remove NewTabButton field trial.asvitkine@chromium.org2013-03-071-15/+1
| | | | | | | | | | Resources will be removed in a separate CL. BUG=180363 Review URL: https://chromiumcodereview.appspot.com/12492002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186572 0039d316-1c4b-4281-b951-d872f2087c98
* Immersive fullscreen polishjamescook@chromium.org2013-03-052-6/+10
| | | | | | | | | | | | | | | 1. Change loading indicator color to blue 2. Slow down the initial slide-out 3. Always paint the caption area black, like maximized 4. Clicks in the top pixel of the screen switch tabs 5. Fix a crash due to tooltip position lookup during view reparenting BUG=180022 TEST=manual, existing unit_tests and browser_tests Review URL: https://codereview.chromium.org/12393062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186102 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Add page load indicator for immersive fullscreenjamescook@chromium.org2013-03-042-19/+73
| | | | | | | | | | | | The animation is a placeholder (a moving red rectangle) until we decide if immersive fullscreen will ship. BUG=none TEST=manual, enable Immersive Fullscreen in about:flags, enter fullscreen, reload a page, watch bar at top of screen animate Review URL: https://chromiumcodereview.appspot.com/12390051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185839 0039d316-1c4b-4281-b951-d872f2087c98
* An even better fix for the tab crasher while audio indicator is oncpu@chromium.org2013-03-023-10/+117
| | | | | | | | | | | | | | | | | | | | | | | | | | See bug below, basically the issue happens if you are: - playing audio - capturing like with webrtc - tab changes icon or caption - capturing stops I know it sounds like hard to find case however hangouts makes it happen. If you can see both the audio indicator which is an equalizer and the capture which is a red dot,then you are in the problem zone. This time arround I have unittests for the relevant cases. BUG=178154 TEST= see bug Review URL: https://codereview.chromium.org/12377038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185667 0039d316-1c4b-4281-b951-d872f2087c98
* views: Build tab_renderer_tab.* within browser_ui_views library.tfarina@chromium.org2013-03-011-1/+2
| | | | | | | | | BUG=125846 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/12379015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185616 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land: move HWND utilities to ui/views/win.dmazzoni@chromium.org2013-03-011-2/+2
| | | | | | | | | | Originally committed r185554, reverted in 185578 BUG=none Review URL: https://codereview.chromium.org/12315135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185590 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 185554wez@chromium.org2013-03-011-2/+2
| | | | | | | | | | | | | | | This broke Win Aura because external_tab_container_win.cc was not updated for the file move and namespace change. > Move HWND utilities to ui/views/win. > > BUG=none > > Review URL: https://codereview.chromium.org/12315135 TBR=dmazzoni@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185578 0039d316-1c4b-4281-b951-d872f2087c98
* Move HWND utilities to ui/views/win.dmazzoni@chromium.org2013-03-011-2/+2
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/12315135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185554 0039d316-1c4b-4281-b951-d872f2087c98
* Yet another fix for crash in the tab audio indicatorcpu@chromium.org2013-02-281-15/+17
| | | | | | | | | | | | | | | | | | | | Again, this happens with tab capture at the same time I missed one case, in that the 'old' data needs to be reset or else you can also enter StopIconAnimation in the same Tab::SetData function. See the previous fixes: https://codereview.chromium.org/12319104 https://codereview.chromium.org/12314134 BUG=178154 TEST= see bug R=sky Review URL: https://codereview.chromium.org/12376002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185081 0039d316-1c4b-4281-b951-d872f2087c98
* Reland ash: Use immersive mode for fullscreenjamescook@chromium.org2013-02-271-3/+4
| | | | | | | | | | | | | | | | | | * Remove immersive mode button from maximized window frame * Tie immersive mode to browser-fullscreen only, keep tab-fullscreen with existing UI * Size button exits immersive mode * Add ImageButton::GetImage for testing * Most browser commands are enabled in immersive fullscreen BUG=177549 TEST=added to browser_tests views_unittests ash_unittests Original review: https://codereview.chromium.org/12316086/ Review URL: https://chromiumcodereview.appspot.com/12328119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184908 0039d316-1c4b-4281-b951-d872f2087c98
* Rework ash::CursorManager into a corewm object, to share code with desktop.erg@chromium.org2013-02-271-1/+0
| | | | | | | | | | | Desktop aura no longer spams the console with enable/disable mouse pointer messages. BUG=none Review URL: https://chromiumcodereview.appspot.com/12263050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184798 0039d316-1c4b-4281-b951-d872f2087c98
* Better fix for crash in tab.cccpu@chromium.org2013-02-271-10/+14
| | | | | | | | | | | | | | | The fix of https://codereview.chromium.org/12319104 was incomplete as we need to reset the state of the data_.audio_state to NONE if we are doing the capture animation. See the bug for the crash locations BUG=178154 TEST=see bug Review URL: https://codereview.chromium.org/12314134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184790 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 184600jamescook@chromium.org2013-02-261-4/+3
| | | | | | | | | | | | | | | | | | | | | | | Breaks omnibox text input after leaving immersive mode, will fix and reland > ash: Use immersive mode for fullscreen > > * Remove immersive mode button from maximized window frame > * Tie immersive mode to browser-fullscreen only, keep tab-fullscreen > with existing UI > * Size button exits immersive mode > * Add ImageButton::GetImage for testing > > BUG=177549 > TEST=added to browser_tests views_unittests ash_unittests > > > Review URL: https://chromiumcodereview.appspot.com/12316086 TBR=jamescook@chromium.org Review URL: https://codereview.chromium.org/12335098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184669 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Use immersive mode for fullscreenjamescook@chromium.org2013-02-261-3/+4
| | | | | | | | | | | | | | | | * Remove immersive mode button from maximized window frame * Tie immersive mode to browser-fullscreen only, keep tab-fullscreen with existing UI * Size button exits immersive mode * Add ImageButton::GetImage for testing BUG=177549 TEST=added to browser_tests views_unittests ash_unittests Review URL: https://chromiumcodereview.appspot.com/12316086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184600 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WebContents methods that duplicate WebContentsView methods.jam@chromium.org2013-02-261-3/+4
| | | | | | Review URL: https://codereview.chromium.org/12334073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184598 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crasher in tab icon indicatorcpu@chromium.org2013-02-252-33/+21
| | | | | | | | | | | | | | | | | | | | | | | | We believe from evidence that the audio animation and the recording / projecting animation make the state of icon_animation_ get out of whack For example, consider: 1- that we are projecting 2- then a sound is played in the tab 3- then the sounds ends 4- tab needs to be repainted At #3 the icon_animation_ is .reset() yet capture_state != CAPTURE_STATE_NONE So at #4 we would crash as seen in the bug comment #1 BUG=178154 TEST=see bug Review URL: https://codereview.chromium.org/12319104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184518 0039d316-1c4b-4281-b951-d872f2087c98
* Audio indicator in each tabcpu@chromium.org2013-02-225-19/+70
| | | | | | | | | | | | | | | | | | Basically a throbber animation that cycles over a number of frames on a bitmap. Currently only 6 frames, which is too little but good enough for testing. Note that the tab.cc logic should make it so that the audio indicator is low on the priority. That is, if the tab is recording or broadcasting and playing sounds that should show instead of the audio animation. BUG=3541 TEST=see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183977 Review URL: https://codereview.chromium.org/12328027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184183 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 183977dalecurtis@google.com2013-02-225-70/+19
| | | | | | | | | | | | | | | | | | | | | | | | > Audio indicator in each tab > > Basically a throbber animation that cycles over a number of > frames on a bitmap. Currently only 6 frames, which is too little > but good enough for testing. > > Note that the tab.cc logic should make it so that the audio indicator > is low on the priority. That is, if the tab is recording or broadcasting and > playing sounds that should show instead of the audio animation. > > BUG=3541 > TEST=see bug > > Review URL: https://chromiumcodereview.appspot.com/12328027 Broke Linux ChromiumOS Debug Clang: http://goo.gl/iOwf2 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/12319058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183980 0039d316-1c4b-4281-b951-d872f2087c98
* Audio indicator in each tabcpu@chromium.org2013-02-225-19/+70
| | | | | | | | | | | | | | | | | Basically a throbber animation that cycles over a number of frames on a bitmap. Currently only 6 frames, which is too little but good enough for testing. Note that the tab.cc logic should make it so that the audio indicator is low on the priority. That is, if the tab is recording or broadcasting and playing sounds that should show instead of the audio animation. BUG=3541 TEST=see bug Review URL: https://chromiumcodereview.appspot.com/12328027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183977 0039d316-1c4b-4281-b951-d872f2087c98
* Merge BrowserListImpl into BrowserList.gab@chromium.org2013-02-213-18/+14
| | | | | | | | | | | | | | | | Kept AddBrowser and RemoveBrowser static (having it access the private members of the appropriate list for the browser added/removed); kept AddObserver and RemoveObserver static so that observers are notified about browser additions, removals, and set actives on every desktop (observers should filter if they so desire). The only calls that are not-static (i.e. for which consumers need to be aware of HostDesktopType) are: iterators, size(), empty(), get(), and GetLastActive(). All the consumers were already made multi-desktop aware in the multiple CLs preceding this one :)! BUG=129187, 177341 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183580 Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=183701 Review URL: https://chromiumcodereview.appspot.com/12281006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183853 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 183580 - added a static initializer on Macyoz@chromium.org2013-02-213-14/+18
| | | | | | | | | | | | | | | | | | > Merge BrowserListImpl into BrowserList. > > Kept AddBrowser and RemoveBrowser static (having it access the private members of the appropriate list for the browser added/removed); kept AddObserver and RemoveObserver static so that observers are notified about browser additions, removals, and set actives on every desktop (observers should filter if they so desire). > > The only calls that are not-static (i.e. for which consumers need to be aware of HostDesktopType) are: iterators, size(), empty(), get(), and GetLastActive(). All the consumers were already made multi-desktop aware in the multiple CLs preceding this one :)! > > BUG=129187 > > > Review URL: https://chromiumcodereview.appspot.com/12281006 TBR=gab@chromium.org Review URL: https://codereview.chromium.org/12310034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183701 0039d316-1c4b-4281-b951-d872f2087c98
* views: Start building some tabs/ files within browser_ui_views library.tfarina@chromium.org2013-02-212-3/+5
| | | | | | | | | | BUG=125846 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/12319029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183677 0039d316-1c4b-4281-b951-d872f2087c98
* Merge BrowserListImpl into BrowserList.gab@chromium.org2013-02-203-18/+14
| | | | | | | | | | | | | Kept AddBrowser and RemoveBrowser static (having it access the private members of the appropriate list for the browser added/removed); kept AddObserver and RemoveObserver static so that observers are notified about browser additions, removals, and set actives on every desktop (observers should filter if they so desire). The only calls that are not-static (i.e. for which consumers need to be aware of HostDesktopType) are: iterators, size(), empty(), get(), and GetLastActive(). All the consumers were already made multi-desktop aware in the multiple CLs preceding this one :)! BUG=129187 Review URL: https://chromiumcodereview.appspot.com/12281006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183580 0039d316-1c4b-4281-b951-d872f2087c98
* Split out the static methods from ThemeService to ThemeProperties.pkotwicz@chromium.org2013-02-181-3/+3
| | | | | | | | | | | | | The goal of this change is to make BrowserThemePack not depend on ThemeService anymore and to make it clearer as to which changes require updating the version number in browser_theme_pack.h BUG=None Test=None Review URL: https://chromiumcodereview.appspot.com/12207103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183134 0039d316-1c4b-4281-b951-d872f2087c98
* Part I: clear primary and selection clipboards if data came from content area.vasilii@chromium.org2013-02-181-0/+1
| | | | | | | | | BUG=171974 TBR=asargent,sky Review URL: https://chromiumcodereview.appspot.com/12041078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183123 0039d316-1c4b-4281-b951-d872f2087c98
* Makes running a move loop ignore events from a source other than thesky@chromium.org2013-02-157-15/+26
| | | | | | | | | | | | | one that initiated the drag. BUG=172950 TEST=none R=sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/12212177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182651 0039d316-1c4b-4281-b951-d872f2087c98
* move --aura-host-window-size to --ash-host-window-bounds oshima@chromium.org2013-02-151-3/+3
| | | | | | | | | | | | remove --use-fullscreen-window as this is no longer necessary. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/12261018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182617 0039d316-1c4b-4281-b951-d872f2087c98
* Do not cache the tab background if a tab background was autogenerated by a themepkotwicz@chromium.org2013-02-131-1/+13
| | | | | | | | | BUG=175426 Test=None Review URL: https://chromiumcodereview.appspot.com/12218093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182095 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly hardcode tab_drag_controller_interactive_uitest.cc to use the ↵gab@chromium.org2013-02-123-67/+91
| | | | | | | | | | | | | | native desktop list. Getting rid of some of the last BrowserList:: iterator methods :)! Also making BrowserListImpl const-safe (otherwise GetLastActive(), required in this CL, couldn't be used on a const BrowserListImpl*). BUG=129187 Review URL: https://codereview.chromium.org/12213091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181984 0039d316-1c4b-4281-b951-d872f2087c98
* Update graphics for the tab recording indicatortommi@chromium.org2013-02-111-11/+39
| | | | | | Review URL: https://codereview.chromium.org/12208111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181779 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-06-08 12:03:31 +0000