summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ui/views
Commit message (Collapse)AuthorAgeFilesLines
* Move UserMetrics to content.michaeln@google.com2011-04-2714-85/+57
| | | | | | | | | | | | | | Just the class that provides the action logging API which is used all over the place is being moved. The UserMetrics class uses the notification system to inform the core of the user metrics system of each event, that core part is not being moved. Also take care of a TODO to remove the class methods that take a Profile* as a paramter (since Profile is verbotten in /content). BUG=78499 Review URL: http://codereview.chromium.org/6883021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83251 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move AutocompleteEditViewWin/autocomplete_edit_view_win.* to ↵tfarina@chromium.org2011-04-276-11/+3164
| | | | | | | | | | | | | | | | ui/views/omnibox directory. - Rename AutocompleteEditViewWin to OmniboxViewWin. - Move autocomplete_edit_view_win.* to omnibox_view_win.* BUG=80186 TEST=None R=pkasting@chromium.org Review URL: http://codereview.chromium.org/6902055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83156 0039d316-1c4b-4281-b951-d872f2087c98
* Scrap WNDCLASSEX.hCursor, update GetCursorForPoint.msw@chromium.org2011-04-271-10/+1
| | | | | | | | | | | | | | | | | Default to Win arrow in View::GetCursorForPoint & RootView::UpdateCursor. Simplify WidgetWin::SetCursor, avoid sending NULL. Only SetCuror on client events (DWM handles non-client). RIP TextButtonWithHandCursorOver (r57652 through r64531). RIP WindowWin::InitClass & |resize_cursors_|. Add OVERRIDE specifiers liberally. BUG=35356 TEST=Cursor styles shown in Win & Linux toolkit_views. Review URL: http://codereview.chromium.org/6880201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83123 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Move AutocompleteEditViewGtk/autocomplete_edit_view_gtk.* to ↵tfarina@chromium.org2011-04-262-5/+3
| | | | | | | | | | | | | | | | ui/gtk/omnibox directory. - Rename AutocompleteEditViewGtk to OmniboxViewGtk. - Move autocomplete_edit_view_gtk.* to omnibox_view_gtk.* BUG=80186 TEST=None R=pkasting@chromium.org,evan@chromium.org Review URL: http://codereview.chromium.org/6905030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83086 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in menu code that would happen if you attempted to show asky@chromium.org2011-04-261-8/+82
| | | | | | | | | | | | | | | context menu while a context menu was already shown. The code would end up attempting to access an object that was since deleted (the MenuItemView). In fixing the crash I realized the logic wasn't quite right for this case either, so fixed that too and added a test. BUG=80392 TEST=see bug R=ben@chromium.org Review URL: http://codereview.chromium.org/6905033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83066 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CreateParams to InitParams.ben@chromium.org2011-04-2624-31/+31
| | | | | | | | | http://crbug.com/72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6901034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83057 0039d316-1c4b-4281-b951-d872f2087c98
* Show hardware addresses for wifi and ethernet networks.dilmah@chromium.org2011-04-261-1/+1
| | | | | | | | | | | | | | | | | | | Network menu (in status area button) is modified in following way: In oobe and login screen we add "More..." submenu and show hardware addresses in submenu. In login screen we additionally show proxy settings in this submenu. In browser this menu is unchanged because: (1) we assume that there is no need in those hardware addresses since login was successful. (2) user can see them via other means. We add some methods (GetWifiDevice and GetEthernetDevice) to login_library because we need to obtain hardware addresses for ethernet and wifi even if there is no visible wi-fi networks and if ethernet is disconected. BUG=chromium-os:13010 TEST=Manual Review URL: http://codereview.chromium.org/6899025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83046 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang by making type_ defined during OS_LINUX non-OS_CHROMEOS builds.ben@chromium.org2011-04-262-2/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83045 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the way Widget::Init works:ben@chromium.org2011-04-2629-122/+124
| | | | | | | | | | | | | - Remove SetCreateParams from the public Widget API. - Add parent/bounds fields to CreateParams - Make Widget::Init be the canonical init method (vs. WidgetWin/Gtk Init) and have it take a CreateParams. - NativeWidget now has a InitNativeWidget method, which subclasses can override. Everyone must call Widget::Init via Widget* (not WidgetWin* as this will be ambiguous to WindowImpl::Init). BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6881107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83037 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors handling of NativeWebKeyboardEvent into a commonsky@chromium.org2011-04-263-5/+39
| | | | | | | | | | | | | | | | place. Another approach is to promote HandleKeyboardEvent to Widget. This might be premature though as it doesn't appear the X side needs this code. Let me know which you prefer. BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6902014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83016 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: remove wstring functions from base/i18n/rtl.hevan@chromium.org2011-04-251-7/+6
| | | | | | | | | | And update callers. BUG=23581 Review URL: http://codereview.chromium.org/6883140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82924 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move LinkController into its own header file.tfarina@chromium.org2011-04-2527-132/+159
| | | | | | | | | | | | | | | | | | | While I'm here, did some changes: - Rename the LinkController interface to LinkListener. - Move the interface to link_listener.h - Rename the event from LinkActivated to LinkClicked. - Changed the get/set accessors to listener()/set_listener(). - Add OVERRIDE to LinkClicked methods. BUG=None TEST=None R=sky@chromium.org Review URL: http://codereview.chromium.org/6881099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82885 0039d316-1c4b-4281-b951-d872f2087c98
* options: Get rid of the unused OptionsGroup enum.tfarina@chromium.org2011-04-252-3/+1
| | | | | | | | | | | | | | While I'm here, move the enum OptionsPage to options_util.h, so we can get rid of the options_window.h header file too. BUG=None TEST=None R=jhawkins@chromium.org Review URL: http://codereview.chromium.org/6898036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82866 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes another case of object getting deleted while menu is showingsky@chromium.org2011-04-252-1/+17
| | | | | | | | | | | | | | | causing problems. We seem to get a never ending stream of bugs because of this. I'm beginning to think we should convert to using non-native menus and no longer block in Run. That way problems like this should go away. BUG=80099 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6882105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82859 0039d316-1c4b-4281-b951-d872f2087c98
* Move blocked content from TabContents to TabContentsWrapper.avi@chromium.org2011-04-223-7/+7
| | | | | | | | | BUG=71097 TEST=hammer on popup blocking; should be no visible change Review URL: http://codereview.chromium.org/6854035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82643 0039d316-1c4b-4281-b951-d872f2087c98
* Make InfoBarDelegate::GetIcon() return gfx::Image rather than SkBitmap.rsesek@chromium.org2011-04-211-2/+3
| | | | | | | | | BUG=carnitas TEST=visual Review URL: http://codereview.chromium.org/6883095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82569 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] First pass at multiple selection in the tabstrip.rsesek@chromium.org2011-04-211-1/+1
| | | | | | | | | | | | | | | | | | | This hooks up a new TabController state (called 'active') to indicate what 'selected' used to: key/focused state. The selected state can now be applied to multiple TabControllers. Currently only commands available through the context menu are usable for a multi-tab selection. Support for dragging will come in a future CL. The other notable chane is that tab activation now happens on |-mouseUp:| rather than |-mouseDown:|, which is in preparation for multi-tab dragging. BUG=78816 TEST=Shift click, Cmd click, and Cmd+Shift click to select tabs in different ways. Review URL: http://codereview.chromium.org/6821003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82543 0039d316-1c4b-4281-b951-d872f2087c98
* Split out large icons into a separate resource paksail@chromium.org2011-04-2115-2/+16
| | | | | | | | | | | | | | This is a part of r82185 that was reverted. The change was reverted because it caused a performance regression. I'm checking in just the reorganization code to narrow down exactly which part of the change caused the regression. The only code change here is some header includes. If this change passes the perf bot then my next change will be to load the new resource pak. BUG=None TEST=None Review URL: http://codereview.chromium.org/6883110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82538 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82497 - Split out large icons into a separate resource pakThis is a ↵sail@chromium.org2011-04-2115-16/+2
| | | | | | | | | part of r82185 that was reverted. The change was reverted because it caused a performance regression.I'm checking in just the reorganization code to narrow down exactly which part of the change caused the regression.The only code change here is some header includes. If this change passes the perf bot then my next change will be to load the new resource pak.BUG=NoneTEST=NoneReview URL: http://codereview.chromium.org/6883110 TBR=sail@chromium.org Review URL: http://codereview.chromium.org/6879113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82502 0039d316-1c4b-4281-b951-d872f2087c98
* Split out large icons into a separate resource paksail@chromium.org2011-04-2115-2/+16
| | | | | | | | | | | | | | | This is a part of r82185 that was reverted. The change was reverted because it caused a performance regression. I'm checking in just the reorganization code to narrow down exactly which part of the change caused the regression. The only code change here is some header includes. If this change passes the perf bot then my next change will be to load the new resource pak. BUG=None TEST=None Review URL: http://codereview.chromium.org/6883110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82497 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of "Select tabs when dragging onto them".asvitkine@chromium.org2011-04-214-3/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mac and Windows implementation. Also known as "spring loaded tabs" - which comes from the term Apple coined for similar functionality in the Finder with folders (spring loaded folders). This CL adds the helper class SpringLoadedTabStripHelper which contains the cross-platform logic for transitioning to the tab with a delay. The class is then used from platform-specific tab strip code in response to drag events. The delay between when you hover over a tab and the tab selection taking place is currently 0.5 seconds. Also, the CL changes the "drop indicator over tab" area to be the middle 1/2 of the tab, instead of 1/3 to make it easier to hover of a tab on Windows. (On the Mac, it was already at 1/2.) BUG=19071 TEST=1. Select some text and drag it over an inactive tab. In 0.5 seconds, the tab selection should switch to that tab. You should now be able to drag the text into the content area of that tab (e.g. into a text box). 2. Select some text and drag it over an inactive tab. Without waiting over 0.5 seconds, move the mouse away from that tab. No tab switch should take place. Review URL: http://codereview.chromium.org/6806013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82492 0039d316-1c4b-4281-b951-d872f2087c98
* OnWindowPosChanged override wasn't calling through to WidgetWin impl, ↵ben@chromium.org2011-04-201-0/+1
| | | | | | | | | | resulting in the RootView never getting sized. http://crbug.com/79432 TEST=see bug Review URL: http://codereview.chromium.org/6877104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82403 0039d316-1c4b-4281-b951-d872f2087c98
* Revert high res icon changessail@chromium.org2011-04-2015-16/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The new high res icon change may have caused a perf regression. To verify I'm reverting the following chnages: commit 3a360c6b3d2fc174cb7597d6365cfc5418d1442b r82326 Disable loading high res icons on Mac commit 3c39226937a39d0042b8a794f13505c7a25ca58b r82247 Fix reload button unit test commit f87ab117fc159566868e71e4df5672852bebd718 r82245 Unregister toolbar view from window notifications commit 0b287ba4a4ad5c19d901f973eb9af594dcf3dba1 r82239 Fix failing Mac unit tests commit 8b681c46a139d12151323952c58122f6805d7597 r82236 Mac: Remove custom drawn buttons commit 6ae8a2fe40485731b86267e362936db16b4c0706 r82209 Fix clang build break commit e8a19d1e0c76f204c834318566e4206320583449 r82185 Add support for multi resolution icons BUG=None TEST=Compling Review URL: http://codereview.chromium.org/6878077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82352 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at hiding the crash seen on ChromeOS in ↵ben@chromium.org2011-04-201-8/+9
| | | | | | | | | | ToolbarView::PopupTopSpacing. I don't understand the circumstances behind it occurring but this change should be pretty harmless. BUG=76064 TEST=none Review URL: http://codereview.chromium.org/6777013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82343 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust infobar arrow height when the toolbar height changes. This also ↵pkasting@chromium.org2011-04-2012-107/+241
| | | | | | | | | | fixes infobars having thewrong top arrow height in popups. BUG=76388 TEST=open and close the bookmark bar with an infobar open. The infobar arrow should adjust per the mocks in the bug. Review URL: http://codereview.chromium.org/6880059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82251 0039d316-1c4b-4281-b951-d872f2087c98
* Add enum histogram for dangerous download save or discard.mattm@chromium.org2011-04-191-1/+1
| | | | | | | | | BUG=79490 TEST=save or discard a dangerous download, check about:histograms Review URL: http://codereview.chromium.org/6849004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82186 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for multi resolution iconssail@chromium.org2011-04-1915-2/+16
| | | | | | | | | | | | | | | | | | | | | | | | To support HiDPI we need a way to load two copies of icons, a low resolution version and a high resolution version. To support this, this change does the following: - split theme_resource.grd into three files: - theme_resources.grd: icons that only have one resolution - theme_resources_standard.grd: low resolution icons - theme_resources_large.grd: high resolution icons - theme_resource.grd and theme_resources_standard.grd and compiled into chrome.pak/chrome.rc for all platforms. - theme_resources_large.grd is compiled into theme_resources_large.pak for platforms that want high resolution icons (currently only Mac) - gfx::Image now support icons with multiple resolution Currently not all ThemeService APIs return multi-resolution images. Once this is checked in I'll work on converting them as I go. Note, this change will have to be coordinated with the change to reorganize theme resources. I'll work with saintlou on that. BUG=75812 TEST=Added a TIFF to theme_resources.grd. Verified that the toolbar icon had a mutliresolution image. Verified that unit tests passed. Review URL: http://codereview.chromium.org/6849030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82185 0039d316-1c4b-4281-b951-d872f2087c98
* Disable PDF tests and SizeWindow on Chrome OSrkc@chromium.org2011-04-191-2/+3
| | | | | | | | | | | | | PDF tests have been disabled due to a crash they have on Chrome OS; see attached bug. The SizeWindow test doesn't apply to ChromeOS since Chrome OS doesn't allow resizing windows anyway. R=zelidrag@chromium.org BUG=chromium:79837 TEST=Built and ran the tests I can for a Chromium build, PDF browertests won't run unless I have an official build; also ran the trybots. Review URL: http://codereview.chromium.org/6879029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82144 0039d316-1c4b-4281-b951-d872f2087c98
* Centralizes checking for non-null return from CreateWindow.sky@chromium.org2011-04-191-0/+1
| | | | | | | | | | BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6880034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82137 0039d316-1c4b-4281-b951-d872f2087c98
* Move BubbleBorder support from ExtensionPopup to BrowserBubble.xiyuan@chromium.org2011-04-1914-449/+480
| | | | | | | | | | | | | | | | | | | - Split BorderContents from border.cc/h into border_contents.cc/h; - Use BubbleBackground for BorderContents so no longer need to override OnPaint; - Add SetBackgroundColor to BorderContents to make background color configurable; - Rename BorderWidget to BorderWidgetWin and put into border_widget_win.cc/h; - Move the bubble border support from ExtensionPopup into BrowserBubble and implement it using BorderContents/BorderWidgetWin; BUG=chromium-os:14075 TEST=Verify fix for chromium-os:14075 Review URL: http://codereview.chromium.org/6874021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82122 0039d316-1c4b-4281-b951-d872f2087c98
* New cancel test (includes change in DownloadItem::Complete meaning andrdsmith@chromium.org2011-04-191-1/+0
| | | | | | | | | | | | | | | | | notification interface). * Changed DownloadItem::COMPLETE state to mean "really all done" with download (used to mean "all data received"). This isn't a very large change, since we recently put in another change to dangerous downloads where we didn't recognize all data received until we had been accepted by the user, which means that there aren't any blocking points between all data received and COMPLETE. * Removed DownloadItem::Observer::OnDownloadFileCompleted() notification. It's now redundant with the COMPLETE state, and the COMPLETE state works better for synchronization (because you can test the download item for it as opposed to having to be an observer when the notification is sent). * Added a basic test for cancel functionality in the downloads system. Also shifted MarkAsComplete to be used only by SavePackage, and make sure that the final transition occurs for drag-n-drop downloads (which don't need to go through name finalization). BUG=78183 TEST=All known download tests, manual drag-and-drop and dangerous accept/discard pre/post data received. Review URL: http://codereview.chromium.org/6720061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82113 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some omnibox extension icon issues:pkasting@chromium.org2011-04-1911-121/+106
| | | | | | | | | | | | | * API naming: call it what it is -- rename GetSpecialIcon[...]() to GetIconIfExtensionMatch() * Fix layout/alignment problems since extension icons are 16x16 instead of 19x19. (The new constant in LocationBarView will also be useful to me later in an infobar change.) While I'm mucking with the AutocompelteResultView, this cleans up a ton of crappiness in there, mostly related to the "touch" subclass that has been reworked to extend its parent in a much moe lightweight way. BUG=none TEST=Install an extension that provides an omnibox keyword; icons in the dropdown and in the special "keyword mode" omnibox appearance should align with each other and the other icons. Review URL: http://codereview.chromium.org/6878036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82112 0039d316-1c4b-4281-b951-d872f2087c98
* Enable one test for more debugging and remove debugging code from another testfinnur@chromium.org2011-04-191-2/+31
| | | | | | | | | | | that hasn't been problematic since it was enabled (crash was caused by an unrelated problem that has now been fixed, apparently). BUG=64304, 69882 TEST=None, just changing automated tests. Review URL: http://codereview.chromium.org/6877007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82100 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the context menu on the keyboard overlay and the print dialog.mazda@chromium.org2011-04-192-0/+6
| | | | | | | | | | | | | This change fixes the crash bug which happens when right-clicking the keyboard overlay or the print dialog. BUG=chromium-os:14147 TEST=manually on the chrome notebook Review URL: http://codereview.chromium.org/6879006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82048 0039d316-1c4b-4281-b951-d872f2087c98
* Fix infobar animation bug: reversed argument meant the browser didn't ↵pkasting@chromium.org2011-04-191-1/+1
| | | | | | | | | | properly re-layout the content area at the end of infobar animation. BUG=none TEST=none Review URL: http://codereview.chromium.org/6878035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82047 0039d316-1c4b-4281-b951-d872f2087c98
* first-run: Move ShowFirstRunDialog() function to first_run_dialog.htfarina@chromium.org2011-04-181-2/+27
| | | | | | | | | | | | | So first_run doesn't need to depend on chrome/browser/ui/. BUG=79586 TEST=None R=jhawkins@chromium.org Review URL: http://codereview.chromium.org/6871032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82014 0039d316-1c4b-4281-b951-d872f2087c98
* views: Organize downloads UI files into the ↵tfarina@chromium.org2011-04-189-18/+18
| | | | | | | | | | | | | | | chrome/browser/ui/views/download/ directory. cocoa and gtk already has this directory layout. BUG=None TEST=None R=rdsmith@chromium.org,dmazzoni@chromium.org Review URL: http://codereview.chromium.org/6865044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81975 0039d316-1c4b-4281-b951-d872f2087c98
* More TabStripModel renaming:sky@chromium.org2011-04-182-7/+7
| | | | | | | | | | | | | | | | AddTabTypes::ADD_SELECTED -> ADD_ACTIVE SelectTabContentsAt -> ActivateTabAt BUG=none TEST=none R=ben@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/6840007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81947 0039d316-1c4b-4281-b951-d872f2087c98
* Made full tab file browser to open automatically when a new disk device is ↵zelidrag@chromium.org2011-04-161-106/+4
| | | | | | | | | | properly mounted. BUG=chromium-os:14215 TEST=plug in SD card or USB key, observe file browser opens and navigates to that new device Review URL: http://codereview.chromium.org/6865033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81881 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some infobar drawing glitches:pkasting@chromium.org2011-04-1613-49/+69
| | | | | | | | | | | * Glass mode popups used the wrong separator color, making the arrow look weird * The stroke/fill were not being drawn quite correctly due to some subtle AA-related issues BUG=none TEST=none Review URL: http://codereview.chromium.org/6875017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81846 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the TabContentsDelegate::ToolbarSizeChanged() method as no one was ↵pkasting@chromium.org2011-04-1510-22/+7
| | | | | | | | | | using it. Rename BrowserWindow::SelectedTabToolbarSizeChanged() to ToolbarSizeChanged() as there are no per-tab toolbars since we made the DownloadShelf per-window a while ago. BUG=none TEST=none Review URL: http://codereview.chromium.org/6870002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81834 0039d316-1c4b-4281-b951-d872f2087c98
* Removes code added to track down crash. The crash seems to havesky@chromium.org2011-04-151-13/+0
| | | | | | | | | | | | | | | | | | | | occurred for two reasons: . window class name changing out from under us. . CreateWindow returning NULL because we're out of memory. I've changed the following: . Left in CHECK on return from CreateWindow. . Removed dependency on class name. We don't really need it anyway. I've also changed View::PaintFocusableBorder to check focusable last, as that requires looking up the FocusManager BUG=77651 TEST=none Review URL: http://codereview.chromium.org/6865023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81812 0039d316-1c4b-4281-b951-d872f2087c98
* first-run: Pull out FirstRunBrowserProcess/ImportObserver into their own ↵tfarina@chromium.org2011-04-151-0/+1
| | | | | | | | | | | | | | | header files. This cleanups the first_run.h file a little bit. BUG=None TEST=None R=jhawkins@chromium.org Review URL: http://codereview.chromium.org/6871002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81810 0039d316-1c4b-4281-b951-d872f2087c98
* Policy to manage file selection dialogs.pastarmovj@chromium.org2011-04-154-48/+46
| | | | | | | | | | | | | | | | Adds a policy to allow/disallow file selection dialogs from wherever they can be launched (Save Link As, Import Bookmarks, etc.). In case file selection dialogs are disallowed by policy a InfoBar informs the user whenever he triggers a file selection dialog. BUG=73174 TEST=Manually set the policy and check if the corresponding file selection are not shown and the InfoBar appears. Review URL: http://codereview.chromium.org/6814011 Patch from Sandro Feuz <sfeuz@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81804 0039d316-1c4b-4281-b951-d872f2087c98
* Make most shotcut keys take effect on the keyboard overlay. mazda@chromium.org2011-04-156-32/+170
| | | | | | | | | | | | | | | | | This patch makes shortcut keys handled by chrome's accelerator handler take effect on the keyboard overlay. In order to do keyboard overlay specific accelerator handling, I introduced a KeyboardOverlayDialogView class which inherit from HtmlDialogView. keyboard_overlay_dialog_view.cc was accidentally compiled for the linux build with the initial patch and that caused build errors. This patch fixes the build error by excluding it from the linux build. BUG=chromium-os:13016 TEST=manually on chrome notebook Review URL: http://codereview.chromium.org/6871003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81733 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Make most shotcut keys take effect on the keyboard overlay."mazda@chromium.org2011-04-156-170/+32
| | | | | | | | This reverts commit 9a675193fe08ff3dcdf089ace0e61d21dd14856b. TBR=tfarina@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81700 0039d316-1c4b-4281-b951-d872f2087c98
* Make most shotcut keys take effect on the keyboard overlay.mazda@chromium.org2011-04-156-32/+170
| | | | | | | | | | | | | | This patch makes shortcut keys handled by chrome's accelerator handler take effect on the keyboard overlay. In order to do keyboard overlay specific accelerator handling, I introduced a KeyboardOverlayDialogView class which inherit from HtmlDialogView. BUG=chromium-os:13016 TEST=manually on chrome notebook Review URL: http://codereview.chromium.org/6854019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81699 0039d316-1c4b-4281-b951-d872f2087c98
* Revert unspoofable infobar appearance to use an arrow pointing to the ↵pkasting@chromium.org2011-04-159-83/+75
| | | | | | | | | | omnibox, rather than a tab on the left edge. This does not yet change the arrow height when the bookmark bar is open. BUG=76388 TEST=Infobar "unspoofable" UI looks like an arrow, not a tab Review URL: http://codereview.chromium.org/6854028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81689 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid sending notification of losing focus to the renderer side when a ↵yzshen@chromium.org2011-04-141-0/+7
| | | | | | | | | | | | | context menu is shown. This fixes the CrOS behavior, making it the same as Linux Chromium. BUG=None TEST=On CrOS: (1) use Pepper flash to show a .swf file; (2) select some text on the flash; (3) click right button on the selection. The selection should not disappear. Review URL: http://codereview.chromium.org/6840067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81674 0039d316-1c4b-4281-b951-d872f2087c98
* Moves responsibility for showing profile error dialog out of Browsersky@chromium.org2011-04-142-21/+0
| | | | | | | | | | | | | and into a standalone function. This way we can show the error dialog if no browser is around (as can happen during startup). BUG=74639 TEST=none R=ben@chromium.org,avi@chromium.org,estade@chromium.org Review URL: http://codereview.chromium.org/6838031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81637 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-06-08 00:54:58 +0000