summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ui
Commit message (Collapse)AuthorAgeFilesLines
* Get rid of Image::Image(SkBitmap*)pkotwicz@chromium.org2012-05-144-23/+23
| | | | | | | | | | | Bug=124566 Test=Compiles on CrOS,Mac Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136812 Review URL: https://chromiumcodereview.appspot.com/10378009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136823 0039d316-1c4b-4281-b951-d872f2087c98
* app_list: Remove unneeded forward declaration from app_list_model.h.tfarina@chromium.org2012-05-142-6/+6
| | | | | | | | | | | And while I'm here rename GetItem to GetItemAt, as it's more consistent with the other names used in this class (AddItemAt, DeleteItemAt, etc.). R=xiyuan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10332135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136815 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 136812 - Get rid of Image::Image(SkBitmap*)pkotwicz@chromium.org2012-05-144-23/+23
| | | | | | | | | | | | Bug=124566 Test=Compiles on CrOS,Mac Review URL: https://chromiumcodereview.appspot.com/10378009 TBR=pkotwicz@chromium.org Review URL: https://chromiumcodereview.appspot.com/10383153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136813 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of Image::Image(SkBitmap*)pkotwicz@chromium.org2012-05-144-23/+23
| | | | | | | | | Bug=124566 Test=Compiles on CrOS,Mac Review URL: https://chromiumcodereview.appspot.com/10378009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136812 0039d316-1c4b-4281-b951-d872f2087c98
* browser: Extract ShowLoginWizard() function from browser_dialogs.htfarina@chromium.org2012-05-131-5/+0
| | | | | | | | | BUG=125846 R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10377120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136811 0039d316-1c4b-4281-b951-d872f2087c98
* extensions: Make use of simple_message_box functions in ExtensionsStartupUtil.tfarina@chromium.org2012-05-136-29/+59
| | | | | | | | | | This is a follow up to r133396. R=aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/10219013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136806 0039d316-1c4b-4281-b951-d872f2087c98
* views: Add a new ctor to MessageBoxView that takes only a InitParams.tfarina@chromium.org2012-05-137-31/+24
| | | | | | | | | | This simplifies many consumers of this API. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10378086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136804 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome/browser/simple_message_box.h to chrome/browser/ui.thestig@chromium.org2012-05-136-5/+35
| | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10384116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136798 0039d316-1c4b-4281-b951-d872f2087c98
* browser: Rename Browser::tabstrip_model to Browser::tab_strip_model.tfarina@chromium.org2012-05-1231-120/+120
| | | | | | | | | | | This was a TODO for me in browser.h R=ben@chromium.org TBR=thestig@chromium.org,sky@chromium.org,tim@chromium.org Review URL: https://chromiumcodereview.appspot.com/10388101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136769 0039d316-1c4b-4281-b951-d872f2087c98
* views: Have a more accurate name for View parent_owned accessors.tfarina@chromium.org2012-05-1210-24/+24
| | | | | | | | | | | | Remove the getter accessor of parent_owned() because it's used only internally by View. And change the setter accessor from set_parent_owned() to set_owned_by_client(). BUG=122384 R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10384068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136766 0039d316-1c4b-4281-b951-d872f2087c98
* Remove notification that isn't used any more after r88133.avi@chromium.org2012-05-123-22/+0
| | | | | | | | | | BUG=20569 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10384135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136757 0039d316-1c4b-4281-b951-d872f2087c98
* The link next to terminated extensions currently displays a (Cmd+R) on Macs ↵hebert.christopherj@chromium.org2012-05-121-2/+4
| | | | | | | | | | | | | | | | and a (Ctrl+R) on Linux/Windows. However, reloading the chrome://extensions only reloads unpacked extensions -- as expected. This patch adds a new IDS_EXTENSION_RELOAD_UNPACKED to the generated_resources.grd in order to differentiate between the "Reload" link for terminated extensions, and the "Reload (Ctrl+R)" link for unpacked extensions. BUG=127277 TEST=Terminate extension using task manager. Make adjustment to unpacked extension. (Cmd/Ctrl+R) to reload. Terminated extension should not reload, and unpacked extension should. Review URL: https://chromiumcodereview.appspot.com/10384087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136717 0039d316-1c4b-4281-b951-d872f2087c98
* Disable animation of omnibox popup.mukai@chromium.org2012-05-111-0/+3
| | | | | | | | | | | As is discussed in crbug.com/124104, omnibox popup should not have animation but appear immediately. BUG=124104 TEST=manually done Review URL: https://chromiumcodereview.appspot.com/10310111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136714 0039d316-1c4b-4281-b951-d872f2087c98
* Quote WebPreferences in namespace webkit_glue.wangxianzhu@chromium.org2012-05-113-2/+3
| | | | | | | | | | | | | | To avoid name conflict when linking DumpRenderTree which has its own implementation of the class with the same name. BUG=127811 TEST=Build all without errors TBR=kalman@chromium.org,dpapad@chromium.org,ben@chromium.org,battre@chromium.org Review URL: https://chromiumcodereview.appspot.com/10384128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136707 0039d316-1c4b-4281-b951-d872f2087c98
* fix extension page crashestade@chromium.org2012-05-112-16/+21
| | | | | | | | | | | | | | two fixes: 1. for certain callbacks, look up terminated extensions as well as active or disabled extensions. This fixes the crash, which occurs when flipping the incognito bit for a terminated extension. 2. change the UI so that "show button", "allow in incognito", "options", etc., do not show for terminated extensions, the same way they already do not show for disabled extensions. (this also fixes the crash by making it impossible to trigger) BUG=125393 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10392033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136693 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the include path to tab_strip_model.h due to merge conflict.tfarina@chromium.org2012-05-111-1/+1
| | | | | | | | | BUG=127798 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10332127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136674 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the include path to pinned_tab_codec.h due to merge conflict.tfarina@chromium.org2012-05-111-1/+1
| | | | | | | | | BUG=127798 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10332126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136672 0039d316-1c4b-4281-b951-d872f2087c98
* browser: Move the tabs directory into ui.tfarina@chromium.org2012-05-1184-87/+6698
| | | | | | | | | | BUG=127798 R=ben@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10332124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136669 0039d316-1c4b-4281-b951-d872f2087c98
* Extract StartupTabs and startup types from StartupBrowserCreator.ben@chromium.org2012-05-119-1039/+1140
| | | | | | | | | | BUG=none TEST=none TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136573 Review URL: https://chromiumcodereview.appspot.com/10384106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136658 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that the panel cannot be dragged or resized under any top-aligned ↵jianli@chromium.org2012-05-1121-113/+240
| | | | | | | | | | | | | | | menu or taskbar. This is platform-independent work that adds constraint logic to drag and resize controller. For Windows, we do not have problem for panel resizing since we rely on system resizing that does the correct thing. Also the MacOS specific fix for dragging issue is not longer needed. In addition, I addressed some more feedbacks from http://codereview.chromium.org/10356007/. BUG=122669 TEST=new tests Review URL: https://chromiumcodereview.appspot.com/10389048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136645 0039d316-1c4b-4281-b951-d872f2087c98
* Implement delegation to Metro file pickers.siggi@chromium.org2012-05-111-2/+18
| | | | | | | | | | | R=cpu@chromium.org,robertshield@chromium.org BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10310103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136624 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix unit_tests:FullscreenExitBubbleControllerTest.DenyExitsFullscreen ↵rsesek@chromium.org2012-05-112-8/+10
| | | | | | | | | | | | | | | on 10.7. This moves a call to WindowFullscreenStateChanged() from the command to enter fullscreen to the async callback when fullscreen is actually entered. BUG=103906 TEST=Test passes on Lion. Fullscreen works as before on 10.5-10.8. Review URL: https://chromiumcodereview.appspot.com/10356106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136617 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 136573 - Extract StartupTabs and startup types from ↵ben@chromium.org2012-05-119-1140/+1039
| | | | | | | | | | | | | | StartupBrowserCreator. BUG=none TEST=none TBR=sky Review URL: https://chromiumcodereview.appspot.com/10384106 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10332117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136582 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where you couldn't click on pinned tabs. This happened insky@chromium.org2012-05-111-10/+25
| | | | | | | | | | | | touch mode if the only tabs were pinned tabs. BUG=126510 TEST=see bug R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10386074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136574 0039d316-1c4b-4281-b951-d872f2087c98
* Extract StartupTabs and startup types from StartupBrowserCreator.ben@chromium.org2012-05-119-1039/+1140
| | | | | | | | | BUG=none TEST=none TBR=sky Review URL: https://chromiumcodereview.appspot.com/10384106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136573 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 136499 - Taking over issue 10006037.yusukes@google.com2012-05-112-10/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moved WebDataService to ProfileKeyedService James: chrome\browser\ui\intents Peter: chrome\browser\ui\search_engines chrome\browser\search_engines Nicolas: chrome\browser\sync Rachel/Elliot: chrome\browser\profiles and the whole cl BUG=112234 TEST=unit-tests TBR=jhawkins@chromium.org,pkasting@chromium.org,zea@chromium.org,erg@chromium.org,isherman@chromium.org Review URL: https://chromiumcodereview.appspot.com/10185008 Reason of the revert: The CL broke the following linux_chromeos browser_tests. EnterpriseLoginBlocksForEnterpriseUser_0 EnterpriseLoginBlocksForEnterpriseUser_1 EnterpriseLoginBlocksForEnterpriseUser_2 EnterpriseLoginBlocksForEnterpriseUser_3 EnterpriseLoginBlocksForEnterpriseUser_4 EnterpriseLoginBlocksForEnterpriseUser_5 EnterpriseLoginDoesntBlockForNormalUser NormalLoginDoesntBlock sample log: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/1071/steps/browser_tests/logs/stdio [14648:14648:0510/212507:358430278:FATAL:web_data_service.cc(96)] Check failed: BrowserThread::IsWellKnownThread(BrowserThread::DB). Backtrace: base::debug::StackTrace::StackTrace() [0x7ff2e9b74e76] logging::LogMessage::~LogMessage() [0x7ff2e9ba6627] WebDataService::WebDataService() [0x144d7a7] TBR=rlp@chromium.org Review URL: https://chromiumcodereview.appspot.com/10382123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136522 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLFetcherDelegate to net/ and split URLFetcher between net/ and content/akalin@chromium.org2012-05-114-9/+9
| | | | | | | | | | | | | | | | | | | | | Temporarily make a shim content::URLFetcherDelegate class. A future CL will replace all instances of content::URLFetcherDelegate with net::URLFetcherDelegate and remove that class. Move most URLFetcher methods to net::URLFetcher, except for the static methods (which will be handled in a future CL) and AssociateWithRenderView, which is content-specific. Replace all instances of content::URLFetcher* in the URLFetcherDelegate callbacks with net::URLFetcher* (except for rlz, which required its own special hack). BUG=118220 TEST= TBR=mnissler@chromium.org,jhawkins@chromium.org,cpu@chromium.org,estade@chromium.org,sky@chromium.org,joth@chromium.org,satish@chromium.org Review URL: https://chromiumcodereview.appspot.com/10386063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136514 0039d316-1c4b-4281-b951-d872f2087c98
* Taking over issue 10006037.rlp@chromium.org2012-05-112-6/+10
| | | | | | | | | | | | | | | | | | | | | | | Moved WebDataService to ProfileKeyedService James: chrome\browser\ui\intents Peter: chrome\browser\ui\search_engines chrome\browser\search_engines Nicolas: chrome\browser\sync Rachel/Elliot: chrome\browser\profiles and the whole cl BUG=112234 TEST=unit-tests TBR=jhawkins@chromium.org,pkasting@chromium.org,zea@chromium.org,erg@chromium.org,isherman@chromium.org Review URL: https://chromiumcodereview.appspot.com/10185008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136499 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 136414 - Fixes taking a screenshot of a page in high DPIpkotwicz@chromium.org2012-05-111-5/+5
| | | | | | | | | | | | | | | | Also tagged read_pixel_bounds with _in_pixel to make it more clear what coordinate system it is in. BUG=127550 TEST=Manual Review URL: https://chromiumcodereview.appspot.com/10381093 TBR=pkotwicz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136416 Review URL: https://chromiumcodereview.appspot.com/10332102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136495 0039d316-1c4b-4281-b951-d872f2087c98
* Move OOMPriorityManager and LowMemoryObserver to chrome/browser/chromeos/.thestig@chromium.org2012-05-111-2/+3
| | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10384098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136485 0039d316-1c4b-4281-b951-d872f2087c98
* Web Intents: Fix explicit intents crash for the Views implementation.gauravsh@chromium.org2012-05-112-1/+19
| | | | | | | | | | | | | | | The picker model doesn't get populated with the installed service in the explicit intents code path. Fix that by populating the picker model with the installed services while enumerating services available for explicit intents. BUG=chromium:127454 TEST=trigger explicit intent, ensure no crash happens. Review URL: https://chromiumcodereview.appspot.com/10384093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136484 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetImageSkiaNamed to resource_bundle and theme_provider.pkotwicz@chromium.org2012-05-116-2/+18
| | | | | | | | | | | This makes converting use of SkBitmap into ImageSkia easier Bug=124566 Test=Manual Review URL: https://chromiumcodereview.appspot.com/10388064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136470 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Fix user whiltelist not properly populated regression.xiyuan@chromium.org2012-05-111-8/+23
| | | | | | | | | | | | | | This happens because the whitelist pref value is stored in policy and policy set on device is asynchronous. Before previous policy write comes back, pref value cache is stale and should not be used as a basis for further mutating (as what happens when we AppendToList while there is a previously queued AppendToList). BUG=127215 TEST=Verify fix for issue 127215. Review URL: https://chromiumcodereview.appspot.com/10332094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136466 0039d316-1c4b-4281-b951-d872f2087c98
* mac: Send X-Rlz-String header.thakis@chromium.org2012-05-111-5/+3
| | | | | | | | | | BUG=none TEST=X-Rlz-String header is sent on official builds when homepage changes to google. Review URL: https://chromiumcodereview.appspot.com/10392035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136453 0039d316-1c4b-4281-b951-d872f2087c98
* Fix maximized window header height for --touch-optimized-uijamescook@chromium.org2012-05-101-10/+29
| | | | | | | | | | | | | The touch layout needs space for full-sized close and sizing buttons, so we shouldn't cram the tabstrip to the top of the screen. Also switched metric-lookup functions to hacker_style(). BUG=127426 TEST=visual, maximized window has enough space for full size close button when running with --touch-optimized-ui Review URL: https://chromiumcodereview.appspot.com/10383119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136442 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring AutocompleteActionPredictor Database.shishir@chromium.org2012-05-107-82/+75
| | | | | | | | | | BUG= TEST=Same as before Review URL: https://chromiumcodereview.appspot.com/10380041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136439 0039d316-1c4b-4281-b951-d872f2087c98
* Change GPUInfo to handle multiple GPUs.zmo@chromium.org2012-05-101-2/+2
| | | | | | | | | | | | | | | | | | At the moment we always select one GPU as primary and the others as secondary. In preliminary GPU info collection (without creating a GL context and collect GL VENDOR/RENDERER strings), we actually don't know which GPU is in use. The current logic is that if one GPU is Intel, we assume the other is primary. I agree a better logic is needed. However, at the moment, logging/crash reports all requires ONE GPU vendor_id/device_id, so even though we don't know which GPU is active, we still need to randomly select one. This needs more thinking and design, so I think it's reasonable to leave it to a possible future CL. Also, the logic on collecting GPU info through libpci is changed to collect multiple GPUs. If one is Intel and one is NVIDIA, we assume it's optimus and we disable GPU features. This logic is hardwired in Chrome in this CL. The plan is to push the logic to blacklist, but I'll leave it to a seperate CL. BUG=126307,75220 TEST=about:gpu page on a Linux system with optimus GPU R=kbr TBR=jam Review URL: https://chromiumcodereview.appspot.com/10389051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136429 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 136414 - Fixes taking a screenshot of a page in high DPIpkotwicz@chromium.org2012-05-101-6/+6
| | | | | | | | | | | | | | Also tagged read_pixel_bounds with _in_pixel to make it more clear what coordinate system it is in. BUG=127550 TEST=Manual Review URL: https://chromiumcodereview.appspot.com/10381093 TBR=pkotwicz@chromium.org Review URL: https://chromiumcodereview.appspot.com/10332102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136416 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes taking a screenshot of a page in high DPIpkotwicz@chromium.org2012-05-101-6/+6
| | | | | | | | | | | Also tagged read_pixel_bounds with _in_pixel to make it more clear what coordinate system it is in. BUG=127550 TEST=Manual Review URL: https://chromiumcodereview.appspot.com/10381093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136414 0039d316-1c4b-4281-b951-d872f2087c98
* Converts a CHECK back into a DCHECK.sky@chromium.org2012-05-101-3/+1
| | | | | | | | | | BUG=124465 TEST=none R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10378094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136405 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a bug in touch tabstrip that could result in gaps in thesky@chromium.org2012-05-103-20/+29
| | | | | | | | | | | | tabstrip. This would happen when shrinking the window or removing a tab before the active tab. BUG=123274 TEST=covered by tests. Review URL: https://chromiumcodereview.appspot.com/10392028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136404 0039d316-1c4b-4281-b951-d872f2087c98
* views: Refactor the way we register BrowserActionsContainer prefs.tfarina@chromium.org2012-05-102-11/+17
| | | | | | | | | | | This is similar to the way cocoa does. BUG=125846 R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10387047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136394 0039d316-1c4b-4281-b951-d872f2087c98
* Rename and document Browser::GetTabbedBrowser()'smmenke@chromium.org2012-05-104-16/+31
| | | | | | | | | | | | | | |match_incognito| parameter, and do the same for the corresponding BrowserList functions. Also fix incorrect comment for BrowserList::FindTabbedBrowser. R=sky@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10384090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136392 0039d316-1c4b-4281-b951-d872f2087c98
* Use proper webstore link for suggested intent handlers.groby@chromium.org2012-05-101-2/+4
| | | | | | | | | | | R=jhawkins@chromium.org BUG=119413 TEST=none Review URL: https://chromiumcodereview.appspot.com/10389056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136388 0039d316-1c4b-4281-b951-d872f2087c98
* Change name of location_entry accessor in LocationBar to GetLocationEntry to ↵dominich@chromium.org2012-05-1024-47/+44
| | | | | | | | | | | | match accepted style. BUG=NONE TEST=NONE Review URL: https://chromiumcodereview.appspot.com/10387044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136386 0039d316-1c4b-4281-b951-d872f2087c98
* Remove prerender hover experiment supportdominich@chromium.org2012-05-102-16/+0
| | | | | | | | | BUG=111130 Review URL: https://chromiumcodereview.appspot.com/10256009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136376 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix deadcode.jhawkins@chromium.org2012-05-101-1/+1
| | | | | | | | | | | | | | | |link_color| cannot be NULL at this point. CID_COUNT=1 CID=103948 BUG=none TEST=none R=groby TBR=erg Review URL: https://chromiumcodereview.appspot.com/10377074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136372 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Document a previously-implied assertion.jhawkins@chromium.org2012-05-101-0/+5
| | | | | | | | | | | | | CID_COUNT=1 CID=103962 BUG=none TEST=none R=groby TBR=erg Review URL: https://chromiumcodereview.appspot.com/10389052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136367 0039d316-1c4b-4281-b951-d872f2087c98
* Rename BrowserInit to StartupBrowserCreator, and move into startup subdir.ben@chromium.org2012-05-109-170/+203
| | | | | | | | | | BUG=none TEST=none TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136337 Review URL: https://chromiumcodereview.appspot.com/10356100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136366 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes drag and drop crash. The problem was when I madesky@chromium.org2012-05-101-39/+43
| | | | | | | | | | | | | | | | | | | | MenuController::SetExitType do a QuitNow it would prematurely exit out of drag and drop, causing a crash. The fix is to not QuitNow if drag and drop is on going. (Have I mentioned I hate nested message loops?). I also changed DragDropController to QuitNow, this way tests can work and seems like what we want anyway. Lastly I made all the bookmarkbarviewtests work again as they provide coverage of this. BUG=127348 TEST=covered by tests R=ben@chromium.org,varunjain@chromium.org Review URL: https://chromiumcodereview.appspot.com/10388056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136365 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-06-07 04:39:29 +0000