| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/5471002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
process before they get clobbered by browser_shutdown leading to a potential double-close.
BUG=58053
TEST=exit chrome with notifications open
Review URL: http://codereview.chromium.org/5319011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert previous traces and add one targeted test.
My traces seem to indicate that something else
than a Chrome window has focus when the test fails.
Lets figure out what that is...
BUG=62937
TEST=Tracking down problem in test
Review URL: http://codereview.chromium.org/5463001
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/5451002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert previous traces and add one targeted test.
My traces seem to indicate that something else
than a Chrome window has focus when the test fails.
Lets figure out what that is...
BUG=62937
TEST=Tracking down problem in test
Review URL: http://codereview.chromium.org/5463001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Listen for extension install events and restart the Enterprise Daemon if an extension was installed, that is from a policy and it contains the policy marker file.
BUG=chromeos:9702
TEST=manual
Review URL: http://codereview.chromium.org/5311007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The installer now does its work based on distributions and target installation paths.
Each distribution has exactly one target installation path but each installation path can have more than one distribution.
In the absense of the --multi-install switch, the installer should continue to work as before.
The biggest difference here is that we don't rely on a single global distribution object that controls the entire installation flow and we have a few classes for the new abstractions instead of global functions.
It's far from perfect, but it's a step towards separating the core file package required for all distributions from the distributions themselves.
Additionally, there are tons of little changes here such as consistant usage of FilePath and CommandLine instead of mixing them with std::wstring.
TEST=Install, uninstall, upgrade, etc. Everything install related.
BUG=61609
Review URL: http://codereview.chromium.org/5172011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Reset the source-page of the navigation if the new page is going to use a different profile than the originating page (e.g. a link on a non-OTR page opening a page in the OTR window)
BUG=63172
TEST=manual, see bug.
Review URL: http://codereview.chromium.org/5396002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For official Windows builds only, remove the flag and turn on the cloud print
proxy setup UI.
BUG=60092
TEST=On an official Windows build, cloud print gone from about:flags, present in both tabbed and untabbed options (under the hood).
Review URL: http://codereview.chromium.org/5409001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=compiled locally, trybots
Review URL: http://codereview.chromium.org/5384002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63382
TEST=None
Review URL: http://codereview.chromium.org/5177009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WasSized method. (I previously hadn't realized there was any scenario
in touch where the content could be resized.)
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/5291007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/chromium-os/issues/detail?id=9625
TEST=manual
Review URL: http://codereview.chromium.org/5359008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=agl
BUG=53659
TEST=none
Review URL: http://codereview.chromium.org/4091005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64660
TEST=build succeeds (no effective code change)
Review URL: http://codereview.chromium.org/5367006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=60646
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/5262009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52451
TEST=Manually create app shortcuts for urls and apps.
Review URL: http://codereview.chromium.org/5273004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
three variants in though as I'm going to add to about:flags the
ability to choose between them.
Because of the time I'm doing the minimal set of changes for Mac and TBRing this. Rohit, could you clean it up when you have a chance?
BUG=none
TEST=none
TBR=estade@chromium.org, rohitra@chromium.org
Review URL: http://codereview.chromium.org/5373006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
1. new sets of strings indicating animation in chrome/browser/content_setting_image_model.cc - non-NULL id indicated that the situation is animated.
2. TabSpecificContentSettings has indicator that the new blockage occured, and was/was not messaged to the user.
3. ContentSettingImageView on Windows/ChromeOs is descended from LinearAnimation to allow animation of the popup indicator to the user.
BUG=39260
TEST=Mocks
Review URL: http://codereview.chromium.org/3120034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was two pixels to far to the left.
TBR=glen
BUG=51105
TEST=None
Review URL: http://codereview.chromium.org/5348005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
open and bug fix for when feedback tab is closed without hitting cancel
(hitting cancel, cancels any pending system information requests, which was
being skipped when the cancel button wasn't hit and the tab was directly closed)
When Navigate is called for a Singleton tabs, regardless of whether or not the
tab is already open, by default navigate creates tab_contents for the URL and
then checks if the URL is already open on another tab - this can causes issues
with DOM UI pages which expect to be open only at one time on one browser; in
this case, the feedback DOM UI.
BUG=chromium-os:8857
TEST=Ran multiple browsers and clicked on the feedback button while the feedback
page was open - from the feedback page itself, and from other pages. Correct
behavior was observed; we switched to the feedback page and no crashes.
Review URL: http://codereview.chromium.org/4921001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Grab task manager context menu strings from resources, not from TableColumn
structure, because some columns in the table may not have a header title but
we still need an identifier in the context menu.
BUG=64241
TEST=Bring up context menu, see no blank items
Review URL: http://codereview.chromium.org/5303010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37891
TEST=trybots
Review URL: http://codereview.chromium.org/5249001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 89f4de523e9c916950f72c264cdefed662849124.
TBR=aa@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Callers can use this optional argument to allow for popups larger than than the default 800x600 size.
Note that the implementation makes minimal changes to the existing popup code, and relies on use of the ExtensionPopupObserver to install the max size settings.
TEST=ExtensionApiTest.Popup
BUG=none
Review URL: http://codereview.chromium.org/5254007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before creating a new kind of TabStrip, I'm first cleaning up the BaseTabStrip class to remove two unused methods: SetDraggedTabBounds, and AsTabStrip.
AsTabStrip was particularly unwanted because the base class was referencing the derived class.
Furthermore, as an additional cleanup effort, I observe that there is no original caller to TabStripModelDelegate::ContinueDraggingDetachedTab(...)
Therefore:
TabStripModelDelegate::ContinueDraggingDetachedTab(...) REMOVED
DefaultTabHandler::ContinueDraggingDetachedTab(...) REMOVED
...which leaves no callers of Browser::ContinueDraggingDetachedTab(...)
Therefore:
Browser::ContinueDraggingDetachedTab(...) REMOVED
...which leaves no callers of BrowserWindow::ContinueDraggingDetachedTab(bounds)
Therefore:
BrowserWindow::ContinueDraggingDetachedTab(bounds) REMOVED
BrowserView::ContinueDraggingDetachedTab(bounds) REMOVED
...which leaves no callers of BrowserFrame::ContinueDraggingDetachedTab()
Therefore:
BrowserFrame::ContinueDraggingDetachedTab() REMOVED
BrowserFrameGtk::ContinueDraggingDetachedTab() REMOVED
BrowserFrameWin::ContinueDraggingDetachedTab() REMOVED
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5253001
Patch from Chad Faragher <wyck@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38475
TEST=Tested using a page that does this for both the Chromium and Google Chrome switch from a known provider to unknown and from an unknown provider.
Review URL: http://codereview.chromium.org/5313005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
animation. This would happen when typing a character and we already
have the suggested text. In particular we would cancel the animation
because the selection changed, and never restart it because of the
early return when the suggested text matched current suggested text.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5316006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. If there is suggested text it is committed.
. If there is no suggested text, but instant is active instant is
committed.
BUG=64340
TEST=see bug
Review URL: http://codereview.chromium.org/5328005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome process and run tests on it. This is an addition to the low level interface underlying testing frameworks like PyAuto and WebDriver.
Normally, test frameworks communicate with Chrome over an unnamed socket pair on POSIX. The test creates the socket pair and then launches the browser as a child process, passing an open file descriptor for one end of the socket to the browser. This change adds a command line switch that, when passed to the browser, causes it to listen on a named socket instead, eliminating this parent/child process requirement. Therefore, you can potentially connect any number of tests to a preexisting browser process.
For ChromeOS, this allows you to run tests on the instance of Chrome that is launched on startup, which controls things like the login and lock screens, the battery meter, the wireless UI, etc. Currently there is no way to run tests on a pre-existing Chrome instance. Eventually this will also allow you to connect both PyAuto and WebDriver to the same Chrome instance and run both in the same test.
If you pass the browser the following command line switch:
./chrome --testing-channel=NamedTestingInterface:/path/to/file
This causes the browser to listen for incoming connections. An AutomationProxy can connect to the browser by connecting a Unix domain socket to the specified path and control the browser over the socket.
This is currently only for POSIX. Windows support will come in a future change. Also, this initial change only allows one connection; multiple connection support will come in a future change.
BUG=chromium-os:8512
TEST=Run Chrome with --testing-interface=/var/tmp/NamedTestingInterface, then run NamedInterfaceTest.BasicNamedInterface under ui_tests.
Review URL: http://codereview.chromium.org/4202004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
effort to eliminate GTK for TOUCH_UI.
BUG=none
TEST=manually tested
Review URL: http://codereview.chromium.org/4319003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As it happens, the command-id is a TabStripModel::ContextMenuCommand. So it
needs to be converted into a browser command first, before the accelerator is
looked up.
BUG=None
TEST=Right click on a tab. The context menu should have proper accelerators
displayed (e.g. Ctrl+T for the 'New Tab' option).
Review URL: http://codereview.chromium.org/5331005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It flakily times out on Winows trybot.
TBR=sky
BUG=64303
TEST=interactive_ui_tests
Review URL: http://codereview.chromium.org/5369004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As described in the bug, the current behavior is confusing and bug-prone.
BUG=47194
TEST=Check that there are no visible regressions in RTL and LTR language UIs on Linux & Windows.
Review URL: http://codereview.chromium.org/5154009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
provider and nothing else.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5270001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64267
TEST=Existing tests suffice.
Review URL: http://codereview.chromium.org/5361003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit c0ddb28cf383462655b52aa79396ea695c0ffb3c.
TBR=aa@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is a UI issue (noted in the code) that I need to figure
out before I can turn it on by default.
BUG=49233
TEST=n/a
Review URL: http://codereview.chromium.org/4995001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/5286005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create and process touch-events. The touch-events are created from
pointer-events. The way to decide whether a 'pointer event' originated from a
touch-device is not yet well-defined. So for now, use the --touch-devices
command line parameter to specify which pointer devices should be treated as
touch-device. For example, you can run:
./out/Debug/chrome --touch-devices=7,8
to treat the events coming in from devices with id 7 and 8 as touch events.
(these are the slave ids you get from 'xinput list')
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4738001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add badge_util::DrawBadgeIconOverlay() which draws a dynamic text overlay over
a badge icon.
Add Windows support for rendering a dynamic icon showing the # background pages
to the wrench menu.
BUG=64144
TEST=Enable background page, look at wrench menu
Review URL: http://codereview.chromium.org/5299001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Returns icon of the incognito guy to the tab header.
2. Sets NTP as homepage for the guest mode.
3. Adds the missing separator between the options.
BUG=chromium-os:9534
TEST=manual
Review URL: http://codereview.chromium.org/5314002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a timeout in the test.
BUG=62937
TEST=Enabling a test to find where it times out.
Review URL: http://codereview.chromium.org/5297003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I suspect the problem is that the test is just a bit too long for the
timeout value we use.
BUG=38992
TEST=The CL enables a test.
Review URL: http://codereview.chromium.org/5239003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add API to WebCursor to return a native-cursor, and implementation for windows,
linux and mac.
For linux: Move gtk_util::GetCursor into gfx:: namespace. Also, get rid of
ref/unref'ing the cursors from everywhere. Instead, do almost all of it in one
place (in gfx). Also, show proper cursors for web-pages with touchui=1 (i.e. add
support for updating cursor in RenderWidgetHostViewViews).
Review URL: http://codereview.chromium.org/5110010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Side effect: Changed all instances of IDC_REPORT_BUG to IDC_FEEDBACK to correctly indicate the message
BUG=chromium-os:5361
TEST=Verified visually that the status bar icon is gone and the toolbar icon
is there; tested the toolbar icon to verify functionality.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65582
Review URL: http://codereview.chromium.org/4546002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NetworkStateNotifier's constructor is supposed to be called by UI thread,
but because we launch browser before initializing NetworkStateNotifier,
in rare occasion, page load (which is IO thread) can access NetworkStateNotifier
before UI thread initializes the object
This change moves initialization code before launching browser to make sure
Constructor is called by UI thread.
BUG=chromium-os:9370
TEST=see bug for repo steps
Review URL: http://codereview.chromium.org/5163007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:8658
TEST=Manual.
Review URL: http://codereview.chromium.org/5180002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added BackgroundPageTracker which tracks which extensions/apps contain
background pages.
Added code to wrench menu/toolbar to display a badge when there is a new
background page added to the system.
BUG=59980
TEST=BackgroundPageTrackerTest
Review URL: http://codereview.chromium.org/5207002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23581
Review URL: http://codereview.chromium.org/5158006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66973 0039d316-1c4b-4281-b951-d872f2087c98
|