summaryrefslogtreecommitdiffstats
path: root/chrome/browser/unload_uitest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Migrate Event API methods to Google Style.ben@chromium.org2011-02-101-3/+3
| | | | | | | | | | | | | | Re-landing, moving the bits Mac uses to ui/base/events.h BUG=72040 TEST=none TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74377 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74408 0039d316-1c4b-4281-b951-d872f2087c98
* Move Event files into views/eventsben@chromium.org2011-02-091-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=sky Review URL: http://codereview.chromium.org/6459024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74305 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74118 - Remove wstring from RVH's run Javascript command.avi@chromium.org2011-02-081-4/+4
| | | | | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6312154 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6459002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74158 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from RVH's run Javascript command.avi@chromium.org2011-02-081-4/+4
| | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6312154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74118 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up net unit testing code.erg@google.com2011-01-261-1/+1
| | | | | | | | | | | | | | | | | | | | (Reapply r72562 with willchan's nits + locally tested shlib fixes + removing duplicate code that was partially responsible for the failure.) - Move code included from blah_unittest.h (where blah_unittest.cc has actual unittests) into their own files, often completely out-of-lining the definitions. - Remove anonymous namespaces from headers. - Reorder method declarations. - Make other unit test link against net_test_support instead of reaching in and including .h files in their targets directly. BUG=68682 TEST=compiles First Review URL: http://codereview.chromium.org/6264013 Review URL: http://codereview.chromium.org/6248021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72682 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Clean up net unit testing code." since it breaks the shlib builder.erg@google.com2011-01-251-1/+1
| | | | | | | | | | This reverts commit 006f377bbb65ece3490b7c76e58e0dc4cb330909 (r72562). BUG=68682 TEST=compiles TBR=thomasvl git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72564 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up net unit testing code.erg@google.com2011-01-251-1/+1
| | | | | | | | | | | | | | | | | - Move code included from blah_unittest.h (where blah_unittest.cc has actual unittests) into their own files, often completely out-of-lining the definitions. - Remove anonymous namespaces from headers. - Reorder method declarations. - Make other unit test link against net_test_support instead of reaching in and including .h files in their targets directly. BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6264013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72562 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of random other files to src/ui/baseben@chromium.org2011-01-201-7/+7
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6257006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71970 0039d316-1c4b-4281-b951-d872f2087c98
* Remove action_max_timeout_ms and fix all the callers.tfarina@chromium.org2011-01-191-3/+4
| | | | | | | | | | | (This was a TODO for phajdan.jr). BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6354005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71861 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/platform_thread.h stub and fix up all callers to use the new ↵brettw@google.com2011-01-011-1/+0
| | | | | | | | | location and namespace. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70346 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-021-1/+1
| | | | | | | | | | | | | | | | | | | | tab_menu_model->ui/tabs tab_contents_wrapper->ui/tab_contents view_ids.h->ui status_bubble.h->ui options*->ui/options show_options_url*->ui/options location_bar*->ui/omnibox input_window*->ui browser_uitests->ui/tests BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5582002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68047 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bunch of missing bug references to FLAKY testsstuartmorgan@chromium.org2010-10-271-2/+3
| | | | | | | | | BUG=None TEST=N/A Review URL: http://codereview.chromium.org/4135007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64150 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling UnloadTest.CrossSiteInfiniteUnloadAsyncInputEvent on Mac/Windows,creis@google.com2010-10-201-5/+16
| | | | | | | | | | | where it consistently (and slowly) fails. BUG=38427 TEST=UnloadTest.CrossSiteInfiniteUnloadAsyncInputEvent Review URL: http://codereview.chromium.org/3931003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63183 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Re-enable UnloadTest and ProcessSingletonTest now that shared library ↵mattm@chromium.org2010-10-061-16/+9
| | | | | | | | | | | | | build is fixed. (https://bugs.webkit.org/show_bug.cgi?id=46762) TEST=try bots, local shlib build BUG=47575,47979 Review URL: http://codereview.chromium.org/3624002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61598 0039d316-1c4b-4281-b951-d872f2087c98
* DISABLE UnloadTest.BrowserCloseTabWhenOtherTabHasListener on windowscmasone@google.com2010-09-171-1/+1
| | | | | | | | | | | | Per discussion with maruel and phajdan.jr, re-marking this test as DISABLED on windows. It sometimes crashes, causing the remaining tests to be marked as failing. TBR=estade BUG=45281 TEST=UnloadTest.BrowserCloseTabWhenOtherTabHasListener doesn't run Review URL: http://codereview.chromium.org/3421016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59815 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Make WaitForTabCountToBecome automation call not Sleep.phajdan.jr@chromium.org2010-09-071-2/+2
| | | | | | | | | | | | Sleeping is an unreliable method to wait for things. Instead, we set up an observer. BUG=none TEST=none Review URL: http://codereview.chromium.org/3300011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58731 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58563 - GTTF: Make WaitForTabCountToBecome automation call not Sleep.gavinp@chromium.org2010-09-041-2/+2
| | | | | | | | | | | | | | | | | (unfortunately, Mac & Windows started failing tab perf tests on this change) Sleeping is an unreliable method to wait for things. Instead, we set up an observer. BUG=none TEST=none Review URL: http://codereview.chromium.org/3300011 TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3344009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58566 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Make WaitForTabCountToBecome automation call not Sleep.phajdan.jr@chromium.org2010-09-031-2/+2
| | | | | | | | | | | | Sleeping is an unreliable method to wait for things. Instead, we set up an observer. BUG=none TEST=none Review URL: http://codereview.chromium.org/3300011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58563 0039d316-1c4b-4281-b951-d872f2087c98
* Mark test UnloadTest.BrowserCloseUnload as flaky.mirandac@chromium.org2010-08-101-1/+2
| | | | | | | | | BUG=51698 TEST=none Review URL: http://codereview.chromium.org/3107004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55583 0039d316-1c4b-4281-b951-d872f2087c98
* TTF: Re-enable UnloadTest.BrowserCloseTabWhenOtherTabHasListener on Win byjhawkins@chromium.org2010-07-131-1/+1
| | | | | | | | | | | | marking it as FAILS_. TBR=estade BUG=45281 TEST=UnloadTest.BrowserCloseTabWhenOtherTabHasListener Review URL: http://codereview.chromium.org/2979004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52222 0039d316-1c4b-4281-b951-d872f2087c98
* Disable all UnloadTest tests using LoadUrlAndQuitBrowser on Linuxstuartmorgan@chromium.org2010-06-291-18/+11
| | | | | | | | | | | TBR=erikkay BUG=47575 TEST=Greener bot Review URL: http://codereview.chromium.org/2822037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51151 0039d316-1c4b-4281-b951-d872f2087c98
* Disable another crashing unload test on Linuxstuartmorgan@chromium.org2010-06-291-1/+5
| | | | | | | | | | | TBR=erikkay BUG=47575 TEST=Greener bots Review URL: http://codereview.chromium.org/2887001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51136 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BrowserCloseUnload on Linuxstuartmorgan@chromium.org2010-06-291-1/+3
| | | | | | | | | | | TBR=sky BUG=47575 TEST=Green dbg-shlib Linux bot Review URL: http://codereview.chromium.org/2827035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51127 0039d316-1c4b-4281-b951-d872f2087c98
* Disables BrowserCloseNoUnloadListeners as it is crashing.sky@chromium.org2010-06-281-1/+2
| | | | | | | | | | BUG=47575 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/2853016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50978 0039d316-1c4b-4281-b951-d872f2087c98
* Marks BrowserCloseNoUnloadListeners flaky.sky@chromium.org2010-06-251-1/+8
| | | | | | | | | | BUG=47575 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/2825024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50898 0039d316-1c4b-4281-b951-d872f2087c98
* TTF: Re-enable tests that rely on ClickModalDialogButton since it is nowcsilv@chromium.org2010-06-161-27/+11
| | | | | | | | | | supported on Mac. BUG=45031 TEST=none Review URL: http://codereview.chromium.org/2812003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49969 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the MAYBE_ prefixes for UnloadTest.* on Windowsglider@chromium.org2010-06-111-0/+5
| | | | | | Review URL: http://codereview.chromium.org/2745015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49529 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the MAYBE_ prefix from MAYBE_BrowserCloseBeforeUnloadOK andglider@chromium.org2010-06-111-0/+2
| | | | | | | | | | MAYBE_BrowserCloseBeforeUnloadCancel on Linux. TBR=jhawkins Review URL: http://codereview.chromium.org/2781013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49512 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a test as flaky on linux because it fails sometimes on valgrind.estade@chromium.org2010-06-021-6/+11
| | | | | | | | | | BUG=32615,45675 TEST=tree greener TBR=creis Review URL: http://codereview.chromium.org/2450006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48759 0039d316-1c4b-4281-b951-d872f2087c98
* Mark BrowserCloseTabWhenOtherTabHasListener as flaky on Linux.estade@chromium.org2010-06-011-1/+2
| | | | | | | | | | BUG=45562 TEST=tree green TBR=jshin Review URL: http://codereview.chromium.org/2449007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48673 0039d316-1c4b-4281-b951-d872f2087c98
* Only disable UnloadTest.BrowserCloseTabWhenOtherTabHasListener under valgrindestade@chromium.org2010-06-011-3/+1
| | | | | | | | | | | (leave it enabled on non-valgrind Linux) BUG=45562 TEST=green tree Review URL: http://codereview.chromium.org/2428002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48649 0039d316-1c4b-4281-b951-d872f2087c98
* Disable UnloadTest.BrowserCloseTabWhenOtherTabHasListenerjrg@chromium.org2010-06-011-1/+3
| | | | | | | | | | | | | Makes Linux valgrind unhappy http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20(valgrind)(4)/builds/5866/steps/valgrind%20test:%20ui/logs/stdio BUG=http://crbug.com/45562 TBR=jungshik@chromium.org Review URL: http://codereview.chromium.org/2417003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48646 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: Fix OS_WINDOWS to OS_WIN.estade@chromium.org2010-05-281-1/+1
| | | | | | The bad macro caused the test to be wrongly enabled on windows. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48454 0039d316-1c4b-4281-b951-d872f2087c98
* Retry r48417.estade@chromium.org2010-05-271-26/+35
| | | | | | | | | | | Disable UnloadTest.BrowserCloseTabWhenOtherTabHasListener on windows because it is failing. BUG=45281 TEST=tree is green Review URL: http://codereview.chromium.org/2279006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48442 0039d316-1c4b-4281-b951-d872f2087c98
* Inform the command updater of the tab restore state.estade@chromium.org2010-05-271-3/+3
| | | | | | | | | BUG=14428 TEST=TabRestoreUITest.* Review URL: http://codereview.chromium.org/2228004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48437 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 48417 - More test enabling.jrg@chromium.org2010-05-271-31/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | RedirectTest.ClientServerServer passes locally so I'm trying reenabling it. file a bug for RedirectTest.ClientCancelledByNewNavigationAfterProvisionalLoad . file a bug for SessionHistoryTest.CrossFrameFormBackForward mark SessionHistoryTest.LocationReplace as failing rather than disabled fix UnloadTest.BrowserCloseTabWhenOtherTabHasListener (the popup was being caught by the popup blocker) TEST=buildbots BUG=12913 Review URL: http://codereview.chromium.org/2264001 TBR=estade@chromium.org Looks like UnloadTest.BrowserCloseTabWhenOtherTabHasListener still unhappy on bot? http://buildbot.jail.google.com/buildbot/chromium/builders/XP%20Tests/builds/20319/steps/ui_tests/logs/stdio [----------] Global test environment tear-down [==========] 315 tests from 72 test cases ran. (1089094 ms total) [ PASSED ] 308 tests. [ FAILED ] 7 tests, listed below: [ FAILED ] MouseLeaveTest.FLAKY_TestOnMouseOut [ FAILED ] HistoryTester.FAILS_VerifyHistoryLength2 [ FAILED ] HistoryTester.FAILS_VerifyHistoryLength3 [ FAILED ] WorkerTest.FLAKY_WorkerHttpLayoutTests [ FAILED ] UnloadTest.BrowserCloseTabWhenOtherTabHasListener [ FAILED ] SessionHistoryTest.FAILS_LocationReplace [ FAILED ] SessionHistoryTest.FLAKY_HistorySearchXSS Review URL: http://codereview.chromium.org/2225009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48433 0039d316-1c4b-4281-b951-d872f2087c98
* More test enabling.estade@chromium.org2010-05-271-26/+31
| | | | | | | | | | | | | | | - RedirectTest.ClientServerServer passes locally so I'm trying re-enabling it. - file a bug for RedirectTest.ClientCancelledByNewNavigationAfterProvisionalLoad . - file a bug for SessionHistoryTest.CrossFrameFormBackForward - mark SessionHistoryTest.LocationReplace as failing rather than disabled - fix UnloadTest.BrowserCloseTabWhenOtherTabHasListener (the popup was being caught by the popup blocker) TEST=buildbots BUG=12913 Review URL: http://codereview.chromium.org/2264001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48417 0039d316-1c4b-4281-b951-d872f2087c98
* Enable passing unload tests on Linux.estade@chromium.org2010-05-271-22/+13
| | | | | | | | | | | Also make one execute significantly faster. BUG=45021 TEST=they pass consistently Review URL: http://codereview.chromium.org/2296001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48415 0039d316-1c4b-4281-b951-d872f2087c98
* Build unload_uitest.cc on the Mac, with a few of the tests disabledstuartmorgan@chromium.org2010-05-251-4/+14
| | | | | | | | | | | | | Enables all the unload UI tests on the Mac that don't put up modal dialogs. Disables those that do, and adds a tracking bug for them. Also switches the hanging Linux test to DISABLED instead of not being compiled. BUG=45021,45031 TEST=More tests run Review URL: http://codereview.chromium.org/2202001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48210 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Miscellanous UI tests cleanups:phajdan.jr@chromium.org2010-03-301-2/+2
| | | | | | | | | | | | | | | - use built-in timeouts instead of "inventing" them in each test case - avoid unneeded checks and operations - use automation calls more effectively - use FLAKY mark instead of DISABLED to maintain test coverage - split some tests to make the above possible TEST=UI test based BUG=39785 Review URL: http://codereview.chromium.org/1547003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43070 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the CrossSiteInfiniteBeforeUnloadAsync test as flaky as it fails ↵ananta@chromium.org2010-03-261-1/+2
| | | | | | | | | | | | | | | | randomly on the valgrind Linux builder. It appears that this was already marked flaky in revision 42358. I synced to head and still can't get that change. Bug=39057 TBR=amit Review URL: http://codereview.chromium.org/1468002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42826 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a test which has been failing regularly on the valgrind UI bot as FLAKY_.eroman@chromium.org2010-03-231-1/+3
| | | | | | | | BUG=39057 Review URL: http://codereview.chromium.org/1074010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42358 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce number of automation methods ending with WithTimeout.phajdan.jr@chromium.org2010-03-221-1/+1
| | | | | | | | | | | | | | | | | | | | | They are just too easy to misuse. People started inventing their own hardcoded timeouts all over the place. Also, the is_timeout return parameter was not checked consistently. Additionally, some calls actually had no timeout at all, making hangs possible. This change also removes useless DLOG statements. We should get the required info from the ASSERT/EXPECT macros in test code, which is quite well checked by WARN_UNUSED_RESULT. TEST=all ui-based BUG=none Review URL: http://codereview.chromium.org/1076005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42213 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing Unload UI test until fixed.creis@chromium.org2010-03-171-1/+4
| | | | | | | | | | TBR=stuartmorgan BUG=34827 TEST=UnloadTest.CrossSiteInfiniteUnloadAsyncInputEvent Review URL: http://codereview.chromium.org/1000009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41859 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a timeout issue in RenderWidgetHost.creis@chromium.org2010-03-171-6/+36
| | | | | | | | | | | | | | | Before, each call to StartHangMonitorTimeout would reset the timer, possibly postponing it indefinitely. BUG=11007 BUG=16535 TEST=RenderWidgetHostTest.DontPostponeHangMonitorTimeout TEST=RenderWidgetHostTest.StopAndStartHangMonitorTimeout TEST=UnloadTest.CrossSiteInfiniteUnloadAsyncInputEvent Review URL: http://codereview.chromium.org/1034001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41844 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Add more NULL-checks to UI tests that were lacking them to avoid ↵phajdan.jr@chromium.org2010-03-111-0/+5
| | | | | | | | | | | crashiness. TEST=none BUG=none Review URL: http://codereview.chromium.org/841002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41273 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a UI test for WebKit fix to beforeunload bug.creis@chromium.org2010-02-101-0/+20
| | | | | | | | | | | The issue with Gmail warnings on cross-site navigations has been fixed upstream, and a recent WebKit DEPS roll pulled it in. This just adds an automated test for it in Chrome. BUG=32615 TEST=UnloadTest.BrowserCloseWithInnerFocusedFrame Review URL: http://codereview.chromium.org/594014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38633 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the part of http://codereview.chromium.org/593018 touching ↵phajdan.jr@chromium.org2010-02-101-4/+17
| | | | | | | | | | | | | | | | unload_uitest.cc The test started to hang mysteriously on Linux Tests(dbg)(1) and I remember some past problems about this test. Would need more investigation. The test is fine on all other platforms and bots, including Linux Tests(dbg)(2). TBR=brettw TEST=stop hanging BUG=none Review URL: http://codereview.chromium.org/597020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38611 0039d316-1c4b-4281-b951-d872f2087c98
* Make several tests more snappy, less sleepy.phajdan.jr@chromium.org2010-02-101-17/+4
| | | | | | | | | | | Some also say it's good for reducing flakiness. TEST=Changing ui_tests. BUG=none Review URL: http://codereview.chromium.org/593018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38605 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePath in URLRequestMocks.evan@chromium.org2009-10-141-4/+8
| | | | | | | | | BUG=24672 TEST=compiles Review URL: http://codereview.chromium.org/271066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29013 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 18:04:30 +0000