summaryrefslogtreecommitdiffstats
path: root/chrome/browser/unload_uitest.cc
Commit message (Collapse)AuthorAgeFilesLines
* [GTTF] Miscellanous UI tests cleanups:phajdan.jr@chromium.org2010-03-301-2/+2
| | | | | | | | | | | | | | | - use built-in timeouts instead of "inventing" them in each test case - avoid unneeded checks and operations - use automation calls more effectively - use FLAKY mark instead of DISABLED to maintain test coverage - split some tests to make the above possible TEST=UI test based BUG=39785 Review URL: http://codereview.chromium.org/1547003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43070 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the CrossSiteInfiniteBeforeUnloadAsync test as flaky as it fails ↵ananta@chromium.org2010-03-261-1/+2
| | | | | | | | | | | | | | | | randomly on the valgrind Linux builder. It appears that this was already marked flaky in revision 42358. I synced to head and still can't get that change. Bug=39057 TBR=amit Review URL: http://codereview.chromium.org/1468002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42826 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a test which has been failing regularly on the valgrind UI bot as FLAKY_.eroman@chromium.org2010-03-231-1/+3
| | | | | | | | BUG=39057 Review URL: http://codereview.chromium.org/1074010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42358 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce number of automation methods ending with WithTimeout.phajdan.jr@chromium.org2010-03-221-1/+1
| | | | | | | | | | | | | | | | | | | | | They are just too easy to misuse. People started inventing their own hardcoded timeouts all over the place. Also, the is_timeout return parameter was not checked consistently. Additionally, some calls actually had no timeout at all, making hangs possible. This change also removes useless DLOG statements. We should get the required info from the ASSERT/EXPECT macros in test code, which is quite well checked by WARN_UNUSED_RESULT. TEST=all ui-based BUG=none Review URL: http://codereview.chromium.org/1076005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42213 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing Unload UI test until fixed.creis@chromium.org2010-03-171-1/+4
| | | | | | | | | | TBR=stuartmorgan BUG=34827 TEST=UnloadTest.CrossSiteInfiniteUnloadAsyncInputEvent Review URL: http://codereview.chromium.org/1000009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41859 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a timeout issue in RenderWidgetHost.creis@chromium.org2010-03-171-6/+36
| | | | | | | | | | | | | | | Before, each call to StartHangMonitorTimeout would reset the timer, possibly postponing it indefinitely. BUG=11007 BUG=16535 TEST=RenderWidgetHostTest.DontPostponeHangMonitorTimeout TEST=RenderWidgetHostTest.StopAndStartHangMonitorTimeout TEST=UnloadTest.CrossSiteInfiniteUnloadAsyncInputEvent Review URL: http://codereview.chromium.org/1034001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41844 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Add more NULL-checks to UI tests that were lacking them to avoid ↵phajdan.jr@chromium.org2010-03-111-0/+5
| | | | | | | | | | | crashiness. TEST=none BUG=none Review URL: http://codereview.chromium.org/841002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41273 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a UI test for WebKit fix to beforeunload bug.creis@chromium.org2010-02-101-0/+20
| | | | | | | | | | | The issue with Gmail warnings on cross-site navigations has been fixed upstream, and a recent WebKit DEPS roll pulled it in. This just adds an automated test for it in Chrome. BUG=32615 TEST=UnloadTest.BrowserCloseWithInnerFocusedFrame Review URL: http://codereview.chromium.org/594014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38633 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the part of http://codereview.chromium.org/593018 touching ↵phajdan.jr@chromium.org2010-02-101-4/+17
| | | | | | | | | | | | | | | | unload_uitest.cc The test started to hang mysteriously on Linux Tests(dbg)(1) and I remember some past problems about this test. Would need more investigation. The test is fine on all other platforms and bots, including Linux Tests(dbg)(2). TBR=brettw TEST=stop hanging BUG=none Review URL: http://codereview.chromium.org/597020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38611 0039d316-1c4b-4281-b951-d872f2087c98
* Make several tests more snappy, less sleepy.phajdan.jr@chromium.org2010-02-101-17/+4
| | | | | | | | | | | Some also say it's good for reducing flakiness. TEST=Changing ui_tests. BUG=none Review URL: http://codereview.chromium.org/593018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38605 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePath in URLRequestMocks.evan@chromium.org2009-10-141-4/+8
| | | | | | | | | BUG=24672 TEST=compiles Review URL: http://codereview.chromium.org/271066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29013 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable UnloadTest.BrowserCloseBeforeUnload* tests now that they are ↵dglazkov@chromium.org2009-09-251-2/+2
| | | | | | | | | | | | | | passing again. The http://trac.webkit.org/changeset/48732 fixed it. TBR=senorblanco TEST=none BUG=22696 Review URL: http://codereview.chromium.org/242006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27192 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable BrowserCloseBeforeUnload* tests while I am working on ↵dglazkov@chromium.org2009-09-241-2/+2
| | | | | | | | | | | | fixing them. TBR=thomasvl TEST=none BUG=none Review URL: http://codereview.chromium.org/222023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27097 0039d316-1c4b-4281-b951-d872f2087c98
* Disable two ui_tests on linux after a WebKit merge.paul@chromium.org2009-09-221-0/+2
| | | | | | | | BUG=22696 TEST=Covered by ui_tests. Review URL: http://codereview.chromium.org/211053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26868 0039d316-1c4b-4281-b951-d872f2087c98
* Don't hardcode the timeout in the unload ui test.estade@chromium.org2009-08-311-1/+1
| | | | | | | | | The too-short timeout was making it leak in valgrind. BUG=20617 Review URL: http://codereview.chromium.org/180044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24919 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up lines longer than 80 chars under src/chrome/browser. mark@chromium.org2009-08-171-1/+2
| | | | | | | | | | | | | | | | | | | Command: awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' *.cc *.h # recursive find . -type f \( -name '*.cc' -o -name '*.h' \) -exec awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' {} \; Patch by Pierre-Antoine LaFayette <pierre.lafayette@gmail.com> BUG=None TEST=None Code review URL: http://codereview.chromium.org/164566 Review URL: http://codereview.chromium.org/171066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23583 0039d316-1c4b-4281-b951-d872f2087c98
* Move mock url request classes to a location when browser tests will be able ↵phajdan.jr@chromium.org2009-07-301-1/+1
| | | | | | | | | | | to use them too. TEST=none BUG=none Review URL: http://codereview.chromium.org/160366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22056 0039d316-1c4b-4281-b951-d872f2087c98
* Sprinkle some defensiveness into the UI tests so that they don't explode if ↵stuartmorgan@chromium.org2009-07-071-1/+3
| | | | | | | | | | the proxy doesn't respond (e.g., due to a timeout). BUG=none TEST=Hopefully the Mac valgrind bots will more reliably run all their tests (although there are likely more issues like this lurking). Review URL: http://codereview.chromium.org/149281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20096 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the failing UI test. I filed a P1 bug on it.brettw@chromium.org2009-05-291-1/+4
| | | | | | Review URL: http://codereview.chromium.org/114063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17194 0039d316-1c4b-4281-b951-d872f2087c98
* Make automation proxy objects to ref_counted. That allows to process async ↵stoyan@chromium.org2009-05-281-7/+7
| | | | | | | | | | | notifications directly in channel background thread. Add support for listener-less ChannelProxy. BUG=none TEST=none Review URL: http://codereview.chromium.org/113722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17093 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: enable unload ui tests, which pass after r15025 (and again after r15332).estade@chromium.org2009-05-071-6/+0
| | | | | | Review URL: http://codereview.chromium.org/99294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15572 0039d316-1c4b-4281-b951-d872f2087c98
* Move: drag_drop_types, favicon_size, icon_util, insets, path, ↵ben@chromium.org2009-05-061-1/+1
| | | | | | | | | message_box_flags, os_exchange_data to src/app http://crbug.com/11387 Review URL: http://codereview.chromium.org/115012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15371 0039d316-1c4b-4281-b951-d872f2087c98
* Second attempt at cleaning up handling of --disable-popup-blocking. I ↵pkasting@chromium.org2009-04-291-19/+30
| | | | | | | | | didn't realize that now window.open() will result in a popup with this flag, where before it resulted in a tab. This necessitated changes to a test that expected one window and two tabs to expect two windows each with one tab. I also fixed the test to not crash when some expectations were not met (by using ASSERT_ instead of EXPECT_), and to properly use (expected, actual) instead of (actual, expected). Review URL: http://codereview.chromium.org/99203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14886 0039d316-1c4b-4281-b951-d872f2087c98
* Convert Windows Sleep to PlatformThread::Sleepevan@chromium.org2009-04-281-5/+3
| | | | | | | | | | | | First stage to make tests/others cross-platform. BUG=None TEST=Ran tests successfully (windows) Review URL: http://codereview.chromium.org/63113 Patch from Mohamed Mansour <m0.interactive@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14688 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r14620 which was a rollback of r14549 and r14508. Thistc@google.com2009-04-271-7/+21
| | | | | | | | | | | | change re-enables the ui tests. Since jam re-enabled some tests, I had to #ifdef around 4 tests that are not shutting down cleanly on linux. It looks like we have renderers that aren't shutting down properly (pegged at 100% cpu). Review URL: http://codereview.chromium.org/100061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14680 0039d316-1c4b-4281-b951-d872f2087c98
* Speculatively roll back r14549 and r14508. The chrome browsertc@google.com2009-04-271-17/+7
| | | | | | | | | | | | process is pegged at 100% cpu after ui_tests has exited. Seeing if this is the cause. Will re-roll forward if it's not. TBR=estade Review URL: http://codereview.chromium.org/100047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14620 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: implement automation for modal dialogs.agl@chromium.org2009-04-261-1/+1
| | | | | | | | | | | | | | | | | The Linux ui_tests are currently red because BrowserCloseBeforeUnloadOK and BrowserCloseBeforeUnloadCancel are failing. This is because we didn't implement several automation functions regarding modal dialogs and someone obviously wrote a test which needed them. So this is a TBR in order to green the tree. TBR=tony http://codereview.chromium.org/99032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14549 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sudden termination after the latest WebKit merge.jam@chromium.org2009-04-251-2/+44
| | | | | | | | BUG=10927 Review URL: http://codereview.chromium.org/93104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14517 0039d316-1c4b-4281-b951-d872f2087c98
* Port unload_uitest.cc and enable some of the tests on linux.estade@chromium.org2009-04-241-7/+17
| | | | | | | | Make WaitForSingleProcess respect base::kNoTimeout (which is equivalent to INFINITE on windows). Review URL: http://codereview.chromium.org/99008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14508 0039d316-1c4b-4281-b951-d872f2087c98
* Merge: chromium side [42671:42725]levin@chromium.org2009-04-231-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | Rebaselines: http://trac.webkit.org/changeset/42722 resulted in LayoutTests/editing/inserting/insert-3907422-fix.html LayoutTests/editing/pasteboard/paste-text-015.html LayoutTests/editing/style/font-family-with-space.html http://trac.webkit.org/changeset/42723 resulted in LayoutTests/editing/selection/select-all-iframe.html LayoutTests/svg/custom/pointer-events-path.svg http://trac.webkit.org/changeset/42716 resulted in LayoutTests/fast/dom/HTMLSelectElement/named-options.html http://trac.webkit.org/changeset/42725 Broke the close event behavior and resulted in disabling these ui tests: * BrowserCloseBeforeUnloadOK and * BrowserCloseBeforeUnloadCancel Review URL: http://codereview.chromium.org/92051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14291 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r14146 which refactors DialogButton into cross platformtc@google.com2009-04-211-5/+5
| | | | | | | | | | code. This is the same as the last change except I renamed class MessageBox to class MessageBoxFlags to avoid conflicting with the same name in windows.h. Review URL: http://codereview.chromium.org/87065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14159 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor DialogDelegate so the DialogButton enum is in cross platform"tc@google.com2009-04-211-5/+5
| | | | | | | | | | | | This reverts commit r14146. MessageBox is redefined to MessageBoxW by windows. I need to rename the class. Review URL: http://codereview.chromium.org/87064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14147 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor DialogDelegate so the DialogButton enum is in cross platformtc@google.com2009-04-211-5/+5
| | | | | | | | | | | | | | | | | code. This is mostly a find & replace in our code to use the new location of the enum. I also deleted some GetDialogButtons methods in child classes because they were identical to the parent version in DialogDelegate. This will allow more code to be enabled on linux/mac in the automation provider. Review URL: http://codereview.chromium.org/88008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14146 0039d316-1c4b-4281-b951-d872f2087c98
* Move windowing related objects into chrome/views/window subdir.ben@chromium.org2009-03-171-1/+1
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/42272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11819 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run unload tests that hang the renderer in single-process mode, since ↵jam@chromium.org2009-03-061-0/+16
| | | | | | | | now the browser thread waits for the renderer thread on shutdown. Review URL: http://codereview.chromium.org/39245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11093 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes CRLF and trailing white spaces.maruel@chromium.org2009-03-051-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
* Run the unload tests in single process mode, after my fix to single process ↵jam@chromium.org2009-02-281-35/+0
| | | | | | | | | mode. BUG=7933 Review URL: http://codereview.chromium.org/27311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10680 0039d316-1c4b-4281-b951-d872f2087c98
* blacklist some more tests in single processjam@chromium.org2009-02-211-0/+15
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10146 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor code from RenderThread and PluginThread and move it to ChildThread. ↵jam@chromium.org2009-02-211-0/+20
| | | | | | | | | | | ChildProcess now owns the ChildThread, which removes duplicate code and simplifies things. Clean up ChildProcess, there really was no need for all the templates and statics in it and its subclasses. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10080 Review URL: http://codereview.chromium.org/21502 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10144 0039d316-1c4b-4281-b951-d872f2087c98
* Make CommandLine into a normal object, with some statics for getting at the ↵evan@chromium.org2009-01-211-4/+4
| | | | | | | | | | | current process's command line. One explicit goal of this change is to *not* deal with the string/wstring issues at the API on POSIX; the functions are the same as before, which means they remain as broken as before. (I did try to fix the internals, though, so migrating the callers is now possible by adding platform-appropriate hooks.) Review URL: http://codereview.chromium.org/18248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8347 0039d316-1c4b-4281-b951-d872f2087c98
* Add some initial before unload tests. We still need testsojan@google.com2008-12-171-11/+115
| | | | | | | for multiple tabs with beforeunload/unload handlers. Review URL: http://codereview.chromium.org/14085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7122 0039d316-1c4b-4281-b951-d872f2087c98
* Move to using data URLs for unload tests and generallyojan@google.com2008-12-111-28/+95
| | | | | | | | cleanup the unload tests in preparation for adding in tests for beforeunload. Review URL: http://codereview.chromium.org/14017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6839 0039d316-1c4b-4281-b951-d872f2087c98
* Changes UnloadUITest to navigate to last URL synchronously in hopes ofsky@google.com2008-11-131-3/+4
| | | | | | | | | | | | | making ui test more consistent. I suspect I could get the same effect by changing the last sleep to kMaxTestExecutionTime, but seems best to use the sync function here. TEST=none BUG=none Review URL: http://codereview.chromium.org/10692 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5354 0039d316-1c4b-4281-b951-d872f2087c98
* Enable unload UI tests again, but don't run them for single-process.ojan@google.com2008-11-061-4/+21
| | | | | | Review URL: http://codereview.chromium.org/9464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4906 0039d316-1c4b-4281-b951-d872f2087c98
* Disable new tests that are failing on buildbot.ojan@google.com2008-11-061-4/+4
| | | | | | Review URL: http://codereview.chromium.org/9446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4861 0039d316-1c4b-4281-b951-d872f2087c98
* Bandaid patch so that we continue with crosssite navigations instead of ↵ojan@google.com2008-11-061-0/+102
closing the tab if the beforeunload /unload handler hangs. This patch does the right user-visible behavior, but I'm not a huge fan of the plumbing necessary to make it work. Totally open to cleanup suggestions. There's also currently one bug that I haven't been able to pinpoint in the UI test. It only treats the first UI test of the four that I run as a cross-site navigation. No matter which test I run first. I wonder if there is some state I should be setting/clearing before/after each test run? Also there's a DHECK that we hit that the UI test exposed. I 'm not sure it's a case that a user could actually hit though and it's not new with this code, so I added a TODO. Can I get help from a mac person on adding the UI test to the xcode project? BUG=3198 Review URL: http://codereview.chromium.org/8920 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4855 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 20:49:52 +0000