summaryrefslogtreecommitdiffstats
path: root/chrome/browser/user_data_manager.h
Commit message (Collapse)AuthorAgeFilesLines
* Fix issue 32106xiyuan@chromium.org2010-02-251-0/+6
| | | | | | | | | | | | | | | | | | Issue 32106 happens when user creates a browser window without creating desktop shortcut. In this case, Windows does not have sufficient relaunching info to support pinning the browser window. The fix is to create a shortcut in "User Pinned" folder which Win7 watches and would get relaunch info from it. Also fix a minor bug in win_util::SetAppIdForWindow that would make the function only work for Win7 but not above. BUG=32106 TEST=Verify fix for 32106. See comemnts #1 and #5 for repro steps. Review URL: http://codereview.chromium.org/660038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39963 0039d316-1c4b-4281-b951-d872f2087c98
* Fix racing condition that blocks profiles menu showing upxiyuan@chromium.org2009-12-221-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | Chrome should show profiles menu when "enable-udd-profiles" is supplied on command line. This is broken while refactoring app menu code from ToolbarView into AppMenuModel. Previously, the profile submenu model is kept in ToolbarView and profiles menu would show up on 2nd time app menu showing up. After the refactoring, profile menu is moved into AppMenuModel, which is re-created everytime before we show app menu. In AppMenuModel, it requests profiles data from GetProfilesHelper which will later invoke OnGetProfilesDone. However, app menu is created on the UI thread and blocks the callback until it shows up. This makes the profiles mneu empty. The fix is to leverage an existing profile list in BrowserProcess. When "enable-udd-profiles" is on, BrowserInit will get the initial profile list and NewProfileDialog will refresh it if user creates new profile. And AppMenuModel just use the list to populate the profile menu. BUG=30417 TEST=Verify profiles menu exists when "enable-udd-profiles" is on command line for issue 30417. Review URL: http://codereview.chromium.org/503062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35166 0039d316-1c4b-4281-b951-d872f2087c98
* Ninth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-071-0/+4
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/372013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31357 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a forward declaration that is not being used.jhawkins@chromium.org2009-02-201-1/+0
| | | | | | Review URL: http://codereview.chromium.org/20528 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10075 0039d316-1c4b-4281-b951-d872f2087c98
* Make user_data_manager.cc compile on Posix.jhawkins@chromium.org2009-02-201-3/+1
| | | | | | Review URL: http://codereview.chromium.org/20525 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10074 0039d316-1c4b-4281-b951-d872f2087c98
* I'm relanding the UserDataManager leak fix. I didn't realize we hadsky@google.com2009-01-231-1/+1
| | | | | | | | | | | | | stubs for mac which needed to be updated too. This time I'll wait for the bots to finish compiling before committing. BUG=none TEST=none TBR=munjal Review URL: http://codereview.chromium.org/18566 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8587 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts my user data manager change as it breaks the mac buildbot.sky@google.com2009-01-231-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=munjal Review URL: http://codereview.chromium.org/18564 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8584 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak of UserDataManager on shutdown.sky@google.com2009-01-231-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/18714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8581 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium-MultiProfile-Prototypemunjal@chromium.org2008-12-031-0/+149
Summary ======= Implement a prototype of multiple profiles in Chrome by utilizing the functionality of user-data-dir command line flag that already exists. A profile in this case is an umbrella for all user data including cookies, history, bookmarks, settings, etc. Each profile gives the user a separation of all these data elements. User Interface ============== - Wrench > "New window in profile" menu item, with sub-menu items. This new menu item has sub menu items for each existing profile, for up to 9 profiles, and one more sub menu item to launch a window in a new profile. The 9 sub-menu items also have the accelerators like CTRL + SHIFT + 1, CTRL + SHIFT + 2, etc. If there are more than 9 profiles, we will also show an extra sub-menu item, "Other...". - New Profile dialog box This dialog box is shown to the use when (s)he clicks Wrench > New window in profile > <New Profile>. It lets the user specify a profile name, and also shows a checkbox to create a desktop shortcut to launch Chrome in that profile. - Choose profile dialog box This dialog box lets the user select a profile from a drop down to open a new window in. It also has an item <New Profile> in the drop down, selecting which will show the new profile dialog box mentioned above. CTRL + M shortcut also launches this dialog box. Code Organization ================= chrome\browser\user_data_dir_profile_manager.h/.cc: This class provides an abstraction of profiles on top of the user data dir command line flag. chrome\browser\views\user_data_dir_new_profile_dialog.h/.cc New profile dialog box code. chrome\browser\views\user_data_dir_profiles_dialog.h/.cc Choose profile dialog box code. Review URL: http://codereview.chromium.org/12895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6333 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-04-02 20:13:37 +0000