| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update references to use headers in chrome/browser/ui/views.
Update copyright dates in affected files.
/chrome/browser/ui/views/constrained_html_delegate_win.cc
Add space before 'private' label (presubmit warning)
/chrome/browser/ui/views/toolbar_view.cc
Add space before 'cleanup' label (presubmit warning)
BUG=69082
TEST=Compiling...
Review URL: http://codereview.chromium.org/6204002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4694005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2809036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
lost focus to a child window. This is used to prevent
closing browser/page action bubble when they lose focus
to a select popup or alert box.
BUG=37784
TEST=Start Chrome with extensions that have a page action
and browser action that contains selects (combobox)
and a way to show an alert box. Verify that showing
the select popup or the alert dialog does not cause
the bubble to close.
Review URL: http://codereview.chromium.org/899002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
an extension popup was causing the popup to lose focus and
be dismissed, causing other problems.
This CL fixes it on Windows with the following:
- the message box is now parented to the popup, not the tab
- the popup is not disimissed when losing focus to a window for
which it is the owner.
BUG=29147
TEST=Create an extension with a popup that contains a combo-box
and a button to show an alert and confirm box. Click on the
combobox and select an item. Click the button to show the
alert and confirm message box. The popup should not be closed
when you do that.
Review URL: http://codereview.chromium.org/650045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/593111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/577015 for the review status of this CL.
BUG=None
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/600101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=30358
TEST=see bug
Review URL: http://codereview.chromium.org/501179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changes for a child window of the popup, as it is the case
with select popups.
BUG=28110
TEST=Make sure extension popups are still working as expected.
Open an extension popup with a select popup (combo box)
in it. Click on the select to bring up its popup, the
extension popup should stay opened.
Review URL: http://codereview.chromium.org/459005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
action popup.
With this change, select elements still don't work correctly
with page actions: when you try to use them, the page action
popup disappears. However, at least now, it doesn't crash.
BUG=27576
TEST=Install extension in related bug. Navigate to any site
and click page action. Browser should not crash.
Review URL: http://codereview.chromium.org/399032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the really hard ones which will need actual review instead of rubber-stamping.)
Review URL: http://codereview.chromium.org/386026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
popup.
BUG=23833,23835
TEST=none
Review URL: http://codereview.chromium.org/259065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
window that extends below a browser action button when the browser is clicked. When it loses focus, it is automatically dismissed.
BUG=23596
TEST=none
Review URL: http://codereview.chromium.org/258011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15494
TEST=none
Review URL: http://codereview.chromium.org/210031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it less susceptible to crashes in certain use cases.
Remove a delay in destroying the widget that was added to work around
the old crash.
BUG=18248
TEST=none
Review URL: http://codereview.chromium.org/211027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
change for this is to get rid of the concept of a "current" toolstrip and the idea that there's only one handle around. Instead, each toolstrip has its own handle and each can be displaying it independently. There's some initial work for moles in there, but it's disabled since this will require some other plumbing to hook up properly.
Review URL: http://codereview.chromium.org/155192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to happen or not.
ExtensionShelf doesn't need mirroring since View methods already provide most of the RTL functionality.
BUG=http://crbug.com/11880
TEST=Run chrome --lang=he and add 1+ extensions, and see if the handle is in proper position.
Review URL: http://codereview.chromium.org/149045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
getting the mechanics of the shelf handle and the dragging correct. Part 2 will actually allow the order to be changed.TEST=hover over an extension toolstrip, grab the handle and drag. release.
Review URL: http://codereview.chromium.org/119103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
that are attached to browser UI. I needed another one of these for the extension shelf, and figured I'd try to make one that was generic. Ideally, we'd do more refactoring so that StatusBubbles, InfoBubble, etc. could all share some common code.
BUG=none
TEST=none (I'd love some suggestions on what to put into a unit test here)
Review URL: http://codereview.chromium.org/113486
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16277 0039d316-1c4b-4281-b951-d872f2087c98
|