| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
deleted, in an attempt to fix a crasher.
BUG=46757
TEST=See bug
Review URL: http://codereview.chromium.org/3026060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome: create an option for using libcros provided by the system; fix all
includes referring to libcros to not include third_party/
* Headers fix is needed to support using system libcros (installed to /usr/include)
* All includes are "", and therefore a local variant in third_party/cros/ is
always preferred, but system will also get picked up as a secondary target
* Fixed chrome/browser/chromeos/cros/synaptics_library.h comments to better
reflect the header placement
* Added a variable system_libcros defaulting to 0
* Gotten rid of duplicate cros_api.gyp
* Changed both places to either link against cros_api or libcrosapi
TEST=build in the following scenarios:
1) libcros not installed, libcros sources in third_party/, !defined system_libcros
- sucess
2) installed libcros, put #error into /usr/include/cros/chromeos_cros_api.h, repeat 1)
- success
3) BUILD_DEFINES+=system_libcros=1, removed libcros from third_party, repeat 2)
- fail (on #error in chromeos_cros_api.h)
4) Installed clean libcros, repeat 3)
- success
Review URL: http://codereview.chromium.org/3043010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We currently have two copies of these enums, one in Chrome
and one in Chrome OS. I'm switching us to have a single
copy in the libcros repo.
This reverts r45955, which reverted r45952. I've added
third_party/cros to the browser directory's DEPS file to fix
the checkdeps.py failure.
http://codereview.chromium.org/1811002/show contains the
review of the original change.
BUG=none
TEST=built it and ran checkdeps.py manually
Review URL: http://codereview.chromium.org/1705017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1692017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We currently have two copies of these enums, one in Chrome
and one in Chrome OS. I'm switching us to have a single
copy in the libcros repo.
BUG=none
TEST=built it
Review URL: http://codereview.chromium.org/1811002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
lost focus to a child window. This is used to prevent
closing browser/page action bubble when they lose focus
to a select popup or alert box.
BUG=37784
TEST=Start Chrome with extensions that have a page action
and browser action that contains selects (combobox)
and a way to show an alert box. Verify that showing
the select popup or the alert dialog does not cause
the bubble to close.
Review URL: http://codereview.chromium.org/899002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WmIpc.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/646079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/577015 for the review status of this CL.
BUG=None
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/600101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=30358
TEST=see bug
Review URL: http://codereview.chromium.org/501179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Creating RenderWidgetHostView for gtk
* Fix assertion failure in BrowserBubble
* Don't change the window size if the size is empty, which causes gtk assertion error.
With this change, most of extension tests in browser passes except for toolstrip.
Given that toolstrip is obsolete, may be we should just remove it from test.
BUG=None
TEST=Run browesr_tests. All tests for extension must pass except for ExtensionApiTest.Toolstrip
Review URL: http://codereview.chromium.org/390006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
window that extends below a browser action button when the browser is clicked. When it loses focus, it is automatically dismissed.
BUG=23596
TEST=none
Review URL: http://codereview.chromium.org/258011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it less susceptible to crashes in certain use cases.
Remove a delay in destroying the widget that was added to work around
the old crash.
BUG=18248
TEST=none
Review URL: http://codereview.chromium.org/211027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/112093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=none
TEST=none
TBR=ben
Review URL: http://codereview.chromium.org/115948
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17246 0039d316-1c4b-4281-b951-d872f2087c98
|