summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views/frame
Commit message (Collapse)AuthorAgeFilesLines
* Fix a whole category of frame switching bugs relating to the window z-order ↵ben@chromium.org2009-10-152-10/+34
| | | | | | | | | | | | | | | | | | | | | | | | | being screwed up screwed up when DWM is toggled or themes are installed or reset. The first part of the fix was to remove the hack I put in to hide then show the window while the frame type change occurs. The hack was to work around the fact that upon returning to glass from non-glass, the area identified by BrowserFrameWin::OnNCCalcSize as client was filled with solid black vs. transparent black. I don't know why this fix works, but returning a client size for the opaque frame as 1 pixel different to the window rect causes the blackness bug to not occur, so that's what I did (in addition to removing the hack). I also had to put in a couple of fixes to accommodate the pixel turd we gain in the opaque frame. I renamed ChangeSize to LayoutRootView. When we're using the opaque frame, since the views system is rendering the entire content of the window all the time I always size the widget to the window rect rather than the client rect. http://crbug.com/15424 TEST=change the frame type by: - turning on/off aero glass - installing a theme, then resetting - running an app that forces the DWM off, e.g. the O3D plugin The frame should appear correct after the transition in either direction, and window z-order should be preserved. Review URL: http://codereview.chromium.org/266013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29164 0039d316-1c4b-4281-b951-d872f2087c98
* Show "Loading" bubble while loading a theme.avi@chromium.org2009-10-152-0/+17
| | | | | | | | | BUG=http://crbug.com/22219 TEST=load a theme, see "Loading..." Review URL: http://codereview.chromium.org/267031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29121 0039d316-1c4b-4281-b951-d872f2087c98
* Hides the control buttons for browser when maximized on chromesky@chromium.org2009-10-142-11/+39
| | | | | | | | | | | | os. maximized is the default state on chrome os, so this effectively gives us no window controls just as we have now. BUG=none TEST=none Review URL: http://codereview.chromium.org/273055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29061 0039d316-1c4b-4281-b951-d872f2087c98
* Gets the full screen bubble to work on views/gtk.sky@chromium.org2009-10-142-5/+14
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/264059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29027 0039d316-1c4b-4281-b951-d872f2087c98
* Add ChromeOS controls to BrowserViewoshima@chromium.org2009-10-142-3/+33
| | | | | | | | | | | | * Added BrowserExtender class to isolate ChromeOS specific controls from BrowserView * Extender currently adds main menu and status area view only. * System menu is not enabled because using SetContextMenuController on NonClientFrameView didn't work. I need to investigate how. * PanelController support will be added in next CL. Review URL: http://codereview.chromium.org/269078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29021 0039d316-1c4b-4281-b951-d872f2087c98
* Couple of views/gtk tweaks:sky@chromium.org2009-10-132-0/+6
| | | | | | | | | | | | | . Adds accelerator to list of files compiled on views/gtk. . Adds function to Screen to get monitor bounds from a window. . Adds BrowserFrameGtk::GetAccelerator to match windows. BUG=none TEST=none Review URL: http://codereview.chromium.org/275005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28902 0039d316-1c4b-4281-b951-d872f2087c98
* WidgetWin was an accelerator target, it does not need to.jcampan@chromium.org2009-10-132-6/+0
| | | | | | | | BUG=None TEST=make sure Esc still works in the bookmark bubble and that accelerators work as expected. Review URL: http://codereview.chromium.org/271067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28842 0039d316-1c4b-4281-b951-d872f2087c98
* include CHROMEOS files and defintions in TOOLKIT_VEIWS build.oshima@chromium.org2009-10-121-0/+3
| | | | | | | | | | | | | | | | | * changed gyp files so that all files compiled for chrome os will be also compiled when toolkit_views==1 * changed to define OS_CHROMEOS when toolkit_views==1 * changed TabOverbiewMessageListener to use BrowserView instead of BrowserWindowGtk when toolkit_views==1 I left one for CHROME_NOTIFY_FLOATING_TAB_OVER_TOPLEVEL b/c i couldn't figure out how to get gdkwindow from xid. Looks like I need to register it somewhere Note: Nicolas updated trybot and buildbot to include chromeos dependency, so this all should compile fine. BUG=none TEST=run views unit test and browser. Review URL: http://codereview.chromium.org/262027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28764 0039d316-1c4b-4281-b951-d872f2087c98
* Move native_widget_types and gtk_native_view_id_manager from base/gfx tobrettw@chromium.org2009-10-111-1/+1
| | | | | | | | | | | | app/gfx in preparation for removing the base_gfx project. This also moves base/window_impl.cc to app/win/window_impl because this file shouldn't be in base. TEST=none BUG=none Review URL: http://codereview.chromium.org/273017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28691 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: use NtpBackgroundUtil to draw detached bookmark bar.estade@chromium.org2009-10-091-6/+21
| | | | | | | | BUG=23836 Review URL: http://codereview.chromium.org/268027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28618 0039d316-1c4b-4281-b951-d872f2087c98
* Converts info bubbles on views/gtk from popups to normal windows tosky@chromium.org2009-10-072-2/+3
| | | | | | | | | | | avoid the focus problems. BUG=none TEST=none Review URL: http://codereview.chromium.org/246099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28228 0039d316-1c4b-4281-b951-d872f2087c98
* Find-in-bar would steal focus when switching tab.jcampan@chromium.org2009-10-021-2/+0
| | | | | | | | BUG=23296 TEST=See bug. Review URL: http://codereview.chromium.org/243073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27901 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the Linux views buildjam@chromium.org2009-10-021-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27822 0039d316-1c4b-4281-b951-d872f2087c98
* Don't send tab switching/killing/creating keyboard accelerators to pages. ↵jam@chromium.org2009-10-022-0/+21
| | | | | | | | | | This avoids tabs maliciously preventing closing using ctrl+f4/ctrl+w/alt+f4, and also hung/slow renderers from making tab cycling sluggish. BUG=5496 TEST=added ui test Review URL: http://codereview.chromium.org/224023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27814 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix the AcceleratorPressed override to match the declaration in ↵jhawkins@chromium.org2009-10-012-6/+9
| | | | | | | | | | | WidgetWin. CID=4190 BUG=none TEST=none Review URL: http://codereview.chromium.org/255031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27758 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding keyboard code refactoring:jcampan@chromium.org2009-09-291-5/+7
| | | | | | | | | | | | | | | | http://codereview.chromium.org/248010/show Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to several places where I had to switch from VK_ to VKEY_. Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly. BUG=None TEST=Make sure short-cuts works as expected, especially in the omnibox. Review URL: http://codereview.chromium.org/251020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27444 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27412 it breaks the toolkit views Linux build.jcampan@chromium.org2009-09-281-7/+5
| | | | | | | TBR=sky Review URL: http://codereview.chromium.org/254005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27416 0039d316-1c4b-4281-b951-d872f2087c98
* Change the way the NonClientView handles forcing the native frame for ↵ben@chromium.org2009-09-289-45/+65
| | | | | | | | | | | | | popups/app windows. Rather than carrying state in a force_native_frame_ member it uses a virtual method AlwaysUseNativeFrame analogous to AlwaysUseCustomFrame. This makes me a little happier. BUG=none TEST=On a vista capable system, test that when a theme is installed, popups and app frames are rendered with the native frame. Test that constrained windows (e.g. HTTP basic auth) are rendered with the custom frame. Without a theme installed, test that all windows have a native frame except constrained windows. With Vista Basic system setting, verify that all windows have a custom frame, including constrained windows. Review URL: http://codereview.chromium.org/200146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27413 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to ↵jcampan@chromium.org2009-09-281-5/+7
| | | | | | | | | | | | several places where I had to switch from VK_ to VKEY_. Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly. BUG=None TEST=Make sure short-cuts works as expected, especially in the omnibox. Review URL: http://codereview.chromium.org/248010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27412 0039d316-1c4b-4281-b951-d872f2087c98
* [Relanding erg's change with fix for toolkit_views shortcuts and jcampan@chromium.org2009-09-251-11/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | interactive ui tests. Note that this was originally reviewed in http://codereview.chromium.org/217022/show I originally Elliot suggestion of replacing the usage of int for keycode with the bae::Keycode type, but that led to the CL getting out of hands (as this is used in many different places). So this is only the patch set 1 of that CL, I'll replace the type in another CL] Use windows keycodes under linux (and all non-windows platforms). This fixes any place where we use a VKEY_* (RenderWidgetHost, for example) under Linux, but breaks accelerators in TOOLKIT_VIEWS which relied on this wrong behaviour. Previously, keyboard_codes_linux defined all the VKEY_* constants as their GDK_* counterparts, which is wrong since the VKEY_* are supposed to resolve to windows key codes. BUG=22551 TEST=Make sure accelerators still work as expected on Chrome Linux and Chrome Linux with toolkit views. Test when the the accelerators with the focus in the location bar and also with the focus on the page. Review URL: http://codereview.chromium.org/235025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27284 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. Cleanup related to OOP Profile Importjeremy@chromium.org2009-09-251-0/+1
| | | | | | | | | * Add PROFILE_IMPORT_PROCESS type to ChildProfileInfo. * Other small bits of cleanup. Review URL: http://codereview.chromium.org/220027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27222 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so that you shouldn't be able to get a big fat bookmarksky@chromium.org2009-09-252-0/+5
| | | | | | | | | | | | | | | | | | | bar. This happened because when we changed from needing a bookmarkbar/extension-shelf to not needing one we processed the layout change asynchronously, but could paint immediately and painting always checks the current state. I initially made painting/layout stay in sync with regards to whether they thought the bookmark bar should be shown, which also fixes this, but because we process the change async there was still some noticable jank. Instead I've changed processing of the transition from needing bars to not (or vice-versa) to be synchronous. BUG=22165 TEST=see bug Review URL: http://codereview.chromium.org/219034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27218 0039d316-1c4b-4281-b951-d872f2087c98
* Changes from listening to focus-out/focus-in for active status tosky@chromium.org2009-09-242-12/+5
| | | | | | | | | | | listening for is-active. BUG=none TEST=none Review URL: http://codereview.chromium.org/219016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27071 0039d316-1c4b-4281-b951-d872f2087c98
* Add more view ids and gtk widget names to so gtkparasite istony@chromium.org2009-09-231-0/+1
| | | | | | | | easier to navigate. Review URL: http://codereview.chromium.org/221001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26992 0039d316-1c4b-4281-b951-d872f2087c98
* Fix views build.estade@chromium.org2009-09-231-1/+1
| | | | | | | | TBR=stuartmorgan Review URL: http://codereview.chromium.org/224001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26893 0039d316-1c4b-4281-b951-d872f2087c98
* Download in progress dialog:estade@chromium.org2009-09-231-7/+12
| | | | | | | | | | | - Change hardcoded "Google Chrome" to product name. - Implement for GTK. BUG=21652 Review URL: http://codereview.chromium.org/212051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26891 0039d316-1c4b-4281-b951-d872f2087c98
* Implements a couple of NOTIMPLEMENTEDs in window_gtk and comments onsky@chromium.org2009-09-221-1/+1
| | | | | | | | | | | why we're not going to implement some. BUG=none TEST=none Review URL: http://codereview.chromium.org/207057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26864 0039d316-1c4b-4281-b951-d872f2087c98
* hide toolstrips in full screen modeerikkay@chromium.org2009-09-221-0/+5
| | | | | | | | | BUG=13439 TEST=none Review URL: http://codereview.chromium.org/214045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26809 0039d316-1c4b-4281-b951-d872f2087c98
* allow the handle to be hidden when moles are expandederikkay@chromium.org2009-09-211-2/+5
| | | | | | | | | BUG=15494 TEST=none Review URL: http://codereview.chromium.org/210031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26706 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BrowserFrameWin::OnMoving bad_override coverity error.mattm@chromium.org2009-09-182-2/+2
| | | | | | | | BUG=17104 Review URL: http://codereview.chromium.org/208019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26633 0039d316-1c4b-4281-b951-d872f2087c98
* While fixing bug 22070 (Toolstrip theme background not updated when resizing ↵finnur@chromium.org2009-09-181-1/+0
| | | | | | | | | | | | Chrome window) I added code to trigger repainting the background on resize. This flushed out a problem (Skia exceptions) that was causing the extension tests to become flaky on the bots (bug 22135). I've changed the code to do a deep copy on the subset bitmap we get before passing it down to the renderer, which causes Skia to not go haywire when drawing the background. That makes it possible to fix bug 22070, which now causes the background to be updated on resize. There is also now no need to set the background_needs_repaint_ flag to true before calling Layout. We also don't need to keep track of whether we are detached or not, we just need to monitor the background_needs_repaint_ flag. BUG=22070, 22135 TEST=Monitor the bots and see if the tests become flaky again. Review URL: http://codereview.chromium.org/215017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26526 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionShelf now uses the BookmarkExtensionBackground, just like the ↵finnur@chromium.org2009-09-152-239/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | BookmarkBarView. Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added. Added an interface that both BookmarkBarView and ExtensionShelf implement. This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not. Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions). Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process. Toolstrip text color values are no longer hard-coded but use the color specified in the theme. Decreased the timeouts for showing and hiding the toolstrip handle. Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses. Known issues: Some themes expose the fact that: - The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though. - Didn't spend much time theming the shelf handle (just used the solid color from the theme). - When extension shelf is merged with the bookmark bar, there is a painting artifact (horizontal dotted line) that appears (apparently it was known to appear before this change). BUG=18452, 21272, 21273 TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed. Review URL: http://codereview.chromium.org/204022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26227 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 26184, 26181 and 26178 to fixnsylvain@chromium.org2009-09-152-39/+239
| | | | | | | | | | the compile error on the toolkit builder. TBR:finnur Review URL: http://codereview.chromium.org/203064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26186 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionShelf now uses the BookmarkExtensionBackground, just like the ↵finnur@chromium.org2009-09-142-239/+39
| | | | | | | | | | | | | | | | | | | | | | | | | BookmarkBarView. Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added. Added an interface that both BookmarkBarView and ExtensionShelf implement. This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not. Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions). Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process. Toolstrip text color values are no longer hard-coded but use the color specified in the theme. Decreased the timeouts for showing and hiding the toolstrip handle. Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses. Known issues: Some themes expose the fact that: - The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though. - Didn't spend much time theming the shelf handle (just used the solid color from the theme). BUG=18452, 21272, 21273 TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed. Review URL: http://codereview.chromium.org/203034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26178 0039d316-1c4b-4281-b951-d872f2087c98
* Removes some dead NOTIMPLEMENTEDs and enables some code that no longersky@chromium.org2009-09-141-1/+0
| | | | | | | | | | | needs to be ifdef'd out. BUG=none TEST=none Review URL: http://codereview.chromium.org/196111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26177 0039d316-1c4b-4281-b951-d872f2087c98
* Split the "downloads in progress at exit" confirm dialog text intopaul@chromium.org2009-09-141-13/+45
| | | | | | | | | | | | | | a bold font warning question and a normal font explanation to better map to the Mac UI guidelines. BUG=19755 TEST=Try to exit chrome with a download in progress. The dialog text should have two paragraphs: the first in bold font asking a question, and the second in normal font with an explanation. Review URL: http://codereview.chromium.org/193080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26159 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes the focus remembered across tab switches for Chrome Linux with ↵jcampan@chromium.org2009-09-142-0/+16
| | | | | | | | | | | | | | | toolkit views. It also contains clean-ups and implementation of different minor focus related things. BUG=None TEST=Open several tabs. Focus the location bar for some tabs, the page for others. Make sure that when switching between tabs the focus is restored to the last focused place (location bar or page) for each tab. Also test that deactivating/reactivating the browser window still restores focus properly. Review URL: http://codereview.chromium.org/194041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26153 0039d316-1c4b-4281-b951-d872f2087c98
* Remove jankiness from bookmark animation for --show-extensions-on-top.sidchat@google.com2009-09-081-4/+0
| | | | | | | | | BUG=20927 TEST=none Review URL: http://codereview.chromium.org/192039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25680 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression introduced in dnd refactoring. I removed a check forsky@chromium.org2009-09-084-39/+105
| | | | | | | | | | | | | | the URL that I shouldn't have (it won't be needed at some point, but it is now). BUG=21198 TEST=Select a URL and drag to the tab strip. Make sure you get the drop target and you can drop the text to create a new tab. Do the same with www.google.com, you shouldn't get a drop target. Review URL: http://codereview.chromium.org/202010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25653 0039d316-1c4b-4281-b951-d872f2087c98
* Move the "history is too new" dialog out oftony@chromium.org2009-09-052-0/+22
| | | | | | | | | | | | | chrome/browser/history/history.cc. Instead use a notification that Browser picks up and delegates to BrowserWindow. Include implementations for Windows, Linux GTK+, and Linux Views (sorry, no mac impl). Review URL: http://codereview.chromium.org/200023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25556 0039d316-1c4b-4281-b951-d872f2087c98
* Make the extension shelf appear on the left of the bookmark bar, instead of ↵sidchat@google.com2009-09-041-15/+23
| | | | | | | | | | on the right. BUG=http://www.crbug.com/20929 TEST=none Review URL: http://codereview.chromium.org/198002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25533 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 9867: Activating the previous/next buttons with the keyboard in the find ↵finnur@chromium.org2009-09-032-2/+3
| | | | | | | | | | | | | bar should not change the focus. Add param const Event& event to ButtonPressed, so that recipients can find out more about the event that generated the ButtonPress message. BUG=9687 TEST=Open www.google.com and open Find-in-page, search for 'e'. Press FindNext button with mouse and note that the focus should be on the textfield. Now press Tab twice to put focus on the FindNext button and press SpaceBar a few times. Note that the focus should stay on the FindNext button. Review URL: http://codereview.chromium.org/188016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25367 0039d316-1c4b-4281-b951-d872f2087c98
* Move status area view to the chromeos directory.brettw@chromium.org2009-09-032-409/+0
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/192001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25279 0039d316-1c4b-4281-b951-d872f2087c98
* Infrastructure to allow putting Extension Shelf on top along with Bookmarks.sidchat@google.com2009-09-022-16/+322
| | | | | | | | BUG=http://code.google.com/p/chromium/issues/detail?id=20517 TEST=none Review URL: http://codereview.chromium.org/173613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25236 0039d316-1c4b-4281-b951-d872f2087c98
* Some enhancements as requested to the compact nav bar. The search box looksbrettw@chromium.org2009-09-021-4/+29
| | | | | | | | | | | | | | | larger, back and foward moved to the right, there is a border below the tab strip. Importantly, the compact nav bar can be switched on and off at runtime via the app menu (which creates a new window with it) rather than using the command line flag. BUG=none TEST=none Review URL: http://codereview.chromium.org/171112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25179 0039d316-1c4b-4281-b951-d872f2087c98
* Workaround Skia and Pango measuring font heights differently by asking Pangobrettw@chromium.org2009-09-021-1/+1
| | | | | | | | | | | | | | | | | | for the height that we'll report in the gfx::Font. This seems wrong, but at least things will look reasonable until we find a better solution. This changes the existing height computation code to use ceiling. Even though this is no longer used, it is good to have the correct code for the height computation here so that if we find a better solution, it will be run properly. This also gives more room for the clock in the status area view because the height is now more and we want it to be aligned properly. BUG=none TEST=none Review URL: http://codereview.chromium.org/183044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25131 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk confirm form resubmission dialog.mattm@chromium.org2009-08-312-0/+5
| | | | | | | | | | | Refactor so that the dialog is shown by calling BrowserWindow::ShowRepostFormWarningDialog BUG=19761 TEST=see bug Review URL: http://codereview.chromium.org/174294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24930 0039d316-1c4b-4281-b951-d872f2087c98
* Experiment with dislodging the Extension Shelf and having it only appear on ↵finnur@chromium.org2009-08-302-6/+32
| | | | | | | | | | | the New Tab page. BUG=http://crbug.com/20415 TEST=With the extension toolstrip visible, go to the New Tab page and press Ctrl + Alt + B. Watch the toolstrip merge into the New Tab page and back again into a separate toolstrip (when you press Ctrl + Alt + B again). Also, when you do this on a regular webpage (as opposed to NTP) this should toggle the toolstrip visiblity. Review URL: http://codereview.chromium.org/175017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24864 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Gtk confirm form resubmission dialog." Broke linux views build.mattm@chromium.org2009-08-282-6/+0
| | | | | | | | | | This reverts commit e6ab23c81e56c6b9fbb062bbb090a648e6ebef12. TBR=beng Review URL: http://codereview.chromium.org/183006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24827 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk confirm form resubmission dialog.mattm@chromium.org2009-08-282-0/+6
| | | | | | | | | | | Refactor so that the dialog is shown by calling BrowserWindow::ShowRepostFormWarningDialog BUG=19761 TEST=see bug Review URL: http://codereview.chromium.org/174294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24826 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-09 18:29:05 +0000